- 12 Aug, 2020 40 commits
-
-
Dana Fried authored
See attached bug for the problem statement and some of the rationale for this change. Handles a case where we are not going into immersive mode, but also going fullscreen in a way that the default key to restore the browser is not ESC (as it is for media, etc.) but F11/Fullscreen. In this edge case, on ChromeOS, the message - "Press [F11] to exit full screen" - is displayed and announced to the screen reader. The message uses the default accelerator (which is still F11 on ChromeOS). This could be confusing to users on Chromebooks where there are no physical function keys but there are media keys, one of which is the fullscreen key. We cannot just change the default accelerator to Fullscreen however since the media key is translated to a function key at a lower level; there is no "fullscreen" key as far as Chrome is concerned. To handle this, on ChromeOS only, we substitute the name of the key - "Fullscreen" - for the name of the accelerator. Bug: 1110468 Change-Id: Id0764f3eb68c8dc49baf5cbe156cbd22e66362d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347962Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#797457}
-
Ben Pastene authored
Will update simple_chrome_workflow.md on the CrOS-side of the world in a follow-up. Bug: 937821 Change-Id: I006dde1fcab5ad4a0fc48a5b5f8440a554da1bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350540 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#797456}
-
Mustaq Ahmed authored
Bug: 1113758 Change-Id: I955a8031913e6acf1fe3c5b878e819a2d4a38fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350560 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#797455}
-
Becca Hughes authored
If the Media History database is unrecoverable then we should delete it and start again. Change-Id: I76552537eeec315f66168abbf47c947ee37ecd96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305192Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#797454}
-
Tom Anderson authored
XTest/XRecord include XInput, so we need to get rid of those too if we want to get rid of the macros etc that XInput provides. Depends on WebRTC CL: https://webrtc-review.googlesource.com/c/src/+/180773 BUG=1066670 R=nickdiego,sky Change-Id: Id3b3cb61196cf10bc47976957d8b290877020d5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327373 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#797453}
-
Matt Jones authored
Bug: 1113325 TBR: peconn@chromium.org Change-Id: If61582b64343cdfa6de5f1c152c7d239696e16c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353409Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#797452}
-
Mugdha Lakhani authored
This adds PrerenderTabHelper for WebLayer, which is a WebContentsObserver, and adds logic to create it when TabImpl is created. Some unreachable code has been removed from Chrome's PrerenderTabHelper as well. Bug: 1096088, 1106294 Change-Id: Ifa567096d9901a465104efd955d872ebfc1b4e5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343038 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#797451}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I1ae7fac0faa66a2c4e727f2ac44517118df15c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352524Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797450}
-
Lijin Shen authored
Extend to M92 Bug: NONE Change-Id: I0e2ee3f83ebc6e0e553010ca997ee1493b7dba59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351717 Auto-Submit: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#797449}
-
Garrett Beaty authored
Change-Id: Ic7a6f8d983dba91c4e43f279b112b33fbfc7836c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353017 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#797448}
-
Alex Turner authored
Converts FontMatchingMetrics::PublishIdentifiabilityMetrics() from using the IdentifiabilityDigestHelper to using IdentifiableTokens. Also adds IdentifiableSurface::FromTypeAndToken() to enable use of a Token as the input digest. Finally, reuses the IdentifiabilityMetricBuilder to improve performance. Bug: 1102934 Change-Id: I9b05581f56bfd1205db0086e46cbd5a54e013ca5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321776Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#797447}
-
My Nguyen authored
Update os_languages_page_v2 according to spec at http://go/cros-lang-settings-ux slide 11. Languages menu functions and tests are mostly copied from os_languages_page Current view: http://screen/vZFDtvSXXD9 Note: Both OS search strings and regular OS settings strings haven't received UX writing review yet so they are translateable false and no screenshots are required. Bug: 1113439 Change-Id: I0146ad0e485187171829d08076e9956d6ae281fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345930Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#797446}
-
Donn Denman authored
Adds @google.com to the contextual-search-eng address in flag-metadata.json. Change-Id: Ia5f0329543c339a7e4aaa21ac2f051a326b39c0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353130 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#797445}
-
Ali Juma authored
The network context used for Safe Browsing on iOS currently sends an empty UA string. This CL sets the UA string to the browser's UA string, matching the behavior on other platforms. Bug: 11156263 Change-Id: I73eac07c4fa3d7b2418abfe3d8e4526c0c3b51da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353113Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#797444}
-
Dan Harrington authored
Changes merged: https://chromium.googlesource.com/feed/+/c80d3c49fa92f00c05130106b29d5b49a735ac97 Change-Id: I7d676b458cc1d8e32aa2db104e0e81591d7a32d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353011 Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#797443}
-
Philip Rogers authored
This patch extends the following metrics to M88: Renderer4.MainThreadWheelScrollReason Renderer4.MainThreadGestureScrollReason Bug: 841364 Change-Id: I14bfe66ee5ac1c56f66101007a7e67c513171014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344644Reviewed-by:
Sam Fortiner <samfort@microsoft.com> Reviewed-by:
-
Eric Seckler authored
Copy/paste bug snuck in, which meant we were reporting into the same histogram twice rather than into two different ones. Correcting. Change-Id: Ia43697b69ff5603cc931e2dbda62fdb5892305b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352189 Auto-Submit: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#797441}
-
Emily Stark authored
This CL improves elision behavior in the simplified domain field trials when the omnibox is too narrow to fit the full hostname (or even the full registrable domain). The main change is that if the omnibox is too narrow, we scroll the domain to show as much of it as we can from the right. This is a partial fix, in the simplified domain field trials, for a longstanding security bug (crbug.com/527638). The behavior with this CL is still a little weird because there's no visual cue that the domain is truncated, but I think it's better than the status quo where we show the left edge of the domain in Chrome today (e.g., "google.com..." instead of "...evil.com"). For simplicity, I've made it so that if the domain does not fit in the omnibox's bounds, we don't do any hover animations. I think this is okay from a UX perspective; after all, in this case, we're not eliding anything that the user wouldn't be able to see today. It's simplest to implement because ElideAnimation doesn't know anything about hostname/URL semantics and thus doesn't know that it should align the URL specially when the domain doesn't fit. Bug: 1107912,527638 Change-Id: I0682582b95393ded82dfd6d56f5ab9d0859e92d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342283 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#797440}
-
Yuke Liao authored
In order to promote browser_tests to run in non-experimental mode so that it's sherrifed to prevent regressions. Bug: 1111979 Change-Id: I7668d920cb2ed09583bc3eeb606aac0759d502cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353352Reviewed-by:
-
Brandon Wylie authored
Bug: 1094885 Change-Id: Ie3fb46b2fb7029671f91612fefee7fcb2352a613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353012Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a465e2e30890..c95b589112f3 2020-08-12 adlai@google.com Reland "Migrate GrSurfaceContext readPixels to take direct context" 2020-08-12 brianosman@google.com SkRuntimeEffect: Handle different main() signatures on CPU 2020-08-12 robertphillips@google.com Fix bug in op chaining 2020-08-12 mtklein@google.com more careful rrect deserialization 2020-08-12 adlai@google.com Reland "Migrate SkImage::MakeFromTexture to GrRecordingContext" 2020-08-12 mtklein@google.com fix a SkRRect::readFromMemory() fuzzer bug If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1111169,chromium:1112259 Tbr: fmalita@google.com Change-Id: Ia9a45981611d9ad7bdd9aa3e0d3741aaed82ecd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353099Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797437}
-
Michael Thiessen authored
This change adds an assertion that pollUiThread is not called from the UI thread, which is equivalent to calling sleep(), and won't actually run any UI thread tasks. In the few cases where polling the UI Thread from the UI thread is necessary, I introduce CriteriaHelper#pollUiThreadNested, which nests the looper in order to continue running UI tasks. Bug: 1115220 Change-Id: I834251df334c80d657e45dddeab5ae744de0fe17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340004Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#797436}
-
Erik Chen authored
Attestation is the process of proving ownership of a private cryptographic key. One side issues a challenge, and the entity must sign the challenge using a private key. chromeOS exposes blessed extension APIs that allow force-installed policy extensions to issue attestation challenges. By default, these are not available on lacros. This CL adds basic plumbing for enterprise.platformKeys.challengeMachineKey. This is not intended to be a fully functional implementation -- that will require further refactoring and debugging from domain experts. Bug: 1113443 Change-Id: I8781ef1367242de59faacb372cf6453925fdfa86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324303Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#797435}
-
Ben Pastene authored
This test requires 2 Tast vars. Simple Chrome currently doesn't fetch the internal tast vars repo. So disable this test while we figure it out. Bug: 1115622 Change-Id: I31c7404e4eecdff965143a2f3430b114f85e9eca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353064 Commit-Queue: Ben Pastene <bpastene@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Auto-Submit: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Michael Thiessen authored
We were leaking the overridden ApplicationContext, leading to other tests failing when interacting with mocks created by the ExternalNavigationHandler. Not sure why this isn't occurring on bots, but it does locally. Change-Id: Ie283a6f96f69dec2a8e70c4ed11e025f6e475c68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353121Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/67615460bea4..383f2cfca4a1 2020-08-12 danilchap@webrtc.org Stop mentioning RTPFragmentationHeader in call/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I6037b9236d0ae1202381c9149d83c8f771e31ee6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351754Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dfa133b7b48c..fac64cf60aa2 2020-08-12 lalitm@google.com Merge "tp: strip leading whitespace before looking for comments" 2020-08-12 fmayer@google.com Disable PollBehavesProperly without ASAN. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I2a2fe9d6f6cb4127dd3bdd846633818d4bd9e1d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351287Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b65408064b1f..ee70c3aabba0 2020-08-12 swiftshader.regress@gmail.com Regres: Update test lists @ 13f04d59 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic45323946b11c96b494312d706240b708408369f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353114Reviewed-by:
-
Daniel Murphy authored
While reading the code it isn't clear the WebAppInstallTask may only be used once. Adding DCHECKs and a comment to clarify this for future readers. R=loyso@chromium.org Change-Id: I08c188ac9eaef53ab7b9a82f0bbd93f383a5e936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300830 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#797429}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: CrComponentsNetworkConfigElementBehaviorTestV3.All Change-Id: Iec3529a023fb5c00c341d6f8d535991fe37552d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347072 Commit-Queue: James Hawkins <jhawkins@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1aff02d44478..2088cdec6612 2020-08-12 cwallez@chromium.org Update tests to use new mapping APIs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I06ac3b8a6f0093f92267bdb98a9accc241794179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351756Reviewed-by:
-
Stephen McGruer authored
This reverts commit dc5bcc30. Reason for revert: Suspected of breaking win-32-archive build: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/15597?blamelist=1#blamelist-tab Original change's description: > Update schema for PolicyRefreshRate and MaxInvalidationFetchDelay > > Include the min and max values already specified in the policy > descriptions and in the code handling the policies. > > The limits for the PolicyRefreshRate policy are specified in > components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc. > > The limits for the MaxInvalidationFetchDelay policy are specified in > chrome/browser/policy/cloud/cloud_policy_invalidator.cc. > > BYPASS_POLICY_COMPATIBILITY_CHECK=Min and max values already specified, > they just were missing from the schema > > Change-Id: Ia1b3904dd1f377d5bc1ee7c2742f3eaeb3f34969 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349211 > Commit-Queue: Chris Sharp <csharp@chromium.org> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797407} TBR=csharp@chromium.org,pmarko@chromium.org Change-Id: I3211f93539d1f5c5d81cc380b13f88e8f543bb9b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353359Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#797426}
-
Claude van der Merwe authored
The 'actionable' attribute was added to 'property-box' in network_config_toggle.html. This caused a pointer cursor to be displayed when the element was disabled. This change removes the 'actionable' property and adds css to change the cursor to initial if the element is disabled and pointer if it is enabled. Bug: 1114668 Change-Id: If09818400ae37b3f3c21f15b161d37940ae4ed62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347196Reviewed-by:
-
Sammie Quon authored
Update text and change so exit mirror mode will not trigger it. Partial revert of crrev.com/c/2340265 as we may keep around some of the notifications that are currently behind the flag. Test: manual Bug: 1111479 Change-Id: I285e5b41af06aeb940be02f6b9d2255531c9444b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350901Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#797424}
-
Kyle Horimoto authored
We do not start up PhoneHubManager at all when prohibited by policy (see [1]), so this is no longer an appropriate enum value. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2350024/ Bug: 1106937 Change-Id: Ie143f16b363707042d7da191b6891e051f64a50b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352210 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#797423}
-
Robert Ma authored
Importantly, this rolls some webdriver/ changes that will fix the regression in issue 1115609. Removed the related expectations introduced in the import https://crrev.com/c/2351549 as well. Bug: 1115609 Change-Id: I5f0ebfc1d657556e166fc6d433b24f3f2ff8a14a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351383Reviewed-by:
-
Andrew Comminos authored
When layers associated with multiple different documents (via TransformNode) overlap at an event's position, mitigate any misattribution caused by complex occlusion by discarding attribution when there exists a layer with a document outside of the targeted layer's parent chain. Bug: 910421 Change-Id: I4d98c4a65f0704c06c3bfbc16a7fc8b9c42d28e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351142Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#797421}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597233486-9b99859a3e8f91576b2a111cc083e1a4b72a89f4.profdata to chrome-mac-master-1597255086-4c97f40f3099850ce4002243596e1c9e8589ecba.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6fc218658384d9edc07f652faf21f03feabeafb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353098Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f4ca4974. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I281db5ed18dfbe4a1afafff4ec819432772b4d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353170Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797419}
-
Meilin Wang authored
Please see screenshot in the linked bug. Bug: b/161481195 Test: manually. Change-Id: Ie276b743b122d447cc658dfff6e72476122aef3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336493 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#797418}
-
