- 30 Jan, 2018 40 commits
-
-
Austin Tankiang authored
Make Geolocation use WeakInterfacePtr, which is the class to use so that mojo interface handles do not need to be manually closed on Execution context destruction. WeakInterfacePtr are the new hotness, they do that automatically on Execution context destruction. No new tests, no change in behavior, covered by existing tests. Bug: 800641 Change-Id: Icf5347c012c735b03676d2537cae4473f03fc568 Reviewed-on: https://chromium-review.googlesource.com/880246 Commit-Queue: Austin Tankiang <austinct@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#532795}
-
Donna Wu authored
This CL separate the general functions for getting needed information from MtpStorageInfo to storage_monitor::StorageInfo and add the |id| and |location| test back. BUG=769630 Change-Id: I1d77c1e4ea9471e04706ac9e94778e8bea771a94 Reviewed-on: https://chromium-review.googlesource.com/880487 Commit-Queue: Donna Wu <donna.wu@intel.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#532794}
-
Kent Tamura authored
It's helpful for logging. This CL won't affect production. Change-Id: I9f35d75799ce060ceef34e173967c0881930504d Reviewed-on: https://chromium-review.googlesource.com/892579Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#532793}
-
Victor Costan authored
This CL contains the following refactorings. 1) The preprocessor defines ("compile-time options" in the SQLite documentation [1]) used to build the SQLite library bundled with Chromium are extracted in a "chromium_sqlite3_compile_options" configuration. 2) The "chromium_sqlite3_compile_options" configuration is injected into all the targets that depend on //third_party/sqlite (when using Chromium's bundled SQLite library), so sqlite.h is parsed with the same preprocessor defines used to compile the library. This will become important when we start disabling the SQLite features we don't use. 3) The SQLite shell is compiled with the same preprocessor defines and disabled warnings as the SQLite library. The shell is only built on Linux for the purpose of debugging SQLite issues, and does not ship with Chrome. 4) The configuration used when we rely on the system's SQLite library (so the SQLite bundled with Chromium is not built) is renamed from "sqlite_config" to "system_sqlite_config". [1] https://www.sqlite.org/compile.html Bug: 807093 Change-Id: Ibf495ef3c4635a9b40c35e9998694293899d10d9 Reviewed-on: https://chromium-review.googlesource.com/892096Reviewed-by:Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#532792}
-
Koji Ishii authored
Following bot results are included. 3384 3387 3388 3392 2 lines were removed and 28 lines were deflaked by consecutive results since 3356. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I62bdd22e9e92bc46d58dc74daba3cd74959bcc01 Reviewed-on: https://chromium-review.googlesource.com/892192 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532791}
-
Ryan Hamilton authored
Bug: 787949 Change-Id: I19ff9ce7f046eb177403d5e9350833e1932b98a1 Reviewed-on: https://chromium-review.googlesource.com/884421Reviewed-by:
Buck Krasic <ckrasic@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#532790}
-
Christian Biesinger authored
This reverts commit a324bac1. Reason for revert: Causes various performance regressions and at least one memory regression, see bugs listed below. Original change's description: > Add UKM metrics for rendering timing measurements > > UKM review: https://docs.google.com/document/d/1Cpe5kLi3tVshH3evoJVUVDjOw7le-f8jFwBjEk2uadY/edit > > Bug: 783383 > Change-Id: Ib684e9e07322e27633b33576c688fa699fada81e > Reviewed-on: https://chromium-review.googlesource.com/812154 > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532051} TBR=cbiesinger@chromium.org,asvitkine@chromium.org,chrishtr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 783383,807121,806814,806810,806808,806806,806795,806801,806809,806812,806830,806829,806805,806796 Change-Id: I33e40eb337bb0b1daea4be753878d7218342942f Reviewed-on: https://chromium-review.googlesource.com/892482 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#532789}
-
Aleks Totic authored
Now the tree looks like this: Box (block-flow children-inline) offset:0,34 size:600x72 LineBox offset:31,0 size:568x18 Box (children-inline)(self paint) offset:0,-1 size:367x19 Text offset:0,1 size:337x17 start: 30 end: 83 Text offset:377,0 size:191x17 start: 1 end: 30 LineBox offset:24,18 size:575x18 Box (children-inline)(self paint) offset:0,-1 size:575x19 Text offset:0,1 size:200x17 start: 144 end: 171 Text offset:200,1 size:375x17 start: 84 end: 144 LineBox offset:21,36 size:578x18 Useful when debugging painting. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I0901841736b7bbad9534a3ecbcc187c9b968d15c Reviewed-on: https://chromium-review.googlesource.com/892103 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#532788}
-
Hongchan Choi authored
This CL resolves wrongly placed locks at 3 different objects. * Observation Mutex M6756: HTMLMediaElement::provide_input_lock (Mutex) Mutex M9163: MediaElementAudioSourceHandler::process_lock_ (Mutex) Mutex M9987: WebAudioSourceProviderImpl::sink_lock_ (base::Lock) These 3 locks have a cyclic reference: M9163 => M6756 => M9987 => M9163 * Scenario 1. Entry point: MediaElementAudioSourceNode::Create() from BaseAudioContext's factory method 2. HTMLMediaElement::SetAudioSourceNode() M9163 locked 3. HTMLMediaElement::AudioSourceProviderImpl::SetClient() M6756 locked 4. WebAudioSourceProviderImpl::SetClient() M9987 locked 5. HTMLMediaElement::AudioClientImpl::SetFormat() 6. MediaElementAudioSourceNode::SetFormat() 7. MediaElementAudioSourceHandler::SetFormat() Acquiring M9163 fails because it is already held at step 2. * Attempted Solution in this CL HTMLMediaElement::SetAudioSourceNode() does not have to lock the MediaElementAudioSource node - because the source node and the handlers are locked locally in SetFormat() method. * Suppressed Error The patch fixes the lock-order-inversion, but it shows another TSAN suppression case: --- ThreadSanitizer: Matched 3 suppressions (pid=85351): 1 race:tzset_internal 2 deadlock:dbus::Bus::ShutdownAndBlock --- Note that this error is labled as a |won't fix|: https://cs.chromium.org/chromium/src/build/sanitizers/tsan_suppressions.cc?l=220 case instead. Bug: 786739 Test: CF repro tool cannot reproduce, showing one of TSAN suppression Change-Id: I8d9f6fe549562e39f7212f80aa2dea6c9527922e Reviewed-on: https://chromium-review.googlesource.com/879242Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Mounir Lamouri (slow) <mlamouri@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532787}
-
Yoichi Osato authored
PositionInGraphicsLayerBacking uses a boolean argument |selection_start| to compute a selection bound. This patch refactors the function by removing the argument and splitting the function into StartPositionInGraphicsLayerBacking and EndPositionInGraphicsLayerBacking for code health. Bug: 789870 Change-Id: I09b08afaef179cedd00d6d9b6bbd47cb5cd222bb Reviewed-on: https://chromium-review.googlesource.com/892193Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#532786}
-
Ryan Hamilton authored
Change-Id: I12c2ce5551bcd2630af75ac9e9f6e15758c3a7e6 Reviewed-on: https://chromium-review.googlesource.com/889639 Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
This CL removes a reference from CachedMetadataHandlerImpl to Resource, and instead captures necessary data from Resource when CachedMetadataHandlerImpl is created, i.e. when a response is received. This is to make CachedMetadataHandler and Resource independent, so that CachedMetadataHandler can be used even when the corresponding Resource is garbage-collected or revalidated, for Issue 783124. This CL causes a behavior change in CachedMetadataHandler::Encoding(): Previously, it returned the final encoding that reflected the encoding detection by the response body. After this CL, it returns the encoding at the time of ResponseReceived() that doesn't reflect the encoding detection (by UTF BOMs in the case of scripts). This shouldn't affect the correctness, because if the encoding at the time of ResponseReceived() is the same, then the final encoding should be also the same (provided the response content is the same). This might cause different Encoding()s are returned for the same final encoding and thus affect memory/performance, but this is expected to be quite rare because UTF BOMs are quite rare. Bug: 784875, 783124 Change-Id: I0b72fafc54537fae93c90d1abf3bddf4e094add8 Reviewed-on: https://chromium-review.googlesource.com/791494 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#532784}
-
Zhuoyu Qian authored
This patch introduce a new class |PluginParameters| to simply the parameters of functions in HTMLPlugInElement, HTMLEmbedElement and HTMLObjectElement. BUG=572908 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I191000990b64ab638501ee3ded4dfc1e1b521e30 Reviewed-on: https://chromium-review.googlesource.com/883005Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#532783}
-
Kent Tamura authored
Custom Element V1 supports only XHTML namespace, and Document::createElemenNS() ignored specified namespace URI. - Reject namespace URIs other than XHTML's one on finding 'definition'. - Check existence of 'definition' instead of names on choosing appropriate element factory. The new behavior matches to Firefox and the specification. Bug: 806665 Change-Id: I458685eeb48019be9da086b3b2a8703deac655c6 Reviewed-on: https://chromium-review.googlesource.com/892541Reviewed-by:
-
Hayato Ito authored
It looks that event-path-001.html is obsolete and needs to be updated, however, let's remove it because we have already other web platform tests for event.composedPath() in wpt/shadow-dom/. Bug: 776656 Change-Id: Ic6c5909ebc44c7260c8cc8ad9e935c406af3a070 Reviewed-on: https://chromium-review.googlesource.com/891038 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532781}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/95d2f6fb..10835cef Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I20c5247a532dad1f5ee9996ec9a01d2082248064 Reviewed-on: https://chromium-review.googlesource.com/892518Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#532780}
-
Hwanseung Lee authored
reame CSSTranslationto to CSSTranslate for consistency with others. https://github.com/w3c/css-houdini-drafts/pull/598 https://drafts.css-houdini.org/css-typed-om-1/#csstranslate Bug: 806736 Change-Id: I0af1dd54e9337bdd513ee622fbaa83ae6f7bc9ef Reviewed-on: https://chromium-review.googlesource.com/890919Reviewed-by:
nainar <nainar@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#532779}
-
John Abd-El-Malek authored
Temporary disable of browser tests that use CertVerifier with network service until services/network uses a component. Until then, the test method isn't exported and the tests fail. TBR=rockot@chromium.org NOTRY=true Bug: 753658 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ifd5c4bf4e8e92aa8a87c439eb053ec08105724e4 Reviewed-on: https://chromium-review.googlesource.com/892496 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#532778}
-
Brandon Jones authored
This rendering context type is effectively a variant of an ImageBitmapRenderingContext, but which can only be supplied images directly by a XRSession. Bug: 670510 Change-Id: I780d47b873f4295e169d06fe993278067e99178d Reviewed-on: https://chromium-review.googlesource.com/877182 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#532777}
-
Tien-Ren Chen authored
This CL adds an optional path field on ClipPaintPropertyNode. For non-composited clip nodes, the clip path is implemented as cc::ClipPathOp. For composited clip nodes, the clip path will be synthesized as a mask layer, similar to how border radius is implemented. This CL itself doesn't implement CSS clip-path yet, which will be done as a follow-up CL. BUG=792769 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I8a69b85491ffa08c8f6dab3f695a4b13f7a88088 Reviewed-on: https://chromium-review.googlesource.com/885242 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532776}
-
Kentaro Hara authored
This is a speculative fix for bug 792604. It looks like that we're missing wrapper-missing somewhere and the v8::Function of Geolocation's callbacks are collected prematurely. This CL keeps Geolocation alive until all one-short callbacks are invoked. This CL has no risk of causing memory leaks because 1) the one-shot callbacks are guaranteed to be invoked in a finite time period and 2) ActiveScriptWrappable::HasPendingActivity is implemented in such a way that it returns false after context gets destroyed. Bug: 792604 Change-Id: Ief245d0409fc6b1b35cfe11e3368de230b503482 Reviewed-on: https://chromium-review.googlesource.com/892557Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#532775}
-
Xianzhu Wang authored
We need to repaint the PaintLayers which have changed paint properties to update paint property states for paint chunks. Bug: 805049 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib113ef4ca0971614c9c1a3201c342a1c4862e9ed Reviewed-on: https://chromium-review.googlesource.com/885262 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#532774}
-
Kouhei Ueno authored
Bug: 803774 Change-Id: I5eccac078132a66ba041cd1fa30bbef6c75dc700 Reviewed-on: https://chromium-review.googlesource.com/890577Reviewed-by:
-
Makoto Shimazu authored
This reverts commit 8d170b87. Reason for revert: The test added by this CL is flaky. Original change's description: > MD Extensions: Port LazyBackgroundPageApiTest.UpdateExtensionsPage to new UI. > > Bug: 800502 > Change-Id: I059c10360312df02b040e3e87667b8a39abce09c > Reviewed-on: https://chromium-review.googlesource.com/891627 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532714} TBR=rdevlin.cronin@chromium.org,dpapad@chromium.org Change-Id: I58b2acc0496a3c901e57fc240d96059ff50248ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 800502, 807153 Reviewed-on: https://chromium-review.googlesource.com/892658Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532772}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/69f2184e9c43..52dc3feb012c $ git log 69f2184e9..52dc3feb0 --date=short --no-merges --format='%ad %ae %s' 2018-01-29 bsep Disable ScrollActionTest.testWheelScrollDistanceWhileZoomed (flaky). Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic770ec51be9d88f65e224c0f18eeff3a8c75a446 Reviewed-on: https://chromium-review.googlesource.com/892291 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#532771}
-
Hwanseung Lee authored
value attribute should be immutable to prevent cyclic references in CSSMathInvert, CSSMathNegate. Bug: 803687 Change-Id: Ic38936609f5233386c2f2f4fe8ce958d7b5ca904 Reviewed-on: https://chromium-review.googlesource.com/891202Reviewed-by:
-
Kunihiko Sakamoto authored
Bug: 705400 Change-Id: Iffc701df6997a0341839cf5b294694ffd5dc20d8 Reviewed-on: https://chromium-review.googlesource.com/887999 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#532769}
-
Fergal Daly authored
It was added to the whitelist in https://crrev.com/c/807754. Bug: 771087,763980 Change-Id: I3f168415bba5cfcf4383c30c3ef6e66036ffc050 Reviewed-on: https://chromium-review.googlesource.com/892195Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#532768}
-
Tetsui Ohkubo authored
This is a reland of 4497e01a. Change fron the original CL (PatchSet #1): * Loop over existing toasts in a way that won't crash when a toast is removed mid-loop. SetExpanded may cause the toast to be removed. See the comment for detail. Original change's description: > Do not close widget in TrayBubbleView for notification center. > > This is a follow-up CL of https://crrev.com/c/816778 . > > There were three code paths to close notification center: > * Only WebNotificationTray::HideMessageCenter is called. > (clicking on tray bell icon) > + TrayBubbleWrapper::OnWindowActivated is called in addition. > (pressing search button) > + TrayBubbleView::OnWidgetActivationChanged is called in addition. > (clicking on screenshot notification in notification center) > > On the last code path, Widget::Close() is called before > WebNotificationTray::HideMessageCenter(). > HideMessageCenter() assumed the widget is still open, thus the crash > https://crbug.com/792583#c14 was caused. > > The quick fix CL fixed HideMessageCenter(), but it is confusing that > the widget can be closed through multiple code paths. > This CL uses TrayBubbleView::InitParams::close_on_deactivate so that > the TrayBubbleView does not close the widget. > > TEST=manual > BUG=792583 > > Change-Id: Ibff47189719043d6ec6830f50888c8323e63f44a > Reviewed-on: https://chromium-review.googlesource.com/833429 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#528866} TEST=MessagePopupCollectionTest.AddedAndRemovedAtSameTime BUG=792583,804389 Change-Id: I79257b3c64e27926687f50284d7c3e2d03375c28 Reviewed-on: https://chromium-review.googlesource.com/886101 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#532767}
-
Makoto Shimazu authored
TBR=klausw@chromium.org NOTRY=true Bug: 807152 Change-Id: Ie6894445c01f5ec0cfc83b2a955a5b9b56979bd3 Reviewed-on: https://chromium-review.googlesource.com/892586Reviewed-by:
-
Tatsuhisa Yamaguchi authored
While 1+ incognito browser windows are opened, it'll have separate Files app extension background and foreground scripts running. The ones in the incognito context should only be visible by the file picker window invoked by the browser, but should not show fullscreen app windows or notifications. - Prevent duplicated "Removable device detected" notifications (when no DCIM folder in it) - Prevent duplicated Files app windows popup (when plugging a disk with /DCIM directory) - Files app fullscreen mode opened with incognito context (which caused some errors), when clicking the "show in folder" link in "Removable device detected" notification. - Other duplicated notifications such as "formatting finished". This is reland of crrev.com/c/861589 with some tweak. Bug: 800658 Test: manually tested as noted above Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7c9fbfb4bbf25d40228895d5f5836bb9caa1f5fa Reviewed-on: https://chromium-review.googlesource.com/886661Reviewed-by:
Daichi Hirono <hirono@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#532765}
-
Keishi Hattori authored
This CL separate weak persistent tracing out from the non-weak persistents, so we can register the weak callbacks in the IncrementalMarkingFinalize. Otherwise the WeakPersistents may get destroyed after they get traced and register a weak callback. BUG=757440 Change-Id: I28934b0bc9b8686195583480798627f86b79915c Reviewed-on: https://chromium-review.googlesource.com/882785 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Michael Giuffrida authored
With browser/tab activity being consolidated in resource_coordinator, TabMetricsLogger belongs here. This CL just moves files without changing functionality. TabMetricsLogger will later take over responsibility for logging other logging other tab UKMs from tab_manager_web_contents_data.cc. It will also be generalized to handle other "tab" types like Chrome apps. Bug: 783989 Change-Id: I55425b027a4860f52eb49b9169609954fe2f76a9 Reviewed-on: https://chromium-review.googlesource.com/890861 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#532763}
-
Peter Kotwicz authored
This CL changes the custom-package-name specified in ChildProcessCreationParams to apply to both sandboxed and unsandboxed services. Perviously when a user launched a WebAPK: - Renderers would use a non-Chrome sandboxed process defined in the WebAPK APK - The GPU process would run in a Chrome process WebAPKs no longer use a non-Chrome process for renderers. This leaves us with two cases: Case #1 - Chrome - Renderer runs in Chrome-process (Package name provided by application context) - GPU process runs in Chrome-process (Package name provided by application context) Case #2 - Android Webview - Renderer runs in Chrome-process (Package name different than application context) - Does not use GPU process or other non-sandboxed processes Bug=797999 Change-Id: I050e9e16a6a9a17c99d46c33e0ce190d17e66d98 Reviewed-on: https://chromium-review.googlesource.com/885781 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#532762}
-
https://skia.googlesource.com/skia.git/+log/b0c427b1f286..2f5b8d81c231 $ git log b0c427b1f..2f5b8d81c --date=short --no-merges --format='%ad %ae %s' 2018-01-29 reed don't draw non-finite contexts in imagefilters 2018-01-25 bsalomon Add kRGBX_8888, kRGBA_1010102, and kRGBX_1010102 color types. Unused for now. 2018-01-29 mtklein target Android M for -arm- ASAN builds 2018-01-29 csmartdalton Drop support for unused MSAA extensions 2018-01-29 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 12c037610..5dd4ad896 (1 commit) 2018-01-29 mtklein Add 32-bit ARMv8 bots 2018-01-29 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 37b697edf..12c037610 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ieb3375b8a5b65bc62a06e678211a19205d2eda5b Reviewed-on: https://chromium-review.googlesource.com/892405Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#532761}
-
Ashley Enstad authored
Allows obbs_fyi trybot to run tests without rebuilding chrome Reduces trybot time from an hour and a half to <10 minutes Bug: 758632 Change-Id: I8ab95895111bd8b13533b1f9318a0e7891134fd5 Reviewed-on: https://chromium-review.googlesource.com/887956 Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Reviewed-by:
Emily Hanley <eyaich@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#532760}
-
Kristian H. Kristensen authored
We dropped the modifier as we chain to the GbmBuffer constructor in GbmBuffer::CreateBuffersFromFds() and passed 0 for addfb_flags. When we create the KMS framebuffer, this indicates that the kernel should get the buffer layout from the BO instead of the modifier. This works only as long as the modifier is one supported by this legacy convention. Intel Y-tiling isn't, and as when we started using that, this path started failing. We need to pass the modifier from the handle along so that we can create the KMS framebuffer properly. The few callers that create a NativePixmapHandle from scratch have been changed to pass DRM_FORMAT_MOD_INVALID so they still get the legacy implicit behaviour they expect. Bug: b:70546200, b:71416883, chromium:789292, b:69238712, b:68003124 Change-Id: If851a9933eefcfc552cc60b5e45aaf6e1a205c82 Reviewed-on: https://chromium-review.googlesource.com/885906 Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#532759}
-
Matt Falkenhagen authored
The test was using add_result_callback() which is triggered after a test finishes. Unfortunately this file uses both async_test and promise_test. promise_tests run sequentially but async_tests run in parallel. Therefore, the add_result_callback was being called every time an async_test finished, causing a race when this promise_test was in the middle of execution. R=shimazu Bug: 807014 Change-Id: Ic1bc568fe812f540feec901f95cc89684ef1cae2 Reviewed-on: https://chromium-review.googlesource.com/892553Reviewed-by:
-
Fady Samuel authored
This CL introduces a DeadlinePolicy that clients can specify on a SurfaceLayer. DeadlinePolicy currently consists of three options: 1. UseExistingDeadline() which uses whatever the current deadline is on the provided SurfaceLayer. As deadlines are one shot, the last deadline will reset to 0 after commit. If UseExistingDeadline() is used after the last commit, then that translates to 0. Otherwise, it translates to use whatever the last specified deadline was. 2. UseDefaultDeadline() which uses whatever the system default is for the surface synchronization deadline (usually 4 frames). 3. UseSpecifiedDeadline(uint32_t) which allows the client to specify a deadline in terms of number of frames. Navigation now gets a "UseExistingDeadline" policy which will usually translate into a deadline of 0 unless a resize happened just before it. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I83a3106fa602fac1eab52b1493affa46131f9383 Bug: 672962,806835 Reviewed-on: https://chromium-review.googlesource.com/890242 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#532757}
-
Satoshi Niwa authored
Below are the steps for converting Chrome-specific filesystem:// URLs into ARC URLs. 1) Extract filesystem URL(s) from pickle. -> "filesystem:chrome-extension://hhao.../external/drive-.../root/...." 2) Crack URL with FileSystemContext. -> "/special/drive-.../root/...." 3) Convert to Arc URL -> "content://org.chromium.arc.chromecontentprovider/externalfile%3Adrive-.../root/...." Bug: chromium:767982 Test: out/Default/exo_unittests --gtest_filter="DataOffer.*" Change-Id: I9fc803f69acd0d3573c25668ca5786d7e6002501 Reviewed-on: https://chromium-review.googlesource.com/867807 Commit-Queue: Satoshi Niwa <niwa@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#532756}
-
