- 18 Nov, 2019 40 commits
-
-
Lukasz Anforowicz authored
ExtraRequestCompleteInfo relies only on origin-related parts of the url. This means that we can replace the |GURL url| field with |url::Origin origin_of_final_url|. This helps sanitize the URL in the future (possibly removing the path and/or query parts in some cases). Bug: 973885 Change-Id: Iac54c27a5f8d3b1d80463f0092d31324cc928fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894153 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#716359}
-
Matthew Jones authored
Bug: Change-Id: Ic4c8a01624c33202feccc4c24932ebf449dcd488 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922411 Commit-Queue: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Auto-Submit: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#716358}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f6ea6efa9de..665be402b23d Created with: gclient setdep -r src-internal@665be402b23d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia17c50b70829865608c8420e83ef70ca59b578ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922409Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716357}
-
Matt Wolenetz authored
This change expands the disabling of this test from Win ASAN to everywhere due to flakiness on wide variety of builders. BUG=1026001,998369 TBR=karandeepb@chromium.org Change-Id: I51b0ae7596a0c8739cce0713a1c11803546a1979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922559Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#716356}
-
Tarun Bansal authored
Fallback prerender requests to preconnect when it's not possible to do a prerender. This primarily affects low memory devices. This is behind kPrerenderFallbackToPreconnect feature. Currently, this fallback is enabled for only the prerenders initiated by omnibox. This CL extends it to other cases as well. Change-Id: Iaf51b73d10a6c8f90f06ab4629ecf7d13f4a992f Bug: 943442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920430Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#716355}
-
Rayan Kanso authored
Grab available icons and pipe down to contacts provider. Bug: 1020564 Change-Id: Ia81bb00567a937ea3f6e7aa3a992cdaac2e9d16c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893068Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#716354}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/91513b431669..2577dd772d69 git log 91513b431669..2577dd772d69 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 vapier@chromium.org cbuildbot: abort on all legacy cq build code paths Created with: gclient setdep -r src/third_party/chromite@2577dd772d69 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ib88add6b706f8fbe1edc6a7255db521832cb8c1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922410Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#716353}
-
Matt Menke authored
In https://chromium-review.googlesource.com/c/chromium/src/+/1914973, I moved the V8 proxy resolver code from net/ to services/proxy_resolver, but didn't update the namespace, for easier review. This followup CL fixes the namespace of the moved code. Bug: 1007962 Change-Id: Ic4d44a2773c732437073496de9a07e2cf362d303 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914943Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#716352}
-
Doug Arnett authored
Bug: 1025861 Change-Id: I439831c35802d9a0238ad8f482814724a4c289ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921639Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#716351}
-
Andrew Xu authored
There is no reason to hide the hotseat when the shelf context manu is showing. If there is any edge case that we really need to hide the hotseat with the context menu showing (I cannot come up so far), we should close the context menu first. Add a unit test case for this scenario. Bug: 1020388 Change-Id: If38d376fff27a1fd63f02c1a6a7cb323e73e8936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747386 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#716350}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/839a6520..94acd86a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1f481247de3aebc9d7023e52a348d9a7773678a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921617Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#716349}
-
Daniel Cheng authored
Bug: 1025358 Change-Id: Iadef27f215c7a4dccd307ad32f4fbe5649403fb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919821 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#716348}
-
Daniel Nicoara authored
Provide a way to resize the Webview independent of it's container. Follow-ups will remove the LayoutManager. Though, for now we need to leave it so it doesn't break the current behavior. Bug: b/143612326 Test: Manually on device Change-Id: I913ecc699eafa4fd3feb46e07db6a894ecb53747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922557Reviewed-by:
Albert Chaulk <achaulk@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#716347}
-
James Hollyer authored
In order to be more explicit use BindOnce instead of Bind. Bug: 1007640 Change-Id: Ifd0e754b189da878c76832b62efab23e1895d4c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864097Reviewed-by:
-
Ken Rockot authored
This reverts NaCl processes to use only the Legacy IPC Channel (over Mojo) for all IPC, rather than bootstrapping them as Service Manager service processes just so they can then bind an IPC Channel. To support this, Browser/ChildProcessHost is modified to support such processes if so configured at construction time. This "legacy mode" for ChildProcessHost can be removed if/when NaCl processes are removed from Chrome. Some light groundwork is put down for further refactoring as well: namely the Mojo invitation ownership is lifted into ChildProcessHost, and a ChildProcessHost::IpcMode enum is introduced to select what mode different process types will operate in. Follow-up CLs will introduce a new IPC mode and incrementally port all other process types to it. IpcMode::kServiceManager will be removed in the near future, and IpcMode itself will be removed completely (bringing ChildProcessHost back down to only one mode of operation) once kLegacy can be removed too. Bug: 977637 Change-Id: I1abec0fe8ad7b2a18bddcdd467657447c641370e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915320Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#716345}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/dd6b19ec37f3..0d10afabcf7a git log dd6b19ec37f3..0d10afabcf7a --date=short --no-merges --format='%ad %ae %s' 2019-11-18 9856269+sarahM0@users.noreply.github.com Add spvc parser support for control flow instructions (#894) Created with: gclient setdep -r src/third_party/shaderc/src@0d10afabcf7a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=radial-bots+chrome-roll@google.com Bug: None Change-Id: Ie3d523e7bc8c81b83f2243d7ba36fe50e1564200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922408Reviewed-by:
-
Tommy Steimel authored
This CL adds logic to MediaNotificationService::Session to dismiss its MediaNotificationItem after an hour of inactivity when paused. Bug: 1025439 Change-Id: Ie2374b1f25bcbf332dace4ffa1220507d22f1a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920017 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#716343}
-
jonross authored
A series of skia_renderer_pixel_skia_gold_tests began failing on Windows when ran with SkiaRenderer on NVidia. This suppresses those tests until the root cause can be fixed TBR=ynovikov@chromium.org TEST= skia_renderer_pixel_skia_gold_test Bug: 1003040 Change-Id: I0c6353b8583f75e90dfb8a7005ee79fe2ce08e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922233Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#716342}
-
Andrew Grieve authored
Bug: 1003532 Change-Id: I8b3ec212067c0bfd145258e645c42db7ae140790 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919734 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
shrekshao authored
Driver workaround for BaseVertexBaseInstance Extension on Mac exists in ANGLE. We need to turn it on for passthrough on Mac. Bug: 1025719 Change-Id: I8223e50f52430e657fa6a0ceb334099d2f6418b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922357Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Shrek Shao <shrekshao@google.com> Cr-Commit-Position: refs/heads/master@{#716340}
-
Peter Kotwicz authored
This CL refactors CustomTabTaskDescriptionHelper in preparation for making WebAPKs use CustomTabTaskDescriptionHelper This CL: - Makes CustomTabTaskDescriptionHelper a LifecycleObserver and moves logic to determine whether to customize the task desckription to CustomTabTaskDescriptionHelper - Replaces the use of TabModelSelectorObserver and TabModelSelectorTabModelObserver with CustomTabActivityTabProvider.Observer - Replaces CustomTabTaskDescriptionHelper#mCurrentTab with CustomTabActivityTabProvider#getTab() BUG=989912 Change-Id: Iebde1ece8b00bf5c532b2f38ed1cfec24a4f1982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907520 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#716339}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a8ea23db0091..39da10b5563f git log a8ea23db0091..39da10b5563f --date=short --no-merges --format='%ad %ae %s' 2019-11-18 nigeltao@google.com Optimize SkWuffsCodec pixbuf zero-initialization 2019-11-18 egdaniel@google.com Make GrSemaphore no longer derive from GrGPUResource. Created with: gclient setdep -r src/third_party/skia@39da10b5563f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@google.com Bug: None Change-Id: I982a68de46c7211e90f32a586fa6967fe2b1b453 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921563Reviewed-by:
-
Tina Wang authored
Bug: 1025981 Tbr: jbudorick@chromium.org Change-Id: I80bfe9163aa1f270e3af452f73cb8424974b64e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922191Reviewed-by:
Tina Wang <tinazwang@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Tina Wang <tinazwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#716337}
-
Alex Ilin authored
This CL updates ProcessMemoryDumpTest::CountResidentBytesInSharedMemory test to use the new shared memory API. The old API, base::SharedMemory, is being removed. Bug: 795291 Change-Id: I9aa24c6f80c8a75f669b983f8ac1731b76d167dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920120Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#716336}
-
Anastasia Helfinstein authored
This change is a pure refactor. Bug: None Change-Id: Ic2e2bacd9d838cab06d1705fc0012574c72fc747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917050Reviewed-by:
Aran Gilman <gilmanmh@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#716335}
-
Daniel Hosseinian authored
When destinations are managed in print preview (through the anticipated PrinterTypeDenyList policy) , the menu will look differently than expected. For instance, a user may expect the 'Save as PDF' option to appear even when it is disallowed by the administrator. The badging may elucidate correct abnormal behavior. Bug: 487875 Change-Id: I6d8bd29663673b41f3644940df6dd0b049d25855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918011 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#716334}
-
Kyle Ju authored
- Manual tests that are timed out will have Skip specifier. - Manual tests with Skip specifiers will be written to NeverFixTests. Bug: 1025937e Change-Id: I1269e318ed120c31b1d3aec3e51a17b98551c596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921638 Commit-Queue: Kyle Ju <kyleju@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#716333}
-
Peter Kasting authored
Previously, ChromeTypographyProvider overrode these to implement the Harmony colors. This override makes it harder to understand where colors are set or to control how native themes interact with Chrome's built-in colors. Oversights in the ChromeTypographyProvider also led to bugs, e.g. unreadably dark text in disabled textfields in dark mode. Instead this pushes the Harmony colors down into the core classes. This has the following effects: * Users with the GTK theme enabled will now get GTK colors in cases where the ChromeTypographyProvider previously forced Harmony colors. This makes sense since these users are getting GTK colors, not Chrome colors, for all other aspects of secondary UI. * "Should ignore Harmony" native themes will now use correct color IDs for disabled buttons and message box bodies. * Windows non-high-contrast "should ignore Harmony" users (light mode, button text != black) will now get Harmony colors for buttons as well as unselected labels and textfields. It's not clear to me this is ideal, but we already fail to use some of the system colors for these users (for example, for dialog/bubble backgrounds), and the user segment should be small (Win 7 classic theme users who've customized their button colors). Long-term, I suspect the right course if we really care about these users is to supply a GTK-like "use system theme" mode for Windows. * The Chrome-side typography provider will now return the correct colors for disabled textfields and dark mode STYLE_LINKs. * After some research into the Harmony specs for its original intent, I changed STYLE_HINT from matching message box body text to matching disabled text. With some upcoming changes to disabled text colors, this will have the net effect of making the hint text a bit "fainter" (it should ultimately be #72777c/#8c9196 in light/dark mode instead of the current #5f6368/#9aa0a6). This also removes kColorId_ButtonHoverColor, which is unused, and uses the native selection background color for selected labels on Windows light mode, since I was touching that code anyway. Bug: 1024091 Change-Id: Idf62606ac6278289cf7f715979df105e4d9b9986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920433Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#716332}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/515a3848e23d..fa20b0b9db94 git log 515a3848e23d..fa20b0b9db94 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 zakerinasab@google.com Merge "Update Vulkan memory tracker counters" Created with: gclient setdep -r src/third_party/perfetto@fa20b0b9db94 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I38c0db25aacca12beae5627f33211111573d4713 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921562Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/430d4059adb3..e4b3136913c6 git log 430d4059adb3..e4b3136913c6 --date=short --no-merges --format='%ad %ae %s' 2019-11-18 syoussefi@chromium.org Update front-end image test failures' bug number 2019-11-18 syoussefi@chromium.org Vulkan: Fix col-major transformation of unsized arrays Created with: gclient setdep -r src/third_party/angle@e4b3136913c6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=courtneygo@google.com Bug: None Change-Id: I2b9ae60b6459cac40ba60466cbbe0d981eb1d21d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917977Reviewed-by:
-
Jia authored
Add a field trial testing config. Bug: 881215 Change-Id: I8b1a911807df8f18cb44ab89259192cc11ff673a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921022Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#716329}
-
James Hollyer authored
We are eliminating base::Bind in favor of base::BindOnce and base::BindRepeating in order to be more explicit. While working on this issue I also went ahead and changed the Callback to RepeatingCallback and Closure to RepeatingClosure. Bug: 1007747 Change-Id: I4ee2fa0c375d8d102cee342603bb552153a6b50f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862866 Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#716328}
-
Mirko Bonadei authored
This is a speculative CL to temporarily workaround the issue reported on crbug.com/1025796. It seems that starting from [1] the bot started to report errors like: >>> referenced by string_traits_wtf.cc >>> obj/mojo/public/cpp/bindings/wtf_support/string_traits_wtf.o:(sancov.module_ctor_8bit_counters) And they look quite similar to what was reported on crbug.com/912919 (which was blocked on the WebRTC component build support) and it that case the solution has been to temporarily switch back to release builds (see https://chromium-review.googlesource.com/c/chromium/src/+/1367652). [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1874722 TBR: ehmaldonado@chromium.org Bug: 1025796 Change-Id: Ic5261df5cd4569fb5b76ffc7d82e8aacc9d9191b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920824 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#716327}
-
Kai Uwe Broulik authored
This interface lets an application ask the file manager to scroll to and highlight a specific file in its parent folder. It is supported by at least KDE's Dolphin and Gnome's Nautilus and removes the need for filemanager-specific code. In case the interface is not available or the call fails, the parent folder is opened as before. Bug: 352988 Change-Id: Id4e2b61cc77a12698fe6f02b307c9b1e815ab4ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905947Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#716326}
-
Chris Cunningham authored
These are a relic of the blink/media divide that was recently flattened. Now we can just use the blink types. Removing the same for encodingInfo() will be done in a follow up CL. Change-Id: I7e53ce07322e3d97d4aa5ee0e679ed1c27ab67a9 TBR: rtoy@chromium.org Change-Id: I7e53ce07322e3d97d4aa5ee0e679ed1c27ab67a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914974 Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#716325}
-
Chase Phillips authored
This test became flaky after https://crrev.com/c/1891461 which introduced a console deprecation notice for AppCache. Converting this test to a testharness.js test to mark its success explicitly once it reaches completion. Bug: 1022915 Change-Id: I42f707773f9a58bdb0a3a62a5d6d1648aa40dc33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917939 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#716324}
-
John Lee authored
Bug: 1023492 Change-Id: I368bafe618a885a5c068ba04dfb4a6e779514368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919744 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#716323}
-
chromium-autoroll authored
Roll airmont AFDO profile from 80-3945.24-1573469012-benchmark-80.0.3964.0-r1 to 80-3945.24-1574075354-benchmark-80.0.3964.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Id4c4e7dff04a9d9a0500cdeb245e0ce1409bef05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922507Reviewed-by:
-
chromium-autoroll authored
Roll broadwell AFDO profile from 80-3904.92-1573478033-benchmark-80.0.3964.0-r1 to 80-3945.24-1574073272-benchmark-80.0.3964.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I7444dec6c7cb832fa8271b0795b89c3f6701c1b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920646Reviewed-by:
-
Edward Jung authored
Still need these metrics while we look for a replacement LinkDoctor service. Bug: 988708 Change-Id: Idd6816b8b8d7fbbfd885181ade39b02f43a486dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1920176Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#716320}
-
