- 22 Aug, 2019 22 commits
-
-
Sergei Datsenko authored
Bug: 995508 Change-Id: Iec4a4042b66ee29a88930db5768678f8628c6538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762263 Auto-Submit: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#689279}
-
Gyuyoung Kim authored
This CL converts old Mojo types to the new types in MockWakeLock. - Replace mojo::Binding with mojo::Receiver - Replace mojo::BindingSet with mojo::ReceiverSet Bug: 983396 Change-Id: I0b096867f836fedcc189a399cc9eeef41cc8bb8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761961Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#689278}
-
Matt Mueller authored
Records a bitfield of the various types of trust settings that were seen. Bug: 991247 Change-Id: I50d4070a309088a99c5317dc13a4a3c59acae47d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754276 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#689277}
-
Gyuyoung Kim authored
This CL converts old Mojo types to the new types in DeviceSensorEntry. - Replace mojo::Binding with mojo::Receiver - Apply mojo::Remote into SensorPtr Bug: 983396 Change-Id: I5a6153c4046a6cef5b98d73dd723d7e1fcb955a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757422Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7719c19e556f..b06831a5ae4a Created with: gclient setdep -r src-internal@b06831a5ae4a The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ie5d5aecad1b00334a16379b474f2f1ae8ea1171c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764636Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689275}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9e081d164c81..fe65f6d2c3d1 git log 9e081d164c81..fe65f6d2c3d1 --date=short --no-merges --format='%ad %ae %s' 2019-08-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-21 fmalita@chromium.org [svgcanvas] Add flag to suppress newlines and tabs in XML Created with: gclient setdep -r src/third_party/skia@fe65f6d2c3d1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@google.com Bug: None Change-Id: I00ce5ca23bac57509f60b52821b7a1f0809f24fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764446Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#689274}
-
David Bertoni authored
Bug: 397197, 482733 Change-Id: I0238994306c26a6abb85cef2800ad86d0802cbd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764418Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#689273}
-
Zhenyao Mo authored
BUG=867155 TEST=none R=kbr@chromium.org NOTRY=true Change-Id: Ife839b1eac2643b7150e5c6172112f33cd36b283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717526 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#689272}
-
Joel Hockey authored
Ignore any query or fragment in path when reading files Bug: 846546 Change-Id: If86dcf4ea1a12378c29553475945abe56714c729 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763270 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#689271}
-
Fred Mello authored
Notable Changes: - Moved the MainDex annotation to the ModuleInstaller interface - Removed Stub Class and Template - Removed need for setInstanceForTesting to be static To add more context: - A change was also made to clank/BUILD.gn - Tested all modules locally - Reviewed MainDex changes with Sam M. - All tests passing locally as well as in the CQ Downstream change: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1685369 Bug: 995940 Change-Id: Id9771513ccaa7f33510a3cee49884dd405e33db2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762699Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Fred Mello <fredmello@chromium.org> Cr-Commit-Position: refs/heads/master@{#689270}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/722aa0bc8abe..4de25e8087ab git log 722aa0bc8abe..4de25e8087ab --date=short --no-merges --format='%ad %ae %s' 2019-08-21 saklein@chromium.org Reland "AndroidService: Refactor uprev and unpin endpoints." 2019-08-21 pmoy@chromium.org usergroup_baseline: expect cros_healthd in the disk group. 2019-08-21 bpastene@chromium.org deploy_chrome: Only set the security context if 'restorecon' is available on the DUT. 2019-08-21 mikenichols@chromium.org httplib2: Update httplib2 to resolve SSL issue Created with: gclient setdep -r src/third_party/chromite@4de25e8087ab The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I65e79f9c08083b1b0bc1e49bf8ec46883c08c3b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764445Reviewed-by:
-
Luciano Pacheco authored
Remove UI code and file_manager_browsertest_base that supports MyFilesVolume disabled. Change ARC++ tests to run with MyFilesVolume flag enabled since the issue with them has been fixed on CL:1757960. After this CL all Files app tests (UI, unit and integration) run with MyFilesVolume flag enabled, which allows the removal of the rest of the code using this flag. Bug: 880132,880130 Change-Id: If10b5af427db20be587afb6c142a108acc8c4f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755566Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#689268}
-
Ted Meyer authored
to reset, which caused duplicate IDs. Bug: 794255 Change-Id: I801c588529804a418b83dd66e7aa15806fae717c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764261Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#689267}
-
Reid Kleckner authored
He no longer works on Chrome and requested to be removed. TBR=yunlian@chromium.org Change-Id: Id03fcd144bd5c9e542a15e80a520571675c16550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764474Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#689266}
-
Jazz Xu authored
This CL add a SurfaceView in PictureInPictureActivity and a compositor in OverlayWindowAndroid to display video surface. Bug: 964388 Change-Id: I94f96bed25f8ed6904bce4d2d369f8bf4763d72c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757428Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#689265}
-
Shawn Gallea authored
Add ExternalBeginFrameClient parameters to pass an ExternalBeginFrameClient object through CastWindowTreeHost to eventually allow custom framerates in cast. Bug: b/139299756 Test: Compile and run cast_shell Change-Id: If44428e639df047c69daa172ba4bc91d21089d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762578Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Shawn Gallea <sagallea@google.com> Cr-Commit-Position: refs/heads/master@{#689264}
-
Robert Sesek authored
Requests for private data on macOS are increasingly protected by the TCC (Transparency, Consent, and Control) subsystem, which mediates the access with dialog prompts. When an application launches a child process, the system maintains a concept of the "responsible" process, and the parent is responsible for the child (in terms of appearing as the requesting process in the dialog prompt). When launching processes that by design execute third-party code, such as PPAPI plugins and native components of extensions, the browser app should not appear to be the responsible process. The third-party code is the one making the request and should be displayed as such in the system prompt. In order to do this, an undocumented posix_spawnattr_t bit can be set to disclaim responsibility for the new child process. This establishes a new chain of responsibility starting with the launched process. Bug: 945969 Change-Id: Ib931d3345da1b19bce7c8c5197ef675cf776cdfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759149 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#689263}
-
Natalie Chouinard authored
Change-Id: Ib09eca453afa833eb124d3e8c04e407c3e7b6466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762498Reviewed-by:
-
Erik Jensen authored
Xvfb-randr was a custom build of Xvfb we created due to missing RandR support in the stock Xvfb. However, stock Xvfb has supported RandR since version 1.18.1, making Xvfb-randr obsolete. This patchset drops the optional dependency on xvfb-randr from the Debian package and updates the session script to always use stock Xvfb. It also switches to using a large frame-buffer size on stock Xvfb. This will make resize-to-fit more useful out of the box for the vast majority of users now using a RandR- supporting version of Xvfb, but the handful of users running old Xvfb versions may find themselves with a much larger desktop than desired. Such users can revert to the old behavior by adding export CHROME_REMOTE_DESKTOP_DEFAULT_DESKTOP_SIZES=1600x1200 to their ~/.profile or similar. Bug: 955203 Change-Id: Ibad903104a719e7e86c1fe375d18388030668e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764675Reviewed-by:Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Cr-Commit-Position: refs/heads/master@{#689261}
-
Ovidio Henriquez authored
This change updates the descriptor tests in wpt/ to be standalone window tests. This change allows tests to be formatted with clang-format. Bug: 994756 Change-Id: Ifcedeadd35d0775793269572fec478eaa5dbe06d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757889Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL is a part of converting Mojo types to new Mojo types. It cleans up ShareServiceRequest and uses PendingReceiver<mojom::blink::ShareService>. Bug: 978694 Change-Id: I79ee3ac57cb60cda4390c01d44c3d54bd43dcb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760845Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Joel Hockey authored
These don't need to be crashes in prod Bug: 996263 Change-Id: I266c7986cba170f638d7d382f1ca5bfb71c3f883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763554 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
-
- 21 Aug, 2019 18 commits
-
-
Gayane Petrosyan authored
Add warning comment to prevent use of problematic types in seralized theme data. Bug: 988055 Change-Id: I1c7658d5818a6f71c0218f4c17a1adbcda0d3279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764327 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#689257}
-
Ayu Ishii authored
This change adds SMSReceiverOutcome to UKM to help us better understand how URLs are using this feature and its impact. It will also help us identify URLs that have particularly low success rates so we can evaluate how we can improve the feature. UKM Collection Review Document [Google Only]: https://docs.google.com/document/d/1EmUzkzy4bB0h6T4QT-KTsygV_AQWv2Vb5rJE38QAYA0/edit?usp=sharing Bug: 976332 Change-Id: Ib4a1c13b7a1afc00cc1232ced3e76ffe42b07a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736139Reviewed-by:
Jun Cai <juncai@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#689256}
-
Daksh Idnani authored
Bug: 985486, 984780, angleproject:3701 Change-Id: Ie513cb2d8b79a52c54581c2c86748cd74ce7c7bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764183Reviewed-by:
-
Thomas Tangl authored
Histogram name: Profile.Menu.ClickedActionableItem - The new histogram will replace the user actions recorded for some of the buttons(bug link added in the comments). - Using a histogram makes it easier to analyse the use of the profile menu. Bug: 966388 Change-Id: I790cc89334c05d91a90f96b153236ff8c1735df4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762234 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#689254}
-
Mason Freed authored
On non-flipped framebuffer devices (e.g. Mac in some cases), the mask image was previously being wrapped into an SkImage with the incorrect value for flip_texture. This is now correct, which fixes a bug with masking of backdrop-filter. I also improved the backdrop-with-mask WPT test to catch this problem. Bug: 974857 Change-Id: I5c7cdedac29dfe1a9d9c214169fde718799649fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761557 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#689253}
-
Andrey Kosyakov authored
This reverts the order of visiting of layout objects for pseudo-element children to the one we've had before https://chromium-review.googlesource.com/c/chromium/src/+/1757208 to prevent regressions in the protocol clients. Change-Id: Ia652c04708eeef7372f466dfddd997aa688e0528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764355 Auto-Submit: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#689252}
-
Joel Hockey authored
Moved pwa.html to be at /html/pwa.html to suit libapps normal directory layout. See crrev.com/c/1757753. Tbr: calamity@chromium.org Bug: 846546 Change-Id: Ia996e671fa1afc2c891e1a4d7136458f9382ce48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763511 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Adrienne Walker authored
This is a DCHECK + workaround for issue 988590. https://chromium-review.googlesource.com/c/chromium/src/+/1749703 solves root of the problem, and will avoid this DCHECK for this particular content. Bug: 988590 Change-Id: I0e66ba388c11bbc3805ead42343d7fe7af7a79da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752873 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#689250}
-
Glen Robertson authored
install_manager_bookmark_app_browsertest.cc was actually testing PWA install bubble behaviour, which is already tested in hosted_app_browsertest.cc and pwa_install_view_browsertest.cc. Tests for launcher behaviour were moved to a better home in chrome_launcher_controller_browsertest.cc This was resolved in prep for https://chromium-review.googlesource.com/c/chromium/src/+/1746116 Change-Id: I03a7dfcead67c0174241b8cbd4192035b71be15b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760843Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Glen Robertson <glenrob@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Cr-Commit-Position: refs/heads/master@{#689249}
-
Allen Bauer authored
Previous behavior would always select the parent node when a child was deleted. Unless the node was a child of the root node and the root wasn't visible, then select the first child of the root node. Now the behavior will select the child node after the deleted node(s). If the deleted node was the last node and more children remain, then select the new last node. If there are no remaining children, then select the parent node. Scenario 1 - Simple delete of child node root +--child1 +--child1 +--|child2| <--- Delete this node. +--child3 Result: root +--child1 +--child1 +--|child3| Scenario 2 - Delete of a immediate child of the non-visible root. >Child1 >Child2 >|Child3| <--- Delete this node. >Child4 Result: >Child1 >Child2 >|Child4| Scenario 3 - Delete of last child node (other children remain). root +--child1 +--child1 +--child2 +--|child3| <--- Delete this node. Result: root +--child1 +--child1 +--|child2| Scenario 4 - Delete of last child node (no children remain). root +--child1 +--|child1| <--- Delete this node. Result: root +--|child1| Bug: 991304 Change-Id: I26bf90fd89b3d0d946bf73b7c1047621ca35308a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761299 Auto-Submit: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#689248}
-
Luum Habtemariam authored
Didn't realize this test suite became dependent on cups at some point; this change enforces this. Bug: chromium:945409, chromium:988567 Test: unittests built successfully Change-Id: I109fb2c667daf6cf7178c4cd1e67ef8f4c40658d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764633Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#689247}
-
Oystein Eftevaag authored
If the startup tracing rule is added to a preemptive config, then tracing just gets immediately started (due to the mode) and then stopped (due to startup tracing sending a trigger). We only want startup tracing to be activated when tracing isn't automatically started. R=ssid@chromium.org Bug: 983307 Change-Id: I36a5c10aa9a1c6b16a330dd96677e71af16e146c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762600 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#689246}
-
Akihiro Ota authored
This change does three things: 1. Add a feature flag for ChromeVox sub-node language switching. 2. Check for this flag inside ChromeVox LanguageSwitching to determine the language switching behavior (either node-level or sub-node switching). 3. Adds tests to cover both behaviors. Bug: 923068 Change-Id: I8b8b3cbef6d4bd3d8229f616c481b9009d911f90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750108Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Chris Hall <chrishall@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#689245}
-
Rahul Arakeri authored
Clicking on a scrollbar arrow when the scroller has reached max offset currently chains the input to it's parent scroller. The fix here is to avoid scroll chaining if did_lock_scrolling_layer_ is true. Note that this fix is only for non-animated scrolling (i.e "smooth scrolling" disabled). Bug: 965829 Change-Id: I5c9fe09c6687d8a2216c19d18e63c673d0c27be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652303 Commit-Queue: Rahul Arakeri <arakeri@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#689244}
-
Takuto Ikuta authored
Bug: 996219 Change-Id: I3530e49059e5547a7571a47a94971b24308ac834 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1763512Reviewed-by:
Michael Moss <mmoss@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#689243}
-
Erik Chen authored
This CL is a refactor that moves construction of RenderWidget to RenderFrameImpl for local main frame construction. This has the slight behavior change of affecting the timing at which various objects can constructed and initialized. This CL is in preparation for moving ownership of RenderWidget to RenderFrame. Change-Id: I4c80f4c762e622cc3412978d4943e8e8ba9637e7 Bug: 995981, 419087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764254Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#689242}
-
Vikas Soni authored
CodecSurfaceBundle now owns CodecBufferWaitCoordinator instead of TextureOwner. This is because when switching codecs, we re-use same TextureOwner to create a new CodecBufferWaitCorrdinator in VideoFrameFactoryImpl which was an issue. This could lead to multiple CodecBufferWaitCoordinator to be in flight at once. Hence instead of creating CodecBufferWaitCoordinator every time we switch codecs, we just use the one which CodecSurfaceBundle has. Bug: 996382 Change-Id: I614a2dbb54203f397dbbb9c1d6fa772e4b0146d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1764412 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#689241}
-
Shivani Sharma authored
This is a reland of 6199b09d with a fix for the crash in crbug.com/993543 Original change's description: > Httpcache transaction's mode to be set to WRITE before creating entry > > https://bugs.chromium.org/p/chromium/issues/detail?id=986211#c49 describes the > code path that may lead to mode_ being set to NONE(do not use entry) and state > being set to STATE_CREATE_ENTRY. > > While the intention of DoRestartPartialRequest() is to set the mode to WRITE before > setting the state to STATE_CREATE_ENTRY, ResetPartialState() ends up overwriting the > mode_ to NONE via HttpCache::Writers::EraseTransaction. Both are doing the correct > thing independently so changing the order of mode_ = WRITE and calling > ResetPartialState() should fix the issue. > > This leads to another dcheck to be hit which is that RecordHistograms should only > be invoked once. To fix that this CL also moves the calling site of RecordHistograms() > to the destructor of HttpCache::Transaction which makes the invariant that RecordHistograms > should only be called once, easier to follow in the code. > > TEST: net_unittests --gtest_filter=*RangeGET_OverlappingRangesCouldntConditionalize > Bug: 986211 > Change-Id: I176b6187dc69aa23de73d45263da104da622e0bf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739410 > Reviewed-by: Zhongyi Shi <zhongyi@chromium.org> > Commit-Queue: Shivani Sharma <shivanisha@chromium.org> > Cr-Commit-Position: refs/heads/master@{#685901} Bug: 993543 Change-Id: I186e7dec8c0eeca5d42cf0e5217d3afc9e12d33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757367 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#689240}
-
