- 09 Dec, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/26a24ee9aebf..a737e5f65ca1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ibf090b0d4036f5fc22d9c6a913d48c05a126390f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580582Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#835007}
-
Nicholas Hollingum authored
We extend the BorealisWindowManager to track the lifetime of individual windows, apps (as collections of windows) and the session (as collections of apps. This new observer was kept separate from the already-present anonymous observer as the two have limited overlap, and are not used simultaneously by any clients (currently). We also implement a trivial watcher in the BorealisContext which joins the new session-observing behaviour with the ShutdownMonitor. This watcher will only be active while the context exists so we will not accidentally issue shutdown requests while the vm is not running. Bug: b/172006764, b/172979315 Change-Id: Ie58c87acbb14eebe41152986f6b86032a5d8c759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576876 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Cr-Commit-Position: refs/heads/master@{#835006}
-
Peter Qiu authored
Enable accelerated video decode for Cast devices that supports v4l2 codec. Bug: internal b/174596074 Test: manual on device Change-Id: I650a997309b2edb51721baec94cfd034b13f655f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568857Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Cr-Commit-Position: refs/heads/master@{#835005}
-
Amr Aboelkher authored
In case the private set membership is in progress, and RetryStep has been called, the PrivateSetMembershipRetryStep should return true to prevent Hash dance protocol from executing while private set membership is in progress. This CL is preventing that parallel execution from occurring, along with its required regression tests. BUG=chromium:1156119 Change-Id: I06d25b1fd1171d4b680b5d6b0be21bdb2282a518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577216 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#835004}
-
Lijin Shen authored
Mock deps to see if dispatcher can suspend and resume correctly. Bug: 1155359 Change-Id: Ib0705da0d15795da0a36b5b2b778808d3feacec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573503Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#835003}
-
Wei Li authored
For MacViews, most of text editing commands are already supported. This CL adds the four scroll commands which also have default key bindings: scrollPageUP, scrollPageDown, scrollToBeginningOfDocument, scrollToEndOfDocument, This CL adds comments about the other three commands with default key bindings that we still don't support yet. Test: Press Ctrl+Up/Down should move cursor to the beginning/end of the page. Press HOME/END should move cursor to the beginning/end of the document. If tested on textfield, it will move to the line's beginning or end instead since textfield only supports single line so far. Bug: 586985 Change-Id: I31dd16fce56fb6d8f4f01a094e80ed35d409baa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575948Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#835002}
-
Becca Hughes authored
This adds a UKM metric to BasicPlayback that contains whether the playback has come from a page that was opened by Kaleidoscope. This is so we can track watchtime that is attributable to Kaleidoscope. Ukm-Privacy-Review: https://docs.google.com/document/d/1XOeGNU34FlSv_rrs5TTovpc9gTyT4IQ3Rdy2T7oyLGQ/edit?usp=sharing BUG=1152935 Change-Id: Icc6047abddf1f4f1389c09a639e9a8c49c8f24ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558691 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Change Files app to NOT inline CSS and its images. Measurements showed that this has not significant impact to the startup time. The flattenhtml option used to inline the CSS file is considered deprecated for the latest build tools used in Web UIs. Bug: 1151829 Change-Id: Ibf0bf4f4a77a40ac5a48b1b999a4fde65d7c6bdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560281 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#835000}
-
Bruce Dawson authored
This reverts commit 24e521c6. Reason for revert: bug has been found and fixed Original change's description: > Track progress through View destructor > > The View destructor ends up in an impossible state which means that > execution must have branched to the middle of it, but it is not clear > how this could happen. This change adds an array of line numbers that is > filled in as the destructor runs to leave us some bread crumbs. It also > records the vtable of the about-to-be-deleted child object so that we > can investigate if this is a type-related bug. > > Bug: 1152152 > Change-Id: I386507974a8b6ccd1914e0ec62151456411f0c19 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572793 > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Reviewed-by: Robert Liao <robliao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#833875} TBR=robliao@chromium.org,brucedawson@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1152152 Change-Id: I62871ab84d1a219c9eed67bc2ce3d0b4ceed44c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580545Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#834999}
-
Jinsuk Kim authored
A ThemeColorProvider for top UI (TopUiThemeColorProvider) replaces TabThemeColorProvider, and gets moved to a modularized target chrome/browser/ui/android/theme. This is a new source of truth for toolbar/top part of Chrome UI theme color. Previously TabThemeColorHelper played the role, but now it was redefined to provide the theme color coming from tab contents only. TopUiThemeColorProvider puts together all the signals and decides the final theme color to be used for top UI. Bug: 1127732 Change-Id: I50cd25dd7ebc5b632b397afb1e5246c461fdd61c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546347 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Chris Thompson <cthomp@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. R=dcheng@chromium.org Bug: 1144462 Change-Id: If91ff350a6aacd601e848b705ea2e397484cc439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579667 Commit-Queue: danakj <danakj@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#834997}
-
Brandon Wylie authored
Bug: 1147581 Change-Id: I2003662a67825bd842389fb4d8c9f03c9071f2fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552990 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#834996}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 55c6c513. With Chromium commits locally applied on WPT: f0946b3e "Create compositor animation for background-color" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: Iba95ba58277c5153f0eb7771f627dc89c4f808e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580029Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834995}
-
Xianzhu Wang authored
This simplifies pre-paint flag propagation across frame boundaries. When a pre-paint flag is set, instead of propagating across frame boundaries for non-throttled frames or mark pre-paint skipped for throttled frames at frame boundaries, now always stop at frame boundaries when setting ancestor flags, and propagate the flags into owner frames just before PrePaint for non-throttled frames. Also fix flag propagation for blocking touch and wheel event handlers. Change-Id: I9f5a58cbfdd7cfeda3bfdcbcc94de503b473bf3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578009Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834994}
-
Alan Cutter authored
InstallFinalizer::UninstallWebAppFromSyncByUser() and InstallFinalizer::CanUserUninstallFromSync() are not called by production code. This CL removes them. Change-Id: I51a0cd97da31e3b631c8a9c2a00228341156c321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515423Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#834993}
-
Darin Fisher authored
Change-Id: If66051dcd1da5b8b15fd54e0191dd52a9e751938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580905Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834992}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a737e5f65ca1..c6b219431a16 2020-12-08 marcinoc@google.com Merge "Fix SysUI Jank root cause - long GPU Completion" 2020-12-08 primiano@google.com Merge "Deflake KernelAddressSymbolization and MetaTrace tests" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I21009e22da22db92e082466fbbf6436034ccf6e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579876Reviewed-by:
-
Rob Schonberger authored
Adds in the soda speech recognizer client to chrome, talking to ml service, with appropriate mojo bindings. Add service connection bindings with appropriate fakes, and unittests for creation (along with appropriate expectations on creation for fake. TEST=tested via the unit test / compilation here. Bug: 1152254 Change-Id: Ib39362e3aebef732efe4eaba29ca073653737a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562924 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#834990}
-
Daniel Clark authored
Switch away from deprecated v8::Module APIs to the non-deprecated ones that support import assertions (https://tc39.es/proposal-import-assertions). Future changes will start using the import assertions exposed by these APIs and plumb then into the module infrastructure for use with JSON and CSS modules. Bug: 1132413 Change-Id: I23addcdfe18422abfa735b9aae807c50a9cb2a67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574535Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#834989}
-
Jeffrey Kardatzke authored
This adds support for rendering of protected surfaces that require overlays. This consists of: -Turn on synchronous page flip testing for protected content configurations -Turn on overlay prioritzation support for protected content configurations -Turn on using real buffers for page flip test for protected content configurations -Clip the source rect for protected overlays -Align the source rect by the subsample factor in protected overlays -Allow quads that are occluded by a render pass filter that require an overlay BUG=b:153111783,b:155511837 TEST=Protected overlays render when clipped, unit tests pass Change-Id: Iabe1f4696a0b98225b18efe1d2a1598edb5fa578 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555543Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#834988}
-
Liquan (Max) Gu authored
Context: In some cases, CPRService passes ChromeActivity to PaymentUiService when PUiService really needs Context and WindowAndroid. So this CL changes to provides Context and WindowAndroid to these cases. Doing so can reduce Chrome features' dependencies on ChromeActivity. Changes: * CPRService provides Context and WindowAndroid instead of ChromeActivity to methods when applicable. Bug: 1155788, 1140340, 1140344 Change-Id: Ib934dbbdba25bfc278ce13232d59ef3c4acf2131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577956 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834987}
-
Hui Yingst authored
This CL migrates ScriptInjectionCallback::CompleteCallback to base::OnceCallback, and migrates related uses of base::Bind to base::BindOnce. Bug: 1152265 Change-Id: If3182c7c0c45c5e1b45073dfe47edbf25d7081c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572777 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834986}
-
Azeem Arshad authored
This CL updates error strings in PIN/PUK unlock dialog. This makes it clear that network connection will be lost after final attempt. This also separates PUK error string from warning and moves it closer to corresponding input button. Fixed: 1155235 Change-Id: I28668a1699843a08010e6e5311b9176e8d56ecea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579808Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#834985}
-
Rouslan Solomakhin authored
Before this patch, Web Payment would enable app store integration on Chrome OS when invoked from an origin that has a TWA, even if not currently running in a TWA. This allowed tabs to invoke the app store billing flow. This patch returns an empty TWA package name to Web Payment when Browser::app_controller() is null. After this patch, Web Payment enables the app the store billing flow only when running inside of a TWA. Bug: 1156537 Change-Id: Ie0ba5b0980be193dfcab36177d652e4ed2635407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580011Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#834984}
-
Anton Bikineev authored
The bucket index lookup is now initialized at compile-time. Change-Id: I13b7d09d88060f35d2f64197b5fbbd59c3102179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580798 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#834983}
-
Shengfa Lin authored
Automation extension is no longer needed or supported since 85 Change-Id: I6a57f8efd99cec3cde2b2a6de431f8612169b23c Bug: chromedriver:3376 no-try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579881Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#834982}
-
Clark DuVall authored
This warms up the GPU process on startup, which has a significant impact on perf. Pinpoint jobs show big improvements in startup with the WebLayer shell app, but it's likely this will make even more of an impact on client apps with larger code size, since GPU process startup will be slower there. Pinpoint run: https://pinpoint-dot-chromeperf.appspot.com/job/110e71ff520000 -5.1% first_contentful_paint_time -4.3% navigation_commit_time Bug: 1146438 Change-Id: I43e8ab3a0af14083e5a2790d8281e2e0bfa6a6ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580458 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#834981}
-
Tomasz Wiszkowski authored
This change enforces coherency between Java and Native AutocompleteResult in the situation where some of the suggestions originate from the voice input. This change solves the following issues: - GroupSuggestionsBySearchVsURL will include the voice suggestions, - Suggestions can be merged / deduplicated with existing entries - Voice Suggestions will not be listed below grouped entries (suggestions with header), - We are now able to properly report these suggestions to GWS, - We should see fewer reports in Omnibox.Android.InvalidMatch as Java entries will now have corresponding Native matches. Bug: 1151794 Change-Id: I575670781e744f3ac832705c830f3e0e506a83ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568850 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#834980}
-
danakj authored
These bitmaps are safer for transport from untrustworthy sources since all bitmaps should be in N32 format and the browser can make bad assumptions as a result. R=dcheng@chromium.org Bug: 1144462 Change-Id: Ieb4843b337ad2b26d85c49d7630f5966d5bdb378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580544 Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
-
Ryan Sturm authored
When the prefetch request starts, we will use MEDIUM priority, when it is being served, we will convert it to HIGHEST prioirty (derived from navigation resource request). Bug: 11567701 Change-Id: I388336e972675ea72504135c0022c9b56aa3a99c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580447 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#834978}
-
Etienne Pierre-doray authored
For better clang error message, thread safety annotation now uses "context" capability name. SequenceCheckerImpl (likely a bug in clang), but using alias works. Note: SequenceChecker somehow doesn't inherit the capability name from Change-Id: I2339a6f40f0cfaf34d11025a468febeaf8ac1d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577594 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#834977}
-
Joe Downing authored
TL;DR: calculate row size and offsets for |input_sample_| w/o using the stride of the frame provided in ProcessInput(). I am working on getting our H.264 HW encoding solution running again after ~3 year hiatus (we did some prototyping in 2017 but haven't used it since). This solution used to work but when I tried it this week, I hit a crash in libyuv::I420ToNV12() which was called from MediaFoundationVideoEncodeAccelerator::ProcessInput(). After some debugging, the crash appears to be due to the params passed to libyuv::I420ToNV12(). The dst_* params get initialized using the stride of the planes in the VideoFrame instead of the width (in pixels) of the screen. |input_sample_| is initialized using a size which does not take stride into account so the libyuv conversion function eventually runs off the edge of the input_buffer and AVs. It looks like this change was introduced in: https://chromium-review.googlesource.com/c/chromium/src/+/2124213 I'm not sure why other usages of this class have not hit this crash. I suspect that either the usage in the Chrome browser use a VideoFrame with no additional padding (stride - width == 0) or there is something specific to how we are are using this class. Change-Id: Id16415c93cc7f1180d1964e88be4b9db2a6ab36c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572751 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
-
Chong Gu authored
Ignore-Goma-Freeze: the fyi builder will add very little load. Bug: 1156885 Change-Id: I706c935a668acfad6380d89021d4a9549728fe8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580913 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#834975}
-
Bill Budge authored
- Fix experiment groups. Change-Id: If572af8fe4f60699c8013f75af58328be5c8013f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576952Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Auto-Submit: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#834974}
-
Amr Aboelkher authored
The PSM RLWE OPRF/Query response will be assigned to the DeviceManagementResponse in several places after providing the mocked async replies from the server. Thus, this CL is providing helper functions to assign these replies accordingly. The async replies will be used to mock the behaviour when the PSM is in progress and OnConnectionChanged has been triggered, which will trigger RetryStep again. That will be needed due to a bug that shows that both protocols will be executed at the same time, instead of waiting until PSM finishes. Its fix, along with tests will be uploaded in another CL. BUG=chromium:1156119 Change-Id: I0e333987c63eac161437a0853049e015d10a7ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577496Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
-
James Cook authored
ChangeMetricsReportingState() has side effects that occur even if the reporting state didn't change, including recording an UMA metric and clearing some stability data. Change MetricsRecordingObserver to only call the method when the state actually changed, rather than unconditionally on startup and on change. Bug: 1148604 Test: added to unit_tests Change-Id: Ia510bcb99c5b8dd0ad23e7ade0c8595ad8d86cfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580841Reviewed-by:
-
danakj authored
The detection code makes a COM SoftwareBitmap from an SkBitmap, and has a DCHECK to verify the bitmap is N32 format, but the mojom allows other formats. We add CHECKs to ensure that a malicious renderer can not produce an incorrectly sized Buffer. R=reillyg@chromium.org Bug: 1156854 Change-Id: Iecfddbf4512f69bb7102378379ff7129426c488a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580027Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#834971}
-
Phillis Tang authored
Add unit tests for install In-Product Help recording and triggering functions. Bug: 1149670 Change-Id: Ibb91438b6a12787b9eac6794ab8747bd13136009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545782Reviewed-by:
Phillis Tang <phillis@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#834970}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/09a26915bd92..eca04eeeb8d8 2020-12-08 nifong@google.com Always attempt to flatten images with mskp image ids 2020-12-08 johnstiles@google.com Error out gracefully in SPIR-V when an intrinsic is missing. 2020-12-08 csmartdalton@google.com Assert that no FP needs local coords when the variable is void 2020-12-08 fmalita@chromium.org [svg] Text shaping and layout 2020-12-08 johnstiles@google.com Fix GN dirty checking for SPIR-V test files. 2020-12-08 reed@google.com Add flag to hide non-sampling imageshader factories 2020-12-08 brianosman@google.com Remove legacy reference to fInputColor in GrSkSLFP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I38a2accea6264c862df702475a20966c6a800828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579836Reviewed-by:
-
Brandon Wylie authored
Bug: 1148747 Change-Id: I4e1a3ed449ae27a2caca8f1387b9bbf4d407aa39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2579720Reviewed-by:
-
