GitLab

BUG=630355
NOTRY=true

Review-Url: https://codereview.chromium.org/2175903002
Cr-Commit-Position: refs/heads/master@{#407293}

Add dictionaries and seed corpora from AFL.
All of the additions were shown to significantly help afl-fuzz fuzz the target fuzzers.

BUG=611337

Review-Url: https://codereview.chromium.org/2168263005
Cr-Commit-Position: refs/heads/master@{#407292}

This CL nukes ContentBrowserClient::CreateGeolocationDelegate()
and their overrides, and transfers each embedder's callsite to the
appropriate correspondent BrowserMainParts. These embedders are
namely: android_webview,  blimp, cast, chrome and content_shell.

Continuation of https://crrev.com/2127973002/.

BUG=612334

Review-Url: https://codereview.chromium.org/2174613002
Cr-Commit-Position: refs/heads/master@{#407291}

This CL solves a problem with the side nav menu drawer staying open when
using the back/forward buttons. The drawer now closes when navigating
forward or back.

BUG=623903
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2170223002
Cr-Commit-Position: refs/heads/master@{#407290}

* Replaces the previous "Select shipping address" or "Select shipping option"
  prompts with gigantic [SELECT] and [ADD] buttons on the right of each
  incomplete section.

* Caches a copy of the SectionInformation in the relevant PaymentRequestSection
  instances so that we can determine if we need to prompt the user to SELECT
  or ADD new PaymentOptions.

* Buttons are enabled from top to bottom, with only one button enabled at a
  time.  This encourages users to move downward while filling out the form.
  When a button is visible for a section, the only way to interact with the
  section is via the button (no more clicking on incomplete sections to expand
  them).

* The shipping summary section, which combines both the shipping address and
  shipping option fields, can now display a button that shows either the
  button for the incomplete shipping address section or the incomplete shipping
  option section (prioritized in taht order).

* Get rid of and generalizes a bunch of unneeded strings.

* Because the logic is so complicated now, we consolidate most layout updates
  and view visibility checks to updateControlLayout().

* Updates the PaymentRequestDynamicShippingSingleAddressTest to account for the
  lack of summary text for incomplete sections.

* Edits the "select shipping address" string to add "and requirements" to the end.

Videos:
https://drive.google.com/open?id=0B7c8ZkXVwskDZDZWUkhDXzdvLUE
https://drive.google.com/open?id=0B7c8ZkXVwskDRm53UUhHUHZmeW8

BUG=603635

Review-Url: https://codereview.chromium.org/2170693002
Cr-Commit-Position: refs/heads/master@{#407289}

This class is mostly a stub but not quite. And it's also a stub of
LayerTreeHostSingleThreadClient. Break it up into two real stubs
of those interfaces. And it inherits from StubLayerTreeHostClient
and implements just what it needs to be the client for FakeLayerTreeHost.

Now stuff that isn't using FakeLayerTreeHost doesn't need to use
FakeLayerTreeHostClient, they can use the StubLayerTreeHostClient.

R=enne,dtrainor
TBR=miguelg
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2174653002
Cr-Commit-Position: refs/heads/master@{#407288}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0cea24e0..4fd7f380

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2172233003
Cr-Commit-Position: refs/heads/master@{#407287}

I don't understand how gyp works with mojo bindings, but this seems to
fix some compile failures introduced in https://codereview.chromium.org/2158913006

BUG=630666

Review-Url: https://codereview.chromium.org/2173883003
Cr-Commit-Position: refs/heads/master@{#407286}

Fixing soft undo

BUG=618803
R=lushnikov@chromium.org

Review URL: https://codereview.chromium.org/2166603002 .

Cr-Commit-Position: refs/heads/master@{#407285}

Previously, the image would grow larger than kTrayPopupDetailsIconWidth.

BUG=625251

Review-Url: https://codereview.chromium.org/2165133002
Cr-Commit-Position: refs/heads/master@{#407284}

Adds a new browser automation testing library for Autofill.
The library leverages ChromeDriver to playback tasks composed
of user actions. A action recorder extension is included in order
to assist in the process of creating test tasks.

BUG=

Review-Url: https://codereview.chromium.org/2116583004
Cr-Commit-Position: refs/heads/master@{#407283}

This CL adds ComputeTransformsToTarget method which takes a transform id
and effect id and calls this instead of ComputeTransforms when
destination is target.

BUG=622372
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2172003002
Cr-Commit-Position: refs/heads/master@{#407282}

BUG=610521

Review-Url: https://codereview.chromium.org/2113383002
Cr-Commit-Position: refs/heads/master@{#407281}

For tests other than a few LayerTreeTests, this changes all tests that
used a DirectRenderer to use a DelegatingRenderer instead.

FakeLayerTreeHostClient took options for allowing fake software
compositing, but it was unused. The REMOTE_DIRECT_RENDERER_TEST_F macro
was also unused now.

(Also enables SurfaceLayerSwapPromiseWithDraw which was disabled but
the bug is fixed.)

R=enne
TBR=miguelg
BUG=421923,606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2171143002
Cr-Commit-Position: refs/heads/master@{#407280}

BUG=630068

Review-Url: https://codereview.chromium.org/2167843005
Cr-Commit-Position: refs/heads/master@{#407279}

https://chromium.googlesource.com/skia.git/+log/f1491693527a..a1ce2163906e

$ git log f14916935..a1ce21639 --date=short --no-merges --format='%ad %ae %s'
2016-07-22 mtklein DM: don't redirect stderr to verbose.log

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=jcgregorio@google.com

Review-Url: https://codereview.chromium.org/2174013002
Cr-Commit-Position: refs/heads/master@{#407278}

This CL organizes the typemaps in Blink GN build. Previously, we dump
typemaps in Blink to third_party/WebKit/Source/platform/mojo/blink_typemaps.gni,
even though some of them are used by third_party/WebKit/public/. This is wrong
and inconsistent with GYP build. So I added a new typemaps.gni in WebKit/public
to collect them separately.

TBR=pdr@chromium.org

BUG=629566

Review-Url: https://codereview.chromium.org/2172333002
Cr-Commit-Position: refs/heads/master@{#407277}

This is more consistent overall, GetGLImplementation() doesn't tell exactly
whether we're using the core profile, or which version of ES etc.
It also helps testing & fuzzing, because mocks/stubs may implement ES2 but don't
report kGLImplementationEGLGLES2, causing inconsistencies.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2170293002
Cr-Commit-Position: refs/heads/master@{#407276}

This CL fixes both (1) the renderer crash originally fixed by
https://codereview.chromium.org/2165043002, and (2) reverts the part
of that CL which prevents ChromeOS from having zero-velocity
GestureFlingStarts, which caused a regression in two-finger swipe
navigation for touchpad. It also moves the DCHECK from the original CL
to a new location which would have prevented the renderer crashes from
being introduced in the first place.

This CL doesn't include a test, though the test proposed by
khmel@ in https://codereview.chromium.org/2168693003 presumably will
land shortly after this CL.

BUG=627227
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2173603002
Cr-Commit-Position: refs/heads/master@{#407275}

This should allow some unittests (specifically offline pages related
unittests) to create the UINQEService despite not being a browser
process with no IOThread.

BUG=

Review-Url: https://codereview.chromium.org/2172393002
Cr-Commit-Position: refs/heads/master@{#407274}

In the near future, SurfaceIdAllocator will live in clients
and so ui::ContextFactory should not create a
SurfaceIdAllocator directly. Instead, ui::ContextFactory
allocates a new surface client ID, which can be used to
create a SurfaceIdAllocator in clients.

This CL also moves calls to RegisterSurfaceClientId and
InvalidateSurfaceClientId close to
RegisterSurfaceClientFactory and
UnregisterSurfaceClientFactory respectively. In a
subsequent CL, these two will be merged together into
SurfaceFactory.

BUG=627283, 629940
TBR=reveman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2166423002
Cr-Commit-Position: refs/heads/master@{#407273}

Context: https://codereview.chromium.org/2128793003/#msg29

BUG=

Review-Url: https://codereview.chromium.org/2176843002
Cr-Commit-Position: refs/heads/master@{#407272}

Unit tests for https://codereview.chromium.org/2149523002/.
BUG=628496, 624506
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2166923002
Cr-Commit-Position: refs/heads/master@{#407271}

On most platforms the monotonic clock is system wide which means it is
consistent across processes making conversion unnecessary. In fact not
only it is unnecessary but harmfull because the
InterProcessTimeTickConverter (IPTTC) conversion [1] is an estimation
which introduces some error.

The patch limits the usage of IPTTC to platforms that require it which
is any Windows where we cannot use |QueryPerformanceCounter|.

After this change we will only collect UMA metrics[2] for IPTTC on
platforms where it is used.

[1] https://docs.google.com/document/d/1RcaOZ1G8ttAez9YuilvbDJCkCaYuLKqNkVpQvIBqsvM/edit
[2] Affects InterProcessTimeTicks.*

BUG=616574
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2090783002
Cr-Commit-Position: refs/heads/master@{#407270}

This avoids problems with the timer being delayed by nested message
loops and ScopedPageLoadDeferrers, where code in the nested message
loop might access the document and not generate a notification.

The timer was originally added to prevent re-entrant calls to V8,
but that can now be prevented with ScriptForbiddenScope.

BUG=629542
TEST=See bug for repro steps.

Review-Url: https://codereview.chromium.org/2171063002
Cr-Commit-Position: refs/heads/master@{#407269}

The current implementation relies on SkPath::getBounds(), which
computes a conservative result (includes control points).

Use SkPathOps::TightBounds() instead, for an exact answer.

BUG=230599
R=fs@opera.com,pdr@chromium.org,schenney@chromium.org,caryclark@google.com

Review-Url: https://codereview.chromium.org/2168133002
Cr-Commit-Position: refs/heads/master@{#407268}

This provides autorelease support for Mac tasks.

BUG=553459

Review-Url: https://codereview.chromium.org/2172123003
Cr-Commit-Position: refs/heads/master@{#407267}

Review-Url: https://codereview.chromium.org/2179543002
Cr-Commit-Position: refs/heads/master@{#407266}

No-op cleanup extracted from https://codereview.chromium.org/2135413003/#ps40001

In this CL:

 - Explicitly document the threading requirements of the API after grokking its use of locks
   in some places and lack of in some others)
   - (It's mostly thread unsafe; except for a few calls which are okay from the owner
      as well as the underlying thread; and one method which is actually thread-safe)
   - Add assertions as such (and catch issues on try bots :-O -- http://crbug.com/629139)
   - Remove |thread_lock_| which is unnecessary under the documented conditions
     (delayed until http://crbug.com/629139 is fixed..).

 - C++11 member initializers (makes it cleaner to add new POD members and
                              makes constructors simpler -- e.g. |run_loop_| was uninitialized)
 - Assertions and tests for current API which allows Start/Stop/Start cycles
   but wasn't tested... (actually more than that is poorly/not tested in this class
   but I'm merely adding tests for parts I'm stressing in my actual follow-up CL).

 - Comment nits

 - Make event-based tests use WaitableEvent instead of sleeping + toggling a bool.

BUG=629716, 629139

Review-Url: https://codereview.chromium.org/2145463002
Cr-Commit-Position: refs/heads/master@{#407265}

Changes the associated bindings implementation for ChannelMojo
such that remote interfaces can be acquired immediately upon
ChannelMojo construction rather than having to wait for connection
on the IO thread.

Simplifies the Channel bootstrapping process, removing a round-trip
Init message (and in fact the entire IPC::mojom::Boostrap interface)
since there's no need to actually exchange associated interface handles
over the pipe. Instead both sides can assume the other will use a fixed,
reserved endpoint ID for their IPC::mojom::Channel interface.

This also removes the restriction that associated interfaces must be
added to a Channel after Init. Instead the same constraints apply as
with AddFilter: an associated interface, like a filter, may be added
at any time as long as either Init hasn't been called OR the remote
process hasn't been launched.

The result of this CL is that any place it's safe to AddFilter,
it's also safe to AddAssociatedInterface; and any place it's safe to
Send, it's also safe to GetRemoteAssociatedInterface and begin using
any such remote interface immediately.

Remote interface requests as well as all messages to remote interfaces
retain FIFO with respect to any Send calls on the same thread. Local
interface request dispatch as well as all messages on locally bound
associated interfaces retain FIFO with respect to any OnMessageReceived
calls on the same thread.

BUG=612500,619202

Committed: https://crrev.com/e1037f997da9e1d44ca3b09d4ff32f0465673091
Committed: https://crrev.com/508da24622f957a01b076ccd058bfdccc79068a4
Review-Url: https://codereview.chromium.org/2163633003
Cr-Original-Original-Commit-Position: refs/heads/master@{#406720}
Cr-Original-Commit-Position: refs/heads/master@{#407050}
Cr-Commit-Position: refs/heads/master@{#407264}

This CL also let chrome compile against 24.1.1 support library.

BUG=609085

Review-Url: https://codereview.chromium.org/2175513002
Cr-Commit-Position: refs/heads/master@{#407263}

The current plan is to remove the code for M54 but
keep the Panels enabled for M53 to provide more time for transition.

BUG=571511

Review-Url: https://codereview.chromium.org/2176823002
Cr-Commit-Position: refs/heads/master@{#407262}

This DCHECK is clearly not intentional and can't possibly be correct.
It's not being hit in practice today due to the latency of ChannelMojo
setup, but reducing that latency easily exposes it.

TBRing because it's trivial.

BUG=None
TBR=yzshen@chromium.org

Review-Url: https://codereview.chromium.org/2178633002
Cr-Commit-Position: refs/heads/master@{#407261}

This reverts commit 58ac1ade, which
disabled a few flaky tests, and fixes those tests so they are no longer
flaky.

In a follow up change, we'll roll back
https://codereview.chromium.org/2172183002
since this change addresses the flakes caused by that patch.

BUG=630549

Review-Url: https://codereview.chromium.org/2176803002
Cr-Commit-Position: refs/heads/master@{#407260}

platform/ParsingUtilities.h caters to the same needs, so transition
users of skipString(...) to skipToken(...) and remove
platform/text/ParserUtilities.h.

Review-Url: https://codereview.chromium.org/2176623003
Cr-Commit-Position: refs/heads/master@{#407259}

BUG=621070

Review-Url: https://codereview.chromium.org/2167843004
Cr-Commit-Position: refs/heads/master@{#407258}

Revert of [system-health] Add full Google Search story to the System Health story sets (patchset #5 id:80001 of https://codereview.chromium.org/2148843002/ )

Reason for revert:

I see a failure for
benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.search:portal:google
on
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/50880

This is obviously related.

Only one run with this patch has been completed thus far.  Either this change caused the failure or, even if not, this change has caused this test to become flaky (I don't see any failures before this).

Original issue's description:
> [system-health] Add Google Search browsing story to the System Health story sets
>
> This patch adds a single 'search:portal' story (both desktop and
> mobile) which does the following:
>
>   1. Open google.co.uk.
>   2. Type 'what is science' and hit return.
>   3. Scroll down to the Wikipedia result.
>   4. Click on the Wikipedia result and wait until it loads.
>
> This is a prototype of the SH stories with same origin and cross-origin
> navigtation (see
> https://docs.google.com/spreadsheets/d/1t15Ya5ssYBeXAZhHm3RJqfwBRpgWsxoib8_kwQEHMwI/#gid=712129109).
> Equivalent stories for other search pages (Baidu, Yahoo, Amazon, ...)
> will follow shortly (in subsequent CLs).
>
> BUG=589726
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
>
> Committed: https://crrev.com/d6d935821c3afc9c0ce21e2a74a5411b59cb3c66
> Cr-Commit-Position: refs/heads/master@{#407225}

TBR=nednguyen@google.com,petrcermak@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=589726

Review-Url: https://codereview.chromium.org/2173943003
Cr-Commit-Position: refs/heads/master@{#407257}

Use the page transition, which seems more reliable, rather than the
HasUserGesture method, to detect whether a given navigation event was
spawned by the user clicking on a link.

BUG=630072

Review-Url: https://codereview.chromium.org/2165193002
Cr-Commit-Position: refs/heads/master@{#407256}

It turns out that
roundedIntPoint(LayoutUnit::max()) != LayoutUNit::max()
so disable the assert in BackgroundImageGeometry that is really just
checking that we have pixel snapped the phase. We don't check any other
values for pixel snapping, so there's no reason to keep checking phase.

And there's no danger to having an unrounded value here. Nothing breaks.

R=fmalita@chromium.org
BUG=626745

Review-Url: https://codereview.chromium.org/2180433002
Cr-Commit-Position: refs/heads/master@{#407255}

https://chromium.googlesource.com/chromium/src/+/81de34207

BUG=526594
TBR=schenney@chromium.org

Review URL: https://codereview.chromium.org/2173053003 .

Cr-Commit-Position: refs/heads/master@{#407254}