- 14 Feb, 2018 40 commits
-
-
Ted Choc authored
This removes the dependency on an immediate onUpdate from the framework to have a default title. BUG= Change-Id: I0e36b40b25e0a26c618e48cbf99c4a470f19ccf0 Reviewed-on: https://chromium-review.googlesource.com/918781Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#536731}
-
https://skia.googlesource.com/skia.git/+log/8242c5c199f5..0ee866dac78b $ git log 8242c5c19..0ee866dac --date=short --no-merges --format='%ad %ae %s' 2018-02-14 egdaniel Revert "When creating emptyp MipMap proxies, don't instantiate them immediately." 2018-02-14 robertphillips Fix compilation of opList-based DDL implementation Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I09e9f2bce7ccb6f935c9555563dcef49f079c77c Reviewed-on: https://chromium-review.googlesource.com/919246 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536730}
-
erikchen authored
Bug 1: When an AllocationTracker is destroyed from a client disconnecting, queued barrier callbacks would not be run. This would cause the heap dump to never be emitted. Bug 2: The implementation of MemlogConnectionManager::OnNewConnection called mojo::SharedBufferHandle::Create, which uses synchronous IPC with the browser process. This can cause deadlock/timeouts, since the browser process synchronously waits for the memlog pipe to free up and eventually gives up after 10 seconds, tearing down the allocator shim. The solution is to create a dedicated thread for calling mojo::SharedBufferHandle::Create, thus avoiding the deadlock. Change-Id: Ib3f4143381ce03c353ffe93d45794070e3b007d5 Bug: 811711 Reviewed-on: https://chromium-review.googlesource.com/917243 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#536729}
-
Mustaq Ahmed authored
Currently RemoteFrame::Navigate is the user of Frame::HasTransientUserActivation that passes a RemoteFrame*, and it seems wrong because the user activation (user gesture) needed by the navigation should belong to the LocalFrame that initiated the navigation. Follow-up CLs after this one will update UserActivation code in Frame to take a LocalFrame* instead of a Frame*, and get rid of redundant IPCs. Bug: 811414 Change-Id: I771c1694043edb54374a44213d16715d9c7da704 Reviewed-on: https://chromium-review.googlesource.com/914736 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#536728}
-
Louis Romero authored
This delegate method will change in a follow-up CL from notifying the animations will start, to asking the delegate to trigger the animations at its convenience. Context: go/bvc-tab-switcher-animators Bug: 787833 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I3da5140c0dd224fd0689a32461c9ac6f43a6a7ea Reviewed-on: https://chromium-review.googlesource.com/895687 Commit-Queue: Louis Romero <lpromero@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#536727}
-
Hiroki Nakagawa authored
addModule() is the entry point of Worklets (incl. PaintWorklet, AudioWorklet, etc) and it should be the best place to record usage of them. Bug: n/a Change-Id: I3e7ef55911e5ef458988ddccb7a5961cfdf80afa Reviewed-on: https://chromium-review.googlesource.com/912929 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#536726}
-
Rob Percival authored
This reverts commit 885175c6. Reason for revert: https://crbug.com/811566 Original change's description: > Add test coverage of field trial for Certificate Transparency log auditing > > It is intended that this feature will be slowly turned on in the near > future. Only desktop platforms will be enabled initially. > > Bug: 506227 > Change-Id: Ie6669f1ecb07c84ee26f28349b30f3da5b5cbf8f > Reviewed-on: https://chromium-review.googlesource.com/873531 > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Commit-Queue: Rob Percival <robpercival@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536100} TBR=rsleevi@chromium.org,jwd@chromium.org,robpercival@chromium.org,sdoyon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 506227 Change-Id: I46afc0c9ff42d5cd840e02e3982a92079fd60ce5 Reviewed-on: https://chromium-review.googlesource.com/918582Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Rob Percival <robpercival@chromium.org> Cr-Commit-Position: refs/heads/master@{#536725}
-
Samuel Huang authored
This CL declutters archive.Run(), making it easier to build helper tools for Supersize. Extracted functions: - DeduceMainPaths() for path deduction. - AddMainPathsArguments() for related arguments. Change-Id: Ibf65936ac8b71c57e578cb286e5886c8cedad41c Reviewed-on: https://chromium-review.googlesource.com/917187 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#536724}
-
Mihai Sardarescu authored
This CL simplifies the BubbleSyncPromoDelegate API to have a single method to enable sync and to start a Chrome sign-in flow. This CL presents the DICE sync promo in the password saved bubble view. Screenshots (DICE-enabled): https://drive.google.com/file/d/1avvcDAtKx1Wk9ovKKb1FxNxnwhsb_LV_/view?usp=sharing https://drive.google.com/file/d/1U6jD3pvjFoiPYTUoqvOjkcPs0HMlWOgA/view?usp=sharing Screenshots (pre-DICE): https://drive.google.com/file/d/1_99pFN-wdRsgX-MPYCCM7wIw4Z3m8HXg/view?usp=sharing Dice stands for the desktop identity consistency, which enforces consistency between Google accounts in the browser and in the content area. Design doc and mocks: See internal link from bug Bug: 805412 Change-Id: I223abd01e8fac927dc728110b2475335345c362c Reviewed-on: https://chromium-review.googlesource.com/883261 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#536723}
-
Morten Stenshorne authored
One more test passing. TBR=atotic@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I19f5b593a0275b49b8af58080a6a2204d7242d8f Reviewed-on: https://chromium-review.googlesource.com/919067 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#536722}
-
Alex Clarke authored
If only a single call to Emulation.setVirtualTimePolicy is made with waitForNavigation:true then addInspectorEmulationAgent wasn't getting called in time, which meant InspectorEmulationAgent::FrameStartedLoading wasn't called for the navigation, which meant the virtual time policy was never changing. Bug: 777763 Change-Id: I7525ed1de924319c195ecfdd602c3fad808eba59 Reviewed-on: https://chromium-review.googlesource.com/918665Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#536721}
-
Gustav Sennton authored
The WebView support library (in the Android Support Library) and the WebView support library glue (in Chromium) will both need methods for mapping a class loaded in some ClassLoader into a class loaded in the current ClassLoader. In this CL we put that utility in the boundary interface directory to avoid duplicating this Class-conversion functionality in both the Android Support Library and Chromium (instead this functionality will be mirrored from Chromium into the support library). Bug: 788177 Change-Id: Icea382115bedd53d1b255d3a115fff03fcdb15ba Reviewed-on: https://chromium-review.googlesource.com/919062Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Gustav Sennton <gsennton@chromium.org> Cr-Commit-Position: refs/heads/master@{#536720}
-
Gustav Sennton authored
Android publishes all public APIs that are not marked with the @hide annotation. Boundary interfaces are not supposed to be public to apps. In this CL we add a file with the sole purpose of hiding the boundary interface package from apps. Bug: 788177 Change-Id: I58c9c7a8445c1a3fdfda3164735f5e2c755dfc44 Reviewed-on: https://chromium-review.googlesource.com/918861Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Gustav Sennton <gsennton@chromium.org> Cr-Commit-Position: refs/heads/master@{#536719}
-
Miguel Casas authored
This CL changes the TRACE_ for accelerated video decode from the current "Video Decoder" to "media.gpu", since trace categories are never more than one word, and there seems to be plenty of categories composed with dot (e.g. cc.debug.quads etc). This category doesn't seem to be named in Chromium OS tests, so this change should not affect anyone. This CL also adds a new entry for Vaapi video encoding. Bug: 811912 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I170252752ab32c49bb4e479469700be396f6421b Reviewed-on: https://chromium-review.googlesource.com/916887 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#536718}
-
Ian Clelland authored
(Except for vibration; that one still gets its own flag) Bug: 810879 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I97bdcc651e6c3d99cc0aff279e83080ea153d031 Reviewed-on: https://chromium-review.googlesource.com/912157Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#536717}
-
https://skia.googlesource.com/skia.git/+log/fc711a2b0143..8242c5c199f5 $ git log fc711a2b0..8242c5c19 --date=short --no-merges --format='%ad %ae %s' 2018-02-13 egdaniel When creating emptyp MipMap proxies, don't instantiate them immediately. 2018-02-14 rmistry [Android Compile Bot] Check if patch/hash is not from origin/master 2018-02-12 liyuqian Add SkDAARecord to prepare for init-once 2018-02-09 liyuqian Add header file installation tips for building skia Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I6571a8286a65fd9b77ac5a923b755a14f1f6b3cf Reviewed-on: https://chromium-review.googlesource.com/919101 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536716}
-
Nektarios Paisios authored
Makes our implementation more similar to native dialogs on Windows, like the Run dialog. R=dmazzoni@chromium.org, sadrul@chromium.org Bug: 779297 Change-Id: Idde84c1664f4cc7af43b6470825ff4cdc3ddd475 Tested: Using Inspect tool from the Windows SDK Reviewed-on: https://chromium-review.googlesource.com/902842Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#536715}
-
Kevin McNee authored
Bug: None Change-Id: I1585edfd43dd688dba38fff659fa74a9366fe8dc Reviewed-on: https://chromium-review.googlesource.com/916548Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#536714}
-
Maks Orlovich authored
disk_cache users should only need to go through disk_cache.h; the individual _impl.h files aren't public API. Change-Id: Ie2e7f696ec81e03ff00dbfcfc5535fd7929acf83 Reviewed-on: https://chromium-review.googlesource.com/916742Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#536713}
-
Tim Dresser authored
This is a reland of fe64540e. Original change's description: > Report First Input Delay across OOPIFs, report First Input Timestamp. > > Previously we only reported for documents in the same process. > > Adds InteractiveTiming.FirstInputTimestamp UKM, > PageLoad.InteractiveTiming.FirstInputTimestamp UMA. > > Bug: 803935, 808089 > Change-Id: I182d764257c6ad215c585b938f11a47c88c00b32 > Reviewed-on: https://chromium-review.googlesource.com/901802 > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Bryan McQuade <bmcquade@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536358} Accidentally skipped CQ. Then reverted. TBRing original reviews: TBR=bmcquade@chromium.org, dtapuska@chromium.org, isherman@chromium.org, tsepez@chromium.org Bug: 803935, 808089 Change-Id: Ia4e47ea1fd4bc557a193b84e199dd9f3ddf1e6cb Reviewed-on: https://chromium-review.googlesource.com/916007 Commit-Queue: Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#536712}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/15403669..8c345b4a Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I31d648a71d1d97a21d0388c802840a1dfeda6d3a Reviewed-on: https://chromium-review.googlesource.com/918743Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#536711}
-
https://webrtc.googlesource.com/src.git/+log/5dbb58602f24..d377f041944f $ git log 5dbb58602..d377f0419 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icb8138e36a04d68786e54a3debd6705a2e43100d Reviewed-on: https://chromium-review.googlesource.com/918961 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536710}
-
Chandan Padhi authored
Intent to implement and ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/h4sCuIqb_78 Bug: 293292 Change-Id: Ib1869d4e940cffb3012572451268dec1ffb55a0e Reviewed-on: https://chromium-review.googlesource.com/899402 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#536709}
-
Rohit Rao authored
These serve as common model classes that can back either UICollectionView or UITableView. CollectionViewModel is updated to be a subclass of ListModel with added restrictions on permitted item types but no functional changes. CollectionViewController and its subclasses are largely unchanged. BUG=805136 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibcfbab5bae62c5c8a37f764508294421d3d1c307 Reviewed-on: https://chromium-review.googlesource.com/916365 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#536708}
-
Justin Cohen authored
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I913bc2bbe5d6ef5a2434d44c020c34bf5299343e Reviewed-on: https://chromium-review.googlesource.com/916712Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#536707}
-
Amirhossein Simjour authored
This CL moves AnchoredPopupWindow, RectProvider, and ViewRectProvider to ui/android/widget. This is needed to avoid circular dependency between DropdownPopupWindow and AnchoredPopupWindow. BUG=809758 Change-Id: If019ede28561a36b3f079806334bf85acc49c219 Reviewed-on: https://chromium-review.googlesource.com/909553 Commit-Queue: Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#536706}
-
https://skia.googlesource.com/skia.git/+log/6ce969472e2e..fc711a2b0143 $ git log 6ce969472..fc711a2b0 --date=short --no-merges --format='%ad %ae %s' 2018-02-13 robertphillips Add SkCharacterization creation helper to GrContextThreadSafeProxy (take 2) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Ia3d2464b6a513f9a49f89de19630f072302e828d Reviewed-on: https://chromium-review.googlesource.com/918921 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536705}
-
Finnur Thorarinsson authored
- Ensure Settings and Close are visible always (for non-Chrome OS). - Add "from this site" to the "block all notifications" string. Bug: 810873,768300 Change-Id: I85eb7753614e8cd678343d06de6160b9dac5d50d Reviewed-on: https://chromium-review.googlesource.com/913271 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#536704}
-
François Beaufort authored
This CL prepares the PictureInPictureWindow interface by adding the |resize| event handler to PictureInPictureWindow. We currently don't receive resize events from the backend. Triggering |resize| event will come in a future CL. Bug: 806249 Change-Id: Ib10eabc0e35af782dcdb36862535063d2dab0a2c Reviewed-on: https://chromium-review.googlesource.com/908562Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#536703}
-
Mugdha Lakhani authored
Bug: 799483 Change-Id: I9411d141492ae3db3f6baf413b31c7daa099b3a0 Reviewed-on: https://chromium-review.googlesource.com/918801Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#536702}
-
Friedrich Horschig authored
The title of the (only displayed) category causes confusion with Talkback because it was counted as search result entry. As it also doesn't need to be shown according to the latest mocks, removing it should be just fine. Bug: 808260 Change-Id: I870bb02f9f936dbf4f41ad3edb9cf1b9f0617dec Reviewed-on: https://chromium-review.googlesource.com/918621Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#536701}
-
Finnur Thorarinsson authored
Font metrics are calculated in two different ways on Windows, (Chrome uses DirectWrite, unit_tests GDI), so there is a slight offset that needs to be accounted for. Bug: 768300 Change-Id: Ia43e95df199b9e81ca37fae64bca76a4b9cc1d3c Reviewed-on: https://chromium-review.googlesource.com/915943 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#536700}
-
arthursonzogni authored
This revert commit fbeba561. Reason for revert: I suspect it breaks: GetAllPagesV1HandlerTest.testMultiplePages in chrome_test_apk downstream (crbug.com/811221). Original change's description: > Everything is the same as the original land, except for changes > to offline_page_test_archiver.cc and .h. > I've added a new test override of the new function that was added > in the original changelist, so the test override will be called > in unit tests. This was causing unit test failures in the internal > clank builds, even though it passed all the unit tests in the commit > queue. > > Original changelist: > https://chromium-review.googlesource.com/c/chromium/src/+/896555/12 > > Bug: 758690 > > Publish the Offline Page to a public directory > > This change will move the offline page to a public directory and inform > the system download manager if any (for instance, on Android) of the > location and type of the file. If both steps succeed, the > offline page item will be written to the offline page model database. TBR=petewil@chromium.org,dimich@chromium.org,jianli@chromium.org,carlosk@chromium.org Bug: 758690,811221 Change-Id: Ic055aeaf7369fd0696ccbb10c72be177e75ee693 Reviewed-on: https://chromium-review.googlesource.com/918541 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#536699}
-
Naina Raisinghani authored
We used to have some inline style map layout tests for a subset of properties. This patch moves them to WPT using the new test harness. Properties added: - position - padding-{top,bottom,left,right} - text-align - text-decoration-style Bug: 774887 Change-Id: I9fc9d6d425b1a5ce0c71f8d918bc5893c74c4e89 Reviewed-on: https://chromium-review.googlesource.com/917927 Commit-Queue: nainar <nainar@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#536698}
-
François Beaufort authored
According to UI review deck, the Picture-in-Picture icon should live at the very bottom of the list in the overflow menu. Test page: https://beaufortfrancois.github.io/sandbox/media/overflow-video.html Screenshots: https://imgur.com/a/lnH1e Bug: 726621 Change-Id: Id0075ec3524842200eacc315539233a494edc484 Reviewed-on: https://chromium-review.googlesource.com/916381Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#536697}
-
Tim Schumann authored
CrossSiteDocumentBlockingServiceWorkerTest.NoNetwork and CrossSiteDocumentBlockingServiceWorkerTest.NetworkAndOpaqueResponse They were already marked as flaky for Android and fail with the same error on Linux CSI. Bug: 809735 Change-Id: I62d8f8d152af287fd3c983806d430c5bd4e1d93e Tbr: creis@chromium.org,lukasza@chromium.org Reviewed-on: https://chromium-review.googlesource.com/918581 Commit-Queue: Tim Schumann <tschumann@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#536696}
-
Tsuyoshi Horo authored
Bug: 803774 Change-Id: I271421221cad33a61ec1b4e329fb7e5cc53289cd Reviewed-on: https://chromium-review.googlesource.com/911268 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#536695}
-
Victor Costan authored
First, Chrome currently requires iOS 10.0 or above. Second, as of today, Chrome for iOS will use our patched version of SQLite, removing an unnecessary point of divergence between platforms. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-device Change-Id: I365713588d079658d5be9c1282d40f591aba05f7 Reviewed-on: https://chromium-review.googlesource.com/907497Reviewed-by:
Randy Smith <rdsmith@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#536694}
-
Thomas Tangl authored
This CL implements the storage mechanism for the images in AccountTrackerService. Images are save to and loaded from disk. Bug: 794522 Change-Id: I6e54b5467e11d8f32a8518ab042218e74914ca3c Reviewed-on: https://chromium-review.googlesource.com/913575Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#536693}
-
Kush Sinha authored
Mirror is now available on Chrome OS via a preference. Use of truth for checking whether Mirror is enabled in the Settings page. AccountConsistencyModeManager: :IsMirrorEnabledForProfile as the source Change-Id: I4a8c2ddd4242953bd13fdb06ace2ef9d715850b3 Reviewed-on: https://chromium-review.googlesource.com/913608Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#536692}
-