- 01 Oct, 2020 40 commits
-
-
Jimmy Gong authored
Fully implements the FindMyDeviceControllerImpl class. This change also features a new state: kRingingNotAvailable. This state is only set if the DoNotDisturb is enabled. Bug: 1106937 Test: chromeos_components_unittests Change-Id: Ifeb4dd88ea19ad6949bad2a92d840f392d7ccd47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438773 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#812962}
-
Peter Kotwicz authored
Design doc: https://docs.google.com/document/d/1SNrFzWCXb4KaegXH8nokilOHGSkTFvLfhK75ZwmIKaE/edit?usp=sharing This CL introduces //third_party/androidx/fetch_all_androidx.py which retrieves androidx dependencies from snapshots in https://androidx.dev/snapshots/latest/artifacts and runs //third_party/android_deps/fetch_all.py The version of the androidx dependencies is generated based on information in https://androidx.dev/snapshots/latest/artifacts/BUILD_INFO The CL also: - Fixes fetch_all.py --ignore-vulnerabilities command line parameter to skip 'dependencyCheckAnalyze' step. - Adds the 'useDedicatedAndroidxDir' parameter to build.gradle to replace androidx dependencies in //third_party/android_deps with a java_group() which points to the target declaration in //third_party/androidx BUG=1064277 Change-Id: I652e56a9721154487c10fafaa2008fc728b9d8b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399773 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#812961}
-
Xinghui Lu authored
The goal is to replace the current SBER checkbox with this new enhanced protection message whenever the user is able to opt-in to enhanced protection. It applies to SAFEBROWSING, SSL and CAPTIVE_PORTAL interstitials. Adds a section named enhanced-protection-message in interstitial_large.html, and adds a new command named CMD_OPEN_ENHANCED_PROTECTION_SETTINGS in interstitial_commands.mojom to handle the callback from js to c++. Screenshot: http://screen/5AirLStp39i24Gm. To follow the mocks, an icon and a different background color will be added in a future CL. Also adds a chrome flag named safe-browsing-enhanced-protection-message-in-interstitials to control this feature. Bug: 1130721,1130745 Change-Id: Ic5924ae2324a5fed1760b5549cb915c3279f1dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427548 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#812960}
-
Sami Kyostila authored
This patch switches the background tracing subsystem to control tracing through the Perfetto client API. The main benefit of this is being able to specify priorities for tracing sessions (incl. legacy JSON ones), which avoids interfering with interactive tracing sessions such as ones from the DevTools profiler. Bug: 1058632 Change-Id: I9c35e079a75a51fd4472011eee23fd431a720bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404830Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#812959}
-
Daniel Classon authored
Adds missing punctuation to the reverse scrolling setting strings that were causing i18n issues. Screenshot (same image): https://storage.cloud.google.com/chromium-translation-screenshots/f516453a6d7a904e39e84ec3a0aa12b6e0343203 Buganizer bug: https://buganizer.corp.google.com/issues/169863233 Bug: 1132398 Change-Id: I0de91a3ed664bbaab97dd92c9382a1569e113329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443212 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
-
Max Curran authored
Downloaded HTML were being intercepted and being downloaded as Offline Pages. In cases where the headers included "Content-Disposition: attachment", the Offline Page download would fail. I have added an extra constraint when intercepting the download that excludes cases with the specified header. Bug: 1041209 Change-Id: Ia3c3ca1db4e4526c355700ed661c390a06de2d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443791 Commit-Queue: Max Curran <curranmax@chromium.org> Auto-Submit: Max Curran <curranmax@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812957}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Idcb844b8f862e5eea8c6db6adf6796c82c70b386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443789Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812956}
-
Yusuf Sengul authored
Bug: 1129714 Change-Id: Ibd98640f75a306c327f11c5aca1d81acd334f4a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417551 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#812955}
-
Meilin Wang authored
This CL adds handlers for "Get started" and "Dismiss" buttons on the onboarding screen. Misc: Update unittests in |PhoneHubUiControllerTest|. BUG=1106937,1126208 TEST=unittested. Change-Id: I6576b3fb32c1bd5b6a96a61ff9fcdc5ac9c2fc70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439363 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#812954}
-
George Burgess IV authored
Unless it's guaranteed that `std::forward` always turns into an rvalue ref, using `std::move(x)`, where `x`'s type is a universal reference, is generally unsafe. `std::forward` is preferred for these cases. Bug: 1134310 Change-Id: I9f00c6bf7dff033191adf75a9943a0e9cb139b1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443730 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: George Burgess <gbiv@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#812953}
-
Xi Han authored
Bug: 1132948, 1076274 Change-Id: Ib0047b913bd7a844f7a59b36d6e4e40b097f4a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443543Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#812952}
-
Tomasz Wiszkowski authored
This change extracts the gesture events from SuggestionViewDelegate and moves the Gesture event reporting over to the OmniboxSuggestionDropdown. Currently, gestures are only reported by the suggestions inheriting from BaseSuggestion MVC component. As an effect, custom suggestion types do not correctly respond to user initiating interaction with the Suggestions list (ie. the list may be updated as the user attempts to scroll the list or collapses the header) and may be reporting inaccurate times (this specifically affects the QueryTiles at this point). The update moves this reporting to a centralized place, ensuring that all the events will be correctly reported, including custom suggestion types. The only case not covered (that was also not covered previously) is the keyboard interaction. Bug: 1106109 Change-Id: I54811d316cf420fc0ea7bbb10b807ef7b3ac196a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440975Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#812951}
-
Josiah K authored
Fixed: 1111074 AX-Relnotes: Fix shaking movement while navigating the Chrome menu in docked magnifier Change-Id: Icdae63357af284fcce68f4a5d73c26fac7f6628a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418012 Commit-Queue: Josiah Krutz <josiahk@google.com> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#812950}
-
Darwin Huang authored
Replace all uses of whitelist with allowlist in ContentSettings code. Bug: 842296 Change-Id: I51442289ad63651313515ab3e2db76e2bc2dfe06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439554Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812949}
-
Jordan Bayles authored
Currently, some of the TabCapture tests are disabled, due to historic flakiness. A lot of this is due to using an invalid URL, causing the web contents to be flaky/broken. This patch re-enables tests and fixes some of them by using actual domains and improving test isolation. Some tests are reenabled with the hope that they will be more more stable now... will have to monitor. Bug: 427730, 674517, 764464 Change-Id: Ic8cb93388572ff5e5828e6179cb728084c9324d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438290 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#812948}
-
Yue Li authored
The current text annotation model we are using is not good at concatenated words like "SampleClassName" and words contains special characters like "test_example(". Since it takes time for us to roll up to the v2 model, filter such kind of queries for now to improve the quality. Bug: b/159664194 Test: Manual Test Change-Id: I203388766b160fa7f3368702e1c75683a3e148ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440832 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by: -
Tarun Bansal authored
The previous ownership in tools/metrics/histograms/OWNERS is no longer relevant. Change-Id: I3fe050c396011ae88c8766d8e259b8a32cf9c20b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442094 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#812946}
-
Sophey Dong authored
Bug: 1133398 Change-Id: Ie8787bd6f5772805a94c972163cd8a4e7735ef03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442097Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#812945}
-
Marijn Kruisselbrink authored
A previous CL made opening files on special volumes via the file picker and file handling APIs work, this also fixes the entry point for drag&drop in a similar manner. The bulk of this change is changing NativeFileSystemMangerImpl to use the file system backends instead of base::File to determine if a path is a file or a directory. Bug: 1132102 Change-Id: I6c64356ea285b717ce63afc9c34d097bcde08016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432808Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#812944}
-
Patrick Monette authored
The voting system that existed for frames must be expanded to also support workers. This means the old name was no longer adequate. Bug: 971272 Change-Id: Iaa6a368b6c36a7971388acef14b5182cdd507b29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432669Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#812943}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/72a6843cad22..d2958971d9c5 2020-10-01 fmayer@google.com Merge "Allow to use data_source_stop_timeout_ms in java_heap_dump." 2020-10-01 treehugger-gerrit@google.com Merge "perfetto_cmd: Use monotime for sendfile timeout" 2020-10-01 treehugger-gerrit@google.com Merge "Add missing stddef.h header in compiler.h" 2020-10-01 treehugger-gerrit@google.com Merge "processor: Update null names of legacy Chrome async tracks on lookup." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I9e335d669e8fe66130631a440c14594e6808e5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441381Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812942}
-
Karan Bhatia authored
This reverts commit 1b26f574. Reason for revert: Causes HidServiceTest.OpenAndNavigateCrossOrigin to fail. Original change's description: > [hid] Replicate self-destruct logic in connection fake > > HidConnectionImpl is self-owned and will self-destruct on > disconnection of the HidConnection or HidConnectionWatcher. > This CL modifies the FakeHidConnection used in tests so it > behaves the same way. > > BUG=1126689 > > Change-Id: I8bbdcca7c77699749c6022f01b8a456c4891cdb8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441151 > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Auto-Submit: Matt Reynolds <mattreynolds@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#812858} TBR=reillyg@chromium.org,mattreynolds@chromium.org,andypaicu@chromium.org Change-Id: Ibd1de02feee8d39e071a3291f3dce2062eff3270 No-Presubmit: true No-Tree-Checks: true No-Try: true TBR: mattreynolds@chromium.org Bug: 1126689, 1134346 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443760 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#812941}
-
Leonard Grey authored
This command source adds commands to create a new Doc, Sheet, Meet etc. It doesn't require any integration, since it takes advantage of the new docs.new etc. URLs. (This change also populates CommanderController's default command sources) Bug: 1014639 Change-Id: I1acef15e9eac2cda11b0087419ee8ccb6328dd9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442871 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#812940}
-
David Bertoni authored
Bug: 1093066 Change-Id: I295f3167a49054acd8498728bbb87981c13390f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427033 Auto-Submit: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#812939}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ie40d71cc1ad5821a4dc6f17f2dd5ca484572c656 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442647Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#812938}
-
Haiyang Pan authored
This reverts commit 38fddca3. Reason for revert: content_browsertests should be covered on android CQ. We could remove test suites that are covered by M from L so that L does not have capacity issue. Original change's description: > Disable content_browsertests from android-lollipop-arm-rel. > > Bug: 1131618 > Change-Id: I1cbdfeb79ed0b86afe8351bfd10f642851adfb87 > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427126 > Commit-Queue: Anjali Doneria <adoneria@google.com> > Reviewed-by: Haiyang Pan <hypan@google.com> > Reviewed-by: Erik Staab <estaab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#809953} TBR=estaab@chromium.org,martiniss@chromium.org,hypan@google.com,adoneria@google.com Bug: 1131618, 1133002 Change-Id: I2d56ce960db789cd650cd90f6d00a53ce8e96fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434676Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#812937}
-
Caitlin Fischer authored
Bug: 1126640 Change-Id: Ie6027b53de6b832424d7c926581786aab5d4fe93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437023Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#812936}
-
spdonghao authored
Bug: 1113852 Change-Id: Ic5a75d929b1ee4b62b3925a7d47a8c05886d87b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426566Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#812935}
-
Nate Fischer authored
No change to logic. This autogenerates AwFeatures.java from aw_features.cc using the java_cpp_features GN rule. Fixed: 1128789 Test: autoninja -C out/Default system_webview_apk Change-Id: If3f3f36384e04328428f3feb05bffa62c02fcdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412798 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#812934}
-
Antonio Gomes authored
BUG=1113900 R=jamescook@chromium.org Change-Id: I7e1eb50571f25a5713e4795fa34f3de07b1a3022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443394 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/dba4db5668d6..29ef556aff96 2020-10-01 alessiob@webrtc.org AGC2: max adaptation speed now part of config If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1781ddd717d5afecab52807416be8c1e2fbdd846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443286Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/da5828c06b4c..16ebcf601d7f 2020-10-01 brandon1.jones@intel.com Limit Clear Color Values to 2^24 For Integer Formats If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I84a407a2b8ce27620a5beced24b9b80adde00aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441708Reviewed-by:
-
Henrique Nakashima authored
This will be used in the builder to generate stats to track the progress of modularization (which is done by running some scripts manually at the moment. Sample output: {"class_edges": 51396, "class_nodes": 8368, "inbound_ChromeActivity": 196, "inbound_ChromeTabbedActivity": 24, "package_cycles_size_equals_2": 390, "package_cycles_size_up_to_4": 19949, "package_edges": 7932, "package_nodes": 744} Bug: 1133838 Change-Id: Ia732386706740df290e58b0187c25589320217b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441323 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#812930}
-
David Black authored
Currently the file_icon_util will return kGoogleGrey700 icons for icons which do not have a color. In some cases, this is too low contrast to be easily seen. A follow up CL will make use of this newly exposed color param to request theme colors for file icons in the holding space feature. Bug: 1133913 Change-Id: I8e0f13ce9fb19782de950d7bb8fbe04ca21fb5cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443390Reviewed-by:
-
Peter Kotwicz authored
This strict mode violation is caused by a strict mode in com.samsung.android.feature.SemCscFeature#isUseOdmProduct() on Samsung devices BUG=1121181 Change-Id: If76dff59f26b26b65e0ca71ecf76fb3d7a2df4a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415277 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601553580-367c6f76c3cbdd1ced1ecc49db85241195c30ea6.profdata to chrome-linux-master-1601575120-46ddcdbe4da420985f324196a05692689b215d89.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id9b1d1a00b04fff135466116a1186658ee57337c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443280 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Reda Tawfik authored
This CL records user actions on the warning dialog and the bottom sheet for the AllPasswordsBottomSheet. Adds a test for recording histogram. Bug: 1104132 Change-Id: I88afa34eb9d1562c138e4b967dca4da9d09e0b8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429072 Commit-Queue: Reda Tawfik <redatawfik@google.com> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#812926}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I616b7ee629c60295d76c5773b4961812bee1a33d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443450Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1e5bef446919..6b79223314a5 2020-10-01 chonggu@google.com Reland "[Fuchsia] Allow passing through ssh_config file directly, make port optional." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: If981d732aed102fbb14bd18af0c2d81eb049249e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2443282Reviewed-by:
-
Jia authored
If a client makes rapid index updates that are intrinsically async, there may be a race condition so that updates are not done in the right order. This cl checks ongoing updates and queue later updates when necessary. Bug: 1133931 Change-Id: I0edbf57f2039b8a4dc51b75292788f22464eef9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440320 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812923}
-
