GitLab

Network is by far the largest subdirectory of chromeos.
This gives it its own BUILD.gn file.

Also added a ":chromeos_implementation" config.
Better to use a single config than a define each time, less chance for
undetected spelling errors.

Bug: 446937
Change-Id: I2f26cf3f9f15c4b4db364d7d2bc6cf5cc7e57887
Reviewed-on: https://chromium-review.googlesource.com/c/1276568
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599216}

TBR=mmoroz@chromium.org

Change-Id: Ic807cb7245d1093bf78cb9bb1c81e08520c1fd55
Reviewed-on: https://chromium-review.googlesource.com/c/1277911Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599215}

Bug: 840371
Change-Id: Ia606c6a773b202be623fc31d9dcb542a4e483d7f
Reviewed-on: https://chromium-review.googlesource.com/c/1277186
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599214}

Bug: 878390
Change-Id: Ic2b7bbf2221e91a81802be040c1bc41a5230c13c
Reviewed-on: https://chromium-review.googlesource.com/c/1273270Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599213}

DMServer dropped support for iOS recently and also
IOS_BROWSER is removed from registration types.

Change-Id: Iaa8e5619a1f85110d8d76744a711999f09fb0580
Reviewed-on: https://chromium-review.googlesource.com/c/1273070Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599212}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1c128aa9efd9..e5455648879b


git log 1c128aa9efd9..e5455648879b --date=short --no-merges --format='%ad %ae %s'
2018-10-12 greg@lunarg.com Consider atomics that load when analyzing live stores in ADCE (#1956) (#1958)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@e5455648879b

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Id920e27775336e02f65b2bad6b75329008923664
Reviewed-on: https://chromium-review.googlesource.com/c/1278714Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599211}

This CL uses ScopedBlockingCall to mark blocking calls in /components/metrics.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation (MAY_BLOCK/WILL_BLOCK). See
    BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

Bug: 874080
Change-Id: Ifa1cba993d25114f81984771e50d4734ef66a954
Reviewed-on: https://chromium-review.googlesource.com/c/1191325Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599210}

This reverts commit 04cab8f6.

Reason for revert: The data logged here shows we are very likely not creating a bunch of HistoryAddPageArgs that aren't getting written. The highest count created was 3 (the majority are 0), which implies this isn't an issue. See bug for more details.

Original change's description:
> history: adds minimal memory dump information for history
> 
> Before I add more exhaustive information I want to make sure I'm on the right
> track. This adds the count of the number of outstanding requests to add a
> page (url and other information) that haven't been processed yet.
> 
> BUG=807009
> TEST=none
> 
> Change-Id: Ieb18fe74e9e91fe4f99eb1a791b04367c60cfd0d
> Reviewed-on: https://chromium-review.googlesource.com/1234240
> Commit-Queue: Scott Violet <sky@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Siddhartha S <ssid@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#592916}

TBR=sky@chromium.org,erikchen@chromium.org,ssid@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 807009
Change-Id: Ic0c01697bced51123b71f059905d98f9945eaa2f
Reviewed-on: https://chromium-review.googlesource.com/c/1276945Reviewed-by: Siddhartha S <ssid@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599209}

This reverts commit 1c6c9d1b.

Reason for revert: Breaks tests when combined with https://chromium-review.googlesource.com/c/chromium/src/+/1260491. Doesn't properly wait for devicesync service to be ready before querying the list of devices.

Original change's description:
> Make Instant Tethering work with legacy hosts before hosts update.
> 
> The phone side flags and enrollment will be slower than the ChromeOS
> rollout. In order to avoid breaking Instant Tethering in the meantime,
> look for cases where:
> 
> 1) There are no host devices reporting BETTER_TOGETHER_HOST support.
> 2) There is at least one host device reporting INSTANT_TETHER_HOST
> support.
> 
> In this scenario, the only possiblity is that this host device has not
> reenrolled yet after receiving the new flags.
> 
> Bug: 893769
> Change-Id: Ib7fd0acdbe80903a499dd0dd42fd60365304371d
> Reviewed-on: https://chromium-review.googlesource.com/c/1277272
> Commit-Queue: Jeremy Klein <jlklein@chromium.org>
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599058}

TBR=khorimoto@chromium.org,jlklein@chromium.org

Change-Id: Iee7a71e551e875764f38cdf72391378cdacc80bc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 893769
Reviewed-on: https://chromium-review.googlesource.com/c/1278541Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599208}

The histogram that counts token state transitions was not correctly
tracking the cases when Chrome fails to load a token for the primary
account. This CL adds this entry to the histogram. This should allow us
to understand to what extent Chrome fails to load tokens from disk.

Bug: NONE
Change-Id: I6237d5090984e0244a6203d60f2c319072b73555
Reviewed-on: https://chromium-review.googlesource.com/c/1278731
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599207}

* The service shouldn't unregister from the topics, when handler
the Handler is unregistering from topic (as stated in the documentation
for for UnregisterHandler).
* Sync shouldn't unregister on browser shutdown

TBR=gab@chromium.org, pavely@chromium.org

Bug: 894752, 801985
Change-Id: If676d159ba7d7beeebf325bce2e78b5847da3f76
Reviewed-on: https://chromium-review.googlesource.com/c/1277908Reviewed-by: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599206}

This CL is adding trace events to look closer on some slow cases
happening in the browser process. Traces will be collected via
slow-reports and an investigation will be continued based on results of
these events.

R=fdoray@chromium.org, ccameron@chromium.org

Bug: 894459
Change-Id: I2e3c37e9a42ceef9ca9aea5ec94a125db247aa77
Reviewed-on: https://chromium-review.googlesource.com/c/1277825
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599205}

In CL 1171374 'lazyload' feature policy was introduced as a new
policy-controlled feature which would modify (restrict) the usage of the
lazyload attribute. The implementation only applied the feature to frame
owner elements. This CL extends the policy's coverage to images as well.

Bug: 869492
Change-Id: I9a2bd309ac366b75308b657d3ea129a7717ad23f
Reviewed-on: https://chromium-review.googlesource.com/c/1251024
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599204}

Nothing prevents CookieMonsterChangeDispatcher::Subscription to
outlive CookieMonsterChangeDispatcher.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ifa2cd0c8def9ae1c63a0a3d37bd469bbbc78e5ca
Reviewed-on: https://chromium-review.googlesource.com/c/1242460
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599203}

Bug: NONE
Change-Id: I18d05d59ba0be38d7598396fab2cef8b44647fcf
Reviewed-on: https://chromium-review.googlesource.com/c/1278754Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599202}

Change a CHECK to an logged warning if madvise is attempted when code
ordering has not been performed. This happens on upstream builds
including arm64 builds.

Bug: 894748
Change-Id: Icdb7ae0c94cfad5beec0215c6186e29135c1079a
Reviewed-on: https://chromium-review.googlesource.com/c/1278746Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599201}

This patch means removing the preference and functions
that reference it.
Because preference is set but never read, that is indeed obsolete.

Bug: 889908
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I22a80bed2387b08480dae9c930bb1d329dd8c45d
Reviewed-on: https://chromium-review.googlesource.com/c/1264343
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599200}

https://webrtc.googlesource.com/src.git/+log/55d1af14751a..c34cf71d6017


git log 55d1af14751a..c34cf71d6017 --date=short --no-merges --format='%ad %ae %s'
2018-10-12 oprypin@webrtc.org Revert "Remove old video_bitrate_allocator.h"
2018-10-12 mbonadei@webrtc.org Move SdpType from/to string definition close to declaration.


Created with:
  gclient setdep -r src/third_party/webrtc@c34cf71d6017

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I7014c484f5486bdc51a05adc2b602509c6c86207
Reviewed-on: https://chromium-review.googlesource.com/c/1278713Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599199}

Bug: 872904
Change-Id: I44e020b7d7d121650f4c292b71b4d2dbc45fa9f3
Reviewed-on: https://chromium-review.googlesource.com/c/1277765Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599198}

We used to have only one flag, --auto-update, which controls both
uploading and landing the import CL. This makes testing new setup of the
bot (i.e. LUCI in this case) hard.

This change adds one more flag, --auto-upload, to exercise more steps
(namely uploading and rebaselining), which will be used on the
experimental LUCI builder.

Bug: 790503
Change-Id: I4ce07fc9ddf15a34c9cb25ba4723d250cad26977
Reviewed-on: https://chromium-review.googlesource.com/c/1277587
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599197}

This was accidentaly removed as part of FrameLoadRequest cleanup.

Bug: none
Change-Id: I58bf324729d397a2f0340831fd116ab749f7a213
Reviewed-on: https://chromium-review.googlesource.com/c/1278290
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599196}

ProfileSyncService::platform_sync_allowed_provider_ was a callback that
returned whether Android's "Master Sync" toggle is enabled, and so Sync
shouldn't start up. However, PSS didn't know when the value changed, so
the callback was kinda useless, and PSS could easily get into an
inconsistent state (where there is a disable reason, but Sync is still
running). Things were working out in practice only because the Android
UI code also called RequestStart/Stop as necessary.
So, since PSS needs change notifications anyway, let's make that
explicit: This CL replaces the callback by a bool, which can be set
explicitly.

Bug: 867901
Change-Id: I5b7e9f4657d1f565d9643984eb52ec1df26b5c90
Reviewed-on: https://chromium-review.googlesource.com/c/1269870Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599195}

Change-Id: I71ed01f39d1c81c62828d8e4900091e7941e7ab1
Reviewed-on: https://chromium-review.googlesource.com/c/1278399Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599194}

Know issues:
 * Skia only draws Y plane.
 * makeYUVAPromiseTexture() will release context, even if it failed.
 * Skia doesn't accept GL_RGBA8 format for a yuva plane

Bug: 824382
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ic8da2b3de574ef2a0d527c79f34d383a676a3bc0
Reviewed-on: https://chromium-review.googlesource.com/c/1262421Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599193}

This CL fixes some edge condition interactions when being loaded as
a ReadableStream.  In particular, it:

1. Properly distinguishes between the end of the DataPipe and a closed
   DataPipe with bytes left to be read.  A ReadableStream that is not
   actively draining the pipe could get closed too early.
2. Responses must support explicit completion in order to handle error
   conditions properly.  This CL makes DataPipeBytesConsumer wait
   for an explicit signal before closing.
3. Service worker navigation preload is updated to provide the explicit
   completion signals.

Bug: 894815
Change-Id: I8cff3de94aa2dcbc8deb4a9601a95c13b8ab94d9
Reviewed-on: https://chromium-review.googlesource.com/c/1272715
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599192}

Change-Id: I9bac8317577feaadfa00ec88661175b7338ced4a
Reviewed-on: https://chromium-review.googlesource.com/c/1267596Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Shu Chen <shuchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599191}

This reverts commit 5cd8c123.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 599026 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWNkOGMxMjNlNDUyYzBiNzZmYmJjYWY1M2U4MmQ4NmNhN2Q1NDkzMAw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/9016

Sample Failed Step: viz_browser_tests

Sample Flaky Test: FileDisplay/FilesAppBrowserTest.Test/fileDisplayWithoutVolumesThenMountDrive_DriveFs

Original change's description:
> Files app: Select My files when there are no volumes
> 
> Make Files app select "My files" when there are no available volumes,
> this to allow Files app to behave properly when volumes subsequently
> become available.
> 
> Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
> non-null |displayRoot| before trying to change to |displayRoot|. This
> fixes the error "Cannot read property 'getParent' of null" when Drive
> volume becomes available before Downloads volume, which is the default
> volume/root.
> 
> Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
> DriveFsTestVolume can re-mount itself.
> 
> Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
> Bug: 893161, 884967
> Change-Id: Ic813b25261530495c11c9f641a92f6e07f883702
> Reviewed-on: https://chromium-review.googlesource.com/c/1272418
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Reviewed-by: Sam McNally <sammc@chromium.org>
> Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599026}

Change-Id: I883485c8fc1bdcc22dba93cc4b03b7c157dcb5f2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 893161, 884967, 889703
Reviewed-on: https://chromium-review.googlesource.com/c/1278063
Cr-Commit-Position: refs/heads/master@{#599190}

ProfileSyncServiceBundle owns and exposes signin-related objects for
use by sync tests. These signin-related objects include ones that are
deprecated by IdentityManager and no longer used directly in the
production code being tested; however, up until now it has not been
feasible to convert this test utility to using IdentityTestEnvironment,
as doing so would have required converting the widespread usage of this
utility in one go.

We recently introduced an IdentityTestEnvironment usage mode wherein
it can be supplied with IdentityManager's dependencies from the
external client, precisely to enable incremental conversion in use cases
like this. This CL exploits this usage mode to introduce
IdentityTestEnvironment in ProfileSyncServiceBundle.h and provide an
example of its usage to eliminate a direct usage of the deprecated
classes. Once the conversion is complete, ProfileSyncServiceBundle can
then be changed to *only* hold an IdentityTestEnvironment object.

Bug: 886600, 886599
Change-Id: I205c3567fc0a9bcd6f7b613c00a247c302d71be5
Reviewed-on: https://chromium-review.googlesource.com/c/1273065
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599189}

Using wpt-import in Chromium 68550e48.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/25974

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=lukebjerring

No-Export: true
Change-Id: I132a332cdc953a69e5c54c550a9bb4e5d08c9bb5
Reviewed-on: https://chromium-review.googlesource.com/c/1277603
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599188}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f37e9866851d..2cecd6e79600


Created with:
  gclient setdep -r src-internal@2cecd6e79600

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Iac9c77c5c0927e0ca3862bf5171f5972e5c40ca7
Reviewed-on: https://chromium-review.googlesource.com/c/1278711Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599187}

Needed some rebaselining on Mac.

Attempted to mark it as passing here:
https://chromium-review.googlesource.com/c/1277649

Then a sheriff marked it as failing again:
https://chromium-review.googlesource.com/c/chromium/src/+/1278785

TBR=kojii@chromium.org,orphis@chromium.org

Change-Id: I4b282cba19e6c94f032c127f70672cf4cfe133ab
Reviewed-on: https://chromium-review.googlesource.com/c/1278805
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599186}

We currently log the UserDeletedCookieOrCacheFromDialog histogram from
Desktop. On Android we only know about total cookie/cache deletion
and not those started from CBD.
This CL adds logging of the UserDeletedCookieOrCacheFromDialog histogram
to the CBD dialog on Android.

Change-Id: I51c1ff6d3c5dc6f531f5bfccc59f522718b1abef
Reviewed-on: https://chromium-review.googlesource.com/c/1276605
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599185}

The call site of this function is resetting the |allowed_touch_action_|
only, so rename this function to ForceResetTouchActionForTest.

This CL should not introduce any behavior change.

Bug: None
Change-Id: I253d73f4f21bdb6268f43ce535453412f4b32c51
Reviewed-on: https://chromium-review.googlesource.com/c/1277947
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599184}

https://webrtc.googlesource.com/src.git/+log/28d200c24624..55d1af14751a


git log 28d200c24624..55d1af14751a --date=short --no-merges --format='%ad %ae %s'
2018-10-12 terelius@webrtc.org Remove support for microsecond resolution in RtcEventLogs.
2018-10-12 sprang@webrtc.org Move TemporalLayers to api/video_codecs.


Created with:
  gclient setdep -r src/third_party/webrtc@55d1af14751a

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I15b74c4ebe322c1004b1ba8d1cfb25d82b65614c
Reviewed-on: https://chromium-review.googlesource.com/c/1278709Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599183}

This is a reland of 475bfe9d. Fixed test
failures which happened because some DCHECKs had side effects.

Original change's description:
> [sync::test] Add single client integration test for custom passphrase
>
> Add a Sync integration test which exercises custom passphrase flows, including
> the handling and proper functioning of the newly added key derivation method
> (scrypt).
>
> Add an integration test helper file for encryption-related tasks and modify
> FakeServer and LoopbackServer to allow easier modification of persistent
> entities such as Nigori. Add passphrase-related functionality to
> ProfileSyncServiceHarness to give tests better control over how and when
> passphrase-based encryption is enabled.
>
> The test uses a gray-box approach, where it tests the client at the
> ProfileSyncService granularity, but injects and inspects entities on the (fake)
> server to ensure that encryption is performed properly. This is necessary
> because, when it comes to encryption, we are not interested merely in that it
> does not hinder existing functionality (e.g. two clients are syncing data
> properly in the presence of a custom passphrase), but also that it provides the
> expected security to the user. For this reason, we use our knowledge of the
> encryption architecture internals to ensure that the data committed to the
> server is encrypted in the expected way.
>
> Bug: 894148
> Change-Id: I728f7f18cc0db7b1da50f747a87a640877d0b023
> Reviewed-on: https://chromium-review.googlesource.com/c/1274205
> Commit-Queue: David Davidović <davidovic@google.com>
> Reviewed-by: vitaliii <vitaliii@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#598912}

Bug: 894148
Change-Id: I752acff5815531c0c83ebefb43fb620a785e3ca3
Reviewed-on: https://chromium-review.googlesource.com/c/1278790
Commit-Queue: David Davidović <davidovic@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599182}

WebNode::IsFocusable() updated style and layout tree, without ignoring
pending stylesheets, which meant generating a display:none placeholder
style for the root node. Instead, early return from IsFocusable() when
we are blocking rendering.

Bug: 521692

Change-Id: Idd6cfcf800e4173cfc1bdcb916728c7a0186edf9
Reviewed-on: https://chromium-review.googlesource.com/c/1245787Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599181}

This reverts commit 7bd91635.

Reason for revert: fast/css-grid-layout/grid-columns-rows-get-set.html is flaky
Bug: 894792, 894795

Original change's description:
> [blink] Control ScriptStreamer with ScriptResource
> 
> Move the ScriptStreamer control logic from ClassicPendingScript to
> ScriptResource. In the future, this will allow us to start streaming
> a ScriptResource before the ClassicPendingScript is available, e.g on
> preload.
> 
> The ClassicPendingScript now only sends one "finished" callback, from
> ScriptResource. This callback is either when the streaming completes,
> or when there is no streaming and the ClassicPendingScript has told
> the ScriptResource that it doesn't intend to start streaming. In the
> long run, we want all scripts to go through the streaming interface,
> and we want ScriptResource to control when streaming starts, so the
> "no more streaming" call will disappear -- however it is necessary to
> maintain the current behaviour, and be able to control it with a
> runtime flag.
> 
> Bug: chromium:865098
> Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e
> Reviewed-on: https://chromium-review.googlesource.com/c/1181430
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599148}

TBR=kinuko@chromium.org,rmcilroy@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org

Change-Id: Id8e8df8f960c60c88762cdf837e7ba9eb74944d6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:865098
Reviewed-on: https://chromium-review.googlesource.com/c/1278758Reviewed-by: Florent Castelli <orphis@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599180}

This reverts commit e9c79d56.

Reason for revert: single_process_mash_browser_tests failing on chromium.memory/Linux ChromiumOS MSan Tests
Bug: 894799

Original change's description:
> Make DriveFS opt-out in FilesApp tests.
> 
> Bug: 891197
> Change-Id: Id3101a43cfe97e652d71f720b5f312b933af1113
> Reviewed-on: https://chromium-review.googlesource.com/c/1277133
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Commit-Queue: Sam McNally <sammc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599117}

TBR=noel@chromium.org,sammc@chromium.org

Change-Id: If9140eb468d1e27aeb217a3202b638aa0f4e20f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 891197
Reviewed-on: https://chromium-review.googlesource.com/c/1278757Reviewed-by: Florent Castelli <orphis@chromium.org>
Commit-Queue: Florent Castelli <orphis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599179}

Currently, IdentityTestEnvironment internally constructs all the
dependencies of IdentityManager as well as the IdentityManager object
itself. This behavior is nice for hiding the fact that IdentityManager
has these dependencies from consumers, but doesn't allow for
usage of IdentityTestEnviroment in incremental conversion of tests that
have broad direct usage of these dependencies. Concretely,
profile_sync_test_util.h provides one such problematic case: it
constructs and directly exposes these dependencies, which are then
broadly used by a set of tests that consume this utility class.
Converting all these tests in one go is not practical.

This CL adds an alternate IdentityTestEnvironment constructor that
takes in the dependencies and constructs IdentityManager via those
passed-in dependencies. To enable this constructor, the CL also
encapsulates the fact that IdentityTestEnvironment otherwise obtains
these dependencies from an internal object within the current
IdentityTestEnvironment constructor.  It also moves ownership of
IdentityManager from that internal object to IdentityTestEnvironment
itself so that it can be created/owned independent of that internal
object.

A followup CL will use this new constructor.

Bug: 886599
Change-Id: I4c6a503dcc11c327193f80bc7d7c48e467c6919b
Reviewed-on: https://chromium-review.googlesource.com/c/1273298
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599178}

This CL makes it possible to append values to list-valued properties.

To do this, we must produce a CSSStyleValueVector which holds the final
value produced by the append (i.e. the concatenation of the existing
values and the incoming values). Then (like for StylePropertyMap.set),
a CSSVariableReferenceValue with equivalent tokens is created from that
vector.

Bonus: Fix names of some tests to make it easier to read the output.

R=chrishtr@chromium.org

Bug: 641877
Change-Id: I0d58f66255a9ff7e14c1ee8f4d243353b9a4a0da
Reviewed-on: https://chromium-review.googlesource.com/c/1270967
Commit-Queue: Anders Ruud <andruud@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599177}