- 13 Oct, 2018 40 commits
-
-
Tanja Gornak authored
Bug: 801985, 894501 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I20613ab10fbce214fcd9f430ae9e9d09913429c4 Reviewed-on: https://chromium-review.googlesource.com/c/1276648Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#599504}
-
Alexander Hendrich authored
This reverts commit 75d0995f. Reason for revert: Causes DCHECK crashes on sign-in Original change's description: > Updated AllowedUILocales to handle preferred languages. > > Updated AllowedUILocales to limit not only the ui locales but also the > available preferred languages. Renamed AllowedUILocales to AllowedLanguages to > better indicate that. > > Bug: 579660, 876494, 894406 > Cq-Include-Trybots: luci.chromium.try:closure_compilation > Change-Id: Iae929216e164fe941e5e335a3ce2e7ff47dce0e3 > Reviewed-on: https://chromium-review.googlesource.com/c/1256570 > Commit-Queue: Zakhar Voit <voit@google.com> > Reviewed-by: Sergey Poromov <poromov@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597559} TBR=stevenjb@chromium.org,droger@chromium.org,poromov@chromium.org,hendrich@chromium.org,voit@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 579660 Change-Id: I6107a6668abde445d972a97e63dca93446b0ab0d Cq-Include-Trybots: luci.chromium.try:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/c/1278761Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#599503}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b49cd41ba210..3c580c7e2860 Created with: gclient setdep -r src-internal@3c580c7e2860 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5d1096fdbf42a1f70dc7b71c752fdcc185a13bf3 Reviewed-on: https://chromium-review.googlesource.com/c/1279911Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599502}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/355f9eaaf10a..4f5ccaaecd7e git log 355f9eaaf10a..4f5ccaaecd7e --date=short --no-merges --format='%ad %ae %s' 2018-10-13 thestig@chromium.org Fix span / unique_ptr destruction order in PDF_DataDecode(). 2018-10-13 thestig@chromium.org Make testing/ pass gn check. 2018-10-13 thestig@chromium.org Fix v8 ToLocalChecked() failure in CJS_Runtime. Created with: gclient setdep -r src/third_party/pdfium@4f5ccaaecd7e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:895026,chromium:894938 TBR=dsinclair@chromium.org Change-Id: I385c86e2fdb8668f66ff1842698837b25f463ae2 Reviewed-on: https://chromium-review.googlesource.com/c/1279913Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599501}
-
Tanja Gornak authored
Bug: 894764 Change-Id: If190cdf6396b567c9ab5e983d67d4f25b20d501b Reviewed-on: https://chromium-review.googlesource.com/c/1278787Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#599500}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fc6076842c5f..366257823d3a git log fc6076842c5f..366257823d3a --date=short --no-merges --format='%ad %ae %s' 2018-10-13 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@366257823d3a The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ifb83ae71a90df5a923b7f01ad6c7917ea269bd26 Reviewed-on: https://chromium-review.googlesource.com/c/1279910Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b28db529c866..bc7a51e79c5b git log b28db529c866..bc7a51e79c5b --date=short --no-merges --format='%ad %ae %s' 2018-10-13 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files Created with: gclient setdep -r src/third_party/skia@bc7a51e79c5b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=stani@chromium.org Change-Id: I40ac54f4cd83f0d3effb7cb34f93c4b53ed6fe49 Reviewed-on: https://chromium-review.googlesource.com/c/1279909Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e421d384ca88..355f9eaaf10a git log e421d384ca88..355f9eaaf10a --date=short --no-merges --format='%ad %ae %s' 2018-10-13 thestig@chromium.org Add missing config to core/fxcrt:seekablemultistream target. 2018-10-12 xlou@chromium.org Add setters/getters for BleedBox and TrimBox. 2018-10-12 tsepez@chromium.org Beef up coverage in CJS_Field. 2018-10-12 thestig@chromium.org Split core/fpdfapi build rules into various sub-directories. 2018-10-12 thestig@chromium.org Make core/fxcrt pass gn check. Created with: gclient setdep -r src/third_party/pdfium@355f9eaaf10a The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:894655 TBR=dsinclair@chromium.org Change-Id: Ibf405817acf8815d4c7cbdc285edc90d5a97c8a2 Reviewed-on: https://chromium-review.googlesource.com/c/1279906Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I60ad72c09d4efffe2ac67afaba0cb3455c439d28 Reviewed-on: https://chromium-review.googlesource.com/c/1279912Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bc3adfd851d0..b49cd41ba210 Created with: gclient setdep -r src-internal@b49cd41ba210 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I87466c480e9628ca9a252182a946f8bd098bcc1f Reviewed-on: https://chromium-review.googlesource.com/c/1279908Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7e67041a1428..b28db529c866 git log 7e67041a1428..b28db529c866 --date=short --no-merges --format='%ad %ae %s' 2018-10-13 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@b28db529c866 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=stani@chromium.org Change-Id: I0ff6ab3d59bc58fa86477cac1b7aab84ea06aec7 Reviewed-on: https://chromium-review.googlesource.com/c/1279907Reviewed-by:
-
John Z Wu authored
1. Test |currentIdentity|. 2. Test |passphraseNeeded| and |unlockWithPassphrase:|. Bug: 770984 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8dd57cd0aeb772b24aaeffc6a0b833dba1e866fe Reviewed-on: https://chromium-review.googlesource.com/c/1278991 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#599493}
-
CJ DiMeglio authored
Because the conditions in which we turn on surfaces for videos have grown more complicated, and because surfaces for MS (MediaStream) has pretty much been implemented, it has been decided that special-casing MS videos was no longer required. Bug: 746182 Change-Id: Ie79c56ba80707c9b3e102eba9bcc712e994065b2 Reviewed-on: https://chromium-review.googlesource.com/c/1250095 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#599492}
-
Aleks Totic authored
Bug: 612962 Change-Id: I794b3010dd4d234f81be025987cda38b134aae4e Reviewed-on: https://chromium-review.googlesource.com/c/1279355Reviewed-by:
-
John Z Wu authored
Use account profile so data is tied to the signed in user. Bug: 867548 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib43b4af2f015bd405a2f321c048468eabd010fb9 Reviewed-on: https://chromium-review.googlesource.com/c/1279175Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3ccb6ac29e42..bc3adfd851d0 Created with: gclient setdep -r src-internal@bc3adfd851d0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I02b86de00ae06336c7efdc5e56435eb08dbe0e2c Reviewed-on: https://chromium-review.googlesource.com/c/1279905Reviewed-by:
-
Richard Li authored
In this CL, function in content::SWFetchRequest::Serialize is moved into content::ServiceWorkerUtils::SerializeRequestData. This work is a preparation for removing content::SWFetchRequest. BUG=789854 Change-Id: Ic0867e4ee75a19488b92a62a44cd2bad14839a63 Reviewed-on: https://chromium-review.googlesource.com/c/1270519 Commit-Queue: Richard Li <richard.li@intel.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#599488}
-
Wenzhao Zang authored
Bug: 882595 Change-Id: I7bce42ce07325fd72e842ac86dd1ee8fc9753460 Reviewed-on: https://chromium-review.googlesource.com/c/1278802Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599487}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/01815d76afed..7e67041a1428 git log 01815d76afed..7e67041a1428 --date=short --no-merges --format='%ad %ae %s' 2018-10-13 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 c97e3f6684c7..79b914075cc5 (1 commits) Created with: gclient setdep -r src/third_party/skia@7e67041a1428 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=stani@chromium.org Change-Id: I4dca0ccac74d78d5ed26e85d1c97dce8ac3e0cdd Reviewed-on: https://chromium-review.googlesource.com/c/1279904Reviewed-by:
-
Daniel Cheng authored
Bug: 891908 Change-Id: Ibe82744b16c7655b76dc1dfbf11fb158a0316fc7 Reviewed-on: https://chromium-review.googlesource.com/c/1277827 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#599485}
-
Sammie Quon authored
We can now fling to show or hide launcher. Uses same threshold as in app list view. Also change app list show/hide from a shelf button to use longer animation, to match ux spec. Test: ash_unittests HomeLauncherGestureHandlerTest.Fling* Bug: 888617 Change-Id: I73de8ad6fdeace7f9ef34124eb2e5741e92b3371 Reviewed-on: https://chromium-review.googlesource.com/c/1279296 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#599484}
-
Findit authored
This reverts commit 21ba6121. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 599360 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMjFiYTYxMjFkMmJhNTgyMTUxNWJjYjlmM2ZkZjc2ODIwNDQyNTA2MQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14616 Sample Failed Step: viz_content_browsertests Sample Flaky Test: BrowserSideFlingBrowserTest.GFCGetsBubbledFromOOPIF Original change's description: > Reland "Fling bubbles from OOPIF properly." > > This is a reland of a12ef847 > > The reland has the following two fixes: > 1- In the added tests, we wait for the ack of the GSB from the parent view to make > sure that GFS is processed after GSB has been bubbled to avoid the flakiness. > 2- Early return in BubbleScrollEvent to avoid crbug.com/828422 > > Original change's description: > > Fling bubbles from OOPIF properly. > > > > While we are bubbling a scroll sequence GFS is sent to the fling controllers > > of both the oopif and the bubbling target. The fling controller of the oopif > > calls progressFling and generates a GSU with inertial phase, the GSU gets acked > > immediately before getting sent to the renderer since we are in bubbling mode. > > Then the oopif's fling controller receives the unconsumed GSU ack and generates > > a GSE to complete the scrolling sequence on the oopif. The bubbling target's > > fling controller receives and processes the GFS and generates GSUs which are > > sent to the target's renderer. > > > > If the GSE generated by the oopif's fling controller gets bubbled before > > the GFS, the bubbling target gets reset and the target does not receive the > > GFS. This cl fixes the issue by making sure that the events generated by the > > oopif's fling controller are not bubbled to the target. Also in case of > > GFS bubbling, the GFC should also get sent to the bubbling target to make > > sure that the fling controller in charge of flinging receives the GFC. > > > > > > Bug: 884728, 249063 > > Test: BrowserSideFlingBrowserTest.[Touchpad|Touchscreen]FlingBubblesFromOOPIF > > Change-Id: I064944f125bebcb746f329af4cfb117f3be94ff0 > > Reviewed-on: https://chromium-review.googlesource.com/c/1274193 > > Reviewed-by: Kevin McNee <mcnee@chromium.org> > > Reviewed-by: Charlie Reis <creis@chromium.org> > > Commit-Queue: Charlie Reis <creis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#599001} > > Bug: 884728, 249063 > Change-Id: I1528d904e84ff85f7828392c2b0178a42869d529 > Reviewed-on: https://chromium-review.googlesource.com/c/1278963 > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Reviewed-by: Charlie Reis <creis@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599360} Change-Id: I5553104cdf30a18fb9399b486d5c403a67dda409 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 884728, 249063, 895059 Reviewed-on: https://chromium-review.googlesource.com/c/1279943 Cr-Commit-Position: refs/heads/master@{#599483}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5a81fddd7cbb..3ccb6ac29e42 Created with: gclient setdep -r src-internal@3ccb6ac29e42 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I522b6a4d9fe8c58842dfa0a18b0ee005cfb744da Reviewed-on: https://chromium-review.googlesource.com/c/1278937Reviewed-by:
-
bbvch13531 authored
This CL covers presubmit warning due to base::ThreadChecker. Bug: 810841 Change-Id: I2b8718c33a4cb2c38e5d5a7a96387d904dc659d3 Reviewed-on: https://chromium-review.googlesource.com/c/1191342Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#599481}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I435c4c23426964b1e52c7bcd51f2d1bce6d23215 Reviewed-on: https://chromium-review.googlesource.com/c/1279370Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#599480}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1de6f5099019..5aac72d05c7e git log 1de6f5099019..5aac72d05c7e --date=short --no-merges --format='%ad %ae %s' 2018-10-12 benjhayden@chromium.org Copy tsmon-client from infra to catapult/third_party. Created with: gclient setdep -r src/third_party/catapult@5aac72d05c7e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:867060 TBR=sullivan@chromium.org Change-Id: Idb554b580eced8f014dafaaa9e762839d3d40937 Reviewed-on: https://chromium-review.googlesource.com/c/1277703Reviewed-by:
-
Kenneth Russell authored
conformance/textures/misc/tex-video-using-tex-unit-non-zero.html was flaky because of the ExtraWebGLVideoTextureMetadata flag. Since that's no longer being specified for the WebGL tests, this test is expected to be reliable. Bug: 830901 Tbr: kainino@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie3ae83d67bb47b3bfbe1db898e5fce1745b18e48 Reviewed-on: https://chromium-review.googlesource.com/c/1279430Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#599478}
-
Zhuoyu Qian authored
In the context of ServiceWorker, We should rename "pattern" to "scope", wherever it is used in the context of service workers. Bug: 840272 Change-Id: I982c179077a2a690ecf06d1efe70bac46fc871ec Reviewed-on: https://chromium-review.googlesource.com/c/1273197Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#599477}
-
Lei Zhang authored
They are already specified on the PDFium side. One of these has moved so depending on it is breaking the DEPS roller. Also roll src/third_party/pdfium 29b708e7af32..e421d384ca88 (20 commits) https://pdfium.googlesource.com/pdfium.git/+log/29b708e7af32..e421d384ca88 2018-10-12 thestig@chromium.org Do IWYU in xfa. 2018-10-12 tsepez@chromium.org Beef up CJS_Document method coverage. 2018-10-12 thestig@chromium.org Split core/fxcrt build rules into core/fxcrt/BUILD.gn. 2018-10-12 tsepez@chromium.org Add test for CJS_Annot JS callbacks. 2018-10-12 thestig@chromium.org Remove more unnecessary includes and do IWYU as needed. 2018-10-12 thestig@chromium.org Split most core build rules into various BUILD.gn files in core. 2018-10-12 thestig@chromium.org Move core/fdrm/crypto/* to core/fdrm/. 2018-10-12 thestig@chromium.org Split constants and testing build rules into their own BUILD.gn files. 2018-10-12 tsepez@chromium.org Add test for CJS_Color properties. 2018-10-12 tsepez@chromium.org Add tests for CJS_Console methods. 2018-10-12 thestig@chromium.org Split fpdfsdk build rules into various BUILD.gn files in fpdfsdk. 2018-10-12 thestig@chromium.org Split fxjs build rules into fxjs/BUILD.gn. 2018-10-12 thestig@chromium.org Split xfa build rules into various BUILD.gn files in xfa/. 2018-10-12 thestig@chromium.org Slightly simplify CPDF_FormField's notify methods. 2018-10-12 thestig@chromium.org Rename CPDF_{Array,Dictionary}::GetCount() to size(). 2018-10-12 thestig@chromium.org Forward declare more in codec code. 2018-10-12 thestig@chromium.org Remove redundent ASSERT + if checks in CPDF_FormControl. 2018-10-12 thestig@chromium.org Split fxbarcode build rules into fxbarcode/BUILD.gn. 2018-10-12 thestig@chromium.org Add minimal pixel test for a rendering bug. 2018-10-12 thestig@chromium.org Fix naming for CPDF_FormField::Type enum. TBR=tsepez@chromium.org Change-Id: Ifbdb52bf0d184cd03206979fc4f50c750bd4f343 Reviewed-on: https://chromium-review.googlesource.com/c/1279362 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#599476}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d38382d060ca..01815d76afed git log d38382d060ca..01815d76afed --date=short --no-merges --format='%ad %ae %s' 2018-10-13 hcm@google.com Update Skia milestone to 72 Created with: gclient setdep -r src/third_party/skia@01815d76afed The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=stani@chromium.org Change-Id: I92659e6cc735b57e73a0b83234f64669b25c0263 Reviewed-on: https://chromium-review.googlesource.com/c/1279902Reviewed-by:
-
kokihoon authored
arraysize is deprecated, we should use base::size() instead. This CL changes arraysize to base::size in ios Bug: 837308 Change-Id: Ic24c06e57f254976ee791f7094313cdbd0125ed7 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/c/1257469 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Collin Baker authored
gfx::Path is currently just an SkPath with additional ways to construct it. Furthermore, those additional constructors are not used. This CL removes those unused constructors. A future change would be removing gfx::Path and replacing all uses of it with SkPath. Change-Id: Ib1e56841d23e79c6da1ab419429afd5e37f8a8aa Reviewed-on: https://chromium-review.googlesource.com/c/1275135 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#599473}
-
Etienne Bergeron authored
This CL is a first step towards fixing performance issues with fonts. It's removing an useless fonts iterator. The iterator is only used to copy fonts from a vector to an other vector. R=fdoray@chromium.org Bug: 894459 Change-Id: Iadeeea61ad5f06dbd4b9ad2a9d440b7dba8742fd Reviewed-on: https://chromium-review.googlesource.com/c/1278849Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#599472}
-
Nektarios Paisios authored
Sorted methods and switch cases in ax_role_properties in alphabetical order and added const to method arguments Also, renamed all remaining methods to drop the "Role" suffix. Just a small cleanup CL. R=dtseng@chromium.org, aleventhal@chromium.org Change-Id: I29760dc1c8ecf7b54a840489800ca5c843d27298 Reviewed-on: https://chromium-review.googlesource.com/c/1208450 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#599471}
-
Alexander Alekseev authored
Bug: 895000 Change-Id: I2a561a784e013e7d175ba31c5415b82c67d1bb59 Reviewed-on: https://chromium-review.googlesource.com/c/1279385 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#599470}
-
Makoto Shimazu authored
The issue seems to happen due to resolving respondWith after waitUntil. It should not happen, so this CL changes DCHECK to CHECK and add a new CHECK to ServiceWorkerContextClient. Bug: 889567 Change-Id: I0391b43e5aa89a8b936cb0fbf5866c8e18ef94a2 Reviewed-on: https://chromium-review.googlesource.com/c/1275785Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2f0e716fa7b9..5a81fddd7cbb Created with: gclient setdep -r src-internal@5a81fddd7cbb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I240c8afa96794a26f311538faeee889618c481c6 Reviewed-on: https://chromium-review.googlesource.com/c/1277704Reviewed-by:
-
Henrique Grandinetti authored
effect immediately. Bug: 895036 Change-Id: Icfa7364e8217e4df9904154bf1372328187bd4a6 Reviewed-on: https://chromium-review.googlesource.com/c/1279368Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Cr-Commit-Position: refs/heads/master@{#599467}
-
Dmitry Titov authored
Bug: 895045 Change-Id: I2f542536bf61d8953d88f42959ee47f07e73150e Reviewed-on: https://chromium-review.googlesource.com/c/1279364Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Dmitry Titov <dimich@chromium.org> Cr-Commit-Position: refs/heads/master@{#599466}
-
Dale Curtis authored
The trun element is capable of generating sample information from zero data, in these cases there's no reason to iterate 0..sample_count. Hopefully this can help reduce timeouts in the fuzzers too; though now they'll probably just OOM instead. BUG=891900 TEST=none R=chcunningham Change-Id: I9466bbbc1238cba2c5d28f12f5efff506568ac28 Reviewed-on: https://chromium-review.googlesource.com/c/1279360 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#599465}
-
