- 28 Apr, 2020 40 commits
-
-
Ken MacKay authored
This allows internal code to resample without directly depending on Chromium media code. Bug: internal b/148569388 Change-Id: I08ecf20daf1be67727a18b7ce6829d28854ccffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170424 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#763519}
-
Aran Gilman authored
This reverts commit 9781ff27. Reason for revert: The original CL is completely unrelated to the flaky test; actual culprit CL is https://crrev.com/c/2167751. Original change's description: > Revert "Refactor Reader Mode's JavaScript tests to use Mocha." > > This reverts commit 7de90169. > > Reason for revert: Suspicious to have broken DomDistillerViewerSourceBrowserTest.UISetsPrefs in browser_tests. > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/37476 > > > Original change's description: > > Refactor Reader Mode's JavaScript tests to use Mocha. > > > > The tests did not previously use an established test framework, making > > tasks like executing certain code before or after every test and testing > > asynchronous code more difficult. It should also be easier for > > developers familiar with JavaScript testing in general and WebUI testing > > in particular to read and write JavaScript tests for DOM Distiller and > > Reader Mode. > > > > Follow-up work includes replacing the custom assert methods with Chai, > > as well as writing more tests to cover existing functionality. > > > > Bug: 1027612 > > Change-Id: I39acc923a0424881d2694281d9aa0323c8f9a913 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992504 > > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org> > > Commit-Queue: Aran Gilman <gilmanmh@google.com> > > Cr-Commit-Position: refs/heads/master@{#762551} > > TBR=wychen@chromium.org,gilmanmh@google.com > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1027612 > Change-Id: I78b6b82e98c8f47951ab88e2056595de878f1ab1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166219 > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Commit-Queue: Yuki Shiino <yukishiino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#762720} TBR=yukishiino@chromium.org,wychen@chromium.org,gilmanmh@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1027612 Change-Id: I8f2faf0eaf6dcaa0e655b5f563874781cdff38fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170418Reviewed-by:
Aran Gilman <gilmanmh@google.com> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#763518}
-
Mark Schillaci authored
This CL removes KitKatWebContentsAccessibility.java and moves all the logic from that class into the parent/base class of WebContentsAccessibilityImpl.java. We will no longer support KitKat going forward, so we can move the KitKat specific code to our parent class since we can be certain that any user is at least at that API level. Bug: 1073117 Change-Id: I862a6c39bd618cc7bbc80d9ac5c13e5d590cb3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159418Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Bo <boliu@chromium.org> Auto-Submit: Mark Schillaci <mschillaci@google.com> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#763517}
-
Peng Huang authored
This reverts commit 9dfaeca2. Reason for revert: The change doesn't fix the crash, we still get surface lost. Original change's description: > Fix crash in gpu::VulkanSwapChain::ScopedWrite::ScopedWrite > > The crash is because the vkAcquireNextImageKHR() fails with > VK_ERROR_SURFACE_LOST_KHR, probably the platform window is > closed, or a new swapchain is created with the same platform > window. Since vkAcquireNextImageKHR() is called just before > rendering DDL to the vkmage, if there isn't a new vkimage > is available, it is too late to properly handle it. Fix > the problem by call vkAcquireNextImageKHR() immemorially after > vkQueuePresentKHR() call. If vkQueuePresentKHR() call is successful, > then the surface should be good, and vkAcquireNextImageKHR() > should be successful too. If surface is lost, vkQueuePresentKHR() > will return VK_ERROR_SURFACE_LOST_KHR., and then the PresentBuffer() > will return SWAP_FAILED to caller. Caller should be able to handle it > properly like it does with GL and glSwapBuffers(). > > Bug: 1070754 > Change-Id: I697cca3a282d046e9592d554403f7c10c811cf19 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155197 > Commit-Queue: Peng Huang <penghuang@chromium.org> > Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> > Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> > Auto-Submit: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760555} TBR=penghuang@chromium.org,vasilyt@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1070754 Change-Id: Ic76b26b30ecb282218ce32701eb3bd143038609b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170978Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#763516}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/587fbb9ef3a5..71c49f8eab3d git log 587fbb9ef3a5..71c49f8eab3d --date=short --first-parent --format='%ad %ae %s' 2020-04-28 amaiorano@google.com Run clang-format on renamed headers 2020-04-28 amaiorano@google.com Rename Vulkan-source .h to .hpp Created with: gclient setdep -r src/third_party/swiftshader@71c49f8eab3d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie9cafb569d24b9370fc39e8ae62d316e4d44234c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170792Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763515}
-
inglorion authored
With this change, goma_link.py and goma_ld.py take a new option, --no-gomacc, which causes them to generate build rules without gomacc invocations. This allows these scripts to be used to break a local ThinLTO linker invocation into smaller commands which still run locally. Bug: 1072888 Change-Id: I47900e40811e9e39248246126491dfeb80725256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158061 Commit-Queue: Bob Haarman <inglorion@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#763514}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c244f5392178..2d79ef264eba git log c244f5392178..2d79ef264eba --date=short --first-parent --format='%ad %ae %s' 2020-04-28 cwallez@chromium.org Do not use Dawn's warnings for compiling Chromium's gtest main. 2020-04-28 bryan.bernhart@intel.com D3D12: Fix invalid allocation size check. 2020-04-28 jiawei.shao@intel.com Add basic supports of readonly and writeonly storage textures on Metal 2020-04-27 xilefmai@gmail.com Fix MSVC compilation. 2020-04-27 cwallez@chromium.org Enable -pedantic and disable currently triggered warnings 2020-04-27 cwallez@chromium.org Fix ValidateRowsPerImage error text. 2020-04-24 cwallez@chromium.org Enable more warning needed for Skia to build with Dawn on Linux 2020-04-24 cwallez@chromium.org Add Matrix chatrooms to README.md 2020-04-24 cwallez@chromium.org Deprecate BufferCopyView.rowPitch/imageHeight -> bytesPerRow/rowsPerImage Created with: gclient setdep -r src/third_party/dawn@2d79ef264eba If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1072449,chromium:1075817 Tbr: cwallez@google.com Change-Id: I62b5622ab62c6489c631c7b4b232efc87aa825e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170793Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763513}
-
Brian Sheedy authored
Causes all RenderTest comparison failures to surface when running the tests locally, even if the particular hardware/software combination is not supported. This is so that developers using unsupported configurations, e.g. an Android emulator, to develop locally can still see pixel output. Bug: 1057851 Change-Id: I3bc40966746a011eb4fd4a2eb3b16a76e5d8ea70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170549 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#763512}
-
Hans Wennborg authored
CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved to the much smaller headers check.h, check_op.h, and notreached.h, respectively. This CL updates .cc files to use those headers instead when possible, with the purpose of saving compile time. (Split out from https://crrev.com/c/2164525 which also has notes on how the change was generated.) Bug: 1031540 Change-Id: I643818242b92e19a1048fac89dd8aae323e8b1ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164510Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#763511}
-
Collin Baker authored
Snapping the dragged tab to the correct position will be implemented in a follow-up change. This also adds a function GetSnapPositionForLocation() that takes just a location and ignores window-specific properties, unlike GetSnapPosition(). This is necessary since the DragImageView used by DragDropController is not snappable itself. Instead, it is just a placeholder for a new browser window that will be snapped. Bug: 1069869 Change-Id: I4b9946c9e1f6484a7ec79f8ad71db518d9dd9c7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150025 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#763510}
-
Scott Violet authored
BUG=1033029 TEST=WebLayerTest.getUserAgentString Change-Id: I6331b3731ac36dbde138e7a8ca731165a6ba0b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166352 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#763509}
-
Vladislav Kaznacheev authored
This provides a quick fix for the regression introduced by crrev.com/c/2079607. The use of transforms will be re-introduced shortly. Bug: 1073653 Test: manual Change-Id: I7612d0923e9991ad63e083007c1a30763fc60d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165857Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#763508}
-
Sam Bowen authored
Create new structs to hold content attributes for the image. These specify different UI-related properties of the image. In a future CL, we will add code to media_feeds_converter to fill in the new content attribute fields. Bug: 1071658 Change-Id: I82bcf01dffdd399bfc43fde4707cf2ccdaaa057e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163439 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#763507}
-
Hongchan Choi authored
This is to catch up the spec change in AudioWorkletNode.onprocessorerror event handler. The current implementation uses a regular Event object to report an error, but the spec has changed to use a proper ErrorEvent. The CL also cleaned up redundant modification in the test file, which was caused by the previous revision. Bug: 1064240 Test: external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-onerror.https.html Change-Id: If7ac7eee96138ec0dbe02a3a046a5bdee27389db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168542Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#763506}
-
bttk authored
This will help identify crashes related to partner customization. Customization includes the default homepage url and default bookmarks. Bug: 1063948 Change-Id: I62ceb297f0fcfda7e322c97a6476454d147bc0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150011Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#763505}
-
Chromium WPT Sync authored
Using wpt-import in Chromium df0eae72. With Chromium commits locally applied on WPT: 86131ac4 "Add a test for ReplaceTrack that verifies video track content." c317bae5 "[IntersectionObserver] Fix handling of remote parent frame intersection" 6e40df0d "[EventTiming] Attempt to fix some flaky tests" 9a26c536 "Effective Touch Action when <body> is the viewport defining element" 3f9ff2a8 "bluetooth: async/await for test helper methods" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: binji@chromium.org: external/wpt/wasm foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools pwnall@chromium.org, jsbell@chromium.org: external/wpt/cookie-store pwnall@chromium.org, mkwst@chromium.org: external/wpt/native-io NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I341eee9d5f2a2214efcd3f467426f0eb55675162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171016Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763504}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Id9abb7dd3555e36a19bd3c5d451d1b2209f13a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170979Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#763503}
-
Esmael El-Moslimany authored
Split action menu button and remove button into two buttons. Bug: 1064850 Change-Id: Iee82ff988201cd5c9cdb44054b3d81addd03d4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168832 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#763502}
-
siashah authored
The card issuer was added to CreditCard class in crrev.com/c/2145970. Please refer to the bug for the design doc. Bug: 1063426 Change-Id: Ifec43187879f3be9f0a5196bdbada0db5fd8f786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166133Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#763501}
-
Zach Trudo authored
The majority of the contents of messaging_layer should have been in chrome/browser/policy, with the public proto landing in components/policy. This change moves things to their appropriate location and updates the build rules. Bug=b:153361703 Change-Id: Ie57a14ff608682691e3c53cb6615be83e0d97fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166130 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Auto-Submit: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#763500}
-
Chong Gu authored
Disable VideoCaptureDeviceTest on Fuchsia. Start running capture unittests on Fuchsia FYI bots, adds 2 minutes of bot time and run time. Bug: 1075762 Change-Id: I5e62bad602939c438a7f47e8c898304e63a5135e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168522 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#763499}
-
Mirko Bonadei authored
The directory //third_party/jsr-305 has recently been removed. Bug: 1070424 Change-Id: I2a3da25ee64ffcf28a6f59274af02656d6e71d76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170346Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#763498}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1e6581c46ce7..9a90474af88f git log 1e6581c46ce7..9a90474af88f --date=short --first-parent --format='%ad %ae %s' 2020-04-28 fmayer@google.com Improve version detection. 2020-04-28 hjd@google.com Merge "traced: Allow statsd more concurrent sessions" 2020-04-28 fmayer@google.com Fix heap_profile script for Q. 2020-04-28 fmayer@google.com Fix heap_profile for Python 3. 2020-04-28 fmayer@google.com Roll trace_to_text in heap_profile. Created with: gclient setdep -r src/third_party/perfetto@9a90474af88f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I20178e806cca35fc591dcc10339c344055161be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170794Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763497}
-
Andrew Grieve authored
Bug: 1075998 Change-Id: I82d3f9da16faf7c344859dd8478af0f7a115dcc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170849 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#763496}
-
Mason Freed authored
To enable feature detection, this CL enables this: HTMLTemplateElement.prototype.hasOwnProperty("shadowRoot") This is as documented in the explainer, at [1]. [1] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md#feature-detection-and-polyfilling Bug: 1042130 Change-Id: I529af9ce952b4d2e162e099c7ca703af8f3c4791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166466 Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#763495}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d50c00bf..c301c370 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2e842b9b2c775d6dda8c68292b35148fb75cca7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170806Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763494}
-
Maksim Ivanov authored
Remove the assertion on |googleResponseReceived| from the MergeSessionTest.XHRNotThrottled test, because checking this variable hits a race with the JS code that writes this variable (in the observer of XMLHttpRequest). It seems correct that the test shouldn't assert on this variable, because, unlike other MergeSessionTest tests, the merge session completion is already performed in the beginning of the test, and requests to Google addresses shouldn't be blocked. Bug: 990844 Test: Run the test ("browser_tests --gtest_filter=All/MergeSessionTest.XHRNotThrottled/1") several thousand times and with stress-ng Change-Id: I92d09409969fcc66623f2025abc3162af02cca04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170867Reviewed-by:
Chris Mumford <cmumford@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#763493}
-
Scott Violet authored
BUG=1075662 TEST=FullscreenCallbackTest.testDestroyFragmentWhileFullscreen Change-Id: I46cc5865fe5b395304f860d715704bc909a818ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170976Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#763492}
-
zhaoyangli authored
Handles unknown system dialog by catching the exception. If it's a system update alert, choose later. If not, deny it. Bug: 1072000 Change-Id: Ifc12a37771c247d2f68c7f73ac0169aa337e5dda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159916 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#763491}
-
wutao authored
This is a preparation to create access token controller for ambient mode. This cl extracts common logic of ambient mode related unittests into an AmbientAshTestBase. Bug: b/148463064 Test: new AmbientAshTestBase Change-Id: I5b94820521653a3b519b4ed223322da919333a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138505 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#763490}
-
Dan Harrington authored
Bug: 1044139 Change-Id: I8b6ce0db6e9cc9930f49080c5fbde533d199dbfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166343 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#763489}
-
Roman Sorokin authored
on branded builds Bug: 977743 Change-Id: Ie0a017323f26051601bde74c4d28e41ea85a95df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170866Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#763488}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I372cc59df1d4fa529f2e5e02d5320055e8130f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170802Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763487}
-
Becca Hughes authored
Add a Media.Feed.Discover UKM event that is recorded when we discover a new Media Feed. This is to track usage of the feature. BUG=1065014 Change-Id: If0fb31dcf597cc51716c1397904412f199c09524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122368 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#763486}
-
Tommy Li authored
This test is flaky on Mac in general: https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests/33739 Bug: 1076005 Change-Id: I9c338cc128d43e8d44977dc7328a73f7c23efd8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170554 Auto-Submit: Tommy Li <tommycli@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#763485}
-
Koji Ishii authored
The test itself is unchanged, so this probably starts to fail, or starts to flake (one win bot I checked passed this test.) TBR=mstensho@chromium.org Bug: 1076028 Change-Id: I7a69b5b4e4adad7c01815d62ece1a973db1ad907 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170747Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#763484}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7d66c798bb49..d70aa16fd5af git log 7d66c798bb49..d70aa16fd5af --date=short --first-parent --format='%ad %ae %s' 2020-04-28 sokcevic@google.com Reland "Print ps in intervals while the process is running" Created with: gclient setdep -r src/third_party/depot_tools@d70aa16fd5af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1074355 Tbr: agable@chromium.org Change-Id: I85571be61eb9b0259a93e697258441635c2306e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170791Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#763483}
-
wutao authored
There could be multiple URL requests at the same time. This patch creates URL loader for each request. Bug: b/153504737 Test: manual Change-Id: I990f60e09242fc1ce65e23b8068aa0edda59601c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141614Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#763482}
-
Haiyang Pan authored
- android-bfcache-rel - android-opus-arm-rel - android_blink_rel - android-cronet-arm-dbg - android-lollipop-arm-rel-swarming - ToTAndroid Also add cronet-gtests to the builder android-cronet-lollipop-arm-rel The following builders are not migrated for now since they are no working properly with Lollipop: - android-cronet-asan-arm-rel - android-asan Bug: 1032336, 1074410 Change-Id: I3186742244be821ca22f5481f0e652b0b3477410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168797 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#763481}
-
Amr Aboelkher authored
This CL is doing the following: - Rolling to the recent version - Update the README with the exact version Bug: chromium:1076079 Change-Id: Ie16aeaf8e2325762e6928a991c1aefe21dbfb24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170868Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#763480}
-