GitLab

One of the design considerations in https://codereview.chromium.org/1358173005/ was that using base.copyWithoutNullFields made the code future-proof if new options are added. This unit test ensures that that holds true and also improves some of the existing unit tests to catch some obvious errors.

Review URL: https://codereview.chromium.org/1366093003

Cr-Commit-Position: refs/heads/master@{#351180}

BUG=490488

Review URL: https://codereview.chromium.org/1376533002

Cr-Commit-Position: refs/heads/master@{#351179}

Xcode 7.0 has been publicly released and iOS downstream requires it to build
so use the iOS 9.0 SDK with Xcode 7.0 for the bots upstream.

Run the tests on all the currently supported iOS version 7.1, 8.3 and 9.0.

BUG=516606

Review URL: https://codereview.chromium.org/1369243002

Cr-Commit-Position: refs/heads/master@{#351178}

This change is needed for testing recoverable SSL interstitials for
WKWebView.

BUG=462427

Review URL: https://codereview.chromium.org/1358033002

Cr-Commit-Position: refs/heads/master@{#351177}

The memory dump provider for OutputSurface was registered on the
client thread, but could be unregistered on the main thread in cases when
the client was cleaned up before the destructor was called (very common).
Move the unregistration code to the parallel of the registration code, so that
both only when appropriate, on the client thread.

BUG=536824
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1371163002

Cr-Commit-Position: refs/heads/master@{#351176}

Tints all action-bar menu icons so they are the same color as the
system icons (home/up button and three-dots overflow icon).

Review URL: https://codereview.chromium.org/1369653002

Cr-Commit-Position: refs/heads/master@{#351175}

These are types that we've seen on page_cycler.typical_25.

BUG=

Review URL: https://codereview.chromium.org/1372273002

Cr-Commit-Position: refs/heads/master@{#351174}

The "N cookies from this site" link gets updated in real time (to update the
value of N). That causes the link to lose click events and its tab index.
Solve the problem by only updating the link text, rather than destroying and
rebuilding the entire layout.

BUG=535587

Review URL: https://codereview.chromium.org/1372453002

Cr-Commit-Position: refs/heads/master@{#351173}

This allows users and integration tests to use the Data Saver API, but
override the list of Data Reduction Proxies to use for HTTP proxies with
a custom list.

BUG=526827

Review URL: https://codereview.chromium.org/1345523005

Cr-Commit-Position: refs/heads/master@{#351172}

Revert of scheduler: Add a base directory (patchset #4 id:60001 of https://codereview.chromium.org/1374653003/ )

Reason for revert:
Change causes compile failure:
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/6135

Original issue's description:
> scheduler: Add a base directory
>
> This patch moves the more fundamental scheduling primitives (e.g.,
> TaskQueueManager) to a separate base/ directory. This makes the layered
> architecture of the scheduler more obvious and reduces the likelihood of
> accidentally introducing layering violations.
>
> With this refactoring, the overall dependencies are:
>
>        +------+
>        | base |
>        +------+
>            ^
>            |
>        +-------+     +------+
>        | child |<----| test |
>        +-------+     +------+
>           ^ ^          ^ ^
>           | |          | |
>           | '----------|-|---.
>           | .----------' '-. |
>           | |              | |
>       +----------+      +-------+
>       | renderer |      | ppapi |
>       +----------+      +-------+
>
> Committed: https://crrev.com/516bee16e9437521cdd20a78d683f9dbaf35df3e
> Cr-Commit-Position: refs/heads/master@{#351109}

TBR=jochen@chromium.org,alexclarke@chromium.org,skyostil@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1370343002

Cr-Commit-Position: refs/heads/master@{#351171}

Revert of Small fix for URLRequestJobs when entering suspending mode. (patchset #3 id:40001 of https://codereview.chromium.org/1366203004/ )

Reason for revert:
Seeing odd failures that make no sense on android bots that may somehow be due to this CL...Trying a revert.  :(

Original issue's description:
> Small fix for URLRequestJobs when entering suspending mode.
>
> When entering suspend mode, there was a window of time between
> when the request was canceled, and when the NetworkDelegate was
> informed it was canceled.  This didn't exist for other cancellation
> paths, and if an embedder invoked certain callbacks in this period,
> thinking the request was still live, crashes could result.
>
> BUG=289715
>
> Committed: https://crrev.com/05608da225e05b4a20da3f4ca0cb9a5276fcf3d6
> Cr-Commit-Position: refs/heads/master@{#350938}

TBR=davidben@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=289715

Review URL: https://codereview.chromium.org/1372213003

Cr-Commit-Position: refs/heads/master@{#351170}

R=prasadv@chromium.org
BUG=432959

Review URL: https://codereview.chromium.org/1375693003

Cr-Commit-Position: refs/heads/master@{#351169}

BUG=520266

Review URL: https://codereview.chromium.org/1364913005

Cr-Commit-Position: refs/heads/master@{#351168}

Revert of Enable subsequence caching (patchset #3 id:40001 of https://codereview.chromium.org/1366163002/ )

Reason for revert:
There are still some regressions.

BUG=410097,536764,536674,533717

Original issue's description:
> Enable subsequence caching
>
> BUG=410097
>
> Committed: https://crrev.com/80bdce2c101c3c6a8a2383b8d7035df7bdd5c0c4
> Cr-Commit-Position: refs/heads/master@{#350965}

TBR=chrishtr@chromium.org,pdr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=410097

Review URL: https://codereview.chromium.org/1377643002

Cr-Commit-Position: refs/heads/master@{#351167}

V8DebuggerAgent was split into interface and implementation. All other agents should depend on the public part only.

Once InjectedScript, InjectedScriptHost and InjectedScriptManager are also moved to .../inspector/v8 some of the methods on V8DebuggerAgent will be removed and called only by the implementation classes.

BUG=439376

Review URL: https://codereview.chromium.org/1367623006

Cr-Commit-Position: refs/heads/master@{#351166}

This CL adds and implements NetworkDelegate::OnNetworkBytesSent(), which
is used to notify the network delegate when bytes have been sent over
the network.

BUG=518051

Review URL: https://codereview.chromium.org/1362793003

Cr-Commit-Position: refs/heads/master@{#351165}

If a user quits Chrome with two windows, both docked, on restore Chrome
will notice that neither window is fully visible and select the first
window in its restoration list to make visible. However, the profile
also has a notion of an active window, which session restore auto-
matically makes fully visible. The result is that depending on the order
in which the windows were placed in the dock, both windows can end up
restored fully visible instead of only one of them (which ideally should
be the last active window).

This change causes session restore to restore the last active window to
fully visible if all windows are hidden and the last active window
appears in the window restoration list.

BUG=536201

Review URL: https://codereview.chromium.org/1366313003

Cr-Commit-Position: refs/heads/master@{#351164}

At rockot@'s suggestion, I tested this with a small Chrome app that I
wrote (https://github.com/zeptonaut/serial-device-enumerator-app) that
opens a window showing all information that Chrome knows about serial
devices. We chose this route over unit tests because we didn't think
it was wise to write unit tests that assumed specific devices were
plugged into our test servers.

As far as devices, I used an FTDI Chipset High Speed USB 2.0 to Serial
RS-232 DB-9 Converter. This was useful because it's one of not-so-many
devices that has both serial properties (COM port) and USB properties
(vendor ID, device ID, and display name).

BUG=522217

Review URL: https://codereview.chromium.org/1357993002

Cr-Commit-Position: refs/heads/master@{#351163}

BUG=529471

Review URL: https://codereview.chromium.org/1365443004

Cr-Commit-Position: refs/heads/master@{#351162}

Per bug, we would send duplicate queries upon parsing previously-known forms on a page.

BUG=512173

Review URL: https://codereview.chromium.org/1371713002

Cr-Commit-Position: refs/heads/master@{#351161}

BUG=521646

Review URL: https://codereview.chromium.org/1364103003

Cr-Commit-Position: refs/heads/master@{#351160}

BUG=528847

Review URL: https://codereview.chromium.org/1365813003

Cr-Commit-Position: refs/heads/master@{#351159}

BUG=536092
TEST=None

Review URL: https://codereview.chromium.org/1373873003

Cr-Commit-Position: refs/heads/master@{#351158}

BUG=536832

Review URL: https://codereview.chromium.org/1369363002

Cr-Commit-Position: refs/heads/master@{#351157}

- download item click target takes up the entire vertical space
- move progress indicator padding from implicit (in DownloadShelf) to explicit (in relevant view)
- MD for shelf controls (show all, close buttons)

Unfortunately I did have to touch the existing shelf code, and therefore risk breaking it, but my visual inspection shows no changes to the appearance in LTR or RTL, warning state or normal state.

BUG=505804

Review URL: https://codereview.chromium.org/1367083002

Cr-Commit-Position: refs/heads/master@{#351156}

Previously the LayerTreeImpl's CurrentScrollingLayer could be either
the inner viewport or the outer viewport. It's clearer if it only ever
takes one of these values.

BUG=526462
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1365343002

Cr-Commit-Position: refs/heads/master@{#351155}

Also added a test to prevent a regression.

Essentially, ScreenLocker::HandleLockScreenRequest calls UserAddingScreen::Cancel and uses a callback to be notified for when the user-adding screen is completed. The crash happened because this callback was invoked too early - before the adding screen has been fully deinitialized.

BUG=467111

Review URL: https://codereview.chromium.org/1356713004

Cr-Commit-Position: refs/heads/master@{#351154}

* This houses previously static methods of NetworkPortalDetector, such as Get (now GetInstance), IsInitialized, InitializeForTesting, etc.
* InitializeNetworkPortalDetector moved to cbmc
* Number of renames of NetworkPortalDetector:: to network_portal_detector::

Files with non-trivial changes:
network_portal_detector_impl.{cc|h}
network_portal_detector.{cc|h}
chrome_browser_main_chromeos.cc

Everything else is a mechanical search/replace

BUG=530485
TEST=unit tests and browser tests.
TBR=kalman@chromium.org

Review URL: https://codereview.chromium.org/1358343003

Cr-Commit-Position: refs/heads/master@{#351153}

This patch adds memory tracing for GpuMemoryBuffers and graphics resources
used by media in GpuMemoryBufferVideoFramePool.

BUG=

Review URL: https://codereview.chromium.org/1355373003

Cr-Commit-Position: refs/heads/master@{#351152}

https://codereview.chromium.org/1376483002 broke trigger-only AMP calls
to build/android/test_runner.py. This fixes that workflow.

BUG=
TBR=mikecase@chromium.org

Review URL: https://codereview.chromium.org/1371243002

Cr-Commit-Position: refs/heads/master@{#351151}

I've narrowed down the linked crash to a bad m_owner pointer in Frame. I've
added two temporary magic values to help diagnose where this is coming from:

In Frame I added a magic value beside the m_owner element to guard against
heap corruption.

In HTMLFrameOwnerElement I added a magic value that should help us catch when
m_owner is not pointing to an HTMLFrameOwnerElement sooner.

In both cases, we should also be able to see if either m_owner of Frame has
already been destructed.

Also turned the ASSERT in ~HTMLFrameOwnerElement into a RELEASE_ASSERT in
case we're destroying it without disconnecting it from the Frame.

BUG=519752

Review URL: https://codereview.chromium.org/1369003003

Cr-Commit-Position: refs/heads/master@{#351150}

VideoFrame::visible_rect could be different than natural_size when the
VideoFrame is coming from a media stream that is from a camera.
crrev.com/1358883003 is planning to convert the video frames coming from
different media sources.

This CL crops VideoFrame using visible_rect when it gets converted to
a new VideoFrame backed by GpuMemoryBuffers.

BUG=

Review URL: https://codereview.chromium.org/1371683002

Cr-Commit-Position: refs/heads/master@{#351149}

Changes:
  - Moves --enable-features/--disable-features flags to content from
    chrome.
  - Copies their content when starting renderers.
  - In renderer_main.cc, creates and registers a FeatureList initialized
    with those flags.

BUG=526169

Review URL: https://codereview.chromium.org/1355613002

Cr-Commit-Position: refs/heads/master@{#351148}

BUG=535373

Review URL: https://codereview.chromium.org/1361153004

Cr-Commit-Position: refs/heads/master@{#351147}

This refactoring of CustomTabsConnection has two benefits:
- Move the client and session handling logic away from CustomTabsConnection.
- Simplify locking in CustomTabsConnection, as it is all handled by
  ClientManager.

Some methods in CustomTabsConnection are now simple pass-through. These
will be removed in a subsequent CL. Leaving these here means that no
test code is affected.

Review URL: https://codereview.chromium.org/1370473002

Cr-Commit-Position: refs/heads/master@{#351146}

This addresses a review comment from https://codereview.chromium.org/1373903002/ that I forgot to fix there.

TBR=andybons@chromium.org

Review URL: https://codereview.chromium.org/1370293002

Cr-Commit-Position: refs/heads/master@{#351145}

There is a problem on A1 devices where sdcard/ is read only. This remounts / with write
permission to push files to /sdcard then resets it to read only.

BUG=

Review URL: https://codereview.chromium.org/1370873002

Cr-Commit-Position: refs/heads/master@{#351144}

Revert of [DevTools] Do not use AboutToNavigateRenderFrame in DevToolsUIBindings. (patchset #1 id:1 of https://codereview.chromium.org/1360143003/ )

Reason for revert:
This patch added a race. It should be using DidStartNavigationToPendingEntry instead.

Original issue's description:
> [DevTools] Do not use AboutToNavigateRenderFrame in DevToolsUIBindings.
>
> DidStartProvisionalLoadForFrame is enough here.
>
> BUG=none
>
> Committed: https://crrev.com/ee6eca69ffbd1d510d02397df5047f27cc256e8e
> Cr-Commit-Position: refs/heads/master@{#350974}

TBR=pfeldman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1369413002

Cr-Commit-Position: refs/heads/master@{#351143}

  In order to roll GN cdc76669..1b1e7e8c (r350849:r351089) and pick up
  the following changes:

  1b1e7e8c GN: Schedule config loads for sub-configs.
  c5598930 GN: Don't allow nested things inside template invocations.
  1c3192f7 Enhance GN documentation.
  e1bbf321 [GN]: Fix bug in roller script with try servers

TBR=dpranke@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel;tryserver.chromium.win:win8_chromium_gn_dbg,win_chromium_gn_x64_rel

Review URL: https://codereview.chromium.org/1370133006

Cr-Commit-Position: refs/heads/master@{#351142}

This patch address a bunch of issues people have found in the roll_gn script:

- Fixes yet another bug where we weren't waiting for the try jobs
  to finish.
- Fixes a bug where we were adding an extra '\n' onto the DEPS file
  in the final roll CL.
- Closes the 'build_gn' CL once the build has completed.
- Adds better logging at the end of the 'wait' and 'roll_buildtools' steps.
- Removes mac_chromium_gn_rel from CQ_EXTRA_TRYBOTS, since
  it is part of the default set now.

R=brettw@chromium.org, andybons@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1372203003

Cr-Commit-Position: refs/heads/master@{#351141}