- 06 Dec, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eb2f2ad6ffdf..8807e6de3a17 Created with: gclient setdep -r src-internal@8807e6de3a17 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia5bde08c98963dcef9b75753e08be31595dac2af Reviewed-on: https://chromium-review.googlesource.com/c/1365416Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614332}
-
erikchen authored
Several test suites relied on the common resources .pak being unsuccessfully loaded in order to function correctly. On Android, .pak files can leak between successive runs of different test suites, which would cause flaky test failures. This CL makes it so that failing to load the common resources .pak file will hit a DCHECK. This CL fixes several instances where test suites were incorrectly trying to load [and failing to load] the common resources .pak file. Change-Id: I5294f921e42524b699c7019b7a56c0a30106c89c Bug: 906587 Reviewed-on: https://chromium-review.googlesource.com/c/1363447Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#614331}
-
Alex Clarke authored
The MessageLoop version of IsIdleForTesting does not take Now() into account, but the SequenceManager version was. This is a mistake because its flaky when there are delayed tasks that are just about to run. TBR=fdoray@chromium.org Bug: 910645, 863341, 891670 Change-Id: Ieaf5e534df0f553046b76fa844f61e4a268082f9 Reviewed-on: https://chromium-review.googlesource.com/c/1365233Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#614330}
-
Alex Clarke authored
Previously the TaskQueueSelector would allow up to 3 delayed tasks to run for every immediate task if both where ready to run. This patch changes it to a 1:1 ratio like the MessageLoop. NB neither the SequenceManager nor the MessageLoop allow delayed tasks to skip ahead of immediate tasks. In addition I've removed the PrioritizingSelector inner class which makes the code a bit more readable. In addition based on review comments I changed the style of functions to return a pointer to the WorkQueue or null rather than a bool. This in general improves readability. Bug: 863341, 891670 Change-Id: I61d4f118880f109c01ad4a2d5301acc9103b0b35 Reviewed-on: https://chromium-review.googlesource.com/c/1361103 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
Mike Reed authored
TBR= Bug: skia:2664 Change-Id: Idf2e2d1c4eefd295d4262a0b49542c83119f639f Reviewed-on: https://chromium-review.googlesource.com/c/1363212 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#614328}
-
Antonio Gomes authored
This CL migrates (most of) account_reconcilor_unittest.cc code away from SigninManager and PO2TS. Production code was migrated and unit tests were minimally updated to keep running in [1]. Remarks: - The CL can completely remove SigninManager direct API calls. - The CL could not completely remove direct PO2TS API calls, due to two missing API: set_all_credentials_loaded_for_testing and LoadCredentials. - Given how the test uses gaia_id to manipulate reconciles and how IdentityTestEnvironment hides setting the gaia_id from the tests, there were some adaptations needed so that the functionalities could continue fully tested. For instance, the following methods were added/ used: * GaiaIdForAccountKey: Added. * identity::GetTestGaiaIdForEmail: Referenced. [1] https://chromium-review.googlesource.com/c/1330223 BUG=910581 Change-Id: I58db6044caa22b6072cb6d22dd7c97c668c46cd3 Reviewed-on: https://chromium-review.googlesource.com/c/1357059Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#614327}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/518add35a8f3..fafae11bfc4c git log 518add35a8f3..fafae11bfc4c --date=short --no-merges --format='%ad %ae %s' 2018-12-06 terelius@webrtc.org Allow parsing RTC event logs without a transaction ID. Created with: gclient setdep -r src/third_party/webrtc@fafae11bfc4c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2becf74e5f60f900df64e46c4e9a20b4e5603999 Reviewed-on: https://chromium-review.googlesource.com/c/1365414Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614326}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ddbf9b06e56d..eb2f2ad6ffdf Created with: gclient setdep -r src-internal@eb2f2ad6ffdf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I641322947d4d0b62fb0cf79fc9ae43742fb6b51e Reviewed-on: https://chromium-review.googlesource.com/c/1365413Reviewed-by:
-
Huanzhong Huang authored
Remove part of the description of BrowsingDataCounter's |pref_| that's no longer true and irrelevant. Bug: none Change-Id: Ibfb47522b33b5ca92f9e29191c79b7070d425e38 Reviewed-on: https://chromium-review.googlesource.com/c/1358459Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#614324}
-
David Roger authored
This configuration is no longer enabled on any platforms. The code can now be removed. TBR=sky Bug: 777774 Change-Id: Id92ef784e3ae933b21d96f8fd39deba1a4fa67a6 Reviewed-on: https://chromium-review.googlesource.com/c/1355189 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#614323}
-
Alex Clarke authored
This test is currently flaky because it relies upon the ordering of delayed and non delayed tasks to quit a run loop before the very short (0.01s) animation delay is up. This patch deflakes it by temporarily freezing time to prevent the animation from completing before the test expects it to. TBR=wzang@chromium.org Bug: 863341, 891670, 910493 Change-Id: I34cf2824c387c380134eb38b3375e6ab79de4be8 Reviewed-on: https://chromium-review.googlesource.com/c/1365244 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
-
Carlos Caballero authored
ThreadManager instances are created on the new thread and thus their thread_manager_ member might not be initialized when GetThreadManagerFor is called. This patch addresses that issue by having two different containers. One to keep track of threads and the other for keeping track of all the ThreadManager instances. This code could use some nice refactoring, this patch just tries to do the minimum changes to get rid of the race. Bug: 906468 Change-Id: Ie39f5a6a18111248c4f83264f6adcdaef4befa23 Reviewed-on: https://chromium-review.googlesource.com/c/1365442 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/924d5cbc6627..285509d0e41e git log 924d5cbc6627..285509d0e41e --date=short --no-merges --format='%ad %ae %s' 2018-12-06 dtu@chromium.org [pinpoint] Add cpython to CIPD packages for Swarming tasks. Created with: gclient setdep -r src/third_party/catapult@285509d0e41e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:911511 TBR=sullivan@chromium.org Change-Id: If17883c4c319c61a837806e819bd0b6c4bdbee28 Reviewed-on: https://chromium-review.googlesource.com/c/1365412Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c60a77731d68..518add35a8f3 git log c60a77731d68..518add35a8f3 --date=short --no-merges --format='%ad %ae %s' 2018-12-06 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 68c6b982..d6dec397 (614157:614285) 2018-12-05 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 48afe1fc..68c6b982 (614046:614157) Created with: gclient setdep -r src/third_party/webrtc@518add35a8f3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie8e88fd34dcfea01fdf9936668312881d8648d7e Reviewed-on: https://chromium-review.googlesource.com/c/1365490Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ed9aa80dbd6e..ddbf9b06e56d Created with: gclient setdep -r src-internal@ddbf9b06e56d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib4c1d177947f216078337b7a96776a364e186e1e Reviewed-on: https://chromium-review.googlesource.com/c/1365491Reviewed-by:
-
Dániel Bátyai authored
Arm64 builds for chromeos do not currently use gold when linking. This change enables gold, which results in smaller binary size. Bug: 878565 Change-Id: I70f24490ac010ce58bcc6fd1441ade63288147ad Reviewed-on: https://chromium-review.googlesource.com/c/1341913Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Peter Gal <pgal.u-szeged@partner.samsung.com> Cr-Commit-Position: refs/heads/master@{#614317}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6d59568196c0..7c4a9b7c7e0e git log 6d59568196c0..7c4a9b7c7e0e --date=short --no-merges --format='%ad %ae %s' 2018-12-06 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2018-12-06 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 96bd8fdf36e5..8f1b7a66a5e3 (3 commits) 2018-12-06 herb@google.com Embed SkPath in SkGlyph::PathData Created with: gclient setdep -r src/third_party/skia@7c4a9b7c7e0e The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: I498a50fb1a2fc65424f50214ad9a19d1a004788c Reviewed-on: https://chromium-review.googlesource.com/c/1365171Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 8fea47aa. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I1f6ad756eb6eafe1416332c08f6f9edd7b030f93 Reviewed-on: https://chromium-review.googlesource.com/c/1365077Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#614315}
-
Robbie Gibson authored
This CL disables dragging text out of the omnibox on iPhone because there is nowhere to drag the text to. Bug: 834778 Change-Id: Ic5c731b8c5400c40e7357c5ff25e5a8e45f3e544 Reviewed-on: https://chromium-review.googlesource.com/c/1363194Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#614314}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c7cc237f9582..924d5cbc6627 git log c7cc237f9582..924d5cbc6627 --date=short --no-merges --format='%ad %ae %s' 2018-12-06 benjhayden@chromium.org Add alerts-section for v2spa. Created with: gclient setdep -r src/third_party/catapult@924d5cbc6627 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I3ce19b927d52a7efb70f97d51f37cdb8bb4a68d0 Reviewed-on: https://chromium-review.googlesource.com/c/1365170Reviewed-by:
-
Victor Costan authored
This CL removes the following patches: * patches/0006-fts3-Fix-uninit-variable-in-fts3EvalDeferredPhrase.patch was superseded by https://www.sqlite.org/src/info/6f4b0d0494446d46 * patches/0009-Fix-ossfuzz.c-to-compile-and-run-with-our-config.patch was superseded by https://www.sqlite.org/src/info/d343f7d6b05865c2 * patches/0010-Backport-Windows-VFS-mmap-fix.patch was a backport of 3.26.0 change https://sqlite.org/src/info/ffce4aac18dacbf2 This CL adds a workaround to our wrapper for SQLite's main header. The workaround is needed by the change at https://www.sqlite.org/src/info/d584a0cb51281594 which fixes a bug that was preventing us from building the SQLite shell on Windows. The most attractive feature in this version is the introduction of the SQLITE_DBCONFIG_DEFENSIVE config flag [1]. The flag will be enabled in a follow-up CL, after the upgrade proves stable. [1] https://www.sqlite.org/c3ref/c_dbconfig_defensive.html Bug: 910906 Change-Id: I046dc5a1419188bb93be24fe0edaf536411d100d Reviewed-on: https://chromium-review.googlesource.com/c/1357358 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#614312}
-
Huanzhong Huang authored
To allow checks for |buttonText|. Change-Id: I367876e36e669b56a2dc4cd436665bd600be398e Reviewed-on: https://chromium-review.googlesource.com/c/1356716 Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#614311}
-
Hiroki Nakagawa authored
Bug: 911415 Change-Id: If442d03c009fd934dc4f6700b63dc435af381093 Reviewed-on: https://chromium-review.googlesource.com/c/1364993Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#614310}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e2f948469c66..bdd887fce76c git log e2f948469c66..bdd887fce76c --date=short --no-merges --format='%ad %ae %s' 2018-12-06 kainino@chromium.org Revert "Create new src/tests BUILD.gn file." 2018-12-05 senorblanco@chromium.org Create new src/tests BUILD.gn file. Created with: gclient setdep -r src/third_party/dawn@bdd887fce76c The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If083040df65451a828b022bd4e3c95be0c9c3473 Reviewed-on: https://chromium-review.googlesource.com/c/1365174Reviewed-by:
-
Karolina Soltys authored
Follow-up to patch 1353921. Bug: 891670 Change-Id: Ibae12547f3550debeda11cc400b6cb1b6eabfca9 Reviewed-on: https://chromium-review.googlesource.com/c/1363206Reviewed-by:
-
Mirta Dvornicic authored
webrtc::VideoEncoderFactory::CodecInfo properties are being moved to webrtc::VideoEncoder::EncoderInfo, see: https://crbug.com/webrtc/10065. Bug: webrtc:10065 Change-Id: Ib74503c5390f4f3c148a8039005a28870733a974 Reviewed-on: https://chromium-review.googlesource.com/c/1358061 Commit-Queue: Mirta Dvornicic <mirtad@google.com> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#614307}
-
Hans Wennborg authored
It fails with tip-of-tree Clang because the diagnositics have changed slightly. Disable for now and possible re-enable with updated expectations after the next Clang roll. TBR=thakis Bug: 912021 Change-Id: Ib0d83178ea5c38fa2d19ada720e8526437c916fd Reviewed-on: https://chromium-review.googlesource.com/c/1365434Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#614306}
-
Kunihiko Sakamoto authored
This fixes a bug that viewport width was evaluated to zero when evaluating media queries from Link: rel=preload headers, if "width=device-width" was specified in <meta name="viewport">. viewport_description->max_width has type = kDeviceWidth and value = 0 in such case, so device width must be resolved before overriding viewport dimensions. Note: HTMLPreloadScanner is already doing this, in HandleMetaViewport(). Bug: 590188 Change-Id: Iffb0e031e0316bd41aaf52014609d5e7d0b32284 Reviewed-on: https://chromium-review.googlesource.com/c/1360209 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/baf62bde47d2..ed9aa80dbd6e Created with: gclient setdep -r src-internal@ed9aa80dbd6e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iff2613e7527e25d3f2621fb252220a890fc26b8e Reviewed-on: https://chromium-review.googlesource.com/c/1365411Reviewed-by:
-
Jérôme Lebel authored
This is a reland of 1d497322 This patch also includes implementation for: RLZTrackerDelegateImpl::ShouldUpdateExistingAccessPointRlz() Original change's description: > cros: Fix DCHECK for rlz_lib::UpdateExistingAccessPointRlz > > In addition to fixing the DCHECK, this CL contains a speculative fix > for flaky test (crbug.com/907379). The guess for the flakiness is > (not able to repro the failure locally though): > > |RecordProductEvent| may fail to acquire the |ScopedRlzValueStoreLock| > when recording the CAI event, because the lock is being taken by > |UpdateExistingAccessPointRlz|. In tests, the delay for > |ScheduleDelayedInit| is set to zero, so it's possible for this race > condition to happen. But in production, the delay is non-zero. > > I don't think we're losing test coverage by disabling > |UpdateExistingAccessPointRlz| here because the call is a no-op in > tests, and another test (RlzLibTest.UpdateExistingAccessPointRlz) is > testing its implementation. > > Bug: 906293, 907379 > Change-Id: I208919f22edc09fc1a739a1efe1909a71e5a2730 > Reviewed-on: https://chromium-review.googlesource.com/c/1353990 > Reviewed-by: Roger Tawa <rogerta@chromium.org> > Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#613172} Bug: 906293, 907379, 911439 Change-Id: Ic1d9f85bc3714f890d2dc7fcc1d070d0711baec0 Reviewed-on: https://chromium-review.googlesource.com/c/1360692 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#614303}
-
Kent Tamura authored
mojo_layouttest_test.mojom is renamed to mojo_web_test_helper_test.mojom. It keeps _test suffix indicating it affects only tests. Bug: 843412 Change-Id: Iddfdfcbfd87228fb9ee8abd2777f4838c4b66801 Reviewed-on: https://chromium-review.googlesource.com/c/1362717Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#614302}
-
Philip Jägenstedt authored
This is like the `./wpt run --no-manifest-update` in upstream wpt: https://github.com/web-platform-tests/wpt/blob/81607985fc9485cbf9f3d0a8ae74359f885eb36b/tools/wptrunner/wptrunner/wptcommandline.py#L52-L53 Because updating the manifest is pretty slow, this reduces the time to run a few tests over and over in development when the manifest is not changing. On a Linux workstation, the time to run a single test (dom/historical.html) went from ~14s to ~7s. Bug: 905406 Change-Id: I50e4b8bdd9d3bedbf1e31bc34a2338317a30aaf0 Reviewed-on: https://chromium-review.googlesource.com/c/1361874 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Reviewed-by:
Luke Z <lpz@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#614301}
-
Clemens Arbesser authored
Also in this CL: - refactoring of parts of the backend to remove redundant and potentially error-prone code - modified unit tests for web_controller to test for UTF-8 compliance of SetFieldValue() Change-Id: Ib7dd2429159a527ec81f325622e8bf6f97c5e5ab Reviewed-on: https://chromium-review.googlesource.com/c/1360691 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#614300}
-
Javier Ernesto Flores Robles authored
Only add the loading indicator if the model hasn't been created Bug: 912085 Change-Id: I0d557013eeb63cf882793460a342e22485fa48d5 Reviewed-on: https://chromium-review.googlesource.com/c/1363179Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#614299}
-
Yutaka Hirano authored
In order to WebDataConsumerHandle deprecation easy, move content::FtpDirectoryListingResponseDelegate to blink. Bug: 910489 Change-Id: I878df1c90c28de1c3f44d9ed48e518207fa831c5 Reviewed-on: https://chromium-review.googlesource.com/c/1358315 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8f1b7a66a5e3..d300548fcc28 git log 8f1b7a66a5e3..d300548fcc28 --date=short --no-merges --format='%ad %ae %s' 2018-12-06 enga@chromium.org Add ANGLE_multi_draw entrypoints to proc table Created with: gclient setdep -r src/third_party/angle@d300548fcc28 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890539 TBR=ynovikov@chromium.org Change-Id: Id92afc679acf0f0e00f46fba3d8806da8987f4d1 Reviewed-on: https://chromium-review.googlesource.com/c/1365175Reviewed-by:
-
Kent Tamura authored
The behavior of ListedElement::checkValidity() with kCheckValidityDispatchNoEvent was very simple. This CL introduces IsNotCandidateOrValid() for that behavior, and removes CheckValidityEventBehavior argument of checkValidity(). Change-Id: Ieff28ada30cc47d8617e73306d874cdfa9dee43c Reviewed-on: https://chromium-review.googlesource.com/c/1364990 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#614296}
-
Makoto Shimazu authored
Currently NetS13nServiceWorker is enabled by default, and we don't have tests excercising non-S13nServiceWorker path. This flips the test to enable S13nServiceWorker to disabling S13nServiceWorker forcefully. Bug: 715640 Change-Id: I8ba3401989dcd9da46e24cd7dc0500f66a200741 Reviewed-on: https://chromium-review.googlesource.com/c/1365050 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#614295}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3dc3d8f696a7..baf62bde47d2 Created with: gclient setdep -r src-internal@baf62bde47d2 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I405f390d1485db257fc26dca9ad21eede7227b0f Reviewed-on: https://chromium-review.googlesource.com/c/1365173Reviewed-by:
-
Reka Norman authored
This CL adds a fake page handler to the app management page which is used when accessing chrome://apps?fakeBackend=true. Bug: 906508 Change-Id: Ib92a66a45b312efd14b5fb038d7cc506944dd716 Reviewed-on: https://chromium-review.googlesource.com/c/1360034 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#614293}
-
