GitLab

BUG=53173
TEST=none yet (will add tests when BackgroundModeManager handles prefs notifications)

Review URL: http://codereview.chromium.org/3200007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57225 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3108043

TBR=mnaganov@chromium.org
Review URL: http://codereview.chromium.org/3203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57224 0039d316-1c4b-4281-b951-d872f2087c98

1. Treats ASCII double/single quoation marks between Hebrew letters as MidLetter
   for Hebrew spellchecker because they're commonly used in place of Geresh and Gershayim.
2. Pass through ASCII double/single quotation marks and Geresh and Gershayim in OutputHebrew.

See http://www.unicode.org/reports/tr29/proposed.html (version 6.0.0.0 draft2) about Hebrew
tailoring.

This alone does not fix bug 22909 completely. This CL will be followed with an ICU data fix. 

BUG=22909
TEST=unit_tests --gtest_filter=SpellcheckWordIteratorTest.*

Review URL: http://codereview.chromium.org/3112015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57223 0039d316-1c4b-4281-b951-d872f2087c98

Add support for a directory file chooser command, which creates a file list by enumerating all the files in the selected directory.

BUG=47162
TEST=layout test input-file-directory-upload.html, or www/~johnnyg/dir_upload/ demo page

Review URL: http://codereview.chromium.org/2825051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=53200
TEST=n/a

Review URL: http://codereview.chromium.org/3162034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57218 0039d316-1c4b-4281-b951-d872f2087c98

When an individual entry is lost from the appache's diskcache, attempts to load that resource will fallthru to the network instead of promptly failing. See bug 50657. This is just a first step, a repair step will follow on in a future change.

BUG=50657
TEST=none

Review URL: http://codereview.chromium.org/3187017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57217 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Verify CrOS preferences working properly in dom-ui options window.
Review URL: http://codereview.chromium.org/3174032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57216 0039d316-1c4b-4281-b951-d872f2087c98

BUG=53035
TEST=none

Review URL: http://codereview.chromium.org/3151033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57215 0039d316-1c4b-4281-b951-d872f2087c98

Since we are simulating non-shared resources on top
of shared resources we can't actually let contexts
use texture 0 because they are all sharing it.

Also, moved the black textures to the texture manager.

TEST=unit tests and ran conformance tests
BUG=none

Review URL: http://codereview.chromium.org/3150026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57214 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50254
TEST=unittests

Review URL: http://codereview.chromium.org/3136030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57213 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=unittests

Review URL: http://codereview.chromium.org/3181034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57212 0039d316-1c4b-4281-b951-d872f2087c98

This will be yanked out, but is being used to triage a bug.

BUG=50517
TEST=None

Review URL: http://codereview.chromium.org/3150033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57211 0039d316-1c4b-4281-b951-d872f2087c98

pointer of the backend is valid until the callback fires,
even after the http cache is deleted.

BUG=52387
TEST=net_unittests


Review URL: http://codereview.chromium.org/3195017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57210 0039d316-1c4b-4281-b951-d872f2087c98

BUG=53141
TEST=none


Review URL: http://codereview.chromium.org/3159035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57209 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52765
TEST=Bookmark sites in a language different than the language Chrome is configured in (you should have few of them, with titles long enough, so there are more than 100 characters in that language). Go to the bookmark manager, no translate infobar should be shown.

Review URL: http://codereview.chromium.org/3130045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57208 0039d316-1c4b-4281-b951-d872f2087c98

BUG=TEST=none

Review URL: http://codereview.chromium.org/3142035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57207 0039d316-1c4b-4281-b951-d872f2087c98

be shared between PepperView and X11View.

Have View create appropriate decoder based on encoding of the update stream.

Add state to decoder to keep track of whether Begin/End has been called in the
correct order.

Add unittests for new routines.

BUG=none
TEST=remoting unit tests

Review URL: http://codereview.chromium.org/3124005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57206 0039d316-1c4b-4281-b951-d872f2087c98

tabcontents after an animation that would result in a gray rect.

BUG=53083
TEST=see bug

Review URL: http://codereview.chromium.org/3142034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57205 0039d316-1c4b-4281-b951-d872f2087c98

what this cl is:
- a REALLY bare skeleton implementation of ProxyConfigService for chromeos (lots of design details remain to be worked out on the chromeos side, but i needed to get something basic up)
- focused on getting chrome part correct, extracting design flow and implementation from linux variant that are relevant to chromeos, e.g.: 
  - provide access of ProxyConfigService interface on IO thread
  - provide methods on UI thread for UI to read/modify proxy config (like linux's GConf notifications on UI thread)
  - fetch initial config on UI thread (this is not absolutely necessary for chromeos, 'cos i don't use GConf, but i just follow linux for now)
  - however, the class is RefCountedThreadSafe (so that both net::ProxyService and DOMUI can access it), and the code resides in chrome/browser/chromeos dir instead of net/proxy.  
  - design details are in .h files
- initial config is hardcoded as pac script and loaded as owner (TODO: load this from cros settings persisted on chromeos device)
  - this should work like the current chromeos session manager which sets the auto-proxy environment variable in login script to the same pac script
- implement an augmented analogue to net::ProxyConfig to hold actual proxy config and UI settings (e.g. source and readonly attributes)
  - backend uses this as the main proxy config, and only converts it to net:::ProxyConfig for network stack on the IO thread in net::ProxyService::GetLatestProxyConfig.
  - UI methods also use this structure
- provide methods to get and set configs from UI thread 
  - UI can use dom_ui->GetProfile()->GetChromeOSProxyConfigServiceImpl() to access these methods on the UI thread
  - these methods are by no means final
    - i only added them here to verify the design flow that modifications can be made from UI thread and picked up by IO thread.
    - david and i will improve or modify them to whatever works best for frontend and backend.
- unittest that tests most functionalities: socks and bypass_rules will be enabled in a later cl.

TODOs after this cl:
- work with UI, load initial config as owner from cros settings
- implement policy mechanism, merge it with owner during initial load and modifications
- persist proxy settings
- etc etc etc

BUG=chromium-os:5127
TEST=nothing yet.

Review URL: http://codereview.chromium.org/3047052

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57204 0039d316-1c4b-4281-b951-d872f2087c98

BUG=41762
TEST=none

Review URL: http://codereview.chromium.org/3165055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57202 0039d316-1c4b-4281-b951-d872f2087c98

Configure the opengl view to draw below the window, draw the view with NSClearColor so that's transparent, and make the window non-opaque while plugins are showing, so that the opengl surface can show through.

This is a bit slower than previously without this patch, but it's about as fast as it was when we used CoreAnimation to show IOSurfaces.

Parts of this code are from Simon Fraser's MacTierra code (with permission).

BUG=44087,51748
TEST=
* Go to youtube. Findbar should show up on top of video. Go fullscreen. Tab overlay should show up on top of video.
* Go to youtube, drag tab with video out and to a new window. Video should continue playing.
* Install https://chrome.google.com/extensions/detail/bdnkaenpadjoldiddfdidinjmjeagaji , click browser action. Should still work.
* Install a transparent theme such as https://tools.google.com/chrome/intl/cy/themes/theme_at_mecko.html or http://chromium.googlecode.com/issues/attachment?aid=3778755830122130591&name=theme-bug.crx&token=27908ca7e699a023c8446657b24c4696 . Browser window shouldn't become transparent while videos are playing.

Review URL: http://codereview.chromium.org/3176027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57201 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52520
TEST=Verify metrics are saved when changing options in dom-ui options window (--enable-tabbed-options).
Review URL: http://codereview.chromium.org/3153034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57200 0039d316-1c4b-4281-b951-d872f2087c98

I have not implemented the Mac/Linux part yet, will do so in a subsequent CL (does InfoBubble exist for Mac?).

This info bubble remains visible on screen until recognition ends or the user cancels it.
It also tracks the html element which requested speech recognition if it changes position
on screen (e.g. user scrolls the page or moves the browser window).

To get this working, I extended InfoBubble to query the delegate if it can be closed when
another window gets activated, as well as to reposition it when required.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/3133034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57199 0039d316-1c4b-4281-b951-d872f2087c98

Revert 57187 - Adding a couple of binary files to hopefully get a good try run on my next changlist.

(I thought we wanted separate sets for Identity and Connect column, but UI leads said we should consolidate here)

TBR=jcivelli
TEST=None
BUG=52916

Review URL: http://codereview.chromium.org/3120028

TBR=finnur@chromium.org
Review URL: http://codereview.chromium.org/3162035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57198 0039d316-1c4b-4281-b951-d872f2087c98

KeepAlive mode.  The condition to check that in CanAutorestartForUpdate() is
reversed.

BUG=none
TEST=On Linux - Change BrowserProcessImpl::StartAutoupdateTimer() function to
change the timer from 6hrs to 30 seconds.  Build and run chrome with
--no-startup-window and --keep-alive-for-test flags.  Run "touch" on browser
exe to fake an update.  Wait for 30 seconds and verify that the browser shuts
down and restarts.

Review URL: http://codereview.chromium.org/3206003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57197 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3137033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57196 0039d316-1c4b-4281-b951-d872f2087c98

BUG=52918
TEST=Less log spam.
Review URL: http://codereview.chromium.org/3164035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57194 0039d316-1c4b-4281-b951-d872f2087c98

info (url, title, mimetype, doctype) to WebAccessibility.

BUG=none
TEST=Modified unit test: RenderMessagesUnittest.WebAccessibility
TEST=Added new browser test: RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree

Review URL: http://codereview.chromium.org/3013035

TBR=dmazzoni@chromium.org
Review URL: http://codereview.chromium.org/3173040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57193 0039d316-1c4b-4281-b951-d872f2087c98

Added new functional tests for translation and also cleaned up existing tests.

Review URL: http://codereview.chromium.org/3111030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57192 0039d316-1c4b-4281-b951-d872f2087c98

This prevents console spew.

BUG=26621
TEST=Run Chrome and don't get messages in Console.app from sandboxd about Chrome Helper. Run with --enable-sandbox-logging and get them.

Review URL: http://codereview.chromium.org/3155031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57191 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3108043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57190 0039d316-1c4b-4281-b951-d872f2087c98

Differences over the reverted version (http://codereview.chromium.org/3080034/show - reverted http://codereview.chromium.org/3137022/show ):
  * Jobs never log anything in their destructor, as the HostResolverImpl randomly outlives the NetLog, at least in some unit tests.
  * Removed the extra log entries for when a DNS lookup starts/completes.  Instead, the job's event is ended in OnLookupComplete().
  * Slight modification of the CanceledAsynchronousLookup unit test, as the Job is now closed before posting any events to the Request.  For actual lookups, this behavior means the Job's duration more accurately reflects the time the DNS lookup takes itself.


BUG=46844
TEST=Look at the net-internals screen.

Review URL: http://codereview.chromium.org/3119027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57189 0039d316-1c4b-4281-b951-d872f2087c98

info (url, title, mimetype, doctype) to WebAccessibility.

BUG=none
TEST=Modified unit test: RenderMessagesUnittest.WebAccessibility
TEST=Added new browser test: RendererAccessibilityBrowserTest.TestCrossPlatformAccessibilityTree

Review URL: http://codereview.chromium.org/3013035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57188 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jcivelli
TEST=None
BUG=52916

Review URL: http://codereview.chromium.org/3120028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57187 0039d316-1c4b-4281-b951-d872f2087c98

HALCADClientListener::HALCADClientListener), add a new one for a leak on Snow
Leopard

TBR=timurrrr
BUG=46186

Review URL: http://codereview.chromium.org/3106035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57186 0039d316-1c4b-4281-b951-d872f2087c98

This depends on https://bugs.webkit.org/show_bug.cgi?id=44446

Review URL: http://codereview.chromium.org/3165053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57185 0039d316-1c4b-4281-b951-d872f2087c98

because update is enabled for non-official build there is no sense to skip OOBE update screen.

BUG=cromium-os:4002, cromium-os:4003
TEST=Install older Chromium OS build on device, start dev server with
new image (./start_devserver --client_prefix ChromeOSUpdateEngine),
remove Local State and .oobe_completed files.

Review URL: http://codereview.chromium.org/3192014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57184 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/3134029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57183 0039d316-1c4b-4281-b951-d872f2087c98

BUG=53198
TBR=glider
Review URL: http://codereview.chromium.org/3135043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57182 0039d316-1c4b-4281-b951-d872f2087c98

implementation used by chrome interoperate correctly with other products that
use RLZ,

BUG=None
TEST=Install chrome and another RLZ-enabled product and make sure they
correctly share the DCC string and their RLZ strings.  No registry values
should have the type REG_BINARY.

Review URL: http://codereview.chromium.org/3181033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57181 0039d316-1c4b-4281-b951-d872f2087c98