- 07 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/266e4e05a88c..075cc4c355a6 git log 266e4e05a88c..075cc4c355a6 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 88264e3e188d..27a3d31d7a9d (1 commits) Created with: gclient setdep -r src/third_party/angle@075cc4c355a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:None Change-Id: I7a6ec9371d0b48cdaae404766aa71657999da35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903514Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713436}
-
Elly Fong-Jones authored
Bug: 1011446 Change-Id: Ie6043c36e60c2aeedee7722907ef6816f0972b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901430Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#713435}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c4420ef3dc6c..cea290f9d5bf git log c4420ef3dc6c..cea290f9d5bf --date=short --no-merges --format='%ad %ae %s' 2019-11-07 robertphillips@google.com Add GrPrimitiveType to GrProgramInfo Created with: gclient setdep -r src/third_party/skia@cea290f9d5bf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@google.com Bug: None Change-Id: Ie31f8a470d536b12803abc106414d2774594f7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903513Reviewed-by:
-
Elly Fong-Jones authored
This change moves CreateFootnoteView into an anonymous namespace, and passes in the instance variables it needs. While the SharingDialogData member is not itself const, none of the members that CreateFootnoteView depends on change during the lifetime of SharingDialogView. Unfortunately the member cannot be const since it contains some callbacks that need to be run, and the members of SharingDialogData cannot be made const because they are iteratively filled in by other code before the dialog is created. Bug: 1011446 Change-Id: I3af6a9a3d3c2e5aa2f1d50dbb560182ccff945c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901432Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/070a9e2a8724..40aaf7602881 git log 070a9e2a8724..40aaf7602881 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 ilkos@google.com Merge "UUID in TraceMetadata" 2019-11-07 fmayer@google.com Merge "Do not use garbage object for unique_retained / retained calculation." 2019-11-07 treehugger-gerrit@google.com Merge "core: Expose kMaxPreambleBytes from TracePacket" Created with: gclient setdep -r src/third_party/perfetto@40aaf7602881 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I0bb8e1dd28f6e7523e967de734239b3dd69c9bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903512Reviewed-by:
-
Sylvain Defresne authored
Add function computing the base::TimeDelta since the application launch from kernel information about the process (based on the implementation from google_toolbox_for_mac). Bug: none Change-Id: I5d70aa1f9bb76b1b22f8375c2e7e53319486e460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899994 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#713431}
-
Lei Zhang authored
The flag was deleted in https://crrev.com/708103, so the corresponding entry in flag-metadata.json is useless. Bug: 824867 Change-Id: Ice9bab31555bd0012ab349f636937a8676da2e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902748 Auto-Submit: Lei Zhang <thestig@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#713430}
-
Olivier Robin authored
Company name is not on the settings page anymore (but country is) Change-Id: Ia6dc7ffc22e6d7cab9ecfc935031bf1c571e83f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1890078Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#713429}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=gbiv@chromium.org Change-Id: If302960d0ed9d8f060d49421b14a96761de4e4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903869Reviewed-by:
-
Dave Tapuska authored
The DCHECK already covers the stopped/stopping states, so the only states it doesn't cover are kInactive and kUninitialized. Since JS is calling this API, the kUninitialized state is impossible. So the only state that this occurs in is kInactive. The method can return null in quirks mode so adjusting the DCHECK for inactive documents seems best. BUG=1020787, 1002472 Change-Id: Ief51eb7783ea7ed506107646a258f24e274127b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902007 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#713427}
-
Mihai Sardarescu authored
This CL removes a few unnecessary usages of ScopedAccountConsistencyDice. Change-Id: I756d99f16dacd05e348bb46578851fd193600d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899870Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#713426}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5de55dca..df4d2ded Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib56aefaafc5dad1ca8046f2d535d60393bf877b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902434Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#713425}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/7d10a733de..b47c6e25f9 TBR=tvanderlippe@chromium.org Change-Id: I0beeba8c52f2266fa7254645c434e815fdd2561a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903134Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#713424}
-
Mihai Sardarescu authored
This CL sets the expiry date to never for Signin.SetCookieSuccess and Signin.GaiaCookieManager.Logout. Fixed: 1006988 Change-Id: I0d03af89d80291c73cf43e3c1217a620ad85e6dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899885Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#713423}
-
Mikhail Khokhlov authored
Saving histograms as an artifact in Telemetry and reading them in Results Processor was a temporary measure to make transition more smooth. Now it's time to remove it. Bug: 981349 Change-Id: Ib303177903456e8d81aae9de89c47117c96cd7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900990Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#713422}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/64cfaeac4c5d..252d1eb47f23 git log 64cfaeac4c5d..252d1eb47f23 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 yunchao.he@intel.com Suppress viewport test 2019-11-07 hao.x.li@intel.com Add Vulkan validation layers on Windows Created with: gclient setdep -r src/third_party/dawn@252d1eb47f23 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Ie448231d15d2173246d1fbdfeff40ad1268ed006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903828Reviewed-by:
-
Andreas Haas authored
The parameter was not used anymore. R=haraken@chromium.org CC=ulan@chromium.org Bug: chromium:1008840 Change-Id: I4651b4e9bdb4425820316d998ff3b9d11aaab90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893276Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#713420}
-
Tim Volodine authored
In this patch: - Add safebrowsing threat types to watch (currently malware, phishing, unwanted and billing). This is needed by the RemoteSafeBrowsingDatabaseManager. - Create and set native SafeBrowsingApiHandlerBridge during initialization. This is needed for native <-> java interactions. BUG=1015418 Change-Id: I2ea97435a6e3885382ca6cad163337acd17dafa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901045Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#713419}
-
Matthias Körber authored
To allow for a better impact assessment, the feature to overwrite static placeholders in username fields is retroactively put behind a Finch flag. Note that older version will always overwrite the static placeholder if the prediction from the server is supplied. Bug: 1022291 Change-Id: I39f1ac557f7e9751d348b1df5796bfa276839e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903351Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1af507800d72..070a9e2a8724 git log 1af507800d72..070a9e2a8724 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 treehugger-gerrit@google.com Merge "UI: feature-detect window.chrome, make firefox friendly" Created with: gclient setdep -r src/third_party/perfetto@070a9e2a8724 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I1a49344f78315d8932f5269a18111c059974cdca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903827Reviewed-by:
-
Juan Antonio Navarro Perez authored
These were not used for anything other than listing these in benchmarks.csv. Furthermore, the names of benchmarks do not match names of test suites actively uploading data to perf dashboard. Bug: 1020510 Change-Id: Ib17c4c4fc413a95aefb3003520304482b01109c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1897657Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#713416}
-
Jamie Madill authored
conformance/ogles/GL/struct/struct_009_to_016.html conformance/ogles/GL/struct/struct_017_to_024.html conformance/ogles/GL/struct/struct_025_to_032.html Tbr: kbr@chromium.org Bug: 1017162 Change-Id: I4f65aaf85b051f6aa7c1704671a20771f45b9c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903806Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#713415}
-
Anatoliy Potapchuk authored
This CL provides basic logic presuming we have network connection during the installation. Network handling will be done in a following CL. Bug: 1015383,1006230 Change-Id: Id60b480fd5fdce04a61fdd7c226424e204f18882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879451 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#713414}
-
Mikhail Khokhlov authored
Results Processor now handles all output formats, so we can remove the arguments that were used to pass some formats to Telemetry. Bug: 981349 Change-Id: Ibf6d12a7a1814b31c11d566f607f063694ab3f38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901028 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
-
Felipe Andrade authored
Second batch of KerberosCredentialsManager unit tests. Also adds a fake KerberosCredentialsManager::Observer to test notifications sent by KerberosCredentialsManager on accounts changes. Bug: 952251 Change-Id: I4c66a30c98c5b3862a7279acac2f66066a007098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871882 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#713412}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/e66080e9a1..7d10a733de TBR=aerotwist@chromium.org Change-Id: I686d703fd99cb2586c8bd182e2f59ae6239f6df6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903355Reviewed-by:
-
Benoît Lizé authored
ProductConfig is a class used for product-specific configuration. This is specifically targeted at providing different settings for TrichromeChrome and TrichromeWebView, without interfering with synchronized proguarding. This CL contains two things: 1. Renaming LocaleConfig -> ProductConfig, as it is used more broadly than Locales 2. Adding support for setting up the linker with it. The second point is required as TrichromeWebView must not be loaded with the Chromium linker, yet the configuration class currently lives in //base, which is in the library APK. To ease the migration, some targets still use the "default" configuration, which falls back to the existing mechanism, using NativeLibraries.java in base/android. Change-Id: Id034b1b24d3aee836442253c4b398231271ca107 Bug: 979638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886682 Commit-Queue: Benoit L <lizeb@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#713410}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/67d4bf7a..5de55dca Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4bfd189331ac9db165599f55e15c55817e57470d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902433Reviewed-by:
-
Gabriel Charette authored
Instead use base::DeleteSoon which enforces usage of TaskTraits. This CL is a no-op as-is. It was recently discovered however that some callers did BrowserThread::DeleteSoon() with pending tasks running on different task queues (different traits -- e.g. TaskTraits to make this more obvious. Please review whether calls in this CL can be migrated as-is or need additional traits to match potentially pending tasks. Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109 for cursory review. This CL was uploaded by git cl split. R=peter@chromium.org TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion... BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/ Bug: 1019767 Change-Id: Iab1b207a72afe4f2cc0b57d3fb97223282fe071c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893540 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#713408}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I6d35b0897dc753d16ae37bc83dff502f960af154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899500 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#713407}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8542baee0645..266e4e05a88c git log 8542baee0645..266e4e05a88c --date=short --no-merges --format='%ad %ae %s' 2019-11-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src d9fbf0234869..dc59b4b075e9 (2 commits) Created with: gclient setdep -r src/third_party/angle@266e4e05a88c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: chromium:None Change-Id: If6acc3208d4579d4ff3b58873bfe10dfd9f9dbe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903672Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/70ec48ca281c..54875d05f17e git log 70ec48ca281c..54875d05f17e --date=short --no-merges --format='%ad %ae %s' 2019-11-07 mbonadei@webrtc.org Add missing RTC_EXPORT for the Chromium Windows build. Created with: gclient setdep -r src/third_party/webrtc@54875d05f17e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: I224d8ccc0a90ed5d1eb16f783b03112611d04f63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903746Reviewed-by:
-
Tanmoy Mollik authored
Bug: 959157 Change-Id: I7aa52c938e813e1fcde76b370be1d6e8c4ea3401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886861 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#713404}
-
Friedrich Horschig authored
This CL adds a blue "Use Password" button to the touch to fill sheet if exactly one suggestion exists. This should address the potential problem that users don't see the bottom sheet as actionable. This CL can only be merged if a string translation is approved. The button is guarded by a field trial param. Activate it with a study like this: "TouchToFillStudy": [ { "platforms": ["android"], "experiments": [ { "name": "Enabled", "params": { "show_confirmation_button": "true" }, "enable_features": [ "TouchToFillAndroid" ] } ] } ] Screenshots with and without button are attached to the initial comment of the linked bug. Bug: 1021506 Change-Id: I8857987d7726800846d58338a518317099def022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1892962Reviewed-by:Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#713403}
-
Anastasiia Nikolaienko authored
In certain cases, Gaia's /ListAccounts APIs claims accounts to be in a valid state when they are actually invalid. This causes issues with account reconciliation because |AccountReconcilor| uses /ListAccounts as the source of truth and is unable to detect this state. In this state, certain Google properties like Gmail for example send a Mirror re-authentication header for the offending account. However, even after the user re-authenticates the account, account reconciliation ends up being a no-op because the reconcilor thinks that the user's cookies are valid and there is nothing to reconcile. Fix this by storing the accounts for which we receive Mirror re- authentication headers from Gaia and calling LogOutAllAccounts to remint cookie when tokens for these accounts are updated. Please check the attached bug for more context. Note: This is a temporary client-side fix until Gaia fixes its /ListAccounts API. Bug: 1012649 Change-Id: I797a049d59fe32ea406cf9ddbbbaa94bc2b57b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871591 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
-
Zakhar Voit authored
This introduces a flag that centers title text to WidgetDelegate and WebDialogDelegate and applies it to the login screen extension's window (it is one of the requirements for Imprivata TT launch). Bug: 1018682 Change-Id: I082a7de9ea29c07a6eb3e71a7c814ced5a2ce5d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883568Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Zakhar Voit <voit@google.com> Cr-Commit-Position: refs/heads/master@{#713401}
-
Anastasiia Nikolaienko authored
This reverts commit 30fd9e19. Reason for revert: submitting https://crrev.com/c/1871591 instead ( where we call LogOutAllAccounts directly instead of changing the logic of AccountReconcilor). Original change's description: > Fix Mirror cookie validity mismatch > > In certain cases, Gaia's /ListAccounts APIs claims accounts to be in a > valid state when they are actually invalid. This causes issues with > account reconciliation because |AccountReconcilor| uses /ListAccounts as > the source of truth and is unable to detect this state. > In this state, certain Google properties like Gmail for example send a > Mirror re-authentication header for the offending account. However, even > after the user re-authenticates the account, account reconciliation ends > up being a no-op because the reconcilor thinks that the user's cookies > are valid and there is nothing to reconcile. > > Fix this by storing some flags in |CookieReminter| which are set when > we receive Mirror re-authentication headers from Gaia, and are cleared > when the next reconciliation cycle begins. > > This is a temporary fix until we can submit https://crrev.com/c/1871591. > > Bug: 1012649 > Change-Id: I04fd971cdc788094f038ee808b4a38003ef48e22 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883652 > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710870} Bug: 1012649 Change-Id: I2873677ac23f3ea98930603f0c1615a59fa8ce97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901036Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1944f6e6df68..6d6b9a1ca930 git log 1944f6e6df68..6d6b9a1ca930 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 perezju@chromium.org [Telemetry] Remove legacy value system Created with: gclient setdep -r src/third_party/catapult@6d6b9a1ca930 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:992427 Change-Id: I74236c8f2988daaac0cc8b252959fa7c3eb822bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903668Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/866bde58907c..1af507800d72 git log 866bde58907c..1af507800d72 --date=short --no-merges --format='%ad %ae %s' 2019-11-07 primiano@google.com Merge "infra: quality of life" Created with: gclient setdep -r src/third_party/perfetto@1af507800d72 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Iebb4e4fcb81b466fe05097a9e4de7e90f206610c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903669Reviewed-by:
-
Sylvain Defresne authored
The omnibox already had a reimplentation of GTMFadeTruncatingLabel that used NSAttributedText property to perform the fade-truncation as OmniboxPopupTruncatingLabel. Move it to a shared location and rename it to FadeTruncatingLabel and convert TabView to use the new class thus removing another dependency on third_party/google_toolbox_for_mac. Before: https://drive.google.com/file/d/1YeEL6jkm-P9cNeEgS0vJxlPu-HIEo3_r/view After: https://drive.google.com/file/d/1U1jAVeXYg4RFiw98UzZ-yoBBoOG2e1MD/view Bug: none Change-Id: Ic43f0973d36ba6b74c0ad0a2fa9068d5a3be9bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1901082 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#713397}
-
