- 09 Jun, 2010 40 commits
-
-
rsesek@chromium.org authored
BUG=46186 TEST=Mac Valgrind UI 3 Review URL: http://codereview.chromium.org/2736002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49313 0039d316-1c4b-4281-b951-d872f2087c98
-
csilv@chromium.org authored
displaying in a tab. This could happen when the user types in a new query before the AlternateNavURLFetcher was able to resolve the URL. BUG=43378 TEST=Load two single word domains within quick succession in the same tab. Review URL: http://codereview.chromium.org/2747006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49312 0039d316-1c4b-4281-b951-d872f2087c98
-
eblake@chromium.org authored
Review URL: http://codereview.chromium.org/2748005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49311 0039d316-1c4b-4281-b951-d872f2087c98
-
dhg@chromium.org authored
BUG=chromium-os:3462 TEST=none Review URL: http://codereview.chromium.org/2758004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49310 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
BUG=none TEST=trybots Review URL: http://codereview.chromium.org/2770005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49309 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Review URL: http://codereview.chromium.org/2729002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49308 0039d316-1c4b-4281-b951-d872f2087c98
-
jcivelli@chromium.org authored
Since some work is needed on Linux and Mac to use the new translate infobar delegate, I created a new version of the refactored classes instead of replacing them. Once Linux and Mac use the new classes, we can make the swicth. The TranslateInfoBarDelegate now contains all states, so there is no more logic on the infobar classes. I broke down the single infobar class into multiple ones (there is now an infobar for each state: before translate, translating, after translate, error): it makes the code simpler. I had to fix ReplaceInfoBar on Windows as it was not working properly. BUG=40828 TEST=Test thoroughly the translate feature. Review URL: http://codereview.chromium.org/2602003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49307 0039d316-1c4b-4281-b951-d872f2087c98
-
luchen@google.com authored
Questions: - Is deltaY the correct field in which to store this event value? - Is the 'wheel' addEventListener hook broken in the first place? Doesn't work for me on OSX, but might be working in Windows/Linux and don't know if this change would break it for those. - It is necessary to cancel event bubbling for the onmousewheel event? Review URL: http://codereview.chromium.org/2456004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49305 0039d316-1c4b-4281-b951-d872f2087c98
-
luchen@google.com authored
Review URL: http://codereview.chromium.org/2718003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49304 0039d316-1c4b-4281-b951-d872f2087c98
-
senorblanco@google.com authored
BUG=none TEST=none TBR=hamaji Review URL: http://codereview.chromium.org/2724011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49303 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
BUG=46111 TEST=none Review URL: http://codereview.chromium.org/2785001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49302 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
the comment, I suspect it used to be private but got moved around and now it's public. TEST=none BUG=none Review URL: http://codereview.chromium.org/2740008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49301 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/2749004 TBR=sergeyu@chromium.org Review URL: http://codereview.chromium.org/2724010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49300 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
RFC 2744 does not require string types to be NULL terminated, because their length is explicitly passed as part of the gss_buffer_desc (see Section 3.2.). As such, when printing error strings, the length should be explicitly stated. This is shown in the example code of gss_display_status in Section 5.11. While in practice this is the case (at least from checking MIT and Heimdal's error handling code), it doesn't hurt to be defensive. In addition, there are some conditions where value may be NULL or length may be 0, so make sure to check for these prior to calling StringPrintf, so as not to crash. Finally, for the extreme defensive case, make sure that the length (which is a size_t) is capped at INT_MAX prior to printing. Contributed by ryan.sleevi@gmail.com BUG=33033 TEST=None Review URL: http://codereview.chromium.org/2646004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49299 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/2749004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49298 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=46177 TEST=CrOs Valgrind 3 goes green. Review URL: http://codereview.chromium.org/2739004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49297 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
Before we carefully used the app (Chrome/Chromium) name, but: 1) these are for internal debugging use only, so why compute this name 2) on Linux the thread ids are limited to 16 characters, and "Chromium" is too long Review URL: http://codereview.chromium.org/2741003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49296 0039d316-1c4b-4281-b951-d872f2087c98
-
nshkrob@chromium.org authored
2. Timed updates of the database based on the number of sites changed. BUG=None TEST=TopSitesTest Review URL: http://codereview.chromium.org/2746002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49294 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@chromium.org authored
for an invalid program. The check is already in UseProgram. If that check passes the program is "installed" at which point it, even if LinkProgram is called and fails, marking the program as invalid, the previously installed program is still in use until UseProgram is called. TEST=none BUG=none Review URL: http://codereview.chromium.org/2770007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49293 0039d316-1c4b-4281-b951-d872f2087c98
-
eroman@chromium.org authored
Review URL: http://codereview.chromium.org/2746005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49292 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
Change the layout of content and general page. Use the horizontal title and content layout for each option group. BUG=18949 TEST=Open the option window, check the content and general pages. Patch by Ningxin Hu <ningxin.hu@intel.com>. Review URL: http://codereview.chromium.org/1969006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49291 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=21149 TBR=agl@chromium.org Review URL: http://codereview.chromium.org/2711008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49290 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
BUG=46114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49288 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
Convert from using NSBitmapImageRep plus context manipulation to -[NSImage lockFocus]. BUG=none TEST=Browser actions look the same as before. Review URL: http://codereview.chromium.org/2635005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49287 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
Excluding them individually appeared to be too hard... BUG=38575 Review URL: http://codereview.chromium.org/2779006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49286 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
BUG=None TEST=net_unittests, and ran chrome with net_internals DNS. Review URL: http://codereview.chromium.org/2721005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49285 0039d316-1c4b-4281-b951-d872f2087c98
-
mirandac@chromium.org authored
A DictionaryValue we need to keep was being autoreleased in the Mac message loop. The import process uses only C++ code, so we just make a deep copy of the (very small, 5 strings) Dictionary when it's passed into the bridge. BUG=46003 TEST=import works on Mac OS 10.6 and 10.5 Review URL: http://codereview.chromium.org/2715006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49284 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
BUG=21149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49283 0039d316-1c4b-4281-b951-d872f2087c98
-
shess@chromium.org authored
AFAICT was being used by the star button, which is now a page action. BUG=none TEST=none Review URL: http://codereview.chromium.org/2675003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49282 0039d316-1c4b-4281-b951-d872f2087c98
-
scottbyer@chromium.org authored
On behalf of gene@chromium.org. Redesign cloud printing subsystem layer. Make it a class, and allow to have internal state. Also, some minor improvements. BUG=none TEST=Try run Windows cloud print proxy and confirm documents get printed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49200 Review URL: http://codereview.chromium.org/2519002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49281 0039d316-1c4b-4281-b951-d872f2087c98
-
mark@chromium.org authored
I have non-algorithmic changes to bsdiff and bspatch, and they'll be easier to review and easier to identify in the future if an unpatched copy is checked in first. The bsdiff and bspatch that you'll find elsewhere in the repository are actually different forks of bsdiff, and aren't quite as appropriate for use in the Mac binary patcher. The other copies are Mozilla's variant of bsdiff. BUG=45017 TEST=none Review URL: http://codereview.chromium.org/2789003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49280 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49279 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
New mocks are attached to bug 44622. These changes replace the in-place editing of address and credit card records with a table of records and separate sheets for manipulating the record data. Changes to the layout of fields on the sheets has been done also. AutoFillDialog.xib changes: Replaced disclosure based list of address and credit cards with an NSTableView of the same data. Added buttons for "Add", "Edit", and "Remove". Replaced AutoFillAddressViewController.xib with sheet-based AutoFillAddressSheetController.xib. Replaced AutoFillCreditCardViewController.xib with sheet-based AutoFillCreditCardSheetController.xib. BUG=44621 TEST=AutoFillAddressModelTest,AutoFillAddressSheetControllerTest,AutoFillCreditCardModelTest,AutoFillCreditCardSheetControllerTest,AutoFillDialogControllerTest Review URL: http://codereview.chromium.org/2673006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49274 0039d316-1c4b-4281-b951-d872f2087c98
-
noelallen@google.com authored
Review URL: http://codereview.chromium.org/2674003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49273 0039d316-1c4b-4281-b951-d872f2087c98
-
andreip@chromium.org authored
before passing the message to IndexedDBDispatcherHost for processing. This is a clone of http://codereview.chromium.org/2657007/show which was LGTM'ed by Jeremy Orlow. Review URL: http://codereview.chromium.org/2711004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49272 0039d316-1c4b-4281-b951-d872f2087c98
-
joth@chromium.org authored
It was pulling internal geolocation headers into resource_message_filter.cc BUG=none TEST=none Review URL: http://codereview.chromium.org/2742002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49271 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
keyboard. Because I don't want the menu to actually get focus I'm using SetHotTracked when traversing and AcceleratorPressed from enter/return. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2741004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49270 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
Add a command line switch to enable the pepper testing interface. This moves the other switch we were using in the plugins directory to the new file as well. TEST=covered by UI test BUG=none Review URL: http://codereview.chromium.org/2716002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49269 0039d316-1c4b-4281-b951-d872f2087c98
-
nkostylev@google.com authored
BUG=none TEST=All controls are disabled on "New User" screen with login is in progress Review URL: http://codereview.chromium.org/2774004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49268 0039d316-1c4b-4281-b951-d872f2087c98
-
andreip@chromium.org authored
This CL is a clone of http://codereview.chromium.org/2607001/show which was reviewd and LGTM'ed by Jeremy Orlow. Review URL: http://codereview.chromium.org/2740003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49267 0039d316-1c4b-4281-b951-d872f2087c98
-