- 04 May, 2018 40 commits
-
-
chrome://flagsIan Clelland authored
Bug: 837344 Change-Id: Ie1367ed1c12c714bad4d6aa28aa989b2a712c309 Reviewed-on: https://chromium-review.googlesource.com/1030841 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#555968}
-
Hiroshige Hayashizaki authored
This CL imports the async-local-storage implementation as-is except for renaming to index.js. Original author: Domenic Denicola (domenic@chromium.org) https://github.com/domenic/async-local-storage All code were written and contributed by Googlers who are Chromium Contributors. Tentatively this CL imports the files under core/script/resources until a long-term plan for repository location etc. is settled. This is a still experimental feature behind a flag, and its API interface and implementation can be changed significantly before shipped. This CL also imports a test with some modifications. Change-Id: I99944c75240ab2f1d114aa85f5c8ffac1f5e9b98 Reviewed-on: https://chromium-review.googlesource.com/1033713 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#555967}
-
Robert Liao authored
1) C4146 (unary minus operator applied to unsigned type, result still unsigned) for constexpr size_t dynamic_extent = -1; 2) Workarounds for ternary expressions in templates (parens currently needed). BUG= Change-Id: Ia5d4ded07e819589800e957ce8cf369ddd6cd4ac Reviewed-on: https://chromium-review.googlesource.com/1042806Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#555966}
-
Khushal authored
The context is allocated an id which is implicitly assumed to be 2 bytes, so it can be encoded in framebuffers/texture ids and used to verify that textures used with a context are allocated by it. This causes overflow issues with fuzzer runs, so wrap around the id once it reaches the max value. R=enne@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I10c799520be55a310ad90a4dfdb564f805cc3ce5 Reviewed-on: https://chromium-review.googlesource.com/1040878 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#555965}
-
Hiroshige Hayashizaki authored
This reverts commit 9a6936e7. Reason for revert: Suspected to cause compile failure on Windows debug builds: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win%20Builder%20%28dbg%29/130944 Original change's description: > Refactor AXSnapshotNodeAndroid into mojo. > > Test: browser_tests --gtest_filter=ArcVoiceInteractionArcHomeServiceTest.* > Change-Id: I25e45f2663767d5d7ef20bd8bb5637b077c6eb44 > Reviewed-on: https://chromium-review.googlesource.com/1014464 > Commit-Queue: Muyuan Li <muyuanli@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555921} TBR=dmazzoni@chromium.org,sky@chromium.org,dcheng@chromium.org,muyuanli@chromium.org Change-Id: I6b9ad7763f07410278c2aa5ea40b4aacbbe10e75 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1043187Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#555964}
-
Hiroshige Hayashizaki authored
This CL imports the virtual-list implementation as-is except for renaming virtual-list-element.js to index.js. Original author: Valdrin Koshi (valdrin@google.com) and Gray Norton (graynorton@google.com) https://github.com/valdrinkoshi/virtual-list All code were written and contributed by Googlers who are Chromium Contributors. Tentatively this CL imports the files under core/script/resources until a long-term plan for repository location etc. is settled. This is a still experimental feature behind a flag, and its API interface and implementation can be changed significantly before shipped. Change-Id: I07071ae2dd17481d3240198f91f28cf0cef5536d Reviewed-on: https://chromium-review.googlesource.com/1031749 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alex Russell <slightlyoff@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555963}
-
Antonio Gomes authored
This is a preparation CL to migrate GoogleURLTracker from URLFetcher to SimpleURLLoader. BUG=714018 Change-Id: I1ba490d9fea5bf5c23212471f723407de488023f Reviewed-on: https://chromium-review.googlesource.com/1042505 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#555962}
-
Hiroshige Hayashizaki authored
This is a reland of bde742c2 This reland contains fixes for: - Issue 839236 (by adding a dependency in core/script/BUILD.gn), and - A unit test failure that caused revert https://chromium-review.googlesource.com/1042065 (by adding skip_minify flag as the minifier inserted unexpected newlines to scripts) TBR=kinuko@chromium.org,kouhei@chromium.org Original change's description: > [Layered API] Implement Layered API infrastructure behind a flag > > This CL > 1. Maps std:x|y URLs to std:x (according to the draft spec [1]), > 2. Then maps to std-internal://x/index.js (not spec'ed [2]) > in GetInternalURL(), > 3. Then retrieves and serves the script contents for std-internal: > URLs in GetSourceText() using ui::ResourceBundle() > from blink_resources.pak. > > The source JavaScript files for Layered APIs are placed under > third_party/blink/renderer/core/script/resources/layered_api > and bundled into blink_resources.pak. > > This CL introduces std: and std-internal: schemes that are used in Blink side > (std: is user-facing while std-internal: is mostly invisible for users) > but not outside Blink. > > [1] Spec: > https://github.com/drufball/layered-apis/blob/master/spec.md > [2] Implementation design doc: > https://docs.google.com/document/d/1V-WaCZQbBcQJRSYSYBb8Y6p0DOdDpiNDSmD41ui_73s/edit > > Bug: 829084 > Change-Id: I61fc0a2f17d937db6e859303ab8a84e4b2b87850 > Reviewed-on: https://chromium-review.googlesource.com/1013321 > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555524} Bug: 829084, 839236 Change-Id: I37ed111cf924b52f5998c1e6a2b6dd7d1965c813 Reviewed-on: https://chromium-review.googlesource.com/1042616 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#555961}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8f20428bf4dc..848c86e3e858 $ git log 8f20428bf..848c86e3e --date=short --no-merges --format='%ad %ae %s' 2018-05-03 mmoss Make 'gclient_gn_args*' handling consistent between sync and flatten. 2018-05-03 martiniss Revert "Reland "bot_update: Patch on gclient by default."" Created with: roll-dep src/third_party/depot_tools BUG=chromium:825063,chromium:643346 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I38178ecfae2023a5ade41d0f584905010540cafb Reviewed-on: https://chromium-review.googlesource.com/1043461 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555960}
-
Rohit Rao authored
Switches to TableViewModel instead of a std::vector of BookmarkNodes. BUG=839423 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0b12b1c22f6f0d229eed79da407df2443081bbfe Reviewed-on: https://chromium-review.googlesource.com/1042349Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#555959}
-
Sammie Quon authored
Moved a common set of lines to overview_utils.cc and used the new function to fade out minimzed windows in tablet mode. Test: none Bug: 824720, 839486 Change-Id: I4655a49d5f79db9d98786a7cef6fdbcc23ddfb9d Reviewed-on: https://chromium-review.googlesource.com/984402 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555958}
-
Wang Qing authored
Extension API tests chromium.runtime GetPlatformInfo functions return NULL. Bug comes from automated test unit: browser_tests BUG= 838783 R= tbarzic@chromium.org Change-Id: I4f6b04835fb949f15218c5adc4401950ba14b0a3 Reviewed-on: https://chromium-review.googlesource.com/1038912Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: 汪 清 <wangqing-hf@loongson.cn> Cr-Commit-Position: refs/heads/master@{#555957}
-
Sunny Sachanandani authored
Raster tasks can be cancelled between being scheduled and running. When a resource is used for the first time, we create its texture and mailbox on the compositor context, and expect the worker context to wait on a sync token. If the task is cancelled before running, the sync token will be lost and never waited on. This CL stores the sync token in GpuBacking::returned_sync_token, and simplifies the code for passing the sync token to RasterBufferImpl. Test: RasterBufferProviderTest.WaitOnSyncTokenAfterReschedulingTask Bug: 836497 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4cf9be7909659a6a0bfdca44b9251539dd448d57 Reviewed-on: https://chromium-review.googlesource.com/1041142 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555956}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a2f0a25c..60da1b2e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ida7e0cf041cf73f1b00892fe5ee0c7ab2fad94a8 Reviewed-on: https://chromium-review.googlesource.com/1042889Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#555955}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2b23bcaf7dee01385f3753b8ceb2befaad751b77 Reviewed-on: https://chromium-review.googlesource.com/1043019 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#555954}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6cbd505d. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/16796 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=kereliuk No-Export: true Change-Id: I6cdc2a867f7e8f8aa8785727fa7f6b16f8e97394 Reviewed-on: https://chromium-review.googlesource.com/1043022 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#555953}
-
Jennifer Apacible authored
Currently, the initial media control shown is always the play (untoggled) icon. This change checks for whether or not the play is currently active, or playing, when entering Picture-in-Picture mode. This change also updates how media player state (active / inactive) and other relevant information (e.g. media player id) is retrieved. The MediaWebContentsObserver and MediaPlayerId are not updated after entering Picture-in-Picture mode. BUG: 836389 Change-Id: I64baafebc20bf91fd457866237d1ec8dd526fd68 Reviewed-on: https://chromium-review.googlesource.com/1034158 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#555952}
-
Lukasz Anforowicz authored
Cross-Origin Read Blocking (CORB) tries to protect certain resource types (e.g. text/html). To be resilient against HTTP responses mislabeled with an incorrect Content-Type, CORB sniffs the response body to confirm if it truly is the protected type. Before this CL the confirmation sniffing logic decided to block resources that are both a valid html and a valid javascript. Blocking of such resources is undesirable, because it is disruptive to existing websites that use such polyglot responses in <script> tags. After this CL, a HTML comment that contains a Javascript comment will cause the confirmation sniffing to decide that the response is not really a HTML document (this will prevent CORB blocking). Bug: 839425 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie790a81c2742513aed9fda45edd0bb2976bd0fc6 Reviewed-on: https://chromium-review.googlesource.com/1042820 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#555951}
-
Stephen Martinis authored
Bug: 818832 Change-Id: I235b3c2ea84cdae68e7787f4d0a8ff7e277ab669 Reviewed-on: https://chromium-review.googlesource.com/1042846Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#555950}
-
Wenzhao Zang authored
1. Unify the Gaia and network screens to use the same |userCount|. 2. Does not unify the views and WebUI login because: 1) It's probably better to check $('pod-row').pods.length in WebUI since loading the pods takes some time. 2) The WebUI is being deprecated soon. Bug: 838083 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ifac5797f244d08815e2357404e95c4ba7f9f953a Reviewed-on: https://chromium-review.googlesource.com/1040769 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555949}
-
Ted Meyer authored
Allows a preferred and fallback decoder to be sent cross-thread and initialized without requiring extra thread hops back to report the status of an intermediate failure. Bug: 832917 Change-Id: Ib9e014a746e38588ce285153230511b33db8e47b Reviewed-on: https://chromium-review.googlesource.com/1023115 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#555948}
-
Chris Nardi authored
GeometryInterfaces was promoted to stable by https://crrev.com/481096, which landed in M61. Remove the flag as it is no longer needed. Bug: 402536 Change-Id: I56e739958ca13c1185889070b99e32efa501c46b Reviewed-on: https://chromium-review.googlesource.com/1043092Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#555947}
-
Eric Orth authored
Convert final usage to a ClearAllEntries() call since the final usage is building a duration to clear everything anyway. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id6a4c1fc0000fb0d0aacb37a39e6998842c01f0d Reviewed-on: https://chromium-review.googlesource.com/1035942 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#555946}
-
Ben Pastene authored
This "cros_vm_launcher" target generates a script at build time (located at $out_dir/bin/launch_cros_vm) that you prepend to any other command and it will ensure a cros VM is running for the duration of the command. Also add it as a dependency to telemetry unittests. Invoking it in a bot's tests will come in a later CL. Bug: 828607, 832374 Change-Id: I56ee169c81127bf8cac1114b719f1cdeeb2c3d31 Reviewed-on: https://chromium-review.googlesource.com/1040117Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#555945}
-
dpapad authored
Previous code was working around crbug.com/689158 and crbug.com/768555. New code still works around them, but without requiring JS logic to do so, achieved by wrapping the cr-toggle contents with a <button>. Bug: 768073 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I435f6a44979a934b8548b13bdbd947d324eab5c5 Reviewed-on: https://chromium-review.googlesource.com/1040683Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#555944}
-
danakj authored
Replaces the WebBlendMode enum with a BlendMode enum in graphics_types.h under platform/graphics/ which is used throughout blink. This type is kept because the bindings generator requires an enum with matching names as the CSS property names (namely kNormal instead of kSrcOver). Then we convert from BlendMode to SkBlendMode in GraphicsLayer in order to pass it to the WebLayer. TBR=fserb Bug: 838693 Change-Id: If306343f4cd51911b46d6e1ca96529789477d29d Reviewed-on: https://chromium-review.googlesource.com/1038403 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#555943}
-
Majid Valipour authored
We use the latter on everything else in cc/animation and better to be consistent. This change should have no functionality change. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I87b37c9ab02166b628420cad95b7ea6a74d57caa Reviewed-on: https://chromium-review.googlesource.com/1042847Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#555942}
-
https://pdfium.googlesource.com/pdfium.git/+log/525147a1f6d6..ad178855775d $ git log 525147a1f..ad1788557 --date=short --no-merges --format='%ad %ae %s' 2018-05-03 rharrison Invalidate GIF input buffer when moving file cursor backwards 2018-05-03 tsepez Prove that the memory was good at FPDFBitmap_CreateEx() create time. 2018-05-03 hnakashima Use pointers instead of refs in CXFA_TextLayout params. 2018-05-03 dsinclair [xfa] Verify we can get a font manager before setting up XFA 2018-05-03 dsinclair [xfa] Verify field count before accessing Created with: roll-dep src/third_party/pdfium BUG=chromium:839348,chromium:839361,chromium:838886,chromium:835693,chromium:837585 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I06ec60f0a34b13f864be053ffe512402c4c8ad7a Reviewed-on: https://chromium-review.googlesource.com/1043278Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555941}
-
Hiroshige Hayashizaki authored
As the current minifier doesn't support module scripts (e.g. import statements) and [1] is going to add module scripts that contain imports to a grit archive, this CL adds a |skip_minify| option to skip minifier for individual files as a workaround. |skip_minify| will be used in [1]. [1] https://chromium-review.googlesource.com/1031749 Bug: 829084, 839512 Change-Id: Ie4c3ad21cd2ef8cfb715d0eb57e7045f754acc1a Reviewed-on: https://chromium-review.googlesource.com/1031108 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#555940}
-
Jun Choi authored
Currently FidoDiscovery::Start() is called in the constructor of FidoRequestHandlerBase class. This potentially leads to crash in authenticator_impl_unittest.cc when FakeU2fDevice is used. When FakeU2fDevice is used, the device is added in a synchronous manner as soon as discovery starts. This leads to invocation of FidoRequestHandlerBase::DeviceAdded() which then calls CreateTaskForNewDevice() which is a pure abstract function. This has been a non-issue until now as may unit tests does not actually call AuthenticatorImpl::{MakeCredential, GetAssertion}() and because AuthenticatorImpl constructor we used in unit tests has empty |protocols_| field. This should be changed as we add more end to end tests in future. Thus this CL moves invocation of FidoDiscovery::Start() from base class constructor to constructor of implementing class and add hid transport to AuthenticatorImpl::protocols_ in constructor. Bug: 798573 Change-Id: Iaca4978dd06233f670b44b52a30ec192b5f2cb51 Reviewed-on: https://chromium-review.googlesource.com/1032258 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#555939}
-
Gabriel Charette authored
Cleanup while working towards crbug.com/839525 R=fdoray@chromium.org Bug: 839525 Change-Id: I5616ebb2f2037fb8d7d1f1259c3cb57e958d02d4 Reviewed-on: https://chromium-review.googlesource.com/1042881Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#555938}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6c692edf010c..8f20428bf4dc $ git log 6c692edf0..8f20428bf --date=short --no-merges --format='%ad %ae %s' 2018-04-25 ehmaldonado Reland "bot_update: Patch on gclient by default." Created with: roll-dep src/third_party/depot_tools BUG=chromium:643346 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: If1aeb8f42c55a23a9fc1f92555fe37b794373fa4 Reviewed-on: https://chromium-review.googlesource.com/1043154Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555937}
-
Lukasz Anforowicz authored
Bug: 838623 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6afbc0a870a7818ebec64da5d81875dd72173586 Tbr: olivierrobin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1036527 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#555936}
-
Stefan Zager authored
This includes two chromium-specific commits to support CPU profiling on Android with simpleperf. R=agrieve@chromium.org Change-Id: Ibce20aae72d5c01af055f3125cdbd848fe6c427d Reviewed-on: https://chromium-review.googlesource.com/1043069Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#555935}
-
Kenneth Russell authored
The chromium/src CL needs to land before the tools/build CL does, or the builder will break completely. Bug: 838970 Change-Id: I3d788eac5564ad90bdd67f6e387a309b8718185b Tbr: zmo@chromium.org Tbr: cwallez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1043489Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#555934}
-
https://chromium.googlesource.com/catapult.git/+log/19282cf9d32d..153134ef26c3 $ git log 19282cf9d..153134ef2 --date=short --no-merges --format='%ad %ae %s' 2018-05-03 dtu [pinpoint] Increase task queue rate. 2018-05-03 szager Add support for profiling on Android using simpleperf 2018-05-02 ssid Fix symbolization of heap profiles when so is mapped from apk 2018-05-03 nednguyen Fix cache_temperature_unittes to use working pages from test archives Created with: roll-dep src/third_party/catapult BUG=chromium:734705,chromium:839127 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I97dd890c7eda177ae8b603b830e60bfbb215da98 Reviewed-on: https://chromium-review.googlesource.com/1043079 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555933}
-
Noel Gordon authored
Bug: 833834 Change-Id: Iea9d32052c6ffbe17bf2cdd5075cbf5e9a203e0a Reviewed-on: https://chromium-review.googlesource.com/1042428Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555932}
-
Peter Collingbourne authored
This is useful for files that are only read by the linker, such as orderfiles. We were normally getting this right in the case where the target contained at least one source file, as the output file would transitively depend on the inputs via the source files, but if the target only contained dependencies on other targets, the inputs wouldn't be depended on at all. Bug: 835622 Change-Id: Ic7fb39caeacd4698b7ec6cfb0cb583a429a117dd Reviewed-on: https://chromium-review.googlesource.com/1041274Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#555931}
-
Dongseong Hwang authored
In the case, the fullscreen strategy is used for scanning out fullscreen scaled buffers (i.e. fullscreen youtube), instead of single on top strategy. It makes the case not submit the unnecessary primary plane to display engine. TEST=Youtube https://youtu.be/w8RN8T13rjE on soraka BUG=683347 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8c82c7dd6182c34c0420ff4819ba37d5881039f0 Reviewed-on: https://chromium-review.googlesource.com/656222 Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Dongseong Hwang <dongseong.hwang@intel.com> Cr-Commit-Position: refs/heads/master@{#555930}
-
Maks Orlovich authored
Bug: 832908 Change-Id: Ibf6b40fc043dfded18d500d71fa5f5316d1a31af Reviewed-on: https://chromium-review.googlesource.com/1042219Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#555929}
-