- 28 Jun, 2019 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5d13106e..b8c9b171 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I457423a0d9b25b6a8d832bab9ed35a6332c4b634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681780Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673368}
-
Alexandre Frechette authored
When choosing a new UI language, enable it and put it at the top of the accept languages list. That way the accept languages list reflects the user's language preferences. Bug: 972033 Change-Id: I5bbee2f569f3a0d5941ebb161bcae751b3c41001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665650 Commit-Queue: Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#673367}
-
Lutz Justen authored
Adds support for KerberosRememberPasswordEnabled and KerberosAddAccountsAllowed policies. Both are enabled by default. If KerberosAddAccountsAllowed is disabled, all unmanaged accounts are erased, the 'Add account' button (in the Kerberos accounts settings page) is disabled and a management indicator is shown. If KerberosRememberPasswordEnabled is disabled, all stored passwords for unmanaged accounts are erased, the 'Remember password' checkbox (when adding an account) is disabled and a management indicator is shown. BUG=chromium:952239 TEST=Enable KerberosEnabled policy, add a managed account with KerberosAccounts policy, go to chrome:settings/kerberosAccounts, add an account and remember the password, change KerberosRememberPasswordEnabled policy to false, reload policy and chrome:settings/kerberosAccounts page (does not auto-update), click 'Refresh Now' on the manually added account, make sure that the password field is empty and the 'Remember password' checkbox is unchecked and disabled, disable KerberosAddAccountsAllowed policy, reload policy, go to chrome:settings/kerberosAccounts, make sure that the manually added account got removed and the 'Add account' button got disabled. Change-Id: Ia9c0d5d31a655981972850b872e7c57ab5a4a7fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674548 Commit-Queue: Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#673366}
-
David Bokan authored
We ignore the scale limits to prevent pages from overriding a user's ability to zoom into content. However, the minimum-scale is less important since a poorly set limit would mainly just prevent the user from getting an overview of the page. Pages often use the minimum-scale to ensure the intended layout of the page isn't shrunken beyond the viewport size so without this change many page layouts appear broken on load. Bug: 929709 Change-Id: I220dd0f5df912921e9876e0005452a7a4e9f1adf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680688 Auto-Submit: David Bokan <bokan@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#673365}
-
Mohamed Amir Yosef authored
Before this CL: The ModelTypeWorker were unconditionally setting the title in the BookmarkSpecifics, if the SyncEntity.name isn't empty. However, the production server sets the name to "tombstone" for tombstones and hence the worker would actually set the title in the specifics. As a result the specifics are never empty. Empty specifics are used further in the pipeline to identify remote deletions, and hence remote deletions are always ignored. After this CL: The ModelTypeWorker would only assign the title for non-tombstones. Bug: 979150 Change-Id: I9ec80efbba95c2163403b3564adb1ae2bade3dfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681890 Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#673364}
-
jonross authored
Suppress compositing/reflections/reflection-on-composited.html TBR=backer@chromium.org Test: vulkan_swift_shader_blink_web_tests Bug: 979652 Change-Id: I862e5fd53e2ce63096287c9e26713a5002d0c635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681877Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#673363}
-
Tim Volodine authored
Records the custom response status code for the intercepted requests where input stream is null. The data is recorded only when the status codes and reason phrases are actually valid. This is recorded regardless of whether the network service is enabled or disabled. The UMA is useful to see if there is any significant usage for this type of interception. This type of interception has been originally mentioned in crbug.com/965608, where it results in behavior different to the old (non-network service) code path. Also see crbug.com/974273 for more details. BUG=974273,965608 Change-Id: I5a36757621b0b6227c10fae862749f85f8b0e4a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660657Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#673362}
-
Lutz Justen authored
For managed Kerberos accounts, this CL - adds a management indicator next to an account in the accounts list, - adds a management indicator on the advanced configuration dialog - disables the option to remove the account and - disables the text area to edit the configuration. Also renames a JS field from 'hasRememberedPassword' to 'passwordWasRemembered' in order to reflect the field in the proto. BUG=chromium:974145 TEST=./testing/xvfb.py out/Release/browser_tests --gtest_filter=CrSettingsPeoplePageKerberosAccountsTest.All Enable KerberosEnabled policy, add managed accounts via KerberosAccounts policy, open chrome:settings/kerberosAccounts, make sure that the all the things advertised above are true. Change-Id: I6386657c98dfc028081c1fef26b7f14e8e8b43fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674085 Commit-Queue: Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Reviewed-by:Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#673361}
-
Aran Gilman authored
Specifically, this CL does the following: * Return DarkModeClassification instead of bool from ShouldInvertColor(). This makes the interface for color classification more similar to that for image classification. * Create a separate file for DarkModeColorClassifier tests. This encourages more thorough testing of individual classifiers. * Make DarkModeClassification an enum class and remove "DarkMode" from the individual values' names. * Add ElementRole enum to DarkModeFilter. This sets up planned changes for handling elements differently depending on the "role" within the page. There was actually a bug in the old code where most text drawing methods did not use the new text inversion check. This should now be fixed. Bug: 968340 Change-Id: Ide6e26182f70bb2679ca0d20e295b0402559df38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679480Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Aran Gilman <gilmanmh@google.com> Cr-Commit-Position: refs/heads/master@{#673360}
-
Aran Gilman authored
Bug: 971068 Change-Id: I20cdf28af8b98d5475ca38d35c8a9fd7cff04044 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680945Reviewed-by:
-
Mohammad Refaat authored
TabSwitcher's protocol dismissWithNewTabAnimationToModel method used to return Tab. The return value was never used by any caller. and doesn't seem to be needed. Bug: 911733 Change-Id: Ie0f86362905c9015ad725d4fc19b99f553f3ae90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680894 Auto-Submit: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#673358}
-
Lutz Justen authored
Adds the ability to disable settings-textarea elements. Disabled text areas are aria-disabled, unfocused and are not reachable by tabbing. BUG=chromium:974145 TEST=browser_tests --gtest_filter=CrSettingsTextareaTest.* Change-Id: I085c2a045e4d5432cc23d9b21da582fc9255c742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676633 Commit-Queue: Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Reviewed-by:
-
Rayan Kanso authored
Bug: 973844 Change-Id: I9d5c64c163abb6bfd81df16ab77fb7b4c9d56d5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678181Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#673356}
-
Mihai Sardarescu authored
This CL removes a bit of dead code from LoginUIService::DisplayLoginResult(). Bug: NONE Change-Id: Ia303e5776fa61186854abb22db24df724648017f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682028Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#673355}
-
Lutz Justen authored
Changes FakeKerberosClient's internal storage from a map to a vector, so the order in which accounts are added is preserved. Also remembers whether the login password was used. BUG=chromium:952240 TEST=Manually tested on Linux desktop Change-Id: Icfb576e3f54f97cdb849b41ea6dd8fa49b3101ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674084 Commit-Queue: Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Reviewed-by:
-
Lutz Justen authored
Adds a notification triggered by a signal from the Kerberos credentials manager when the active Kerberos ticket expires. Upon clicking the ticket, the reauthentication flow is started. In practice, this should happen every few weeks if the Kerberos ticket lifetime and renewal lifetime are set properly on the KDC, e.g. 24 h lifetime + 14 days renewal lifetime. BUG=chromium:952245 TEST=None Change-Id: I0bb9965a0598571208f20c9ab53750ded2f6769a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1667304Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#673353}
-
Tanmoy Mollik authored
Enable UnifiedConsent for ArticleSnippetsTest and update goldens for personalized sign-in promos. Bug: 936986 Change-Id: Ia058e6c2a18a5c49c13b019522ecc09067df5082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679754Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Cr-Commit-Position: refs/heads/master@{#673352}
-
Maksim Moskvitin authored
NigoriSyncBridge now respects custom_passphrase_derivation_method and custom_passphrase_scrypt_salt fields and supports decryption with keys derived using SCRYPT method. If the remote update contains an unsupported key derivation method (or SCRYPT, while kSyncForceDisableScryptForCustomPassphrase is enabled), the bridge reports ModelError (which means sync becomes inactive). This CL doesn't support migration, which fills custom_passphrase_derivation_method for old CUSTOM_PASSPHRASE users, but fills it if user just enabled CUSTOM_PASSPHRASE. The complete migration code will be added in follow-up CLs. Bug: 922900 Change-Id: I87bacd54d8b22b9f53868161e1196398bb966661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676710 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
-
Philip Rogers authored
Bug: 979389, 979380, 979367 Change-Id: I69039de5179152c3ab4a021243f50ebad3050401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1682008Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#673350}
-
David Bokan authored
The fallback cursor determines scroll modes based on the location within the current scroller. The location and size of the scroller are compared in root frame coordinates (i.e. the page's coordinate system). However, for the root scroller, we need to account for zooming. When the page is zoomed, the scroller's (visual viewport's) bounds shrink within the root frame. This means we need to convert the root-frame-relative point into the visual viewport so that we're computing locking relative to the visual viewport. Bug: 978214 Change-Id: Ib995aa9171ae818dd43a5b6208dd061ec6892eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681271Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#673349}
-
Peter Kasting authored
To avoid decreasing the supported platforms from today, this expands enable_hidpi from Linux (incl. CrOS)/Mac/Win to also include iOS. This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1670357 , which was reverted since a direct dependency on ui_features.gni breaks external projects. Bug: 564112 Change-Id: I2426ccae4eaf300a1fe8df77bccb3ec2e932ee01 TBR: rohitrao, sadrul Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681302 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#673348}
-
Scott Violet authored
GetStateForTabSwitch() was previously called before the active WebContents changed. It's now called *after* the WebContents has changed. As GetStateForTabSwitch() may access the WebContents to determine state, this change broke some behavior. To fix it, this patch avoids querying for state from the WebContents, and instead handles the one case this cared about after the switch. BUG=923290 TEST=covered by test Change-Id: Ia8e4ccdeb5c90577783630c271909b5e633ca4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670151Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#673347}
-
Ella Ge authored
TBR=nhiroki@chromium.org No-Try: true Bug: 979593 Change-Id: I24b412334c6fe64338bc2e0e3b467c0e8d5f12cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681874Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#673346}
-
Mathias Carlen authored
This patch introduces a new action to display message popups (bubbles) in the bottom sheet anchored at the icon. R=arbesser@google.com Bug: b/132863319 Change-Id: I51d2d885937e6e50e8273217c481b606be7a91d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681771 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#673345}
-
David Bertoni authored
Extensions may register service workers at multiple scopes, but only the script specified in the manifest's background data is given bindings. Bug: 961836 Change-Id: I03ab866842e00c198f2a6f0b2d150ed671302a90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606188Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#673344}
-
Andy Paicu authored
This allows flash to be used in incognito as well if the user chooses to. Bug: 974721 Change-Id: Ibbc825df65b2a0a6b48944cad2bad82cc733eb43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681762 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#673343}
-
Charlene Yan authored
This will be used for TabGroups interactive tests since they will have varying number of tabs. Change-Id: I1de27a149cd9f94c04701ddf0e2f7392d87c2bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680654Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#673342}
-
Xiaocheng Hu authored
Current code uses weakly-typed CalcOperator enum for arithmetic operators, and casts them between chars interchangeably. This makes it hard to read, and prevents extending the operators with more math functions. Hence, this patch changes CalcOperator to a strongly-typed enum, stops all the direct casting between chars, and renames it to CSSMathOperator as a preparation to add new math functions. Bug: 825895 Change-Id: Ie2ea58163f800cf5f480ac34a9c49a3e677e1946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680294Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#673341}
-
Steven Bennetts authored
I missed migrating a couple of CrPolicyNetworkBehavior calls from html in https://chromium-review.googlesource.com/c/chromium/src/+/1669093. The symptom was the policy indicator missing from the list of wifi networks (now fixed). Bug: 853953 Change-Id: Ie6e786bb22cebd7033c3fdfdb794721853520392 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680998Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#673340}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/825aad13dcf4..a47ba4119f27 git log 825aad13dcf4..a47ba4119f27 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 eladalon@webrtc.org Get rid of deprecated version of NackSender::SendNack [1/2] 2019-06-28 asapersson@webrtc.org RateControlSettings: add option to set min pixels per frame for libvpx vp8. 2019-06-28 alessiob@webrtc.org NetEQ: BackgroundNoise::Update returns true when the filter is updated Created with: gclient setdep -r src/third_party/webrtc@a47ba4119f27 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4149b09597f6613f38c83e732c0360d701a2d0c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681988Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673339}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30c1bb6efcde..923582ce437a Created with: gclient setdep -r src-internal@923582ce437a The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=peria@google.com,poromov@google.com,eirage@google.com Change-Id: Ib2761db346ac44d170d2b6de19b77fc7de2d3a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681991Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673338}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/40495290dceb..74561df3e679 git log 40495290dceb..74561df3e679 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 swiftshader.regress@gmail.com Regres: Update test lists @ 40495290 Created with: gclient setdep -r src/third_party/swiftshader@74561df3e679 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I1c61b70a30f97e1696613aa841a641274f48cd9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681987Reviewed-by:
-
Henrique Nakashima authored
savePageLater() was moved from OfflinePageBridge to RequestCoordinatorBridge. Migrate the deprecated call so it can be deleted from RequestCoordinatorBridge. This CL is the chromium part of step 2 in refactoring RequestCoordinatorBridge out of OfflinePageBridge. Bug: 978871,959957 Change-Id: I55c920de7fccf70b01b963e308559ac24e5c1cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1678289Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#673336}
-
Mehran Mahmoudi authored
This fixes an issue in Protected Media settings that happens on small screens when using keyboard input. It prevents focusing the TriStateSiteSettingsPreference items using directional keys. Bug: 974413 Change-Id: I8c432774ba92dc9a2419ccdbd57946e69c11db9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680832Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#673335}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Icf5ca321de51256ceef45900548f36bc29fd7205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660387 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#673334}
-
Luke Zielinski authored
Bug: 937369 Change-Id: Iccfe46ee026e77dd826f6b132cf3e72fd0500246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680604 Auto-Submit: Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#673333}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6580f3fa. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." bc7ec548 "MSE: Test addSourceBuffer and changeType relaxed type strictness and allowance for implicit changeType" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ibf7b692f6268f0d8e10d22bec49b02b2ffb1f0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680694Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#673332}
-
Hitoshi Yoshida authored
In compiling Web IDL, we want to modify AST-based definitions. IRs are internal representations for IDL definitions to manage in IDL compilation. This CL defines skeltons of IRs, and they will be implemented in follow-up CLs. Bug: 839389 Change-Id: I614901109c4aec9c42a8986b919d6b7184ef309e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681446 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#673331}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f5a4989c..5d13106e Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic61d58161495aef0af7fcdb75e8e5d6dc41f64c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681421Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f51c389d79a4..6d47875c4c50 git log f51c389d79a4..6d47875c4c50 --date=short --no-merges --format='%ad %ae %s' 2019-06-28 taylori@google.com systrace: Update traceconv version Created with: gclient setdep -r src/third_party/catapult@6d47875c4c50 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=crouleau@google.com Change-Id: Ic10575628169ac2b5c58cafc0f1e43f0733c42ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1681364Reviewed-by:
-
