GitLab

The Ime test, testPastePopupShowAndHide, was flaking because of a race condition
where the paste popup menu was shown before the insertion handle was shown. This
is a problem because it allows the scenario:

1) Paste menu shown
2) Set composition
3) Insertion handle is shown

This causes the paste menu to not be hidden since setting the composition only
clears the menu by clearing the insertion handle. This CL makes setting the
composition wait for the insertion handle to be shown to guarantee this sequence:

1) Paste menu and insertion handle shown
2) Set composition
3) Insertion handle cleared
4) Paste menu hidden

BUG=661572

Review-Url: https://codereview.chromium.org/2617583003
Cr-Commit-Position: refs/heads/master@{#441971}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9e6944a8f310..fa1926f937dc

$ git log 9e6944a8f..fa1926f93 --date=short --no-merges --format='%ad %ae %s'
2017-01-06 sullivan Update perf dashboard tooltips to use logdog logs and show status pages.
2017-01-06 charliea Undo unnecessary disables from http://crrev.com/2236493003/
2017-01-05 simonhatch Dashboard - Add some extra logging info for failed auto-bisect.
2017-01-05 nednguyen Revert of Asserting telemetry story display name length for filename creation. (patchset #3 id:40001 of https://codereview.chromium.org/2488743006/ )
2017-01-05 dtu [pinpoint] Fix error message for missing parameters in /isolated.
2017-01-05 benjhayden Update UserModel to an ES6 class.
2017-01-05 benjhayden Configure chai to include stack traces.
2017-01-05 achuith Revert retries for DNS failures.
2017-01-05 benjhayden Finish renaming InteractionRecords to UserExpectations.
2017-01-05 sullivan Add a cached last_row_timestamp to StoppageAlert.
2017-01-05 eakuefner [Dashboard] Factor business logic in AddPointHandler out into AddData method
2017-01-05 simonhatch Dashboard - Bisect output should include percent change if possible.
2017-01-05 jessimb Changing group reports to use an id for multiple keys.
2017-01-05 charliea Replace iterItems() with Object.entries() in a few files
2017-01-05 charliea Use individual power sample for story:power metric
2017-01-05 eakuefner [Dashboard] Eliminate redundancy in AddPointHandler.post
2017-01-05 mikecase Add logcat markers to begin and end of each story.
2017-01-05 charliea Migrate more files from iterItems() to Object methods
2017-01-05 simonhatch Dashboard - Refactor output and clarify bisect failures.
2017-01-04 charliea [catapult android trybot] Make Telemetry tests run on Android
2017-01-04 eyaich Asserting telemetry story display name length for filename creation.
2017-01-04 achuith Browser startup timeout 4 min on ChromeOS, 1 min elsewhere.
2017-01-04 aiolos Unit refactor cl 1: Rename UnitScale to UnitPrefixScale.

BUG=662941,546625,665439,678282,665439,662941,676742

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2613243002
Cr-Commit-Position: refs/heads/master@{#441970}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/platform/.

There are too many references to change them all at once, so this CL is
part 14 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2615813003
Cr-Commit-Position: refs/heads/master@{#441969}

HistoryPage_EntryLinkClick
HistoryPage_InitClearBrowsingData
HistoryPage_RemoveSelected
HistoryPage_Search
HistoryPage_SearchResultClick

BUG=676121

Review-Url: https://codereview.chromium.org/2592843002
Cr-Commit-Position: refs/heads/master@{#441968}

Reset the scrollview delegate before releasing the WKWebView.
Move the |scrollview setDelegate:| to static_html_native_content.mm for symetry.

BUG=678118

Review-Url: https://codereview.chromium.org/2616633003
Cr-Commit-Position: refs/heads/master@{#441967}

Revert of Add CHECKs to ResourceLoader to investigate crashes (patchset #1 id:1 of https://codereview.chromium.org/2619513002/ )

Reason for revert:
This seems to be causing WebKit Linux Trusty Leak to fail reliably, perhaps you don't need to test in the wild with a CHECK after all?

04:10:44.200 6804 worker/0 http/tests/htmlimports/import-async-previous-async.html crashed, (stderr lines):
04:10:44.200 6804   [1:1:0106/041043.551773:1549663839:FATAL:ResourceLoader.cpp(70)] Check failed: !m_loader.
04:10:44.200 6804   #0 0x0000014b22ce base::debug::StackTrace::StackTrace()
04:10:44.200 6804   #1 0x0000014c110b logging::LogMessage::~LogMessage()
04:10:44.200 6804   #2 0x000002832215 blink::FinalizerTrait<>::finalize()
04:10:44.200 6804   #3 0x000000f0fae0 blink::NormalPage::sweep()
04:10:44.200 6804   #4 0x000000f0dd29 blink::BaseArena::completeSweep()
04:10:44.200 6804   #5 0x000000f12edc blink::ThreadState::completeSweep()
04:10:44.200 6804   #6 0x000000f14c40 blink::ThreadState::collectGarbage()
04:10:44.200 6804   #7 0x00000241a36f blink::V8GCController::gcEpilogue()
04:10:44.200 6804   #8 0x000000a85b05 v8::internal::Heap::PerformGarbageCollection()
04:10:44.200 6804   #9 0x000000a849bc v8::internal::Heap::CollectGarbage()
04:10:44.200 6804   #10 0x000000a83943 v8::internal::Heap::CollectAllGarbage()
04:10:44.200 6804   #11 0x00000241aa0b blink::V8GCController::collectAllGarbageForTesting()
04:10:44.200 6804   #12 0x0000023a11c7 blink::(anonymous namespace)::WebLeakDetectorImpl::collectGarbageAndReport()
04:10:44.200 6804   #13 0x00000148c109 _ZN3IPC8MessageTI34ShellViewMsg_TryLeakDetection_MetaSt5tupleIJEEvE8DispatchIN7content15BlinkTestRunnerES7_vMS7_FvvEEEbPKNS_7MessageEPT_PT0_PT1_T2_
04:10:44.200 6804   #14 0x00000148b980 content::BlinkTestRunner::OnMessageReceived()
04:10:44.201 6804   #15 0x0000020f3da2 content::RenderViewImpl::OnMessageReceived()
04:10:44.201 6804   #16 0x0000016616d5 IPC::ChannelProxy::Context::OnDispatchMessage()
04:10:44.201 6804   #17 0x000001525b0e base::debug::TaskAnnotator::RunTask()
04:10:44.201 6804   #18 0x00000231a9b2 blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
04:10:44.201 6804   #19 0x0000023195f4 blink::scheduler::TaskQueueManager::DoWork()
04:10:44.201 6804   #20 0x000001525b0e base::debug::TaskAnnotator::RunTask()
04:10:44.201 6804   #21 0x0000014c631d base::MessageLoop::RunTask()
04:10:44.201 6804   #22 0x0000014c6a65 base::MessageLoop::DoWork()
04:10:44.201 6804   #23 0x0000014c7a4a base::MessagePumpDefault::Run()
04:10:44.201 6804   #24 0x0000014c6047 base::MessageLoop::RunHandler()
04:10:44.201 6804   #25 0x0000014dfc5e base::RunLoop::Run()
04:10:44.201 6804   #26 0x000002110b80 content::RendererMain()
04:10:44.201 6804   #27 0x000000fc5887 content::RunZygote()
04:10:44.201 6804   #28 0x000000fc67fc content::ContentMainRunnerImpl::Run()
04:10:44.201 6804   #29 0x000000fbf760 content::ContentMain()
04:10:44.201 6804   #30 0x00000043ecf1 main
04:10:44.201 6804   #31 0x7f6e80c02f45 __libc_start_main
04:10:44.201 6804   #32 0x00000043ebd1 <unknown>

Original issue's description:
> Add CHECKs to ResourceLoader to investigate crashes
>
> There are crash reports that |m_resource| is broken in
> ResourceLoader::didReceiveResponse. It is strange as ResourceLoader::m_resource
> is constant after its construction. To investigate the issue, this CL adds some
> CHECKs in ResourceLoader.
>
> BUG=675947
> R=tyoshino@chromium.org
>
> Review-Url: https://codereview.chromium.org/2619513002
> Cr-Commit-Position: refs/heads/master@{#441919}
> Committed: https://chromium.googlesource.com/chromium/src/+/0ff2bff5863ccfdc069ed54794104dc126c6daf9

TBR=tyoshino@chromium.org,yhirano@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675947

Review-Url: https://codereview.chromium.org/2615993005
Cr-Commit-Position: refs/heads/master@{#441966}

BUG=677326

Review-Url: https://codereview.chromium.org/2607193002
Cr-Commit-Position: refs/heads/master@{#441965}

https://skia.googlesource.com/skia.git/+log/f80f115dd5ae..8c8cb5bfc547

$ git log f80f115dd..8c8cb5bfc --date=short --no-merges --format='%ad %ae %s'
2017-01-06 mtklein simplify by removing _d stages
2017-01-06 brianosman Revert "Revert "Hard code bicubic coefficients in the shader""

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=csmartdalton@google.com

Review-Url: https://codereview.chromium.org/2615013004
Cr-Commit-Position: refs/heads/master@{#441964}

I also removed some ifdefs that are no longer necessary and some
windows code that isn't needed.

BUG=671246
TEST=none
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2611253002
Cr-Commit-Position: refs/heads/master@{#441963}

Using an interface makes the usage of MediaImage needlessly more
complicated than needed. A dictionary should keep the feature working
roughly the same way and improve developer's ergonomics.

Spec change: https://github.com/WICG/mediasession/pull/162

BUG=676995
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2612003002
Cr-Commit-Position: refs/heads/master@{#441962}

TBR=yusufo@chromium.org
BUG=671797

Review-Url: https://codereview.chromium.org/2611163005
Cr-Commit-Position: refs/heads/master@{#441961}

Adds BeginFrameAck struct and updates the signature and callsites of
BeginFrameSource::DidFinishFrame(). This is split off from
https://codereview.chromium.org/2527283003/.

Observers will be required to use BeginFrameAcks to indicate the
result of a BeginFrame message. The acknowledgments will be used by the
DisplayScheduler to determine when all updates for a BeginFrame have
been received and trigger an early deadline.

A BeginFrame acknowledgment indicates:
1) completion of a specific BeginFrame by the observer,
2) whether or not the observer produced updates, and
3) the oldest frame that was incorporated into the last update from the
observer.

2) and 3) are in preparation for DevTool's BeginFrameControl, see
http://bit.ly/bfc-v1 and https://codereview.chromium.org/2411793008/.

Follow-up patches will add:
- correct calculation of |latest_confirmed_frame| in
  Scheduler/DisplayScheduler.
- missing DidFinishFrame() calls in observers
- integration of acks into CompositorFrame submission (to allow ack
  propagation from services / renderer compositor)
- modification of DisplayScheduler to rely on BeginFrameAcks.

BUG=646774, 401331
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2591013004
Cr-Commit-Position: refs/heads/master@{#441960}

This can be used to disable SlimmingPaintInvalidation when it is enabled
by default.

BUG=646176
TBR=achuith@chromium.org (for chrome/browser/chromeos/login/chrome_restart_request.cc)
R=pdr@chromium.org,creis@chromium.org,holte@chromium.org

Review-Url: https://codereview.chromium.org/2612323002
Cr-Commit-Position: refs/heads/master@{#441959}

The DCHECK could be triggered if sampling of results by SharedSampler on
background thread took longer than refresh cycle (1 second) and at the
same time user added or removed one of TaskManager columns handled by
SharedSampler.

This DCHECK was an errorneous assumption. I removed it and added a comment
explaining this situation.

BUG=678471

Review-Url: https://codereview.chromium.org/2612773004
Cr-Commit-Position: refs/heads/master@{#441958}

This is just an alias for --extra-tools, and all affected buildbots have
been updated to not use this flag.

BUG=none
R=danakj@chromium.org

Review-Url: https://codereview.chromium.org/2619533002
Cr-Commit-Position: refs/heads/master@{#441957}

BUG=352807
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2619493004
Cr-Commit-Position: refs/heads/master@{#441956}

Without this, the notification could get grouped with one of the other
types of Chrome notifications.

BUG=675961

Review-Url: https://codereview.chromium.org/2618733003
Cr-Commit-Position: refs/heads/master@{#441955}

BUG=660907
TEST=StyleRelatedMainThreadScrollingReasonTest.ClipPathTest;
StyleRelatedMainThreadScrollingReasonTest.ClipTest;
StyleRelatedMainThreadScrollingReasonTest.BorderRadiusTest
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2613743002
Cr-Commit-Position: refs/heads/master@{#441954}

updatePaintProperties -> prePaint
synchronizedPaint -> paint
synchronizedPaintRecursively -> paintGraphicsLayerRecursively

Review-Url: https://codereview.chromium.org/2613983002
Cr-Commit-Position: refs/heads/master@{#441953}

NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2620513002
Cr-Commit-Position: refs/heads/master@{#441952}

When the BrowserScheduler/RedirectHistoryService experiment is disabled,
HistoryService uses a dedicated thread for backend operations. This thread
is joined when the HistoryService is deleted.

When the BrowserScheduler/RedirectHistoryService experiment is enabled,
HistoryService uses a TaskScheduler sequence for backend operations.
These tasks can run after the HistoryService has been deleted.

History backend tasks access databases in the profile directory. A crash
occurs if these accesses occur after the profile directory has been deleted.
To prevent this from happening in ProfileBrowserTest.*., this CL adds code to
flush TaskScheduler before deleting the profile directory.

BUG=661143, 676714

Review-Url: https://codereview.chromium.org/2611053003
Cr-Commit-Position: refs/heads/master@{#441951}

Revert of [Android] Disable system_health.common_mobile on nexus 7 devices. (patchset #1 id:1 of https://codereview.chromium.org/2611753005/ )

Reason for revert:
Didn't fix.

Original issue's description:
> [Android] Disable system_health.common_mobile on nexus 7 devices.
>
> BUG=667470
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
>
> Review-Url: https://codereview.chromium.org/2611753005
> Cr-Commit-Position: refs/heads/master@{#441690}
> Committed: https://chromium.googlesource.com/chromium/src/+/a73420c80a6038860cc35d1d6f1498c963ba2b52

TBR=nednguyen@google.com,sullivan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=667470

Review-Url: https://codereview.chromium.org/2618013002
Cr-Commit-Position: refs/heads/master@{#441950}

We're deprecating the default constructor of Supplement.

This CL also refactors PagePopupSupplement to make the implementation
closer to other supplement implementations.

BUG=610176

Review-Url: https://codereview.chromium.org/2617113003
Cr-Commit-Position: refs/heads/master@{#441949}

BUG=NONE

Review-Url: https://codereview.chromium.org/2610103003
Cr-Commit-Position: refs/heads/master@{#441948}

This patch removes indexed_db_messages.h and makes
IndexedDBDispatcherHost no longer a BrowserMessageFilter.

Handling the special case of a channel close during a DB open operation
does not seem to be necessary as long as we ensure that the database
handle does not get stuck in a closed Mojo pipe so the logic (and test
for it) have been removed.

BUG=627484

Review-Url: https://codereview.chromium.org/2601163002
Cr-Commit-Position: refs/heads/master@{#441947}

* Delete some one-line helper functions.
* Provide some more default method implementations in class Group.

BUG=659631

Review-Url: https://codereview.chromium.org/2616953002
Cr-Commit-Position: refs/heads/master@{#441946}

ExceptionState should not be ignored in production code unless you have
a strong reason to do so. However, people have abused IGNORE_EXCEPTION
and ignored ExceptionState that should not be ignored...

To discourage further mis-usage, this CL renames IGNORE_EXCEPTION to
IGNORE_EXCEPTION_FOR_TESTING.

BUG=670619

Review-Url: https://codereview.chromium.org/2615953003
Cr-Commit-Position: refs/heads/master@{#441945}

BUG=675561

Review-Url: https://codereview.chromium.org/2618703004
Cr-Commit-Position: refs/heads/master@{#441944}

This is one of the steps to deprecate the default constructor of Supplement.

BUG=610176

Review-Url: https://codereview.chromium.org/2614143002
Cr-Commit-Position: refs/heads/master@{#441943}

BUG=674509

Review-Url: https://codereview.chromium.org/2610323003
Cr-Commit-Position: refs/heads/master@{#441942}

Continuation of cl/2615613005, updating module page_test to legacy_page_test.

BUG=678600
TBR=bustamante

Review-Url: https://codereview.chromium.org/2614123003
Cr-Commit-Position: refs/heads/master@{#441941}

No changes other than modifying includes and appropriately forward
declaring the class.

BUG=625684
TBR=girard@chromium.org, clamy@chromium.org, jochen@chromium.org

Review-Url: https://codereview.chromium.org/2590273002
Cr-Commit-Position: refs/heads/master@{#441940}

This change adds the header and the Order Summary section to the
Payment Sheet in the Payment Request dialog. Both sheets still need
many tweaks and extra features but this is the first step towards the
dialog actually looking like the design specs.

Mocks here:

https://folio.googleplex.com/chrome-ux/mocks/329-future-web-pay/latest/desktop#

A screenshot of the Payment Sheet is here:

https://drive.google.com/file/d/0B-DVbqI3huZGREpIaE5yMDZjZzA/view?usp=sharing

A screenshot of the Order Summary shown when clicking the Order Summary
row is here:

https://drive.google.com/file/d/0B-DVbqI3huZGM0F0cC1sS2xLTWs/view?usp=sharing

BUG=676112

Review-Url: https://codereview.chromium.org/2592833002
Cr-Commit-Position: refs/heads/master@{#441939}

https://skia.googlesource.com/skia.git/+log/b38db9a48db0..f80f115dd5ae

$ git log b38db9a48..f80f115dd --date=short --no-merges --format='%ad %ae %s'
2017-01-06 kjlubick Be able to fuzz a directory of input

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=csmartdalton@google.com

Review-Url: https://codereview.chromium.org/2619553002
Cr-Commit-Position: refs/heads/master@{#441938}

This reverts commit c5f4d723.

Reason for revert:
Broke Mac trunk of official.desktop.continuous builder (https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/mac%20trunk/builds/44193/steps/compile/logs/stdio)

TBR=pkasting@chromium.org,pastarmovj@chromium.org
BUG=678919

Review-Url: https://codereview.chromium.org/2618913002
Cr-Commit-Position: refs/heads/master@{#441937}

Roll material_components_ios to v19.0.0 (079c1c9a) and
material_roboto_font_loader_ios to v1.1.1 (e9b8647).

Add a workaround to allow compilation of material_roboto_font_loader_ios
until upstream fixes the incorrect #import path (see [1] for tupstream issue).

[1]: https://github.com/material-foundation/material-roboto-font-loader-ios/issues/6

BUG=673904

Review-Url: https://codereview.chromium.org/2618583004
Cr-Commit-Position: refs/heads/master@{#441936}

* Adds the first test for RecentTabsPage.
* Extracts RecentlyClosedTabManager interface from RecentlyClosedBridge to enable injection of a fake in tests.
* Deletes a bunch of one-line helper functions.
* Minor cleanups like using diamond operators and restricting visibility.

BUG=659631

Review-Url: https://codereview.chromium.org/2610143002
Cr-Commit-Position: refs/heads/master@{#441935}

The file was never added to the build and is now hopelessly out of date.
Other parts of the code exercise AutofillAddress sufficiently anyway.

BUG=672196

Review-Url: https://codereview.chromium.org/2563523002
Cr-Commit-Position: refs/heads/master@{#441934}

Chrome shouldn't be started for ARC++ Kiosk sessions.
However, if it's not started at all before "kSilentLaunch" check,
then bottom bar is shown.
Starting Chrome silently avoid it and shows only blank wallpaper until app is started.

As in future dedicated ARC++ Kiosk initialization flow with Splash Screen will be added,
the issue should pass away together with it, but we need temporary fix for M56 launch.

BUG=676185
TEST=Manual, Start ARC++ Kiosk sessions.

Review-Url: https://codereview.chromium.org/2604813002
Cr-Commit-Position: refs/heads/master@{#441933}

As ARC++ kiosk should always be running during the ARC++ kiosk session,
it make sense to restart it when there is notification that the task was closed.
However, it won't restart the app if some preconditions are not yet satisfied,
e.g. policy is not compliant, app is not ready.

BUG=676825
TEST=Manual, Run Kiosk on ARC++ device

Review-Url: https://codereview.chromium.org/2599333002
Cr-Commit-Position: refs/heads/master@{#441932}