- 16 Oct, 2019 19 commits
-
-
Chris Cunningham authored
Bug: 992235 Change-Id: I306376ffee367eab9eb96b47b7c238d73018f5b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863128Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#706245}
-
tby authored
We're unsure if there are errors stemming from one of the APIs that the DriveQuickAccessProvider implicitly relies on. This CL adds debug metrics for all operations that could error within the provider. There are a lot of metrics here, and we plan to remove them once we're confident the feature is working as intended. Bug: 1011221 Change-Id: Iea9a3ee3237de88fe30bba6705adcebd962338b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857800Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#706244}
-
Manas Verma authored
This CL ensures that fido_authentication_info is not set if it does not contain any data. Bug: 949269 Change-Id: I27ced9ba881d17c66bfc10c8467f9588ff91c091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863642Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#706243}
-
Yoichi Osato authored
This is a leftover from the patch of: "[WebSocket] Do not send response headers for failed handshake." https://chromium-review.googlesource.com/c/chromium/src/+/1847592 Change-Id: I9f18da76d3ff69ef04b1492890831a6ca2611202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860735 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#706242}
-
Peter Kasting authored
Even though the suggestion view and the keyword view take up the same space, that doesn't mean the suggestion view is guaranteed to be at least as large as the keyword view. Use the max of the two sizes. Bug: none Change-Id: Ia08506e8ce2742ce09833930572c278c2ceb9909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857652 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706241}
-
Krishna Govind authored
TBR=meacer@chromium.org Change-Id: Id2dba6d14a42857c4de7e37c24ca7ef30b5aa7a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862665 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#706240}
-
Doug Arnett authored
In order to detect potential rage click type user unhappiness with the DeferAllScript previews, we need the ClickInputBurst count metric recored to UKM so we can determine sites that should not receive the preview. Bug: 1014532 Change-Id: Ib91c1574dd04689d846ce7eebf83193d48424751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854782Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#706239}
-
Anubha Mathur authored
In the sources panel, the "More options"button should be marked with aria-haspopup="true" since the menu that opens is a popup which must be closed/escaped before the rest of the content in the page can be accessed. MAS 1.3.1 Bug: 963183 Change-Id: I20183e6d35aa85b9705763de4a4c433ae1325505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1665299Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Anubha Mathur <anubmat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706238}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a6dd74cc6ed0..821fe40443ea Created with: gclient setdep -r src-internal@821fe40443ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Id3d13335b84ad4a58600db5c0f1c6c4f005eace3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862271Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706237}
-
Sharon Yang authored
* For all fields currently available for a Fuchsia Semantic Node, convert from a Chrome AXNodeData. Testing: Added unit tests, AXTreeConverterTest. Bug: 973095 Change-Id: I95b899f1bdd9a516067483ed441cfe098fd6e5a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1832822 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#706236}
-
Tetsui Ohkubo authored
In ARC, activation of a window is mapped to activity stacking. Notifications, which are not activities, are always placed at the top of windows. When an inline notification and an activity with an input field are shown at the same time, it causes an issue because regardless of the activity having focus, the notification always receives keyboard input. In order to fix that, we have to forward ash side activation through mojo and reflect it to the NOT_FOCUSABLE flag of notifications. A Tast test for this will be added. Android side CL: http://ag/9537575 TEST=manual (Follow the repro steps in the bug.) BUG=b:142103828 Change-Id: Ifda5532b498ef9ea01ee70836813ae700a6ec58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855545Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#706235}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b7c5bac9da28..20c626aa2358 git log b7c5bac9da28..20c626aa2358 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 senorblanco@chromium.org Update Dawn backend to ToT. This is about 3 months of changes. 2019-10-15 egdaniel@google.com Remove use of GrColorType as in param in SimpleTextureEffect.fp to just constructor param. Created with: gclient setdep -r src/third_party/skia@20c626aa2358 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: I35d7bfb335459364bfa5fa9fc8cf29e9b3283cde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862270Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706234}
-
Wenbin Zhang authored
DO NOT REVERT THIS CHANGE. This change may cause discontinuities in perf results by changing which bot stories are run on. It does not make any changes to Chrome itself. More info in the following post on perf sheriff group: https://groups.google.com/a/chromium.org/forum/#!topic/perf-sheriffs/IQFj65XeslM The current shard map and the timing data have been 6 months old. In order to have a better optimized shard map, we need to refresh the timing data and re-generate the shard map. Timing data and shard map are refreshed by running the following script: /src/tools/perf/generate_perf_sharding Currently we have 18 shard maps to update and only 17 of them are updated in this CL. The other one android-nexus5x-perf was updated in an earlier CL together with the shard size change in: https://chromium-review.googlesource.com/c/chromium/src/+/1862995 Bug: chromium:1013767 Change-Id: Idcc0e07cef67e989e34a0bc88e62771149b1bc15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861000 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#706233}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a37797f5. With Chromium commits locally applied on WPT: 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/IndexedDB NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I5a8f1e303f2276b66f008f1cf7151c6102e9b919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863436Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706232}
-
Luum Habtemariam authored
Now CupsProxyService correctly updates CupsPrintersManager when it successfully installs a printer into CUPS. Since any print job involves many IPP requests, each of which could trigger a printer install, this caching debug daemon calls. Bug: chromium:945409 Test: updated unit_tests pass Change-Id: I4d0cba3e5cbe35c5acd2a78fc5a94ff73da5cf1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863729Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#706231}
-
Steven Bennetts authored
Bug: 1014671 Change-Id: Ia84e5de9664859c0f5ba53ad0b32e13ffc761451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863733Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#706230}
-
Alex Newcomer authored
AppListControllerImpl::OnDisplayConfigurationChanged is called when the screen rotates. We recently refactored some visibility functions, this caused the bug. We should check presenters visibility, not the target visibility. Bug: 1012432 Change-Id: I2033484115de22f72fac997258c4013872e2d784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861154 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706229}
-
John Emau authored
Marking the checkbox container as a group role and labeling it meets the following WAI WCAG 2.1 success criteria and allows for screen readers to announce the group label when focusing on a checkbox. 1.3.1 Info and Relationships - Level A https://www.w3.org/WAI/WCAG21/quickref/#info-and-relationships 3.3.2 - Labels or Instructions - Level A https://www.w3.org/WAI/WCAG21/quickref/#labels-or-instructions Screenshot (NVDA Speech Viewer): https://i.imgur.com/ptmRGzu.png Screenshot (Accessibility Tree): https://i.imgur.com/EUTyhTV.png Bug: 963183 Change-Id: Ia801a9a74ca897b6bc94705d72109bd231b00653 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695853Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706228}
-
Andrey Kosyakov authored
Bug: 859382 Change-Id: I42dcd7219cb0dba659f201d022444265a6a4b183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864012Reviewed-by:
Peter Kvitek <kvitekp@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#706227}
-
- 15 Oct, 2019 21 commits
-
-
John Emau authored
Previously the accessible name for the audio context selector was 'BaseAudioContext'. With this change the accessible name becomes `Audio context: ${content title}` and if no context is selected: `Audio context: (no recording)`. This is a much better experience for screen reader users and meets success criteria for WCAG 2.5.3 Label in Name https://www.w3.org/WAI/WCAG21/quickref/#label-in-name Test page: https://mdn.github.io/webaudio-examples/audiocontext-states/ Screenshot (NVDA Speech Viewer): https://i.imgur.com/m5pKYnx.png (NOTE: This screenshot was taken with https://crrev.com/c/1626643 applied to better screen reader support) Screenshot (Accessibility Tree): https://i.imgur.com/e04n8m9.png Bug: 963183 Change-Id: I89e14599313766e7bd2be8a6a953df28c648dbe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711008Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706226}
-
Ahmed Mehfooz authored
Change-Id: Id28394f3d11e190c58b05e37dbdfbef34d95a7d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862857 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#706225}
-
Daniel Rubery authored
This CL allows the user to select "open now" to open a download, while the deep scanning is still pending. This is important for enterprises which don't want the large increase in user friction caused by blocking access to the file. New UI screenshots: https://screenshot.googleplex.com/xwXViHi2u3R.png https://screenshot.googleplex.com/RE102LjRAA2.png Mocks: https://docs.google.com/presentation/d/1MH7zM5YiuCZr3jYsqkTJRC0cqtdo8wuWZOOQ66jptVk/edit#slide=id.g5d9bcde872_0_0 Bug: 980777 Change-Id: I8a2e6844ff5ab68c4faa3e75a0e4eed2064a3be1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848357 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#706224}
-
Peng Huang authored
Bug: 1012878 Change-Id: I9c4c887d9fb5465d38da1cabbe1b52437235f948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863468Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#706223}
-
Nate Fischer authored
This is a roll using my internal change to the exporter script (http://cl/274893271). The main motivation is to roll the change to the BUILD.gn file (to get the proto_java_library target), although this also rolls miscellaneous proto changes which have landed since the last roll. Bug: 1011991 Test: None Change-Id: Ibcbe003f0c386bd2081944c77ecc26a3cd88d559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862727 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#706222}
-
Greg Kerr authored
As the macOS GPU sandbox now allows LaunchServices connections, remove the API call telling it not to connect to LS. Bug: 871280 Change-Id: Ic70da6796b6980c60c2e9ebdd897ccd4f588ea9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863630 Auto-Submit: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#706221}
-
Joel Hockey authored
Use the attached browser CreateParams rather than BrowserList GetLastActive. It feels safer that the attached browser will always be the one that we want whereas BrowserList GetLastActive may not be so reliable. Bug: 1012169 Change-Id: Ifbbc13aa797db7942f5ce1d52decdac264c5d927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862875 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#706220}
-
Robert Sesek authored
With the Service Manager going away, the manifest files that previously mediated access to Mojo services across processes are going away too. Under the new system, various //content classes have methods that bind mojo::Receiver<T> objects via GenericPendingReceiver. Since these call sites control access to objects across a privilege boundary, they should be under the SECURITY_OWNERS review system. This first pass splits out several //content and //chrome ones, but more to come. Bug: 1012033 Change-Id: Ic09c825c8503c570393fa7ce4d89b58bb6efe391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848416 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#706219}
-
David Van Cleve authored
This patch is one of a series of changes adding support for resolving ESNI DNS responses [1] to the built-in resolver. It contains - a new RecordRdata subclass representing an ESNI record - relevant parsing logic for ESNI-type RDATA - unit tests exercising this parsing logic A follow-up CL will contain additions to HostResolverManager and HostCache to handle parsed records of the new type and propagate the results up the callstack. [1]: https://tools.ietf.org/html/draft-ietf-tls-esni-04 R=ericorth Bug: 1003494 Test: Added unit tests to record_rdata_unittest.cc Change-Id: Ib4446b46b19633fba92a8d14d34cf2f38ed14d1d Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845793 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#706218}
-
Peter Kasting authored
Invalidate() is called more frequently (e.g. on color changes), while SetMatch() is called only when the match actually changes. So anything that is tied to the match's content (e.g. the suggestion or keyword contents/description) can be updated in SetMatch() instead of Invalidate() to save work without visible change. Also tweaks Layout() to check the keyword view's visibility instead of the underlying state that controls it. Bug: none Change-Id: Ia0b7ca2566a621ad9315e54313f584c21f999668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857649Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#706217}
-
John Budorick authored
This reverts commit 2fcffb28. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1014742 Original change's description: > Record latency for Impl thread in case of no begin main frame. > > This CL reports the latency in case of no begin main frame. > This can happen in any of the scenarios below: > > 1) WillBeginImplFrame -> DidFinishImplFrame -> DidSubmitCompositorFrame > > 2) WillBeginImplFrame -> WillBeginMainFrame -> BeginMainFrameAborted -> > DidFinishImplFrame -> DidSubmitCompositorFrame > > 3) WillBeginImplFrame -> WillBeginMainFrame -> DidFinishImplFrame -> > BeginMainFrameAborted -> DidSubmitCompositorFrame > > In these cases there will be no latency to report for stages of: > - SendBeginMainFrameToCommit > - Commit > - EndCommitToActivation > But the latency will be reported for the remaining stages. > > Bug: chromium:1003038 > Change-Id: Id0d6a65603b2b15a0ee04a6974a4bd0b2a5a803b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799026 > Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705964} TBR=sadrul@chromium.org,behdadb@chromium.org Change-Id: Ide47f697ba94bdaf4b89564272afe1d7634296c8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1003038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863840Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#706216}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f18342d8..65084e6f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic501f15c5258d482064f35e802a2e5281b5e6055 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863435Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706215}
-
Jimmy Gong authored
- Introduces a Show more button that expands the printer list and shows the complete printer list. - With this change, we only show the first 3 saved printers while the rest are hidden beneath a "Show more" button. - Adds browser test to test all corner cases with the list behavior. Bug:993822 Test: end to end manual, browsertest Change-Id: Ia2128482b02ce759fa94cf9345473664b37877bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808079 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#706214}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0fba1fdff325..9c927784e714 git log 0fba1fdff325..9c927784e714 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 vapier@chromium.org gconv_strip: port to python3 & new ahocorasick module Created with: gclient setdep -r src/third_party/chromite@9c927784e714 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I371aeeea792bbba704798fe6ae979ee6d3abbb63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862264Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706213}
-
Haiyang Pan authored
Currently the builder test-n-tablet has flaky test failure due to timeout in apk installation. Adding logging to see which apk spent the most time. This CL can be reverted after the issue 1004322 is resolved Bug: 1004322 Change-Id: Ic51694add3666aa0e0442cb6f8c11131e04ae13d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859904Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#706212}
-
John Emau authored
This change expands existing screen reader capabilities of the quick open dialog by replacing the use of aria alert with standard ARIA attributes: role=combobox/listbox/option, aria-activedescendant, and aria-autocomplete. The effect is the screen reader announces the selected options and their position in the results, giving the user the total result count. This change follows the WAI ARIA guidance: https://www.w3.org/TR/wai-aria-1.1/#aria-autocomplete Screenshot (NVDA Speech Viewer): https://i.imgur.com/4vJkHfq.png Bug: 963183 Change-Id: I5c3b1b1f80c0a11defdfd66a4b6860df75e5e717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1737872Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#706211}
-
Avery Musbach authored
When the MultiDisplayOverviewAndSplitView feature flag is enabled, every root window controller shall own a split view controller. Note: Code that ends clamshell split view generally shall do so just by ending overview, with no opportunity to specify a SplitViewController::EndReason like kPipExpanded. As kPipExpanded behaves no differently from kNormal anyway, the present CL simply removes kPipExpanded. Test: ash_unittests SplitViewOverviewSessionInClamshellTestMultiDisplayOnly.* Bug: 970013 Change-Id: I2fba66bd2bdd006908bbd1ec023a9bb87e3e57ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856869Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#706210}
-
Torne (Richard Coles) authored
This method (now) just wraps ContextUtils.activityFromContext and adds a trace, but it's not used consistently. The trace was added to diagnose performance issues caused by class verification failures, but we should have this under control now. Change-Id: I2415cd99f0e9f337956888918388d36aaf6d05af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862729 Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#706209}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I4615c7b252f1dca946dfd35bb93a837bb0d5f0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862263Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706208}
-
Johann authored
Removing these caused build errors because assembly files don't properly depend on header files. Change-Id: I00f4b7a47a8965ea7261a415230d19146f0940b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862726 Auto-Submit: Johann Koenig <johannkoenig@google.com> Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#706207}
-
Parastoo Geranmayeh authored
GeolocationBrowserTest.PromptForOffTheRecord TBR=benwells@chromium.org Bug: 1014506 Change-Id: Ia9e5f5ae9554ab4d49dfa981f6decaa7a1c29c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863031 Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Reviewed-by:
Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#706206}
-