- 28 Feb, 2019 40 commits
-
-
Wei-Yin Chen (陳威尹) authored
Bug: 930970 Change-Id: I46e78e8639ce34f51afeeecafbaf4d1062e08bd3 Reviewed-on: https://chromium-review.googlesource.com/c/1492365Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#636266}
-
Aga Wronska authored
Bug: 911326 Test: ParentAccessViewTest Change-Id: I1be9fe83b2902a8895cc5af87b51d675e8711166 Reviewed-on: https://chromium-review.googlesource.com/c/1471494 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#636265}
-
Darwin Huang authored
Minor maintenance change. sqlite 3.27.2 update changes: https://www.sqlite.org/releaselog/3_27_2.html Bug: 936195 Change-Id: I99a5ad5c4b8d7d8fb1d8fe80b1a968c2200ba94b Reviewed-on: https://chromium-review.googlesource.com/c/1492782Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636264}
-
Nate Fischer authored
These tests already work with the NetworkService enabled. The confusion was because the test was previously broken (and a chromium change exposed this), but the test has since been fixed (http://aosp/878513). I ran these tests on an up-to-date copy of Android master to verify. Bug: 933814 Test: build/android/adb_system_webview_command_line --enable-features=NetworkService,NetworkServiceInProcess Test: cd /path/to/android/master/ Test: atest CtsWebkitTestCases:WebViewSslTest#testSecureServerRequiringClientCertDoesCancelRequest Test: atest CtsWebkitTestCases:WebViewSslTest#testSecureServerRequestingClientCertDoesNotCancelRequest Change-Id: Icfc11d9e164e05e4a2dafcb99206cb340cce336a Reviewed-on: https://chromium-review.googlesource.com/c/1487956Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#636263}
-
Bo Liu authored
* Only enable window wide gamut on Q+ * Add code to allow embedder to enable the window wide color gamut check which affects raster. * Add code to actually use P3 color space when enabled and acitivty is wide color gamut. * Add a webview feature to enable the control for webview. Bug: 924588 Change-Id: I02f18457d6e8240438d9f80cc30b639953b9d23d Reviewed-on: https://chromium-review.googlesource.com/c/1489852Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#636262}
-
Xiaohui Chen authored
Bug: b:126587141 Test: locally build and run. See dir removed when disabled. Change-Id: Ic67d30d9a786078e90aac67447cec0b5e8187f6f Reviewed-on: https://chromium-review.googlesource.com/c/1492050Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#636261}
-
Scott Violet authored
Without this the WebContents thinks it's visible, which results in a bunch of stuff happening that shouldn't. BUG=936488 TEST=none Change-Id: Ie5b1aee8d4b9c71566a37d9fdc8e51718ddf516d Reviewed-on: https://chromium-review.googlesource.com/c/1492293Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#636260}
-
Robert Sesek authored
Bug: 932175 Change-Id: I3b60a4338ff0cf31eea7b1aed8c8364c85fda79c Reviewed-on: https://chromium-review.googlesource.com/c/1492093Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#636259}
-
Giovanni Ortuño Urquidi authored
Renames InstallWebAppOrShortcutFromWebContents to Install. We chose InstallWebAppOrShortcutFromWebContents because there used to be a difference between a WebApp and Shortcut. Since both are currently the same and we have no plans to make them different, the naming no longer makes sense. Bug: 877898 Change-Id: I8173d9616351e4c641ba463b8e6de91be97aa513 Reviewed-on: https://chromium-review.googlesource.com/c/1493331Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#636258}
-
Eliot Courtney authored
This records various individual Picture-in-picture metrics for ChromeOS. Bug: b/121299293 Test: chrome://histograms - triggered each type of count Test: unit test Change-Id: I397bd5f2d7a17718bf10c1839492610a2eb88cdb Reviewed-on: https://chromium-review.googlesource.com/c/1457811Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mitsuru Oshima (Slow) <oshima@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#636257}
-
Garrett Beaty authored
telemetry_unittests and telemetry_perf_unittests are consistently failing on Mac10.10 Tests and Mac10.11 Tests. Due to a bug in recipes code, the failures are not causing the builds to fail, so they are consuming resources and not producing any useful signal. Bug: 936540 Change-Id: I49c0cebcc3cf1963c0e2776975ea82b6aa0b0640 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1493153 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#636256}
-
Madeleine Barowsky authored
Contrib benchmarks are those that are not supported on the Chrome perf waterfall but can be manually run by users. This change includes them in the results of list_benchmarks if the --include-contrib option is supplied. Change-Id: Ie09c16888e3bb276dd1f2a9dfe421cf2fbd0e7aa Reviewed-on: https://chromium-review.googlesource.com/c/1491854Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#636255}
-
Maggie Chen authored
We will only do the optimization for the root render pass. If it's not root, the overlay damage rect should be added first. This way it has a better chance to be carved out, just the way it was before the optimization CL. Bug:868561 Change-Id: I930307cb12ae3bd4fffd79a6311635e501ee1699 Reviewed-on: https://chromium-review.googlesource.com/c/1488037 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#636254}
-
David Tseng authored
Bug: 639322 Change-Id: I9443dab4aeaeef75e722bba8d3835f00406a3c65 Reviewed-on: https://chromium-review.googlesource.com/c/1481570 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#636253}
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectible Blink objects with Oilpan or PartitionAlloc. However, some classes of //blink/renderer/platform/bindings have not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of RuntimeCallCounter, RuntimeCallTimer, and RuntimeCallStats classes, it makes sense to use USING_FAST_MALLOC because it has been used with smart pointers. In ParkableString and MarkingDequeItem classes case, it makes sense to use DISALLOW_NEW because it's used by a member variable as a reference type. Lastly, the rest of platform/bindings make sense to use STACK_ALLOCATED() because they have been used by function inside. Bug: 919389 Change-Id: Idbd7b45195c30ac542e18d426da50cf76ef2a25b Reviewed-on: https://chromium-review.googlesource.com/c/1491166Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#636252}
-
Marijn Kruisselbrink authored
This is to avoid accidentally ending up with multiple references to the same underlying ArrayBuffer. The extra performance overhead of this is minimal as usage of partial results is very rare anyway (as can be seen on https://www.chromestatus.com/metrics/feature/timeline/popularity/2158). Bug: 936448 Change-Id: Icd1081adc1c889829fe7fa4af9cf4440097e8854 Reviewed-on: https://chromium-review.googlesource.com/c/1492873 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#636251}
-
Robbie McElrath authored
UpdateAdditionalCertificates assumes the CertVerifierWithTrustAnchors will be non-null, which isn't the case in tests that set up a ChromeMockCertVerifier. Bug: 920038 Change-Id: I5f4322553ab36bf960c26331c6440bf5dbb3f85a Reviewed-on: https://chromium-review.googlesource.com/c/1492757Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/009696c56169..aaa17b8528d8 git log 009696c56169..aaa17b8528d8 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 ynovikov@chromium.org Restrict OpenGL/Vulkan test window re-creation workaround to NVIDIA Created with: gclient setdep -r src/third_party/angle@aaa17b8528d8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Id8d592ece0e359157fa78e0576950a03664a992b Reviewed-on: https://chromium-review.googlesource.com/c/1492831Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#636249}
-
Jun Mukai authored
When custom frame is used for a widget, the "client area" shouldn't be sent based on the client-area, otherwise the located event on the frame will be handled incorrectly. With this CL, DesktopWindowTreeHostMus checks remove_standard_frame of Widget::InitParams and adopts that behavior, thus dialogs of using custom frame and bubbles will not send client area anymore. This property is already used in BrowserFrameMash, so set_auto_update_client_area method is now gone. Bug: 935338 Test: manually Change-Id: I285954a53fea3f9f32d2fc24847cd869e5d5f939 Reviewed-on: https://chromium-review.googlesource.com/c/1488179 Auto-Submit: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#636248}
-
Gyuyoung Kim authored
As the plan to replace UseCounter::Count(const LocalFrame*) with UseCounter::Count(const Document& or ExecutionContext* or DocumentLoader*), this CL replaces all uses of UseCounter::Count(const LocalFrame*) with UseCounter::Count(const Document&). Bug: 936187 Change-Id: Ic1b47ac3550a494c8aad20db7d624ee6199beab7 Reviewed-on: https://chromium-review.googlesource.com/c/1491064Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/105fd0f651d1..83fc5445e748 git log 105fd0f651d1..83fc5445e748 --date=short --no-merges --format='%ad %ae %s' 2019-02-27 chrisforbes@google.com Add support for OpVectorShuffle 2019-02-27 chrisforbes@google.com Add support for OpCompositeExtract 2019-02-27 chrisforbes@google.com Add support for OpCompositeInsert 2019-02-27 chrisforbes@google.com Add complex type walker for literal indexes 2019-02-27 chrisforbes@google.com Add support for OpCompositeConstruct 2019-02-27 chrisforbes@google.com Add GenericValue wrapper for either an Intermediate or a constant 2019-02-27 senorblanco@chromium.org Fix push & pop of XMM registers. Created with: gclient setdep -r src/third_party/swiftshader@83fc5445e748 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126472836,chromium:b/126475423,chromium:b/126475423,chromium:b/126475423,chromium:b/126475423,chromium:b/126475489 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I333643c6b4463e3c7dee2fc73d0ebd0fbe6c2417 Reviewed-on: https://chromium-review.googlesource.com/c/1493191Reviewed-by:
-
Gyuyoung Kim authored
According to the plan to replace |const LocalFrame*| arguement with |const Document&|, |ExecutionContext*|, or |DocumentLoader*| in UseCounter::Count(), this CL replaces all uses of UseCounter::Count(const LocalFrame*) with UseCounter::Count(const Document&). Bug: 936187 Change-Id: I1de30af5d728b1c1119f7d0a75caac35596f1168 Reviewed-on: https://chromium-review.googlesource.com/c/1490370Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Tom Tan authored
ARM64 Chromium build starts to complain (see below) the extra semicolon after inline member function definition. The extra semicolon was there in the initial arm64 support of Chromium sandbox. Seems it is exposed by option -Wextra-semi which was just enabled in Chromium in https://crrev.com/c/1489102 for Windows. ../../sandbox/win/src/resolver_64.cc(57,4): error: extra ';' after member function definition [-Werror,-Wextra-semi] }; ^ 1 error generated. TBR=wfh Bug: 893460 Change-Id: I31a9996cad8739a00b5ba1a2ab35b40feb792e79 Reviewed-on: https://chromium-review.googlesource.com/c/1493158Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#636244}
-
Satoshi Niwa authored
Bug: b:123362537 Test: check that translated string is shown in Android file picker Change-Id: I0075fe0ccf6121401170ebafa88a754c8e242689 Reviewed-on: https://chromium-review.googlesource.com/c/1490368Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#636243}
-
Gayane Petrosyan authored
Bug: 935260 Change-Id: Iad79fdf7da3ddfdb1c746c80f9636ac752d1cbbe Reviewed-on: https://chromium-review.googlesource.com/c/1490113Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#636242}
-
Ryan Sturm authored
This CL supports the pingback for HTTPS Server Previews URLLoader implementation. During committed preview decision time, if we are serving a lite page, the ServerLitePageInfo is backfilled from the navigation handle. This does not support reporting on failures. Bug: 921757,936496 Change-Id: Ic474e0d1bd49f6a181704edcfe24e5f1025d6089 Reviewed-on: https://chromium-review.googlesource.com/c/1487916 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#636241}
-
John Abd-El-Malek authored
This fixes onResponseStarted, onBeforeRedirect, onCompleted and onAuthRequired. Bug: 935104 Change-Id: Id545fcd4ffb82f1e73d22ad67441b379c3fe31be Reviewed-on: https://chromium-review.googlesource.com/c/1488444 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#636240}
-
Istiaque Ahmed authored
For running PendingTasks for a particular ContextId through SWTQ::AddPendingTask(), call StartWorker* exactly once instead of calling it each time for each AddPendingTask call. This has two advantages: - We don't call StartWorker* more than once when we don't need to. - Extension messaging subtly depends on running these tasks once. This is because how LazyBackgroundTaskQueue behaves in terms of multiple pending tasks and we need some sort of parity in SWTQ for future worker messaging implementation. Detailed changes: - ServiceWorkerTaskQueue: Remove the queue for registration (old |pending_tasks_|) and worker start (|waiting_did_start_worker_tasks_|) and merge them to a single queue (|pending_tasks_). Run these tasks once registration, service worker start (DidStartWorkerForScope) and service worker loadstop (DidStartServiceWorkerContext) completes. - IPC: Add thread_id and SW scope to DidStartServiceWorkerContext IPC (loadstop), as PendingTasks that were pending after DidStartWorkerForScope but before the SW context has seen loadstop can use these thread_id and scope to build LazyContextTaskQueue::ContextInfo to run those tasks. Previously we used to remember these two pieces of information in WaitingDidStartWorkerTask. This also simplifies the queue in SWTQ. - IPC: Add thread_id and SW scope to DidStopServiceWorkerContext IPC to clean up the task containers on worker shutdown. This will also be necessary for multiple worker support within extension in future. Bug: 925927 Test: Service worker within extension internal change, no visible effect. Change-Id: I06581f821550154ebca3ee6d9aa803953abf7d86 Reviewed-on: https://chromium-review.googlesource.com/c/1481580Reviewed-by:Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
This test has been migrated to our integration tests on CL:1485623. Bug: 924873 Change-Id: I970429152749565db52aedae14274633a8518bbe Reviewed-on: https://chromium-review.googlesource.com/c/1493332 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#636238}
-
Noel Gordon authored
./tests.sh compares the extracted images in test, by hash, to expected image hash values read from a golden file. Add the golden file. Bug: 935285 Change-Id: I85cd2bbaced10a02db82c5dff5c7f8afc7754835 Reviewed-on: https://chromium-review.googlesource.com/c/1491735Reviewed-by:
-
wutao authored
|kDeepLink| will open embedded UI but we have not defined the UX to show the Web UI. Current guard will not prevent this happens. This patch modify the guard to eary return when the embedded assistant UI is enabled. Bug: 924624 Test: manual Change-Id: Idb44231cd66b07d85c6c400d4b2c152813b227ce Reviewed-on: https://chromium-review.googlesource.com/c/1487515Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#636236}
-
Joel Einbinder authored
Bug: 935942 Change-Id: Ie9e5c340b5b036a7fb9588b1e0c6518478f6317f Reviewed-on: https://chromium-review.googlesource.com/c/1492932Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#636235}
-
Antonio Gomes authored
Apart from start making use of the always-true downcast helper, in order to ensure that WebFrameWidget is always a WebFrameWidgetBase intance (and hence respecting the downcast helper contract), this CL also adds a private WebFrameWidget ctor, and make it a friend-class to WebFrameWidgetBase. This ensures that WebFrameWidgetBase is the only concrete subclass that implements WebFrameWidget. R=jbroman@chromium.org CC=blink-reviews-vendor@chromium.org BUG=891908 Change-Id: Ibdea5aea0fcb538b15a12a7cfc00691249ef2099 Reviewed-on: https://chromium-review.googlesource.com/c/1490291 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
Yun Liu authored
https://cs.chromium.org/chromium/src/base/android/java/src/org/chromium/base/metrics/RecordUserAction.java?q=RecordUserAction&g=0&l=26-27 It seems we need to reset the value to avoid carrying over state to unrelated tests after test is done. Moved them to DummyUiActivityTestCase to set and reset them by default. Bug: 728297, 908174 Change-Id: If9462012a967933e927b5e0987944d03110bab5f Reviewed-on: https://chromium-review.googlesource.com/c/1492368 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#636233}
-
Zhenyao Mo authored
So we could do "bisecting" and pin-point which experiment/feature triggers a specific chrome behavior (say, a regression, a bug). BUG=895142, 932197 TEST=unittest R=mpearson@chromium.org Change-Id: I2c76d73c72f093c8d884cc088495a04066e10687 Reviewed-on: https://chromium-review.googlesource.com/c/1335272 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#636232}
-
Ryan Sturm authored
This adds an about://flag entry for the new way of loading an HTTPS server preview using the network service. Bug: 921736 Change-Id: Ib9c419abdcc09d1700a98854d7e3863f7b4edbc0 Reviewed-on: https://chromium-review.googlesource.com/c/1490442Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
chrome://policyYann Dago authored
Bug: 933797 Change-Id: I01360af1e9800f023c9db3294d0a30475b17568b Reviewed-on: https://chromium-review.googlesource.com/c/1487513 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#636230}
-
Julie Jeongeun Kim authored
This CL moves files from platform/plugins to core/page as these files are only used in core and modules. It also moves scoped_fake_plugin_registry.cc/h to core/testing as it's used only in core. Bug: 936133 Change-Id: I88a2caa8483eb39b16b25e8f983499f378b8c4a8 Reviewed-on: https://chromium-review.googlesource.com/c/1491237 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
NextLinePosition moves caret to the end of |root_element| if all previous attempts fail. However, it uses a mutable variable |node| for the search that can be modified and no longer points to the start node, which results in a wrong |root_element|. This patch uses the initial value of |node| for the search to fix the issue. Note: The modification to |node| is due to an error in a previous refactoring. See crrev.com/bf5e3888 Bug: 906148 Change-Id: Ia27d9a38da5521492057507153e0de0f12a1510e Reviewed-on: https://chromium-review.googlesource.com/c/1492732Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#636228}
-
Scott Graham authored
--product=product/sdk_image.gni is required by fx build now. Change-Id: Ib91f211551bed08b7ff635ee0787c7ca2bf8dc8e Reviewed-on: https://chromium-review.googlesource.com/c/1493087 Commit-Queue: Scott Graham <scottmg@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#636227}
-
