1. 19 Aug, 2011 3 commits
  2. 18 Aug, 2011 37 commits
    • fsamuel@chromium.org's avatar
      Added Frame Set Scaling Test Results for WebKit1 Mac and WebKit2 Mac · 66437542
      fsamuel@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66493
      
      The expected results of the layout tests written for
      https://bugs.webkit.org/show_bug.cgi?id=57785
      differ between WebKitt Mac and WebKit2 Mac.
      
      WebKit2 Mac matches the cross-platform results.
      WebKit1 Mac has a special set of test results.
      
      Reviewed by Tony Chang.
      
      * platform/chromium/fast/frames/frame-set-scaling-3d-expected.png: Added.
      * platform/chromium/fast/frames/frame-set-scaling-3d-expected.txt: Added.
      * platform/chromium/fast/frames/frame-set-scaling-centered-expected.png: Added.
      * platform/chromium/fast/frames/frame-set-scaling-centered-expected.txt: Added.
      * platform/chromium/fast/frames/frame-set-scaling-expected.png: Added.
      * platform/chromium/fast/frames/frame-set-scaling-expected.txt: Added.
      * platform/chromium/fast/frames/frame-set-scaling-rotate-expected.png: Added.
      * platform/chromium/fast/frames/frame-set-scaling-rotate-expected.txt: Added.
      * platform/chromium/fast/frames/frame-set-scaling-skew-expected.png: Added.
      * platform/chromium/fast/frames/frame-set-scaling-skew-expected.txt: Added.
      * platform/mac-wk2/fast/frames/frame-set-scaling-3d-expected.png: Added.
      * platform/mac-wk2/fast/frames/frame-set-scaling-centered-expected.png: Added.
      * platform/mac-wk2/fast/frames/frame-set-scaling-expected.png: Added.
      * platform/mac-wk2/fast/frames/frame-set-scaling-rotate-expected.png: Added.
      * platform/mac-wk2/fast/frames/frame-set-scaling-skew-expected.png: Added.
      * platform/mac/fast/frames/frame-set-scaling-3d-expected.png: Added.
      * platform/mac/fast/frames/frame-set-scaling-centered-expected.png: Added.
      * platform/mac/fast/frames/frame-set-scaling-expected.png: Added.
      * platform/mac/fast/frames/frame-set-scaling-rotate-expected.png: Added.
      * platform/mac/fast/frames/frame-set-scaling-skew-expected.png: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93371 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      66437542
    • tony@chromium.org's avatar
      [chromium] Mark editing/selection/regional-indicators.html as timing · 3f1148e1
      tony@chromium.org authored
      out on Linux debug and rebaseline 2 tests.
      
      * platform/chromium-win/fast/frames/frame-set-scaling-rotate-expected.png: Added.
      * platform/chromium-win/fast/frames/frame-set-scaling-skew-expected.png: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93370 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3f1148e1
    • rniwa@webkit.org's avatar
      positionForPoint returns wrong VisiblePosition at bidi boundaries · 594cc6ed
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65356
      
      Reviewed by David Hyatt.
      
      Source/WebCore: 
      
      The bug was caused by RenderText::positionForPoint's assuming that the position will always reside
      inside the inline box that contains the point, which is not true at the boundaries of bidi-runs.
      
      For example, in aDC12BAb where AB12CD is a RTL text, the offset on the right of A is 7 even though
      the inline box for "BA" only contains offsets 1, 2, and 3. We must traverse the bidi-run "DC12BA"
      until the end to obtain the offset 7 from the inline box for "DC".
      
      Fixed the bug by introducing createVisiblePositionAfterAdjustingOffsetForBiDi which traverses runs
      on the left or the right of the position to compute the appropriate offset following the NSTextView convention.
      
      This patch also fixes a regression from r74971 that caret is placed incorrectly between inline boxes of
      LTR or RTL text in a RTL or LTR block respectively.
      
      Test: editing/selection/caret-at-bidi-boundary.html
      
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::offsetForPosition):
      * rendering/RenderText.cpp:
      (WebCore::lineDirectionPointFitsInBox): Takes ShouldAffinityBeDownstream instead of EAfinity.
      (WebCore::createVisiblePositionForBox):
      (WebCore::createVisiblePositionAfterAdjustingOffsetForBiDi):
      (WebCore::RenderText::positionForPoint):
      
      LayoutTests: 
      
      * editing/selection/caret-at-bidi-boundary-expected.txt: Added.
      * editing/selection/caret-at-bidi-boundary.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93369 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      594cc6ed
    • xji@chromium.org's avatar
      --webkit-visual-word renaming right/leftWordPositionAcrossBoundary · 01d748d0
      xji@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66436
      
      Reviewed by Ryosuke Niwa.
      
      Rename them to right/leftWordPositionIgnoringEditingBoundary.
      
      * editing/visible_units.cpp:
      (WebCore::leftWordPositionIgnoringEditingBoundary):
      (WebCore::rightWordPositionIgnoringEditingBoundary):
      (WebCore::leftWordPosition):
      (WebCore::rightWordPosition):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93368 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      01d748d0
    • crogers@google.com's avatar
      Implement WebMediaPlayerClientImpl::audioSourceProvider() and interface into chromium · 5189b4c7
      crogers@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66441
      
      Reviewed by Darin Fisher.
      
      * public/WebAudioSourceProvider.h: Added.
      (WebKit::WebAudioSourceProvider::~WebAudioSourceProvider):
      * public/WebMediaPlayer.h:
      (WebKit::WebMediaPlayer::audioSourceProvider):
      * src/WebMediaPlayerClientImpl.cpp:
      (WebKit::WebMediaPlayerClientImpl::audioSourceProvider):
      (WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::provideInput):
      * src/WebMediaPlayerClientImpl.h:
      (WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::AudioSourceProviderImpl):
      (WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::~AudioSourceProviderImpl):
      (WebKit::WebMediaPlayerClientImpl::AudioSourceProviderImpl::initialize):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93367 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5189b4c7
    • jeffm@apple.com's avatar
      Soft link against AVFoundationCF and CoreMedia · 0829d2de
      jeffm@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65725
              
      Add new macros to SoftLinking.h to support soft-linking to functions and variables decorated with __declspec(dllimport),
      and use them to soft-link to AVFoundationCF and CoreMedia. I verified that the WebProcess doesn't load these DLLs
      until a media element is used.
      
      Reviewed by Eric Carlson.
      
      No new tests as no change in functionality.
      
      * WebCore.vcproj/WebCore.vcproj: Added AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.
      * WebCore.vcproj/WebCoreMediaQT.vsprops: Removed DelayLoadDLLs linker option which is no longer needed.
      * platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Added.
      * platform/graphics/avfoundation/cf/CoreMediaSoftLinking.h: Added.
      * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Stop linking against AVFoundationCF.lib and CoreMedia.lib and include AVFoundationCFSoftLinking.h and CoreMediaSoftLinking.h.
      * platform/win/SoftLinking.h: Added SOFT_LINK_DLL_IMPORT() and SOFT_LINK_VARIABLE_DLL_IMPORT() macros.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93363 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0829d2de
    • commit-queue@webkit.org's avatar
      Chromium Mac: Show scrollbar when doing search · 41584597
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66209
      
      Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-18
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Updated the Lion scrollbar drawing code to force the scrollbar to be visible when we have tickmarks for search results.
      
      No tests because there are no Mac 10.7 chromium bots yet.
      
      * platform/chromium/ScrollbarThemeChromiumMac.h:
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::paint):
      (WebCore::ScrollbarThemeChromiumMac::paintTickmarks):
      
      Source/WebKit/chromium:
      
      Fixed a bug in invalidateArea where it wouldn't properly invalidate overlay scrollbars. The problem was that it was assuming that the scrollbar was always to the right of the visible scrollbar. This isn't true for overlay scrollbars.
      
      No tests because there are no Mac 10.7 chromium bots yet.
      
      * src/WebFrameImpl.cpp:
      (WebKit::WebFrameImpl::invalidateArea):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93361 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      41584597
    • commit-queue@webkit.org's avatar
      [chromium] Draw the root/"non-composited content" in compositor side · c4ebf0d0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=58834
      
      Patch by James Robinson <jamesr@chromium.org> on 2011-08-18
      Reviewed by Kenneth Russell.
      
      Source/WebCore:
      
      Handle the root or non-composited content with a GraphicsLayer rather than special case logic in
      LayerRendererChromium. This layer's client is the NonCompositedContentHost, which routes the paint callbacks
      through the LayerPainterChromium interface out to the WebView.  The root layer is special in two ways:
      *) The root layer has a scroll offset, which changes how the visibleLayerRect maps to content space and applies a
          draw-time transform.
      *) The root layer masks the alpha channel and disable blending when drawing because of concerns about subpixel
          AA trashing the alpha channel.  The root layer is always opaque so this is fine.
      *) The root layer does not have border texels and does have subpixel AA for text.
      
      Covered by compositing/
      
      * WebCore.gypi:
      * platform/graphics/chromium/ContentLayerChromium.cpp:
      (WebCore::ContentLayerChromium::paintContentsIfDirty):
      * platform/graphics/chromium/ImageLayerChromium.cpp:
      (WebCore::ImageLayerChromium::paintContentsIfDirty):
      * platform/graphics/chromium/LayerChromium.cpp:
      (WebCore::LayerChromium::pushPropertiesTo):
      * platform/graphics/chromium/LayerChromium.h:
      (WebCore::LayerChromium::scrollPosition):
      (WebCore::LayerChromium::setScrollPosition):
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::initialize):
      (WebCore::LayerRendererChromium::releaseTextures):
      (WebCore::LayerRendererChromium::viewportChanged):
      (WebCore::LayerRendererChromium::updateLayers):
      (WebCore::LayerRendererChromium::drawLayers):
      (WebCore::LayerRendererChromium::drawLayersInternal):
      (WebCore::LayerRendererChromium::getFramebufferPixels):
      (WebCore::LayerRendererChromium::cleanupSharedObjects):
      (WebCore::LayerRendererChromium::layerTreeAsText):
      * platform/graphics/chromium/LayerRendererChromium.h:
      (WebCore::LayerRendererChromium::rootLayer):
      (WebCore::LayerRendererChromium::viewportSize):
      (WebCore::LayerRendererChromium::viewportWidth):
      (WebCore::LayerRendererChromium::viewportHeight):
      * platform/graphics/chromium/NonCompositedContentHost.cpp: Added.
      (WebCore::NonCompositedContentHost::NonCompositedContentHost):
      (WebCore::NonCompositedContentHost::~NonCompositedContentHost):
      (WebCore::NonCompositedContentHost::invalidateRect):
      (WebCore::NonCompositedContentHost::invalidateEntireLayer):
      (WebCore::NonCompositedContentHost::setScrollPosition):
      (WebCore::NonCompositedContentHost::notifyAnimationStarted):
      (WebCore::NonCompositedContentHost::notifySyncRequired):
      (WebCore::NonCompositedContentHost::paintContents):
      (WebCore::NonCompositedContentHost::showDebugBorders):
      (WebCore::NonCompositedContentHost::showRepaintCounter):
      * platform/graphics/chromium/NonCompositedContentHost.h: Added.
      (WebCore::NonCompositedContentHost::create):
      (WebCore::NonCompositedContentHost::graphicsLayer):
      * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
      (WebCore::CCHeadsUpDisplay::draw):
      * platform/graphics/chromium/cc/CCLayerImpl.h:
      (WebCore::CCLayerImpl::scrollPosition):
      (WebCore::CCLayerImpl::setScrollPosition):
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      (WebCore::CCLayerTreeHost::CCLayerTreeHost):
      (WebCore::CCLayerTreeHost::initialize):
      (WebCore::CCLayerTreeHost::invalidateRootLayerRect):
      (WebCore::CCLayerTreeHost::setRootLayer):
      (WebCore::CCLayerTreeHost::setViewport):
      (WebCore::CCLayerTreeHost::reallocateRenderer):
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      (WebCore::CCLayerTreeHost::rootLayer):
      (WebCore::CCLayerTreeHost::viewportSize):
      
      Source/WebKit/chromium:
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::paint):
      (WebKit::WebViewImpl::setRootGraphicsLayer):
      (WebKit::WebViewImpl::didRecreateGraphicsContext):
      (WebKit::WebViewImpl::updateLayerTreeViewport):
      * src/WebViewImpl.h:
      
      LayoutTests:
      
      Update pixel baselines that changes due to subtle blending
      differences, primarily on scrollbars. I don't know why these keep
      changing.
      
      * compositing/checkerboard-expected.png:
      * platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
      * platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
      * platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
      * platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
      * platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
      * platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
      * platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
      * platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
      * platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
      * platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
      * platform/chromium-gpu-linux/media/video-zoom-expected.png:
      * platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93360 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c4ebf0d0
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r93354. · 3ad887e7
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/93354
      https://bugs.webkit.org/show_bug.cgi?id=66503
      
      "consensus was not reached" (Requested by senorblanco on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-18
      
      Source/WebCore:
      
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::drawImage):
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::drawNativeImage):
      
      LayoutTests:
      
      * fast/canvas/drawImage-clipped-source-expected.txt: Removed.
      * fast/canvas/drawImage-clipped-source.html: Removed.
      * fast/canvas/drawImage-clipped-source.js: Removed.
      * fast/canvas/drawImage-with-invalid-args-expected.txt:
      * fast/canvas/drawImage-with-invalid-args.html:
      * platform/chromium/test_expectations.txt:
      * platform/mac/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93359 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3ad887e7
    • commit-queue@webkit.org's avatar
      GestureRecognizer: Update how gesture-scroll works. · 9c38b572
      commit-queue@webkit.org authored
      Source/WebCore:
      
      Instead of just sending a series of 'GestureUpdate' events, send a
      single 'GestureBegin' event, followed by a series of 'GestureUpdate' events,
      and end with a 'GestureEnd' event.
      https://bugs.webkit.org/show_bug.cgi?id=66267
      
      Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-18
      Reviewed by Adam Barth.
      
      * page/EventHandler.cpp:
      (WebCore::EventHandler::handleGestureEvent):
      * platform/chromium/GestureRecognizerChromium.cpp:
      (WebCore::InnerGestureRecognizer::InnerGestureRecognizer):
      (WebCore::InnerGestureRecognizer::appendScrollGestureBegin):
      (WebCore::InnerGestureRecognizer::appendScrollGestureEnd):
      (WebCore::InnerGestureRecognizer::appendScrollGestureUpdate):
      (WebCore::scrollEnd):
      (WebCore::isClickOrScroll):
      (WebCore::inScroll):
      * platform/chromium/GestureRecognizerChromium.h:
      (WebCore::InnerGestureRecognizer::firstTouchPosition):
      
      Source/WebKit/chromium:
      
      Add a unit-test to make sure the correct gesture events are being
      generated.
      https://bugs.webkit.org/show_bug.cgi?id=66267
      
      Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2011-08-18
      Reviewed by Adam Barth.
      
      * tests/InnerGestureRecognizerTest.cpp:
      (WebCore::BuildablePlatformTouchPoint::BuildablePlatformTouchPoint):
      (WebCore::BuildablePlatformTouchEvent::BuildablePlatformTouchEvent):
      (WebCore::TEST_F):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93358 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9c38b572
    • rniwa@webkit.org's avatar
      Fix r93349. · 54b825a5
      rniwa@webkit.org authored
      * platform/gtk/Skipped:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93357 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      54b825a5
    • commit-queue@webkit.org's avatar
      Chromium: Update forked ScrollbarThemeChromiumMac.mm · 7420c701
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65555
      
      Patch by Sailesh Agrawal <sail@chromium.org> on 2011-08-18
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      Merge recent changes to ScrollbarThemeMac.mm to ScrollbarThemeChromiumMac.mm.
      
      * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:
      * platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.mm:
      (wkScrollbarPainterSetEnabled):
      * platform/chromium/ScrollbarThemeChromiumMac.h:
      (WebCore::ScrollbarThemeChromiumMac::maxOverlapBetweenPages):
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::registerScrollbar):
      (WebCore::ScrollbarThemeChromiumMac::setNewPainterForScrollbar):
      (WebCore::toScrollbarPainterKnobStyle):
      (WebCore::ScrollbarThemeChromiumMac::updateScrollbarOverlayStyle):
      (WebCore::ScrollbarThemeChromiumMac::updateEnabledState):
      (WebCore::ScrollbarThemeChromiumMac::paint):
      
      LayoutTests:
      
      Removing the chromium-cg-mac version of the expectation file since it now matches the mac one.
      
      * platform/chromium-cg-mac/fast/events/scrollbar-double-click-expected.txt: Removed.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93356 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7420c701
    • tony@chromium.org's avatar
      add embedded png checksums to WebKitTestRunner · 78ae5ce4
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66494
      
      Looks like WebKitTestRunner has never supported embedded checksums.  This copies
      some code from DRT and adds it to the WebKitTestRunner.
      
      Reviewed by Darin Adler.
      
      * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
      * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
      * WebKitTestRunner/GNUmakefile.am: Add new files
      * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
      * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
      * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
      * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
      (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
      (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
      * WebKitTestRunner/cg/TestInvocationCG.cpp:
      (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
      (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
      * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93355 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      78ae5ce4
    • commit-queue@webkit.org's avatar
      Source/WebCore: Unwarranted DOM Exception when when canvas2D drawImage is called with src · 6921035c
      commit-queue@webkit.org authored
      rect out of bounds
      https://bugs.webkit.org/show_bug.cgi?id=65709
      
      Patch by Justin Novosad <junov@chromium.org> on 2011-08-18
      Reviewed by Stephen White.
      
      Test: fast/canvas/drawImage-clipped-source.html
      
      * html/canvas/CanvasRenderingContext2D.cpp:
      (WebCore::CanvasRenderingContext2D::drawImage):
      Removed the unnecessary dom exceptions for out of bounds source rectangles
      The overloads that receive video and image elements as source images
      now use the normalized versions of the source rectangle, which
      GraphicsContext (and its various platform flavors) can handle correctly.
      The normalized rectangle is the equivalent rectangle with width and height
      greater than 0.  The canvas version of this method, which had better layout
      test coverage, was already correctly using the normalized rectangle. The
      newly added layout test verifies correct behavior with negative
      source rectangle dimensions.
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::drawNativeImage):
      Fixed algorithm that adjusts the destination rectangle to match the clipping
      applied to the source rect. The case of scaled filtered images with source
      rectangles that overlap the edge of the image was not being handled
      correctly. This use case was previously unsupported and used to trigger
      a DOM exception.
      
      LayoutTests: Unwarranted DOM Exception when when canvas2D drawImage is called with src
      rect out of bounds
      https://bugs.webkit.org/show_bug.cgi?id=65709
      
      Patch by Justin Novosad <junov@chromium.org> on 2011-08-18
      Reviewed by Stephen White.
      
      * fast/canvas/drawImage-clipped-source-expected.txt: Added.
      * fast/canvas/drawImage-clipped-source.html: Added.
      New test that verifies the clipping behavior when source rectangles
      are partially out of the bounds of the source image
      * fast/canvas/drawImage-clipped-source.js: Added.
      (patternTest.this.testPixel):
      (patternTest.this.testRedSquare):
      (patternTest.this.testPattern):
      (patternTest.this.testAggregatePattern):
      (patternTest):
      (drawTestPattern):
      (executeTest):
      * fast/canvas/drawImage-with-invalid-args-expected.txt:
      * fast/canvas/drawImage-with-invalid-args.html:
      This test covers (among other things) cases where the source rectangle is
      _completely_ outside the bounds of the source image.  It was modified to no
      longer expect DOM exceptions
      * platform/chromium/test_expectations.txt:
      Out-dated test canvas/philip/tests/2d.drawImage.outsidesource.html
      is now expected to fail
      * platform/mac/Skipped:
      Skipping canvas/philip/tests/2d.drawImage.outsidesource.html
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93354 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6921035c
    • ap@apple.com's avatar
      [Gtk] editing/selection/regional-indicators.html fails · 2cc5c148
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=66501
      
              * platform/gtk/editing/selection/regional-indicators-expected.txt: Land failing results.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93353 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2cc5c148
    • ap@apple.com's avatar
      Use a correct name for expected results. · e339c385
      ap@apple.com authored
              * platform/qt/editing/selection/regional-indicators-actual.txt: Removed.
              * platform/qt/editing/selection/regional-indicators-expected.txt: Copied from LayoutTests/platform/qt/editing/selection/regional-indicators-actual.txt.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93352 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e339c385
    • ap@apple.com's avatar
      [Qt] editing/selection/regional-indicators.html fails · 6d62ec94
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=66500
      
              * platform/qt/editing/selection/regional-indicators-actual.txt: Land failing results.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93351 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6d62ec94
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r93329. · f957c596
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/93329
      https://bugs.webkit.org/show_bug.cgi?id=66497
      
      Turned text on chromium win blue (Requested by jamesr_ on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-08-18
      
      Source/WebCore:
      
      * WebCore.gypi:
      * platform/graphics/chromium/ContentLayerChromium.cpp:
      * platform/graphics/chromium/ContentLayerChromium.h:
      * platform/graphics/chromium/ImageLayerChromium.cpp:
      (WebCore::ImageLayerTextureUpdater::prepareToUpdate):
      * platform/graphics/chromium/LayerChromium.cpp:
      (WebCore::LayerChromium::LayerChromium):
      (WebCore::LayerChromium::pushPropertiesTo):
      (WebCore::LayerChromium::dumpLayerProperties):
      * platform/graphics/chromium/LayerChromium.h:
      * platform/graphics/chromium/LayerRendererChromium.cpp:
      (WebCore::LayerRendererChromium::initialize):
      (WebCore::LayerRendererChromium::releaseTextures):
      (WebCore::LayerRendererChromium::updateRootLayerContents):
      (WebCore::LayerRendererChromium::drawRootLayer):
      (WebCore::LayerRendererChromium::invalidateRootLayerRect):
      (WebCore::LayerRendererChromium::rootLayerChanged):
      (WebCore::LayerRendererChromium::viewportChanged):
      (WebCore::LayerRendererChromium::updateLayers):
      (WebCore::LayerRendererChromium::drawLayers):
      (WebCore::LayerRendererChromium::paintLayerContents):
      (WebCore::LayerRendererChromium::drawLayersInternal):
      (WebCore::LayerRendererChromium::getFramebufferPixels):
      (WebCore::LayerRendererChromium::cleanupSharedObjects):
      (WebCore::LayerRendererChromium::layerTreeAsText):
      (WebCore::LayerRendererChromium::dumpRenderSurfaces):
      * platform/graphics/chromium/LayerRendererChromium.h:
      (WebCore::LayerRendererChromium::rootLayer):
      * platform/graphics/chromium/NonCompositedContentHost.cpp: Removed.
      * platform/graphics/chromium/NonCompositedContentHost.h: Removed.
      * platform/graphics/chromium/RenderSurfaceChromium.cpp:
      (WebCore::RenderSurfaceChromium::dumpSurface):
      * platform/graphics/chromium/TiledLayerChromium.cpp:
      (WebCore::TiledLayerChromium::createTilerIfNeeded):
      (WebCore::TiledLayerChromium::tilingTransform):
      * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
      (WebCore::CCHeadsUpDisplay::draw):
      * platform/graphics/chromium/cc/CCLayerImpl.cpp:
      (WebCore::CCLayerImpl::CCLayerImpl):
      * platform/graphics/chromium/cc/CCLayerImpl.h:
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      (WebCore::CCLayerTreeHost::CCLayerTreeHost):
      (WebCore::CCLayerTreeHost::initialize):
      (WebCore::CCLayerTreeHost::createRootLayerPainter):
      (WebCore::CCLayerTreeHost::invalidateRootLayerRect):
      (WebCore::CCLayerTreeHost::setRootLayer):
      (WebCore::CCLayerTreeHost::setViewport):
      (WebCore::CCLayerTreeHost::reallocateRenderer):
      * platform/graphics/chromium/cc/CCLayerTreeHost.h:
      (WebCore::CCLayerTreeHost::rootLayer):
      (WebCore::CCLayerTreeHost::viewportContentRect):
      (WebCore::CCLayerTreeHost::viewportScrollPosition):
      (WebCore::CCLayerTreeHost::viewportVisibleRect):
      * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
      (WebCore::CCTiledLayerImpl::draw):
      
      Source/WebKit/chromium:
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::paint):
      (WebKit::WebViewImpl::setRootGraphicsLayer):
      (WebKit::WebViewImpl::setRootPlatformLayer):
      (WebKit::WebViewImpl::didRecreateGraphicsContext):
      (WebKit::WebViewImpl::updateLayerTreeViewport):
      * src/WebViewImpl.h:
      
      LayoutTests:
      
      * platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/ancestor-overflow-change-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/fixed-in-composited-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
      * platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
      * platform/chromium-gpu-linux/compositing/images/direct-image-background-color-expected.png:
      * platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
      * platform/chromium-gpu-linux/compositing/masks/masked-ancestor-expected.png:
      * platform/chromium-gpu-linux/compositing/masks/simple-composited-mask-expected.png:
      * platform/chromium-gpu-linux/compositing/overflow/overflow-scroll-expected.png:
      * platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
      * platform/chromium-gpu-linux/compositing/webgl/webgl-background-color-expected.png:
      * platform/chromium-gpu-linux/fast/canvas/canvas-text-alignment-expected.png:
      * platform/chromium-gpu-linux/fast/canvas/image-object-in-canvas-expected.png:
      * platform/chromium-gpu-linux/media/video-zoom-expected.png:
      * platform/chromium-gpu-linux/platform/chromium/compositing/layout-width-change-expected.png:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93350 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f957c596
    • rniwa@webkit.org's avatar
      Skip tests added by r93291 on GTK because GTK's DRT doesn't support... · 316cd3d4
      rniwa@webkit.org authored
      Skip tests added by r93291 on GTK because GTK's DRT doesn't support textInputController.doCommand yet,
      which is tracked by the bug 66496.
      
      * platform/gtk/Skipped:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93349 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      316cd3d4
    • rniwa@webkit.org's avatar
      GTK rebaseline after r93221. · 0f45e9ff
      rniwa@webkit.org authored
      * platform/gtk/editing/selection/collapse-selection-in-bidi-expected.txt:
      Copied from LayoutTests/platform/win/editing/selection/collapse-selection-in-bidi-expected.txt.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93348 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0f45e9ff
    • rniwa@webkit.org's avatar
      SimplifiedBackwardsTextIterator returns incorrect offset with first-letter rule · 31471910
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66086
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      The bug was caused by SimplifiedBackwardsTextIterator's not taking care of first-letter at all.
      Fixing the bug by detecting RenderTextFragment in handleTextNode.
      
      Also added m_shouldHandleFirstLetter to SimplifiedBackwardsTextIterator to keep track of whether or not
      the next call to handleTextNode needs to process the first-letter part of the text fragment.
      
      Test: editing/text-iterator/backward-textiterator-first-letter-crash.html
      
      * editing/TextIterator.cpp:
      (WebCore::firstRenderTextInFirstLetter): Extracted from handleTextNodeFirstLetter.
      (WebCore::TextIterator::handleTextNodeFirstLetter): Calls firstRenderTextInFirstLetter.
      (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
      (WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
      (WebCore::SimplifiedBackwardsTextIterator::handleFirstLetter): Added.
      * editing/TextIterator.h:
      
      LayoutTests: 
      
      Added a test to ensure WebKit does not hit assertions in SimplifiedBackwardsTextIterator.
      Also fixed a bug in first-letter-word-boundary.html and updated expected offsets for move backward by word
      from 0 to 1 because there is unrendered space before "hello".
      
      * editing/text-iterator/backward-textiterator-first-letter-crash-expected.txt: Added.
      * editing/text-iterator/backward-textiterator-first-letter-crash.html: Added.
      * editing/text-iterator/first-letter-word-boundary-expected.txt:
      * editing/text-iterator/first-letter-word-boundary.html:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93347 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      31471910
    • commit-queue@webkit.org's avatar
      [chromium] Assert that main thread and compositor thread are used safely · 1b35adde
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66145
      
      CCLayerTreeHostImplProxy now has public static methods isMainThread()
      and isImplThread(), and we ASSERT these in various places. If threaded
      compositing is disabled, we fake isImplThread() by setting a flag for
      the duration of compositing, so the assert is still valid.
      
      Patch by Iain Merrick <husky@google.com> on 2011-08-18
      Reviewed by James Robinson.
      
      Covered by existing tests.
      
      * platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
      (WebCore::CCCanvasLayerImpl::draw):
      * platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
      (WebCore::CCLayerTreeHost::doComposite):
      * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.cpp:
      (WebCore::CCLayerTreeHostImplProxy::postDrawLayersTaskOnCCThread):
      (WebCore::CCLayerTreeHostImplProxy::requestFrameAndCommitOnCCThread):
      (WebCore::CCLayerTreeHostImplProxy::isMainThread):
      (WebCore::CCLayerTreeHostImplProxy::isImplThread):
      (WebCore::CCLayerTreeHostImplProxy::setImplThread):
      (WebCore::CCLayerTreeHostImplProxy::commitOnCCThread):
      (WebCore::CCLayerTreeHostImplProxy::drawLayersOnCCThread):
      (WebCore::CCLayerTreeHostImplProxy::setNeedsCommitAndRedrawOnCCThread):
      (WebCore::CCLayerTreeHostImplProxy::setNeedsRedrawOnCCThread):
      (WebCore::CCLayerTreeHostImplProxy::initImplOnCCThread):
      (WebCore::CCLayerTreeHostImplProxy::layerTreeHostClosedOnCCThread):
      * platform/graphics/chromium/cc/CCLayerTreeHostImplProxy.h:
      * platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
      (WebCore::CCPluginLayerImpl::draw):
      * platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
      (WebCore::CCTiledLayerImpl::draw):
      * platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
      (WebCore::CCVideoLayerImpl::draw):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93346 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1b35adde
    • commit-queue@webkit.org's avatar
      https://bugs.webkit.org/show_bug.cgi?id=47240 · 2c6c6cdb
      commit-queue@webkit.org authored
      Fixed a cygwin path problem in the chromium port of diff_image;
      Also made the return values of the diff_image function more consistent.
      
      Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-08-18
      Reviewed by Dirk Pranke.
      
      * Scripts/webkitpy/layout_tests/port/chromium.py:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93345 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2c6c6cdb
    • ap@apple.com's avatar
      Regional indicator symbols that are combined should behave as a single character when editing · 45e769b0
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=65395
      
      Reviewed by Dan Bernstein.
      
      Source/WebCore:
      
      Part two: make cursor movement iterator work. This fixes the problem for strings that don't
      contain more than two flags in a row, as fixing it completely doesn't seem possible with ICU.
      
      Test: editing/selection/regional-indicators.html
      
      * platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator): Added custom
      rules for regional indicator symbols.
      
      LayoutTests:
      
      * editing/selection/regional-indicators-expected.txt: Added.
      * editing/selection/regional-indicators.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93344 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      45e769b0
    • caryclark@google.com's avatar
      Fix rubber band gutter drawing for Skia on Chromium Mac · 322d7175
      caryclark@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66478
      
      Reviewed by James Robinson.
      
      No new tests. The Skia on Chromium Mac platform has
      not been enabled.
      
      This break was detected at compile time; there is no
      behavior change.
      
      * platform/chromium/ScrollbarThemeChromiumMac.mm:
      (WebCore::ScrollbarThemeChromiumMac::ScrollbarThemeChromiumMac):
      Convert the CGImage into an SkBitmap if Skia is present.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93343 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      322d7175
    • commit-queue@webkit.org's avatar
      Add a bunch of accessors to WebAccessibilityObject to expose more of · 0792ac65
      commit-queue@webkit.org authored
      AccessibilityObject to Chromium, including range control values,
      document load state, live region attributes, and a few other
      ARIA attributes.
      
      https://bugs.webkit.org/show_bug.cgi?id=66411
      
      Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-08-18
      Reviewed by Dimitri Glazkov.
      
      * public/WebAccessibilityObject.h:
      * src/WebAccessibilityObject.cpp:
      (WebKit::WebAccessibilityObject::isAriaReadOnly):
      (WebKit::WebAccessibilityObject::isButtonStateMixed):
      (WebKit::WebAccessibilityObject::isControl):
      (WebKit::WebAccessibilityObject::isFocused):
      (WebKit::WebAccessibilityObject::isLoaded):
      (WebKit::WebAccessibilityObject::isRequired):
      (WebKit::WebAccessibilityObject::isVertical):
      (WebKit::WebAccessibilityObject::accessKey):
      (WebKit::WebAccessibilityObject::ariaHasPopup):
      (WebKit::WebAccessibilityObject::ariaLiveRegionAtomic):
      (WebKit::WebAccessibilityObject::ariaLiveRegionBusy):
      (WebKit::WebAccessibilityObject::ariaLiveRegionRelevant):
      (WebKit::WebAccessibilityObject::ariaLiveRegionStatus):
      (WebKit::WebAccessibilityObject::estimatedLoadingProgress):
      (WebKit::WebAccessibilityObject::hierarchicalLevel):
      (WebKit::WebAccessibilityObject::valueDescription):
      (WebKit::WebAccessibilityObject::valueForRange):
      (WebKit::WebAccessibilityObject::maxValueForRange):
      (WebKit::WebAccessibilityObject::minValueForRange):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93342 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0792ac65
    • jchaffraix@webkit.org's avatar
      Implement a faster path for painting tables with overflowing cells · 7e533605
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=65491
      
      This change introduces a smarter way of painting if the table is big enough and we have a small amount
      of overflowing cells in the table. The new path does a binary search of the cells to repaint but adds
      the overflowing cells to the repainting cells.
      
      This saves ~50% when doing programmatic scrolling throught JS on a 500x100 table with some overflowing
      cells. Also we cap the memory usage to a ratio of the total size of the table to avoid blowing up the
      memory.
      
      Reviewed by David Hyatt.
      
      No new tests as the behavior should be the same.
      
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::RenderTableSection):
      (WebCore::RenderTableSection::layoutRows): Added some code to accumulate the overflowing cells
      in an internal HashSet (we don't need to keep them sorted and it makes it easier to use them during
      painting). If we hit the cap, flip the boolean value and clear the HashSet as the slow path does not
      care about the cell's information. Make sure that the "has overflowing cells" information is still
      properly encoded on our 2 values.
      
      (WebCore::compareCellPositionsWithOverflowingCells): Added this method as we are doing a more
      complicated sort:
          * the old path would sort one (mostly sorted) array by rows only as the stable sort would
            take care of keeping the column ordering inside a row.
          * the new path basically has to sort an unsorted array (taken partly from the HashSet).
      
      (WebCore::RenderTableSection::paintObject): Tweaked the logic to account for difference between
      m_forceSlowPaintPathWithOverflowingCell and has some overflowing cells. Also we make sure we don't
      repaint the same cell twice.
      
      (WebCore::RenderTableSection::nodeAtPoint): Changed to hasOverflowingCell(). We don't apply our
      fast path optimization here.
      
      * rendering/RenderTableSection.h: Transformed our original boolean into
      a HashSet and a boolean. The HashSet holds up the CellStruct that are overflowing
      until we reach the memory threshold. After this is hit, we just set the boolean
      to avoid using too much memory.
      
      (WebCore::RenderTableSection::hasOverflowingCell): This is the new way to determine
      if we have any overflowing cell, used only for hit testing.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93341 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7e533605
    • commit-queue@webkit.org's avatar
      An EventSource constructor should throw TypeError, when the number of arguments is not enough. · 073770a5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66454
      
      Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
      Reviewed by Adam Barth.
      
      The spec is here: http://www.w3.org/TR/WebIDL/#es-operations.
      
      Source/WebCore:
      
      Test: fast/eventsource/eventsource-constructor.html
      
      * bindings/js/JSEventSourceCustom.cpp:
      (WebCore::JSEventSourceConstructor::constructJSEventSource): Changed SyntaxError to TypeError.
      * bindings/v8/custom/V8EventSourceConstructor.cpp:
      (WebCore::V8EventSource::constructorCallback): Changed SyntaxError to TypeError.
      
      LayoutTests:
      
      * fast/eventsource/eventsource-constructor-expected.txt: Changed SyntaxError to TypeError.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93340 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      073770a5
    • commit-queue@webkit.org's avatar
      A SharedWorker constructor should throw TypeError, when the number of arguments is not enough. · 052f2a01
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66455
      
      Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
      Reviewed by Adam Barth.
      
      The spec is here: http://www.w3.org/TR/WebIDL/#es-operations.
      
      Source/WebCore:
      
      Test: fast/workers/shared-worker-constructor.html
      
      * bindings/js/JSSharedWorkerCustom.cpp:
      (WebCore::JSSharedWorkerConstructor::constructJSSharedWorker): Changed SyntaxError to TypeError.
      * bindings/v8/custom/V8SharedWorkerCustom.cpp:
      (WebCore::V8SharedWorker::constructorCallback): Changed SyntaxError to TypeError.
      
      LayoutTests:
      
      * fast/workers/shared-worker-constructor-expected.txt: Changed SyntaxError to TypeError.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93339 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      052f2a01
    • alex@webkit.org's avatar
      2011-08-17 Alejandro G. Castro <alex@igalia.com> · df3c93b0
      alex@webkit.org authored
              [GTK] Fix compilation problems with deprecations in gtk+
              https://bugs.webkit.org/show_bug.cgi?id=66073
      
              Reviewed by Martin Robinson.
      
              * platform/gtk/GtkAuthenticationDialog.cpp:
              (WebCore::GtkAuthenticationDialog::GtkAuthenticationDialog): Added
              gtk_box_new conditional compilation for gtk+-3.
              * platform/gtk/RenderThemeGtk3.cpp:
              (WebCore::RenderThemeGtk::adjustRepaintRect):
              (WebCore::RenderThemeGtk::paintSliderTrack):
              (WebCore::RenderThemeGtk::paintSliderThumb):
              (WebCore::RenderThemeGtk::adjustSliderThumbSize): Now we have have
              GTK_TYPE_SCALE in gtk+3.
      
      2011-08-17  Alejandro G. Castro  <alex@igalia.com>
      
              [GTK] Fix compilation problems with deprecations in gtk+
              https://bugs.webkit.org/show_bug.cgi?id=66073
      
              Reviewed by Martin Robinson.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (main): G_CONST_RETURN was deprecated
              * GtkLauncher/main.c:
              (createWindow): Added gtk_box_new conditional compilation for
              gtk+-3.
              * MiniBrowser/gtk/BrowserWindow.c:
              (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
              are just supporting gtk+-3 for WebKit2.
      
      2011-08-17  Alejandro G. Castro  <alex@igalia.com>
      
              [GTK] Fix compilation problems with deprecations in gtk+
              https://bugs.webkit.org/show_bug.cgi?id=66073
      
              Reviewed by Martin Robinson.
      
              * WebCoreSupport/FullscreenVideoController.cpp:
              (FullscreenVideoController::createHud): Added gtk_box_new
              conditional compilation for gtk+-3.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93338 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      df3c93b0
    • darin@apple.com's avatar
      Made some code even more private to a particular file and class · 8c5d7b07
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66428
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/API/mac/WKView.mm:
      (-[WKView _setDrawingAreaSize:]): Made this file internal.
      * UIProcess/API/mac/WKViewInternal.h: Removed _setDrawingAreaSize.
      * UIProcess/DrawingAreaProxy.h: Made sizeDidChange private.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93337 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8c5d7b07
    • commit-queue@webkit.org's avatar
      A Worker constructor should throw TypeError, when the number of arguments is not enough · cef2f177
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66456
      
      Patch by Kentaro Hara <haraken@google.com> on 2011-08-18
      Reviewed by Adam Barth.
      
      Spec is here: http://www.w3.org/TR/WebIDL/#es-operations.
      
      Source/WebCore:
      
      Test: fast/workers/worker-constructor.html
      
      * bindings/js/JSWorkerCustom.cpp:
      (WebCore::JSWorkerConstructor::constructJSWorker): Changed SyntaxError to TypeError.
      * bindings/v8/custom/V8WorkerCustom.cpp:
      (WebCore::V8Worker::constructorCallback): Changed SyntaxError to TypeError.
      
      LayoutTests:
      
      * fast/workers/worker-constructor-expected.txt: Changed SyntaxError to TypeError.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93336 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cef2f177
    • commit-queue@webkit.org's avatar
      Fix logic error causing reverse of desired WebGL rate limiting behavior · 9680a70a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66445
      
      Patch by John Bates <jbates@google.com> on 2011-08-18
      Reviewed by Kenneth Russell.
      
      * platform/graphics/chromium/WebGLLayerChromium.cpp:
      (WebCore::WebGLLayerChromium::setTextureUpdated):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93335 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9680a70a
    • leviw@chromium.org's avatar
      Switch RenderTextControl* to new layout types · 004e29a6
      leviw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66250
      
      Reviewed by Eric Seidel.
      
      Convertikng the RenderTextControl* classes to use the LayoutUnit abstraction.
      
      No new tests as no change in behavior.
      
      * rendering/LayoutTypes.h:
      (WebCore::layoutMod): Added a function to perform the modulo operation on LayoutUnits.
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::hitInnerTextElement):
      * rendering/RenderTextControl.h:
      * rendering/RenderTextControlMultiLine.cpp:
      (WebCore::RenderTextControlMultiLine::preferredContentWidth):
      (WebCore::RenderTextControlMultiLine::baselinePosition):
      * rendering/RenderTextControlMultiLine.h:
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::layout):
      (WebCore::RenderTextControlSingleLine::controlClipRect):
      (WebCore::RenderTextControlSingleLine::preferredContentWidth):
      (WebCore::RenderTextControlSingleLine::scrollWidth):
      (WebCore::RenderTextControlSingleLine::scrollHeight):
      (WebCore::RenderTextControlSingleLine::scrollLeft):
      (WebCore::RenderTextControlSingleLine::scrollTop):
      (WebCore::RenderTextControlSingleLine::setScrollLeft):
      (WebCore::RenderTextControlSingleLine::setScrollTop):
      * rendering/RenderTextControlSingleLine.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93334 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      004e29a6
    • leviw@chromium.org's avatar
      Switch Inline rendering classes to new layout types · ff0b81a3
      leviw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66239
      
      Reviewed by Eric Seidel.
      
      Converting inline rendering classes to use the LayoutUnit abstraction from ints.
      
      No new tests as no change in functionality.
      
      * rendering/InlineBox.h:
      (WebCore::InlineBox::logicalFrameRect):
      (WebCore::InlineBox::baselinePosition):
      (WebCore::InlineBox::lineHeight):
      * rendering/InlineFlowBox.h:
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::logicalOverflowRect):
      (WebCore::InlineTextBox::setLogicalOverflowRect):
      (WebCore::InlineTextBox::baselinePosition):
      (WebCore::InlineTextBox::lineHeight):
      * rendering/InlineTextBox.h:
      (WebCore::InlineTextBox::logicalTopVisualOverflow):
      (WebCore::InlineTextBox::logicalBottomVisualOverflow):
      (WebCore::InlineTextBox::logicalLeftVisualOverflow):
      (WebCore::InlineTextBox::logicalRightVisualOverflow):
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::culledInlineAbsoluteRects):
      (WebCore::computeMargin):
      (WebCore::RenderInline::culledInlineBoundingBox):
      (WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
      (WebCore::RenderInline::linesVisualOverflowBoundingBox):
      (WebCore::RenderInline::clippedOverflowRectForRepaint):
      (WebCore::RenderInline::rectWithOutlineForRepaint):
      (WebCore::RenderInline::computeRectForRepaint):
      (WebCore::RenderInline::mapLocalToContainer):
      (WebCore::RenderInline::lineHeight):
      (WebCore::RenderInline::baselinePosition):
      (WebCore::RenderInline::addDashboardRegions):
      * rendering/RenderInline.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93333 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ff0b81a3
    • jpfau@apple.com's avatar
      New XML parser: add doctype to DOM tree · 8a80bb93
      jpfau@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=66408
      
      Reviewed by Adam Barth.
      
      * xml/parser/XMLTreeBuilder.cpp:
      (WebCore::XMLTreeBuilder::processDOCTYPE):
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93332 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8a80bb93
    • rniwa@webkit.org's avatar
      Add a test to ensure WebKit does not paste contents before · 7272704f
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66481
      
      Reviewed by Alexey Proskuryakov.
      
      Add a regression test since this bug has been fixed by r92695.
      
      * editing/pasteboard/paste-delete-insertion-position-skip-paragraph-expected.txt: Added.
      * editing/pasteboard/paste-delete-insertion-position-skip-paragraph.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@93331 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7272704f