- 10 Oct, 2019 40 commits
-
-
Alex Moshchuk authored
This appears to be a remnant of top document isolation, which was removed a while ago. Also remove the SetIsNeverSuitableForReuse() plumbing which was only used in this class. Bug: 884842 Change-Id: I5bc7f1242bed0a69095355c23d8ab34dab4b7231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849140Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#704766}
-
liberato@chromium.org authored
Previously, destroying a LearningTaskController would cancel any in- flight observations. However, it's convenient to sometimes specify a default value to complete them with if, for example, a browser tab is closed while an observation is pending. This CL adds an optional TargetValue to BeginObservation that will be used to complete the observation if the controller is destroyed. While it might make more sense to include it only on the mojo client, instead of the base interface, it turns out to be easier just to put it there. Change-Id: I9ed7ebf089be123a905265a780e427d0b11dfa54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841248 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#704765}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b484e7ce24c9..2d8a95ee71b5 git log b484e7ce24c9..2d8a95ee71b5 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 robertphillips@google.com Add "meshCount" to GrProgramInfo Created with: gclient setdep -r src/third_party/skia@2d8a95ee71b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: I2a7d45d32b92785bb7b14d62be0f1c51d69e8c63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853167Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704764}
-
Daniel Hosseinian authored
Currently, the scaling settings are stored in booleans. Instead, store the scaling as enum values. |fitToPage| and |customScaling| are accordingly replaced with |scalingType| and |scalingTypePdf| in the settings. In doing so, the declaration of the Scaling type enum is moved from ui/scaling_settings.js to data/scaling.js. Later, the scaling will be passed to the printing backend in another CL. Furthermore, information about whether the printed document is a PDF is passed to the print-preview-scaling-settings element, and the logic to determine the availability of scaling values is handled in the element script. Bug: 989978 Change-Id: Ic8835bfbed88700981ec86df944069706d3cba0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828287 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#704763}
-
liberato@chromium.org authored
Cross-origin redirects for downloads aren't allowed, but media elements didn't notice. This CL causes them to fail rather than download or navigate. It replaces LocalFrameClient::CrossOriginRedirects with the pre-existing network::mojom::RedirectMode, which includes the option kError. We use that to indicate that no cross-origin redirect should be followed. Last, this CL partially addresses a TODO in parallel_job_download to fail redirects, but failing cross-origin redirects. Change-Id: I10d11962cdc175ae818a0e3f19e4aeaa5a68b959 Bug: 990867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779320 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#704762}
-
Collin Baker authored
Change-Id: I186dd89725086a71f0d9973a38a6e2c4a6813eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849435 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#704761}
-
Francois Beaufort authored
Setting the FLAG_READER_NO_PLATFORM_SOUNDS flag allows us to prevent Android from playing sounds when it discovers a tag. Vibration still occurs though with same duration as Android (200ms). Change-Id: If39b880a0b7a69da1a8917fd643ec0846119a47f Bug: 1011325 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840611Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#704760}
-
Christopher Cameron authored
Bug: 952063, 988964 Change-Id: Ie78e8c7b264dd5f713949cc4acbc6ad5df657f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849982 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704759}
-
Hazem Ashmawy authored
Applying AndroidXPlugin to fix issues with signing project builds when it's mirrored to AndroidX repo. Bug: https://issuetracker.google.com/issues/142394338 Test: manually cherry-pick change to //external and run gradlew :webkit:assembleRelease and gradlew :webview-support-interfaces:assembleRelease Change-Id: I4156549137c43128087b94307d14284d5b08414e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853265 Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Aurimas Liutikas <aurimas@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#704758}
-
Clark DuVall authored
The safe redirect checking logic in NavigationURLLoaderImpl was changed in http://crrev.com/c/1779310 to remove the check for web accessible extensions resources. There was similar logic in the WebRequest proxy that should be removed to match. This was causing the network_service_web_request_proxy_browser_tests to fail on the Mojo Linux bot. These tests run with a WebRequest proxy forced on to test the logic: https://ci.chromium.org/p/chromium/builders/ci/Mojo%20Linux/40022 Bug: 442579 Change-Id: I47a208d0586e0dc6389bb8bd4aeae2b3a61c78a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853133 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#704757}
-
Ian Struiksma authored
Since we moved away from checking for paint events to watching the render_frame_count, we no longer need to be hooked into the WebContentsObserver. Additionally, it is better to always go with tab_strip_model->GetActiveWebContents instead of loading from frame before possible navigation. For those 2 reasons, removing the PageActivityObserver and moving that logic into the TestRecipeReplayer. Also refactored the WaitTillPageIsIdle into 2 steps to ensure we don't navigate the page with an active RenderFrameSubmissionObserver. This fixes intermittent issue crbug.com\1003044 that was occurring on multiple sites and always on wiley.com. Also fixes another flaky situation that was occurring on some sites with render frame observing Enables autofill tests for sites: davidsbridal coach findmeagift neiman_marcus north_face wiley fender pets_mart Bug: 1003044,984664 Change-Id: Ib7732eed8a82395f25de3bacad0f30e440bc18ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842675 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#704756}
-
Sertay Sener authored
This CL ports the Blob related IndexedDB Web Tests to WPT tests. Bug: 866164 Change-Id: Ie2b1b6ddc0c1ddbbb92478a2d5c81bd669c30e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807963Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Sertay Sener <sesener@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704755}
-
Shakti Sahu authored
Change-Id: I6d6fa7aed8164314611e547ad4f96891db259933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852175Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704754}
-
Aaron Krajeski authored
We use both throughout the code base but heavily lean towards 2D. Make it 2D throughout. Change-Id: Ia9f3af6592ffade92c80c6dc04749a915dd7b1ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847893 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@google.com> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#704753}
-
danakj authored
This value is part of ScreenInfo which will be once again locally scoped to each local root RenderFrame/RenderWidget. A RenderView without a local main frame won't know the DeviceScaleFactor. R=avi@chromium.org TBR=thestig, rdevlin.cronin Bug: 419087 Change-Id: Ife3bf17d3d80a8f19e817ed270c9dbfe954a8a65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852949Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#704752}
-
Emircan Uysaler authored
This CL checks the current state before creating SkSurfaceCharacterization to properly set protected param. Bug: fuchsia:38284 Change-Id: Ie570cff987427f4667289a60b858c48ad307cd0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849149Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#704751}
-
Yun Liu authored
Also fixed a bug to create directory if host directory doesn't exist, otherwise pull command will pull file to "host directory" as a file. Bug: 985574 Change-Id: I158acdf39a90a3e014a88ffb42d520fc6abf8d67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1839351 Commit-Queue: Yun Liu <yliuyliu@google.com> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#704750}
-
Ken Rockot authored
ScopedFeatureList is unsafe to use after browser threads have been started. This constraint will imminently be enforced by DCHECK to prevent further erroneous usage from landing. This CL corrects usage within miscellaneous Content browser tests as well as Chrome tests related to site islation. This is split from a larger CL where in some rare cases, correction was too complex to resolve before landing the DCHECK, so corresponding test(s) may be disabled instead of fixed. Bug: 846380 Change-Id: Idf6fcaabc37d09b49acb70ad3bd177985bed91cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850736 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#704749}
-
Maks Orlovich authored
It should be treated as a 1st party context, not 3rd party one. Bug: 1012742 Change-Id: Ic8ceb0c7f2e60e15b4517550c50ab67c637b492c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853044 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#704748}
-
Chris Mumford authored
The Android device serial number, specified by the --device-serial command-line option, was unused by the android_webview wptrunner. This resulted in adb failing with the following error: adb wait-for-device error: more than one device/emulator Bug: None Change-Id: I85e236297d7e83950ac26a9283bdad4ef642d62c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845486 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#704747}
-
Lei Zhang authored
Use more C++11. Fix nits and lint errors along the way. Change-Id: I8d905472cbae1568be1f3ce5b8866b0cb564335a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843313Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#704746}
-
danakj authored
These widgets are not in use, and VisualProperties will be sent when they want to be revived by a new local main frame. R=avi@chromium.org Bug: 419087 Change-Id: I4bcdd8a505c4e5c18a3d9e7b6c3b91f444774e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850759 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#704745}
-
Shakti Sahu authored
This CL disables notifications suggested pages for all kinds of contents : offline pages and content indexing. Bug: 1011415 Change-Id: I4555f6f189cbc763379a52d7b163464ff6d8c8c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853111Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704744}
-
John Lee authored
This CL also adds differentiation between a loading and a waiting state, each displaying a spinner in their own colors and directions, similar to how the native tab strip works. This CL also updates types to allow for the new data. Bug: 1004985 Change-Id: I1b9361b3796e369d683b8f63c6a2026364d439f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848573Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#704743}
-
Dominic Mazzoni authored
Bug: none Change-Id: Ifee79eca593238e0f85cd2d5d4b07ea98c9e256b Tbr: aleventhal@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852419Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#704742}
-
Erik Chen authored
This CL is a refactor with no behavior change. In the future, undead RenderWidgets won't exist. By returning nullptr, we prevent accidentally uses from cropping up. Bug: 419087 Change-Id: Ie71c7c818921f1d0a464003e69d6cf267f8fe3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850575Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#704741}
-
Steven Bennetts authored
This CL uses a unuion for type specific properties in ConfigProperties. Since the config properties are typically generated on the fly and passed from UI -> the CrosNetworkConfig implementation, the union type is used to specify the network type (i.e. no explicit type is required). Bug: 853953 Change-Id: I08ae054f8d5554727c4d9422ca325b284c3927e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850724 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#704740}
-
David Benjamin authored
It was only used by tests at this point. Bug: 340460 Change-Id: I1a52c17d439bfb5a198a908aee0fe7600bb7845d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846468Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#704739}
-
Aaron Krajeski authored
This mostly means that we need to be more explicit about when we finalize frame. This is covered in prior CLs: https://chromium-review.googlesource.com/c/chromium/src/+/1848934 https://chromium-review.googlesource.com/c/chromium/src/+/1814457 Next step is to create a CanvasDeferral class that mixes in to the generic CanvasRenderingContext class and manages deferral for all types of canvases. Also, finding a way to get write pixels within deferral by using putImageData would be nice. Bug: 1002523 Change-Id: Ia5aa50e3082177df1f422d14fc7899f8d173a874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762467 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#704738}
-
Yuwei Huang authored
Chromoting is now fully on FTL signaling, so this CL removes LCS support in SignalingAddress and cleans up the code. We can't remove XMPP yet since IT2ME still uses it to communicate with the website. Bug: 983282 Change-Id: I6d1a6d110a7f04ad28e963e7ab7c31c8bcc707be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851226Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Yuwei Huang <yuweih@chromium.org> Cr-Commit-Position: refs/heads/master@{#704737}
-
Ian Wells authored
Bug: 1001506 Change-Id: Ice31c3588d42038ebe7728739189e69710557dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815084Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#704736}
-
Yun Liu authored
Bug: 985581 Change-Id: I53edb1be6c0761e0f52868119576c7dff6b2a3c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850737Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#704735}
-
Adrienne Walker authored
This code is currently in content/browser/loader but is useful to other features. Bug: 1012869 Change-Id: Ie129d975d0d381f2ec8e98670efc8ed52c39d40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848055Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#704734}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01cfdcb21734..b21973d2c0c9 Created with: gclient setdep -r src-internal@b21973d2c0c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I656518a05a1558d434755887f419e751eb56daf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852195Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704733}
-
Jack Lynch authored
This adds an axe tests for the Sources panel global listeners pane. Bug: 963183 Change-Id: Iba5ef2bdc927439604f01d91c1e8b9966c43fdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666329 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#704732}
-
Antonio Gomes authored
It is now possible after mock_peer_connection_dependency_factory.h|cc move [1]. [1] https://crrev.com/c/1816789 BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I76ea8c3477467f5b4956af64cc4b76cc28c20775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816792 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#704731}
-
Jack Lynch authored
This CL adds context menu items to each listener to reveal its source code, remove it, or toggle whether it is passive or blocking (when applicable). This improves the accessibility of the event listeners view in the Elements panel as well as the global listeners view in the Sources panel, as previously the passive toggle and delete buttons were available only on hover. Previously reviewed at https://chromium-review.googlesource.com/c/chromium/src/+/1665298, split into this CL as it impacts multiple parts of the UI. Screenshot: https://gyazo.com/dc1b54b5e0ae1f9b67f89b0400a168a8 Bug: 963183 Change-Id: I497e96ee3eb5d58358f904dd7e9ac92b15840baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716462 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704730}
-
Xida Chen authored
Bug: 900581 Change-Id: Iafa4c8d546e1de8eb540deb17d82b7c055854cf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853132 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704729}
-
Marc Treib authored
article_entry.h/cc contained a bunch of code for converting from Sync types (SyncData/SyncChange/EntitySpecifics) to dom_distiller types. After recent changes, all that code isn't used anymore and can go. This also lets us remove special workarounds for the deprecated ARTICLES data type that we had in sync code. Bug: 1007942 Change-Id: Ic9e4d243dd7a4276973398149fd14da61bf5fe05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835367 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#704728}
-
Stephen Chenney authored
The name of Paint Holding has replaced the original name of AvoidFlashBetweenNavigation. Renaming it allows a forthcoming finch study to use the current name. Also update the description etc. Bug: 1012732 Change-Id: Ia5994207e5d8e8b1f6a136ae709c1c8c773d418d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849145Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#704727}
-