- 31 Jan, 2020 40 commits
-
-
Kurt Horimoto authored
The default cancellation handler is deleted after calling Cancel(), so the observer needs to be removed before cancellation. Bug: 1038514 Change-Id: I9a638b9ae7c6c44e4655fb5d80674285620c308d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032062Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#737213}
-
Virender Singh authored
This change modifies the PDF document's name string to follow formatting rules defined in: http://userguide.icu-project.org/formatparse/messages Bug: 1043505 Change-Id: I1cad4ecea83b41a1ccf7adb68ad3e2a104f65749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030350Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Virender Singh <virens@microsoft.com> Cr-Commit-Position: refs/heads/master@{#737212}
-
Kent Tamura authored
If a json5 file for make_names.py contains duplicated names, make_name.py produced invalid C++ code and we had to remove duplicates. * make_names.py should report an error for duplicated entries instead of producing invalid code. * html/keywords.json5 should allow duplicated entries because it contains keyword sets for multiple attributes and some keywords are valid for multiple attributes. Change-Id: I81c2a4a978ece5a03471fd8b37d85b61cda2a8e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032465 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#737211}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/08f1abcc5bb0..659962bc1b4c git log 08f1abcc5bb0..659962bc1b4c --date=short --first-parent --format='%ad %ae %s' 2020-01-31 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@659962bc1b4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I564612f9fcff1253adb663ddd162db42b6e629a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032569Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737210}
-
Kent Tamura authored
* select-box.html Convert a pixel test to an assert_selection.js test * select-element-paragraph-boundary.html Merge this into select-box.html * document-write-option.html Convert a pixel test to a reference test. Bug: 1040828 Change-Id: I15e156016b183a44709f7a6bc7b520f83a7a73f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032644Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#737209}
-
Kent Tamura authored
PositoinIterator returned a wrong result if INPUT, SELECT, or TEXTAREA has two or more children. Strategy::LastOffsetForEditing() doesn't take into account of IsUserSelectContain(). It's inconsistent with ShouldTraverseChildren<Strategy>. So, this CL introduces an IsUserSelectContain()-aware version of LatOffsetForEditing(). Bug: 697283 Change-Id: Id04cf8ce5cbe3702a4c51a1b6057693c7c669cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029536 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
rbpotter authored
- Call resetString() after setting the textbox value, so that future updates to the textbox will trigger an input-change event. - Also make some conditions more clear in the margins code. Bug: 1046683 Change-Id: I742f264a0dca2c1b5a41e769ada5f5d2966e5c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032433 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#737207}
-
Chris Palmer authored
This reverts commit a7527ee7. Reason for revert: It was a speculative workaround that may not be needed. Original change's description: > Speculatively turn off the `PartitionAllocZeroFill` optimization on macOS. > > It might? be the cause of some test flakage. > > Bug: 892550 > TBR: ajwong > Change-Id: I4ac98e2e5e3d02526ed2c187157d097b82adc756 > Reviewed-on: https://chromium-review.googlesource.com/c/1266199 > Commit-Queue: Chris Palmer <palmer@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597390} TBR=ajwong@chromium.org,palmer@chromium.org,mek@chromium.org,haraken@chromium.org,mastiz@chromium.org Bug: 892550 Change-Id: I55bc9c2869f506cd0f3fa73103c715982b598599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031709Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#737206}
-
Rachel Wong authored
Bug: 1014839 Change-Id: Icd2ff4b14e42118f05bc964824bea004e3a14bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029388Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#737205}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/51aa23b1aa22..689bf533edd9 Created with: gclient setdep -r src-internal@689bf533edd9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041701 Tbr: jbudorick@google.com Change-Id: I3300c5f5b906d03766783c171d0aeb30d8b1bbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032570Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737204}
-
Daniel Clark authored
This change implements live-update and double-escape behavior for the month input popup. When arrow keys are used to change the selection, the changes are immediately reflected on the in-page control (and input events are fired). When the user hits escape, if they have made changes these are reverted without closing the popup. A second escape (or the first one, if no changes were made) closes the popup. Behavior when clicking on a month is not changed; the popup is still submitted immediately (as opposed to other types like datetime-local where the user may want to go on to select other values after clicking the date). The selection/highlight model is changed so that using the arrow keys moves the selection instead of the highlight, invalid dates cannot receive selection, and the highlight is only used as a hover style. Initialization of the control is changed such that if there is any valid month, one will be selected, avoiding scenarios where we don't paint a focus ring because there is no starting selected month. Fixed a bug where months invalid due to the step attribute were not greyed out. The above changes required a lot of the same valid-date-range-seeking functionality already implemented in CalendarPicker, so I removed the side-effects from these functions and moved them into a mixin consumed by both CalendarPicker and YearListView. All of above behavior changes apply only to the standalone month picker; the month selector embedded in date/week/datetime-local popups is unchanged. I'm not sure that live-update and double-escape makes as much sense in those contexts, although we could consider a later follow-up to change the selection behavior to match the new standalone picker's behavior. Bug: 1045195 Change-Id: I264a5285ec7df8bca4b0ad6389886b9580c12ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029243Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#737203}
-
John Lee authored
When a user drags a tab or tab group from another browser, a placeholder is created and appended to the end of the tab list to suggest that the tab or group will be dropped at the very end. This is a temporary solution for not being able to directly place tabs in a specific index. Bug: 1005560 Change-Id: I283862086531a2b21222d43e9a6b650af5b9219a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032057Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/be99ee8f17f9..ec47b57f1440 git log be99ee8f17f9..ec47b57f1440 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 steveanton@webrtc.org Do not transition ICE gathering state to 'complete' when closing Created with: gclient setdep -r src/third_party/webrtc@ec47b57f1440 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1068ef7ddf88ce30abfbaf5d59b6b26eae8d0a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032212Reviewed-by:
-
Hugo Benichi authored
This patch makes ArcNetHostImpl more robust in face of delayed or missing IP configuration properties from shill: - When no IP configuration can be obtained for a network, always request with a few seconds delay a full network property update in order to let IPv4 DHCP or IPv6 autoconf complete. - Send net.mojom ActiveNetworksChanged notifications to ARC on more triggers from NetworkStateHandlerObserver. This allows ARC to obtain IP configuration properties for the host when they are populated after the initial network connection. - Preferably use IP configurations obtained through DeviceState (shill's Device DBUS objects). This allows ARC to consistently obtain both IPv4 and IPv6 configurations for the host. - Always drop partially empty IP configuration object. This allows to filter out double IPv4 configuration objects send by shill and allows ARC to be less defensive about net.mojom notifications sent by Chrome. BUG=b:148431888 BUG=b:146182659 TEST=Flashed atlas, manually watched Chrome and ARC logs while triggering new connetions to dual stack GoogleGuest and IPv6 only GoogleGuest, confirmed that ARC now always get the IP configuration immediately or shortly after the new connection, as far as tested. Change-Id: I24d26d6492f133e0c38949c8c3b4403687bfac21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028881 Commit-Queue: Hugo Benichi <hugobenichi@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#737200}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I7b61247ec4a9b8c2ae610ea7a7d4ec621886b45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032784Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737199}
-
Daniel Cheng authored
Change-Id: Iee21649faf1407f3c0c404b6e931d524b0ceabe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029252 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#737198}
-
Rachel Wong authored
Bug: 1014839 Change-Id: I9104d53beebc430a285b570f640d671ffad91c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029387Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#737197}
-
Chromium WPT Sync authored
Using wpt-import in Chromium be2478a3. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bokan@chromium.org: external/wpt/visual-viewport dcheng@chromium.org, palmer@chromium.org: external/wpt/domparsing rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I48ad880e51389735ae52d54ced8d8b05c7c171e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031970Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737196}
-
Kent Tamura authored
This CL removes inner_block_height_, which is a cache of inner_block_'s height because: - The computation of the height doesn't look a heavy operation. - inner_block_height_ was referred only if -webkit-appearance:menulist*. This CL has no behavior changes. Bug: 1040828 Change-Id: Ic70ee31202fffaaaecfacc47c5141f52a921be55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032685Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#737195}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1edaa1d1e18f..f28d0ae61457 git log 1edaa1d1e18f..f28d0ae61457 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 kainino@chromium.org Revert "Remove VK_DEFINE_NON_DISPATCHABLE_HANDLE magic, use explicit VkHandle wrapper" 2020-01-31 kainino@chromium.org Remove VK_DEFINE_NON_DISPATCHABLE_HANDLE magic, use explicit VkHandle wrapper Created with: gclient setdep -r src/third_party/dawn@f28d0ae61457 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1046362 Tbr: cwallez@google.com Change-Id: I2d7ee0497ab58ad4c5a53883d961be757e4c7281 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032619Reviewed-by:
-
Xing Liu authored
Finch parameter is not guaranteed to be ready on first run. This may introduce unexpected behaviors, like the user see the notification on second time running Chrome. Now we always persist the first run timestamp and uses a Finch specified timestamp from the server to check if first run happens recently. If so then just skip the notification. Also address an issue that origin checks for NotificationPlatformBridgeMac is removed, now we let the empty GURL pass. Bug: 1047286,1046457 Change-Id: I59723c7d35230345ca9d77ccc810a07646d34b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032346 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#737193}
-
Yuichiro Hanada authored
Bug: None Test: ash_unittests Change-Id: I62e018e0898f032bc947862750e542c0da9f91cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025167 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737192}
-
Md. Hasanur Rashid authored
The Chromium C++ style guide recommends that DVLOG is used as it "avoids bloating the release executable and in debug can be selectively enabled at runtime". Bug: 519010 Change-Id: I601859734234d21ae98a51539f4384ae8d94f795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026854 Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#737191}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/04bb1f2f0353..62c4aa446733 git log 04bb1f2f0353..62c4aa446733 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 tsepez@chromium.org Avoid segv in CXFA_FFPageView::GetPageViewRect() after page is gone. 2020-01-31 thestig@chromium.org Rename CPDFSDK_FormFillEnvironment::GetPermissions(). 2020-01-30 thestig@chromium.org Clarify what CPDFSDK_FormFillEnvironment::GetPermissions() does. 2020-01-30 thestig@chromium.org Consolidate dimension checking code inside cpdf_dib.cpp. 2020-01-30 thestig@chromium.org Handle a case of colorspace mismatch with JPEG2000 images. Created with: gclient setdep -r src/third_party/pdfium@62c4aa446733 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1012369,chromium:1042915 Tbr: pdfium-deps-rolls@chromium.org Change-Id: Ia4975786941e334f991dd674f2c6e2b12e1aaf06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032616Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7fd0c00afadd..51aa23b1aa22 Created with: gclient setdep -r src-internal@51aa23b1aa22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041618,chromium:1041701 Tbr: jbudorick@google.com Change-Id: I0979ff67c853b97f5763f8a6e9ac441ea3077127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032214Reviewed-by:
-
Peter Boström authored
This makes sure the ImeWarningBubbleView can show (and not crash :)) when ExtensionsToolbarMenu is enabled. Also fixes ImeWarningBubbleTest.* when ExtensionsToolbarMenu is enabled. Bug: chromium:943702, chromium:984654 Change-Id: Idf8bdd14792201eba421547b8ccd0543817e8ce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028186 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737188}
-
Takumi Fujimoto authored
Record the above two GMC metrics in CastMediaNotificationItem. TBR=jwd@chromium.org Bug: 1042832 Change-Id: I108b8e8f13c3a1a45d514c4b345b1ce224a9ba27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005388Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#737187}
-
Chris Blume authored
When a website contains an image with a wide color gamut, it should inform the Viz process as to the widest color space being used and allow the Viz process to change its display. Bug: 955158 Change-Id: I66039294647d5d24dc47d11b66db0d280a3ab1a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978634 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#737186}
-
Patrick Noland authored
Bug: 865801 Change-Id: I4f718c8032bc6c86034a3aa867674d53837aaad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028259 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#737185}
-
Mohsen Izadi authored
We need to access ui::EventType in //cc as a part of adding event latency info to compositor latency metrics, however, //cc cannot have dependency on //ui. There is a //ui/events/types directory that's accessible from //cc. This CL moves ui::EventType to //ui/events/types so it can be accessed form //cc. Bug: 963781 Change-Id: Id1cc85ca74f2fe114942285e0c9de39944c0e175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028629Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/5fcdf4ad4909..6c109e908aa4 $ git log 5fcdf4ad4..6c109e908 --date=short --no-merges --format='%ad %ae %s' 2020-01-29 junyer Make the fuzzer use FuzzedDataProvider. 2020-01-12 junyer Tidy up a test. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: I46f5757eeace0104ebdef23be713b9f95a7b1d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031881Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#737183}
-
Sammie Quon authored
It's a cheaper alternative that gets the same visuals. Design doc in the linked bug. First application will be on the overview item close button. Short-term follow ups: 1) Apply on ink drops ash-wide. 2) Change ink drop highlight for ash ink drops to use solid color layer. Test: manual Bug: 1042303 Change-Id: Ia1728762fd9234304277e3bb42c12dfa03f87fef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026527 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#737182}
-
Mason Freed authored
The [1] CL combined the ElementNamespaceType bits, to save space. However, as seen in [2], this caused a performance regression, likely due to a slower IsHTMLElement(). This CL attempts to get back that performance through two optimizations: - ALWAYS_INLINE the accessors for both GetElementNamespaceType() and the IsXyzElement() accessors. - Move kHTML to a value of 0, in the hope that this operation is faster when the kConstant is zero: GetElementNamespaceType() == kConstant [1] https://chromium.googlesource.com/chromium/src/+/956931765e5969c44ad9a4641ff1c99977c8498f [2] https://crbug.com/1036543 Bug: 1036543 Change-Id: I4976829ab0b7c9d875d4d4e6b516333b44e7dddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029311 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#737181}
-
Gary Kacmarcik authored
Change-Id: I1ea23ac27a95d95491470d9a5d27713a35e5fb64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032328 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#737180}
-
Alex Moshchuk authored
The HasSecurityState() check was introduced as a temporary workaround to eliminate crashes caused by Mojo services trying to perform ChildProcessSecurityPolicy security checks after the RenderProcessHost has been destroyed. HasSecurityState() was used to detect that the process was gone and just fail open. Now, we have a better solution in place with ChildProcessSecurityPolicyImpl::Handle, which extends the lifetime of a process's security state even after the RPH has gone away. Switch BroadcastChannelProvider to use this approach instead. Bug: 943887 Change-Id: Id83c27364506ff9a349a10c5f54193c2aa0f369b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031924Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#737179}
-
Takuto Ikuta authored
python client is deprecated, let me recommend to use go client instead. Bug: 984869 Change-Id: I93bde0a245510a178bfe5990b074211ba6f45ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029565 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737178}
-
Gyuyoung Kim authored
Existing WebTestControl and WebTestClient interfaces have been used by |BlinkTestRunner| and |BlinkTestController| classes. So, it's better to use BlinkTestControl and BlinkTestClient interface names. - Rename WebTestControl to BlinkTestControl - Rename WebTestClient to BlinkTestClient - Rename web_test.mojom to blink_test.mojom - Rename WebTestBlinkTestClient to BlinkTestClientImpl Instead, the IPC messages defined in web_test_messages.h are going to be converted to WebTestControl and WebTestClient interfaces. Bug: 1039247 Change-Id: Ic835d03f872e67477323c48e5e5f72a69627ffa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015472 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#737177}
-
Kenichi Ishibashi authored
This CL moves ScheduleDeleteAndStartOver() call from ServiceWorkerStorage::DidWriteUncommittedResourceId() to ServiceWorkerRegistry so that we can reduce ServiceWorkerContextCore dependency from ServiceWorkerStorage. Bug: 1039200 Change-Id: If6ca49d6489fbe34a777a3b005ff1a6792e4e257 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026336 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#737176}
-
chrome://media-appchrome://media-app-guestTrent Apted authored
Currently we pass an ArrayBuffer which does not work for large files such as video. Passing a File works, and doesn't require a copy. Add media/video to the list of handlers now we know it works. Tested manually with a 5GB video, and covered by existing unit and integration tests (with smaller files). Update the existing file_handler.accept map rather than adding a new handler due to https://crbug.com/1047509. BUG=996088, b/144865801 Change-Id: I46b3ba53676534e06ba039c9a52c8701b4d1d432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029532Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#737175}
-
Dale Curtis authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/e79e5ceb2cb7..9c29f229c5aa $ git log e79e5ceb2..9c29f229c --date=short --no-merges --format='%ad %ae %s' 2020-01-24 gramner checkasm: Increase buffer alignment to 64-byte on x86-64 2020-01-28 martin arm: cdef: Add special cased versions for pri_strength/sec_strength being zero 2020-01-28 martin arm: cdef: Fix some comment typos 2020-01-28 gramner Fix crash in dav1d_apply_grain() with negative picture strides 2020-01-27 gramner Optimize the cdef_filter C implementation 2020-01-27 gramner checkasm: Improve cdef_filter test 2020-01-24 gramner Avoid redundant calls to CDEF DSP functions 2020-01-22 gramner x86: Bump nasm version requirement to 2.14 2020-01-21 thresh CI: Use a newer image to build snap packages 2019-12-12 victorien x86: add prep_8tap AVX512 asm 2020-01-17 victorien x86: replace "mov hb, Xb" by "movzx hd, Xb" in MC 2020-01-20 psilokos x86inc: save xmm_regs_used in spill_xmm for non-win64 2020-01-15 martin arm64: itx: Fix overflow/clipping in negation in idct16 2020-01-14 gramner x86: Fix overflows in SSSE3 idct 2020-01-14 gramner x86: Fix missing saturations in inverse identity asm 2019-12-21 rsbultje SSSE3 implementations of film grain Created with: roll-dep src/third_party/dav1d/libdav1d TBR=tguilbert Change-Id: I1dd1ca36e32d68a4e9ee318f2acc435fa69e61a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032413Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#737174}
-
