- 20 Dec, 2017 40 commits
-
-
Sam McNally authored
Bug: 779444 Change-Id: I9c56fc78c1eb622e55abe28cb97a53cbab6d60df Reviewed-on: https://chromium-review.googlesource.com/832288Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#525251}
-
Zhuoyu Qian authored
This patch makes BackgroundEdgeOrigin to be an enum class for better type safety. Bug: 684966 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Idd6d55e4cb4f67d844a5ffbea7a47dd5d375c07d Reviewed-on: https://chromium-review.googlesource.com/830988Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#525250}
-
Kenneth Russell authored
These bots are crashing with the 5s timeout. BUG=796437 TBR=zmo@chromium.org, pfeldman@chromium.org Change-Id: I2c2b9b491af93a7dcce86a27f6d5af68bb2ee81f Reviewed-on: https://chromium-review.googlesource.com/835475Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#525249}
-
Benjamin Pastene authored
Bug: 796376 Change-Id: Ifb1b14bddfad4db4fdfcef966a760a31c6720b9e Reviewed-on: https://chromium-review.googlesource.com/835647Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#525248}
-
chrome://flagsLeo Zhang authored
Bug: 783049 Change-Id: I162ac00846be5e267d206a89e8e2d652ec603874 Reviewed-on: https://chromium-review.googlesource.com/831379 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#525247}
-
Alexander Alekseev authored
There are still some very old users on some devices, that do not have full profile information in Local State users list. This Cl falls back to UserEmail as a key in user_types list, and implements migration, so that this will not trigger CHECK again. Bug: 795380 Change-Id: Ic1c4ecbae2118be922417fb09de96df6e89aa316 Reviewed-on: https://chromium-review.googlesource.com/835531 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#525246}
-
Kouhei Ueno authored
No behavioral change. Bug: None Change-Id: Ib45aa79a253d9ae2ad230f11b9b11b74dee4837d Reviewed-on: https://chromium-review.googlesource.com/833433Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#525245}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/aac382b3b65d..603d01e818ba $ git log aac382b3b..603d01e81 --date=short --no-merges --format='%ad %ae %s' 2017-12-19 myjang [presubmit] Use GerritAccessor in CheckChangedLUCIConfigs Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I7e072d9207ba087a0e5f513a5020be587b41ac8a Reviewed-on: https://chromium-review.googlesource.com/835489Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#525244}
-
Alice Boxhall authored
Bug: 560525 Change-Id: I9096609606dff3230ccaebfc763dc5ec43dc761a Reviewed-on: https://chromium-review.googlesource.com/764579 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#525243}
-
Kenneth Russell authored
This test in JavaBridgeBasicsTest has become very flaky on the android_n5x_swarming_rel trybot. BUG=795378 TBR=torne@chromium.org Change-Id: Ia25a2b3407634a8a926bf618d87c12c9686abd0c Reviewed-on: https://chromium-review.googlesource.com/835867Reviewed-by:
-
Andrew Grieve authored
This fixes pak files not being rebuilt when file IDs are shifted from <if>'ed out <part> files. Bug: 785576 Change-Id: I8cd0d6a4fa315b3c3a20a608a65083f2f9a9cc9b Reviewed-on: https://chromium-review.googlesource.com/834788Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#525241}
-
Eric Karl authored
Currently, management of outstanding compositor locks and timeouts is managed on ui::Compositor. We want to use this functionality on content::CompositorImpl as well, so this refactor lets us share code. TBR=sky@chromium.org for purely mechanical change (rename) in ash/rotator/screen_rotation_animator.cc Bug: 792120 Change-Id: I13665c1d9eec6a1822ab86baabfdf1bf66db5178 Reviewed-on: https://chromium-review.googlesource.com/834882 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#525240}
-
John Rummell authored
Generating the Storage ID requires a browser specific value. Update the GN files so that other embedders can provide the value through GN args. Also updates the build files to reference the internal file used by Chrome to provide the value when building official versions. BUG=478960 TEST=compiles with changed GN args Change-Id: Id14e32fb38c60e4d4112ab71500a98b79e3a6035 Reviewed-on: https://chromium-review.googlesource.com/812567 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#525239}
-
Mike Reed authored
Bug: Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ia8d81135c16606cbf32fe9275a954127e35c7550 Reviewed-on: https://chromium-review.googlesource.com/834714Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#525238}
-
Yuly Novikov authored
conformance2/textures/canvas_sub_rectangle/tex-2d-r11f_g11f_b10f-rgb-float.html conformance2/textures/canvas_sub_rectangle/tex-2d-rg32f-rg-float.html conformance2/textures/webgl_canvas/tex-3d-rgba32f-rgba-float.html deqp/functional/gles3/shadercommonfunction.html deqp/functional/gles3/shaderpackingfunction.html Removed existing Fail expectation for conformance2/textures/canvas_sub_rectangle/tex-2d-rg32f-rg-float.html on passthrough Win NVIDIA OpenGL, since the tests run validating CB. BUG=795030,794340 TBR=kbr@chromium.org,zmo@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9fe3675ac9aa0b68b7884273294dc1210ada4bad Reviewed-on: https://chromium-review.googlesource.com/835135 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#525237}
-
Austin Tankiang authored
Convert FrameHostMsg_CancelInitialHistoryLoad and FrameHostMsg_UpdateEncoding from the old IPC system to mojo. Bug: 786836 Change-Id: I80c250d7b086b34a2709c70d89b9ecce8e07ec75 Reviewed-on: https://chromium-review.googlesource.com/826829Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
-
Hiroshige Hayashizaki authored
They should be no longer used in Blink, as the spec update https://github.com/whatwg/html/pull/2991 removes the references them from the HTML spec. Bug: 763597 Change-Id: I515b12a36a8e6f97b72ef6695a05da2f89ecfa8e Reviewed-on: https://chromium-review.googlesource.com/802465 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#525235}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/c3532457d457..3789415eddd0 $ git log c3532457d..3789415ed --date=short --no-merges --format='%ad %ae %s' 2017-12-20 thestig Roll DEPS for clang to 8427dae2. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I912f6374a6104509f0bf1b7c091bdd3888cffe26 Reviewed-on: https://chromium-review.googlesource.com/835548 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#525234}
-
Darren Shen authored
Spec: https://drafts.css-houdini.org/css-typed-om-1/#transformvalue-normalization We currently fail tests because we haven't implement normalization of 'matrix()' and 'matrix3d()' yet. Bug: 788570 Change-Id: I0a8b02db6ecbdc863c117663e519548a8aa9957e Reviewed-on: https://chromium-review.googlesource.com/833427 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
-
smut authored
Bug: 795459 Change-Id: Iad2d5a81c6ea3fb6eb07884c03b52477a0ec7751 Reviewed-on: https://chromium-review.googlesource.com/831287Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#525232}
-
Hirokazu Honda authored
We are using a new VDA-like IPC defined in components/arc/common/video_decode_accelerator.mojom. Therefore, the codes with deprecated IPC are not used and run at all. This change removes these deprecated codes. TEST=CTS MediaTest on veyron_minnie and eve BUG=chromium:74547 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I2eab8bb90c4e7d0ac66abca6a5a0c9c26acadfa3 Reviewed-on: https://chromium-review.googlesource.com/826342Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fbec1952..ad7b878c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I5c7ebc57068784afe105fd985e8d0521308bc7eb Reviewed-on: https://chromium-review.googlesource.com/835036Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#525230}
-
Zhenyao Mo authored
This is a short term fix. Long term, we need to fix the underlying bug that in mus-viz mode, browser process doesn't talk to GPU process. BUG=796386 TEST=affected tests on chromeos bots R=piman@chromium.org TBR=pfeldman@chromium.org Change-Id: I8fe8e7cbe62c39f035b5ba6cf01b8f82b7d4e241 Reviewed-on: https://chromium-review.googlesource.com/835420 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
Caleb Rouleau authored
We don't care about the performance of these, so it's best not to run them at all. This change has two parts: 1. Split unoptimized tests into separate test cases so that they can be filtered separately. 2. Add the filter for them to the gn_isolate_map so that swarming jobs will filter them out. Bug: 767124 Change-Id: Ia7b9a44f202346aec051280043756ea5d1d716e7 Reviewed-on: https://chromium-review.googlesource.com/835354Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#525228}
-
Will Chen authored
I moved most of the test expectations attached to this bug to the MSANExpectations file since they're only flaky on the MSAN builder. A couple of them are actually flaky on multiple builders, so I've left them in TestExpectations. TBR=hbos@chromium.org Bug: 760543 Change-Id: Ia81745ac59a4e850dee96c868972fdfe9f6c1ff5 Reviewed-on: https://chromium-review.googlesource.com/835413 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Will Chen <chenwilliam@chromium.org> Cr-Commit-Position: refs/heads/master@{#525227}
-
David Tseng authored
- don't override next and previous object / line for single lined text boxes. Search+Left and Right are important to basic navigation. Test: added new BackgroundTest Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4491c63797cd250f2108d00d82c42cdfa300fdf5 Reviewed-on: https://chromium-review.googlesource.com/834691Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#525226}
-
Kenneth Russell authored
Was disabled on the non-Swarmed bot; needs to be disabled on the Swarmed one too. BUG=754875 TBR=zmo@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8b083708a4e67900711d87f5b28d5ee0ce4f624c Reviewed-on: https://chromium-review.googlesource.com/835653 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
-
Sergey Ulanov authored
Fuchsia test/exe runner was looking for symbols in exe.unstripped and lib.unstripped directories. Files in these directories are no longer generated, so the script would use outdated files left over from when they were generated. Cleanup the script to ignore these directories. Change-Id: Ic9d8ced326c3c2d83caf70e0ccea7df4af01c414 Reviewed-on: https://chromium-review.googlesource.com/834762Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#525224}
-
Ned Nguyen authored
These are not running anywhere, so they are just code debt. Change-Id: I30eacfefe6387a3ea9c6da2945260897d334dfc5 Reviewed-on: https://chromium-review.googlesource.com/833415Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#525223}
-
Leo Zhang authored
Add a ItemTouchHelper in the LanguageListBaseAdapter to support Drag&drop, and clean up some code. Tested on locale devices and emulator. Demo video link on Pixel, it shows how the "long-click" and "drag handler" works. https://googleo.users.x20web.corp.google.com/screenrecord/chrome/lang-settings-drag.mp4 Bug: 783049 Change-Id: Ibac2fd045036a3ae6974c9ffe08cc6231b57e65f Reviewed-on: https://chromium-review.googlesource.com/826884Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#525222}
-
Joel Einbinder authored
Compiling very large files (40mb) will crash DevTools Bug: 795363 Change-Id: I15108f3cc6b09daa3501782626dee734e3e3f049 Reviewed-on: https://chromium-review.googlesource.com/835416Reviewed-by:
-
Steve Kobes authored
This de-flakes compositing/iframes/iframe-composited-scrolling.html when root layer scrolling is enabled. Bug: 796335 Change-Id: Iec78032b48f90b9775dd6ef30826a0da0b328acf Reviewed-on: https://chromium-review.googlesource.com/834871 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#525220}
-
Aga Wronska authored
Show shelf on views based login screen. It requires initilizing shelf earlier when creating window. Move control over shelf visibility into ShelfWidget, because the visibility depends on session state and ash switches. It is no longer possible to control it only by parent container. This change will cause showing shelf on secondary display on login screen when views base login is enabled. See crbug.com/796239 for details. This change results in showing shelf with shutdown button only. It will be followed by update to status area and implementation of missing shelf buttons. Bug: 792656 Change-Id: I1281d661d62e71b99f5c607f6c90c831eb4d2414 Reviewed-on: https://chromium-review.googlesource.com/832919 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#525219}
-
Kurt Horimoto authored
The coordinator should stop observing the FullscreenController when its BrowserState is destroyed. Bug: 796152 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4f24c4a0d9f99cc66f67b85af678eff3da4a18fa Reviewed-on: https://chromium-review.googlesource.com/835430 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#525218}
-
Yuri Wiitala authored
Two fixes that ensure the captured video sizes are I420-format-friendly: 1. The oracle can propose odd-numbered width or height, since it is not aware of the pixel format restriction. This was causing a DCHECK() failure in media::ComputeLetterboxRegionForI420(). Thus, simply truncate the capture resolution to the next-lower even number. 2. CopyOutputResults can be truncated upstream, causing a result size that might be smaller than expected. Thus, ensure the frame content is letterboxed around the actual result, and done so at even-numbered pixel coordinates to avoid "blurred edging" effects. Bug: 754872 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ia5fb2a54cd87febc0be2f71c2878b24616b99e25 Reviewed-on: https://chromium-review.googlesource.com/833753Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#525217}
-
Renjie Liu authored
Bug: 76915 Change-Id: Ia0f05256c85eb67daae13c20b96a067a06cfb2ba Reviewed-on: https://chromium-review.googlesource.com/816574 Commit-Queue: Renjie Liu <renjieliu@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#525216}
-
edchin authored
ExternalAppLauncher should be a tab helper rather than a standalone object. This CL simply moves code. The tricky part is the memory management when moving from an Objective-C to C++ class. Note: ** Presubmit Warnings ** Some UMA_HISTOGRAM lines have been modified and the associated histogram name has no match in either tools/metrics/histograms/histograms.xml or the modifications of it: [ios/chrome/browser/web/external_app_launcher_tab_helper.mm:162] Tab.ExternalApplicationOpened Bug: 791792 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia3efce8dc4b80ef749ec539c67a13074cc31a6d8 Reviewed-on: https://chromium-review.googlesource.com/812425 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#525215}
-
Bill Budge authored
- Moves declaration to build/config/allocator.gni, so it can be imported to other components. Bug: chromium:756050 Change-Id: If1fd8383baf6ee576470a235b2e542ccc192505f Reviewed-on: https://chromium-review.googlesource.com/835270Reviewed-by:
-
Dominic Mazzoni authored
Instead of only using NativeViewAccessibility on some platforms, rename the base class ViewAccessibility and make it a general-purpose class for view accessibility code. Potential benefits of doing it this way: * View subclasses like Slider wouldn't need to add a special method like SetAccessibleName. Instead any client could override the name or any other property directly: view->GetViewAccessible().SetName(...); * Creates a means to share more code with AXViewObjWrapper. * Creates a way to have a single consistent ID for all Views, making relations between views easier. As a next step, these could be moved from View to ViewAccessibility, further simplifying view.h: HandleAccessibleAction(const ui::AXActionData& action_data); gfx::NativeViewAccessible GetNativeViewAccessible(); void NotifyAccessibilityEvent(ui::AXEvent event_type); Bug: 796350 Change-Id: I9676a362a45ed57629f3205f3b6c45ec695d9f23 Reviewed-on: https://chromium-review.googlesource.com/833221Reviewed-by:Trent Apted <tapted@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#525213}
-
Chris Cunningham authored
This is mostly a reland of https://chromium-review.googlesource.com/c/chromium/src/+/807604 with some improvements and now unblocked by changes to bots. Media layout tests need repair 1) Many tests check for proprietary codec support by only asking about "video/mp4" without specifying a codec. This check is busted because MP4 is no longer considered proprietary while codecs like H264 and AAC still are. We currently claim "video/mp4" is entirely unsupported via test hacks to avoid breaking those checks. 2) Some MSE tests focus on MP4 with H264. While many bots now have the needed codecs, we artificially remove their support via test-only hacks in order to keep expectations the same for all runners. This CL does the following 1) Remove incomplete checks for "video/mp4" - instead hardcode use of the .ogv files (preserving the existing behavior). 2) Update MSE mp4/h264 test expectations to PASS. Starting this week all webkit bots include the needed codecs. 3) Remove test hacks that artificially reduce codec support. It is also not a goal to make LayoutTests try all the supported codecs. That is covered by unit/integration tests. Due to 3) above, some external/wpt/media-source tests now fail because they select mp4. Fixing these failures is tracked in Issue 794338. TBR: dalecurtis@chromium.org, peter@chromium.org Bug: 327115,746579,787575,568704,794338 Change-Id: I8443d32fc9871c887d0009605cf8876521844916 Reviewed-on: https://chromium-review.googlesource.com/827649Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#525212}
-
