GitLab

This patch fixes the alignment so the text in the rows is properly vertically centered.

TBR=yoshiki@chromium.org
TEST=Run Files.app, select an item.
BUG=none

Review URL: https://chromiumcodereview.appspot.com/16168003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202818 0039d316-1c4b-4281-b951-d872f2087c98

This increases the minimum dimensions that ash uses when
detecting video for the purpose of preventing the screen
from being dimmed. It's unlikely that any given set of
numbers will be perfect here, but this may help avoid some
false positives caused by animated advertisements.

BUG=171456

Review URL: https://chromiumcodereview.appspot.com/16174002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202817 0039d316-1c4b-4281-b951-d872f2087c98

The comments on the SelectFile() method says it is safe to pass NULL to the arg params. However, this is not true on the Android implementation of the function, SelectFileDialogImpl::SelectFileImpl() for Android.

BUG=None

Review URL: https://chromiumcodereview.appspot.com/16082002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202816 0039d316-1c4b-4281-b951-d872f2087c98

AutofillDialogController is self-destroying on ViewClosed. Thus,
TestAutofillDialogController::runner_ is not available after ViewClosed,
and RunMessageLoop must live on the TestFixture instead, since it is
potentially run after the view has been closed (via controller->Hide)

BUG=234008
TEST=none
R=avi@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16054005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202815 0039d316-1c4b-4281-b951-d872f2087c98

Because the display scale factor and the window size are sent in two different
IPCs, and because the window size (ViewMsg_Resize) may be delayed (to avoid
spamming the renderer with resize messages while dragging), the renderer can
think it's using a different resolution than it is.

This merges the ViewMsg_ScreenInfoChanged and ViewMsg_Resize messages,
so that the renderer cannot not have a consistent view of the window size and
DPI.

BUG=239624

Review URL: https://chromiumcodereview.appspot.com/16048003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202814 0039d316-1c4b-4281-b951-d872f2087c98

This patch replaces line-height with padding to avoid an ugly, not centered selection.

TBR=yoshiki@chromium.org
TEST=Go to Files.app, edit a file.
BUG=239305

Review URL: https://chromiumcodereview.appspot.com/16007010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202813 0039d316-1c4b-4281-b951-d872f2087c98

If styles.xml has paddingStart and exists in values/, it will cause
crashes on Galaxy Tab&Note because style resources are not overrided by
the generated styles.xml (generate_v14_compatible_resources.py), which is to
avoid crashes on Galaxy Tab&Note (crbug.com/235118). So make
generate_v14_compatible_resource.py use styles.xml under values-v17/ not values/

BUG=243952

Review URL: https://chromiumcodereview.appspot.com/16125003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202812 0039d316-1c4b-4281-b951-d872f2087c98

This is a re-land of issue 14299011, which broke GLSurfaceGLX, in turn breaking Chrome Linux/Aura.

This CL changes WeakPtr in the following ways: 
* Changes thread-bindings semantics so that WeakPtrs only become bound when the first one is dereferenced, or the owning factory invalidates them. 
* Removes WeakPtrFactory::DetachFromThread. 
* Renames SupportsWeakPtr::DetachFromThread to DetachFromThreadHack.

Calling code changes to allow this: 
* Unnecessary use of SupportsWeakPtr removed from SGIVideoSyncProviderThreadShim.
* Unnecessary DetachFromThread() calls removed from PluginInfoMessageFilter, DhcpProxyScript[Adapter]FetcherWin and (Chromoting's) PolicyWatcherLinux.
* DetachFromThread() calls rendered unnecessary by change in binding semantics removed from IOThread, SearchProviderInstallData, RuleRegistryWithCache and GLSurfaceGlx. 

WebGraphicsContext3DInProcessCommandBufferImpl uses the re-named DetachFromThreadHack() - bug 234964 tracks work to remove that use. 

TBR=darin,awong
BUG=232143, 234964, 243914

Review URL: https://chromiumcodereview.appspot.com/16007009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202811 0039d316-1c4b-4281-b951-d872f2087c98

In particular, remove STATE_SEND_BODY,
STATE_SEND_BODY_COMPLETE, SPDY_WAITING_FOR_RESPONSE and
instead add logic to detect when we receive an out-of-place
response.

Fix tests that were using the wrong SpdyStreamType and
weren't using a delegate.

Add various TODOs.

BUG=243643
R=rch@chromium.org

Review URL: https://codereview.chromium.org/15892015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202810 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202809 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=True
TBR=peria@chromium.org

Review URL: https://codereview.chromium.org/15948004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202808 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242285
For ash delegate
TBR=jamescook@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15937008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202807 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=151288:151349&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/16122003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202806 0039d316-1c4b-4281-b951-d872f2087c98

The caller of GetOriginsForType should know the StorageType,
so this parameter will not add any information to the callback.
Historically this was useful when we'd used old callbacks.

BUG=220029
TEST=should not break existing tests

Review URL: https://chromiumcodereview.appspot.com/15925005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202805 0039d316-1c4b-4281-b951-d872f2087c98

Added 'error logs' tab.  For now, simply TranslateErrors::Type is logged.  More error details will be logged when we can get those from Translate API.

BUG=175967
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/15881006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202804 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244343
R=satorux@chromium.org

Review URL: https://codereview.chromium.org/15878006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202803 0039d316-1c4b-4281-b951-d872f2087c98

This patch adjusts the grid view's styles to match the recent specs by removing checkbox and making the label transparent. Along the way, the redundant border (from webui) has been hidden.

TBR=yoshiki@chromium.org
TEST=Go to Files.app, enter a directory with images. Switch to the grid view.
BUG=239288

Review URL: https://chromiumcodereview.appspot.com/15878007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202802 0039d316-1c4b-4281-b951-d872f2087c98

This patch does:
- Rename ValidateFileSystemRoot() to OpenFileSystem() to make it clearer
  what the method does (as the method is called in response to OpenFileSystem
  request from the renderer)
- Also change boolean 'create' parameter to an enum (OpenFileSystemMode)

BUG=243216
R=benjhayden@chromium.org, kinaba@chromium.org, tzik@chromium.org

Review URL: https://codereview.chromium.org/16043006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202801 0039d316-1c4b-4281-b951-d872f2087c98

Formats from Canon, Fuji, Minolta, Olympus, Panasonic, and Sigma.

BUG=165598

Review URL: https://chromiumcodereview.appspot.com/15875004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202800 0039d316-1c4b-4281-b951-d872f2087c98

BUG=243208
R=dbeam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15823004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202799 0039d316-1c4b-4281-b951-d872f2087c98

Original patch broke SelectFileAndOpen browser test. This is because Files.app
notify 'selection-change-complete' to the tests even if the selection is empty.
This CL is fixed the problem by adding a check of the number of selected items.

Previously reverted CL: crrev.com/15950003

BUG=243687
TEST=browser_tests

Review URL: https://chromiumcodereview.appspot.com/15808007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202798 0039d316-1c4b-4281-b951-d872f2087c98

http://i.imgur.com/VHG6Zbl.png

BUG=229102

Review URL: https://chromiumcodereview.appspot.com/15745022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202795 0039d316-1c4b-4281-b951-d872f2087c98

We're going to send this down after all so the page can properly match
Chrome's decision about whether what you've typed is an URL.

TEST=Manually with GWS change to deal with SWYT.
BUG=243201

Review URL: https://chromiumcodereview.appspot.com/15732014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202794 0039d316-1c4b-4281-b951-d872f2087c98

BUG=236781
TEST=browser_tests --gtest_filter='TranslateBrowserTest.*'

Review URL: https://chromiumcodereview.appspot.com/15680006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202793 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202792 0039d316-1c4b-4281-b951-d872f2087c98

AppShimHost is now confined to interacting with the app shim and passing
events to AppShimHandlers. ExtensionAppShimHandler becomes the default
handler for app shim events.

BUG=168080
TEST=There should be no behavior change with this refactor.

Review URL: https://chromiumcodereview.appspot.com/15269003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202791 0039d316-1c4b-4281-b951-d872f2087c98

Suspected to break Linux ChromeOS build
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/19953/steps/compile/logs/stdio

obj/ui/snapshot/test/snapshot_unittests.run_all_unittests.o:run_all_unittests.cc:function
main:error: undefined reference to
'ui::test::CompositorTestSuite::CompositorTestSuite(int, char**)'
obj/ui/snapshot/test/snapshot_unittests.run_all_unittests.o:run_all_unittests.cc:function
main:error: undefined reference to
'ui::test::CompositorTestSuite::~CompositorTestSuite()'


> Remove unnecessary ui::CompositorTestSupport
> 
> The ui::CompositorTestSupport class existed to initialize WebKit since
> ui::Compositor depends on cc which used to depend on WebKit being initialized
> to function properly.  cc no longer has this requirement, so this class is
> unnecessary.
> 
> R=piman, sky
> 
> Review URL: https://chromiumcodereview.appspot.com/14744016

TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/15838015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202790 0039d316-1c4b-4281-b951-d872f2087c98

The FakeVideoDecoder simulates a typical video decoder that could have some
decoding delays (to simulate out-of-order decoding). Since it's fake,
it does not care about what the input is. It always generate output frames
successfully but with a frame delay (specified in the ctor).

All callbacks passed to FakeVideoDecoder can be held if desired. This gives the
test class a chance to do some operation during pending callbacks.

BUG=141788

Review URL: https://chromiumcodereview.appspot.com/15085011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202789 0039d316-1c4b-4281-b951-d872f2087c98

The motivating force behind this change is we want to ping the first time
a generated password is used. If we need to keep information about first use,
we might as well keep total usage stats as it is an interesting UMA statistic 
as well.

Changes to the other PasswordStore implementations will be in separate CLs

BUG=240560

Review URL: https://chromiumcodereview.appspot.com/14811010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202788 0039d316-1c4b-4281-b951-d872f2087c98

The ui::CompositorTestSupport class existed to initialize WebKit since
ui::Compositor depends on cc which used to depend on WebKit being initialized
to function properly.  cc no longer has this requirement, so this class is
unnecessary.

R=piman, sky

Review URL: https://chromiumcodereview.appspot.com/14744016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202787 0039d316-1c4b-4281-b951-d872f2087c98

* Make worker observe the destruction of the thread where it does work. 
* Make work done signal a memeber of worker and set it when worker's working
  thread is destroyed so that syncer won't be blocked indefinitely on work
  that's not gonna run.
* Ref-count worker in session context so that worker remains valid when syncer
  is still iterating through workers but registrar has erased it from its worker map.
* Add RequestStop() and Stopped() to allow worker to return early when it's 
  stopped while waiting to run work on its working thread.

This cl by itself should have no real impact because the added functions are not used.

BUG=19757

Review URL: https://chromiumcodereview.appspot.com/14046031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202786 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239168,125846
R=jamescook@chromium.org,ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16070003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202783 0039d316-1c4b-4281-b951-d872f2087c98

BUG=244464
TEST=trybots
R=oshima@chromium.org

Review URL: https://chromiumcodereview.appspot.com/15960013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202782 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239282
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/15670008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202778 0039d316-1c4b-4281-b951-d872f2087c98

IdleActionWarningDialogView uses Widget::CreateWindow. 
Use DialogDelegate::CreateDialogWidget instead. 
See before/after pics at http://crbug.com/166075#c106
Trigger with debug code in Patch Set 1.

BUG=166075
TEST=Idle action warning dialog does not have an extra border. 
R=derat@chromium.org

Review URL: https://chromiumcodereview.appspot.com/16032008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202777 0039d316-1c4b-4281-b951-d872f2087c98

This was initially introduced to get ExternalFileSystem's
local mount root path, but accessing MountPointProvider
from lower-layer FileUtil module looks ugly.

This patch:
- Deprecate FileSystemMountPointProvider::GetFileSystemRootPathOnFileThread
- Add FileSystemOperationContext::root_path() instead for passing root path

BUG=241701
TEST=Moved tests from content_unittests:FileSystemMountPointProviderTest.*
 to content_unittests:SandboxMountPointProviderTest.*

R=bauerb@chromium.org, michaeln@chromium.org, tzik@chromium.org

Review URL: https://codereview.chromium.org/15959006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202776 0039d316-1c4b-4281-b951-d872f2087c98

Testing shows we can allow for much lower buffer sizes on WASAPI,
OSX, and PulseAudio clients.  In most cases, this change brings those
clients down to the nearest multiple of 512.  WaveOut and ALSA clients
will use the nearest multiple of 2048.

Based on testing done in https://codereview.chromium.org/14570002/

BUG=162207
TEST=Using these buffer sizes for HTML5 audio works without glitching
when an AudioConverter is in the graph.

Review URL: https://chromiumcodereview.appspot.com/14573006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202775 0039d316-1c4b-4281-b951-d872f2087c98

The original name was redundant.

BUG=242121
TEST=none
R=hashimoto@chromium.org, jhawkins@chromium.org

Review URL: https://codereview.chromium.org/15650008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202774 0039d316-1c4b-4281-b951-d872f2087c98

We are converting gesture's timestamp to microseconds at many
places (e.g. for latency measure). So let's not truncate the
timestamp to milliseconds level when creating the event.

BUG=243443
TEST=None.

Review URL: https://chromiumcodereview.appspot.com/16159007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202773 0039d316-1c4b-4281-b951-d872f2087c98

This structure would be useful in ui/surface, which can't depend on cc/.

BUG=

Review URL: https://chromiumcodereview.appspot.com/14999012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202772 0039d316-1c4b-4281-b951-d872f2087c98