- 18 Jun, 2019 14 commits
-
-
jorgegil@google.com authored
PointerTest.IgnorePointerEventDuringModal was passing when it shouldn't have been. These change fixes it with correct assertions and splits it into three separate and more clear test scenarios. Bug: 973693 Test: exo_unittests Change-Id: Icd9b95a8634ff47cb12ae55208229d9a15c69fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658840 Auto-Submit: Jorge Gil <jorgegil@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#669920}
-
Malay Keshav authored
This patch performs multiple tasks: - Removes redundant license information from js file. - Fixes unicode characters to be ascii when minifying. - Updates the README to give the correct minification parameters. - Add BUILD.gn file Bug: 958684 Change-Id: I7f39cd22f081fcdae6f463ba7da2364e425986b2 TESTED: Build chrome os locally with lottie Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663379Reviewed-by:
-
Nicholas Hollingum authored
This cl adds the templating engine which is used to generate the proto and the harness used by the fuzzer. The templater uses Jinja2 and has a .gni wrapper for ease of use in our build system. I have confirmed that the fuzzer has more coverage than the prototype in crrev.com/c/1640526, however it requires further work to improve the coverage to the desired levels. Bug: 961564 Change-Id: Ie27d7ff0b97cf3ed88dadfebf4d977682054c699 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645134Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#669918}
-
Sergey Ulanov authored
Without format ClientNativePixmap cannot verify that the handle it received is valid. Bug: 957314 Change-Id: I387c6d7e43feb9e129a6e84313494c175bf6ed71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661059Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#669917}
-
tby authored
This is the V2 model for query-based mixed-types ranking. For experimentation purposes V1 has been kept also, and the instantiation of one, the other, or neither, is controlled by finch parameters. Bug: 931149 Change-Id: I4ecdbfc98dfed330a6e7406b33e89171838170c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661317Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#669916}
-
Alex Danilo authored
Fix stale comments that referred to PanelEntry objects, which are now called PanelItem. Fix/update Closure annotations. Bug: 947388 Change-Id: Ic9945e0c160723c9d38867fd22a47d9cff521d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657517Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#669915}
-
Sergey Ulanov authored
Two fixes for AudioOutputStreamFuchsia: - Don't call Play() until after the first SendPacket() call as is required by the AudioRenderer interface. - Add padding to min_lead_time_ for the first packet, to reduce the chance that samples at the beginning of the stream are dropped. Bug: 974029 Change-Id: If2dc43a3df7d671a42f7983dea130fa3b10ad1ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659230 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#669914}
-
Peng Huang authored
Without those two extensions, vulkan validation layers will report errors Bug: None Change-Id: I1117fc03c3d322b3e51955591fea13b4db247a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662836Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#669913}
-
Andrew Lee authored
This is a small bug which is caused by this CL merged yesterday (https://chromium-review.googlesource.com/c/chromium/src/+/1636889). This error occurs because DCHECK(!property_trees->needs_rebuild) fails. While we try to drag elements on the dom tree UI, the property trees need to be updated again, hence property_trees->needs_rebuild = true. We can easily avoid this error by only calling GetRenderSurfaceReason() when rebuild is NOT required. Bug: 973092 Change-Id: Ifdb49d7e81d32f6bcff73662ef34f0118d4abf50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650640 Commit-Queue: MyungJae Lee <myungjaelee@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Jon Mann authored
This field is now only shown under the "Network" details pane. Bug: 924246 Change-Id: Ibdd6d722d26792a2ab108392721ae88a0abb2fb6 Screenshot: https://screenshot.googleplex.com/24ayhPiZrWw.png Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663076 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#669911}
-
Noel Gordon authored
DriveFs shipped and it reports Team Drive modification time: show that time in the file list. Bug: 867153 Change-Id: I8569e90687ef22f6d67ef8ae032aa80d21acb09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660302Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#669910}
-
Min Chen authored
Bug: 937907 Change-Id: I33f0fab2b6c2147994c8ec64c9bdd142bea71d06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662988 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#669909}
-
sczs authored
Previously we were simply updating the BadgeUI, but the backing variable for the badge state wasn't being updated. Updating the badgeState also triggers an Update of the UI per line 171. Bug: 972113, 911864 Change-Id: Iaff8d95bde53df319ef957d8ad27040610b8f89f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648664Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#669908}
-
Taylor Bergquist authored
Bug: 974647 Change-Id: Iaa6d037b15d47ad9cf3f1b7537b4439c3f53c037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663018 Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#669907}
-
- 17 Jun, 2019 26 commits
-
-
Charlene Yan authored
This reverts commit 1158f5ef. Reason for revert: This is an experimental reland since this broke older mac waterfall bots. This was fixed with https://chromium-review.googlesource.com/c/chromium/src/+/1649313 Original change's description: > Revert "Add ability to drag tabs between pinned and unpinned tabs to modify the" > > This reverts commit 91948560. > > Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/38757, consistent failures on mac of the following tests: > TabDragging/DetachToBrowserTabDragControllerTest.DragToPinEnabled_DragToUnpinInNewWindow/0 > TabDragging/DetachToBrowserTabDragControllerTest.DragToPinInNewWindow/0 > > Original change's description: > > Add ability to drag tabs between pinned and unpinned tabs to modify the > > pinned state. > > > > Bug: 965681 > > Change-Id: I4cebf850839a1fdbee702ab2cd3c2fccbdba811e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637045 > > Reviewed-by: Bret Sepulveda <bsep@chromium.org> > > Commit-Queue: Charlene Yan <cyan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#666796} > > TBR=bsep@chromium.org,cyan@chromium.org > > Change-Id: I0a68811b31c718fcdccba6058ab6bdf664a1547a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 965681 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649316 > Reviewed-by: Armando Miraglia <armax@chromium.org> > Commit-Queue: Armando Miraglia <armax@chromium.org> > Cr-Commit-Position: refs/heads/master@{#667042} TBR=bsep@chromium.org,armax@chromium.org,cyan@chromium.org Change-Id: Ia1521f2c2443c40a3b2ac55be079c6e1be91dea2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 965681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648899 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#669906}
-
Matt Falkenhagen authored
It's expiring and we're not watching it. Bug: 972778 Change-Id: Icbf74f6f2af28557b8b30db23e2268fe144f2ba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661327 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Auto-Submit: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#669905}
-
Maksym Onufriienko authored
This is part of EG1 to EG2 migration, which involves moving EarlGrey code from app-side helpers into test code. EarlGrey2 has multiprocess architecture, where Chrome Test and Chrome App are separate processes. Chrome App can be launched with specific feature flags. Chrome Test should be able to query the value of specific flags from Chrome App. Chrome Test can't use base::FeatureList::IsEnabled(), because base::Feature value is not in sync with Chrome App. This CL builds infrastructure for Chrome Test to query value of specific flags from Chrome App. As `base::FeatureList::IsEnabled` won't compile under EG2, added C_E_G methods that will just call ChromeEarlGreyAppInterface methods: - (BOOL)[ChromeEarlGrey isSlimNavigationManagerEnabled] - (BOOL)[ChromeEarlGrey isCompactTranslateInfobarIOSEnabled] - (BOOL)[ChromeEarlGrey isBlockNewTabPagePendingLoadEnabled] - (BOOL)[ChromeEarlGrey isUmaCellularEnabled] - (BOOL)[ChromeEarlGrey isUKMEnabled] - (BOOL)[ChromeEarlGrey isWebPaymentsModifiersEnbaled] # Require for ios_intertnal/external_url_omnibox_popup_egtest.mm # https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/1357283 - (BOOL)[ChromeEarlGrey isNewOmniboxPopupLayoutEnabled] As there is no way to pass `base::Feature` parameter to ChromeEarlGreyAppInterface, its methods will be 1:1 match to E_C_G, e.g. BOOL isSlimNavigationManagerEnabled { return [ChromeEarlGreyAppInterface isSlimNavigationManagerEnabled]; } Bug: 922813 Change-Id: I8da1e3fa318ca3de8ad40c4df3cf181c6aa7845d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639138 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#669904}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b9797b31f7a1..468585d96747 Created with: gclient setdep -r src-internal@468585d96747 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: I5b5bec47ab53d213bd5b43870a87820cb5508343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663269Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669903}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/076b7f778883..d7003576dd13 git log 076b7f778883..d7003576dd13 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 absl-team@google.com Googletest export 2019-06-17 misterg@google.com Googletest export 2019-06-17 gennadiycivil@users.noreply.github.com Merge pull request #2287 from PhilLab/patch-1 2019-06-17 gennadiycivil@users.noreply.github.com Merge pull request #2286 from gennadiycivil/master 2019-06-14 misterg@google.com 2019-06-14 misterg@google.com googlemock/docs/CookBook.md small doc test 2019-06-13 misterg@google.com Makefiles are no longer supported. Adding pseudo-break with their impending removal to make sure that people who are interested will notice 2019-06-13 misterg@google.com Merge pull request #2285 from tomalakgeretkal:c++17-fix 2019-06-13 misterg@google.com Merge pull request #2283 from xammy:cmake-cmp0054 2019-06-12 misterg@google.com Formatting Changes 2019-06-12 misterg@google.com Formatting Changes, README 2019-06-12 gennadiycivil@users.noreply.github.com Update README.md Created with: gclient setdep -r src/third_party/googletest/src@d7003576dd13 The AutoRoll server is located here: https://autoroll.skia.org/r/googletest-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official TBR=isamsonov@google.com Change-Id: I4bbd9fba95f9b08e1519d46ffd0d1d08eeb2a97c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662027Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Staphany Park <staphany@chromium.org> Commit-Queue: Staphany Park <staphany@chromium.org> Cr-Commit-Position: refs/heads/master@{#669902}
-
Nick Diego Yamane authored
DesktopWindowTreeHostX11 includes/uses ATK code even when it is configured to be disabled, causing build failures in those cases. This patch fixes it. Additionally, CL fixes lint include_what_you_use errors. Change-Id: Ifbb616b5083869b4c3c7632be60799940535e45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656888Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#669901}
-
chrome://device-logReilly Grant authored
This change replaces VLOG(2) with BLUETOOTH_LOG(DEBUG) in some of the Windows 10 backend for Bluetooth Low Energy. It also improves log detail in BluetoothGattDiscovererWinrt by logging the service and characteristic handles for which errors are being reported. Bug: 969180 Change-Id: I9e0bddfa6d02a7fc20b1c1190b2f9bce06ef132d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650623Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#669900}
-
Jacques Newman authored
The ignored reasons were not being used, so no need to ask. Bug: 972643 Change-Id: Iccb3fa6b4760094719a51b0131e1a1f0514f4b75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659598Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Jacques Newman <janewman@microsoft.com> Cr-Commit-Position: refs/heads/master@{#669899}
-
Jason Majors authored
Bug: 971718 Change-Id: I0531f63b7276d7c061bbab613a4b055ee89acc9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660630 Commit-Queue: Jason Majors <jmajors@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#669898}
-
Caroline Rising authored
When keyboard navigating the tab strip on Mac pane_has_focus is not set to true so key events were hiding the tab hover cards when they shouldnt have been. This change instead ignores hiding cards on when updating the hover card if the tab strip or one of its children (excluding the new tab button) has focus. Bug: 910739, 974896 Change-Id: I306543684f448fa3e4ceac0f346a5b833f334b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650213 Commit-Queue: Caroline Rising <corising@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#669897}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/08b5629336d0..3f8975e121c5 git log 08b5629336d0..3f8975e121c5 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 dongja@google.com Debug: suppress INFO log level in tests 2019-06-17 jmadill@chromium.org Vulkan: Minor cleanup to ContextVk::setupIndexedDraw. 2019-06-17 jonahr@google.com Clean up workarounds/features to single location. 2019-06-17 tobine@google.com Merge ESSL pre-processsor token errors 2019-06-17 syoussefi@chromium.org Vulkan: Enable previously failing clear tests Created with: gclient setdep -r src/third_party/angle@3f8975e121c5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:971660 TBR=jonahr@google.com Change-Id: I90ab5c64dcfb55f6251270407d4db55af5a3f426 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663048Reviewed-by:
-
Tommy Steimel authored
This CL adds a new toolbar icon for the global media controls. The icon only shows up once a controllable media session becomes active. The icon never disappears once it's displayed. This CL also adds a new disabled-by-default feature flag for the global media controls and only creates the icon when the flag is enabled. Bug: 973485, 973486 Change-Id: Ibd6379d45c736918873504d76761170fa57b825e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1655345Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#669895}
-
David Grogan authored
LevelDBEnv.IDB.LockFileAncestorsNotFound LevelDBEnv.ServiceWorker.LockFileAncestorsNotFound LevelDBEnv.LockFileAncestorsNotFound Bug: 969973 Change-Id: Ie8f55d5ad09fe00e63e95681c2781283a822281c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663036Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Sergey Ulanov authored
Previously AudioOutputStreamFuchsia was starting playing before receiving the first OnMinLeadTime. As result it was starting playback with an invalid min_lead_time value, which may result in some samples being dropped. Now it waits for the first OnMinLeadTime event before pumping the first audio buffer. Bug: 973754 Change-Id: I47e828120c392b1ddb2f7d7a74422bf05c8aa43c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658951Reviewed-by:
-
Piotr Bialecki authored
This fixes plane detection sample when running w/o WebXRHitTest. Change-Id: Ic48751677a1e1d2aef702513346993909f783bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663314 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Auto-Submit: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#669892}
-
Matt Reynolds authored
Affected histograms: * Gamepad.KnownGamepadConnectedWithId * Gamepad.UnknownGamepadConnected BUG=969919 Change-Id: I4b7bbd12d0f86cc201591ab2733949fb5f3b5870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657549Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#669891}
-
Jinsuk Kim authored
This CL reverts a change made about gesture navigation navigation bubble dimension in https://crrev.com/c/1650205. Since it is not a touch target, doesn't have to be as big as explained in the CL for a11y. Bug: 974633 Change-Id: I5b1a36b6c2d166f0964caae039f98f67458f6c5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663228Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#669890}
-
Sean Topping authored
More content::WebContentsObserver logic has been moved into CastWebContentsImpl in order to reduce interal //content dependencies. Merge-With: eureka-internal/271377 Bug: internal b/120675407 Test: CQ, Play media on display Assistant Change-Id: If537c4155afe48858a14f4468af8744861440250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604043Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#669889}
-
Reilly Grant authored
This change passes along the test parameter to the serial_test function so that web_tests/serial can use promise_rejects instead of custom logic to check for errors. Bug: 884928 Change-Id: I9e3705e1d62c62bc87562478ada38d62a6bdf3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661043Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#669888}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/8b2600f715e5..2a888de1db05 git log 8b2600f715e5..2a888de1db05 --date=short --no-merges --format='%ad %ae %s' 2019-06-17 google-shaderc-autoroll@skia.org Roll third_party/glslang def9662348b0..9db72785beb3 (1 commits) (#721) 2019-06-17 google-shaderc-autoroll@skia.org Roll third_party/spirv-cross 4104e363005a..146dc453bcec (2 commits) (#722) 2019-06-17 zoddicus@users.noreply.github.com Manually roll DEPS to get past test failure (#717) Created with: gclient setdep -r src/third_party/shaderc/src@2a888de1db05 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: Icc54c2f6c3111b7a0572b64c036ed109037e309a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662948Reviewed-by:
-
wutao authored
This is a clean up cl to add a specific DISALLOWED_BY_KIOSK_MODE type. Bug: 973197 Test: manual Change-Id: Ie7e2d8f8ddc310fbf8c5d4aa07be4f76bfc26747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658939 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#669886}
-
Jon Mann authored
On settings rows which have a toggle and link to a sub-page, the area around the toggle is no longer a click target. This prevents accidental navigations which attempting to flip the toggle. Bug: 917328 Change-Id: I546e34b7814706ceee14b4e75ef991d5c9ef03c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658711Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
-
Josh Karlin authored
What: Label async tasks as ad or not. Why: So that the AdTracker knows if a running task is due to an async task registered while ad script was on the stack. How: Modified the async probes to take a AsyncTaskId* instead of a void*. The AsyncTaskId* stores the bit of whether ad script was on the stack at the time of creation. This is *much* better than the previous approach (https://crrev.com/c/1291232) in that there are no memory leaks, no extra map lookups, and we don't have to worry about cancelasynctask being called. It does require a modification to all probe locations to hold a AsyncTaskId member. Bug: 851531 Change-Id: I92e25b3ab3b8746611c3a3f9a9a7265bab4a601e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648886 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#669884}
-
Michael Thiessen authored
The body can't be unfocused, so we shouldn't report that it can be, and in any case unfocusing the body would not be useful. Bug: 968157 Change-Id: Ie77bedeef0a70084eea1344d6c69ee3daaed916e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661069Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#669883}
-
cassiezhang authored
So that the filter file can take in effect. Bug: 957284 Change-Id: I07118f06cdc346d81da47f0b7fd564e94b5d9767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661000Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Cassie Zhang <cassiez@google.com> Cr-Commit-Position: refs/heads/master@{#669882}
-
Jessica Tallon authored
Problems with the kTextChanged event that were fixed: 1. The events were being emited after the selected item changed. Thus the screen reader could get and present stale information to the user. 2. The events were being emitted for all six Omnibox items each and every time the user inserted or deleted any text. While emitting the event for all six Omnibox items is arguably technically correct, it is functionally not helpful. When the user is typing in the Omnibox, the screen reader will typically only present changes to the Omnibox. Thus these events are just noise to the screen reader. To address both issues, remove the call from SetMatch and add it to OnSelected immediately before ax::mojom::Event::kSelection gets emitted. Also add emitting of kSelectionChildrenChanged event to Omnibox to notify when a selection has occurred. Bug: 896706 Bug: 952272 Change-Id: I3b77c00159da40ee1ce7d5fcaf235e3a1bc31420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596671Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Jessica Tallon <jtallon@igalia.com> Cr-Commit-Position: refs/heads/master@{#669881}
-
