GitLab

Treat a header block with a pseudo-header field following a regular one as
malformed, as required by HTTP/2 draft-14 Section 8.1.2.1.

This lands server change 74067938 by bnc.

BUG=400336

Review URL: https://codereview.chromium.org/531253004

Cr-Commit-Position: refs/heads/master@{#293534}

BUG=352654

Review URL: https://codereview.chromium.org/547653002

Cr-Commit-Position: refs/heads/master@{#293533}

It should be refreshed but it was not by bug. This patch fixes this.

BUG=none
TEST=manual
TBR=fukino@chromium.org

Review URL: https://codereview.chromium.org/543103002

Cr-Commit-Position: refs/heads/master@{#293532}

depends on blink CL https://codereview.chromium.org/540033002/

TBR=jochen

Review URL: https://codereview.chromium.org/545513002

Cr-Commit-Position: refs/heads/master@{#293531}

The parentheses were wrong previously in this if-statement:
if ((wcsstr(str_ptr, L"(VFW)") == NULL) &&
     lstrlenW(str_ptr) < name_length ||
    (!(LowerCaseEqualsASCII(str_ptr, str_ptr + name_length,
                                   kGoogleCameraAdapter))))
The condition lstrlenW(str_ptr) < name_length should be grouped with the condition LowerCaseEqualsASCII(...), not wcsstr(str_ptr, L"(VFW)") == NULL.

The check lstrlenW(str_ptr) < name_length is redundant, so I removed it.

Review URL: https://codereview.chromium.org/541603002

Cr-Commit-Position: refs/heads/master@{#293530}

BUG=405449
TEST=Forced WebRtcAudioCapturer::Initialize() to return false and verified log.

Review URL: https://codereview.chromium.org/545203002

Cr-Commit-Position: refs/heads/master@{#293529}

1. Add retry to http_client.
2. Make Findit more robust for unrecognized chromium revision.
3. Workaround a harmless bug in python 2.7
4. Give a better error message for check failure.

NOTRY=true

Review URL: https://codereview.chromium.org/538383002

Cr-Commit-Position: refs/heads/master@{#293528}

BUG=410446
TEST=manual. launch webstore app from home card.

Review URL: https://codereview.chromium.org/544813002

Cr-Commit-Position: refs/heads/master@{#293527}

TBR=schenney@chromium.org

Review URL: https://codereview.chromium.org/544173002

Cr-Commit-Position: refs/heads/master@{#293526}

Chromium is only using a Service Provider, and not an Application. Moreover
chromium should only depends on mojo_base.gyp, not mojo.gyp.

R=darin@chromium.org,davemoore@chromium.org,blundel@chromium.org

Review URL: https://codereview.chromium.org/531513003

Cr-Commit-Position: refs/heads/master@{#293525}

The code that copies cookies set by a SAML IdP on subsequent logins is
wrong as it uses a method which modifies the cookie being copied by
prepending a dot to the domain name. This CL fixes the problem by
switching to the method that is used during initial login. The method
is also renamed to make it clearer that it may be used on subsequent
logins too.

BUG=410416
TEST=unit_tests updated to detect this problem

TBR=dbeam (wallet_signin_helper_unittest.cc)

Review URL: https://codereview.chromium.org/538543003

Cr-Commit-Position: refs/heads/master@{#293524}

BUG=410891
TBR=henrika
NOTRY=true

Review URL: https://codereview.chromium.org/542173002

Cr-Commit-Position: refs/heads/master@{#293523}

NWVM was using the ScopedCaptureClient to attach a capture controller. The problem with this is that the window manager already made one, and there is only one capture controller when you use SCC and this was screwing with event dispatch as coordinate systems between the different root windows were different (not sure this is a condition we've ever really designed for in aura). Anyway. Made NWVM use DefaultCaptureClient directly.

R=sky@chromium.org
BUG=

Review URL: https://codereview.chromium.org/541013002

Cr-Commit-Position: refs/heads/master@{#293522}

Review URL: https://codereview.chromium.org/536533004

Cr-Commit-Position: refs/heads/master@{#293521}

BUG=380349

Committed: https://chromium.googlesource.com/chromium/src/+/bbb7ea7c66f18298079eea4a6b24834986f4a822

Review URL: https://codereview.chromium.org/479873002

Cr-Commit-Position: refs/heads/master@{#293520}

It used to work after my previous fix 37accc2c, but then it broke again.
This CL changes the way how "-I" arguments are transformed.

BUG=NONE
TEST=manually
NOTRY=true

Review URL: https://codereview.chromium.org/528293002

Cr-Commit-Position: refs/heads/master@{#293519}

Per RFC 4122 section 4.4, the format of GUID version 4 must be
xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx, where y is one of [8, 9, A, B].
This CL updates base::GenerateGUID() on POSIX to be compliant with the
GUID v4 format.

This fix is proposed by Alex Vakulenko <avakulenko@chromium.org>

BUG=None
TEST=base_unittests

Review URL: https://codereview.chromium.org/541633005

Cr-Commit-Position: refs/heads/master@{#293518}

Extract ResultCatcher from ExtensionApiTest. Use it in ShellApiTest, which is separated out from AppShellTest.

Move the remaining DnsApiTest to app_shell_browsertests.

BUG=388893

Review URL: https://codereview.chromium.org/529293003

Cr-Commit-Position: refs/heads/master@{#293517}

Currently interactive UI tests typically call `ClickOnView` to transfer
focus. On Mac, the behaviour of a click changes when an application
loses focus, and re-activating the application in a test is not
reliable. The test application shouldn't be losing focus in
interactive_ui_tests, but tracing suggests this is ocurring anyway.

This CL introduces ui_test_utils::FocusView which is a more robust way
to transfer focus in a test.

OmniboxViewTest.BeginningShownAfterBlur is changed to use
ui_test_utils::FocusView and re-enabled.

BUG=406012

Review URL: https://codereview.chromium.org/534993002

Cr-Commit-Position: refs/heads/master@{#293516}

https://chromium.googlesource.com/chromium/blink/+log/e76e0d3c27477b816754225fcdbcae5c79f6940f..dcd4f892fb78a6f808982633fbc7398714f157be
TBR=arv@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/544073002

Cr-Commit-Position: refs/heads/master@{#293515}

Make ExtensionManagement listening to preference changes.

Move all functionality of admin_policy into StandardManagementPolicyProvider, the latter was essentially a wrapper over admin_policy before.

Merge admin_policy_unittest into extension_management_unittests with minor changes.

BUG=177351
TEST=ExtensionServiceTest,ExtensionManagementTest,ExtensionAdminPolicyTest

Review URL: https://codereview.chromium.org/500043003

Cr-Commit-Position: refs/heads/master@{#293514}

Instead of posting input and compositor tasks directly to the
main thread message loop, forward them to the Blink scheduler
so they can be prioritized over other tasks.

BUG=391005

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290845

Review URL: https://codereview.chromium.org/363383002

Cr-Commit-Position: refs/heads/master@{#293513}

As side effect, this APIs will also be available for the app_shell.
The patch also removes the dependence this API has on the g_browser_process
and thus, no longer will depend on chrome/.

BUG=392842

Review URL: https://codereview.chromium.org/389633002

Cr-Commit-Position: refs/heads/master@{#293512}

Cr-Commit-Position: refs/heads/master@{#293511}

To support unbundled updates we need to stop depending on system
libraries. Disable using the system version of ICU and instead link
Chromium's copy.

This increases binary size by ~7MB.

BUG=409851

Review URL: https://codereview.chromium.org/541753002

Cr-Commit-Position: refs/heads/master@{#293510}

Previously, Android's enhanced bookmarks feature depended on
--manual-enhanced-bookmarks flag and nothing else. But the
correct way is to use UpdateBookmarksExperimentState function's logic,
which desktop has been using.

BUG=386785

Review URL: https://codereview.chromium.org/497563002

Cr-Commit-Position: refs/heads/master@{#293509}

Folloup to https://codereview.chromium.org/537993002/

BUG=410824

Review URL: https://codereview.chromium.org/545173002

Cr-Commit-Position: refs/heads/master@{#293508}

Re-introduce screen manager

BUG=231331
R=ygorshenin@chromium.org

Review URL: https://codereview.chromium.org/539483002

Cr-Commit-Position: refs/heads/master@{#293507}

TBR=jarin@chromium.org

Review URL: https://codereview.chromium.org/546743002

Cr-Commit-Position: refs/heads/master@{#293506}

While working on issue 410276, in particular in
https://codereview.chromium.org/542733002/ , I had to update the
tracing cache backend. Why? Does anyone use it?

Let's remove it instead.

R=pasko@chromium.org,clamy@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/544923002

Cr-Commit-Position: refs/heads/master@{#293505}

BUG=400684

Review URL: https://codereview.chromium.org/451633007

Cr-Commit-Position: refs/heads/master@{#293504}

This is our first attempt, mostly to feel this out.  Performance and
correctness problems are both possible.  Please revert this if a benchmark even
smells funny.

That said, we've been working on this a while, are pretty confident it's good
stuff, and have had Skia's internal testing entirely switched over for a week.
Parts of Chromium that serialize and deserialize SkPictures are already
switched over.  This CL finishes things off by switching the default
recorded-from-scratch SkPicture to use SkRecord too.

BUG=408985,409110,409138

Committed: https://chromium.googlesource.com/chromium/src/+/f7450daaf38f4951b23fabaaaf659c6af33a705c

Committed: https://chromium.googlesource.com/chromium/src/+/5f2a6ab31313eb2fc6e456f65c3863a77d2d0c30

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg;tryserver.chromium.linux:linux_browser_asan

Committed: https://chromium.googlesource.com/chromium/src/+/130033d6c732af90ed117f05517e4efffd23ae58

Review URL: https://codereview.chromium.org/504823003

Cr-Commit-Position: refs/heads/master@{#293503}

This should hopefully fix
BUG=410839
TBR=rnk@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/540313002

Cr-Commit-Position: refs/heads/master@{#293502}

These attributes are gone:
https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#service-worker-container

Blink: https://codereview.chromium.org/541943003/

BUG=404982
TEST=content_unittests --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py --debug http/tests/serviceworker/

Review URL: https://codereview.chromium.org/544023002

Cr-Commit-Position: refs/heads/master@{#293501}

This is required for CL, https://codereview.chromium.org/456413002, to run webkit_unit_tests on android.
In subsequenct CL from blink side, https://codereview.chromium.org/542003002, we should extend the android.py to start sending this file to the
device under test.

R=jochen@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/544903003

Cr-Commit-Position: refs/heads/master@{#293500}

The name is used to retrieve a service from a ServiceProvider.

R=ppi@chromium.org

Review URL: https://codereview.chromium.org/540913003

Cr-Commit-Position: refs/heads/master@{#293499}

This change completes the removal of package_name from
build/java_apk.gyp and removes it from all the places
which still refer to it.

'package_name' used to be how you specified the intermediate
directory when building an APK. Now we use the target name and
includers no longer need to set the intermediate directory
explicitly. However one use in java_apk for setting additional
resources files seems to have crept through the refactoring.

BUG=405963

Review URL: https://codereview.chromium.org/487223003

Cr-Commit-Position: refs/heads/master@{#293498}

When the last profile is deleted, a new one is created automatically.

BUG=410008

Review URL: https://codereview.chromium.org/532963004

Cr-Commit-Position: refs/heads/master@{#293497}

My idea was that the histogram could show if we do a very large number of short
calls and how the length of the streams are related to the length of
AudioTracks. If so, we might have issues in WebRTC clients or in how we
create/destroy the input streams.

BUG=405449
TEST=Manual testing using WebRTC clients.

Review URL: https://codereview.chromium.org/537573002

Cr-Commit-Position: refs/heads/master@{#293496}

Move the include of the Mac TargetConditionals.h file to after we've
checked if we're building for Android. Apparently this file doesn't
exist on all macs used to build android and the rest of android builds
fine without it, so including it there causes the build to fail. It
appears to only be used to test TARGET_OS_IPHONE which will never be
true on android.

BUG=

Review URL: https://codereview.chromium.org/538563002

Cr-Commit-Position: refs/heads/master@{#293495}