- 22 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1ff270d3e636..1dccfa608557 2020-06-22 tvanderlippe@chromium.org Do not run coverage by default for Karma 2020-06-22 yangguo@chromium.org Remove local path in SVG metadata 2020-06-22 alexrudenko@chromium.org DevTools: define source title for mutable stylesheets 2020-06-22 changhaohan@chromium.org Fix adorner text center issue If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1094723,chromium:946975 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I6f83c28b822f88a2f1618e7366252c23ad0a88a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257052Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780751}
-
Michael Achenbach authored
The builder is setting release gn args, but uses V8 in debug mode. After args.gn was included in the web tests isolate, a check started failing, flagging release GN args on a debug builder. This change attempts to run webtests as in release mode but with a debug out directory. We'll rename the builder in a follow up to be less confusing. No-Try: true Bug: v8:10626 Change-Id: Id79d8717917ca6a23e391f16cc40efd3544a915f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255078 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780750}
-
Nohemi Fernandez authored
This patch ensures that all code in Chrome iOS is now using the new sign-in architecture. Bug: 971989 Change-Id: Ib9b1732196b4a0deba2f676723eaa320d6935569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251828Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#780749}
-
Swapnil authored
ExtensionInstallEventLogUploader class is an adapter between the system that captures and stores extension install event logs and the policy system which uploads them to the management server. This will be used in event based reporting for extension events. Bug: 1092836 Change-Id: I1f948b9a8809647ff1b23011b1560886296f5ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246153Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#780748}
-
harrisonsean authored
Safety check is rolling out on desktop and we are now bringing it to iOS. This CL makes a new entry point for safety check in chrome settings behind a flag. Bug: 1078782 Change-Id: I41c1d940b97554071d6365d1711fcc2d7a1f5a92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2187572Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Cr-Commit-Position: refs/heads/master@{#780747}
-
Robbie Gibson authored
WebKit already blocks IndexedDB access from cross-origin iframes. Chrome cannot override that block to enable access. Fixed: 1087871 Change-Id: I748458bee5aa3e857c280ef6b8418172bf2301d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252146 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#780746}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be2b0d66..1e731d42 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I134deed4854facc24ac2313d8709efb73c3ed58a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257338Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780745}
-
Alexander Dunaev authored
All histograms for drag and drop (names starting with Event.DragDrop) have expired. This CL removes them. Bug: 1094775 Change-Id: I87f0da859c97e38803d5f964b5d2389a71f8cb9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252800Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Cr-Commit-Position: refs/heads/master@{#780744}
-
Clemens Backes authored
The finch experiment launched, and the respective flag is flipped on ToT. Hence the field trial is not needed any more. R=bcwhite@chromium.org Bug: 1040030, 1040061 Change-Id: I2d59163e7135a8d40405748a6ce00800acf1d0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252247Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#780743}
-
Morten Stenshorne authored
This was almost working correctly even without this fix, because we currently just brutally break inside a block that overflows if there are no breaks inside, losing any trailing margins. The only problem currently, is that such a break still produces a break token, so that the broken block would resume in the next fragmentainer (even if there's nothing left to lay out), producing no content there, but an empty fragment would create a break opportunity that shouldn't really be there. This was a problem both for regular block containers and fieldsets. This CL fixes that. It's also a problem for column spanners if they participate in an outer fragmentainer context, but we have some underlying issues there, so I just added a TODO. The -001.html test wouldn't even fail without this CL, but as I'm working on fixing the aforementioned brutal breaking, I felt we need slightly better test coverage. The new function AdjustedMarginAfterFinalChildFragment() is extremely simple, and the amount of code duplication it prevents is negligible (or even non-existent). Still, it seems reasonable to provide this function, for the sake of visibility, as this is something that all algorithms need to implement, if they want to get block fragmentation right. Bug: 829028 Change-Id: Ide568f6eaad38cd07e3cfc164bb97745a751fbb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252042 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#780742}
-
Joel Hockey authored
Change UpdateApplicationList to use vm_type to filter sending PluginVm to observers. TBR=nancylingwang@chromium.org Bug: b/158617133 Change-Id: I3c642292b324bf3c0173dc533793130ab3bc2756 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256112 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#780741}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592779386-bb1cede23bbe73907e4b0976414d7537cb5b6999.profdata to chrome-win64-master-1592815711-e36a86e9145f6f12f52b2c83c2feb91a9eebc962.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Idce2b4c6ddd8f9f6c1b6ead6d97465805c709c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257049Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/95c1f4261555..fc7f25ba95db 2020-06-22 abennetts@google.com Manual clustering of bq_rows export (split output into 1 table per master). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC nuskos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1094148 Tbr: nuskos@google.com Change-Id: I2c2402ea65f0f2d043e0a6c026de24babb6ee1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257048Reviewed-by:
-
Anatoliy Potapchuk authored
This reverts commit c7067b96. Reason for revert: the test started failing on linux-chromeos-chrome First failure: https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/6508 Original change's description: > Enable fast file loads for chrome://media-app. > > This cl changes the way we load files such that > 1. we load a single file, after this users can interact with the app. > 2. we asynchronously load every other related file in that directory, > will update the app when it is done. > > Notably: > * adds a way to register observers to AbstractFileList > * adds a way to add files and notify observers to ReceivedFileList > * adds IPC to 'load-extra-files' > * adds `processOtherFilesInDirectory` & `globalLaunchNumber` which > keeps loads in sync > > Existing tests provide a lot of coverage for the new codepaths, however > there are edge cases such as loading the first file then doing one of > the following > 1. invoking launchable IPC i.e. rename > 2. invoking non launchable IPC i.e. delete / save > 3. start an edit (or another action) changing the UI > > This cl adds tests for 1 & 2. > in the case of 1, we have a token `globalLaunchNumber` to make sure > only the most recent load is fulfilled. > in the case of 2, we load files as normal as the previous focus file is > now removed from the file system. > > 3. is handled internally in cl/317047655 > > Bug: b/158043802, 996088 > Change-Id: I23e05efa1ffb9c720a116f63e06ca8565dcc7539 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249266 > Commit-Queue: David Lei <dlei@google.com> > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780696} TBR=tapted@chromium.org,dlei@google.com Change-Id: Id656591a03b9ad337b210f7e7ae17a8af7a80d31 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/158043802, 996088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257319Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#780738}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. TBR=kenrb Bug: 1031540 Change-Id: Ifbee7d4d7a4f1e226ada4d3cff0f5220c51cd4af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254604 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#780737}
-
Ewann authored
This CL rephrases strings related to Chrome Guard. Bug: 1063824 Change-Id: I7ac2525015e754fb169c4923dd81c50996aa8d02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252341Reviewed-by:
-
Jan Wilken Dörrie authored
As a follow-up to r775075 this change introduces a Windows version of string_number_conversions.h, which contains wide string overloads that are only exposed on Windows. In order to facilitate code sharing with the regular string number conversions, this change also adds string_number_conversions_internal.h. Furthermore, it performs some small clean-ups to simplify the template logic and rely on more automatic type deductions. Bug: 911896 Change-Id: I0ed8f8b73b8b78ccbe3a762b04a021c7b2a60ec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231142 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#780735}
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. TBR=jorgelo,meacer Bug: 1031540 Change-Id: Iaa243f8ff7ccfd865f26b765606314c453b90329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254665 Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#780734}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/b97d7669bc7b..adacba3ee921 2020-06-22 johnkslang@users.noreply.github.com Update README.md If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: Ia859b74eb1a8e9259b635d34191aa34f43e973b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257047Reviewed-by:
-
Takashi Sakamoto authored
Instead, use defined(ARCH_CPU_64_BITS) && !defined(OS_NACL). Bug: 1086388,1073933 Change-Id: I66d2214f46e4cf77e391548e780b451869163d60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251573 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#780732}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b85a296d6a61..1ff270d3e636 2020-06-22 mathias@chromium.org Fix typo in link to triage guidelines 2020-06-22 patrick.brosset@microsoft.com Enable the no-return-assign ESLint rule 2020-06-22 petermarshall@chromium.org Update CDP If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1084558,chromium:1093379 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie326de87cbea0e1664d7327a5fce6996ebf00ed7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257045Reviewed-by:
-
Maksim Sisov authored
This patch adds usage of ozone platform in //chrome. It's not possible to use linux wrapper [1] for everything as it may introduce circular deps and other problems. Plus, there are many places that are guarded either by single USE_X11 or USE_OZONE. Thus, use the IsUsingOzonePlatform feature flag to choose the correct path. [1] https://crrev.com/c/2250106 ----- Please note that this ugliness is added temporarily and will be removed as soon as use_x11 is removed (hopefully by Q1 2021 depending on how the finch trial goes). Please also note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. ---- Bug: 1085700 Change-Id: I01653d42a448e708bc772ac2ec4aa64dd3f178b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250066 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#780730}
-
Matthias Körber authored
This CL relaxes the requirements to import a profile. If no address \ profile could be imported from a form section, the import is performed on the union of all sections. Change-Id: Id366c8acc5ab98deb130c592dad507ef7f4cf5c5 Bug: 1097692 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254603 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#780729}
-
chrome://signin-reauthAlex Ilin authored
chrome://signin-reauth needs to display different strings depending on ReauthAccessPoint parameter. Callers pass this parameter to SigninReauthUI as a URL query parameter. chrome/browser/signin/reauth_util takes care of generating a corresponding URL and reading an encoded parameter from in. Bug: 1045515 Change-Id: Ib83ca63cf179fe04a58ba889d8ad0629d54df688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254144 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#780728}
-
Austin Tankiang authored
Bug: 1091104 Change-Id: I966d7e4eab4522f506f08349fa442fd6b0d32ad5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230380Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#780727}
-
Anatoliy Potapchuk authored
The test suite has been increasingly flaky recenly. Example failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/89791 Bug: 1090931 Change-Id: I27dc58e06232cf513f53714a299ffea1b8d5bf08 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256181Reviewed-by:
-
Stephen Nusko authored
nexus 5x webview This test flakes 10% of the time due to a timeout. See bug for details. Bug: 1097719 Change-Id: Idfccd2c1839e302781b35d7bcf0c23dcb1ceb532 No-Try: True TBR: johnchen@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255474Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#780725}
-
Marc Treib authored
Typically, PasswordAutofillAgent (unsurprisingly) shows its popup only if it has password suggestions. However, if the feature EnablePasswordsAccountStorage is enabled, then sometimes the popup needs to be shown even without password suggestions, because it might contain other entries. However, PasswordAutofillAgent didn't know if such other entries actually exist, and so would show the popup "speculatively". If it later turned out that there actually aren't any entries to show, the popup would get suppressed later (in PasswordAutofillManager). That's all well and good, but it produces a bad interaction with (non-Password) AutofillAgent: If PAA says it wants to show a popup, then AA suppresses its own popup. Together, this led to some cases where neither of the two popups showed up. This CL fixes the issue by explicitly informing PAA whether it should show its popup even without suggestions. This bit is passed as a new parameter in the existing InformNoSavedCredentials() IPC. (If there *are* saved credentials, then PAA will always show its popup, so no need to change anything about the FillPasswordForm() IPC.) Bug: 1096521 Change-Id: Id4cafc3e0190dd1d20ad266bc1d7e39f32f83b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252241Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#780724}
-
Tim van der Lippe authored
In DevTools, we want to write Node scripts as part of our Ninja action scripts. That's because we are more familiar with Node than with Python. However, since Ninja only allows Python scripts to be a script of an `action`, we were previously forced to write Python. This change allows the `third_party/node/node.py` script to be used as if it was a regular `node <script args>` invocation. As a result, we can use this script as part of a Ninja action as follows: ``` action(target_name) { script = "//third_party/node/node.py" args = [ "path/to/my/node/script.js", "--any-arg", anyValueForArg, ] } ``` We were previously already using this in DevTools itself, but that requires a Node checkout in `third_party/devtools-frontend/src/third_party/node`. To make sure that a build in Chromium is possible as well, we need to reference the absolute path to `//third_party/node/node.py` and thus requires the same file to exist in Chromium itself. Additionally, the script would now fail with the exitcode as defined by the invoked Node script. Lastly, this CL reformats the script according to the Python formatting standard. Bug: 1096473 R=jacktfranklin@chromium.org,dpapad@chromium.org CC=devtools-reviews+blink@chromium.org Change-Id: Ie11150475d4d32c9dc9e8ec18228d490239ff7c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248568Reviewed-by:dpapad <dpapad@chromium.org> Reviewed-by:
-
Hans Wennborg authored
If the file just needs the CHECK/CHECK_OP/NOTREACHED macros, use the appropriate header for that instead. Or if logging.h is not needed at all, remove it. This is both a nice cleanup (logging.h is a big header, and including it unnecessarily has compile-time costs), and part of the final step towards making logging.h no longer include check.h and the others. Bug: 1031540 Change-Id: I053fb6f7fc1cb03ba43abceba93274f12f2c395f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254124 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
-
Olivier Robin authored
We report URLs for the latest 3 WebStateLists that had activity. Preload WebState count as a separate WebStateList. Bug: 1060658 Change-Id: I035a192de232ce9e9ce6ae864dbf57c8bdc051f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238933 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#780721}
-
Anastasiia Nikolaienko authored
HandleNavigationButtonClicked was used only on Chrome OS and was triggered when user clicked "back" button. Remove this method from handler and navigate back when "back" button is clicked, instead of calling the handler. Bug: 1096007 Change-Id: If4992670fd03b23439be95650fd3a2a1551e5853 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247889Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#780720}
-
Anatoliy Potapchuk authored
Example failure: https://ci.chromium.org/p/chromium/builders/ci/linux-trusty-rel/12878 Change-Id: I024fe697bce0a6e4cfad7953b76958fdfd6dc3ce No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256180Reviewed-by:
-
Victor Hugo Vianna Silva authored
This is a reland of a89d80c4 Reason for reland: One of the upstream CLs had missing .js extensions in some imports, this caused failures later and then all CLs in the chain were reverted. TBR=aee@chromium.org Original changes's description: > This CL addresses a few design issues with PasswordListItem that predate > the introduction of PasswordsListHandler. > > - PasswordListItem would refer to a "menu" even though it knows nothing > about such menu, which is actually provided by the embedder. This CL > replaces mentions to passwordMenu in the component with what it actually > represents: the "more actions" button. > - The event fired by clicking the button was not documented in the file > overview. Moreover, the typedef for the event lived in the embedder. Now > the file exports the typedef. > - Tests that simulated clicks on the button would use the $$('#id') > syntax instead of the $.id one. This is now fixed. > > Bug: None > Change-Id: Ie815237134236468c639e73831bdb3eb7db36f98 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248561 > Commit-Queue: Victor Vianna <victorvianna@google.com> > Reviewed-by: Friedrich [CET] <fhorschig@chromium.org> > Reviewed-by: Esmael Elmoslimany <aee@chromium.org> > Cr-Commit-Position: refs/heads/master@{#779777} Bug: None Change-Id: I1a1db35efab745c7b5cb2893d153f6c643e3bbe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254321Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b772a955e70c..0cc3a37881a2 2020-06-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 545d158a2ff9 to d4b9f576ebb4 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: Ib29c51559917802a5db1bfc481fbc082b49d7750 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257042Reviewed-by:
-
Mahmoud Gawad authored
Made untrusted.html create a Dedicated Web Worker. BUG=b:158119679 TEST=added browsertest to test WebWorker is working (PASS) Change-Id: I52a84135215b1cae028d3865af762d3ddb2cf44c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232401Reviewed-by:
Oleh Lamzin <lamzin@google.com> Commit-Queue: Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#780716}
-
arthursonzogni authored
Patch [1] switched from RFH::is_active() toward RFH::IsCurrent(). We re-learnt this is possible for a RenderFrameHost to be pending deletion while being the "current" RenderFrameHost. This can happen when its frame is detached. [Bug] is caused by receiving DidFocusFrame() on a RenderFrameHost pending deletion (is_active() == false), but current (IsCurrent() == true). This caused a crash later. Patch [2] showed 100% of the crashes in [Bug] were explained by [1]. This patch revert all the is_active() -> IsCurrent() changes from [1]. It also revert the instrumentation [2]. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2186641 [2]: https://chromium-review.googlesource.com/c/chromium/src/+/2252803 [Bug]: https://crbug.com/1093943 Bug: chromimum:1093943 Change-Id: If5cd5774a0f6fd7d0c77de96286f88649627a0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255603Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#780715}
-
Joel Hockey authored
Bug: 1097596 Change-Id: I5bc30e9964f811041cc98bdbcba1d39bc2a2af85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256939 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#780714}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1592798309-f2bcf0f33aab857d8bcffdd4e0dd372aeeedf408.profdata to chrome-win32-master-1592808845-5ecd6c23d23a299e7b02af052540dc3d30072113.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I9801ad9b38fcaa16c8e1cbec5430700f4d701258 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257043Reviewed-by:
-
lijunsong authored
This changeset restores tests for UsernameDetector. The tests were removed in 1814832 along with the old parser. Bug: 1090694 Test: run the added tests Change-Id: I1de631de9943e975dfabaf4e9bc995de3cd7a252 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239105Reviewed-by:
-
