- 14 Apr, 2020 40 commits
-
-
Tetsui Ohkubo authored
In the standard Wayland protocol, null should be allowed for the icon argument of wl_data_device::start_drag. However, when nullptr was passed to the |icon| of DragDropOperation, ScheduleStartDragDropOperation would never be called, because couter_ assumed the icon was always present. This CL fixes that issue. TEST=manual BUG=b:64963392 Change-Id: Ibb504096c31ed6e0048c6fcf7038190db9498fd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143177 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#758708}
-
Toby Huang authored
For supervised users, the kNewVersionApprovalGranted bucket in the SupervisedUsers.Extensions UMA histogram is only supposed to increment when an already-installed extension gets a version update. Currently, the enum increments every time the supervised user enables and disables the extension. This CL fixes the accuracy of this UMA metric. Moreover, SupervisedUserService::UpdateApprovedExtensions() currently gets called every time the extension is re-enabled. This operation is unnecessary and expensive because the function iterates over the entire map of approved extensions. This CL prevents this unnecessary operation from happening. Bug: 1068438 Change-Id: I521fca2bbb3d0bc83744d74e8d9abeb427864bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138637 Commit-Queue: Toby Huang <tobyhuang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#758707}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6bed80858d3b..d9e072e138e6 Created with: gclient setdep -r src-internal@d9e072e138e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: I5dd78a00c1c44f2e86d69508917ed73e1e7332c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148209Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758706}
-
Lei Zhang authored
Pros: Consistent naming, smaller chance of naming conflict, can be forward declared. Cons: More casting required. Change-Id: Id2b11b1ebefe7fabaa03cb59edb39a77ce0c8b74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145955Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#758705}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I512bee0dbb638ce8d64f462bc0a4558c1801b1d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148165Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758704}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/e6e9fec904b8..5bc1f981df4d git log e6e9fec904b8..5bc1f981df4d --date=short --first-parent --format='%ad %ae %s' 2020-04-14 dhoss@chromium.org Add a helper to copy a ByteString to a buffer 2020-04-13 thestig@chromium.org Remove third_party/yasm from DEPS. 2020-04-13 thestig@chromium.org Roll third_party/libjpeg_turbo/ ce0e57e8e..7e3ad7980 (4 commits) 2020-04-13 thestig@chromium.org Add third_party/nasm to DEPS. 2020-04-13 thestig@chromium.org Fix nits in the DEPS file. 2020-04-13 tsepez@chromium.org Remove some needless locals from cxfa_ffwidgethandler.cpp 2020-04-13 tsepez@chromium.org Observe pagview across JS invocation in cpdfxfa_page.cpp Created with: gclient setdep -r src/third_party/pdfium@5bc1f981df4d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1069700,chromium:766721 Tbr: pdfium-deps-rolls@chromium.org Change-Id: I2ec868838e528a83adbec69b7b1f1e00448e91eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148166Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758703}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I3057ee2bbc3c37113c3a7bf02d5b4cb7ab4fa276 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147928Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758702}
-
Filip Gorski authored
This reverts commit 8dc3a74c. Reason for revert: Consistent failures on Android bots: https://ci.chromium.org/p/chromium/builders/ci/android-arm64-proguard-rel https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel Original change's description: > Add pixel browser tests for focus rings > > Focus rings are rendered differently on different platforms, and the > platform specific differences are currently untested because layout > tests force a platform-agnostic focus ring rendering code path. This > browser test is needed in order to run the platform specific code. > > These tests need to be interactive_ui_tests because the window needs > dedicated focus in order to make the focus rings show up consistently. > > A similar test was added in the content layer in > http://crrev.com/c/1969772 > > Bug: 1038425 > Change-Id: I84ce398ab5d782e657cc13d0e073bf9997056bff > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986972 > Commit-Queue: Joey Arhar <jarhar@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Mason Freed <masonfreed@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758587} TBR=sky@chromium.org,masonfreed@chromium.org,jarhar@chromium.org Change-Id: I804ffbeaee91c663e9bd93380e8edf7ea3aa21fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1038425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148472Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#758701}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e5287caf..834c6893 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I98dc51d47e487a6e6f31e9de735feeebb0d65cd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148082Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758700}
-
Fergal Daly authored
DevToolsExtensionTest.HttpIframeInDevToolsExtensionPanel crashes when RenderDocument is set to subframe. Bug: 1064944 Change-Id: I6a17a389a15ee20b10b4ed87f4378842bee13ab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145737Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#758699}
-
Christopher Cameron authored
This is currently called on the IO thread, and is causing crashes. It may be that this call can only been made on the UI thread. Bug: 1067367 Change-Id: Iffb0c9d11f2c7fb6e9dcb496e7babe314a8f4232 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143532Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#758698}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ieff7cc34e070645c825b7e36aef9b58d42eb77e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148170Reviewed-by:
-
Keishi Hattori authored
Remove UntracedMember from WorkerAnimationFrameProvider::offscreen_canvases_ and use the safer WeakMember Bug: 1058341 Change-Id: I62f43a79641eb43fe9c10aedd304e5789760425c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087871Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#758696}
-
John Z Wu authored
Removes code needed to clean up data. This is no longer needed because transport only mode will clean it up for us. Bug: 1056416 Change-Id: I14ac5f6d07238f4bbcb100428cda433e5a4e53b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145540 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#758695}
-
James Cook authored
https://chromium-review.googlesource.com/c/chromium/src/+/2126408 changed the "cros-default-button-color" from blue to grey. However, the side nav menu and update completed checkmark icon depended on that color to be blue. Change them to use cros_default_icon_color_prominent, which is the same blue as they used to be. Before fix: http://screen/D1rKP59xeQ9 http://screen/wpSK6N7b348 After fix: http://screen/Tf3Mtb6KqMi http://screen/KAkaA5TGA5r NOTE: There are still references to --cros-default-button-color in crostini_upgrader/app.html. These may also need to be fixed. I'm just not sure how to spawn that UI to check. Bug: 1070423 Change-Id: I73e2bf0f98b0df5e4d6c3f36e25de5bfe9a95e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148251 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#758694}
-
Tim Van Patten authored
The test type-conversion-test.html is flaky for linux also. Bug: angleproject:4555 Change-Id: Ia693a35aa99c5a362b9f164fc64f06639b1fb53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148278 Commit-Queue: Tim Van Patten <timvp@google.com> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Tim Van Patten <timvp@google.com> Cr-Commit-Position: refs/heads/master@{#758693}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Iba865525431ae576871cfa6040d80e18e42084d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143184Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b0f7984519b7..3b8d1780b324 git log b0f7984519b7..3b8d1780b324 --date=short --first-parent --format='%ad %ae %s' 2020-04-14 jalyn@microsoft.com Fix mac-only enter key regression Created with: gclient setdep -r src/third_party/devtools-frontend/src@3b8d1780b324 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1070143 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib5aa722f3941cac8cfda9874bfcbb1fb33a66955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148205Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/32457326e052..dee4d7a54e44 git log 32457326e052..dee4d7a54e44 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 cclao@google.com Vulkan: Early fragment tests optimization Created with: gclient setdep -r src/third_party/angle@dee4d7a54e44 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I9175c3eb2f6749ce8a01b0c16ac2b68bbd22ae53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148203Reviewed-by:
-
Katie D authored
Bug: 1055150 Change-Id: I74fdfd76923d58e3133c80f88de59efb86daaa78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144869 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#758689}
-
Zain Afzal authored
cl/303855538 will add a save copy function to the clientAPI delegate, this CL adds the chromium side code to implement this function. The save copy delegate function simply prompts the user to pick a file location, dumps a provided blob into the file specified, then relaunches the media app with this new file. Bug: 996088, b/141587270 Change-Id: I97b253fbffa9e1efb75448c98d41c3cee893bf19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134028 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#758688}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e03aa465. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" c53a40f4 "Update size.attributes.parse.trailingjunk" 86131ac4 "Add a test for ReplaceTrack that verifies video track content." 380347e7 "[css-masking] Migrate clip-path-columns-svg-clippath-usou.html to WPT" 2f3bb77d "[device-orientation] Upstream web tests to WPT" 9e22b2c7 "[css-flexbox] Move negative-flex-rounding-assert.html to WPT" 67963d34 "[css-flexbox] Move negative-margins-assert.html to WPT" d53acfce "[css-grid] Migrate positioned-grid-items-crash.html to WPT" 5ec29e3e "[css-grid] Migrate grid-tracks-stretched-with-different-flex-factors-sum.html to WPT" 03a85d57 "[client hints]: Properly apply persisted accept-CH policy in 3P context" f064e48f "Make will-change: backdrop-filter a containing block for fixed and abs" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I222651efc5dd98fc5f88404fcdc013bf8689fc14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147956Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#758687}
-
Sergey Poromov authored
The check is redundant because it's checked previously that the user is affiliated that implies that they are managed. Also chromeos::ProfileHelper::Get()->GetProfileByUser() doesn't return the Profile if it's not finalized and as SafeBrowsingPrivateEventRouter is now created during Profile initialization it doesn't work. Bug: 1069588 Change-Id: Ia4edd715a223688852f643ee2b28b9b9a4d4e354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144178Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#758686}
-
Kenichi Ishibashi authored
These methods are wrappers of corresponding methods defined in ServiceWorkerStorage. Added test patterns come from ServiceWorkerStorageTest.StoreUserData with minor modifications. Bug: 1055677 Change-Id: I6615ff14d10cb7302db7d388363672839998f633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142879 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#758685}
-
Yuki Yamada authored
Adds ResetWithReason() and set_disconnect_handler_with_reason() to HeapMojoRemote so that it can handle custom reason of connection error. Bug: 1049056 Change-Id: I6ee8bfb5e0620f4598270ce9c0dde3effb9dba1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145388 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose, and renames it to position-relative-with-scrollable-with-abspos-crash.html. Bug: 1063749 Change-Id: I138ff2b27b90fbbdbf84c2292c469b757a9350cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145416Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#758683}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4034bbc78ebeb68fe7f19fc1883a0c64453ce268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148207Reviewed-by:
-
My Nguyen authored
window_shell_id is added in candidate_window_view in https://crrev.com/c/685497. Its usage is removed in https://crrev.com/c/1600630, however the attribute is left there. suggestion_window_view is copied from candidate_window_view so it has the same extra code. No_Bug: Cleanup Change-Id: I761a4bb7c137e1778604d31cc31b59d7e934d6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143014Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#758681}
-
David Munro authored
See comment and https://bugs.chromium.org/p/chromium/issues/detail?id=1068914 for details, this seems necessary for sliders within and without cr-dialog to work correctly with touchscreens. Test: Use a WebUI slider, os settings slider and os settings inside a dialog slider, check all work. Bug: chromium:1068905 Change-Id: I07497b81857725b6eef907fda6f936ed3b89c606 Change-Id: Ib12f13bdb8e93e7f1fbe847e24a6c3159413c3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141993Reviewed-by:
-
Taylor Brandstetter authored
Bug: chromium:1069962 Change-Id: Ib86fde34b8b9d9e0065ef153ae2807533321ed79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146139Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Taylor <deadbeef@chromium.org> Cr-Commit-Position: refs/heads/master@{#758679}
-
Gyuyoung Kim authored
This CL moves stretch-table-child.html test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT styles, adding links to the relevant specs, and test description. Additionally, this CL sets a background color to 'first' selector for the manual test. Bug: 1063749 Change-Id: I20655a51cc6fc6462bf4f0aba361e8f9a05d095b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132899Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Xing Liu authored
This CL adds a prefetch image API to image loader. Must be called in reduced mode. In reduced mode, currently it can't start utility process to decode image, so we need to use the correct image fetcher api to do prefetch. Bug: 1058534 Change-Id: Iaed251b2cf2760fbca154b14db6f6c8e4840e52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146304 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Hesen Zhang <hesen@chromium.org> Cr-Commit-Position: refs/heads/master@{#758677}
-
bttk authored
RecordHistogram now works when native is not loaded. Bug: 1069507 Change-Id: I856d509c8b217eea5149adccfb0c28603249a920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148119Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#758676}
-
My Nguyen authored
It wasn't working properly because I forgot to add handling of SuggestionStatus::kBrowsing enum. Bug: 1068855 Change-Id: I0e96f0ab4ab587a80d26d022c1a1e415ea1b6c0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141479Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b8b3f5ffc0ea..e6e9fec904b8 git log b8b3f5ffc0ea..e6e9fec904b8 --date=short --first-parent --format='%ad %ae %s' 2020-04-13 asweintraub@google.com Add new FPDF_LoadMemDocument64 API for PDFium. 2020-04-13 tsepez@chromium.org Allow modifiers for keycode events in .evt files. 2020-04-13 tsepez@chromium.org Make UnownedPtr<> interoperate more transparently with raw pointers. Created with: gclient setdep -r src/third_party/pdfium@e6e9fec904b8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I35630ba61bf49fa84c1ae1886eea8c7ba7adc721 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148192Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/449545fd382b..6bed80858d3b Created with: gclient setdep -r src-internal@6bed80858d3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC xhwang@google.com,yutak@google.com,rhalavati@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024586 Tbr: xhwang@google.com,yutak@google.com,rhalavati@google.com Change-Id: I0e8936171c471fbfd2b6d3d78593c3514833fd28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148196Reviewed-by:
-
David Tseng authored
This change: - makes both CommandHandler.onCommand and ChromeVoxBackground.setPref do the same thing when changing sticky mode. This is with the one exception of CommandHandler calling through to SmartStickyMode (since it is a user command vs other call sites that simply update the pref). - Makes one small fix in SmartStickyMode; not all trees mark an editable root (e.g. Android, views). RELNOTES: n/a Change-Id: I5d0a4bc9626c0a885b350df8515aa42f3553a69a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148121 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#758672}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ac2a401164e1..297fffa4987b git log ac2a401164e1..297fffa4987b --date=short --first-parent --format='%ad %ae %s' 2020-04-13 dproy@chromium.org Add origin trial token for tests Created with: gclient setdep -r src/third_party/catapult@297fffa4987b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1021137 Tbr: sadrul@google.com Change-Id: I5f5ac3a206c0b043847f93ee0de38c0aa4560a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148197Reviewed-by:
-
Nate Fischer authored
WebView team is still monitoring URL scheme metrics to understand WebView usage. We intend to do so indefinitely (until we decide there's a better way to understand WebView usage), so this extends the metrics a year into the future, per guidance. Fixed: 1063899, 1063898 Test: N/A Change-Id: I01c86904cbb0dea9363d7c0546b2419df557ae28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148157 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#758670}
-
John Lee authored
This CL is the first CL of many to replace the settings-box class with a cr-row class, which will allow the removal of settings-box and the use of the --cr-section mixin. This CL proposes examples of a few changes: - Replace .settings-box-text with .cr-padded-text. The name is clearer of what it does and the class may be used with other .cr-row instances. This also allowed us to remove .two-line/.three-line classes unless explicitly used to make one-line rows appear taller. - Replace .start with .flex. It looked like .start was used primary to make a child of .settings-box stretch. .flex achieves the same goal and does not have any position-related info in its name, so it is more flexible in that it can be used in other positions (like a child in the middle). - Replace .middle with .flex or .cr-row-gap, for the same reasons as above. Bug: 973674, 686905 Change-Id: I0532bef08769f9fe2e1aec1d034d0f94b29f8ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144429 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#758669}
-
