GitLab

BUG=458355
TEST=
Make sure the new avatar menu flag is enabled.
1. Open a Chrome instance with 0 or 1 available profiles.
2. Right click on the User Menu button.
3. Nothing should be displayed.
4. Open the User Manager and add some profiles until there are at least 2.
5. Right click on the User Menu button
6. The fast user switcher should display a list of profiles that can be switched to.

Review URL: https://codereview.chromium.org/944563002

Cr-Commit-Position: refs/heads/master@{#318063}

Hopefully this addresses the scope errors the server was logging.

BUG=none

Review URL: https://codereview.chromium.org/957603002

Cr-Commit-Position: refs/heads/master@{#318062}

- the speech queue was clearing the current utterance _after_ executing end callbacks; end callbacks themselves could have generated new utterances, so this cleared the new utterance rather than the previous "current" ones.
- remove overriding of onEvent by output.js.
- update continous read test.

TEST=chromevox_tests --run-manual passes.
BUG=461824

Review URL: https://codereview.chromium.org/955643006

Cr-Commit-Position: refs/heads/master@{#318061}

The status column isn't always visible.  Account for that when attempting to update table elements.

BUG=461723

Review URL: https://codereview.chromium.org/952893008

Cr-Commit-Position: refs/heads/master@{#318060}

Patch in 65ee89744bc1fbb9461f26d83e08243068cb212b that fixes comparison
between opaque and non-opaque type (i.e. whether or not the contents of
the structure is known at the point of compilation).

https://github.com/carllindberg/ocmock/commit/65ee89744bc1fbb9461f26d83e08243068cb212b

BUG=459013

Review URL: https://codereview.chromium.org/958613003

Cr-Commit-Position: refs/heads/master@{#318059}

Revert of Revert of ServiceWorker: Use scheduler's default task queue for posting tasks on main thread (patchset #1 id:1 of https://codereview.chromium.org/954993002/)

Reason for revert:
Test is still flaky, even after reverting this one. For instance

http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%281%29/builds/53768

Original issue's description:
> Revert of ServiceWorker: Use scheduler's default task queue for posting tasks on main thread (patchset #1 id:1 of https://codereview.chromium.org/958523002/)
>
> Reason for revert:
> Highly speculative revert after views_unittests broke on win7:
>
> http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/35660
>
> c:\b\build\slave\win_builder__dbg_\build\src\ui\views\accessibility\native_view_accessibility_win_unittest.cc(190): error: Value of: infobar_accessible.IsSameObject(targets[0])
>
> This patch does change task queuing, which makes it seem slightly more likely to break stuff than the others in the blamelist.
>
> Original issue's description:
> > ServiceWorker: Use scheduler's default task queue for posting tasks on main thread
> >
> > This fixes a task ordering bug between WebMessagePortChannelImpl and
> > ServiceWorkerScriptContext. The former posts tasks via the Blink
> > scheduler's default task queue, and the latter was using the MessageLoop
> > directly. This patch makes tasks from service worker to the main thread
> > go through the scheduler.
> >
> > BUG=460833
> > TEST=http/tests/serviceworker/postmessage-msgport-to-client.html
> >
> > Committed: https://crrev.com/a7fe515e3ca07e260b58ebf460f842601266ed87
> > Cr-Commit-Position: refs/heads/master@{#318022}
>
> TBR=kinuko@chromium.org,skyostil@chromium.org,ksakamoto@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=460833
>
> Committed: https://crrev.com/64250e71c15dfe3576d8e4077e4dfb04f9382482
> Cr-Commit-Position: refs/heads/master@{#318040}

TBR=kinuko@chromium.org,skyostil@chromium.org,ksakamoto@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460833

Review URL: https://codereview.chromium.org/957583003

Cr-Commit-Position: refs/heads/master@{#318058}

Remove the requirement of a GBM device at construction time for
GbmSurfaceFactory and switch to using EGL_DEFAULT_DISPLAY as a native
display.

This allows us to remove the hacks to open the "primary" graphics device
in the GPU initialization. Graphics device initialization would be fully
handled via hotplugging.

BUG=427959

Review URL: https://codereview.chromium.org/955013002

Cr-Commit-Position: refs/heads/master@{#318057}

The script tools/gyp-explain.py uses the output of the gyp generator
"dump_dependency_json" so flip the condition in the gyp files to test
if the generator is "xcode" instead of "ninja" (so that the generator
dumping the JSON dependencies see the same dependency as the "ninja"
generator).

BUG=None

Review URL: https://codereview.chromium.org/957673005

Cr-Commit-Position: refs/heads/master@{#318056}

This pulls in the following Native Client changes:

26f5754: (sbc@chromium.org) Revert "Implement pthread_rwlock functions for NaCl newlib."
641a0eb: (dpranke@chromium.org) Update GN build files w/ cpu_arch -> current_cpu changes
7168ea5: (mtrofin@chromium.org) Support for debug builds for host binaries (e.g. llvm)
123e556: (dschuff@chromium.org) Update revision for PNaCl
d1999f5: (bradnelson@google.com) Reenabling crc32w.

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/952893007

Cr-Commit-Position: refs/heads/master@{#318055}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/86821b5..5a23a14

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/952053006

Cr-Commit-Position: refs/heads/master@{#318054}

The problem is as follows:
User A is upon start active on login screen. User B logs in. Then User A gets added to the multi profile session.

The problem was that there were 2 independent caches:
A - The wallpaper image cache (which contains multiple elements)
B - A last loaded wallpaper path.

Since these both caches could get out of sync it was possible that things did go wrong. This CL is combining the 2 caches by adding a path to each loaded wallpaper.

BUG=454094
TEST=some aspects tested via unit test, visual tests

Review URL: https://codereview.chromium.org/955653006

Cr-Commit-Position: refs/heads/master@{#318053}

When posting a delayed task in the task queue manager we post a wrapping task
which enqueues the actual task on the underlying message loop. It is confusing
to have this task use the actual task's from_here since it looks like the task
get's run at this point, which is not the case.

Review URL: https://codereview.chromium.org/959713002

Cr-Commit-Position: refs/heads/master@{#318052}

Those are now compiled into the executable.
Also remove tools/lsan/ which used to house the suppressions file.

Relanding with .isolate fix.

BUG=302040
TBR=kjellander@chromium.org

Review URL: https://codereview.chromium.org/952103003

Cr-Commit-Position: refs/heads/master@{#318051}

BUG=400674

Review URL: https://codereview.chromium.org/954213002

Cr-Commit-Position: refs/heads/master@{#318050}

BUG=434420, 445265

Review URL: https://codereview.chromium.org/945143006

Cr-Commit-Position: refs/heads/master@{#318049}

This CL fixes MidiManagerUsb's bug which prevented the manager from
listening input events coming from multiple MIDI devices.

BUG=None
R=toyoshim@chromium.org

Review URL: https://codereview.chromium.org/943333006

Cr-Commit-Position: refs/heads/master@{#318048}

WebRTC 8467:8506
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/be487b4..7251e22

Libjingle 8468:8501
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/fe7ee2e..87d21d8

TBR=tommi

Review URL: https://codereview.chromium.org/956933002

Cr-Commit-Position: refs/heads/master@{#318047}

TBR=wfh@chromium.org
BUG=461816
NOTRY=true

Review URL: https://codereview.chromium.org/955983002

Cr-Commit-Position: refs/heads/master@{#318046}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/81e7873..da1c15a

TBR=arv@chromium.org

Review URL: https://codereview.chromium.org/954183003

Cr-Commit-Position: refs/heads/master@{#318045}

TabAndroid is not intended to be subclassed so remove virtuals. Also
restrict access to native pointer from java.

BUG=443773

Review URL: https://codereview.chromium.org/955713002

Cr-Commit-Position: refs/heads/master@{#318044}

Revert of Remove LSan options/suppressions from test_env.py. (patchset #1 id:1 of https://codereview.chromium.org/940033002/)

Reason for revert:
Breaks Linux ASAN:

https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Builder/builds/19163/steps/isolate%20tests/logs/stdio

The error is:

MappingError: Input file /mnt/data/b/build/slave/Linux_ASan_LSan_Builder/build/src/tools/lsan/suppressions.txt doesn't exist

Original issue's description:
> Remove LSan options/suppressions from test_env.py.
>
> Those are now compiled into the executable.
> Also remove tools/lsan/ which used to house the suppressions file.
>
> BUG=302040
> R=kjellander@chromium.org
>
> Committed: https://crrev.com/09fef383665c6d75776bb0b649b29685b38ce617
> Cr-Commit-Position: refs/heads/master@{#318035}

TBR=kjellander@chromium.org,earthdok@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=302040

Review URL: https://codereview.chromium.org/956603004

Cr-Commit-Position: refs/heads/master@{#318043}

This test currently doesn't check anything
BUG=461790
NOTRY=true

Review URL: https://codereview.chromium.org/960533002

Cr-Commit-Position: refs/heads/master@{#318042}

Cr-Commit-Position: refs/heads/master@{#318041}

Revert of ServiceWorker: Use scheduler's default task queue for posting tasks on main thread (patchset #1 id:1 of https://codereview.chromium.org/958523002/)

Reason for revert:
Highly speculative revert after views_unittests broke on win7:

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/35660

c:\b\build\slave\win_builder__dbg_\build\src\ui\views\accessibility\native_view_accessibility_win_unittest.cc(190): error: Value of: infobar_accessible.IsSameObject(targets[0])

This patch does change task queuing, which makes it seem slightly more likely to break stuff than the others in the blamelist.

Original issue's description:
> ServiceWorker: Use scheduler's default task queue for posting tasks on main thread
>
> This fixes a task ordering bug between WebMessagePortChannelImpl and
> ServiceWorkerScriptContext. The former posts tasks via the Blink
> scheduler's default task queue, and the latter was using the MessageLoop
> directly. This patch makes tasks from service worker to the main thread
> go through the scheduler.
>
> BUG=460833
> TEST=http/tests/serviceworker/postmessage-msgport-to-client.html
>
> Committed: https://crrev.com/a7fe515e3ca07e260b58ebf460f842601266ed87
> Cr-Commit-Position: refs/heads/master@{#318022}

TBR=kinuko@chromium.org,skyostil@chromium.org,ksakamoto@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460833

Review URL: https://codereview.chromium.org/954993002

Cr-Commit-Position: refs/heads/master@{#318040}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9bbb321..81e7873

TBR=arv@chromium.org

Review URL: https://codereview.chromium.org/953333002

Cr-Commit-Position: refs/heads/master@{#318039}

Trace the task queue size when a task gets posted into it in addition
to when we reload the work queue. This makes it easier to see when
tasks are posted from a trace.

Review URL: https://codereview.chromium.org/954833005

Cr-Commit-Position: refs/heads/master@{#318038}

Previously, SupervisedUserService implemented extensions::ManagementPolicy::Provider::UserMayModifySettings, preventing any modifications to extensions (including e.g. disabling on permissions increase). This CL switches to MustRemainInstalled, to prevent uninstallation of custodian-installed extensions, and disables all UI that would allow re-enabling.

As a side-effect, this fixes crbug.com/458082 :)

BUG=397951,458082, 461261

Review URL: https://codereview.chromium.org/925563002

Cr-Commit-Position: refs/heads/master@{#318037}

<paper-button> does not handle ENTER and SPACE by default, so this CL change
the buttons to <button>s.
<button>s on the footer already have style similar to paper-button, so the
visual style for each button is not changed.

BUG=461758
TEST=manually check the response for ENTER/SPACE

Review URL: https://codereview.chromium.org/944683003

Cr-Commit-Position: refs/heads/master@{#318036}

Those are now compiled into the executable.
Also remove tools/lsan/ which used to house the suppressions file.

BUG=302040
R=kjellander@chromium.org

Review URL: https://codereview.chromium.org/940033002

Cr-Commit-Position: refs/heads/master@{#318035}

Revert of Enabled gpu_times metrics. (patchset #1 id:1 of https://codereview.chromium.org/937073003/)

Reason for revert:
Causing not redness.

Original issue's description:
> Enabled gpu_times metrics.
>
> The issue where gpu_times would use too much memory has been fixed:
> https://codereview.chromium.org/920523002
>
> In order to prepare for future changes where additional metrics
> will be added to the TBM module, I have also preemptively added a
> filter function which filters out values relating to gpu_times.
>
> R=nednguyen@chromium.org
> BUG=455292, 453131
> TEST=local runs measuring memory usage shows ~700mb
>
> Committed: https://crrev.com/ed5b27a7459e35248992fd5549b72b5731a8baa4
> Cr-Commit-Position: refs/heads/master@{#317974}

TBR=dyen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=455292, 453131

Review URL: https://codereview.chromium.org/952133003

Cr-Commit-Position: refs/heads/master@{#318034}

This test is flaky on Linux Tests (dbg) bot.

BUG=298193
TBR=arv@chromium.org,creis@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/948023003

Cr-Commit-Position: refs/heads/master@{#318033}

BUG=459475

Review URL: https://codereview.chromium.org/957673003

Cr-Commit-Position: refs/heads/master@{#318032}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b36e957..9bbb321

TBR=arv@chromium.org

Review URL: https://codereview.chromium.org/956833003

Cr-Commit-Position: refs/heads/master@{#318031}

BUG=459588
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/952173002

Cr-Commit-Position: refs/heads/master@{#318030}

This to make sure that after login, the system tray is always visible
and within the bounds of the screen.

R=nkostylev@chromium.org
BUG=372838
TEST=interactive_ui_tests --gtest_filter=Login*Test.*

Review URL: https://codereview.chromium.org/922463005

Cr-Commit-Position: refs/heads/master@{#318029}

Adding MockVideoSource::Stop and ::Restart so that the interface can be made pure virtual.

Review URL: https://codereview.chromium.org/956883002

Cr-Commit-Position: refs/heads/master@{#318028}

Also fix the alignment in the "Blacklisted" bubble.

BUG=400674

Review URL: https://codereview.chromium.org/942743003

Cr-Commit-Position: refs/heads/master@{#318027}

This directory is almost empty except for this OWNERS file.

BUG=None
R=jcivelli@chromium.org

Review URL: https://codereview.chromium.org/954633002

Cr-Commit-Position: refs/heads/master@{#318026}

BUG=406277

Review URL: https://codereview.chromium.org/792903003

Cr-Commit-Position: refs/heads/master@{#318025}

Revert of Revert of [DevTools] Check request_id in DevToolsUIBindings::IndexPath (patchset #2 id:40001 of https://codereview.chromium.org/956873002/)

Reason for revert:
Turns out the revert was incorrect (the error even started happening a couple builds before this patch).

Original issue's description:
> Revert of [DevTools] Check request_id in DevToolsUIBindings::IndexPath (patchset #1 id:1 of https://codereview.chromium.org/951953002/)
>
> Reason for revert:
> Speculative revert: http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests/builds/4683/steps/browser_tests%20on%20Mac-10.6/logs/DevToolsSanityTest.TestReattachAfterCrash became very flaky on Mac OS X 10.6 about when this patch was introduced. This is the only devtools change near to the start of the flakiness.
>
> The errors are:
> DevToolsSanityTest.TestReattachAfterCrash (run #1):
> [ RUN      ] DevToolsSanityTest.TestReattachAfterCrash
> [32422:28675:0224/105826:WARNING:data_reduction_proxy_config.cc(211)] SPDY proxy OFF at startup
> HTTP server started on http://127.0.0.1:64960...
> sending server_data: {"host": "127.0.0.1", "port": 64960} (36 bytes)
> [32427:9479:0224/105828:WARNING:channel.cc(547)] Failed to send message to ack remove remote endpoint (local ID 1, remote ID 1)
> [32427:9479:0224/105828:WARNING:channel.cc(547)] Failed to send message to ack remove remote endpoint (local ID 2147483648, remote ID 2
>
> Original issue's description:
> > [DevTools] Check request_id in DevToolsUIBindings::IndexPath
> >
> > If request_id is reused before the previous job with the same id is finished the old job won't be stopped in ~DevToolsUIBindings.
> >
> > BUG=
> >
> > Committed: https://crrev.com/88ac3ce8fa6463e5f04d4b3e7e2327e2ec1b3a19
> > Cr-Commit-Position: refs/heads/master@{#317799}
>
> TBR=dgozman@chromium.org,vkuzkokov@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=
>
> Committed: https://crrev.com/012bebf20cabd5a81179a185b87bd75f632edb66
> Cr-Commit-Position: refs/heads/master@{#318019}

TBR=dgozman@chromium.org,vkuzkokov@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/957623003

Cr-Commit-Position: refs/heads/master@{#318024}