- 04 Jun, 2020 40 commits
-
-
Zhenyao Mo authored
This is for GLImageMemory's optimization path. BUG=1087047 TEST=manual R=kbr@chromium.org,khushalsagar@chromium.org Change-Id: I82d3ceeac36644f95e3a52b2a943c4ecaeb651d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226926Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#774927}
-
Nate Chapin authored
Bug: 1090561 Test: html/semantics/scripting-1/the-template-element/template-element/template-content-in-inactive-document-crash.html Test: html/semantics/scripting-1/the-template-element/template-element/template-content-move-to-inactive-document-crash.html Change-Id: Idfdc343b177fcd81b208d98b0f66799abee5e4d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229368 Commit-Queue: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#774926}
-
Rachel Wong authored
These are some small modifications to allow for a new privacy notice to be added cleanly. Bug: 1079169 Change-Id: I60d4a8c7754f2573055e16990ae524876378eb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226101Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#774925}
-
Omid Tourzan authored
The warning divs get important display rule to prevent default display: none as it prevents animation. The hide action handled by visibility rule. Bug: 1083026 Change-Id: I53112d9029b2c8d621a974668cbf39a82d428420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228017Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#774924}
-
Devlin Cronin authored
Extend it through 06-2021. Bug: 1072517 Change-Id: I5db65d8a091a7428f1a24ef8573f7d4947109132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229469 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#774923}
-
Hitoshi Yoshida authored
This CL fixes two potential issues related to code generator's migration - Do not access Notification.vibration if it is missing - Check Notifivation.data is null or not Bug: 839389, 107964 Change-Id: If2ecbb1339bf539d52f4dad196d8aff36a7e0b80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228015 Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#774922}
-
Haiyang Pan authored
* content_shell_crash_test * telemetry_chromium_minidump_unittests * telemetry_perf_unittests Bug: 1084353, 1084352 Change-Id: Idfcb4c13ab3441a6aafa42986f142c7b745264e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229005 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#774921}
-
Greg Kerr authored
If the kernel supports core scheduling, Hyper-Threading is enabled by default. Users, admins and Finch may still override this setting. BUG=b:152605392 Change-Id: Iffcec33455ec277ec6f79f03908d02015c7d1f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209676Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Auto-Submit: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#774920}
-
Haiyang Pan authored
A wrong filter name was put in crrev.com/c/2227300. TBR=liaoyuke@chromium.org Bug: 1056330, 1022533 Change-Id: Ib042a049cefbe74c50cd7c928a1ab4c3beddc872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228350 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Auto-Submit: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#774919}
-
Nick Harper authored
The policy "public-suffix" has been in use but wasn't documented. The language for both "public-suffix" and "public-suffix-requested" is now updated to more accurately reflect how those are used. Bug: 1063653 Change-Id: Ic559a1af76ff3572fb0f249e5216407ba0a4da99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229434 Auto-Submit: Nick Harper <nharper@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#774918}
-
Sharon Yang authored
Add ComponentInspectorForProcess to manage a singleton per component. Add static functions to inspect.* as a helper to publish version and last revision. Test: Added InspectTest to cr_fuchsia_base_unittests Bug: 1061245 Change-Id: I0918b183fecedcd9a4c70685f7b7a166b2d82732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2173238 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774917}
-
Antonio Gomes authored
... in webmediaplayer_ms.cc This CL: - moves the anonynous namespace declaration within the blink namespace (consistency). - removes the needless blink:: namespace declarations. BUG=704136 R=guidou@chromium.org Change-Id: Ibf54fd53633414a5e9c70c44fab8bcf205cc6abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229203 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#774916}
-
phillis authored
The launch target for file handling is pushed to M86 https://bugs.chromium.org/p/chromium/issues/detail?id=829689. Thus extending the metrics to M90. Bug: 1088559, 1088558, 1088557, 1088556, 1088555, 1088554 Change-Id: I592cb624fb2e98f4c15e51efbf813ebadf4c0615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227116 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#774915}
-
Tom Anderson authored
Fixes a regression after [1]. The issues is that xcb_request_check must be called instead of xcb_wait_for_reply when the request will not generate a reply. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2220524 R=collinbaker Bug: 1066670 Change-Id: I56ffe2f4081c5b8413a47500b4cf4aca1cd9bb59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229721Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#774914}
-
Brian Sheedy authored
Switches most of the GPU pixel tests that are still using the extremely permissive Sobel algorithm onto less permissive parameters or onto exact matching depending on how noisy they are. Also includes an extra optimization to the parameter optimizer script to skip parameter sets that we know are guaranteed to fail. This was necessary in order to get some of the video parameter optimization runtimes down to a reasonable level. Bug: 1078914 Change-Id: Ie4b1dad447a4e35e8545756dc3482819e3d61c7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228057Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#774913}
-
Sorin Jianu authored
Bug: 1026641 Change-Id: I14eaebf153dd419c4453cb22b9c5fb8be7f5add5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229242Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774912}
-
Megan Jablonski authored
Bug: 1089597 Change-Id: Iedc7c6eae986f5b6db73564bab6c45f5546c66b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225368Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#774911}
-
siashah authored
Video: https://drive.google.com/file/d/138nyvCrRQd80CHFlAWQlE13Lkp-dFyms/view?usp=sharing Bug: 1082013 Change-Id: Icef37cfd081eb92be14fed1abe9faf90b2080508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225283Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#774910}
-
Eric Orth authored
Bug: 1088717 Change-Id: Iaea13ba81477e548bdc630b47b4a94d115ef1d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229403Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#774909}
-
Clark DuVall authored
Bug: 1084013 Change-Id: Ia3660f2bf9d6bd98d11fc31b24fe1c903cfec3c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225777 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#774908}
-
Shimi Zhang authored
- Check if the |target_url| is |kBlockedURL|, if true, call the callback with |kIgnore.| - Add regression test. Fixed: 1083819 Change-Id: I56bde76b749efa2dcaf9b3e178ace94b43aa9faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226496 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#774907}
-
Mounir Lamouri authored
In addition to database read time. Bug: None Change-Id: I59bb238c5eb94de0d11a302f8e935886b231a589 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213924 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#774906}
-
Clark DuVall authored
A delegate interface was created to wrap chrome's NavigateParams, and provide chrome specific logic on blocked popups. Things are a bit tricky since in the original code MaybeBlockPopup may or may not take ownership of the NavigateParams (by calling std::move(*params)). The delegate is now passed as a unique_ptr to MaybeBlockPopup, and the unique_ptr is returned if the navigation should continue (nullptr if the popup should be blocked). Bug: 1084013 Change-Id: Ic05d7539c6f53927721158dfffd88b1aba7f3125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224824Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774905}
-
chrome://media-appTrent Apted authored
Some tracing with performance.now() suggests this will shave about 300ms off the critical path for loading a file. We would previously wait for the window 'load' event which indicated that the <iframe> subresource (and all *its* subresources) had fully loaded. This was "safe" but too conservative. There's a tip in the spec: https://html.spec.whatwg.org/multipage/web-messaging.html#posting-messages which suggests to have the <iframe> send a message to its parent to indicate that it's ready to process messages, which this CL does (saving ~100ms). For the other ~200ms, the steps involved in handling the launch event to open the file and determine related files are now allowed to run before the iframe is ready to receive messages. Only the final postMessage that triggers the load must wait for the iframe to be ready. Sample trace for loading a file in a directory with 75 files after this change that explains the "300ms" improve: <privileged> 75~85 ms: JS starts (t=0 in privileged) t+5ms: launch message received t+80ms ms: waiting for iframe t+200ms: iframe "ready" received t+300ms: privileged 'load' event received <-- we used to start "launch" here. <unprivileged> 75~85 ms: JS starts (t=0 in unprivileged) t+50ms: iframe ready (app_main.js executed, app is still null) t+180ms: load in iframe begins t+570ms: load done [warm start] t+1050ms: load done [cold start] Covered by existing tests, which were hammered with some invocations of browser_tests --test-launcher-jobs=20 --gtest_filter='*MediaApp*' \ --gtest_repeat=10 to flush out any flakes. Bug: b/157949149 Change-Id: Ie1c3ca79bb9f7b5d323967ee653943ac7901afd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227716Reviewed-by:
dstockwell <dstockwell@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#774904}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cf77d6e387b6..84620d395a4d 2020-06-03 ehmaldonado@google.com gsutil.py.bat: Skip updating depot_tools if DEPOT_TOOLS_UPDATE=0. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1090603 Tbr: agable@chromium.org Change-Id: Ia2e529b3edd91a48f5f277e88c6d678bab6b63af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229271Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774903}
-
Anders Hartvoll Ruud authored
This CL adds parser/ComputedStyle support for the animation-timeline property. The property doesn't have any affect yet. The property accepts auto, none, <custom-ident> or <string>, and (currently) needs to remember how it was specified in order to serialize correctly. This is a situation that is useful in other scenarios as well (e.g. animation-name), and it's a pattern I expect to see more of in the future, hence this CL adds the 'StyleName' and 'StyleNameOrKeyword' classes for this purpose. Note that expanding animation-timeline from the animation shorthand is not possible yet, and will be done in a separate CL. Bug: 1074052 Change-Id: Ie37e520fd64e9556863c09d97d8c9f8f7c5f7fbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223950 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#774902}
-
Lukasz Anforowicz authored
RenderFrameHostImpl::GetExpectedMainWorldOriginForUrlLoaderFactory takes into account pending navigations, so that URLLoaderFactory objects pushed to the renderer are compatible with the most recent Commit IPC that was sent to the renderer process. GetExpectedMainWorldOriginForUrlLoaderFactory relies on GetOriginForURLLoaderFactory helper functions which asserts (via CHECK) that the computed |request_initiator_site_lock| is compatible with the origin lock of the renderer process. GetExpectedMainWorldOriginForUrlLoaderFactory looks for Commit-send-but-DidCommit-not-yet-received navigations in the RenderFrameHostImpl::navigation_requests_ container. The problem is that: 1. RenderFrameHostImpl::navigation_requests_ container may include failed navigations. 2. RenderFrameHostImpl::ValidateDidCommitParams explicitly relaxes security checks for failed navigations (see |bypass_checks_for_error_page|). 3. GetOriginForURLLoaderFactory unconditionally CHECKs CanAccessDataForOrigin without accounting for failed navigations. The CL here teaches GetOriginForURLLoaderFactory to relax security checks for failed navigations. Bug: 1058111 Change-Id: I59dbe5b92728fcbc28da35a1cf0226a8464b0e48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225242 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#774901}
-
Sophey Dong authored
Currently uses the current tab, which is inaccurate in some cases (WebShare API, press and hold link share). Bug: 1079467 Change-Id: I76d651c2f3791a7e3274a0a316409e0a39700099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225465 Commit-Queue: Sophey Dong <sophey@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#774900}
-
Michael Cui authored
This works around the ARC++ Download folder bug in Managed Guest Sessions, where the <shared storage>/Download mount in Android isn't working correctly. This bug causes any reads of the Download directory in ARC++ to fail, resulting in the sample photos not being readable from Android apps - including the media scanner. This CL moves the sample photos from Downloads to My Files, which allows the Android media scanner to pick up on those photos. Most notably, this allows Google Photos in Demo Mode to display the sample photos bundled in Demo Mode, which was broken before this CL. Note that we would still prefer the sample photos to be stored in the Downloads directory, as most apps expect photos to be there instead of My Files (such as the CrOS camera app and the "open file" dialog). We should revert this CL once the aforementioned bug is fixed. Bug: b/158053270 Change-Id: Id4f39c23ec3321bca424bed405281e42045a136d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228272 Commit-Queue: Michael Cui <mlcui@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#774899}
-
Gyuyoung Kim authored
This CL applies mojo::PendingReceiver to all uses of MidisServerRequest. Bug: 955171 Change-Id: I3faf2160dd85f4d9e7855e3d72685c1b01c8a624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227943Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#774898}
-
Gyuyoung Kim authored
This CL applies mojo::PendingReceiver to all uses of OemCryptoServiceRequest. Bug: 955171 Change-Id: I8ec250d2a56f6e72d29e5d90c20d40587174c60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228253Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#774897}
-
Francois Doray authored
TBR=fdoray@chromium.org Bug: 1090976 Change-Id: I57f4916e5373d48c0128d95237e2e05f7fff3009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228657Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#774896}
-
Garrett Beaty authored
Bug: 1091004 Change-Id: I328a5ff2a81f4c274d758fbe0915ae1257ac3c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229417 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#774895}
-
Gyuyoung Kim authored
This CL applies mojo::PendingRemote and mojo::Remote to all uses of PrintSessionInstance interface. Bug: 955171 Change-Id: I5a31ea941d9d8d8456f1880dcf0b4abc390d0b49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228295Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#774894}
-
Rohit Rao authored
BUG=None Change-Id: I3141de726bd17da79d4d40f43f4bf31d6bf595e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229718Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#774893}
-
Tetsui Ohkubo authored
When DragSource is destroyed after StartDragDropOperation is called, it crashes because DragDropOperation is deleted twice. To trigger this crash, the client simply has to send following requests in order before the user releases the mouse button: - wl_data_device.start_drag - wl_data_source.destroy This CL adds the validity check of the current instance after returning from StatDragAndDrop(). StartDragAndDrop runs a nested RunLoop inside, which may delete the current instance. TEST=DragDropOperationTest.DeleteDuringDragging BUG=None Change-Id: I7e5265069675a59e92a4e1ad7dcc1d59fd9c7f12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217991Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#774892}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib623fdd9d149780574e9a7b9555d7a69396304f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229414Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774891}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ebc6d0a4b9ec..f2d4abb2ef18 2020-06-03 geofflang@chromium.org Vulkan: Correct the viewport before intersecting it with the scissor. 2020-06-03 syoussefi@chromium.org Vulkan: Remove validation error suppressions for VVL bug 2020-06-03 syoussefi@chromium.org Vulkan: Remove validation error suppression for fixed issue 2020-06-03 ianelliott@google.com Vulkan: Pre-rotate dFdx() & dFdy() for Android If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1078378 Tbr: ynovikov@google.com Test: Test: angle_deqp_gles3_tests --gtest_filter=dEQP.GLES3/functional_shaders_derivateTest: Test: angle_end2end_tests --gtest_filter=*EGLPreRotationSurfaceTest.OrientedWindow Change-Id: I122be5c8a02ce3497157ad77c911ef4bb3a3cfe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229266Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774890}
-
Trent Begin authored
This adds a singleton service for NetworkHealthService and adds a mojo remote in network_ui to display the NetworkHealth information. Bug: chromium:1076178 Change-Id: Ic6e7003591abaa0761dff16893b7ce59073a5409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2202316 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#774889}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f84ab8e2ddfa..1220c3995354 2020-06-03 jianj@google.com av1: add a few controls to wrapper If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icc6cf7dcb4d9855ab20bf00d31f5d9e940a1eacb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229289Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774888}
-