- 12 Sep, 2014 40 commits
-
-
Ben Smith authored
* Switched KernelProxy to use utimens/futimens. * kernel_intercept.* forwards utime/utimes/futimes -> {,f}utimens. * Add Node::Futimens * Override FuseFsNode::Futimens * Add newlib headers to define utime/utimes/futimes * Glibc uses at_stim as timespec instead, add define for st_atimensec for compatibility with newlib. BUG=413412 R=sbc@chromium.org Review URL: https://codereview.chromium.org/565343002 Cr-Commit-Position: refs/heads/master@{#294678}
-
mattm authored
BUG=none Review URL: https://codereview.chromium.org/569643003 Cr-Commit-Position: refs/heads/master@{#294677}
-
qinmin authored
For OMA downloads, chrome doesn't handle it correctly as the file needs to be converted to a .fl file and encrypted on the device. The android DownloadManager provides such covertion. As a result, we need to provide a way for us to intercept certain OMA downloads BUG=382698 Review URL: https://codereview.chromium.org/571613002 Cr-Commit-Position: refs/heads/master@{#294676}
-
cmumford authored
Switching for two reasons: 1. Semantics are simpler because, in each of these cases, there was never a subsequent iteration - just a check to see if the iterator key matched the desired key. 2. The Transaction::Get() call uses the LevelDB filter which (when enabled) can significantly reduce disk reads, thus improving performance. This change, along with enabling the bloom filter, resolves a performance issue introduced by r273048. BUG=409520 Review URL: https://codereview.chromium.org/565023002 Cr-Commit-Position: refs/heads/master@{#294675}
-
fsamuel authored
We were accessing a NULL RWHV on BrowserPluginGuest::SetFocus. This CL adds a guard to ensure we only attempt to set focus if we have a View. BUG=413874 Review URL: https://codereview.chromium.org/564153003 Cr-Commit-Position: refs/heads/master@{#294674}
-
cmumford authored
Enabling a LevelDB feature to improve performance. BUG=409520 Review URL: https://codereview.chromium.org/562333005 Cr-Commit-Position: refs/heads/master@{#294673}
-
bauerb authored
BUG=410651 Review URL: https://codereview.chromium.org/566893002 Cr-Commit-Position: refs/heads/master@{#294672}
-
mef authored
Update proguard.cfg to reflect that @UsedByReflection was moved to base/. Add --release option to cr_cronet.py tool. Notes: - Chromium debug build does not apply proguard at all. - Chromium instrumentation test does not allow custom proguard config (but it uses proguard config from instrumented app, which is nice). BUG=390267 Review URL: https://codereview.chromium.org/512953002 Cr-Commit-Position: refs/heads/master@{#294671}
-
binji authored
No trybots because it is a documentation-only change. BUG=137810 R=sbc@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/568153004 Cr-Commit-Position: refs/heads/master@{#294670}
-
damienv authored
When the DemuxerStream has a pending read, this one must be completed before invoking the flush callback. BUG=408189 Review URL: https://codereview.chromium.org/565973003 Cr-Commit-Position: refs/heads/master@{#294669}
-
tonyg authored
Most significant among the changes is improved HTTPS handling. BUG=412826 TBR=slamm@chromium.org Review URL: https://codereview.chromium.org/558263002 Cr-Commit-Position: refs/heads/master@{#294668}
-
jbudorick authored
PushDataDeps takes a long time even when all files are on the device because calculating the digests of all the files takes _much_ longer on a device than it does on a host. Skipping the push step during test listing -- where the data deps are unnecessary -- means that we don't try to push files twice in each gtest run, so we skip all of the device-side MD5 calculations that would happen in the second run. BUG=400440 Review URL: https://codereview.chromium.org/560133002 Cr-Commit-Position: refs/heads/master@{#294667}
-
ericzeng authored
Remove flags and change trunk channel restrictions to dev in preparation for launch. BUG=386830 Review URL: https://codereview.chromium.org/564993002 Cr-Commit-Position: refs/heads/master@{#294666}
-
pkotwicz authored
BUG=409888 TEST=WindowManagerTest.* SplitViewController.* Review URL: https://codereview.chromium.org/550043002 Cr-Commit-Position: refs/heads/master@{#294665}
-
danakj authored
We don't do anything with this rect so remove it. R=nduca@chromium.org, vmpstr BUG=413479 Review URL: https://codereview.chromium.org/563963002 Cr-Commit-Position: refs/heads/master@{#294664}
-
xhwang authored
Previously this is only whitelisted on Linux/ChromeOS. This CL relax this to all platforms. BUG=413812 TEST=Tested on Windows. Review URL: https://codereview.chromium.org/567913002 Cr-Commit-Position: refs/heads/master@{#294663}
-
mukai authored
BUG=409492 R=oshima@chromium.org TEST=ash_unittests, manually Review URL: https://codereview.chromium.org/562413002 Cr-Commit-Position: refs/heads/master@{#294662}
-
rch authored
Review URL: https://codereview.chromium.org/549433006 Cr-Commit-Position: refs/heads/master@{#294661}
-
rdsmith authored
to prevent memory from being freed. R=mef@chromium.org BUG=413400 Review URL: https://codereview.chromium.org/566763002 Cr-Commit-Position: refs/heads/master@{#294660}
-
mathp authored
Skips it during accessibility treatment. BUG=326793 Review URL: https://codereview.chromium.org/569613003 Cr-Commit-Position: refs/heads/master@{#294659}
-
Brett Wilson authored
This is causing a compile failure in component mode. TBR=dpranke Review URL: https://codereview.chromium.org/566023003 Cr-Commit-Position: refs/heads/master@{#294658}
-
hubbe authored
Use are brand-spanking-new options dictionary to be able to configure the target and max burst size for the pacer. This should allow us to do some basic experiments to determine if pacing is really helpful and what the optimal batch size actually is. Review URL: https://codereview.chromium.org/567853002 Cr-Commit-Position: refs/heads/master@{#294657}
-
alekseys authored
BUG=397741 Review URL: https://codereview.chromium.org/565213005 Cr-Commit-Position: refs/heads/master@{#294656}
-
hubbe authored
After a bunch of testing, it seems like there is a direct linear relationship between RTT and the optimal playout delay. Packet loss is also a factor, but since we expect packet loss to be low in normal networks, perhaps we can make the formula as easy as RTT * 4. This is disabled by default, the extension needs to set min_latency_ms in order to activate it. BUG=405339 Review URL: https://codereview.chromium.org/562653004 Cr-Commit-Position: refs/heads/master@{#294655}
-
jfroy authored
BUG=409897 R=rsesek, DaleCurtis Review URL: https://codereview.chromium.org/531863002 Cr-Commit-Position: refs/heads/master@{#294654}
-
sergeyu authored
Previously TransportFactory interface was responsible for creation and initialization of several protocol layers, including PseudoTCP and authentication (TLS). Simplified it so now it only creates raw datagram transport channel. PseudoTcpChannelFactory is now responsible for setting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care of channel authentication. Also added DatagramChannelFactory for Datagram channels. This change will make it possible to replace PseudoTcpChannelFactory with an object that creates SCTP-based channels. Also fixed a bug in SslHmacChannelAuthenticator. It wasn't working properly when deleted from the callback. (base::Callback objects shouldn't be deleted while being called because when deleted they also destroy reference parameters values they are holding). BUG=402993 Review URL: https://codereview.chromium.org/551173004 Cr-Commit-Position: refs/heads/master@{#294653}
-
huangs authored
BUG=399643 Review URL: https://codereview.chromium.org/565963002 Cr-Commit-Position: refs/heads/master@{#294652}
-
nednguyen authored
BUG=413637 Review URL: https://codereview.chromium.org/564173002 Cr-Commit-Position: refs/heads/master@{#294651}
-
dmichael authored
See also https://trac.xiph.org/ticket/2048 BUG=355440 Review URL: https://codereview.chromium.org/570443002 Cr-Commit-Position: refs/heads/master@{#294650}
-
mdempsky authored
Chrome was modified back in May 2014 to use SCM_CREDENTIALS instead of --find-inode-switch and we haven't any heard any negative feedback, so it's time to remove --find-inode-switch entirely. BUG=357670 Review URL: https://codereview.chromium.org/569533002 Cr-Commit-Position: refs/heads/master@{#294649}
-
sky authored
After changes that made Embed() always create a new connection this test is now redundant with EmbedWithSameViewId*. Additionally it wasn't properly waiting, leading to use after frees. BUG=none TEST=covered by tests R=aa@chromium.org Review URL: https://codereview.chromium.org/566463003 Cr-Commit-Position: refs/heads/master@{#294648}
-
rsadam authored
BUG=355572 Review URL: https://codereview.chromium.org/562373002 Cr-Commit-Position: refs/heads/master@{#294647}
-
reed authored
TBR=miguelg@chromium.org Review URL: https://codereview.chromium.org/569483002 Cr-Commit-Position: refs/heads/master@{#294646}
-
mostynb authored
Followup to CL 485833002, which mixed use of the OVERRIDE macro and bare override. BUG=400336 Review URL: https://codereview.chromium.org/562353004 Cr-Commit-Position: refs/heads/master@{#294645}
-
Jian Li authored
BUG=none R=fgorski@chromium.org TBR=kalman@chromium.org Review URL: https://codereview.chromium.org/566933004 Cr-Commit-Position: refs/heads/master@{#294644}
-
danakj authored
TBR=dsinclair, nduca Review URL: https://codereview.chromium.org/540293003 Cr-Commit-Position: refs/heads/master@{#294643}
-
dpranke authored
The W3C test suites are now being imported directly into Blink (checked in under LayoutTests/imported). We no longer need to pull in the repos via DEPS or have a separate expectations file. This is patchset 4 of 4 and completes the cutover. TBR=eseidel@chromium.org BUG=413467 Review URL: https://codereview.chromium.org/557733003 Cr-Commit-Position: refs/heads/master@{#294642}
-
Brett Wilson authored
Instead of putting all the files in a bit test_support target, I made separate smaller test support targets for the various sub-projects (browser, common, etc.) and linked those in. This helps distribute the complexity. R=jamesr@chromium.org Review URL: https://codereview.chromium.org/559543003 Cr-Commit-Position: refs/heads/master@{#294641}
-
weitaosu authored
Revert of Convert device::UsbConfigDescriptor and friends to structs. (patchset #2 id:60001 of https://codereview.chromium.org/562763002/) Reason for revert: This broken the Linux ASan LSan Tests: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%283%29/builds/7506 http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29/builds/5717 Sample callstacks: Direct leak of 400 byte(s) in 10 object(s) allocated from: #0 0x55c6eb in __interceptor_malloc (/b/build/slave/Linux_ASan_LSan_Tests__3_/build/src/out/Release/browser_tests+0x55c6eb) #1 0xab24bb8 in raw_desc_to_config third_party/libusb/src/libusb/descriptor.c:501:45 #2 0xab24ab9 in libusb_get_active_config_descriptor third_party/libusb/src/libusb/descriptor.c:601:7 #3 0xab14aae in device::UsbDeviceImpl::GetConfiguration() device/usb/usb_device_impl.cc:199:9 #4 0xb37d57b in EnumerateOnFileThread(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>) chrome/browser/devtools/device/usb/android_usb_device.cc:262:42 #5 0xb38aebf in Run base/bind_internal.h:288:12 #6 0xb38aebf in base::internal::InvokeHelper\u003Cfalse, void, base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, void (crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*)>::MakeItSo(base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*) base/bind_internal.h:927 #7 0x2d58bff in Run base/callback.h:401:12 #8 0x2d58bff in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #9 0x2ca519c in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #10 0x2ca629e in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #11 0x2ca629e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #12 0x2c23ddf in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #13 0x2cd57b4 in base::RunLoop::Run() base/run_loop.cc:49:3 #14 0x2ca39c4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #15 0x50fd018 in content::BrowserThreadImpl::FileThreadRun(base::MessageLoop*) content/browser/browser_thread_impl.cc:190:3 #16 0x50fdca7 in content::BrowserThreadImpl::Run(base::MessageLoop*) content/browser/browser_thread_impl.cc:244:14 #17 0x2d1ebc8 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #18 0x2d12b20 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #19 0x7f4d560a3e99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Direct leak of 400 byte(s) in 10 object(s) allocated from: #0 0x55c6eb in __interceptor_malloc (/b/build/slave/Linux_ASan_LSan_Tests__1_/build/src/out/Release/browser_tests+0x55c6eb) #1 0xab24bb8 in raw_desc_to_config third_party/libusb/src/libusb/descriptor.c:501:45 #2 0xab24ab9 in libusb_get_active_config_descriptor third_party/libusb/src/libusb/descriptor.c:601:7 #3 0xab14aae in device::UsbDeviceImpl::GetConfiguration() device/usb/usb_device_impl.cc:199:9 #4 0xb37d57b in EnumerateOnFileThread(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>) chrome/browser/devtools/device/usb/android_usb_device.cc:262:42 #5 0xb38aebf in Run base/bind_internal.h:288:12 #6 0xb38aebf in base::internal::InvokeHelper\u003Cfalse, void, base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, void (crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*)>::MakeItSo(base::internal::RunnableAdapter\u003Cvoid (*)(crypto::RSAPrivateKey*, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, scoped_refptr\u003Cbase::MessageLoopProxy>)>, crypto::RSAPrivateKey* const&, base::Callback\u003Cvoid (std::__1::vector\u003Cscoped_refptr\u003CAndroidUsbDevice>, std::__1::allocator\u003Cscoped_refptr\u003CAndroidUsbDevice> > > const&)> const&, base::MessageLoopProxy*) base/bind_internal.h:927 #7 0x2d58bff in Run base/callback.h:401:12 #8 0x2d58bff in base::debug::TaskAnnotator::RunTask(char const*, char const*, base::PendingTask const&) base/debug/task_annotator.cc:62 #9 0x2ca519c in base::MessageLoop::RunTask(base::PendingTask const&) base/message_loop/message_loop.cc:446:3 #10 0x2ca629e in DeferOrRunPendingTask base/message_loop/message_loop.cc:456:5 #11 0x2ca629e in base::MessageLoop::DoWork() base/message_loop/message_loop.cc:565 #12 0x2c23ddf in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) base/message_loop/message_pump_libevent.cc:232:21 #13 0x2cd57b4 in base::RunLoop::Run() base/run_loop.cc:49:3 #14 0x2ca39c4 in base::MessageLoop::Run() base/message_loop/message_loop.cc:308:3 #15 0x50fd018 in content::BrowserThreadImpl::FileThreadRun(base::MessageLoop*) content/browser/browser_thread_impl.cc:190:3 #16 0x50fdca7 in content::BrowserThreadImpl::Run(base::MessageLoop*) content/browser/browser_thread_impl.cc:244:14 #17 0x2d1ebc8 in base::Thread::ThreadMain() base/threading/thread.cc:228:5 #18 0x2d12b20 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:80:3 #19 0x7f4aef980e99 in start_thread /build/buildd/eglibc-2.15/nptl/pthread_create.c:308 Original issue's description: > Convert device::UsbConfigDescriptor and friends to structs. > > These classes do not need to be classes and expecially don't need to be > abstract classes as this leads to a complicated implementation and > complicated tests. All USB devices no matter the platform will have the > same descriptor data. > > This change follows the model of device::HidDeviceInfo. > > BUG= > > Committed: https://crrev.com/be9e363a3af57bd313fbb96ec3b5fa02cef769b5 > Cr-Commit-Position: refs/heads/master@{#294594} TBR=dgozman@chromium.org,rockot@chromium.org,rpaquay@chromium.org,pfeldman@chromium.org,reillyg@chromium.org NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/567003002 Cr-Commit-Position: refs/heads/master@{#294640}
-
dschuff authored
This pulls in the following Native Client changes: r13734: (dyen) Added support for extending basic thread functions in irt_ext. r13735: (dyen) Added testing for file link operations in irt_ext tests. r13738: (dschuff) Override xcode architecture for ia32 standalone builds r13739: (hidehiko) Non-SFI mode: Add -malign-double flag to pnacl-translate. BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_arm_cross_compile,linux_nacl_sdk_build Review URL: https://codereview.chromium.org/569683002 Cr-Commit-Position: refs/heads/master@{#294639}
-