GitLab

I'm making some changes to SystemMonitor in a separate CL that make it
require that a TaskScheduler instance exists, and as some of these tests
use SystemMonitor they need to be modified to use a
ScopedTaskEnvironment.

Change-Id: I900f8c999f8b16259299b6502145b11e348070ff
Reviewed-on: https://chromium-review.googlesource.com/c/1346909Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610386}

They verify the very basic requirement of progress markers being
peristed and loaded upon restart, which prevents clients to fetch all
data from scratch from the server.

This also surfaces a bug with USS bookmarks that should be addressed in
a follow-up patch.

Bug: 856696
Change-Id: I924249579f2d5790f25be6809b03f50d5c421ffc
Reviewed-on: https://chromium-review.googlesource.com/c/1347366
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610385}

SigninManager::Observer::GoogleSignedOut had two overload one
taking a AccountInfo, and one taking two std::string. The latter
is deprecated in favor of the former.

As all overrides of the latter version are in components/signin
or services/identity, convert them in one CL and remove the old
method (that is now unused).

Bug: none
Change-Id: I1e65e9d182f7e48e75ed86f43647a57f65bf3d0e
Reviewed-on: https://chromium-review.googlesource.com/c/1344094
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610384}

The HTML spec requires SharedWorkerGlobalScope.name has [Replaceable]:
https://html.spec.whatwg.org/multipage/workers.html#shared-workers-and-the-sharedworkerglobalscope-interface

This CL also fixes a test expectation of
wpt/workers/interfaces/SharedWorkerGlobalScope/name/setting.html. The name
attribute is now replaceable, so the result should be replaced. Firefox fails
the test because of this wrong expectation:
https://wpt.fyi/results/workers/interfaces/SharedWorkerGlobalScope/name/setting.html?label=stable&aligned&q=%2Fname%2Fsetting.html

Bug: 875714
Change-Id: Id04ae30895a2de4a07e30f49dc1189bb9742f6b9
Reviewed-on: https://chromium-review.googlesource.com/c/1347962Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610383}

This change introduces support for interrupts.

Interrupts can be run as part of wait_for_dom with
allow_interrupts=true.

Interrupts can also run manually, by clicking on a chip, but only if
they have a name.

Interrupts can run automatically if they have autostart=true. Autostart
interrupts are handled differently from normal autostart, as they can
happen at any time. Running an autostart interrupt does not prevent
runnig a normal interrupt.

I tried to keep changes to the main, non-interrupt, path and
refactorings to a minimum in this change.

The result puts all the complexity into the script executor. I'd like to
get it to work, then find a good code split in a follow-up change. The
code has resisted all my attempts at reorganization so far...

Change to the main, non-interrupt path:

 - The responsibility for updating the script status is moved to
 ScriptExecutor, even though the script status map stays in
 ScriptTracker.This allows tracking script state changes caused by
 interrupts running.

 - The WaitForDom now uses the same wait code as
 ActionDelegate::WaitForElement instead of rolling up its own

Limitations:

 - The payload from interrupts is never sent back to the server. This
 doesn't allow interrupts to change variables

 - If an interrupt fails, the failure of the main script is not
 reported to the server; from the server's point of view, the main
 script just never finishes.

 - There's no "prompt" action yet, so interrupts cannot ask questions.

Bug: 806868
Change-Id: I12165965783ba479688c4c5b44ab72477ad4ae2b
Reviewed-on: https://chromium-review.googlesource.com/c/1340309
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610382}

I introduced skip_other_interceptors flag in crrev.com/c/1278433 to skip the
service worker handling of the synthesized redirection of signed exchange.
But this was wrong. We need to call ServiceWorkerProviderHost::SetDocumentUrl()
and SetTopmostFrameUrl() even after SignedExchangeRequestHandler started
handling the response to reject the service worker API calls from the page in
the signed exchange correctly. And also we need to call
SetControllerRegistration(null) to reset the controller state.

Bug: 894755,907712
Change-Id: Iace762636982429c23ec24d9af6a466468e4b9fb
Reviewed-on: https://chromium-review.googlesource.com/c/1347954Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610381}

User-visible changes:
 - ElementInternals interface has |form| IDL attribute
 - form.elements and fieldset.elements contain form-associated custom elements

Implementation:

 - ElementInternals inherits from ListedElement, which has logic and data for
  form-association.
  A form-associated custom element requires an ElementInternals instance
  regardless of calling HTMLElement.prototype.attachInternals().
  ElementInternals is created on demand, and is stored in ElementRareData.

 - Hook CustomElementDefinition::Upgrade to handle form association and
  HTMLCollection invalidation.

Bug: 905922
Bug: https://github.com/w3c/webcomponents/issues/187
Change-Id: Ic7828741c112c3c7339eee43b814d23ff706818b
Reviewed-on: https://chromium-review.googlesource.com/c/1347950
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610380}

Per:

  https://drafts.fxtf.org/filter-effects/#InterfaceSVGFEBlendElement

All other browsers expose these already.

Bug: 906612
Change-Id: I4be6185d4832d980a5d7c6518dcb0b2ccca2ce82
Reviewed-on: https://chromium-review.googlesource.com/c/1341846Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610379}

This CL ensures Infobars are listening to the keyboard when updating
their visibility. Before this CL, they were only listening to layout
changes (which is the indirect, less reliable way to achieve the same).

Bug: 907062
Change-Id: Ide81fd0c1712b8f22f4de0b4e5a3f2a4203d90af
Reviewed-on: https://chromium-review.googlesource.com/c/1346129
Commit-Queue: Friedrich Horschig [CET] <fhorschig@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610378}

https://chromium.googlesource.com/angle/angle.git/+log/9f379f493cd7..efe061bd4f9d


git log 9f379f493cd7..efe061bd4f9d --date=short --no-merges --format='%ad %ae %s'
2018-11-22 jie.a.chen@intel.com Optimize HLSL zero initializer
2018-11-22 jmadill@chromium.org Don't use gl::Error in validation.
2018-11-21 jmadill@chromium.org Vulkan: Cache pipelines with Shader Programs.


Created with:
  gclient setdep -r src/third_party/angle@efe061bd4f9d

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:898030
TBR=geofflang@chromium.org

Change-Id: I125a89563af417fed5d630b2be87b29d98f396f2
Reviewed-on: https://chromium-review.googlesource.com/c/1347083Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610377}

This CL adds Signin.AndroidGetAccountIdsTime histogram that tracks how
much time it takes to get account ids for all accounts on the device.

Bug: 906713
Change-Id: Ie59e815fcb469ced15fe308378e7c3fbc07d776a
Reviewed-on: https://chromium-review.googlesource.com/c/1342997
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610376}

TBR=kyleju@chromium.org

Bug: 856601
Change-Id: I4ab0da613ba282fab128206a91805593952ba0ff
Reviewed-on: https://chromium-review.googlesource.com/c/1347362Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610375}

The warning still fires when targeting Fuchsia, but the rest should be clean
now.

Bug: 890307
Change-Id: I65db88d025b3d4744f43d5a742fbb4cdb3ae6d40
Reviewed-on: https://chromium-review.googlesource.com/c/1347279Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610374}

Migrates audio service and related test code away from using deprecated
service APIs (ServiceContext, ServiceTest, etc) in favor of better ones.

Bug: 891780,906239
Change-Id: Iba655baf597fabd85fc0151d89cd32cb4b92578f
Reviewed-on: https://chromium-review.googlesource.com/c/1345548
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610373}

This reverts commit d15dd85f.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> [Reland] Block resources in FormStructureBrowserTest.
> 
> The files used for FormStructureBrowserTest are snapshots of real web
> sites. They can have link to online resources but should not need them
> for the test to pass.
> But if the network is really bad, the page can wait for the resource
> loading to finish and timeout.
> Preventing the resource loading will make the test faster and more
> robust.
> 
> Bug: 896173
> Change-Id: I16b02e1d7defd4d950e6ee4cd21bd0133b9ac957
> Reviewed-on: https://chromium-review.googlesource.com/c/1346462
> Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610366}

TBR=eugenebut@chromium.org,olivierrobin@chromium.org

Change-Id: I6628a9daa5b9d5a28b3cd9cda86272fe22dec8c6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 896173
Reviewed-on: https://chromium-review.googlesource.com/c/1347284Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610372}

 * window_tiemrs.idl -> window_or_worker_global_scope.idl
 * dom_window_timers.{cc,h} -> window_or_worker_global_scope.{cc,h}
 * blink::DOMWindowTimers -> blink::WindowOrWorkerGlobalScope

in order to match to the HTML standard.

This CL has no behavior changes.

Bug: 701499
Change-Id: Iec6fd1cca6d62d4292f6067047c97440d1d31a33
Reviewed-on: https://chromium-review.googlesource.com/c/1347968Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610371}

Start streaming ScriptResources when they are fetched, so that they
can start streaming during preload, before the script tag is seen.
This is enabled with a new ScriptStreamingOnPreload flag.

Bug: chromium:865098
Change-Id: I4a2874bce857a538f4bd35a818254ca9617f1a72
Reviewed-on: https://chromium-review.googlesource.com/c/1185185
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610370}

This reverts commit a4831e9b.

Reason for revert: still flaky :(

Original change's description:
> Reland "Update BrowsingDataRemoverBrowserTest to include MediaLicenses"
> 
> Original change's description:
> > MediaLicenses can be cleared from the ClearBrowsingData dialog, so update the
> > BrowsingDataRemoverBrowserTest to check them as well. This uses the test-only
> > External Clear Key CDM to store the license in the file system, if it is
> > available.
> 
> This reverts commit e9fc38c7.
> 
> The original CL was flaky due to Mac's only saving file timestamps to
> second granularity. As a result it was possible for the newly created license
> to be saved with a timestamp prior to the current actual time, and deleting
> "old" licenses would include it in the deletion. Change is to wait for some
> time on Macs only to ensure that the "new" license has a later timestamp.
> 
> BUG=808690,879812
> TEST=new browser_tests pass
> 
> Change-Id: Ibd7cf65b468f98af9aa583d3f320e54c8f3f223e
> Reviewed-on: https://chromium-review.googlesource.com/c/1345248
> Reviewed-by: Christian Dullweber <dullweber@chromium.org>
> Commit-Queue: John Rummell <jrummell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610211}

TBR=jrummell@chromium.org,dullweber@chromium.org

Change-Id: I31ee32ae7bb490ce799c92244f352e5a9a627552
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 808690, 879812, 907799
Reviewed-on: https://chromium-review.googlesource.com/c/1347367Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610369}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e89f85283d4c..df6d992630bc


Created with:
  gclient setdep -r src-internal@df6d992630bc

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I5a2b6ee2ccfb1e2019c887d30a9cf0a097a550ce
Reviewed-on: https://chromium-review.googlesource.com/c/1347727Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610368}

The new implementation landed already some time ago and is stable, so
we can delete the old implementation now.

R=mlippautz@chromium.org

Bug: chromium:860637
Change-Id: I3cffd1ef0f879d144c5705618165ca52542f3e15
Reviewed-on: https://chromium-review.googlesource.com/c/1345969Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610367}

The files used for FormStructureBrowserTest are snapshots of real web
sites. They can have link to online resources but should not need them
for the test to pass.
But if the network is really bad, the page can wait for the resource
loading to finish and timeout.
Preventing the resource loading will make the test faster and more
robust.

Bug: 896173
Change-Id: I16b02e1d7defd4d950e6ee4cd21bd0133b9ac957
Reviewed-on: https://chromium-review.googlesource.com/c/1346462
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610366}

Using wpt-import in Chromium 5128eeb5.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mkwst@chromium.org:
  external/wpt/cookies

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I69eb363f7926d16bed5d03ec85e1df4eb7cfb8cd
Reviewed-on: https://chromium-review.googlesource.com/c/1347781
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#610365}

The new FormData->PasswordForm parser lacks a fall-back pass for local
heuristics, if all passwords end up disqualified.

This CL implements that according to the design in
https://goo.gl/ERvoEN

Bug: 906584
Change-Id: I3d0fa466699d2472ad687a14b920943443e06d0f
Reviewed-on: https://chromium-review.googlesource.com/c/1344431
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610364}

This reverts commit 2bbd27e2.

Reason for revert: Suspected cause for media-related crashes: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/6886

Original change's description:
> Remove synchronous blocking from PipelineImpl::Stop().
> 
> We should be able to avoid this with careful use of a trampoline
> through the media thread after PipelineImpl::Stop() completes.
> 
> BUG=905506
> TEST=passes cq.
> 
> Change-Id: I6a9c1a0e578c48a66af85588879346d26009d2ab
> Reviewed-on: https://chromium-review.googlesource.com/c/1336659
> Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610327}

TBR=dalecurtis@chromium.org,xhwang@chromium.org,hubbe@chromium.org,sandersd@chromium.org

Change-Id: Icc496d243065d76268ac22c87a03cf959d1e4948
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 905506
Reviewed-on: https://chromium-review.googlesource.com/c/1347365Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610363}

https://crrev.com/c/1315959 and https://crrev.com/c/1341921 made it
possible to use SQLITE_DEBUG for SQLite fuzzers, which has uncovered
bugs. Unfortunately, the CLs unintentionally removed
ENABLE_SQLITE_API_ARMOR from non-fuzzing builds, reducing our ability to
catch API misuse.

This CL re-instates ENABLE_SQLITE_API_ARMOR for non-fuzzing builds, for
the reasons described above. It also removes
-Wno-implicit-function-declaration in return for a less intrusive
workaround in sqlite3_shim.c.

Bug: 900910
Change-Id: I6327fdcee173c384da0b3b62c1414b7b6126473f
Reviewed-on: https://chromium-review.googlesource.com/c/1345649
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610362}

Form-associated custom elements: customElements.define() retrieves information for form-associated custom elements.

customElements.define() retrieves 'formAssociated',
'formAssociatedCallback', and 'disabledStateChangedCallback' from the
specified constructor and its prototype.

ScriptCustomElementDefinitionBuilder is responsible for the retrieval,
and ScriptCustomElementDefinition and CustomElementDefinition store the
information.

Introduce a new runtime flag 'FormAssociatedCustomElements', and
'ElementInternals' flag is enabled by it.

The new behavior is behind the runtime flag.

Bug: 905922
Bug: https://github.com/w3c/webcomponents/issues/187
Change-Id: Ibb4fef33a278a24a58af658983eb2387fb8efcdd
Reviewed-on: https://chromium-review.googlesource.com/c/1343468
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610361}

This CL adds a wrapper around the WebLoadParams to be able to add params
that make sense only at the Chrome level.

Bug: 906598
Change-Id: I5bd710da4d38c9b9601a297e3f69aa7013ff91d2
Reviewed-on: https://chromium-review.googlesource.com/c/1346403
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610360}

Bug: None
Change-Id: I8707c7e1da02d838228f2a35492a4aba40e0dcf8
Reviewed-on: https://chromium-review.googlesource.com/c/1347578
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610359}

This is a reland of fa8a5d39

Original change's description:
> Fix selection jumping around when removing multiple items in cr-list.
>
> Previously, when the selected item is removed, the selection is changed
> to the index after where the old lead index was. When multiple items are
> removed, the logical next item may move multiple positions. Avoid this
> by moving to the item that hasn't been removed from prior to the
> permutation - using its position after the permutation.
>
> Bug: 708299
> Change-Id: I9393c9f00d5453ef3c3d5378758bb63ed29c43b7
> Reviewed-on: https://chromium-review.googlesource.com/c/1345709
> Reviewed-by: calamity <calamity@chromium.org>
> Commit-Queue: Sam McNally <sammc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610019}

Bug: 708299
Tbr: calamity@chromium.org
Change-Id: I4de9726b919f88a1efe98f036687de07b23715c2
Reviewed-on: https://chromium-review.googlesource.com/c/1347630Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610358}

This flag does not need to be in about:flags anymore. We do not expect
an end user to disable WebAssembly anymore.

R=titzer@chromium.org, ellyjones@chromium.org

Bug: chromium:907408
Change-Id: I2653d806194caf88c5e4501f84ae76421f4c2449
Reviewed-on: https://chromium-review.googlesource.com/c/1345972Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610357}

This adds a test that does the following:
- Writes to a canvas with a cors same-origin image
- Writes to a canvas with a cors cross-origin image from the same URL
- Tests that the canvas is tainted after the second step.

Bug: 907047
Change-Id: Ie231b442eb9b55c642b3957c065555e6f4997a83
Reviewed-on: https://chromium-review.googlesource.com/c/1347952
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610356}

Bug: 907073
Change-Id: I86883cc5326ba3a31a588fc1e1e3d7779cbf1df9
Reviewed-on: https://chromium-review.googlesource.com/c/1347960Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610355}

Bug: 863341, 891670
Change-Id: If583048e9efcc14ab1456153480d1ab2847eb869
Reviewed-on: https://chromium-review.googlesource.com/c/1347271
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610354}

NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: I691fff46ceb59f935f12b352a1f34b081728e302
Reviewed-on: https://chromium-review.googlesource.com/c/1345971Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610353}

Migrates three services (media, cdm, and shape_detection) away from some
deprecated service APIs and onto new ones. Namely ServiceBinding and
ServiceKeepalive are used in lieu of ServiceContext and
ServiceContextRef, and regular unit tests are used instead of the
deprecated ServiceTest framework.

Bug: 891780,906239
Change-Id: I3302f35747702ae8cf39f6f1e33b416e3ec180b2
Reviewed-on: https://chromium-review.googlesource.com/c/1344882
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610352}

When the directory contents is replaced, the selection is informed, and
thus it clears check select mode. Once the new contents is swapped in,
the check select state is lost. If check select mode was enabled and
there was a selection, re-enable check select mode once the directory
contents replacement is complete.

Bug: 773989
Change-Id: I5859ece283dd10aca03310389174726fd18110e2
Reviewed-on: https://chromium-review.googlesource.com/c/1347964Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610351}

This reverts commit 6cd7b732.

Reason for revert: See https://crbug.com/907758
Findit found culprit 610287 with 75% confidence.

Original change's description:
> Add default sanitizer options for Windows.
> 
> strip_path_prefix is needed for Predator to work on ClusterFuzz.
> 
> R=​ochang@chromium.org
> CC=​metzman@chromium.org
> 
> Change-Id: Ib800a54c5f95176ef4acd292f935d6405529cf8f
> Reviewed-on: https://chromium-review.googlesource.com/c/1345570
> Reviewed-by: Alexander Potapenko <glider@chromium.org>
> Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org>
> Reviewed-by: Oliver Chang <ochang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#610287}

TBR=eugenis@chromium.org,glider@chromium.org,inferno@chromium.org,ochang@chromium.org

Change-Id: I4a72cbced73bd0ef1d5c9fe723f28e45fab2fd24
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1347965Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610350}

The share trace notification now has an action.
Given that the test doesn't test the action (and
any future ones), this removes the expectation that
there aren't any.

TBR=twellington@chromium.org

Bug: 907659
Change-Id: Ieb5b9f450e605e47cd068f4d99c1c98708961260
Reviewed-on: https://chromium-review.googlesource.com/c/1347250
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610349}

Bug: 907359
Change-Id: I1e44e7b452e5713b854da68669a72e9e3aa79326
Reviewed-on: https://chromium-review.googlesource.com/c/1345757Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610348}

In order to do query time logging, WindowFeatures and MRUFeatures
have to be merged into current TabFeatures.
Which also leads to modify three other places:
(1) how TabFeatures is calculated in TabActivityWatcher.
(2) how TabFeatures is used in CalculateReactivationScore.
(3) how TabFeatures is logged to ukm.

To be more specific of the change:

(1) Extending TabFeatures:
chrome/browser/resource_coordinator/tab_ranker/tab_features.h
chrome/browser/resource_coordinator/tab_ranker/tab_features.cc
chrome/browser/resource_coordinator/tab_ranker/tab_features_unittest.cc

6 extra fields is added to TabFeatures (4 from WindowFeatures, 2 from
MRUFeatures).
2 helper functions are added
PopulateTabFeaturesToRankerExample (for inference)
PopulateTabFeaturesToUkmEntry (for logging)

2) tab_score_predictor
tab_score_predictor can simply take TabFeatures as input.
chrome/browser/resource_coordinator/tab_ranker/tab_score_predictor.h
chrome/browser/resource_coordinator/tab_ranker/tab_score_predictor.cc
chrome/browser/resource_coordinator/tab_ranker/tab_score_predictor_unittest.cc

(3) For slight different logging.
chrome/browser/resource_coordinator/tab_metrics_logger.h
chrome/browser/resource_coordinator/tab_metrics_logger.cc
chrome/browser/resource_coordinator/tab_metrics_logger_unittest.cc

LogBackgroundTab is changed to LogTabMetrics which basically logs a
full TabFeatures.
LogBackgroundTabShown and LogBackgroundTabClosed are also unified as
LogForegroundedOrClosedMetrics to avoid getting more and more
parameters.

(4) For Triggering of logging.

chrome/browser/resource_coordinator/tab_activity_watcher.h
chrome/browser/resource_coordinator/tab_activity_watcher.cc
chrome/browser/resource_coordinator/tab_activity_watcher_browsertest.cc

The triggering logic is not changed.
Only two helper functions are added:
GetTabFeatures (returns TabFeatures of current tab)
LogForegroundedOrClosedMetrics (gets ForegroundedOrClosed metrics of
current tab and logs to ukm.)

5) tools/metrics/ukm/ukm.xml

8 extra metrics are added to "TabManager.TabMetrics", among which:
"MRUIndex", "TotalTabCount", "TimeFromBackgrounded" are moved from
ForegroundedOrClosed event.

"WindowIsActive", "WindowShowState", "WindowTabCount", "WindowType"
are moved from WindowMetrics event.

"NumReactivationBefore" is the only newly added event which is
currently estimated offline based on TabMetrics; now we can have more
precise value by directly logging it.

Bug: 900454

Change-Id: I705c1c144be4c3df0d5b67a7fe5f2d1afa10f2c9
Reviewed-on: https://chromium-review.googlesource.com/c/1337139Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Charles . <charleszhao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610347}