- 12 Jul, 2018 40 commits
-
-
Sean DuBois authored
This is a reland of 0bd5cafd The original implementation would incorrectly try to use other pixel formats besides COLOR_FORMAT_YUV420_SEMIPLANAR and COLOR_FORMAT_YUV420_PLANAR Original change's description: > Test H264VideoEncodeAndValidate would fail on devices that don't > support COLOR_FORMAT_YUV420_SEMIPLANAR. This make it so the test > queries the encoder, and then take the color format from the > returned set. > > R=braveyao@chromium.org > > Bug: 860559 > Change-Id: I524a7e803e9781960a99308834bac4d361e0c442 > Reviewed-on: https://chromium-review.googlesource.com/1127469 > Reviewed-by: Weiyong Yao <braveyao@chromium.org> > Reviewed-by: John Rummell <jrummell@chromium.org> > Commit-Queue: Weiyong Yao <braveyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#573361} R=braveyao@chromium.org Bug: 860559 Change-Id: If2926cb692910fcd8672ddefcf0c4e45e5998e10 Reviewed-on: https://chromium-review.googlesource.com/1132342 Commit-Queue: Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#574730}
-
tzik authored
This CL replaces base::Timer with its subclasses. As base::Timer changes its behavior subject to its construction time flags, that makes hard to see the actual timer behavior, especially it's unclear when a timer is injected from other components. Also, that OnceCallback support of base::Timer is hard to implement on the dynamically determined invocation pattern. Bug: 850247 Change-Id: I842cb4ffc6eeb2715b7abd710a232230fae627bf Reviewed-on: https://chromium-review.googlesource.com/1128779Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#574729}
-
Patrick Monette authored
This will be used by the IncompatibleApplicationsUpdater and ModuleBlacklistCacheUpdater instances to re-analyze a module when it loads into the process. Bug: 846953 Change-Id: I327fce954cc281dd312732823ef168a4086ea787 Reviewed-on: https://chromium-review.googlesource.com/1135634Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#574728}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/39de3d225856..66447ba64fcc git log 39de3d225856..66447ba64fcc --date=short --no-merges --format='%ad %ae %s' 2018-07-12 sadrul@chromium.org trace-viewer: Show a link to codesearch. 2018-07-12 dtu@chromium.org [pinpoint] Use ntpath.join instead of manual joining. 2018-07-12 dtu@chromium.org [pinpoint] Add unit test for JobState when adding a midpoint. 2018-07-12 simonhatch@chromium.org Dashboard - Optimize histogram_set.ReplaceSharedDiagnostic 2018-07-12 cphlipot0@gmail.com [Telemetry] Fix crash caused by unhandled atrace timeout 2018-07-11 benjhayden@chromium.org Add /api/describe/$test_suite. Created with: gclient setdep -r src/third_party/catapult@66447ba64fcc The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:862666 TBR=sullivan@chromium.org Change-Id: If765fc1ce617c13fa0f24ba128ef28c63fe61e68 Reviewed-on: https://chromium-review.googlesource.com/1135615Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574727}
-
Wei Li authored
In fullscreen mode, the height of the title bar should be as regular size, not as the regular tab strip height. We can not create a new class for fullscreen since that will trigger an NSThemeFrame assert error in reacquireToolbarViewFromFullScreenWindowAndShow(); we can not directly check styleMask in _titleHeight() function because that may not reflect its fullscreen status. This CL introduces a variable and records its fullscreen status in setStyleMask(). The title bar height is decided based on that variable. BUG=825968,831219 Change-Id: I2e827e31f6e7769344584e2ff9ddd5c4efedc419 Reviewed-on: https://chromium-review.googlesource.com/1132135Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#574726}
-
khmel@google.com authored
This also shows notification when this attempt happens. TBR=xiyuan@chromium.org TEST=Manually and unit_tests extended BUG=841939 Change-Id: I6cdb770374d60c4e56539b1fa1d460b011e6bf21 Reviewed-on: https://chromium-review.googlesource.com/1134509 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#574725}
-
Dan Zhang authored
In fuzzing test, fuzzer might send any illegal data to quic. In this case, peer bug shouldn't be captured via DFATAL. Also add EXPECT_QUIC_PEER_BUG macro which is a no-op in chromium. R=zhongyi@chromium.org Bug: 862488 Change-Id: Ic4547cdcc4b7aeb232c9428235aa33ae668659c7 Reviewed-on: https://chromium-review.googlesource.com/1135286Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#574724}
-
Jerome Jiang authored
https://chromium.googlesource.com/webm/libvpx.git/+log/03abd2c8f358..829d1b2098b5 $ git log 03abd2c8f..829d1b209 --date=short --no-merges --format='%ad %ae %s' 2018-07-11 jzern test-data.sha1: update crbug-1539.rawfile 2018-07-11 jzern test-data.mk: add missing crbug-1539.rawfile entry 2018-07-09 jianj vp9 svc: Add test for intra-only for 1 SL. 2018-07-10 jzern decode_test_driver: break decompress loop on error 2018-07-10 jingning Fix the denominator in tpl model 2018-07-10 jingning Enable tpl model only for ARFs 2018-07-10 jingning Properly set the is_valid flag in tpl_frame 2018-07-10 marpan vp9: Initialize source variance in nonrd-pickmode. 2018-07-09 jzern vp9_encoder: only alloc tpl stats if enabled 2018-06-23 jzern vpxdec,raw_read_frame: fix eof return 2018-04-11 marpan vp9-svc: Intra-only frame for spatial layers. 2018-07-08 lu_zero [VSX] Add support to Power9-only vec_absd 2018-06-28 ssilkin vp9-svc: add more command line options to test app. 2018-06-22 zoeliu Add hierarchical structure based ref frame update 2018-07-02 jingning Add enable-tpl-model guard 2018-06-26 ssilkin vp9-svc: fix strings concatenation in test app. Created with: roll-dep src/third_party/libvpx/source/libvpx R=johannkoenig@google.com Change-Id: I6859fe93ca4eaf7e960424c79726c9f25cfa72c9 Reviewed-on: https://chromium-review.googlesource.com/1135515Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#574723}
-
Zhiqiang Zhang authored
This CL checks GMS APK version before enabling CAF. The reason is that the current SDK version is 12.0.1, while we require the APK version to be 12.6.0 or above to make it fully functional (this is to avoid intializing the SDK in Activity#onCreate()). Currently we are using a fallback implementation to check GMS APK version. Ideally this should be done via the versioned GoogleApiAvailability.isGooglePlayServiceAvailable() API. However this versioned API is only added in a later version. The downstream implementation is calling the versioned API directly. After the upstream SDK version gets updated, we can just call the versioned API directly. Bug: 711860 Change-Id: Iec5f84cffcc5c55fd303255b91a7f187c79b15cb Reviewed-on: https://chromium-review.googlesource.com/1132474Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#574722}
-
Henrique Grandinetti authored
Bug: 860674 Change-Id: Iac33adab459abf7bae5f4fae513eea5c06335412 Reviewed-on: https://chromium-review.googlesource.com/1133460Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@google.com> Cr-Commit-Position: refs/heads/master@{#574721}
-
Francois Doray authored
Previously, a tab was proactively discarded when it had spent T time hidden, where T depends on the number of non-discarded tabs and the amount of physical memory. Unfortunately, that meant that if a user kept Chrome open during the night without touching it, all hidden tabs were discarded in the morning. With this CL, we use the "Chrome usage time since hidden" to determine if a tab should be proactively discarded. That will prevent the unwanted behavior of finding all tabs discarded after a long period of inactivity. Bug: 775644 Change-Id: Ie45ddfc07df782adeb32e3334a97bacaec429d45 Reviewed-on: https://chromium-review.googlesource.com/1130470 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#574720}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8b17db68..6234bd45 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If18a3fa6eca5568e52e21c64e3b31c5081e21300 Reviewed-on: https://chromium-review.googlesource.com/1134599Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574719}
-
Hector Carmona authored
Shows the page on start up if the NuxGoogleApps feature is enabled. Bug: 832938 Change-Id: Ibec2d3cb15d8922d4b8d475dca71671a6a02878a Reviewed-on: https://chromium-review.googlesource.com/1115475Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#574718}
-
liberato@chromium.org authored
If AbstractTexture drops its reference to the underlying texture, then that texture might have been freed. This happens when the gl stub is lost. Previously, MCVD assumed that the CodecImage attached to the texture was valid. However, if the AbstractTexture has dropped its ref to the texture, and there are no other refs, then this assumption isn't right. This CL checks if the AbstractTexture still has a TextureBase before referencing the CodecImage. An alternate approach of holding a scoped_refptr to the CodecImage in the callback would also work, but might keep the CodecImage around longer than it should when the stub is destroyed. This can hold the MediaCodec open longer if the CodecImage has an unrendered codec buffer. Bug: 863012 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If83a9eb0c27d6eb8e995424bdf71f7f7bc93590d Reviewed-on: https://chromium-review.googlesource.com/1135697Reviewed-by:
-
Henrique Grandinetti authored
The function that calculates wheter the time window limit of the current day is active, had a wrong logic. Bug: 860679 Change-Id: Iafaaa54e36424033adaf384cdbc9c15d7aa2328e Reviewed-on: https://chromium-review.googlesource.com/1133459Reviewed-by:
-
Ian Clelland authored
This change brings the OriginTrials namespace in line with Blink coding standards, and gets the test methods to match the corresponding methods in RuntimeEnabledFeatures. Change-Id: I2b91fbed4b675d55680996b101a110a98047091c Reviewed-on: https://chromium-review.googlesource.com/1135442Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#574715}
-
Ken MacKay authored
Allow matching audio streams to be redirected to a different output. Bug: b/73284499 Change-Id: I9eae9d945728e87a6cef299e24632f19860bc8e7 Reviewed-on: https://chromium-review.googlesource.com/1130998 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#574714}
-
Henrique Grandinetti authored
The used time should be reset once the time usage limit is set. Bug: 860676 Change-Id: I1d9650d298041caf0b6c2f7321f8263727924b60 Reviewed-on: https://chromium-review.googlesource.com/1134058Reviewed-by:
-
Francois Doray authored
With this CL, the total Chrome usage time measured by UsageClock is recorded in a LifecycleUnit when it is hidden. In an upcoming CL, this will be used to discard a LifecycleUnit after a given amount of Chrome usage time has elapsed since it was hidden. We also record the wall time when a LifecycleUnit is hidden, because freezing occurs when a LifeycleUnit has been hidden for a given amount of wall clock time, not Chrome usage time. Bug: 775644 Change-Id: I76d504e9bbf3eb86ded1203e4e117086faf93277 Reviewed-on: https://chromium-review.googlesource.com/1133593 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
-
Nicolas Pena authored
This CL changes Blink code from using Count(delta.InMilliseconds()) to: * UMA_HISTOGRAM_TIMES where possible. * Otherwise, UMA_HISTOGRAM_CUSTOM_COUNTS if possible. * Otherwise, saturated_cast. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I4f6e2ae0fb318b906ec75c546bea519cd130b09e Reviewed-on: https://chromium-review.googlesource.com/1134083 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
-
Karan Bhatia authored
This CL changes RulesMonitorService::HasRegisteredRuleset to take an extension_id instead of an extension pointer. BUG=None Change-Id: If6d220b7bcaf9be473ff819961f5ed9fe67f681f Reviewed-on: https://chromium-review.googlesource.com/1134519Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#574710}
-
Jared Saul authored
Bug: 848955 Change-Id: I8febd9c3471b58b962d3706eede4be506b092044 Reviewed-on: https://chromium-review.googlesource.com/1134089Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#574709}
-
Peter Kvitek authored
Browser flags that are required for BeginFrameControl are now set only for compositor specific tests thus preventing virtual time flakyness. Reinstate VirtualTimeErrorLoop test since this change fixes its flakiness. Change-Id: I0b01a81df1b8be63da316b27f7404f929f1e0fd1 Reviewed-on: https://chromium-review.googlesource.com/1133711Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Cr-Commit-Position: refs/heads/master@{#574708}
-
Nate Chapin authored
Bug: 31666 Change-Id: I8db30dee7c6b72430eb4083536fca73606de76e8 Reviewed-on: https://chromium-review.googlesource.com/1130101 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#574707}
-
John Abd-El-Malek authored
ResourceContext is deprecated, and after r567879 it returns nullptr when network service is enabled. Instead get the HostResolver from the URLRequestContext. Also remove ResourceContext::GetHostResolver() as it's no longer used. Bug: 853696 Change-Id: Ic09dac09f14e4aaf0e20dd990246cc51ae35e933 Reviewed-on: https://chromium-review.googlesource.com/1135366Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#574706}
-
Will Harris authored
https://helpx.adobe.com/security/products/flash-player/apsb18-24.html BUG=412078 TBR=jschuh@chromium.org Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iecc32fe539d6d16418086f9d8b4e44fde19bdd69 Reviewed-on: https://chromium-review.googlesource.com/1135713 Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#574705}
-
Chromium WPT Sync authored
Using wpt-import in Chromium a7edd65b. With Chromium commits locally applied on WPT: a9045946 "Add a fail-fast for longtask layouttests" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21190 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org, mek@chromium.org: external/wpt/FileAPI TBR=foolip No-Export: true Change-Id: I99e9ecbe3e626ec461f4663c7d48a6896f6a9616 Reviewed-on: https://chromium-review.googlesource.com/1135585 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#574704}
-
Tibor Goldschwendt authored
In order to implement synchronized proguarding we cannot have multiple R class with the same package. Thus, prevent creation of R files with manifest's package when creating APKs. Bug: 862696 Change-Id: I51253c0434f18e19ea627710beaa85b8690b175c Reviewed-on: https://chromium-review.googlesource.com/1134414Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#574703}
-
Yiming Zhou authored
This change adds a feature that allows the Action Recorder Extension to detect when a user presses the Enter key on a page, and records this action. Pressing the Enter key is a common action that a user invokes to submit a form. Bug: 855284 Change-Id: Ia0ec4ab99683266f09a422a4f7ae24fe52eb0b0b Reviewed-on: https://chromium-review.googlesource.com/1135523Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#574702}
-
Ehsan Karamad authored
When provisional load is committed in FrameLoader and the corresponding frame is a LocalRoot, the EventListenerProperties are reset to none for touch and wheel listeners. This update is then propagate through render widget and LayterTreeHost to the browser and the CC correspondingly. However, if the local root is provisional the call is dropped in ChromeClientImpl. This would include all cross-process navigations which end up in a provisional frame. This change will make sure the initial updates for EventListenerProperties for a local root are sent after WebLocalFrameClient is notified about committing provisional load. Bug: 850994 Change-Id: I686ab51277bf675d93bd744d6d0208977ac06b5c Reviewed-on: https://chromium-review.googlesource.com/1126329 Commit-Queue: Ehsan Karamad <ekaramad@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#574701}
-
Robbie McElrath authored
This migrates PrivetTrafficDetector from using net::NetworkChangeNotifier to content::NetworkConnectionTracker, which works with the network service enabled. Bug: 859134 Change-Id: I06f2ecbe142bbed9a8772f69ab109b0c0dc32581 Reviewed-on: https://chromium-review.googlesource.com/1123681Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
-
erikchen authored
On macOS 10.10, AppKit appears to use the test's generated events to asynchronously reactivate the first window. There's no way to tell when this asynchronous reactivation will happen, so just avoid checking the assertion in the test. This problem appears constrained to how we generate test events, and not to the actual behavior of Chrome. Bug: 862859 Change-Id: Ibab56946bef3aea9aac3123d3d8aefdb7974d063 Reviewed-on: https://chromium-review.googlesource.com/1135305Reviewed-by:
-
Moe Ahmadi authored
This reverts commit 77318515. Reason for revert: This change caused a regression (crbug.com/860225). The cause of the regression is that when user focuses a field in order to edit it, Autofill::OnFormsSeen is called which in turn updates the cached form with the new user entered values. Once submitted, form values are discarded as they're thought to be the initial form values on page load. In its current implementation Autofill::OnFormsSeen is only intended to be called on page load. Original change's description: > [AF][IOS] Scan page for form changes when a field is focused > > This CL fixes a regression caused by crrev.com/c/1012979. Previously, > AutofillAgent would scan the whole page on form activities due to the > possiblity of Autofill having been enabled after page load. > crrev.com/c/1012979 replaced that logic in favor of observing the Pref > directly. This has a side effect where previously hidden fields can go > unnoticed by AutofillManager. This CL fixes that regression by scanning the > page when a field is focused. All fields receive focuse before their value > is set by Autofill, therefore, AutofillManager can get notified of > previously hidden fields. > > Bug: 855696 > Change-Id: I175bf90e12d1ca356b746e6347943a295063c288 > Reviewed-on: https://chromium-review.googlesource.com/1112493 > Reviewed-by: Olivier Robin <olivierrobin@chromium.org> > Commit-Queue: Olivier Robin <olivierrobin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#570713} TBR=olivierrobin@chromium.org,mahmadi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 855696, 860225 Change-Id: Icc39e67e6d502d75451dbec83d6271255639ee4c Reviewed-on: https://chromium-review.googlesource.com/1135671 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#574698}
-
Martin Kreichgauer authored
This updates browsing data deletion for DATA_TYPE_PASSWORDS to call device::fido::mac::DeleteWebAuthnCredentials, which deletes credentials created by the macOS platform authenticator from the OS keychain. Also combine the two Touch ID specific configuration methods in {Chrome,}AuthenticatorRequestDelegate and introduce a static variant for Chrome. Bug: 678128 Change-Id: I0034e0815da068fb27c1ea60cad95f958956838e Reviewed-on: https://chromium-review.googlesource.com/1125177 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:Kim Paulhamus <kpaulhamus@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#574697}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/798ee75d2365..895617fa9bc3 git log 798ee75d2365..895617fa9bc3 --date=short --no-merges --format='%ad %ae %s' 2018-07-12 buildbot@webrtc.org Roll chromium_revision efbdada3..f7c234b0 (574489:574598) 2018-07-12 magjed@webrtc.org Android: Add helper functions for comparing H264 codecs 2018-07-12 saza@webrtc.org Remove useless import of arm.gni Created with: gclient setdep -r src/third_party/webrtc@895617fa9bc3 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I07750ee2f3c028532fb0dfbfa0386eeeb119c8f8 Reviewed-on: https://chromium-review.googlesource.com/1135612Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#574696}
-
Nick Burris authored
Chrome runs into a fatal error when the cleaner detects unwanted software. This is because ChromeCleanerScannerResults is created in the IO thread, and ProfileManager::GetLastUsedProfile requires the UI thread. The tests passed because they run a test browser process. - Extract extension name fetching to a separate function. - Call this function in tests so they're not affected. - Follow-up CL: Call this function once the scanner results are on the UI thread, before they're sent to the web UI. Bug: 853339 Change-Id: I9cc2425f7b196e923a22b2afd1e8eee7fca61f5b Reviewed-on: https://chromium-review.googlesource.com/1135194 Commit-Queue: Nick Burris <nburris@google.com> Reviewed-by:
proberge <proberge@chromium.org> Cr-Commit-Position: refs/heads/master@{#574695}
-
Greg Kraynov authored
cc::OrderedSimpleTestTaskRunner isn't used there anymore. Bug: 841735 Change-Id: I88a5bfa2ebaf01a08943396ce20f63c483a19b3a Reviewed-on: https://chromium-review.googlesource.com/1133177Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#574694}
-
spqchan authored
Separate BrowserWindowTouchBarMac into two classes: BrowserWindowDefaultTouchBar and BrowserWindowTouchBarController. BrowserWindowTouchBarController determines what touch bar should be used for browser window. BrowserWindowDefaultTouchBar creates a default touch bar for the browser. These changes are split from a bigger change to hook up touch bar support for web textfield in MacViews: https://chromium-review.googlesource.com/c/chromium/src/+/1132597 Bug: 856391 Change-Id: I9be31c65bd0acc2ec4d39b5e2f6b06fc30e36bf7 Reviewed-on: https://chromium-review.googlesource.com/1133705 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
-
Ben Pastene authored
And alphabetize the list. R=hinoka Change-Id: I28d7c354c153f848fae7098e57b67445345cb850 Reviewed-on: https://chromium-review.googlesource.com/1135691Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#574692}
-
Andrey Lushnikov authored
One-pager describing this refactoring: https://goo.gl/24gkCb Today, `content/` layer provides `permission_manager.h` interface that is supposed to be implemented by embedders and simultaneously used as API in `content/` layer. This leaves us with no place in content/ layer where we can put DevTools instrumentation. This patch separates content API from embedder interface. With this patch, `content/` layer provides 2 interfaces: - content::PermissionController - content-level API to manage permissions - content::PermissionManager - interface to be implemented by embedders. This is a delegate for content::PermissionController. This design enables DevTools to handle and override content permissions through DevTools protocol. The functionality will be encapsulated in PermissionController class. There's exactly one PermissionController for each BrowserContext. If embedder doesn't implement PermissionManager, then PermissionController rejects all permission requests. In a follow-up: - rename `content::PermissionManager` into `content::PermissionControllerDelegate`. - rename `BrowserContext::GetPermissionManager()` into `BrowserContext::GetPermissionControllerDelegate()`. - rename `TestBrowserContext::SetPermissionManager()` into `TestBrowserContext::SetPermissionControllerDelegate()`. R=dgozman TBR=sdefresne, tobiasjs, slan, thakis BUG=631464 Change-Id: I5f6f1ea5b28e284c462a5055d9b072f12f30ce19 Reviewed-on: https://chromium-review.googlesource.com/1111340 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#574691}
-
