- 14 Oct, 2019 40 commits
-
-
Renjie Tang authored
The data is generated by QUIC transport and has no user information. Change-Id: I001bb30a69129cdb5195c36e1ba3abc39628fd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838538Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Renjie Tang <renjietang@chromium.org> Cr-Commit-Position: refs/heads/master@{#705743}
-
Robert Sesek authored
In Catalina, sometimes (under unclear circumstances) the NS{Open,Save}Panel objects do not go through the remote panel view system. Instead, NSOpenPanel returns a non-exported AppKit type NSLocalOpenPanel, which does not have any is-a relationship to a NSSave/OpenPanel. The type checks in SelectFileDialogBridge cause failures when this happens, so relax them. Test: `./Chromium.app/Contents/MacOS/Chromium -NSUseRemoteSavePanel NO` and go to "data:text/html,<input type=file>" in the Omnibox. Upload a file and no crash should occur. Bug: 995476 Change-Id: If57acb94ef7d92784cdb5f6e48f4ea908f2bbdce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860995 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#705742}
-
Lei Zhang authored
TBR=rdevlin.cronin@chromium.org Bug: 1006634 Change-Id: Id72dd4892c52e53b7a892f6c7e0671bea65a67cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860043Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705741}
-
benwgold authored
Bug: 1010708 Change-Id: I8fb61b726ffd4ac964cdbe0909689e0b15021fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856619Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ben Goldberger <benwgold@google.com> Auto-Submit: Ben Goldberger <benwgold@google.com> Cr-Commit-Position: refs/heads/master@{#705740}
-
Xinghui Lu authored
Bug: 1014202 Change-Id: I2c985e1a87e9297c28d6ac10e89ceefeba0e08a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860876Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#705739}
-
Yuwei Huang authored
Catalina starts making /bin/sh the responsible process of the host service script even if we don't explicitly put sh in the launchd plist file, which is bad since the user would be tempted to grant permissions to sh and effectively all shell scripts. This CL reimplements the old script as an executable so that it (remoting_me2me_host_service) can become the responsible process and we can fallback to the old script with disclaim_responsibility in the future. We can technically launch host with disclaim_responsibility to make remoting_me2me_host the responsible process, but both of them still show up as ChromeRemoteDesktopHost on Preferences, while disclaim_responsibility uses an undocumented private API, so I prefer not doing so. The new binary is a drop-in replacement for the old script. The only change here is the removal of SIGKILL, SIGSTOP, and SIGCHLD from the signal forwarding list, as they are either not catchable or make no sense to forward. Bug: 1013692 Change-Id: I56eae7116fdc03aeb9bf754164618bcb84ae5ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857651 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#705738}
-
Darwin Huang authored
The ui/base/clipboard implementation allowed read or write for one of each PortableFormat, where PortableFormat was an enum. While only one of each clipboard format should technically be written to the platform clipboard, this also only allowed one PortableFormat::kData object to be written. The Raw Clipboard[1] feature needs to be able to write any amount of arbitrary representations to the system clipboard. Goals: - Support >1 Platform Representation in each write. - Support custom ordering of Platform Representations. - Pave the way for raw clipboard access. This CL: - Provides a way to write multiple platform representations. - Provides a maximum limit of clipboard formats registered in the browser instance, in platforms with relevant limitations. - Provides relevant conservative checks to avoid abuse. - Adds tests for writing multiple representations, verifying that multiple writes before each commit won't result in an overwrite. [1]: https://tinyurl.com/raw-clipboard-access-design Bug: 897289 Change-Id: I368d2ff0a849ae9475af3335e66c0795039342d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729965 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#705737}
-
Vikas Soni authored
Re-enable AImageReader on Qcom driver version 269.0 since few bug fixes related to memory regressions have been landed and we expect those fixes might have also fixed the crashed we were seeing with version 269.0. Will need to revert this CL if it causes crashes. Since the crashes are not reproducible locally, there is no other way to test this expect removing this driver version from blacklist and hence enabling it on ToT. Bug: 941716 Change-Id: Iaef04f2734271676b59537ade00bdbaf2db416e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860679Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#705736}
-
Evan Stade authored
This completes ScopedObserver updates for Windows, Mac and Android. iOS is the final holdout. Bug: 998625 Change-Id: I415fe2f6799fcd1631385c4a825027424d8bfc0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854520Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#705735}
-
Lijin Shen authored
On landscape view, the tab text is not on the middle of the tab. Add tabMaxWidth to make the text centered. Bug: 1013521 Change-Id: Ic5d1b173f368c1cf3910f86c718c77aaf618bd19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856848Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#705734}
-
khmel@chromium.org authored
This exposes test API to start, stop and get tracing results for active ARC app. TEST=Unit/browser tests, + test prototype BUG=b:141885826 Change-Id: I3870e724108098ebac47f97b08323f341e6ffe80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854790Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#705733}
-
Toni Barzic authored
The app list item focus ring is painted using stroke width 2, within bounds specified by AppListConfig::grid_focus_size(). This fixes discrepancy between what app list config specifies and what actually gets painted using stroke width 2: * the bounds were painted so the stroke was centered on the focus ring bounds * app list config specifies the outer focus ring bounds For kMedium and kSmall app list config (where the top focus ring bounds match the app list item bounds), this caused the top focus ring to be painted using width 1 instead of required 2 (as the upper part of the ring stroke was clipped by the app list item bounds). This updates the focus ring bounds calculation in AppListItemView to account for the stroke size - the target focus ring bounds are inset by half the ring width. BUG=1014128 Change-Id: Ib605afdc4312214a2a6d6c7c46251dd6fbe46000 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859578 Commit-Queue: Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#705732}
-
Matt Jones authored
This patch removes the custom dialog suppression logic in the premissions manager over to ChromeActivity (temporarily) where it can be used by all dialogs. While the bottom sheet is showing, no dialog should be able to be displayed. To support this change, the TokenHolder utility class has been moved from *fullscreen/ to the ui directory where it can be used by the ModalDialogManager. This was done as there are a number of features that individually want to enable or disable one or more types of dialog temporarily. The added token system prevents them from conflicting. This change was made to remove a dependent of getBottomSheet on ChromeActivity. Eventually the logic added to ChromeActivity will live in the RootUiCoordinator. Bug: 986310, 1002277 Change-Id: I727e61c036649d088584be6ebf54a68254998aed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816186 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#705731}
-
John Delaney authored
This CL adds intervention reporting to the heavy ad intervention. An intervention report is generated in the root ad frame and every child frame that is going to be unloaded by the intervention. This CL adds a new function SendInterventionReport() on the blink Frame mojo interface which is exposed by the public RenderFrameHost interface. In the browser process, we call SendInterventionReports on all frames in the subtree that will be unloaded, then load the error page. Because navigations are handled via mojo on the same message pipe as SendInterventionReports for each renderer, we are guaranteed that intervention reports are queued prior to the unload event being dispatched on each frame. Bug: 1003395 Change-Id: If0e8db49dc84b7ec48b6d8c8780361f372df074f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783300Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#705730}
-
Wenbin Zhang authored
Some of the timing data files under src/tools/perf/core/shard_maps/timing_data are no longer in use. This CL will simply removed those files. For those being removed, I've verified that no corresponding _map.json files exists. Bug: chromium:1013767 Change-Id: Iedbc01884d4e115d63ad8b044e8d7100716ce199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857643Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#705729}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/da1f90aa77b4..e7b5c5e99289 git log da1f90aa77b4..e7b5c5e99289 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 jmadill@chromium.org Metal: Use -weak_framework to support OS 10.10. Created with: gclient setdep -r src/third_party/angle@e7b5c5e99289 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Bug: chromium:1014228 Change-Id: Ia3b8f0ed48d8ea1d32d6258dfd2fd78faa0182fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859885Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705728}
-
Yusuf Ozuysal authored
This reverts commit 14f7eff8. Reason for revert: Crashes on Canary with voice input Original change's description: > [StartSurface] Add long press behavior for the fake box > > This CL is based on > https://chromium-review.googlesource.com/c/chromium/src/+/1824554/3 > > It is the fourth patch of splitting the bigger one > https://chromium-review.googlesource.com/c/chromium/src/+/1797069 > > It also unifies the record of the 'Android.OmniboxFocusReason' metrics. > > Screenshot: > https://drive.google.com/file/d/1YlxcF40SYtGVj9K0YgviQtnt5tdGFm-m/view?usp=sharing > > Bug: 982018, 1012275 > Change-Id: I16d045777164d49d72356af474e5c186c8318370 > Binary-Size: crbug.com/998206 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824126 > Commit-Queue: Ganggui Tang <gogerald@chromium.org> > Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705264} TBR=yusufo@chromium.org,gogerald@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 982018, 1012275, 1013943 Change-Id: I4a48866d15dc65e8f939fe1c86867754eea87604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860598Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#705727}
-
Lijin Shen authored
Chrome will crash if we select some bookmarks and then add them to their parent folder. This CL is trying to fix that. Bug: 1012651 Change-Id: I164de82a84bf922c5acdcea560a033291856708d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850418Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#705726}
-
Yusuke Sato authored
This will fix DCHECK failures on eve-arcvm. BUG=b:142144019 TEST=ARCVM starts even with dcheck_always_on = true Change-Id: I21755f2dd27fe3041fe3728355870703011b1092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860883 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#705725}
-
Lei Zhang authored
The test is flaky. TBR=sebmarchand@chromium.org Bug: 1014282 Change-Id: I5b0f151426a8463b750fe99dafe0f271d7fc02ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860978Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705724}
-
Collin Baker authored
This reverts commit 50cf2ba5. Reason for revert: doesn't update alert icon in some cases Original change's description: > Use RecentlyAudibleHelper for tab audibility updates > > This moves Browser away from listening to for INVALIDATE_TYPE_AUDIO for > audibility state changes. > > This is part of a refactor detailed in the attached bug. > > Bug: 846374 > Change-Id: I09cd8395c16bba812e9417f2ca6364d43864d39b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854214 > Commit-Queue: Collin Baker <collinbaker@chromium.org> > Reviewed-by: Peter Boström <pbos@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705204} TBR=pbos@chromium.org,collinbaker@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 846374 Change-Id: I1f38047e4c13a792a01b9c3a423816f4d3203006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860696Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#705723}
-
Marijn Kruisselbrink authored
Cleanups made possible by this will be done in follow-up CLs, this mostly just does the minimum to move all the code over to the UI thread, adjusting callers where needed. Bug: 1011534 Change-Id: I4222a68bf014b7590aa8c0f8ac6a8c1e5b9040da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847895Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jay Harris <harrisjay@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#705722}
-
Dmitry Gozman authored
The only usage is in DidAccessInitialDocument, where we access request_committed for the initial empty document loader. Initial empty document is never marked as committed anyway, because we do that in DidCommitProvisionalLoad which is not called for initial empty document. Bug: none Change-Id: I4e322f6099f458389120fd147f9aaec320cf6fcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857715Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#705721}
-
Dan Beam authored
Fixed: 1013832 Change-Id: I5563e500d7c5371fb61ce07b1336e9e5446cd052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857785 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#705720}
-
Asanka Herath authored
Also adds a reference to the dictionary for http_chunked_decoder_fuzzer. R=mmenke@chromium.org Bug: None Change-Id: I8927ecc9ca4619a6a3b842ac8ee71e281d1fbddb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857021Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#705719}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bb3e02a14bb9..8cd95dd1d376 git log bb3e02a14bb9..8cd95dd1d376 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 lamontjones@chromium.org config: mark gale non-critical. 2019-10-14 vapier@chromium.org cros lint: Update utf-8 BOM check 2019-10-14 gbiv@google.com afdo: yapf Created with: gclient setdep -r src/third_party/chromite@8cd95dd1d376 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I70d240cea2c7591ec525e3296f9b3f81bc89b182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859823Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705718}
-
Chris Harrelson authored
TBR=drott@chromium.org Bug: 1012600 Change-Id: If44af5d9f9428c9bd453d064bc4c88916685f09b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860276 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#705717}
-
Lei Zhang authored
Due to an issue in RenderProcessHostImpl, this test is failing flakily. Disable to make the tree greener. TBR=achuith@chromium.org Bug: 1010866 Change-Id: Idf0309e3ca569cef1116f8ddd2aeaed5cb088c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859878Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705716}
-
Siye Liu authored
Root cause is that if |DirectManipulationHelper::Initialize| returns false, then DirectManipulationHelper hasn't been properly initialized, and it's member |event_handler_| may still be nullptr. In destructor of DirectManipulationHelper, |DirectManipulationHelper::Destroy| is called which references |event_handler_| without a null check result in AV. Fix is to add null check before referencing |event_handler_|. Bug: 1001325 Change-Id: I815583413cb3e4c545568ea4ccba3b29366dedce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857546Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705715}
-
Christian Dullweber authored
Enable this DCHECK independently of flags. All current call sites seem safe and new ones shouldn't be added. Bug: 967668 Change-Id: Id9fcbfbbd2d76dcc7ac5cfecedc8c15add95741c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819499 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#705714}
-
Evan Stade authored
Registration for NOTIFICATION_PROFILE_ADDED is replaced with User::AddProfileCreatedObserver. Note that before this patch, the NotificationRegistrar was never actually used because it was broken by d5f8becb. Thus, this patch also fixes the (relatively minor) bug that while a profile was loading, GetNotifiers would no-op, rather than perform a delayed op. Bug: 268984 Change-Id: I3c68b5bb9610e486088e3e0c5cb23255453dab3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857538Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#705713}
-
Lei Zhang authored
LayerTreeHostTestSurfaceDamage.RunSingleThread_DelegatingRenderer is flaky and causing a lot of CQ runs to fail. TBR=ajuma@chromium.org Bug: 1014263 Change-Id: I229b53eceb6b239cce5d1615780b98c78833af98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860113Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#705712}
-
Eric Lawrence authored
The StartupObserver class monitors the startup of the browser and is used to defer BEST_EFFORT tasks until after the browser has completed startup and the active tab's page has finished loading. The StartupObserver previously failed to detect the case where the browser as launched to the url of a file download; it would then wait for an additional navigation in the first tab or would wait until a failsafe timeout was reached before indicating startup was complete. This change signals completion in the scenario where a file download takes place in the first tab. The failsafe timeout remains set at 3 minutes. Bug: 1006954 Change-Id: Ia1e056f1a54ccc561d1dcf306161470beefe42e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846099Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705711}
-
David Schinazi authored
Change-Id: I30891b73e8ecdc36e223e2df03d7ae4ae5c8ec16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860476 Commit-Queue: David Schinazi <dschinazi@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Auto-Submit: David Schinazi <dschinazi@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#705710}
-
Peter Boström authored
During refactoring in r703138 I forgot to install the new highlight-path generator. Bug: chromium:1013983 Change-Id: If39953bff877bf69066d954d1e7c04b042289636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860152Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#705709}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b6acae6d353d..ba9e1ff86fa4 git log b6acae6d353d..ba9e1ff86fa4 --date=short --no-merges --format='%ad %ae %s' 2019-10-14 cwallez@chromium.org Fix compilation in MSVC that was missing a <utility> include Created with: gclient setdep -r src/third_party/dawn@ba9e1ff86fa4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: Id6de729831fbe4977bf362c5ccec30117ca0fb52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859819Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705708}
-
Jack Lynch authored
This CL adds an axe accessiblity test for the Performance panel Event Log pane. Bug: 963183 Change-Id: Ibd3a63379e6baf65bd6ec7af9787dad620eeff1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721680 Commit-Queue: Jack Lynch <jalyn@microsoft.com> Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#705707}
-
Thanh Nguyen authored
This CL adds a Chrome flag to control the aggregated model search ranker Bug: 1006133 Change-Id: I255f0bf215ec2bb4e52aa3586dbdaf5717caf644 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858061Reviewed-by:
Tony Yeoman <tby@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#705706}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1c462ebc904c..fb632b91110c git log 1c462ebc904c..fb632b91110c --date=short --no-merges --format='%ad %ae %s' 2019-10-14 digit@google.com [linux]: Remove linux namespace. Created with: gclient setdep -r src/third_party/swiftshader@fb632b91110c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:140419396 Change-Id: I9140d644516ac8de0588312d43df32aee0bfe185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859820Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705705}
-
Brian Sheedy authored
Simplifies the process of running the GPU pixel tests locally by making them attempt to automatically detect if they are being run on a workstation instead of on a bot, as well as automatically determining the build revision. This removes the need to pass either --local-run or --build-revision when running locally. Bug: 1013358 Change-Id: Ie3fd2171d94fa4452b7f334c7bcdd5ab42705414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860677Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#705704}
-