- 27 Apr, 2018 40 commits
-
-
Oksana Zhuravlova authored
Bug: 799482 Change-Id: I925b822f11ac2464ef25cfb77175e9beeb3fa57b Reviewed-on: https://chromium-review.googlesource.com/1033925 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#554569}
-
John Budorick authored
Accidentally reenabled while disabling tests on Linux. TBR=dougarnett@chromium.org,timbrown@chromium.org Bug: 831838,837822 Change-Id: I6d0f126e73ff8eac0ed1b48c2eaa149a2be70e04 Reviewed-on: https://chromium-review.googlesource.com/1034014Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#554568}
-
Nicholas Verne authored
This runs the uninstall flow for crostini, which now includes stopping the concierge service then unloading the cros-termina component. Bug: 822507 Change-Id: I31cc40a3ad6732a55ff3f9ae47468751d996c6cf Reviewed-on: https://chromium-review.googlesource.com/1032353 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#554567}
-
Eric Orth authored
Useful to override to create specialized mocks or fakes that only care about a portion of the overall interface. Especially useful for mocks or fakes owned outside the network service code as the mocks can create an interface dependency on only the overridden methods. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id03bdcaab6d991fb1a79ddcaf4eaf0612fe64d52 Reviewed-on: https://chromium-review.googlesource.com/1026418 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#554566}
-
Jun Choi authored
DeviceOperation is an interface for Ctap{Register, Sign}Operation and U2f{Register, Sign}Operation, and will be a branching point for separation of logic between CTAP and U2F requests. CtapRegisterOperation is an implementation of DeviceOperation and is owned by MakeCredentialTask to handle dispatching CTAP MakeCredential request to an authenticator. Bug: 798573 Change-Id: I290ab7b3f686d4418d783723a0ab510f27362462 Reviewed-on: https://chromium-review.googlesource.com/1028792 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#554565}
-
https://skia.googlesource.com/skia.git/+log/5cb5c74efdac..34a388edbd27 $ git log 5cb5c74ef..34a388edb --date=short --no-merges --format='%ad %ae %s' 2018-04-27 csmartdalton ccpr: Remove canMakeClipProcessor 2018-04-27 liyuqian Reland "Reland "Reland "Exercise the threaded backend in test bots""" 2018-04-27 brianosman Add ASYNC trace macros Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=stani@chromium.org Change-Id: Id312399ace42628fc464aecb6415d5f2dad79707 Reviewed-on: https://chromium-review.googlesource.com/1033717Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554564}
-
Matthew Jones authored
A bug in TabModelObserver is causing a discrepancy in behavior between phone and tablet (which the tests depend on). This patch disables the tests on tablet while the issue is resolved. Bug: 837809 Change-Id: I344255ad86651da484cab20569239e851b376d9d Reviewed-on: https://chromium-review.googlesource.com/1034006 Commit-Queue: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#554563}
-
Matt Menke authored
In a followup CL, invalid UTF-8 characters will never be unescaped by the text methods. Bug: 829868 Change-Id: I71df885005f5faa9f72ac5ff6cfb2789c64ae846 Reviewed-on: https://chromium-review.googlesource.com/1024771Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#554562}
-
Chris Harrelson authored
M66 has launched, so we should stop running extra tests that might slow down the CQ. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iee9c064ea3fcdcb896ac268dbef94fad91853c0a Reviewed-on: https://chromium-review.googlesource.com/1034009Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#554561}
-
braveyao authored
In some recent testings it looks like there may be multiple PERMANENT capture error reported before the track is ended due to the first error report. So it's necesary to log the permanent error only once for one session. Bug: 831756 Change-Id: Icf969f0a1f1d644bd362811cf8658cabb7d3a3a1 Reviewed-on: https://chromium-review.googlesource.com/1033818Reviewed-by:
Zijie He <zijiehe@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#554560}
-
Kristian H. Kristensen authored
The underlay only works for opaque buffers, so make sure we don't promote anything with alpha. Bug: 789288 Change-Id: Id39b2220cec7258699668f09b149a5d62a0cec41 Reviewed-on: https://chromium-review.googlesource.com/1026872Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#554559}
-
Ahmed Fakhry authored
BUG=836026 Change-Id: Icf5733c284cfd8cc0fddc121ab781d30de65535a Reviewed-on: https://chromium-review.googlesource.com/1025222 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#554558}
-
https://pdfium.googlesource.com/pdfium.git/+log/3241bb3e98c0..65c255ad2076 $ git log 3241bb3e9..65c255ad2 --date=short --no-merges --format='%ad %ae %s' 2018-04-27 tsepez Fix illegal cast in core/fxge/win32/fx_win32_gdipext.cpp 2018-04-27 thestig Remove CJBig2_HuffmanTable::InitCodes(). 2018-04-27 tsepez Replace void* with CFX_GifPalette* in fxcodec 2018-04-27 hnakashima Fix focused day disappears in XFA MonthCalendar. 2018-04-27 hnakashima Update caret after changes that could move lines in XFA edit. 2018-04-27 thestig Change CJBig2_HuffmanTable to use struct JBig2HuffmanCode. 2018-04-27 thestig Adjust CJBig2_Context::HuffmanAssignCode(). 2018-04-27 tsepez Remove arguments from CPDFSDK_FormFillEnvironment methods (part 2) 2018-04-27 thestig Simplify CJBig2_Context::DecodeSymbolIDHuffmanTable(). 2018-04-27 thestig Use std::function in CJBig2_GRDProc. 2018-04-27 hnakashima Fix backspace on 1st character of a line erases the line break. 2018-04-27 thestig Disambiguate methods in CJBig2_GRDProc. 2018-04-27 thestig Simplify CJBig2_Context::FindReferredSegmentByTypeAndIndex(). 2018-04-27 tsepez Avoid potential duplicate unique_ptr to CPDF_Document from CPDFXA_Context. 2018-04-27 tsepez Remove argument from CPDFSDK_FormFillEnvironment::GetCurrentPage 2018-04-27 thestig Add DEPS include_rules for xfa/fwl. 2018-04-27 thestig Fix undefined behavior in AGG. 2018-04-27 thestig Do validation earlier in CPDF_SampledFunc::v_Init(). (try 2) Created with: roll-dep src/third_party/pdfium BUG=chromium:836361,chromium:709781,chromium:836361,chromium:746232 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3f93d2671a6cc6f854854c61eea6104ae84cc21e Reviewed-on: https://chromium-review.googlesource.com/1033831 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554557}
-
Karandeep Bhatia authored
This CL plumbs the ResourceContext to the WebRequestInfo structure through WebRequestProxyingURLLoaderFactory. This is necessary to fix NTPInterceptionWebRequestAPITest.NTPRendererRequestsHidden for the network servicification path. BUG=797461, 721414 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I2957c1ece0f8f7b44f15156aeb5e554b3a91ff01 Reviewed-on: https://chromium-review.googlesource.com/1029549Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#554556}
-
Dan Sanders authored
This fails on Mac when run in a headless content_shell. Also fixes an incorrect thread post bug in VdaVideoDecoder. Bug: 522298 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I09d397ee108920fc35e8aadc45d9b47840eb8686 Reviewed-on: https://chromium-review.googlesource.com/1033834Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#554555}
-
Min Qin authored
In incognito mode, we shouldn't write to the metadata cache. BrowserContext::GetPath() will return the path of the normal profile in incognito mode. BUG=778425 Change-Id: If1cd5d819d0b754010f60f776226c34d92e383f4 Reviewed-on: https://chromium-review.googlesource.com/1033540Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#554554}
-
Andrey Kosyakov authored
Bug: 836732 Change-Id: Ia8b1fbfca1cb1a30289337571e8db6a3163751ac Reviewed-on: https://chromium-review.googlesource.com/1033721Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#554553}
-
Emircan Uysaler authored
This CL makes sure that we produce a keyframe for every 100 frames when MediaRecorder uses HW encoder. Bug: 837450 Change-Id: Ifa1a674012085aa122a8e907ca1f88cb8a949e55 Reviewed-on: https://chromium-review.googlesource.com/1033181 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#554552}
-
Jay Civelli authored
Reenables the contentc browser test GetUserMediaVideoCaptureBrowserTest. RecoverFromCrashInVideoCaptureProcess with the network service as it seems to be passing now. Tbr: dpranke@chromium.org Bug: 729848 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Iac6246c6f7205dee0791da39f1e08da39a62af47 Reviewed-on: https://chromium-review.googlesource.com/1033955Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#554551}
-
Chris Harrelson authored
Filters which move pixels may move content which is originally outside of the cull rect or ancestor clip rects back into view. Therefore we should adjust the painting root to prevent ancestor clips and cull rects from clipping or culling out the source of the filter. Bug: 804670 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6e1032ecef5fcb5eabb6080bd2f17d8c479dc1e8 Reviewed-on: https://chromium-review.googlesource.com/1033347Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#554550}
-
Esmael El-Moslimany authored
Bug: 836988 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9d8123653fd77bc9142459d666a0e9697569cd94 Reviewed-on: https://chromium-review.googlesource.com/1029127Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#554549}
-
Steven Holte authored
This avoids the implicit recording on destruction and the need to have ukm_recorder to construct an entry, and no longer needs to be part of the UkmRecorder API. Since we now are DCHECK'ing against recording metrics not in ukm.xml we no longer need to have this API behind a friend whitelist. TBR=charleszhao,mlamouri,chrishtr Bug: 754892 Change-Id: I944ae698bd5ad4146411d5e11b945e21c1b52a98 Reviewed-on: https://chromium-review.googlesource.com/1027112 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Cr-Commit-Position: refs/heads/master@{#554548}
-
Sunny Sachanandani authored
The original motivation for this code was to workaround early swap ack on freon, but since freon isn't a thing anymore and we have a display compositor that actually performs the swap, it should be ok to get rid of it. This should improve throughput similar to main frame before activation. R=brianderson BUG=311213 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I5108c74a57ba201d25999989de8da4c7f81a5176 Reviewed-on: https://chromium-review.googlesource.com/1031892Reviewed-by:
Brian Anderson <brianderson@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#554547}
-
https://webrtc.googlesource.com/src.git/+log/169c7fd521da..658ad8816b7e $ git log 169c7fd52..658ad8816 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:833801,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7b0d1b8892886b8bc7c593cf407e147e3fcee689 Reviewed-on: https://chromium-review.googlesource.com/1033812Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#554546}
-
Jordy Greenblatt authored
I added the Google-G and Error Icon from UX. Bug: 835931 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I8ce9ed0b98b68ec6ba2b989f807d5bec1d840042 Reviewed-on: https://chromium-review.googlesource.com/1031733 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#554545}
-
Joshua LeVasseur authored
Change-Id: Ic09db430852c347d55b6ae3132610f7f62e76363 Reviewed-on: https://chromium-review.googlesource.com/1033579Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Joshua LeVasseur <jlevasseur@chromium.org> Cr-Commit-Position: refs/heads/master@{#554544}
-
John Budorick authored
TBR=nednguyen@chromium.org,perezju@chromium.org Bug: 837397 Change-Id: If29d26fefee43107ba6d51c3818e6fed37eaea7c Reviewed-on: https://chromium-review.googlesource.com/1032876 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#554543}
-
bsheedy authored
Adds the ability for tests to be notified when the native UI reaches a steady state instead of sleeping for arbitrary amounts of time. Bug: 826841 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I69428f5ea9b228771180a88df455f8ade67f6a32 Reviewed-on: https://chromium-review.googlesource.com/1026707 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#554542}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: Ia0d430d49a151ab0f33e0396207d074e2ec5cc23 Reviewed-on: https://chromium-review.googlesource.com/1033895Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#554541}
-
Varun Khaneja authored
Also add an enum to the CSD proto. Internal proto submitted as: http://cl/194432497 Bug: 796332 Change-Id: I7764d5063379b94853c656c97db4582c52ee56c3 Reviewed-on: https://chromium-review.googlesource.com/1012437 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#554540}
-
Chong Zhang authored
Disable 'NatGeo' on 'loading.desktop' and 'loading.desktop.network_service' (all desktop platforms) due to consistent failings. See bug for sample log. TBR=kouhei@chromium.org Bug: 837415 Change-Id: I12104ca9fa29abaa4aead932bf8fd6a763194146 Reviewed-on: https://chromium-review.googlesource.com/1031054Reviewed-by:
Chong Zhang <chongz@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#554539}
-
kylechar authored
Add some missing cases where we want to fallback on software compositing to VizProcessTransportFactory. 1. When GPU_FEATURE_TYPE_GPU_COMPOSITING is blacklisted in GpuFeatureInfo. 2. When ContextProvider creation fatally fails. This CL also cleans up the logic to make it easier to follow and removes an unnecessary subclass from VizProcessTransportFactory. Bug: 776050 Change-Id: I7d0e65ac224e649cad786246486fc40c9c841f27 Reviewed-on: https://chromium-review.googlesource.com/1030829 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#554538}
-
Daniel Blakemore authored
This reverts commit 20a36a40. Reason for revert: New API fails under unrelated tests. Rolling back to old API until this can be fixed. Original change's description: > Use new mailto handling setup API. > > Re-lands https://chromium-review.googlesource.com/1031050 after > fixes to downstream changes. > > Bug: 810904 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I2cb00c90d6d35cb7c4dd5cb8ac7c5ffb8746894f > Reviewed-on: https://chromium-review.googlesource.com/1033019 > Reviewed-by: Peter Lee <pkl@chromium.org> > Commit-Queue: Daniel Blakemore <danblakemore@google.com> > Cr-Commit-Position: refs/heads/master@{#554422} TBR=pkl@chromium.org,danblakemore@google.com Change-Id: Ib56bde2e2f8c608e67982507923110747e62f9fa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 810904 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1033547Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#554537}
-
Calder Kitagawa authored
A follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1028575 This moves patch_apply logic to check bounds of an equivalences from the call site of GetNext() to an internal function in the patch_reader. This means the equivalence consumer can use the equivalences without checking anything to do with bounds. I have manually tested that this doesn't appear to break any existing valid patches and it appears to catch all the same errors change 1028575 fixed so I can safely reverse that change. BUG: 837096 Change-Id: I84ccd9e1493f32d16eace4dd8e67586f559220d3 Reviewed-on: https://chromium-review.googlesource.com/1028836 Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#554536}
-
Max Moroz authored
TBR=liaoyuke@chromium.org Bug: 837816 Change-Id: I68b92ad5ec6e0f1d178ad89654abb77b46fb5830 Reviewed-on: https://chromium-review.googlesource.com/1033830Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#554535}
-
Dale Curtis authored
These tests were checking the memory usage values, but were not waiting for the demuxer memory report to come back from the media thread first. BUG=837729 TEST=gtest_repeat=25 on android. Change-Id: I65b4dd0079873389200de26bd2eba9efcd6499af Reviewed-on: https://chromium-review.googlesource.com/1033725Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#554534}
-
Gabriel Charette authored
These changes were scripted as part of the effort to restrict exposure of the raw MessageLoop*. Note that many static methods exposed on MessageLoopCurrent are also deprecated so it is very well possible that this is migrating to an already deprecated method. The goal of this pass is to reduce usage of MessageLoop::current() (and ultimately make it impossible to obtain the MessageLoop* statically). As such I will not edit this CL unless the script did something logically wrong. I defer to owners to fix highlighted usage of already deprecated APIs. Possible script screw ups / things to look out for in this review: - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against one (I will go over that in a separate pass). Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=mark@chromium.org Bug: 825327 Change-Id: I5266e83a811ad85b43bebf1cecebd73b744d3ec3 Reviewed-on: https://chromium-review.googlesource.com/1024491Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#554533}
-
Thomas Anderson authored
This reverts commit 61248f1a. Reason for revert: Suspected breaking component builds (bug 837817) Original change's description: > Add utils to read elf binary and get Build id > > Adds code to parse elf binary to get build id from > .note.gnu.build-id section. The build ID is needed to symbolize > heap dumps from the users. > > BUG=734705 > > Change-Id: If4365e232c060ba96071ba1e1c43618f9807e39c > Reviewed-on: https://chromium-review.googlesource.com/1028995 > Commit-Queue: Siddhartha S <ssid@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#554304} TBR=thestig@chromium.org,ssid@chromium.org Change-Id: If512434b55bcc912990e3997a86f6f93722b15fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 734705 Reviewed-on: https://chromium-review.googlesource.com/1033795Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#554532}
-
Aleks Totic authored
Bug: 837430 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib89a9e5aec3f0541b6b2b5866dab12107eae65e9 Reviewed-on: https://chromium-review.googlesource.com/1031556Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#554531}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/df1d991f..bf02b736 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Iec0714a8a6239808ee7df63fe849c1e0a618bc94 Reviewed-on: https://chromium-review.googlesource.com/1033447Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#554530}
-