GitLab

This is done with a multiple choice because later we will add another option:
"choose the cache backend at random", and make it the default.

BUG=173390,173381

Review URL: https://chromiumcodereview.appspot.com/13862014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193396 0039d316-1c4b-4281-b951-d872f2087c98

BUG=180082
TEST=Open chrome://settings/languages and add Portuguese(Brazil)


Review URL: https://chromiumcodereview.appspot.com/13702003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193395 0039d316-1c4b-4281-b951-d872f2087c98

Reserve 4 new experiment IDs for a refresh of our dev experiments, as the old IDs still haven't converged after the accidental user shuffle.


BUG=


Review URL: https://chromiumcodereview.appspot.com/13863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193394 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/13879008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193393 0039d316-1c4b-4281-b951-d872f2087c98

The delegate makes sure that the keyboard window does not get focus,
and that events are not consumed by the container window itself.

BUG=226986

Review URL: https://codereview.chromium.org/13726015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193392 0039d316-1c4b-4281-b951-d872f2087c98

Also make both backends use the same directory for files, and the same name for
the index file. Using the index file each backend will detect if the index
belongs to it. Hence, easier to make sure that both cache trees on disk are
mutually exclusive.

BUG=229437


Review URL: https://chromiumcodereview.appspot.com/13813015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193391 0039d316-1c4b-4281-b951-d872f2087c98

Name the parameters and comment on their meaning. I was adding another
one of these for checksums, and I found it was getting
confusing. These comments should help.

R=rvargas@chromium.org,pasko@chromium.org,felipeg@chromium.org
BUG=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193056

Review URL: https://chromiumcodereview.appspot.com/13757005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193390 0039d316-1c4b-4281-b951-d872f2087c98

Refactoring is underway to notify client of P2P socket that network is
congested. In the mean time pending packet limit is too small and causes
huge amount of packet loss, this makes WebRTC unusable.

This is a temporary fix to increase this pre-defined value to 32 pending
packets which accomodates 720p streams up to 5Mb/s.

BUG=228956, 229737

Review URL: https://codereview.chromium.org/13992004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193389 0039d316-1c4b-4281-b951-d872f2087c98

This patch allows us to have larger objects passed into the trace
framework which, at the point when we output tracing data, will
request they be converted to TraceFormat by calling the
AppendAsTraceFormat method.

BUG=


Review URL: https://chromiumcodereview.appspot.com/13590005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193388 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none


Review URL: https://chromiumcodereview.appspot.com/12722002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193387 0039d316-1c4b-4281-b951-d872f2087c98

Currently we report computed vsync intervals based on if they are in
an expected range and silently drop otherwise. The disadvantage with this
is that we're probably reporting noise caused by configuration changes
(monitor reconfiguration or moving a window between monitors). We may
also be papering over driver bugs.

Instead, we look for consistency between successive computed intervals
as a way of validating that there hasn't been a configuration change. In
this case, we can be more aggressive in error reporting to find driver bugs
(crash instead of silently drop).

BUG=221701


Review URL: https://chromiumcodereview.appspot.com/13861016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193386 0039d316-1c4b-4281-b951-d872f2087c98

GetResourceList is being deprecated along with Drive API v2 migration.
This CL replaces it with new methods Schedule and ContinueGetResourceList.

BUG=160932
TEST=Ran unit_tests and tested manually.


Review URL: https://chromiumcodereview.appspot.com/13913012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193385 0039d316-1c4b-4281-b951-d872f2087c98

> cc: Temporarily disable tile grid optimization
> 
> Tile grid currently introduces clipping problems which causes some parts
> of the canvas to not be rastered to, which causes slivers of odd looking
> content on the screen.
> 
> R=reveman@chromium.org
> BUG=224419
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/13581011

TBR=enne@chromium.org
Review URL: https://codereview.chromium.org/13879005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193384 0039d316-1c4b-4281-b951-d872f2087c98

The failure job was based on broken revision.
The root problem is already solved, so this re-enables the test.

BUG=229639
TEST=Ran try bot.


Review URL: https://chromiumcodereview.appspot.com/13907003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193383 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193382 0039d316-1c4b-4281-b951-d872f2087c98

control: https://codereview.chromium.org/13834006/
Review URL: https://codereview.chromium.org/13834007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193381 0039d316-1c4b-4281-b951-d872f2087c98

In this case, the databases was actually corrupted but the database classes did not try to repair.
After this CL lands, these corruption should be repaired correctly.

TEST="content_unittests: FileSystemDirectoryDatabaseTest.TestRepairDatabase_MissingManifest & FileSystemOriginDatabaseTest.DatabaseRecoveryForMissingManifestTest"
BUG=229773

Review URL: https://chromiumcodereview.appspot.com/13946004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193380 0039d316-1c4b-4281-b951-d872f2087c98

Introduces ui/keyboard/ which contains generic code for the control of the keyboard (right now, just creation of the container window).

Also includes the necessary changes to ash so that the keyboard is (always) displayed on ChromeOS builds when the --enable-virtual-keyboard flag is present.

BUG=226986

Review URL: https://codereview.chromium.org/13164002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193378 0039d316-1c4b-4281-b951-d872f2087c98

The actual CLs that contain the corresponding code are here:

https://codereview.chromium.org/13441008/
https://codereview.chromium.org/13619014/

This goes in first so that the code can be validated running try jobs.

BUG=chromium:186445
TEST=None

Review URL: https://codereview.chromium.org/13839026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193377 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193375 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jsbell

Review URL: https://codereview.chromium.org/13936004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193374 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True
BUG=


Review URL: https://chromiumcodereview.appspot.com/14052002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193373 0039d316-1c4b-4281-b951-d872f2087c98

BUG=224186
TEST=unittests


Review URL: https://chromiumcodereview.appspot.com/13833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193372 0039d316-1c4b-4281-b951-d872f2087c98

It seems https://codereview.chromium.org/8954009/ was a bit
overzealous. On 64 bit platforms, zlib.h attempts to use the 64 bit
API for all callers. But, we were not allowing that, making writing
portable code difficult. This CL updates our manglings in zlib.h so
that on a 64 bit platform the API defaults to the 64 bit version, as
intended.

This change is downstream of https://codereview.chromium.org/13564004/
and must land after it.

R=rsleevi@chromium.org,agl@chromium.org, brettw@chromium.org
BUG=None


Review URL: https://chromiumcodereview.appspot.com/13473020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193371 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193370 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/14053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193369 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193368 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jsbell

Review URL: https://codereview.chromium.org/14050002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193367 0039d316-1c4b-4281-b951-d872f2087c98

Also moving the dependencies of the handler to chromeos/:

NetworkUIData
from chrome/browser/chromeos/cros/network_ui_data*
to chromeos/network/network_ui_data*

NetworkPropertyUIData
from chrome/browser/chromeos/cros/network_ui_data*
to chrome/browser/chromeos/cros/network_property_ui_data*

CreateNetworkUIData
from chrome/browser/chromeos/net/onc_utils*
to chromeos/network/network_ui_data*

CertificatePattern
from chrome/browser/chromeos/cros/certificate_pattern*
to chromeos/network/certificate_pattern*

Certificate pattern matching (was a member function of CertificatePatern)
from chrome/browser/chromeos/cros/certificate_pattern*
to chrome/browser/chromeos/cros/certificate_pattern_matcher*

The only implementation change is in network_ui_data.cc in order to break dependency on EnumMapper.

NetworkUIData and CertificatePattern are data keeping classes only, and will eventually be replaced by ONC. However, we need them for backwards compatibility for a while.

BUG=180711

Review URL: https://chromiumcodereview.appspot.com/13454006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193364 0039d316-1c4b-4281-b951-d872f2087c98

Removed CSS codes that hides gear menu items but is not handled cr.ui.Menu class.
New codes hides gear menu items by using the 'hidden' attribute.

BUG=175662
TEST=Followed the steps written in bug report that reproduce the problem

Review URL: https://chromiumcodereview.appspot.com/13779006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193363 0039d316-1c4b-4281-b951-d872f2087c98

This is a part of Drive API v2 migration. On Drive API v2, the root resource
id is not fixed, while it is fixed on GData WAPI, which is "folder:root".
By this CL, the MyDrive root entry will be created when the "drive" (grand
root) is accessed for the first time, instead of creating it in
DriveResourceMetadata::Initialize.
Along with the change, this CL also implements the Fast-Fetch behavior
in ChangeListLoader::DoLoadDirectoryFromServcer.

BUG=174237
TEST=Ran unit_tests and tested manually on chromeos-chrome


Review URL: https://chromiumcodereview.appspot.com/13866009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193362 0039d316-1c4b-4281-b951-d872f2087c98

This is required to build on iOS (with the Xcode 4.6 toolchain) in
C++11 mode, to avoid the error: "invalid suffix on literal; C++11
requires a space between literal and identifier"

BUG=226494


Review URL: https://chromiumcodereview.appspot.com/13721002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193361 0039d316-1c4b-4281-b951-d872f2087c98

Breaks webrtc_call.WebrtcCallTest.testLocalPreview.

> Use NTP time for video frame timestamp.
> Add tracing for capture timestamps.
> 
> BUG=225209
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/13554003

TBR=justinlin@chromium.org
Review URL: https://codereview.chromium.org/13882004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193358 0039d316-1c4b-4281-b951-d872f2087c98

BUG=229708


Review URL: https://chromiumcodereview.appspot.com/13981002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193357 0039d316-1c4b-4281-b951-d872f2087c98

Added new DriveNotificationObserver interface which all observers of Google Drive invalidations should implement.

BUG=173339


Review URL: https://chromiumcodereview.appspot.com/13940004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193356 0039d316-1c4b-4281-b951-d872f2087c98

Use the given Profile instead of the default one when possible.
Fallback to file URL when something is wrong with .gdoc file.

BUG=None
TEST=Open a .gdoc (Google Docs) file in both Google Drive and Downloads from Files.app.


Review URL: https://chromiumcodereview.appspot.com/14012003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193355 0039d316-1c4b-4281-b951-d872f2087c98

FileSystemMountPointProvider::CreateFileStream{Reader,Writer} should return scoped_ptr instead of raw pointer so that the caller can make sure it obtains the ownership of the returned Reader/Writer.


BUG=175934
TEST=should pass all existing tests

Review URL: https://chromiumcodereview.appspot.com/13811013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193354 0039d316-1c4b-4281-b951-d872f2087c98

The argument of SetSurroundingText is relative position from passing surrounding
text. Here selection_range or text_range is absolute position from document
root, thus we need conversion.

BUG=222392
TEST=type "a" 140 times with Thai input and made sure not crashing.


Review URL: https://chromiumcodereview.appspot.com/13812013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193353 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193351 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds new methods into DriveScheduler, which will replace
GetResourceList.

BUG=160932
TEST=Ran unit_tests --gtest_filter=DriveScheduler*


Review URL: https://chromiumcodereview.appspot.com/13450006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193349 0039d316-1c4b-4281-b951-d872f2087c98