- 29 Jan, 2016 15 commits
-
-
hyunjune.kim authored
artOffset`. Just only recognize with `percentage` when return value on `startOffset` that is normalize value between 0 and 1. Because occur to the problem on `SVGTextLayoutEngine::begin- TextPathLayout`. So check whether percentage or not, If no percentage, don't recognize to normalize value. BUG=576702 Review URL: https://codereview.chromium.org/1580293008 Cr-Commit-Position: refs/heads/master@{#372225}
-
samli authored
BUG=266276 Review URL: https://codereview.chromium.org/1577723002 Cr-Commit-Position: refs/heads/master@{#372224}
-
jialiul authored
--site-per-process flag. Also resolved the flakiness as a side product. BUG=373155,568710 Review URL: https://codereview.chromium.org/1585003002 Cr-Commit-Position: refs/heads/master@{#372223}
-
khmel authored
This supports communication via Google api to get an auth code for GMS Core client and pass it to ARC instance. There are two types of getting the auth code. Firstly, we try to get it silently and secondary, in case when an additional input is required from the user WebView dialog is shown. Changed logic of starting ARC instance. Now its start is controlled by ArcAuthService after communication with Google auth servers. BUG=571146 TEST=Provide additional unit_tests. TEST=logcat shows that auth code is passed to ARC instance. Both modes are tested: silent and WebView based (can be forced by re-imaging) Review URL: https://codereview.chromium.org/1618193003 Cr-Commit-Position: refs/heads/master@{#372222}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be0306ff..0e000221 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1641133006 Cr-Commit-Position: refs/heads/master@{#372221}
-
wkorman authored
Selection gaps have been disabled in M47 stable for some time now. BUG=471908 Review URL: https://codereview.chromium.org/1642223002 Cr-Commit-Position: refs/heads/master@{#372220}
-
brucedawson authored
If (due to an unexpected failure) one of the find() calls in audio_video_metadata_extractor_unittest.cc fails (returns end()) then dereferencing it triggers undefined behavior. This makes the results of the test undefined. In most cases the test failure will still be caught but there are no guarantees. This change adds a helper function to simplify using find() in a way that is safe even in the face of unexpected failures. This was discovered while investigating crbug.com/581768. R=dalecurtis@chromium.org Review URL: https://codereview.chromium.org/1643633005 Cr-Commit-Position: refs/heads/master@{#372219}
-
creis authored
This test started failing on the Site Isolation FYI bots after https://codereview.chromium.org/1645923002/. This CL disables it there until we can fix it. The test is a no-op on other bots without the --site-per-process flag. BUG=582251 TEST=Site Isolation FYI bots go green. Review URL: https://codereview.chromium.org/1646083002 Cr-Commit-Position: refs/heads/master@{#372218}
-
mcgrathr authored
The nacl64.exe build within the Windows 32-bit x86 Chrome build is not compatible with component-style builds. Build nacl64.exe in a special variant of the x64 toolchain, wherein is_component_build is always false. BUG=512869 R=bradnelson@chromium.org, dpranke@chromium.org Review URL: https://codereview.chromium.org/1580723006 Cr-Commit-Position: refs/heads/master@{#372217}
-
skym authored
BUG=582257 Review URL: https://codereview.chromium.org/1648813002 Cr-Commit-Position: refs/heads/master@{#372216}
-
amp authored
BUG=582130 Review URL: https://codereview.chromium.org/1646893002 Cr-Commit-Position: refs/heads/master@{#372215}
-
charliea authored
BUG=571458 Review URL: https://codereview.chromium.org/1645103002 Cr-Commit-Position: refs/heads/master@{#372214}
-
charliea authored
I thought this was happening before, but upon further inspection, it looks like whatever I did wasn't working. This way of building the battor_agent seems to be. Given that the battor_agent will be used by Telemetry, it makes sense to build this on the waterfall. BUG=571458 Review URL: https://codereview.chromium.org/1640883003 Cr-Commit-Position: refs/heads/master@{#372213}
-
huangs authored
Previously naked pointers AssemblyProgram and EncodedProgram are used over the place, and are deallocated using Delete{AssemblyProgram, EncodedProgram}(). In this CL we use scoped_ptr to manage the life cycles of these objects. - Removed DeleteAssemblyProgram() and DeleteEncodedProgram() and replaced calls with e.g., program.reset(nullptr); if the manual deallocation is a peak memory optimization. - Moved Encode() and ReadEncodedProgram() to the .h files matching the .cc files. - Extracted DetectExecutableType() and ParseDetectedExecutable() from disassembly.* to new files program_detector*c, since Disassembly is really an implementation that caller's don't care about. Review URL: https://codereview.chromium.org/1629703002 Cr-Commit-Position: refs/heads/master@{#372212}
-
kenrb authored
Crash reports associated with the --isolate-extensions trial show that a RenderWidgetHostViewChildFrame can receive mouse events even after Destroy has been called on it, resulting in a null pointer dereference since the RenderWidgetHost pointer has been cleared. This CL checks the pointer for null and discards the event if the RWHVCF is currently awaiting deletion. BUG=571092 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review URL: https://codereview.chromium.org/1641553007 Cr-Commit-Position: refs/heads/master@{#372211}
-
- 28 Jan, 2016 25 commits
-
-
brettw authored
font_warmup_win.cc depends on Blink code but is linked into content/common. This file is not needed outside of child processes, so it can go in content/child and avoid the blink-in-browser usage. Removes the linux conditional on libjingle_webrtc and make it apply whenever webrtc is being used. This code is called by socket_host.cc whenever webrtc is enabled. This is necessary for a future patch that removes Blink's linking into content/browser. Blink is currently bringing in webrtc which is why the code links today. BUG=582206 Review URL: https://codereview.chromium.org/1642213002 Cr-Commit-Position: refs/heads/master@{#372210}
-
davidben authored
https://boringssl.googlesource.com/boringssl/+log/6c22f542f42eccb0de7f43edf27aa1255c7be7e2..2cdf398773edb5e6fa6ccb4088553c245f048062 BUG=none Review URL: https://codereview.chromium.org/1647953004 Cr-Commit-Position: refs/heads/master@{#372209}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/317a45e87988..817c72ad40bf $ git log 317a45e87..817c72ad4 --date=short --no-merges --format='%ad %ae %s' 2016-01-28 djsollen Fix broken Android framework builds GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1641173003 2016-01-28 fmalita SaveFlags begone! 2016-01-28 benjaminwagner Fix typo on trooper page. 2016-01-28 benjaminwagner Work around exasperating Google3 Android build error. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=msarett@google.com Review URL: https://codereview.chromium.org/1642243002 Cr-Commit-Position: refs/heads/master@{#372208}
-
kojii authored
This is a re-land of https://codereview.chromium.org/1541393003/ This patch is another effort to make Character::isCJKIdeographOrSymbol faster. The previous CL[1] made it faster by ~90% for codepoints below U+2020, but codepoints abvoe U+2020 were not as fast. This CL makes all codepoints faster, as fast as ICU functions. Before After Improve ICU All 2569 => 292 88% 298 ASCII 68 => 68 0% 160 Han 2958 => 263 91% 344 Hira 258 => 11 95% 14 Arabic 37 => 32 13% 44 * # of code points and iterations vary by rows. The previous CL[1] clarified that binary search is not as fast as ICU functions such as uscript_getScript(). This patch changes to use UTrie2, which is the data structure ICU property functions use. In addition in this patch: * U+2763 and U+2764 are added as requested by drott@. * Character::isUprightInMixedVertical() was switched to UTrie2 too. * Character::isCJKIdeograph() was removed because it is no longer used. [1] https://codereview.chromium.org/1545073002 BUG=571943 Review URL: https://codereview.chromium.org/1645893002 Cr-Commit-Position: refs/heads/master@{#372207}
-
kbr authored
This is in preparation for switching these bots to the Chromium recipe. The only thing of note is that the angle_deqp_gles3_tests will not be run on the Linux Release dEQP (NVIDIA) bot yet, to match their current configuration. BUG=542370 TBR=dpranke@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/1642293002 Cr-Commit-Position: refs/heads/master@{#372206}
-
dtseng authored
In ChromeVox Next, Search+Shift+Esc activates pass through mode. The subsequent key will be passed through directly to the system. In particular, the key needs to be a ChromeVox command. For example, Search+Shift+Esc followed by any number of key (e.g. Ctrl+L), then ended by Search+L would result in the screen locking since the passed through key is the last ChromeVox command. This cl also makes all key events involving Search captured. TEST=hit Search+L. Verify the key gets eaten (no screen lock) and ChromeVox tries to move to the next link. Press Search+Shift+Esc; then Search+L. Verify screen locks. Do the same with sticky mode on. Double tap Search. Press Shift+Esc. Verify pass through activates. Press Search+L and see that screen locks. Review URL: https://codereview.chromium.org/1636243002 Cr-Commit-Position: refs/heads/master@{#372205}
-
sergeyu authored
Now ChromotingClient creates WebrtcConnectionToHost or IceConnectionToHost depending on protocol_config. BUG=547158 Review URL: https://codereview.chromium.org/1649513002 Cr-Commit-Position: refs/heads/master@{#372204}
-
dcheng authored
Since the tool wasn't using the "spelling" location, replacements would be emitted using source locations into an unnamed input buffer. As a result, the emitted replacements would never apply since the file name would never match. However, it ends up still being included in the symbol dump for the rebase tool. Since these identifiers aren't being renamed, just skip processing anything inside a macro. BUG=581902 Review URL: https://codereview.chromium.org/1641703003 Cr-Commit-Position: refs/heads/master@{#372203}
-
yoav authored
This CL removes support for the "subresource" rel of HTMLLinkElement, as it is not useful, proprietary, and buggy. I2DnR: https://groups.google.com/a/chromium.org/d/msg/blink-dev/Y_2eFRh9BOs/gULYapoRBwAJ BUG=581840 Review URL: https://codereview.chromium.org/1647813003 Cr-Commit-Position: refs/heads/master@{#372202}
-
wkorman authored
Resubmit of http://crrev.com/1518223002 now that we have a fix in for http://crbug.com/569643. Work still pending per http://crbug.com/569211 to use correct rects for certain items. BUG=529938 TBR=christr Review URL: https://codereview.chromium.org/1648023002 Cr-Commit-Position: refs/heads/master@{#372201}
-
dgozman authored
During reattach, InspectorEmulationAgent tries to access mainFrameImpl() too early, which happens to break during remote -> local main frame transition. Similar thing happens when we cleanup during local -> remote transition. Somehow, we also enable emulation for remote frames sometimes (or just not disbale it, so it keeps going). Added null-check for now and TODO. BUG=579065,579474,578968,543896 Review URL: https://codereview.chromium.org/1622633003 Cr-Commit-Position: refs/heads/master@{#372200}
-
marcinjb authored
This puts an stunnel proxy in the engine's Docker container. The client will connect on the same port, stunnel will intercept and forward the underlying traffic to the engine which is now listening on another port. BUG=575421 Review URL: https://codereview.chromium.org/1638153002 Cr-Commit-Position: refs/heads/master@{#372199}
-
nharper authored
BUG=467312 Review URL: https://codereview.chromium.org/1636453004 Cr-Commit-Position: refs/heads/master@{#372198}
-
scottmg authored
Use BrowserList directly instead. R=sky@chromium.org BUG=558054 Review URL: https://codereview.chromium.org/1644773003 Cr-Commit-Position: refs/heads/master@{#372197}
-
jun_fang authored
Font information (like size) is needed to perform layout in the process of loading XFA documents. It was too late to set g_last_instance_id so that XFA didn't get a font by calling FontMap(). BUG=pdfium:349 Review URL: https://codereview.chromium.org/1615723003 Cr-Commit-Position: refs/heads/master@{#372196}
-
xhwang authored
BUG=582194 TEST=Tested with local test and makes sure the certificate is passed from JS to MediaDrm. Review URL: https://codereview.chromium.org/1648073002 Cr-Commit-Position: refs/heads/master@{#372195}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ad0dc0dc..be0306ff Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org Review URL: https://codereview.chromium.org/1646053002 Cr-Commit-Position: refs/heads/master@{#372194}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/30fc26015d6c..7d3030eb345a $ git log 30fc26015..7d3030eb3 --date=short --no-merges --format='%ad %ae %s' CQ_INCLUDE_TRYBOTS= TBR=catapult-sheriff@chromium.org Review URL: https://codereview.chromium.org/1642203002 Cr-Commit-Position: refs/heads/master@{#372193}
-
Bacek authored
When URLRequestHttpJob processing cached response with GetDictionary header we already have seen the header in SdchOwner. So just ignore it. R=rdsmith@chromium.org Review URL: https://codereview.chromium.org/1563163002 Cr-Commit-Position: refs/heads/master@{#372192}
-
lpromero authored
This reverts commit 1602a2c9. This breaks VoiceOver as described in http://crbug.com/581813 BUG=581813 R=rohitrao@chromium.org,pkl@chromium.org Review URL: https://codereview.chromium.org/1640273003 Cr-Commit-Position: refs/heads/master@{#372191}
-
senorblanco authored
Unify it with the GPU version of this test (effect-reference-hidpi-hw.html), which has no filter region set. TBR=fmalita@chromium.org BUG=240845 Review URL: https://codereview.chromium.org/1643013002 Cr-Commit-Position: refs/heads/master@{#372190}
-
alancutter authored
This change ensures that we force an animation update when an @keyframe rule's keyframe offset is modified via script. BUG=581966 Review URL: https://codereview.chromium.org/1649663002 Cr-Commit-Position: refs/heads/master@{#372189}
-
tedchoc authored
BUG=581949 Review URL: https://codereview.chromium.org/1648783003 Cr-Commit-Position: refs/heads/master@{#372188}
-
bajones authored
BUG=563613 Committed: https://crrev.com/838ca1836eae1357a3b9135e808266d7d28bd3fa Cr-Commit-Position: refs/heads/master@{#371062} Review URL: https://codereview.chromium.org/1505343003 Cr-Commit-Position: refs/heads/master@{#372187}
-
yolandyan authored
BUG= Review URL: https://codereview.chromium.org/1643003002 Cr-Commit-Position: refs/heads/master@{#372186}
-