GitLab

This patch extends the Crostini App Registry to record:
- Localized names
- Localized comments
- Mime types
- VM/Container name

The launcher items are updated to use localized names, and the concierge
call now passes the actual VM and container names. We also change the
"app_id" we use for Crostini apps to also include these names, which
should allow us to have multiple icons for an app installed in multiple
containers.

Bug: 821662
Change-Id: I47e4da783c987a026b09decc6a67612fff3f55de
Reviewed-on: https://chromium-review.googlesource.com/995115
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548346}

These add coverage and replace some of the existing layout tests with
a more efficient method of testing.

Tidy a comment in HTTPParsers.h while we're at it.

Change-Id: Idae90404bbd43de2e15a0442c16801079f38c4cc
Reviewed-on: https://chromium-review.googlesource.com/982750
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548345}

https://pdfium.googlesource.com/pdfium.git/+/75f84a56 changed the PDFium
rendering APIs to let callers better control how forms are drawn. The
path for low quality printing / print as image never got updated.

BUG=825985,pdfium:594

Change-Id: I36658f651da3911034648651c6118acbd4050712
Reviewed-on: https://chromium-review.googlesource.com/985133Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548344}

BUG=824598
TBR=sky@chromium.org

Change-Id: I09ac08a2042efffb8562b6a0d9764fdaa6231ff1
Reviewed-on: https://chromium-review.googlesource.com/991619
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548343}

TBR=oshima@chromium.org

Bug: 827435
Change-Id: I7d2fbf3869dbf8f3c14f386436a57f17def3bbf0
Reviewed-on: https://chromium-review.googlesource.com/997176Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548342}

This change removes some a duplicate function to enable Picture in
Picture for LayoutTests. It also consolidates TestExpectations and
moves the existing tests to the same directory.

BUG: 726619
Change-Id: I5f46bb6886ac9b88bb2bd23a2c38fe77ead00ace
Reviewed-on: https://chromium-review.googlesource.com/994256
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548341}

- Add event dispatching code to blink::FormSubmission
 -- Add isConnected() check after FormSubmission creation
- Add event dispatching code to blink::FormData constructor
- Add onformdata IDL attribute
- Add onformdata content attribute

The next CL will add tests.

Bug: 825684
Change-Id: I43a03284a0206a71828dc420119562cdd177c0c2
Reviewed-on: https://chromium-review.googlesource.com/997032Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548340}

Narrow down the set of watched files a bit.

BUG=None

Change-Id: I5f90948260fa1d588c3ba78fbc984a786fff72a4
Reviewed-on: https://chromium-review.googlesource.com/994435Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548339}

It is sometimes necessary to distinguish among the three states of the selected attribute:
- true: a node is selected (e.g. an option)
- false: a node is unselected
- undefined: the node is not meant to be selected

The |selectable| state is implied by the first two values for selected.

With this change, a client can trust that a control is *not* selected rather than not supporting selection. On the author side, (e.g. a views author), one does not need to remember to set selectable state along with the actual selected state.

In ChromeVox, we sometimes want to speak the items which are selected (in the case of cells, for Sheets).
However, in the common case, which is when selection follows focus, it is extremely verbose to speak selected. Instead, only speak items which are unselected.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iaf76784664a72ff7c99fff4ebf35f9b798b34cec
Reviewed-on: https://chromium-review.googlesource.com/985473
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548338}

Change-Id: Ifb231fe7f7b686c417cecc3cad6534239bec5066
Reviewed-on: https://chromium-review.googlesource.com/996315Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548337}

This converts storage::FileSystemOperationRunner::operations_ from
base::IDMap to std::map.

All other users of base::IDMap don't store null value to base::IDMap,
and the null value makes the interface of base::IDMap complex.
So, this removes base::IDMap from FSOR as a preparation to refactor
IDMap.

Change-Id: I65b81ead88133b9ac5ea724af53df67b812e0fde
Reviewed-on: https://chromium-review.googlesource.com/995652Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548336}

TBR=asanka@chromium.org

Bug: 828954
Change-Id: Ifb43987ec0e7e892e6655d4f1469b57daae50be6
Reviewed-on: https://chromium-review.googlesource.com/997055Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548335}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/447b127a..77df816c

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ic046c842c51db3736311c6d2d96c2db8ea797561
Reviewed-on: https://chromium-review.googlesource.com/996992Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548334}

https://pdfium.googlesource.com/pdfium.git/+log/dc566b0a76f9..32942201a456

$ git log dc566b0a7..32942201a --date=short --no-merges --format='%ad %ae %s'
2018-04-04 hnakashima Caret blinks with lower frequency in XFA text field.
2018-04-04 fdegans Prepare for |is_posix| switch in the Fuchsia build
2018-04-04 rharrison Expand ~ when present in directory path

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:812974


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I3d406862bf3646ba6b53d031eb7b5172c169fbda
Reviewed-on: https://chromium-review.googlesource.com/996307Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548333}

This is a precusor cleanup extracted from
https://chromium-review.googlesource.com/c/chromium/src/+/957760/7
in the broader effort to restrict usage of MessageLoop::current().

This CL was uploaded by git cl split.

R=dpapad@chromium.org

Bug: 825327
Change-Id: Ibbd7b8f1c59f8e1022b9d77dfcc4cf6e8490a24e
Reviewed-on: https://chromium-review.googlesource.com/986747
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548332}

BUG=787020
TBR=eae

Change-Id: I9931e0f0c73a6a0bb7dbade9c8c189acec1cb9d2
Reviewed-on: https://chromium-review.googlesource.com/997174Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548331}

Since InlineBoxPosition holds |const InlineBox*| member,
this patch changes its constructor to take const InlineBox
parameter for better code health.

Bug: 766448
Change-Id: Id7f188c5f5c626dc72e4d2e1ec799d14383230ad
Reviewed-on: https://chromium-review.googlesource.com/997111
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548330}

- Removes the largeIconUrl field from ProvidersModel which did not map
accurately to the Provider definition in file_manager_private.idl.

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation

Test: tested manually w/ new clojure compiler provided by scottchen@
Change-Id: I4cea3c7633027cf1e3808aa2f895190630d2adf2
Reviewed-on: https://chromium-review.googlesource.com/994291
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548329}

Using the EmbeddedTestServer will make the same test pass before/after
the underlying code is switched to use the network service. The new
test is also more integrationy, using real network requests, which
seems particularly useful here, as this is the only code that sends
chunked uploads in Chrome. The one downside is that it requires a
test-only method to set the server URL.

Bug: 810555
Change-Id: I46b9321f83027cbc1c3a002ce1b35b693a6560aa
Reviewed-on: https://chromium-review.googlesource.com/987526
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548328}

SQLitePersistentChannelIdStore: same.

(e.g. when the Commit method exits before the loop that goes through the
 individual ops).

Bug: 809199
Change-Id: Ice3d648366e234abc6705f9c998f53d01e201143
Reviewed-on: https://chromium-review.googlesource.com/995637Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548327}

Bug: 820883
Change-Id: Ic696e1cb77106dbb7df5ccb4a9aa276eb8e5a1d7
Reviewed-on: https://chromium-review.googlesource.com/982774
Commit-Queue: Paul Dyson <pdyson@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548326}

Bug: 756447, 829125, 829141
Change-Id: I854594ed35fc5a99df1b68534db42bcb65b81a0f
Reviewed-on: https://chromium-review.googlesource.com/996582
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548325}

https://chromium.googlesource.com/angle/angle.git/+log/59c5b897ec70..00af463e03ef

$ git log 59c5b897e..00af463e0 --date=short --no-merges --format='%ad %ae %s'
2018-04-02 lfy GLES1: Add MatrixType packed enum to entry points
2018-03-30 courtneygo Fix Tokenizer issue
2018-04-04 oetuaho Disallow case statements nested in blocks
2018-03-29 lfy GLES1: glMultiTexCoord4(f|x)
2018-03-31 jmadill Vulkan: Move image layout into helper.
2018-04-04 lucferron Vulkan: Follow up change to optimize number of condition checks
2018-03-29 lucferron Vulkan: Implement stencil test support
2018-03-29 lucferron Vulkan: Depth/stencil scissored clears
2018-03-31 jmadill Vulkan: Use DrawCallParams in draw methods.
2018-04-04 jmadill Move Buffer Subject/Observer to front end.

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: Ic802b0a7271300e23c6e9585a34204177a3f6e17
Reviewed-on: https://chromium-review.googlesource.com/997097
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548324}

Exercises and applies the new dependency download mechanism
from crrev.com/c/819771
Note: The CL enables the android_deps repo, but that can be
reverted by settings the gn variable enable_android_deps_repository
to false, the former binaries and targets are still all valid.

TBR=klobag@chromium.org

Bug: 794210
Change-Id: Ia29ee554a9bbb3c38bd8f88d16af484da2ee439b
Reviewed-on: https://chromium-review.googlesource.com/837189
Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548323}

https://crrev.com/0832751d354f1ed576ee729d9a2a133c1f047dbf missed a bit.

Bug: 816677

Change-Id: I61216e400e1e5973ab9d8683c662269b84b9928f
Reviewed-on: https://chromium-review.googlesource.com/996386Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548322}

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8567c425305735c385ac573f73efa2431aca75fd
Reviewed-on: https://chromium-review.googlesource.com/996575
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548321}

Bug: 756447, 788681
Change-Id: I6cd4d87384bd55f7168a6c8889c631f2f7d9c015
Reviewed-on: https://chromium-review.googlesource.com/996461Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548320}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a1df57cdc657..2a5f70cc060a

$ git log a1df57cdc..2a5f70cc0 --date=short --no-merges --format='%ad %ae %s'
2018-04-04 vadimsh Kick the recipe roller to pick up the revert.
2018-04-04 bcwhite Convert CygWin paths to Windows native for CIPD.

Created with:
  roll-dep src/third_party/depot_tools
BUG=chromium:828981


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I1a08df8f756f915856265d328a28cba90b28cc76
Reviewed-on: https://chromium-review.googlesource.com/996672Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548319}

This adds two new preferences for controlling Certificate Transparency
configuration, intended for use within an Enterprise. In a follow-up,
these will be wired up to Enterprise Policies for enterprise-wide
configuration.

- certificate_transparency.excluded_spkis

  For organizations that are issuing organizationally-bound certificates
  (either OV or EV), they can disable Certificate Transparency for their
  organization by specifying SPKI hashes. Certificate Transparency will be
  disabled if the validated certificate chain contains one of these SPKI
  hashes, and the certificate associated with the SPKI hash meets one of the
  following conditions:

  1) The hash matches the leaf cert's SPKI
  2) The hash matches a CA certificate that has a nameConstraints extension
     with a permittedSubtrees tree, which contains one or more directoryName
     nameConstraints, and there is a directoryName nameConstraint that
     restricts the O field and the leaf cert also has one or more O fields
     in the Subject.
  3) The hash matches a CA certificate, and the CA certificate has one or
     more O fields in the Subject, and these are equal to the Leaf cert in
     ordering, value, and number of values.

- certificate_transparency.excluded_legacy_spkis

  For organizations which are relying on trust anchors that have been removed
  by default by newer versions of the trust store, but were present in older
  versions (and thus subjected to CT requirements), they can disable
  Certificate Transparency for certificates under these CAs by specifying the
  SPKI hash. The SPKI hash must be one which appears in
  //net/data/ssl/root_stores and must not be presently trusted on Android or
  Chrom[e/ium]OS.

Bug: 824184
Change-Id: I0098bf7c28ac5201f9ba0f171f55a43a7fe3e073
Reviewed-on: https://chromium-review.googlesource.com/987513
Commit-Queue: Doug Turner <dougt@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548318}

Instead of passing an ExtensionPrefValueMap to
ExtensionPrefs::InitExtensionControlledPrefs(), just use the member
variable directly.

Similarly, instead of passing `this` and the value map to the
anonymous free function LoadExtensionControlledPrefs(), just
make LoadExtensionControlledPrefs() a member function and use
the ExtensionPrefs members directly.

Bug: None

Change-Id: Ifd036983e83a4ecc9b95144cb87c986b68c2fa12
Reviewed-on: https://chromium-review.googlesource.com/996499
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548317}

The PORTALLOCATOR_DISABLE_COSTLY_NETWORKS flag isn't reliable on mobile
network and may remove networks that shouldn't be removed. Given that we
never had this flag set on the old app and we hadn't got any complain so
far, we may just disable this flag for now.

Bug: 829117
Change-Id: Ic33cc19998ce259c60227e020e1ca1264e4c7fab
Reviewed-on: https://chromium-review.googlesource.com/996613
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548316}

The code to log the collected data using ukm.

Bug: 820883
Change-Id: I5359427153fdb3f9b7f56a26e7238d9d45260f89
Reviewed-on: https://chromium-review.googlesource.com/967909
Commit-Queue: Paul Dyson <pdyson@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548315}

We can ask RenderWidgetHostViewMac for its FrameSinkId/SurfaceId when
the BrowserCompositorMac is already gone there; early out in those
cases and return invalid FrameSinkId/SurfaceId. When GetCurrentSurfaceId
returns invalid SurfaceId, we are going to send the event to the parent
root_view of the now-invalid view [1].

[1] https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_input_event_router.cc?type=cs&l=330

Bug: 828304
Change-Id: I009e51e9c1cfd31dad8efd4a7b504ba63dd49b18
Reviewed-on: https://chromium-review.googlesource.com/996304Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Ria Jiang <riajiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548314}

Consistently failing on WebKit Linux Trusty (dbg).

TBR=mstensho@chromium.org

No-Try: true
No-Presubmit: true
No-Tree-Checks: true

Bug: 829181
Change-Id: If082269d6d58848efa3d7c7c756c774e050cdd79
Reviewed-on: https://chromium-review.googlesource.com/996773
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548313}

FrameSinkVideoCapturer returns a full-resolution snapshot of the page,
but DevToolsEyeDropper expects the snapshot to be scaled to the page's
dip size. This is problematic for the current configuration of
FrameSinkVideoCapturer if device scale factor is anything other than 1.
Make sure FrameSinkVideoCaptuerer also scales the snapshot to the
expected size.

TBR=caseq@chromium.org

Bug: 813929
Change-Id: I324c6dccfd7db69e07d2283f826a613946c0bf07
Reviewed-on: https://chromium-review.googlesource.com/986291
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548312}

Bug: 824774
Change-Id: Ib6be40e0b6b7b215e64035f5ff4ae65531ce7198
Reviewed-on: https://chromium-review.googlesource.com/996433Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548311}

Bug: none
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2a125825faf342373faa4b957788c6e90692a71b
Reviewed-on: https://chromium-review.googlesource.com/996801Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548310}

BUG=787020
TBR=dpranke

Change-Id: I5d7fbbbee13a356ea7b53c577441fbf1c922ccb8
Reviewed-on: https://chromium-review.googlesource.com/996755Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548309}

Assertion at RenderWidgetHostViewAndroid::StopObservingRootWindow
called via |Destroy| failed, since WebContentsViewAndroid::SetContentViewCore
was passing a valid ViewAndroid instead of nullptr when cvc is destroyed.
This kept RWHVA observing root window, while the view tree was already
torn down by WCVA dtor, leaving RWHVA in inconsistent state where it
couldn't get WindowAndroid any more. This CL fixes the bug. Previously
WCVA passed null CVC to RWHVA before https://crrev.com/c/958646, so
this fix is the correct behavior.

Bug: 828211
Change-Id: I79463cd0dce94c5f8d81417208cd313871c4f5d7
Reviewed-on: https://chromium-review.googlesource.com/991002Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548308}

https://webrtc.googlesource.com/src.git/+log/448f4d50dc75..76d9bd5b459b

$ git log 448f4d50d..76d9bd5b4 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I3159a9d10ee4a24536429f89a91df9bdde933cbe
Reviewed-on: https://chromium-review.googlesource.com/996306Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#548307}