GitLab

R=dpranke@chromium.org
BUG=628783

Review-Url: https://codereview.chromium.org/2152523002
Cr-Commit-Position: refs/heads/master@{#405905}

Android now supports dynamic pins, but not static pins.

BUG=517311

Review-Url: https://codereview.chromium.org/2151063003
Cr-Commit-Position: refs/heads/master@{#405904}

BUG=None

Review-Url: https://codereview.chromium.org/2153243003
Cr-Commit-Position: refs/heads/master@{#405903}

crbug.com/611310 contains a report of a rendering issue on 10.9. As I
haven't been able to repro locally, I was hoping to get more data on
this issue during beta/canary, but no additional reports have come in.
In order to allow us to launch to stable with lower risk, this CL
disables GPU raster on 10.9, which only accounts for ~7% of mac users.

We may re-enable this for M53 Beta M54 Canary in order to track down the
issue in question, and hopefully launch to 10.9 in M53.

BUG=611310
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2151393002
Cr-Commit-Position: refs/heads/master@{#405902}

When the TTS UX is showing and the user activates a context menu,
the selection controller gets an event sequence that's confusing,
causing a tap-selection to show the selection handles.

This change hides the Contextual Search UX, and adds a state where
the selection controller knows to ignore the next event that would
show the selection handles, when a context menu has just been shown.

This change cleans up a sequence implicated in a crash, so that
won't be reproducible through triggering the Context Menu anymore.
(Issue 562353)

BUG=628436,562353

Review-Url: https://codereview.chromium.org/2150213002
Cr-Commit-Position: refs/heads/master@{#405901}

* Add the ability to bold parts of a label.

* Add the ability to show a tertiary label in the PaymentOption, which
  will later be used for phone number display.

* The phone number is passed in to the PaymentOption using the new constructor
  via the AutofillAddress class.

See crbug.com/626833 for screenshots.

BUG=603635,626833

Review-Url: https://codereview.chromium.org/2135573004
Cr-Commit-Position: refs/heads/master@{#405900}

Currently most of the chrome UI code access NavigationController through
WebContents. However for Blimp mode there is no WebContents and hence
needs a different way to access NavigationController. In this CL, a
NavigationHandler interface was written that can be directly
accessed from tab. This would be used throughout clank UI. Chrome and
blimp versions would implement this interface.
BUG=612080

Review-Url: https://codereview.chromium.org/2087543002
Cr-Commit-Position: refs/heads/master@{#405899}

BUG=591496
R=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2146333003
Cr-Commit-Position: refs/heads/master@{#405898}

BUG=624722
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2111643005
Cr-Commit-Position: refs/heads/master@{#405897}

The target just needs to be bound as an FBO color attachment, so we
don't even have to deal with coordinate conversion math.

BUG=626861

Review-Url: https://codereview.chromium.org/2144423003
Cr-Commit-Position: refs/heads/master@{#405896}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/de0a832e..1d801c6f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2150223003
Cr-Commit-Position: refs/heads/master@{#405895}

This is the second incremental step towards the full CFI launch.
In the first step, we enabled LinkTimeOptimization (LTO) for the
official Chrome builds. In this step we add Control Flow Integrity
checks for all virtual calls.

The remaining part is to add bad-cast checks to ensure the forward-edge
Control Flow Integrity works as planned. That remaining part will
require more work on reducing the overhead for size and speed by these
CFI checks, so we don't enable them right away.

The expected Perf impact by this CL:

- Chrome binary size is increased by 5%,
- Some of the benchmarks are slowed down by up to 3.5%.

Note that before making it slower, we made it faster by implementing
virtual const propagation and a number of heuristics for automatic
devirtualization in LLVM which sped up some layout benchmarks by up to 7%
(see https://crbug.com/580389 and https://crbug.com/617283)

If there's a higher (negative) impact, we'll be willing to roll this
feature back, but please allow the Perf bots to work for a day or two
to collect more detailed statistics on the regressions, as it will help
us to identify ways to speed it up (most likely, by inventing new ways
for automatic devirtualization).

BUG=464797

Review-Url: https://codereview.chromium.org/2140373002
Cr-Commit-Position: refs/heads/master@{#405894}

Update the ALSA backend so that the calculated rendering delay is either
accurate, or kNoTimestamp. We no longer try to guess the correct delay
timestamp. Note that this requires callers of GetRenderingDelay() to
correctly handle the kNoTimestamp case.

BUG= internal b/30034408

Review-Url: https://codereview.chromium.org/2133293003
Cr-Commit-Position: refs/heads/master@{#405893}

BUG=628086
TEST=See bug, check that logo has reappeared.  Alternately, run in debug
mode and observe that program doesn't crash at startup.

Review-Url: https://codereview.chromium.org/2149233005
Cr-Commit-Position: refs/heads/master@{#405892}

BUG=529938

Review-Url: https://codereview.chromium.org/2144413002
Cr-Commit-Position: refs/heads/master@{#405891}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7d75341f1514..84bd4e0eb215

$ git log 7d75341f1..84bd4e0eb --date=short --no-merges --format='%ad %ae %s'

BUG=472699

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2158603002
Cr-Commit-Position: refs/heads/master@{#405890}

The original patch and the previous relands broke
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in the WebRtc Mac-tester bots, which run using a Logitech C920.

The root cause was that for resolutions >= 1280x720p, the code
configures the use of MJPEG encoding, and that seems to produce
partially invalid JPEG markers, e.g.
(Corrupt JPEG data: 10 extraneous bytes before marker 0xd4)
that throw the AVCaptureStillImageOutput off.

This CL disconnects |stillImageOutput_| in this case.

Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.

Review-Url: https://codereview.chromium.org/2155723002
Cr-Commit-Position: refs/heads/master@{#405889}

This allows us to automatically include the file when we use gn
desc runtime_deps to isolate a test group and its runtime
dependencies.

BUG=internal b/30140639
TEST=Run gn desc out/release chromecast:cast_test_lists, verify
     contains out/release/tests/run_test_list.txt

Review-Url: https://codereview.chromium.org/2150373002
Cr-Commit-Position: refs/heads/master@{#405888}

This patch makes it possible to view and revoke permission to access a
USB device by going to an origin's "site settings" page.

BUG=430999,601627

Review-Url: https://codereview.chromium.org/2134463002
Cr-Commit-Position: refs/heads/master@{#405887}

https://chromium.googlesource.com/skia.git/+log/04d62182fe66..f0c30f55665e

$ git log 04d62182f..f0c30f556 --date=short --no-merges --format='%ad %ae %s'
2016-07-15 halcanary SkPDF: Join Positioned Text
2016-07-15 halcanary SkPDF: Always give a default advance for glyphs.
2016-07-15 djsollen Fix broken Android framework build. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2153953002

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2159473004
Cr-Commit-Position: refs/heads/master@{#405886}

Moves all service manager connections in the content layer
(connections owned by instances of MojoShellConnection and
MojoChildConnection) to the IO thread in all process types.
Note that instances of MojoShellConnection and
MojoChildConnection may still be created and used on
any thread.

Additionally exposes a way for InterfaceRegistry and
InterfaceProvider to forward to/from other instances
so we can still have a corresponding instance of each
on whatever thread owns the Mojo[Shell/Child]Connection
object.

This simplifies interface registration and acquisition
on process hosts and ChildThreadImpls, and makes it possible
for a future CL to introduce IO-thread service registration
to avoid thread hops when binding incoming interface requests.

BUG=623398,612500,619202

Committed: https://crrev.com/439768f0aaaea83ffb7ce6c3ba4438804582c383
Committed: https://crrev.com/0771b1d71a3295691f9ffaefdf50652bd58e01c4
Review-Url: https://codereview.chromium.org/2111353002
Cr-Original-Original-Commit-Position: refs/heads/master@{#404228}
Cr-Original-Commit-Position: refs/heads/master@{#404556}
Cr-Commit-Position: refs/heads/master@{#405885}

R=thestig@chromium.org
BUG=627474

Review-Url: https://codereview.chromium.org/2153703002
Cr-Commit-Position: refs/heads/master@{#405884}

BUG=chromium:627873
TEST=build successfully

Review-Url: https://codereview.chromium.org/2158583002
Cr-Commit-Position: refs/heads/master@{#405883}

Note that the newly added repo is not compiled yet.

BUG=611171

Review-Url: https://codereview.chromium.org/2153923002
Cr-Commit-Position: refs/heads/master@{#405882}

R=rsesek@chromium.org
BUG=628167

Review-Url: https://codereview.chromium.org/2152243003
Cr-Commit-Position: refs/heads/master@{#405881}

Align Chrome's processing of IDB open() and deleteDatabase() requests
with other browsers: such requests should be processed in FIFO order.
Previously, Chrome let delete requests jump ahead of blocked opens, as
hinted at in the spec but not supported by other browsers.

R=cmumford@chromium.org
BUG=479388

Review-Url: https://codereview.chromium.org/2148253003
Cr-Commit-Position: refs/heads/master@{#405880}

BUG=626456

Review-Url: https://codereview.chromium.org/2149493007
Cr-Commit-Position: refs/heads/master@{#405879}

BUG=606596, 621847

Review-Url: https://codereview.chromium.org/2156673002
Cr-Commit-Position: refs/heads/master@{#405878}

BUG=622509

Review-Url: https://codereview.chromium.org/2152353002
Cr-Commit-Position: refs/heads/master@{#405877}

When user taps on an incomplete autofill credit card or [+ ADD CARD]
button, the card editor launches.

For server cards, the editor shows uneditable card information and lets
the user set the billing address.

For local cards, the editor shows the following fields.

1) A list of icons for supported card types.

2) The card number input with Luhn validation and formatting. Required
   field.

3) The name on card input. Required field.

4) The month and year dropdowns. January of this year by default for new
   cards.

5) The billing address dropdown with only complete addresses on disk and
   an option to add a new address. Required field.

6) A checkbox for saving the new card on disk. Checked by default,
   so it behaves similar to autofill settings.

BUG=624924

Review-Url: https://codereview.chromium.org/2116583002
Cr-Commit-Position: refs/heads/master@{#405876}

There are different ways we compare the UrlInfo class.  There is no
reason for it to be comparable instead of just using a custom
Comparator each time as needed (as we already do).

BUG=628711

Review-Url: https://codereview.chromium.org/2152323002
Cr-Commit-Position: refs/heads/master@{#405875}

Also change notification bg from 0xFEFEFE to 0xFFFFFF

BUG=624968
TBR=rdsmith@chromium.org

Review-Url: https://codereview.chromium.org/2143653007
Cr-Commit-Position: refs/heads/master@{#405874}

Even though Chrome now supports foreach on NodeList (which is now iterable), we should do this because:
- Dartium is behind
- some users don't upgrade Chrome regularly
- failing here causes total silence while within web content

Originally introduced by
crrev.com/2074513002/

BUG=626325

TBR=dmazzoni@chromium.org

Review-Url: https://codereview.chromium.org/2127063003
Cr-Commit-Position: refs/heads/master@{#405873}

BUG=628395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=zmo@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2154003002
Cr-Commit-Position: refs/heads/master@{#405872}

The server-update capability was never used in practice. The existence
poses a potential risk of google3 misconfiguration causing all instances
of Chrome iOS to crash on start up.

https://chromereviews.googleplex.com/466337014/ depends on this CL.

BUG=484694

Review-Url: https://codereview.chromium.org/2146323003
Cr-Commit-Position: refs/heads/master@{#405871}

This method is only used by a test (WebViewInteractiveTest.TextSelection) and
may eventually be removed. In the meantime, comply with the content API
guidelines by removing const from the public interface. This is also useful for
a followup CL (https://codereview.chromium.org/2130133004).

BUG=578168

Review-Url: https://codereview.chromium.org/2152073002
Cr-Commit-Position: refs/heads/master@{#405870}

BUG=626989
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2151383002
Cr-Commit-Position: refs/heads/master@{#405869}

BUG=none

Review-Url: https://codereview.chromium.org/2144753002
Cr-Commit-Position: refs/heads/master@{#405868}

Certain accelerated video decoders (in Android and CrOs, see bug)
produce ARGB VideoFrames that are backed by textures, which are
not supported on ToT by VideoTrackRecorder, so nothing gets encoded.

This CL adds code that borrows from webmediaplayer_ms_compositor.cc's
CopyFrame() [1] to try and retrieve the data from the said incoming
VideoFrame, by passing the this to the new method
VideoTrackRecorder::Encoder::RetrieveFrameOnMainThread()

Thanks to this, content_browsertest's MediaRecorderPeerConnection
can be enabled.

[1] https://cs.chromium.org/chromium/src/content/renderer/media/webmediaplayer_ms_compositor.cc?dr=C&q=webmediaplayer_ms_compositor&sq=package:chromium&l=35

BUG=585242

TEST=the newly enabled content_browsertests and
manual testing on N6, see bug for details.

Review-Url: https://codereview.chromium.org/2147753002
Cr-Commit-Position: refs/heads/master@{#405867}

Extends the devtools Page domain with commands to generate and
manage Navigation Throttles.  This functionality will be useful
for WebDriver style test frameworks and is needed for Headless
Chrome.

If enabled by Page.setControlNavigations a Page.navigationRequested
event will be fired if the main frame or a child frame attempts to
navigate, or it receives a server side redirect.  The navigation will
be deferred until a corresponding Page.processNavigation command is sent
in response.

BUG=546953
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2132673002
Cr-Commit-Position: refs/heads/master@{#405866}