- 08 May, 2019 40 commits
-
-
edchin authored
Previously, the grey page placeholder image attempted to use the webProxyView's contentInset property to properly position the placeholder. This used frame setting. The preferred way to position content in the BVC is to use the ContentArea NamedGuide with autolayout contraints. Using the preferred autolayout + NamedGuide approach also fixes a placeholder malpositioning bug related to fullscreen experiments. Bug: 956077 Change-Id: Ia3d115ae203bacb59d41cdb3c377a4a75c00dc95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593921 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#657797}
-
Brian Sheedy authored
Adds libc++.so to the list of data that's required for Android app bundles. This is because bundles currently require aapt2, which in turn requires libc++.so. Bug: 950727 Change-Id: I4a198ae884e7a5ed8b1572dadf669018aecfdc04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600545 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#657796}
-
dpapad authored
After r655514, UseGzip() is a no-op and can be removed. WebUI data sources don't need to do anything special anymore to differentiate between compressed and non-compressed files, since this is handled at a lower layer already. Bug: 738243 Change-Id: Icfdccb611cee010a0c9091b276ee8d5796f9ddcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1563032 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#657795}
-
Mitsuru Oshima (slow - gardening) authored
This reverts commit 6ba4e737. Reason for revert: crbug.com/960914 Original change's description: > Reland "Move CrOS JEA/MJDA to components/chromeos_camera" > > This is a reland of f28fecb3 > > Original change's description: > > Move CrOS JEA/MJDA to components/chromeos_camera > > > > This CL moves CrOS specific JEA/MJDA to components/chromeos_camera. > > > > Bug: 946366 > > Test: Manually > > Change-Id: I666f658955892bc750fdce0626f4979597462c5a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1587678 > > Commit-Queue: Wei Lee <wtlee@chromium.org> > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > > Reviewed-by: Antoine Labour <piman@chromium.org> > > Reviewed-by: Miguel Casas <mcasas@chromium.org> > > Reviewed-by: Michael Wasserman <msw@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#657110} > > Bug: 946366 > Change-Id: I76ed93d18073fef048a68e2b08332122590139af > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597514 > Commit-Queue: Wei Lee <wtlee@chromium.org> > Reviewed-by: Chrome Cunningham <chcunningham@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#657655} TBR=msw@chromium.org,mcasas@chromium.org,chcunningham@chromium.org,rsesek@chromium.org,piman@chromium.org,thomasanderson@chromium.org,wtlee@chromium.org Change-Id: I0af0e4effeee37a8460d871bb2e60ca9a6611bb9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 946366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600359Reviewed-by:
Mitsuru Oshima (slow - gardening) <oshima@chromium.org> Commit-Queue: Mitsuru Oshima (slow - gardening) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#657794}
-
Mike Wittman authored
Updates the stack copying to ensure the copy has the same alignment as the original stack. This fixes a bug where the copying would attempt to read past the end of the stack on unaligned frame pointers. It is also required to ensure the values operated on by the in-stack pointer rewriting match the alignment of the actual pointer values in the stack. And it avoids unaligned reads and writes, which will be required for use with arm. Bug: 956626, 882450 Change-Id: Ie694704813d523d7db9ecb45eb54c3775d86cbe1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592698 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#657793}
-
Koji Ishii authored
This patch fixes to mark lines dirty when floats or OOF that appear in the line needs layout. Before r656770, this issue occurs only when |PrepareLayout()| runs before the layout (e.g., |ComputeMinMax()|). r656770 made this bug to appear more often, by changing to use |PrepareLayout()| to mark when |NeedsCollectInlines()| is set. Change-Id: I0267b87aa83e6058262a9c04aaf159f72030a0b7 Bug: 949222, 959521 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601014Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#657792}
-
Michael Spang authored
This fixes a regression where settings can't be opened on Estelle. Bug: b/132257001 Test: open settings on estelle Change-Id: I4699de0b07b20e52632fcc72f564cd0e0638de66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600327 Auto-Submit: Michael Spang <spang@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#657791}
-
Esmael El-Moslimany authored
Bug: 949479 Change-Id: Icace96388ff832fadbf69918c1aa804b07bfc2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1596623 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#657790}
-
Nicolas Ouellet-Payeur authored
This reverts commit 9d58d481. Reason for revert: crbug.com/960710 Original change's description: > [Headless] Split browser/renderer process dependencies > > This CL splits //headless:headless into 2 components: > - :headless_renderer > - :headless_non_renderer > > :headless_renderer is intended for child processes, and has a smaller > footprint than :headless_non_renderer. > > For release builds, this reduces the size of chrome_child.dll by about > 9.7MB. > > Bug: 929408 > Change-Id: I514a1bb5604f8ab8d6c6031970b5c7a965a8393d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1570654 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> > Cr-Commit-Position: refs/heads/master@{#656433} TBR=caseq@chromium.org,jbudorick@chromium.org,nicolaso@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 929408 Change-Id: If51e35a56b3d14c9723a50a9fe3669601c9e149f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600259 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#657789}
-
Matt Menke authored
It was using UnescapeURLComponent(), which doesn't unescape all characters. Most consumers of it are either buggy (because they don't expect all of UnescapeURLComponent() logic around what it leaves escaped) or don't care about the extra logic. This case is one of the latter. This is part of an effort to reduce use of UnescapeURLComponent() so that we can make it unescape fewer weird cases, primarily to improve security of the omnibox. Bug: 849998 Change-Id: Ieabe95d766d67656db651e03742cba223a622c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600540Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#657788}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6fb8bc0e..9e3a6042 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I84fb577a88acb4412dd79c1f27ded70a0a08138d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601297Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657787}
-
rajendrant authored
For chrome which doesn't have the change to record the histograms correctly, testCheckPageWithQuicProxyTransaction should be skipped. Change-Id: I09e31acde881631859221a824fe858bb9c8b4d8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601342Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#657786}
-
Roman Kuksin authored
Prior to this patch, any requests on MediaStreamManager that had not been explicitly removed with DeleteRequest() are leaked on shutdown. This issue is particularly visible in tests. Bug: 946885 Change-Id: Ic328f5c9c6797dc44add8f8e9c761372d64c7480 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541093 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#657785}
-
Mike West authored
This patch measures the length of `referer` header values in the status quo, and introduces a flag which will strip the header down to its origin if a configurable limit is exceeded. We'll run some experiments once we're gathering data to determine what a reasonable limit might look like. Bug: 959757 Change-Id: I56e10af369399e19dfc92e0245f896804b696210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595872Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#657784}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/011744e6dd2b..4ac42dbf5180 git log 011744e6dd2b..4ac42dbf5180 --date=short --no-merges --format='%ad %ae %s' 2019-05-08 chrisforbes@google.com Punt image->image copies requiring quadlayout awareness to blitter Created with: gclient setdep -r src/third_party/swiftshader@4ac42dbf5180 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/132156862 TBR=swiftshader-team+autoroll@chromium.org Change-Id: I791504c5258e3a52ed433b7d91770701ae4458cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601186Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657783}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/55b9f5ddd2f6..3ac606a7738e git log 55b9f5ddd2f6..3ac606a7738e --date=short --no-merges --format='%ad %ae %s' 2019-05-08 dneto@google.com Update CHANGES, switch to 2019.0-dev (#613) Created with: gclient setdep -r src/third_party/shaderc/src@3ac606a7738e The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@chromium.org Change-Id: I8e1dc970a794fbc5918ae15eca9e0c9c154ed4da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600488Reviewed-by:
-
Sadrul Habib Chowdhury authored
This trace-event will be processed in telemetry for updated metrics (see details in bug and in http://crrev.com/c/1601122) TBR=ericrk@ for trivial change. BUG=960824 Change-Id: Ia44316efbcd168ae61353f868f54ac6d938a1d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601324Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#657781}
-
Nick Harper authored
Change-Id: Ic745c4a3136f8d0783e169fccfb53cf4d0c412e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600642Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#657780}
-
Daniel McArdle authored
This reverts commit ec2ce628. Reason for revert: Pursuing alternate strategy of preserving base::MD5 interface, but replacing its implementation with boringssl. Original change's description: > Replace base::MD5Context with boringssl in //media > > Testing with media_unittests > > Bug: 755368 > Change-Id: I9b45735a5d3054207d3bc340bce45fb25014a447 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1568847 > Auto-Submit: Daniel McArdle <dmcardle@chromium.org> > Commit-Queue: Daniel McArdle <dmcardle@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Reviewed-by: David Benjamin <davidben@chromium.org> > Cr-Commit-Position: refs/heads/master@{#653350} TBR=davidben@chromium.org,sandersd@chromium.org,dmcardle@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 755368 Change-Id: I79c40ea2ee09637b78abc7ad50b049980c934e0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600777Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Daniel McArdle <dmcardle@chromium.org> Cr-Commit-Position: refs/heads/master@{#657779}
-
Antonio Gomes authored
These were caught by presubmit hook, so this CL prepares for it in advance, so the main diff looks easier to review. In summary, - base::Closure -> base::RepeatingClosure. - base::Bind -> base::BindRepeating. - remove ununsed header inclusions (eg base/threading/thread_task_runner_handle.h). - stop null-checking by comparing against nullptr. - base::ThreadChecker -> THREAD_CHECKER. - removed unused content/ includes. BUG=787261 Change-Id: I15d7d7e9d9a31bfbf2683c70f955033d2b11f228 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600518 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Jonathan Metzman authored
Bug: 950091 Change-Id: Ia71b231c84e65ed223a125054993992917227e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600397 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Auto-Submit: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#657777}
-
Danan S authored
Bug: 937995 Change-Id: I64f090e6096200cf404d2f2e4c33ce813ff90eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594178Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Danan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#657776}
-
Xiyuan Xia authored
Migrate the following from mojom::SessionController: - SetSessionInfo - UpdateUserSession - SetUserSessionOrder Bug: 958214 Change-Id: I33d0210753e61801ac16d16f08360e0121d0f160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600432Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#657775}
-
Evan Stade authored
1. Prevent Chrome reaching directly into ash::AcceleratorController by creating a pure virtual interface. The implementation is renamed AcceleratorControllerImpl. 2. Move volume accelerator handling to ash. Convert VolumeController interface into a single callback that Chrome provides. This callback is run whenever the volume is changed via the keyboard. Bug: 958225, 958131 Change-Id: Icc59608ad092eb9f53cda0637d0585ffdfa7f925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595507 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Eric Roman authored
Bug: 959929 Change-Id: I5f0784568f0d6147fc32de5c54b1f8799f472ef9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600636Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#657773}
-
Caleb Rouleau authored
Change-Id: Ie05c8115b56eb54b3c520618a97b0db9243c6df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600633 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#657772}
-
James Cook authored
UI surfaces like the settings window or file manager are "native OS UI" and should not follow the browser's font size setting. The implementation is based on checking URLs because the Webkit prefs must be configured early in WebContents initializion, before the Browser initialization is complete (and hence registered with things like SettingsWindowManager). Bug: 955071 Test: added to browser_tests and unit_tests Change-Id: I982b778498945e159d4a33c39f5e84ac6bc45f41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594085Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#657771}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d2baff227833..3cd2c388997d git log d2baff227833..3cd2c388997d --date=short --no-merges --format='%ad %ae %s' 2019-05-08 lalitm@google.com Merge "trace_processor: fix gcc compile" 2019-05-08 rsavitski@google.com cpp_headers_from_protos: hardcode relative path to buildtools clang-format Created with: gclient setdep -r src/third_party/perfetto@3cd2c388997d The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id35068c8c4858fc84bd5f028b618dd8ab0b7d51c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601356Reviewed-by:
-
Rayan Kanso authored
*messages.* file names are generally reserved for IPC logic, and a presumbit error is triggered if there isn't an OWNERS file with security reviewers. TBR=antrim@chromium.org Change-Id: I5172a35cb2166d37aa6c994b1ad2083f8af1532b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601258 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
-
Ryan Hansberry authored
Though the user-facing control for this pref was removed, because the pref had been synced, its value persisted, potentially locking users into a less-than-ideal RSSI threshold. This change rips all of this unused logic out, so that all users use the same preferred threshold. Bug: 943875 Change-Id: Id2bd9adc3090f835816fa638685d6ca3fedea01f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592863Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#657768}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1ddf2968fb2a..b6e71184c68c Created with: gclient setdep -r src-internal@b6e71184c68c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=dvadym@chromium.org,noel@chromium.org,jbroman@chromium.org,xialinyan@chromium.org Change-Id: I9df91624bc94c2899c9c9251d2fb144337e3aa35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601056Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#657767}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/de991d4fe26a..f5115ed4b0f6 git log de991d4fe26a..f5115ed4b0f6 --date=short --no-merges --format='%ad %ae %s' 2019-05-08 timvp@google.com Vulkan: Enable standard derivatives extension 2019-05-08 staphany@chromium.org Roll ./third_party/googletest/src/ 9997a830e..3f5b5b8f8 (3 commits) Created with: gclient setdep -r src/third_party/angle@f5115ed4b0f6 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@chromium.org Change-Id: I09dfc6b4cb2ca8469376890da5b2a64d97eb7e5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601187Reviewed-by:
-
Maksym Onufriienko authored
chromium.fyi/ios12-beta-simulator has incorrect destination `iPad Pro` https://ci.chromium.org/p/chromium/builders/ci/ios12-beta-simulator Need to update destination to one of valid iPad Pro (9.7-inch) iPad Pro (12.9-inch) iPad Pro (12.9-inch) (2nd generation) iPad Pro (10.5-inch) Bug: 960431 Change-Id: Iff977a2f1d7b6ae5940f2f177552b1ad1b0562fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599629 Auto-Submit: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#657765}
-
Brian Sheedy authored
Further decreases the rate at which clicks are sent to content nodes during instrumentation tests for the VR browser to ensure that all clicks are reliably picked up. Bug: 953990 Change-Id: I6f903f14f2a6bb02fef7e7a76629fa5e038e2e55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601414 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#657764}
-
Kyle Milka authored
When Google is the DSP we now use the local NTP built into Chrome instead of the remote NTP specified in prepopulated_engines.json. Remove the entry, as the loading of the local NTP is handled by logic in chrome/browser/search/search.cc. Bug: 583289 Change-Id: Id28db805bc53eebab6d492be666f909e0ff0b800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591796Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#657763}
-
Bill Orr authored
XRView's were reused instead of creating new ones. Some of the exposed data was arrays that can be detached, which could lead to crashes. Even after fixing it so we don't use the detached arrays, there was the potential for debug tools to try to read them, so we now return null. Bug: 957521, 958014 Change-Id: Id777f598abad39d9cbbbdec539f85d7915eca880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600482Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#657762}
-
Suman Kancherla authored
Refactored existing NavigatorVR class into two. The new NavigatorXR implements just the XR attribute leaving just getVRDisplays() to be implemented in the former class. Test: Passes the following Web Tests: - xr/navigator_xr_blocks_getVRDisplays.html - xr/navigator_xr_blocked_by_getVRDisplays.html Bug: 948360 Change-Id: I24d593cd6bab5fc732af287e8b0b102a684c43be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597531 Commit-Queue: Suman Kancherla <sumankancherla@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#657761}
-
Aran Gilman authored
Android appears to use a different color encoding scheme than the other platforms (ABGR vs ARGB). Retrieving the colors via *getAddr32() returns the "raw" color with the platform-specific encoding. getColor() reorders the bytes to be in ARGB no matter what platform it's on. I also used existing named constants for the colors to make the tests a bit easier to read. Bug: 850782 Change-Id: Ic756fee15fa685cafecfc21f57b2565bf8df08a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594824 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#657760}
-
Becca Hughes authored
If we are playing a local file then we see the "file:///" scheme as the source. We should replace it with placeholder text. BUG=960500 Change-Id: Ie3680ddb6927ec65c4e8d823d1016a8be9f8ee0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600496Reviewed-by:
-
Paul Meyer authored
Bug: 936104 Change-Id: I07733cb7197ef5992d418a38d967544a7ee2b9d2 Tbr: avi@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1491796 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#657758}
-
