GitLab

Move all the butter bar code to a separate class. Fix some style, method & variable names and simplify code.

BUG=134601
TEST=Progress is shown while copying files. Error messages in butter bar are shown and hidden appropriately.


Review URL: https://chromiumcodereview.appspot.com/10824145

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149634 0039d316-1c4b-4281-b951-d872f2087c98

Removes the gfx_unittests target from various .gyp files in favor of
ui_unittests.  This can be landed once the master builders are restarted with
the change: https://chromiumcodereview.appspot.com/10778013

TEST=None
BUG=133864
R=tony@chromium.org, hbono@chromium.org, petermayo@chromium.org
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10778019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149633 0039d316-1c4b-4281-b951-d872f2087c98

Also, when sending error events for a frame, mark them as failed, so we don't touch them again in the future

BUG=139117
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10834125

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149632 0039d316-1c4b-4281-b951-d872f2087c98

that tab; only respected for tabs.executeScript and tabs.insertCSS.

This involved converting tabs.executeScript/insertCSS to use JSON
schema compiler.


BUG=137643
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10815028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149631 0039d316-1c4b-4281-b951-d872f2087c98

apps docs.

TBR=cduvall@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10823144

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149630 0039d316-1c4b-4281-b951-d872f2087c98

Previusly File Manager could insert just created folder in current dir event if it acually created in another. The same thing with renaming and deleting (but that ops are harder to reproduce).

BUG=138429
TEST=Create 2 identical folders on GDrive and downloads (it's important that other to swtich to contains files with the same names). Create new folder, rename a file, delete a bunch of files on GDrive and switch to Downloads.


Review URL: https://chromiumcodereview.appspot.com/10831127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149628 0039d316-1c4b-4281-b951-d872f2087c98

The Content Security Policy specification[1] notes that "Enforcing a CSP
policy should not interfere with the operation of user-supplied scripts
such as third-party user-agent add-ons and JavaScript bookmarklets."
To that end, this CL allows `chrome-extension` resources to bypass
their containing document's policy, meaning that (for example)
`chrome-extension://[ID]/image.png` can be injected into a page, even
if that page has an `img-src 'none';` CSP directive.

[1]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#processing-model

BUG=133223
TBR=thakis@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10792008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149627 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149626 0039d316-1c4b-4281-b951-d872f2087c98

control: http://codereview.chromium.org/10825153/
Review URL: https://chromiumcodereview.appspot.com/10843051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149625 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133088
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10834107

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149624 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cduvall@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10837073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149623 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements CookieMonster::MutableParsedCookie which is derived from CookieMonster::ParsedCookie. This allows parsing a cookie and modifying it afterwards.

BUG=112155
TEST=no


Review URL: https://chromiumcodereview.appspot.com/10697035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149622 0039d316-1c4b-4281-b951-d872f2087c98

TBR=cduvall@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10827138

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149621 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149620 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

BUG=


Review URL: https://chromiumcodereview.appspot.com/10830137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149619 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133866

Review URL: https://chromiumcodereview.appspot.com/10830121

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149618 0039d316-1c4b-4281-b951-d872f2087c98

BUG=133866
TEST=Manual test.


Review URL: https://chromiumcodereview.appspot.com/10837069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149617 0039d316-1c4b-4281-b951-d872f2087c98

Add linux_chromeos and linux_chromeos_clang as preferred try bots whenever chromeos files are modified.

TBR=maruel@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10827137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149616 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137994


Review URL: https://chromiumcodereview.appspot.com/10827115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149615 0039d316-1c4b-4281-b951-d872f2087c98

vector of DataFetcherFactories

In the current implementation, any OS can only use at most one DataFetcher, so
there will always be 0 or 1 DataFetcherFactories in the vector. Therefore it
is simpler to use a single DataFetcherFactory instead of an array. Since DataFetcherFactory is a pointer itself, it can be NULL when there are no available DataFetchers.

BUG=none


Review URL: https://chromiumcodereview.appspot.com/10837055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149614 0039d316-1c4b-4281-b951-d872f2087c98

extensions by removing them when extensions are uninstalled. Tweak several
defensive guards against this to be CHECKs.


BUG=139869


Review URL: https://chromiumcodereview.appspot.com/10851002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149613 0039d316-1c4b-4281-b951-d872f2087c98

Also remove stale comment from speech_recognition_error.h.

BUG=116954


Review URL: https://chromiumcodereview.appspot.com/10831110

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149612 0039d316-1c4b-4281-b951-d872f2087c98

All are stylistic changes reordering targets for better maintainability. 

BUG=None


Review URL: https://chromiumcodereview.appspot.com/10832082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149611 0039d316-1c4b-4281-b951-d872f2087c98

See http://codereview.chromium.org/10792008/ for background.

BUG=139592

Review URL: https://chromiumcodereview.appspot.com/10828067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149610 0039d316-1c4b-4281-b951-d872f2087c98

These gyp defines are set unconditionally in envsetup, which means they
are not in fact part of the "environment" but just the defaults for the
Android build. Move them into common.gypi instead to make this clear.
Several of them were already the correct setting and can simply be
removed.

The makefiles generated by gyp are identical before and after this
change.


Review URL: https://chromiumcodereview.appspot.com/10825131

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149609 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131177, 132773
TEST=manual, units

Review URL: https://chromiumcodereview.appspot.com/10835041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149608 0039d316-1c4b-4281-b951-d872f2087c98

Revert 149604 - Support calling GrabWindowSnapshot when no BrowserProcess instance is avaliable (eg. tests)


BUG=139694


Review URL: https://chromiumcodereview.appspot.com/10821104

TBR=qfel@google.com
Review URL: https://chromiumcodereview.appspot.com/10830135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149606 0039d316-1c4b-4281-b951-d872f2087c98

Originally landed in http://codereview.chromium.org/10808052/


Review URL: https://chromiumcodereview.appspot.com/10823035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149605 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139694


Review URL: https://chromiumcodereview.appspot.com/10821104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149604 0039d316-1c4b-4281-b951-d872f2087c98

With some comment fixes for style nits.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10827135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149603 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=140060


Review URL: https://chromiumcodereview.appspot.com/10836070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149602 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149601 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=apavlov
Review URL: https://chromiumcodereview.appspot.com/10829140

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149600 0039d316-1c4b-4281-b951-d872f2087c98

Also, slightly widen one recently added suppression
BUG=140196
TBR=oshima
Review URL: https://chromiumcodereview.appspot.com/10836071

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149597 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149596 0039d316-1c4b-4281-b951-d872f2087c98

TBR=oshima
BUG=131354,79322
Review URL: https://chromiumcodereview.appspot.com/10837068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149594 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yangguo@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10824126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149593 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10825132

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149592 0039d316-1c4b-4281-b951-d872f2087c98

This class is introduced to separate code related to WAPI
(codename of Documents List API) feed loading.

To minimize diffs, the the class is defined in gdata_file_system.cc
The code will be moved to a set of new files in a separate patch.

BUG=130669
TEST=out/Release/unit_tests --gtest_filter=GData* && out/Release/browser_tests --gtest_filter=GData*

Review URL: https://chromiumcodereview.appspot.com/10828126

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149591 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140041
TBR=oshima
Review URL: https://chromiumcodereview.appspot.com/10828128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149590 0039d316-1c4b-4281-b951-d872f2087c98