Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 11 Jun, 2018 12 commits
    • Chris Harrelson's avatar
      [PE] Rationalize compositing triggers. · 38825770
      Chris Harrelson authored 
      * Compute all triggers except kComboSquashableReasons, kComboCompositedDescendants
and kComboAllCompositedScrollingDeterminedReasons in either style update or
CompositingInputsUpdater.
* Determine composited scrolling (but not the compositing trigger bit) in CompositingInputsUpdater.
* Cache these results on PaintLayer.

This achieves the following goals:
- Separates composited scrolling and awkward LCD text decisions from
the CompositingRequirementsUpdater step.
- Caches more triggers, leading to faster compositing updates in some cases
- Unblocks CL 1072155

Summary of implementation approach:

1. Dirty compositing inputs for all triggers computed there.
2. Compute, and cache on PaintLayer, kComboAllDirectNonStyleDeterminedReasons during
CompositingInputsUpdater.
3. Compute and cache a new DescendantHasDirectCompositingReason dirty bit on PaintLayer.
4. Update composited scrolling in PaintLayerScrollableArea during CompositingInputsUpdater.
This includes the root layer, which uses DescendantHasDirectCompositingReason as one of its
triggers.

Bug:814439,782991

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I21095762cbf806008395c2cf79f4ee038c39cb5f
Reviewed-on: https://chromium-review.googlesource.com/1087791
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: default avatarTien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565925}
      38825770
    • Yoichi Osato's avatar
      [LayoutNG] Rebaseline selection painting expectations around line height · 1b62d187
      Yoichi Osato authored 
      This patch fixes:
fast/text/selection/selection-with-inline-padding.html
paint/invalidation/selection/selection-rl.html

This patch rebases image failures that NG paints 1px taller than old.
This is by-product but got lgtm at the previous patch:
crrev.com/c/1080442 ([LayoutNG] Fill selection paint line gap.)

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Bug: 708452
Change-Id: Iba5a07531f2cabf70707e6a9dfaed51fdc653e53
Reviewed-on: https://chromium-review.googlesource.com/1092567Reviewed-by: default avatarYoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565924}
      1b62d187
    • jchen10's avatar
      Add cmdline options for webgl antialiasing · cfbc812c
      jchen10 authored 
      --webgl-antialiasing-mode is used to specify AA method:
  "none" -- no AA.
  "explicit" -- MSAA with explicit resolve.
  "implicit" -- MSAA with implicit resolve.
  "screenspace" -- screen space AA(CMAA).

--webgl-msaa-sample-count is used to specify the
default sample count if MSAA is currently enabled.

Bug: 849941

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia20ca291c120124f4801b08e01624c6fc28af078
Reviewed-on: https://chromium-review.googlesource.com/1075167
Commit-Queue: Jie A Chen <jie.a.chen@intel.com>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565923}
      cfbc812c
    • Hirokazu Honda's avatar
      Revert "simplify VaapiPictureFactory::Create() method and VaapiPicture members" · b0024ae9
      Hirokazu Honda authored 
      This reverts commit 37a2e00b.

Reason for revert: This CL breaks ARC++ video playback.

Original change's description:
> simplify VaapiPictureFactory::Create() method and VaapiPicture members
>
> This CL moves part of the logic of VaapiPicture creation from VaVDA to
> VaapiPictureFactory, passing the PictureBuffer wholesale since we use
> most of it anyway.  The net result is less lines of code.
>
> VaapiPicture and derived classes hold on to a |texture_id_| and a
> |client_texture_id_|, the latter only used with |bind_image_cb_|:
> - |texture_id_| cannot be zero, either in the tests or in reality, because
>   is a GL texture id; this CL enforces this via a DCHECK() in ctor. That
>   simplifies the body a few methods.
> - |client_texture_id_| can be zero, and is always zero in the v_d_a_unittests,
>   but it doesn't matter because |bind_image_cb_| is dummy for tests ([1]),
>   so there's no point of enforcing it to be non zero.  Moreover, since
>   it's a client-side texture id, it can be any number, so let's skip
>   the confusing checks.
>
> Sprinkled a couple of consts and also, there's no need to do
> !callback.is_null() because CallbackBase provides bool(), so
> s/!callback.is_null()/callback/
>
> [1] https://cs.chromium.org/chromium/src/media/gpu/video_decode_accelerator_unittest.cc?sq=package:chromium&dr&g=0&l=452
>
> Bug: 822346
> Test: compiled+run simplechrome, v_d_a_unittests on eve. media_unittests.
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: I5610ea4abf87df26a85e909aebfbbaa6bb964163
> Reviewed-on: https://chromium-review.googlesource.com/1079834
> Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
> Reviewed-by: Kristian H. Kristensen <hoegsberg@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564178}

TBR=mcasas@chromium.org,dcastagna@chromium.org,hoegsberg@chromium.org,andrescj@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 822346, b:109906289
Change-Id: I58b4968468d99c3f0e4e6b56c1ecd89645550f73
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1094814
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: default avatarPawel Osciak <posciak@chromium.org>
Reviewed-by: default avatarHirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565922}
      b0024ae9
    • Hirokazu Honda's avatar
      Revert "VaapiPicture*: add missing DCHECK()s" · bdbda143
      Hirokazu Honda authored 
      This reverts commit 6873824c.

Reason for revert: crrev.com/c/1079834 breaks ARC++ video playback. This CL has dependency of the CL.

Original change's description:
> VaapiPicture*: add missing DCHECK()s
>
> This CL adds 3 missing DCHECK()s that I forgot after [1]
>
> [1] https://chromium-review.googlesource.com/c/chromium/src/+/1079834/13/media/gpu/vaapi/vaapi_picture_factory.cc#50
>
> TBR=dcastagna@chromium.org
>
> Bug: 717265
> Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
> Change-Id: Ibfc9797bda93dd7660cc64317ab21794dbda6e10
> Reviewed-on: https://chromium-review.googlesource.com/1086131
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564289}

TBR=mcasas@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 717265, b:109906289
Change-Id: Ibc20bee25cdfa127d0b646bc1a03a7e53a6129e4
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1094794
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: default avatarPawel Osciak <posciak@chromium.org>
Reviewed-by: default avatarHirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565921}
      bdbda143
    • Scott Violet's avatar
      chromeos: rename WindowServiceClient* to WindowTree* · 674e5b77
      Scott Violet authored 
      The actual rename.

BUG=none
TEST=none
TBR=jamescook@chromium.org

Change-Id: I66d90858482beb8f7f19aab710d313caaa5cce67
Reviewed-on: https://chromium-review.googlesource.com/1094206Reviewed-by: default avatarScott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565920}
      674e5b77
    • Matt Falkenhagen's avatar
      NetS13nServiceWorker: Disable irrelevant interceptor test. · e5137075
      Matt Falkenhagen authored 
      Skip ServiceWorkerNavigationPreloadTest.CanceledByInterceptor.

This test is about ResourceDispatcherHost interceptors and doesn't apply
to the NetworkService world.

Bug: 715640
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I6a33bff304c2add06a06f80882ba7fe695b946b7
Reviewed-on: https://chromium-review.googlesource.com/1092613Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565919}
      e5137075
    • Hajime Hoshi's avatar
      Add RendererSchedulerTaskType.WorkerThreadTaskQueueCompositor to enum.xml · 453a72a4
      Hajime Hoshi authored 
      Change-Id: I56b5b7fde0ba9ec7a20e5598fce3a040aa713f9b
Reviewed-on: https://chromium-review.googlesource.com/1092556Reviewed-by: default avatarAlexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565918}
      453a72a4
    • Tetsui Ohkubo's avatar
      Unified: Change detailed view header style. · b879459d
      Tetsui Ohkubo authored 
      This CL modifies style of detailed view header by following
UnifiedSystemTray UI spec.

UnifiedSystemTray shares code of detailed view with old SystemTray, so
this CL took the following steps to make the change:
* Move corresponding methods to DetailedViewDelegate
* Move old SystemTray styling code to SystemTrayItemDetailedViewDelegate
* Implement UnifiedSystemTray styling code in
  UnifiedDetailedViewDelegate

Screenshot: http://screen/xT96aUrp5O9

TEST=manual
BUG=850396

Change-Id: I00f8dbccf3dec3ef918d3aa2cd9aacdbb77676bb
Reviewed-on: https://chromium-review.googlesource.com/1092401
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565917}
      b879459d
    • skia-chromium-autoroll's avatar
      Roll src/third_party/skia 7999e0d..92206a4 (1 commits) · 2b8f02ea
      skia-chromium-autoroll authored 
      https://skia.googlesource.com/skia.git/+log/7999e0d..92206a4


git log 7999e0d..92206a4 --date=short --no-merges --format='%ad %ae %s'
2018-06-10 fmalita@chromium.org [skottie] Fix color parsing


Created with:
  gclient setdep -r src/third_party/skia@92206a4

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=csmartdalton@chromium.org

Change-Id: I1c76d5959598e499f71e36096aedc933adacb182
Reviewed-on: https://chromium-review.googlesource.com/1094332Reviewed-by: default avatarskia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565916}
      2b8f02ea
    • David Bokan's avatar
      [BlinkGenPropTree] Stop using PageScaleLayer in cc · 6357cc72
      David Bokan authored 
      This patch prepares CC for turning on blink-generated-property-trees by
removing pinch-zoom/page-scale related uses of the PageScaleLayer. The
only remaining uses are in the cc property tree builder which is only
used when BGPT is disabled. When BGPT is enabled, Blink will create a
page scale transform node rather than a layer. Without BGPT, we find the
appropriate transform node from the PageScaleLayer.

The main change in this CL is making UpdatePageScale work on a property
tree node rather than Layer/LayerImpl. The one complication here is
that there exists a mode for the compositor where the page scale is the
root layer. In this mode, the device scale factor, page scale factor,
and device transform are all applied to the same node. This mode is
used by the UI compositor which isn't yet running BGPT so this use and
building the trees are the only remaining uses of the page scale layer.

This change should have no observable effects.

Bug: 836910
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I87b251e79fb0b89e3cc5f088bebdf862b22c3e6c
Reviewed-on: https://chromium-review.googlesource.com/1079608Reviewed-by: default avatarRobert Flack <flackr@chromium.org>
Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
Reviewed-by: default avatarTien-Ren Chen <trchen@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565915}
      6357cc72
    • fuchsia-sdk-chromium-autoroll's avatar
      Roll Fuchsia SDK from 6953e4c7c3ce to 5d58ae9b2dbf · 8423c9e8
      fuchsia-sdk-chromium-autoroll authored 
      
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I95c6bbd8f9fb890122cdb38ad686aba08cf4eef4
Reviewed-on: https://chromium-review.googlesource.com/1094205
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: default avatarFuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565914}
      8423c9e8
  3. 10 Jun, 2018 18 commits
  5. 09 Jun, 2018 10 commits
    • Andres Calderon Jaramillo's avatar
      Make the JDA unit tests work with odd-sized images. · 65ce78ca
      Andres Calderon Jaramillo authored 
      This CL fixes media/gpu/jpeg_decode_accelerator_unittest.cc so that the
strides and pointers for the VideoFrame that holds the decode result are
computed correctly when the JPEG image has at least one odd dimension.

The strategy is to keep track of a visible size and a coded size for
each image. For odd-sized images, the visible size corresponds to the
original dimensions whereas the coded size corresponds to the odd
dimensions rounded up to the next even number. Thus, the stride
computations will be correct when we call WrapExternalSharedMemory to
build the VideoFrame.

A test case is added for odd-sized images.

To visualize the results, both the software and hardware decode outputs
are saved as PNG when using the --save_to_file flag.

Bug: 849776
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia80c038059949d873b59958afe1fad1533b32226
Reviewed-on: https://chromium-review.googlesource.com/1094037
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: default avatarDaniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565895}
      65ce78ca
    • catapult-chromium-autoroll's avatar
      Roll src/third_party/catapult dc4634d..4bc53b0 (1 commits) · 2388feb4
      catapult-chromium-autoroll authored 
      https://chromium.googlesource.com/catapult.git/+log/dc4634d..4bc53b0


git log dc4634d..4bc53b0 --date=short --no-merges --format='%ad %ae %s'
2018-06-09 benjhayden@chromium.org Replace the 23 Anomaly indexes with 11 joinable indexes.


Created with:
  gclient setdep -r src/third_party/catapult@4bc53b0

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I55dd212cdf2e42dd309db7da3bb80c405adbae13
Reviewed-on: https://chromium-review.googlesource.com/1094494Reviewed-by: default avatarcatapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565894}
      2388feb4
    • Peter Kasting's avatar
      Make all Tab overrides of public methods public. · 33d5f00b
      Peter Kasting authored 
      This also reorders the methods to match the order in the parent classes.

BUG=none
TEST=none
TBR=bsep

Change-Id: I7f4b543a80edf057b67754a324ce6923f8cf06a6
Reviewed-on: https://chromium-review.googlesource.com/1094265
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565893}
      33d5f00b
    • Jeremy Klein's avatar
      Add a feature flag for CrOS Android Messages integration. · 586b4ccc
      Jeremy Klein authored 
      R=khorimoto@chromium.org

Bug: 850823
Change-Id: I7a4b0bbfad4b553929aebd59a508ab11ce208ac1
Reviewed-on: https://chromium-review.googlesource.com/1092192Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Jeremy Klein <jlklein@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565892}
      586b4ccc
    • Chromium WPT Sync's avatar
      Import wpt@418538eb1cce3ecd931285db697736aa2066d05c · dce585da
      Chromium WPT Sync authored 
      Using wpt-import in Chromium 1182c84d.
With Chromium commits locally applied on WPT:
e8832df8 "webrtc wpt: remove test_state_change_event"
fbdd17fb "Improve RTCPeerConnection-setRemoteDescription-tracks.https.html tests."
c220be7c "Fire RTCPeerConnection.onsignalingstatechange in the correct order."
4049f639 "[LayoutNG] Orthogonal flows need available inline size for min/max calculation."
69af6f38 "webrtc wpt: add cleanup to close peerconnections"
03ef65db "Update existing WebUSB WPT to be multi-global"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19247

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=robertma

No-Export: true
Change-Id: I3fa3f0158178897af104b6bdfb4751a46aa8411e
Reviewed-on: https://chromium-review.googlesource.com/1094479
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: default avatarBlink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565891}
      dce585da
    • Sergey Ulanov's avatar
      [Fuchsia] Update fuchsia-sdk:media target · eabc6317
      Sergey Ulanov authored 
      media FIDL library was moved to the fuchsia namespace. Updating BUILD.gn
file accordingly.

Change-Id: I760d8c91f94b5d5a2d0b249d1bdc62f49708063c
Reviewed-on: https://chromium-review.googlesource.com/1094054Reviewed-by: default avatarWez <wez@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565890}
      eabc6317
    • Wez's avatar
      [Fuchsia] Fix FDIO includes in Chromium to match their new location. · 5c3c6f15
      Wez authored 
      - Update #include sites, and the paths in //third_party/fuchsia-sdk's
  build rules.
- Add //third_party/fuchsia-sdk to the set of "gn check" directories.

TBR: thakis, rockot
Bug: 850757
Change-Id: I012d50f405ed93fa49ed4aaa0f25783d1e7e9e4b
Reviewed-on: https://chromium-review.googlesource.com/1094145Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Reviewed-by: default avatarSergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565889}
      5c3c6f15
    • Mathieu Perreault's avatar
      [Views] Change tooltip icon size to 16dp · 1182c84d
      Mathieu Perreault authored 
      It's not recommended to draw outside the canvas factors (here canvas is 32),
and this icon should be 16, as wanted by UX and demonstrated by PNG tooltips
which are 16dp.

Bug: 850571
Test: ./out/Default/browser_tests --gtest_filter=BrowserUiTest.Invoke --ui=CardUnmaskPromptViewBrowserTest.InvokeUi_expired --draw-view-bounds-rects --test-launcher-interactive
Change-Id: I8401c11c60f5926bec81baaf4cb079f93ce87f5c
Reviewed-on: https://chromium-review.googlesource.com/1091130
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
Reviewed-by: default avatarMichael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565888}
      1182c84d
    • skia-chromium-autoroll's avatar
      Roll src/third_party/skia 7a45dd1..5ebb90d (40 commits) · ef8fdfca
      skia-chromium-autoroll authored 
      https://skia.googlesource.com/skia.git/+log/7a45dd1..5ebb90d


git log 7a45dd1..5ebb90d --date=short --no-merges --format='%ad %ae %s'
2018-06-09 senorblanco@chromium.org Revert "remove half float workaround in GrGLGpu::onReadPixels"
2018-06-09 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-08 mtklein@chromium.org remove unused parts of SkTypes.h
2018-06-08 egdaniel@google.com Fall back to bilerp if we are undable to do a copy for mips.
2018-06-08 egdaniel@google.com Reland "Reland "Require mips to be allocated at texture creation time and disable late allocations.""
2018-06-08 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 c3907ef..f15f886 (6 commits)
2018-06-08 bsalomon@google.com Stop passing GrPrimitiveProcessor to GrMesh::sendToGpu.
2018-06-08 herb@google.com Glyph search of desperation
2018-06-08 egdaniel@google.com Revert "Reland "Require mips to be allocated at texture creation time and disable late allocations.""
2018-06-08 borenet@google.com [recipes] Make ct_skps use binaries from a build task
2018-06-08 brianosman@google.com Avoid degenerate matrices (that trigger asserts) in test code
2018-06-08 mtklein@chromium.org see if we can remove this hack
2018-06-08 caryclark@skia.org rebase
2018-06-08 khushalsagar@chromium.org fonts: Perform blob analysis at SkBaseDevice layer instead of canvas.
2018-06-08 mtklein@chromium.org remove unimportant bench
2018-06-08 csmartdalton@google.com Make the SkPathRef GenIDChangeListener ref counted
2018-06-08 bsalomon@google.com Remove include of GrGLProgramBuilder.h from GrGLProgram.h and GrVkPipelineState.h
2018-06-08 csmartdalton@google.com Add a front() accessor to GrAllocator
2018-06-08 herb@google.com New more efficient run builder
2018-06-08 brucewang@google.com Add SkTypeface::makeClone.
2018-06-08 bsalomon@google.com remove half float workaround in GrGLGpu::onReadPixels
2018-06-08 brianosman@google.com Fix A2B JPEG images on GPU backed xform or color-managed canvas
2018-06-08 bungeman@google.com Add text size override to Viewer.
2018-06-08 csmartdalton@google.com Implement Sk2f::floor
2018-06-08 mtklein@chromium.org remove linear blending from SkWebpCodec
2018-06-08 senorblanco@chromium.org GrTessellator: catch missing intersections.
2018-06-08 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-08 fmalita@chromium.org SkJson
2018-06-08 enne@chromium.org Fix SkImageInfo::computeByteSize underflow
2018-06-08 egdaniel@google.com Reland "Require mips to be allocated at texture creation time and disable late allocations."
2018-06-08 bsalomon@google.com Revert "Reland "Workaround constexpr bug in MSVC 2015 in GrTextureOp""
2018-06-08 caryclark@skia.org update SkColor
2018-06-08 caryclark@skia.org fix define comments
2018-06-08 mtklein@chromium.org remove final SkTypes dependencies in SkArenaAlloc
2018-06-08 benjaminwagner@google.com Remove Win2k8 GPU jobs.
2018-06-08 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 81970bc..c3907ef (2 commits)
2018-06-08 timliang@google.com fixed vec3 size differences and mod calculation of skslc msl backend
2018-06-08 brianosman@google.com srgb config is gone. Stop testing it.
2018-06-08 borenet@google.com Update gen_tasks.go to use unforked glog
2018-06-08 robertphillips@google.com Add a factory to any GrOp-derived class that lacked one


Created with:
  gclient setdep -r src/third_party/skia@5ebb90d

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:830651,chromium:829622,chromium:843135,chromium: 819616
TBR=halcanary@chromium.org

Change-Id: If58892b6b6b2061e1b52168911b4fb49a1b990e7
Reviewed-on: https://chromium-review.googlesource.com/1094454Reviewed-by: default avatarskia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565887}
      ef8fdfca
    • Peter Kasting's avatar
      Misc. cleanup while touching tabstrip code: · 05191f36
      Peter Kasting authored 
      * Shorten/simplify
* Move initializers to .h
* Remove dead code
* double -> float
* Better comments/names
* Helper functions
* Use SK_AlphaXXX
* Const correctness
* Don't expose constants unnecessarily
* Use CenterPoint()
* Return by value
* NULL -> nullptr
* Declare variables in narrowest possible scope
* Use static member functions
* SCOPED_TRACE
* Remove using directives
* auto

BUG=none
TEST=none

Change-Id: I80090de4b90c8547f17df93ad2b5b2921bcbbd3f
Reviewed-on: https://chromium-review.googlesource.com/1083781
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: default avatarAllen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565886}
      05191f36