- 23 Aug, 2018 40 commits
-
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ded74c1409ac..5a571a1d27ef git log ded74c1409ac..5a571a1d27ef --date=short --no-merges --format='%ad %ae %s' 2018-08-23 dgarrett@google.com commands: Use cros_mark_as_stable --buildroot. 2018-08-23 dgarrett@google.com request_build: Add "cbb_workspace_branch" support. Created with: gclient setdep -r src/third_party/chromite@5a571a1d27ef The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Idc99788a441c452e79d6aefdb857f948aece7e5a Reviewed-on: https://chromium-review.googlesource.com/1186663Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585543}
-
ziyangch authored
Bug:79208340 Test: locally build and run. Merge-With: eureka-internal/187358 Change-Id: I14cdab64976f27bdaafc473a10c90ad4868b890a Reviewed-on: https://chromium-review.googlesource.com/1148650 Commit-Queue: Stephen Lanham <slan@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585542}
-
Scott Little authored
This reverts commit c40ba7f2. Reason for revert: broke compile, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/7457 Original change's description: > applist: Introduce HomeLauncherGestureHandler. > > Introduce swipe down gesture to homecher. This cl implements the design > at: https://docs.google.com/document/d/1Bt5956kVDcgUz-_BTJc6M1wm5d03onBgJWE3vHQQGl0/edit# > > The design doc states to use a new ScopedClass but after a bit more > thought I think that would be more difficult especially once animations > are added. > > This should be behind a enabled by default flag, but I do not want to > merge too much during code review, so I will add the flag shortly > after this lands. > > Test: added tests > Bug: 872319 > Change-Id: Ibc2dd7344fb3cdb81967b0eefb41d58d377688a3 > Reviewed-on: https://chromium-review.googlesource.com/1184326 > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Reviewed-by: Weidong Guo <weidongg@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585524} TBR=xiyuan@chromium.org,sammiequon@chromium.org,weidongg@chromium.org Change-Id: Ibf5e3a77faec1b2347669c4ae30b47467f3427f7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 872319 Reviewed-on: https://chromium-review.googlesource.com/1187086Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#585541}
-
Weidong Guo authored
Background: When active window exists, toggling overview mode will show a enlarge/shrink animation instead of slide up/down animation. In this case, app list should stay invisible during the animation. Changes: Only run animation when overview mode is using slide animation. Otherwise, set the animation duration to 0 so that app list will immediately disappear when overview mode is on and will immediately show up after overview mode animation when overview mode is off. Bug: 876781 Change-Id: Ifc7af8838beead1dbd1b6d70ee46eec3af19dc19 Reviewed-on: https://chromium-review.googlesource.com/1186036 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#585540}
-
Jacob Dufault authored
- scrollbar fades in and out - scrollbar now only appears when scrolling - scrollbar disappears after a short while if the list was not scrolled Bug: 859228 Change-Id: I5478f387bd733ded02c476d2de05881df6b8d9ea Reviewed-on: https://chromium-review.googlesource.com/1185800Reviewed-by:
-
Randy Rossi authored
This CL removes the platform check for windows/linux/mac when deciding when to announce the startup message. The message should be spoken for all platforms. This script is not executed on Android anymore so there is no longer any reason to prevent the message from being spoken on that platform. For ChromeOS, however, the existing onIntroduceChromeVox listener is used to announce startup. The criteria therefore changed to !isChromeOS. Installed on Chromecast and verified message is spoken to fix the bug. Bug: 875935 Test: Installed on ChromeOS and verified message still spoken Change-Id: I078ee4aaab6ed3cedabcc43edbb6660aa9c7523e Reviewed-on: https://chromium-review.googlesource.com/1181931Reviewed-by:David Tseng <dtseng@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#585538}
-
Weidong Guo authored
Changes: Change from ASCIIToUTF16 to UTF8ToUTF16. Bug: 876953 Change-Id: I6cc3fc093b3ee7dc7d1a94e17c118ad7d0c4a573 Reviewed-on: https://chromium-review.googlesource.com/1186135Reviewed-by:
-
Jan Wilken Doerrie authored
This change adds skeletons of classes required for implementing publishing advertisements for WinRT. Actual functionality will be added in a follow-up CL. Bug: 821766 Change-Id: Ib80e8a53810457765ed5e48550d683e1f595ded8 Reviewed-on: https://chromium-review.googlesource.com/1187144Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#585536}
-
Christian Biesinger authored
Depends on https://chromium-review.googlesource.com/c/chromium/src/+/1185641 Follows the instructions from go/benchmarks-on-fyi-waterfall This benchmark takes about 12 minutes to run based on my experience with Pinpoint. No-Try: True Change-Id: Ie470b7e6404210275d459378174f1d5aeeb2f518 Reviewed-on: https://chromium-review.googlesource.com/1185642 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#585535}
-
Hector Carmona authored
These files were copied from Google Apps NUX and modified slightly. Bug: 832933 Change-Id: I8fd79b2e00d2224e20c6159f478e54defaad0d73 Reviewed-on: https://chromium-review.googlesource.com/1185919Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#585534}
-
James Cook authored
If ChromeVox has ever been turned on during a user session then AutomationManagerAura and AXHostService will be enabled, even if ChromeVox is turned off later. When the shortcut viewer app launches it sees automation is enabled and AXRemoteHost caches the enabled state. When ChromeVox is turned on again AXHostService will generate another OnAutomationEnabled() message to the remote app. Instead of just early-exiting because "automation is already on", re-serialize the app's node tree and send load complete. This is consistent with how AutomationManagerAura behaves today. Bug: 876407 Test: added to views_mus_unittests Change-Id: Ib906da907ca20bbaa3509af72b137462ba006e28 Reviewed-on: https://chromium-review.googlesource.com/1185897Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#585533}
-
Anna Offenwanger authored
Change spelling of XREnviromentIntegrationProvider to XREnvironmentIntegrationProvider. Because apparently it's spelled environ not enviro. Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I001157b168e325aeab03ec9e1bb22532b8c25b45 Reviewed-on: https://chromium-review.googlesource.com/1186963Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#585532}
-
Eric Karl authored
The SurfaceSynchronization feature breaks this test, but after discussion it turns out this test is verifying behavior that is no longer used (or planned to be used in the near future). Disabling the test for now and filing a bug so we can discuss ways to work around this if we want to re-enable in the future. R=twellington@chromium.org Bug: 876943, 871772 Change-Id: I4949b17b20e6376b9b659d9af6cb5d727f348f51 Reviewed-on: https://chromium-review.googlesource.com/1186111 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#585531}
-
Pavel Shmakov authored
Show a dialog with a warning before opening an incognito Custom Tab when incognito tabs are already present. Bug: 871738 Change-Id: I378c34be29d920204fd9c0103547af20b8f33c9d Reviewed-on: https://chromium-review.googlesource.com/1177753 Commit-Queue: Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#585530}
-
Zhongyi Shi authored
No flag update. In QUIC, move TTL logic from QuicServerStream to QuicStream. Not protected. No functional change expected because the TTL interface is not used yet. Merge internal change: 209152580 https://chromium-review.googlesource.com/c/chromium/src/+/1185984 Reduce the size of some quic enum types to 1 byte, and change some int8_t enums to uint8_t. Not protected. Merge internal change: 209149404 https://chromium-review.googlesource.com/c/chromium/src/+/1185983 Store QuicStreamFrame inline within QuicFrame. Not flag protected. (Data structure layout change, hard to protect.) Merge internal change: 209007693 https://chromium-review.googlesource.com/c/chromium/src/+/1185978 Factor out the code for creating KeyExchange objects from QuicCryptoServerConfig::ParseConfigProtobuf into a KeyExchangeSource object which is passed into the QuicCryptoServerConfig's constructor. Merge internal change: 209002409 https://chromium-review.googlesource.com/c/chromium/src/+/1185917 Rollback of internal change 208339929. Merge internal change: 208974769 https://chromium-review.googlesource.com/c/chromium/src/+/1185870 Update stream flow controller on QuicStream::Read(). We are observing that our send window is not getting updated on reads. From the QuicStream::Read() comment and current usage in qbone, it looks like perhaps the Read method should call back to QuicStream::AddBytesConsumed(). Merge internal change: 208892429 https://chromium-review.googlesource.com/c/chromium/src/+/1185867 Enable version 99 testing in QUIC End to End tests Merge internal change: 208877810 https://chromium-review.googlesource.com/c/chromium/src/+/1185864 In QUIC, increase random bytes length to 20 bytes in IETF stateless reset packet. Protected by --quic_more_random_bytes_in_stateless_reset. Merge internal change: 208805996 https://chromium-review.googlesource.com/c/chromium/src/+/1185853 Use the async version of KeyExchange::CalculateSharedKeys in QuicCryptoServerConfig::ProcessClientHelloAfterGetProof(). Protected by --quic_use_async_key_exchange. Merge internal change: 208764362 https://chromium-review.googlesource.com/c/chromium/src/+/1185849 Split QuicCryptoServerConfig::ProcessClientHelloAfterGetProof() into ProcessClientHelloAfterGetProof and ProcessClientHelloAfterCalculateSharedKeys. Follow up CLs will use the async version of CalculateSharedKeys and will pass in ProcessClientHelloAfterCalculateSharedKeys as the callback. Merge internal change: 208762327 https://chromium-review.googlesource.com/c/chromium/src/+/1185846 Add a new async version of KeyExchange::CalculateSharedKey to allow the key exchange operation to be offloaded. Follow up CLs will enable this new codepath in QuicCryptoServerConfig::ProcessClientHelloAfterGetProof(). Merge internal change: 208760423 https://chromium-review.googlesource.com/c/chromium/src/+/1185842 Disable QUIC v35. Protected by --quic_disable_version_35. Merge internal change: 208714937 https://chromium-review.googlesource.com/c/chromium/src/+/1185782 Deprecate --gfe2_reloadable_flag_quic_disable_version_42. Also removes QUIC_VERSION_42 code. Merge internal change: 208698903 https://chromium-review.googlesource.com/c/chromium/src/+/1185739 Deprecate --gfe2_reloadable_flag_quic_disable_version_41_2. Also removes QUIC_VERSION_41 code. Merge internal change: 208668770 https://chromium-review.googlesource.com/c/chromium/src/+/1185528 Remove an unreachable QUIC_BUG_IF in QuicUnackedPacketMap. Not protected. Merge internal change: 208654236 https://chromium-review.googlesource.com/c/chromium/src/+/1185493 Deprecate --quic_use_static_stream_collection_in_write_blocked_list. Merge internal change: 208645294 https://chromium-review.googlesource.com/c/chromium/src/+/1185492 Deprecate --quic_add_to_blocked_list_if_writer_blocked. Merge internal change: 208644812 https://chromium-review.googlesource.com/c/chromium/src/+/1185488 In QuicConnection, notify debug_visitor after a connectivity probing packet is sent. Protected by --quic_notify_debug_visitor_on_connectivity_probing_sent. Merge internal change: 208530778 https://chromium-review.googlesource.com/c/chromium/src/+/1185407 Change-Id: I3bee166d54607a6297cb0c43f079ecdf96f5d0d1 Reviewed-on: https://chromium-review.googlesource.com/1185999 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#585529}
-
Tessa Nijssen authored
The following changes were made: - Store reference to monitor bounds - Rename variable to determine child menu position - Renamed anchor bounds - Renamed menu bounds - Removed Calls to gfx::Rect's origin Store Reference to Monitor Bounds state_.monitor_bounds -> monitor_bounds Renamed Variable to Determine Child Menu Position create_on_the_right -> create_on_right Also cleaned up initialization. Renamed Anchor Bounds owner_bounds -> anchor_bounds The variable is described as being the anchor bounds in a comment above its instantiation. Renamed Menu Bounds pref -> menu_bounds More descriptive name. Removed Calls to gfx::Rect's Origin origin().x() -> x() origin().y() -> y() Calls to x() and y() return the origin's x and y positions. Adding a call to the origin is unnecessary. Change-Id: I29d9b669d567b3d978da721c1b34b9399a1e8178 Reviewed-on: https://chromium-review.googlesource.com/1145544Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#585528}
-
Stephan Herhut authored
There is a mechanism that registers the size of the backing store of a typed array with v8 if such backing store is used by a typed array in a v8 isolate. This is done so that v8 can properly assess the memory pressure of an isolate in the presence of external allocations. With shared array buffers, we can no longer attribute a buffer to a specific isolate, as it might be used by multiple isolates at the same time. The current implementation tries to work around this by only registering with one isolate but ultimately fails at doing so, leading to false data. As a stop-gap fix, this change disables registering of shared buffers completely to at least keep the data consistent while we design a working solution. Change-Id: Ib007cbad6af80e6c82d6ab809bf14ce95c54fc93 Bug: chromium:877055 Reviewed-on: https://chromium-review.googlesource.com/1186461 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#585527}
-
John Abd-El-Malek authored
This way it can be used by tests inside content. Bug: 817187 Change-Id: If1a7c1470b738296f8d121a796f5b5b2492497d6 Reviewed-on: https://chromium-review.googlesource.com/1186028 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Juan Antonio Navarro Perez authored
Add a function to convert the response from a test results request into a data frame for convenient access of the data. Also add corresponding unit tests. Bug: 875251 Change-Id: I396a5c209e37a470ab305edbee82ccc407472766 Reviewed-on: https://chromium-review.googlesource.com/1185184Reviewed-by:
-
Sammie Quon authored
Introduce swipe down gesture to homecher. This cl implements the design at: https://docs.google.com/document/d/1Bt5956kVDcgUz-_BTJc6M1wm5d03onBgJWE3vHQQGl0/edit# The design doc states to use a new ScopedClass but after a bit more thought I think that would be more difficult especially once animations are added. This should be behind a enabled by default flag, but I do not want to merge too much during code review, so I will add the flag shortly after this lands. Test: added tests Bug: 872319 Change-Id: Ibc2dd7344fb3cdb81967b0eefb41d58d377688a3 Reviewed-on: https://chromium-review.googlesource.com/1184326 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Reviewed-by:
-
Dan Harrington authored
- Improve the style of the content: style more closely approximates the suggestions on the NTP. This is still a placeholder UI until we receive the UI spec. - Pressing on content will open it up. - Add 'show all' option. Pressing on it opens the download manager. Bug: 852872 Change-Id: I1d5b93420b88e5a947baac418ca372475b1155cc Reviewed-on: https://chromium-review.googlesource.com/1164177 Commit-Queue: Dan H <harringtond@google.com> Reviewed-by:
Edward Jung <edwardjung@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#585523}
-
Elly Fong-Jones authored
On Mac, VKEY_APPS is actually the right command key, which is not supposed to behave this way in menus. Bug: 875559 Change-Id: I78329273f4ddd5c5cd9aed89669d46f722de118b Reviewed-on: https://chromium-review.googlesource.com/1186705Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#585522}
-
Kevin McNee authored
In the guest view js implementation, setupAttributes and getApiMethods both form circular dependencies. Bug: 793935 Change-Id: I1118e03daea247e3ea670b6bee3788ba9558d779 Reviewed-on: https://chromium-review.googlesource.com/1177841Reviewed-by:
Paul Meyer <paulmeyer@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#585521}
-
Ben Pastene authored
This reverts commit 80a5f1d8. Reason for revert: outage over Original change's description: > Demote android-kitkat-arm-rel to 100% CQ experiment. > > It's not doing well. > https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel?limit=200 > > Fortunately, the M bot is ok: > https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-marshmallow-arm64-rel?limit=200 > > NOTRY=true > > Bug: 876539 > Change-Id: Icb9770bf0df60fe28ad92dfabeb0c5c8f14f30af > Reviewed-on: https://chromium-review.googlesource.com/1185229 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585029} TBR=dpranke@chromium.org,bpastene@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 876539 Change-Id: I3f137fb209f0decfc13be5dab518e9e644e98b8c Reviewed-on: https://chromium-review.googlesource.com/1187084Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9259fd0d4f4c..c40974417610 git log 9259fd0d4f4c..c40974417610 --date=short --no-merges --format='%ad %ae %s' 2018-08-23 syoussefi@google.com Fix x64 visual studio build errors Created with: gclient setdep -r src/third_party/angle@c40974417610 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I88df068b59390a601bf40fa81532ca33c3bc1ab6 Reviewed-on: https://chromium-review.googlesource.com/1186551Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585519}
-
braveyao authored
IOSurfaceCapturer has been enabled 100% everywhere. So remove the related field trial testing config. Bug: 840597 Change-Id: I3d79b5f734c86ec5197527e7c7736c0233dcff71 Reviewed-on: https://chromium-review.googlesource.com/1185526Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#585518}
-
Eugene But authored
Added the following tests: - testAccessibilityOnNotStartedDownloadToolbar - testAccessibilityOnCompletedDownloadToolbar Bug: 854232 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2c49197f02881548cdae817a9753798507ddfc3b Reviewed-on: https://chromium-review.googlesource.com/1184323Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#585517}
-
Bailey Berro authored
This change enforces the NetBiosShareDiscoveryEnabled policy. If enforced, no NetBios discovery will be set up or performed when by the SmbService. Bug: 757625 Change-Id: I8bcd8d049dc597db208f9c38fae5a17b8069dd28 Reviewed-on: https://chromium-review.googlesource.com/1185405 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#585516}
-
Rayan Kanso authored
This was causing callbacks (like GetVisualsForItem) to be lost since the ContentID namespace did not match the registered OfflineContentProvider namespace. Change-Id: I009cbd2c38ac8d91c8c1efcd302be725c6588463 Reviewed-on: https://chromium-review.googlesource.com/1186734Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#585515}
-
Ted Choc authored
All committers should have the ability to modify strings. BUG=876369 Change-Id: Ie2d456de05bb6da79b802a408c19ad3d657db187 Reviewed-on: https://chromium-review.googlesource.com/1187007Reviewed-by:
-
Boris Sazonov authored
This CL performs several minor cleanups in SyncAndServicesPreferences without any changes to the behavior: 1. Reorder constants, fields and calls to have a consistent order for preferences. 2. Consistently use PREF_ prefix for preference keys. 3. Use mSync prefix for preferences that control sync data types. 4. Rename mSyncOmnibox to mSyncHistory to match the title string. 5. Replace onPreferenceClick and if chain with separate listener objects. Bug: 814728 Change-Id: I60fda93757fa160e7c70b98925486332880c92d5 Reviewed-on: https://chromium-review.googlesource.com/1185200Reviewed-by:
-
David Benjamin authored
We have not worked on this code for years. Others have more context around it these days. Bug: none Change-Id: I95c258b08b6e25c359b3b7faa6bfa91cede95350 Reviewed-on: https://chromium-review.googlesource.com/1186981 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#585512}
-
khmel@google.com authored
This resolves races in this test. TEST=Passes ~10000 iteration, no failure reported (before ~5%) BUG=874538 Change-Id: I4d098ebc9a3bb76af3d640a0336716a9b570a2a3 Reviewed-on: https://chromium-review.googlesource.com/1186548 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
-
Guido Urdaneta authored
This reverts commit 68e23978. Reason for revert: As expected, this revert had nothing to do with the WebRTC bot failures. Original change's description: > Revert "[NTP] Clear attribution on the existing tab when apply a theme" > > This reverts commit a9ed1fd3. > > Reason for revert: Speculative revert since two WebRTC bots started failing reliably after this CL. > If the revert does not fix the bots (which I think is likely), we will reland it. > > Original change's description: > > [NTP] Clear attribution on the existing tab when apply a theme > > > > Now we will clear the attribution also on the existing tab when a theme > > is applied. > > > > Bug: 875519 > > Change-Id: I65e8a0dc1ed3492c512cabcf1a2d3f0e6f2e64f7 > > Reviewed-on: https://chromium-review.googlesource.com/1181684 > > Commit-Queue: Weilun Shi <sweilun@chromium.org> > > Reviewed-by: Kristi Park <kristipark@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#584964} > > TBR=kristipark@chromium.org,ramyan@chromium.org,kmilka@chromium.org,sweilun@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 875519 > Change-Id: I20ff372903d2abee0620d42e9cff18777515ac65 > Reviewed-on: https://chromium-review.googlesource.com/1186762 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585499} TBR=guidou@chromium.org,kristipark@chromium.org,ramyan@chromium.org,kmilka@chromium.org,sweilun@chromium.org Change-Id: Ie612910fe42f3ce69fb87186ab3a4b5bc1331afc No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 875519 Reviewed-on: https://chromium-review.googlesource.com/1186802Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#585510}
-
Aleks Totic authored
Bug: 591099 Change-Id: I714827fa06e19ae0b3067ba864ff26f182e07e3c Reviewed-on: https://chromium-review.googlesource.com/1185970Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#585509}
-
gogerald authored
This CL also removes a redundant interface and moved the interface around. Bug: 839130 Change-Id: I5a684dd0319302ed9a0cda95f02ee6f9401be835 Reviewed-on: https://chromium-review.googlesource.com/1185876Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#585508}
-
David Benjamin authored
I was added as backup OWNER before net/OWNERS as here. Now that net/OWNERS is here, remove explicit reference to myself, so this is spread between all net/OWNERS. Bug: none Change-Id: Id27d6b73e24708fa0eb9c903621f9d40c7d20956 Reviewed-on: https://chromium-review.googlesource.com/1186983Reviewed-by:
-
Sam Maier authored
This is a reland of be62a5ba Original change's description: > Android: removing default execute() on AsyncTask > > execute() is a confusing function, with a hidden implicit meaning that > changed in API 11. It would be better if everyone had to use the more > explicit executeOnExecutor() so their preference (serial or thread pool) > is called out. > > Bug: 869907 > Change-Id: I79be6d2b3114cb0520df1104ec5849f7c070c99e > Reviewed-on: https://chromium-review.googlesource.com/1172446 > Reviewed-by: agrieve <agrieve@chromium.org> > Commit-Queue: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584189} TBR=smaier@ reland now that fix is in https://chromium-review.googlesource.com/c/chromium/src/+/1172446 Bug: 869907 Change-Id: I90613192c8655ee08dba939785c79e4aa254c08c Reviewed-on: https://chromium-review.googlesource.com/1181803 Commit-Queue: Sam Maier <smaier@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#585506}
-
Maxim Kolosovskiy authored
If the password generation element is in <iframe>, the popup is shown at wrong position (see the bug). Autofill popups (a list of saved credentials) worked fine. The bounds of the element is changed in two steps: a) apply TransformToRootCoordinates from chrome_password_manager_client.cc b) add web_contents()->GetContainerBounds().OffsetFromOrigin() which is an equivalent of GetBoundsInScreenSpace from chrome_password_manager_client.cc. For generation popups, only TransformToRootCoordinates was applied. This CL adds the second step. Bug: 877049 Change-Id: Ic96b1c454dc245055c641b7fc4ad4b69d5c285dd Reviewed-on: https://chromium-review.googlesource.com/1186736 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#585505}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/31629a8a3271..9db44ed0ef7f git log 31629a8a3271..9db44ed0ef7f --date=short --no-merges --format='%ad %ae %s' 2018-08-23 halcanary@google.com bin/droid script: fix wierd mkdir error on my device 2018-08-23 bsalomon@google.com Revert "Fix leak in SkSLParser" 2018-08-23 bsalomon@google.com Fix leak in SkSLParser 2018-08-23 egdaniel@google.com Revert "Add GPU-side caching of mask-filtered path masks" 2018-08-23 fmalita@chromium.org [skottie] Plumb external SkFontMgr 2018-08-23 borenet@google.com [infra] Speculative fix for cq.cfg 2018-08-23 robertphillips@google.com Add GPU-side caching of mask-filtered path masks Created with: gclient setdep -r src/third_party/skia@9db44ed0ef7f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I2cbb2524eafe25d1acf017b7ae0c1ad25963e0c7 Reviewed-on: https://chromium-review.googlesource.com/1186665Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585504}
-
