GitLab

This CL is part of the Chrome OS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.

Bug: 1101837, 1164001
Change-Id: Ife8f40d30569e2eff4b6c6c97e7efe2d58ff1c77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640415
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845864}

https://skia.googlesource.com/skia.git/+log/230cd50238f2..37d16f135265

2021-01-21 csmartdalton@google.com Remove GrTriangulator::fIsLinear
2021-01-21 csmartdalton@google.com GrTriangulator cleanups
2021-01-21 robertphillips@google.com Add new lazytiling GM and update GrTextureEffect
2021-01-21 nifong@google.com Fix most remaining wasm gm unit tests by correctly providing gl context
2021-01-21 tdenniston@google.com [svg] Implement SourceAlpha input for filter effects
2021-01-21 kjlubick@google.com [canvaskit] Include types in docker build
2021-01-21 tdenniston@google.com [svg] Several filter helper tweaks
2021-01-21 johnstiles@google.com Improve consistency of SPIR-V code generation.
2021-01-21 reed@google.com Update legacy shader context to take sampling
2021-01-21 kjlubick@google.com [canvaskit] Properly downsample 4x4 matrices.
2021-01-21 bsalomon@google.com Make render task targets be just a proxy.
2021-01-21 mtklein@google.com three small fixes for w-parameter
2021-01-21 mtklein@google.com baby's first use of st2/4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC scroggo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: scroggo@google.com
Change-Id: If75043acf608579e15e3c22465c306d32f7cfd45
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643119Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845863}

On the high visibility page, the spacing between the help text and the
icon (!) was too large. Change to 12px to match the other pages.

Change the page titles to use Google Sans to match the spec.

Screenshot: https://screenshot.googleplex.com/aYxByqUaNK6JNUc.png

Fixed: 1169284
Change-Id: Ibd229aab2e2eb3678a7880ce60e94f6b74cd072c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643121Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Curt Clemens <cclem@google.com>
Cr-Commit-Position: refs/heads/master@{#845862}

In the attached bug, speech is triggered in a startup, fresh imaged
environment.

To replicate this,
`rm -rf /home/chronos/*`, then trigger some tts after boot.

The browser process hangs, e.g.
gdb attach <browser_pid>
...
bt

...
#5  0x000058e02342da8f in TtsExtensionEngine::GetVoices(content::BrowserContext*, std::__1::vector<content::VoiceData, std::__1::allocator<content::VoiceData> >*) ()
#6  0x000058e021612615 in content::TtsControllerImpl::SpeakNow(std::__1::unique_ptr<content::TtsUtterance, std::__1::default_delete<content::TtsUtterance> >) ()
#7  0x000058e021612e8f in content::TtsControllerImpl::SpeakNextUtterance() ()
#8  0x000058e01ff769d4 in content::TtsControllerImpl::VoicesChanged() ()
#9  0x000058e02342eeb4 in ExtensionTtsEngineUpdateVoicesFunction::Run() ()
#10 0x000058e02185ebe2 in ExtensionFunction::RunWithValidation() ()
#11 0x000058e021860c5d in extensions::ExtensionFunctionDispatcher::DispatchWithCallbackInternal(ExtensionHostMsg_Request_Params const&, content::RenderFrameHost*, int, base::RepeatingCallback<void (ExtensionFunction::ResponseType, base::ListValue const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&)> const&) ()
#12 0x000058e021860773 in extensions::ExtensionFunctionDispatcher::Dispatch(ExtensionHostMsg_Request_Params const&, content::RenderFrameHost*, int) ()
#13 0x000058e0218818ea in bool IPC::MessageT<ExtensionHostMsg_Request_Meta, std::__1::tuple<ExtensionHostMsg_Request_Params>, void>::Dispatch<extensions::ExtensionWebContentsObserver, extensions::ExtensionWebContentsObserver, content::RenderFrameHost, void (extensions::ExtensionWebContentsObserver::*)(content::RenderFrameHost*, ExtensionHostMsg_Request_Params const&)>(IPC::Message const*, extensions::ExtensionWebContentsObserver*, extensions::ExtensionWebContentsObserver*, content::RenderFrameHost*, void (extensions::ExtensionWebContentsObserver::*)(content::RenderFrameHost*, ExtensionHostMsg_Request_Params const&)) ()

The hang:
TtsControllerImpl::SpeakNextUtterance ->
TtsControllerImpl::SpeakNow ->
TtsControllerImpl::OnSpeakFinished ->
enqueues the utterance back onto |utterance_list_| on failure.

which occurs all while(... !utterance_list_.empty()), leading to a
browser hang.

Solution:
The above utterance fails immediately because the voice is not yet
ready.  We fix this by never returning the voice in the first place, in
TtsControllerImpl::GetVoices.

Therefore, we never get to the point where an utterance matches against
a not yet initialized voice, leading to an attempt to speak, then to an
immediate failure, next to a re-enqueue, and finally a hang.

Bug: 1161107
Change-Id: I2d88c0c6e86bf79ad9ac5dc5240825848daa40ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642746
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845861}

Get() does the same thing as View() and it is recommended to use Get()
instead of View(). So replaced View() with Get() and deleted View().
Also delete Get() where it can be omitted.

Change-Id: Ifa25b6d8e63c95932abc7ad5b229e80e75d722ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639071Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Canon Mukai <canonmukai@google.com>
Cr-Commit-Position: refs/heads/master@{#845860}

The .well-known/webid file can take an arbitrarily long time to load,
but even when it loads immediately, it introduces an unnecessarily long
delay between invoking the API and the browser UX responding to it.

It is the case that the .well-known/webid file can be done
uncredentialed, and hence in parallel, but for the sake of simplicity
I'm just changing some of the sequencing of events.

Upon acknowledgement of the permission prompt, we should also open the
modal dialog right away, before if finishes loading the signin_url,
because that can also take an arbitrarily long time to load and we want
to make sure the user understands who is accountable for the delay (i.e.
that the browser UX has responded to the gesture that the user made)

Bug: 1141125
Change-Id: I40fc02c03488d3a1d6de383b5397baf4cc7aa604
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631451
Auto-Submit: Sam Goto <goto@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Sam Goto <goto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845859}

A recent roll of android docker image causes bundle tests to fail on luci-milo.
Adding these tests so that such issue can be caught early on -dev env.

Bug: 1169406
Change-Id: Id27586b37cbaead5979abfe7e1566f0f068358e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643938Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#845858}

TBR=pnoland@chromium.org

Bug: 1169250
Change-Id: I2b79349d203c42e1b11f7476c13884977ca6c562
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643704Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845857}

Change-Id: Icc9d3644a5ebbbe3028bf6ee69e16431bb58af44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643858
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#845856}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea17cd60ebc3..07a24ad5b02e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC hesen@google.com,lgrey@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1150968,chromium:1166926
Tbr: hesen@google.com,lgrey@google.com
Change-Id: Id4f09d1c33ddc4b25d67c78982dfc560f7c20e97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643622Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845855}

Change-Id: I03ef5402d5fdaf7a89e74c0eb86e914d8ca47ecc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618544
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845854}

This reverts commit be5c5c0f.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 845723 as the
culprit for failures in the build cycles as shown on:
https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JlNWM1YzBmOGRhMDdkMTM3MzAwYzFmZjgzZmExMWQwODU4ZDU0MTUM

Sample Failed Build: https://ci.chromium.org/b/8857454642050670096

Sample Failed Step: browser_tests

Original change's description:
> Reland "Reland "system-web-apps: implements a new LaunchSystemWebAppAsync API""
> 
> This is a reland of 38aeef20
> 
> The first reland adds a test for behaviors during browser shutdown, and
> doesn't yield consistent result. The second reland removes that test.
> 
> The shutdown test was intended to fix https://crbug.com/1121894, where
> we hit CHECK in Browser constructor. The bug was fixed by checking
> browser isn't shutting down in LaunchSWAImpl.]
> 
> It's okay to not test shutdown in LaunchSWAAsync (the added test in
> first reland), because LaunchSWAAsync doesn't attempt to create browser
> windows, and calls methods on objects (Profile, AppService) that are
> still valid during Browser shutdown sequence. So the LaunchSWAAsync API
> shuoldn't experience similar crashes observed in
> https://crbug.com/1121894.
> 
> Original change's description:
> > Reland "system-web-apps: implements a new LaunchSystemWebAppAsync API"
> >
> > This is a reland of 62cb2352
> >
> > The original CL fails when AppBrowserControllerBrowserTest.Shutdown
> > passed a destroyed to LaunchSWAImpl. The reland removes this DCHECK
> > because the use of GetCreationStatusForProfile already makes sure the
> > DCHECK is always successful.
> >
> > Original change's description:
> > > system-web-apps: implements a new LaunchSystemWebAppAsync API
> > >
> > > This CL implements a new LaunchSystemWebAppAsync API, which is for other
> > > chrome components to launch a SWA safely. This new API should be used
> > > for SWA launches.
> > >
> > > The new API uses AppService to record metrics, handle disabled apps,
> > > etc.
> > >
> > > The old LaunchSWA is deprecated (its logic now becomes LaunchSWAImpl).
> > >
> > > LaunchSWAImpl is publicly declared because certain browser tests need to
> > > know the browser that hosts the SWA. It shouldn't be used to launch the
> > > App (other than LaunchSWA and Web app implementations). Subsequent CLs
> > > will attempt to migrate these browsertests to work with the new API.
> > >
> > > Bug: 1154540
> > > Change-Id: I648a3b0404067ba460f0174e975fae44b3a0001a
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592270
> > > Reviewed-by: James Cook <jamescook@chromium.org>
> > > Reviewed-by: Nancy Wang <nancylingwang@chromium.org>
> > > Reviewed-by: Scott Violet <sky@chromium.org>
> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > > Commit-Queue: Jiewei Qian  <qjw@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#843939}
> >
> > Bug: 1154540
> > Change-Id: Ice207ac03834452223c5bb2ef880c6667e6cb25b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633485
> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Auto-Submit: Jiewei Qian  <qjw@chromium.org>
> > Commit-Queue: Jiewei Qian  <qjw@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#845049}
> 
> Bug: 1154540
> Change-Id: I823b43be08c4fb6aefd53a92442359eee296bab3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641605
> Commit-Queue: Scott Violet <sky@chromium.org>
> Auto-Submit: Jiewei Qian  <qjw@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#845723}


Change-Id: I582f9772d283686ae460d9e8b77beb1f8651a282
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1154540
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644138
Cr-Commit-Position: refs/heads/master@{#845853}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8d1dafc6c231..7c153a21c203

2021-01-21 vidorteg@microsoft.com [Loc] Migrate profiler to Localization V2
2021-01-21 andoli@chromium.org [module.json extensions] timeline views
2021-01-21 andoli@chromium.org [module.json extensions] migrate remaining views in browser_debuger
2021-01-21 andoli@chromium.org [module.json extensions] performance_monitor
2021-01-21 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1134103,chromium:1136655
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: Id46271f0834eb53b20de0da99646e1e74b278dd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643145Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845852}

This CL adds metrics measuring outcome of the signed-in profile creation
flow.

Bug: 1169040
Change-Id: I71836804d1096355e4429f055e4878913ed48c17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640541
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845851}

The fuzzer started requesting sizes of 27648x7936 which quickly lead to
OOM situations. This limits the max size to 4096x4096 for resizes. We
will probably need to limit decodes to this size eventually.

R=chcunningham

Fixed: 1169376
Change-Id: I3f7bbf5b56fe96a45771eada1779657476c12ffa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643566
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Chrome Cunningham <chcunningham@chromium.org>
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845850}

If document_ is not set, StyleFetchedImage::ImageNotifyFinished() is a
no-op, so we can return early.

Change-Id: Id967ab46ef583185df42132c972b956c16f853a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643406
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845849}

This is a speculative fix for a DCHECK failure. If SkiaRenderer skips
swap then |current_buffer_modified_| isn't reset to false and looks like
it can violate a DCHECK condition. Add code to SwapBuffersSkipped() that
handles updating framebuffer damage rects and resetting
|current_buffer_modified_|.

Bug: 1161653
Change-Id: Ie811fca55cbf5c57ed5e4af50772e2e538f7b911
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640895Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845848}

Roll Chrome Win64 PGO profile from chrome-win64-master-1611241154-5f537a5e634f10cbf823c07501b1298a461fb817.profdata to chrome-win64-master-1611262248-73432c89b66dbe2013eb2cab3a4d4391b3f9edd9.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-win64-chromium
Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:win64-chrome
Tbr: pgo-profile-sheriffs@google.com
Change-Id: I14246590e8501c85963616d5c61683451c8bc3ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643104Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845847}

1. Previously, we were storing the set indices of each item directly in
GridItemData. This is not necessary as they can be computed on demand.
`CacheItemSetIndices` was renamed to `ComputeItemSetIndices` and was
changed to return `ItemSetIndices` instead.

2. `ResolveOutOfFlowItemGridLines` was moved to `NGGridPlacement`
addressing a TODO. Now the variables `automatic_repetitions` and
`explicit_start` can be directly obtained from the placement instance.

This change does not add nor remove any functionality.

Bug: 1045599
Change-Id: Ib0d3898f9979788cb4e9f7311ab9ad7a1c03504f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626356
Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com>
Reviewed-by: Ethan Jimenez <ethavar@microsoft.com>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Jacques Newman <janewman@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#845846}

We used to prioritize translation intent since the annonation model has
performance issues. Since we switched to the more stable dictionary
based model, reset the priority.

Bug: None
Test: Run existing tests
Change-Id: I939d0f237c6adaf0e12361177efb60ed17990a9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641993Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jeroen Dhollander <jeroendh@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845845}

They add a lot of redundant load, are flaky, and this is an unshipped configuration
Additionally, turns down android-mojo-webview-rel since that's the only thing it ran.

BUG=1169248

Change-Id: I11c7b5bd6a4b8965faa79dcec0ac12f2624ebb15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641119
Commit-Queue: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Haiyang Pan <hypan@google.com>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845844}

TBR=andypaicu@chromium.org

Bug: 1167452
Change-Id: I68155a0657feda06f713b9cf02f9b3d15d1dc01d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643756
Auto-Submit: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845843}

We currently wait for an "I'm ready" signal from the Settings app before
we serve settings search results. Unfortunately this signal is flaky,
and leads to some users never seeing settings results. This CL removes
the check altogether as a temporary measure, while we investigate a
root-cause fix.

UX impact: there's a very short window of time after logging in where
settings results won't do anything, because the Settings app isn't ready
yet. This is short enough that we don't believe it's an issue.

Bug: 1167575
Change-Id: If63770453febbf48d2fe721706daee9ccedcd608
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631822
Commit-Queue: Tony Yeoman <tby@chromium.org>
Reviewed-by: Rachel Wong <wrong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845842}

https://dawn.googlesource.com/dawn.git/+log/001b499275e1..b5cfe3a7746c

2021-01-21 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from afb8cfb2544b to 6761160dc149 (7 revisions)
2021-01-21 enga@chromium.org Add cron-linux-clang-rel-x64 for running cron jobs on CI

Also rolling transitive DEPS:
  https://dawn.googlesource.com/tint from afb8cfb2544b to 6761160dc149

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC sarahmashay@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: None
Tbr: sarahmashay@google.com
Change-Id: I6c3d0ba6b7068696a10fc05bac1b117028f8b015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643122Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845841}

Using wpt-import in Chromium bbb681f0.
With Chromium commits locally applied on WPT:
820c25f5 "Prevent underinvalidation of <pattern> with template"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
jsbell@chromium.org:
  external/wpt/resources

NOAUTOREVERT=true
TBR=lpz@google.com

No-Export: true
Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel
Change-Id: Ia665a4b9b4e60676b8153d3418d6d7f86112566c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643636Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845840}

Change-Id: Ia3d620f9db46a3ba201c90495c9b8328d7bd52c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643272Reviewed-by: Scott Little <sclittle@chromium.org>
Commit-Queue: Megan Jablonski <megjablon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845839}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/02e777d04e20..03fc9a3eb3f8

2021-01-21 chanli@chromium.org [depot_tools] Update rdb pin

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1103287
Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com
Change-Id: Ie3231b6c745be1629506020c43172289baeeb7e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643603Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845838}

This installs a homescreen shortcut for a webpage. It seems at least
some of the code for doing this, i.e. AddShortcutWithSkBitmap(), is
componentizable and could run in WebLayer. This may be desirable
specifically for the case where Chrome is not the default browser
(creating a shortcut in the default browser). However for now, that
decision and work is punted.

Bug: 1164069
Change-Id: I8fbb789dc833a09358a821aba828d7a82ee9fd86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640935Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845837}

This CL introduces a test helper method that refactors away common
checks used in multiple tests and moves those tests to use it.
It is in preparation of enabling subframe error page isolation.

Bug: 838161
Change-Id: Icb32d9a308dc5a8d5e4f93dbdf56e04bb1650b74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641085
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845836}

This CL merges crostini_shared_usb_devices.{html,js} and plugin_vm_sh..,
as they are identical aside from one string and the VM name constant.

Bug: 1167980
Change-Id: Ie444a7d81b099d15d7ee04a65c4666231899c843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639715Reviewed-by: Jimmy Gong <jimmyxgong@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845835}

This CL is part of the Chrome OS source code directory migration:
https://docs.google.com/document/d/1g-98HpzA8XcoGBWUv1gQNr4rbnD5yfvbtYZyPDDbkaE.

Bug: 1101837, 1164001
Change-Id: I0108d52f30555e3945a324cf73038a0e39618d68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640353
Owners-Override: James Cook <jamescook@chromium.org>
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Auto-Submit: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845834}

Replace kkhorimoto (left the team) and eugenebut (leaving the team)
with gambard and ajuma whose expertise is the closest to http
authentication.

Bug: None
Change-Id: I7044737e383a961c82fad44cf2f2c7352b26d0c7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641132Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845833}

Issue: Predictive completions in some IMEs are not working properly
when typing in a webpage.

Cause: Appkit <-(sync)-> RWHVCocoa <-(async)-> Blink

In an IME composition commit, RWHV commits the text to Blink
through an async mojo call. Later when Blink finishes commit, it updates
the text in RWHV through a separate mojo call.

For predictive completions to work, IMEs calls RWHV's
|attributedSubstringForProposedRange:| to retrieve some text
as the context for prediction. Oftentimes the call happens before
Blink's async update to RWHV, resulting in a wrong predictive context.

This issue troubles both Chromium and Firefox but not Safari/Webkit.
Webkit is using an undocumented async IME API.

Also after macOS 10.12+, IMEs expect |selectedRange:| to return a empty
range positioned at the end of the committed text. If not respected the
predictive completions won't work.

Solution:
- Temporarily insert the committed text to RWHV's available text
- Follow the |selectedRange:| requirement

Bug: 710101
Change-Id: I3e4267362ea3e0a6b9f7cebce23fe59d1a6ece6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606140Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845832}

Previous CL split PasswordProtectionRequest into base and derived classes.
A weakptr_factory was added to the derived class, but this is not
necessary. We can use base::AsWeakPtr(&derived) to get a weak ptr to
the derived instance.

Bug: 1147967
Change-Id: I7df37dbe13448a7359707238fbfb8ca18b62ed65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642744Reviewed-by: Ali Juma <ajuma@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845831}

https://swiftshader.googlesource.com/SwiftShader.git/+log/1d5174b9dc3b..5b36fbc5ed2b

2021-01-21 capn@google.com Target macOS 10.12 when building LLVM
2021-01-21 capn@google.com Use aligned allocation for classes with aligned members
2021-01-21 nicolascapens@google.com Enable and require C++17 compilation

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I986f61efb56c3c3ca18b0100ae6ca3dfee2fed7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643117Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#845830}

Bug: 1159169
Change-Id: I9a23bed470b544d5da3938a6889b28fd2375201c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643700Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845829}

This reverts commit 6674e06c.

Reason for revert: Failing on android-pie-x86-rel:

PolicyTestWebXRImmersiveAR.CheckImmersiveARWorksWhenNotSet

PolicyTestWebXRImmersiveAR.CheckImmersiveARWorksWhenEnabled

Original change's description:
> WebXR: add enterprise policy for immersive-ar sessions
>
> This CL adds new enterprise policy that is used to gate access to
> immersive-ar sessions in WebXR Device API. The enterprise policy is
> per-profile, and is implemented by propagating the pref value from
> browser process to blink via WebPreferences.
>
> Additionally, the CL also introduces new AndroidBrowserTest that
> exercises the added glue code, with the assumption that the enterprise
> policy code that controls the pref is correct.
>
> Other changes:
> - add manifest entry in test jinja template in order for them to work on
>   newer Android versions
> - add DVLOGs in WebXR code paths to assist with debugging
>
> Bug: 1159067
> Change-Id: I27eba5fc0e7bae3dca2d47ca3fb2e935facbd37c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627778
> Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Owen Min <zmin@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Reviewed-by: Alexander Cooper <alcooper@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#845521}

TBR=dcheng@chromium.org,tedchoc@chromium.org,zmin@chromium.org,bialpio@chromium.org,alcooper@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: Iac63a792c5d243d01bb3307983de25113cbe614d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1159067
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643625Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845828}

The CQ for infra/config changes often only run the chromium_presubmit
builder and when there are outages that affect the builders that share
machines with chromium_presubmit, it means that changes to attempt to
address the outage may experience long pending times and/or require
skipping the presubmit. Increasing the priority will allow us to keep
the safety provided by the presubmit while still being able to land
changes quickly to address outages.

Bug: 1168201
Change-Id: I828ffcf74a162a6ebdaba0075e6d66ffb31ab2c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643407
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845827}

This cl changes the software backend used for
running viz_unittests and cc_unittests from
SwiftShader GL to SwANGLE (ANGLE on SwiftShader
Vulkan). Other tests suites may be affected.

From this cl, performance expectations for test
runs will likely change. For example, cc_unittests
appears to run faster, while viz_unittests and
views_unittests appear to run slower. Note that
this is still using the validating command decoder,
and once the OOP Raster tests can run on the
passthrough command decoder, we'll be able to use
it and gain some performance on all these test runs.

TBR=kbr@chromium.org
TBR=weiliangc@chromium.org
TBR=eugenis@chromium.org
Reason for TBR: These changes were already reviewed here https://chromium-review.googlesource.com/c/chromium/src/+/2532042

Bug: chromium:1060139
Change-Id: Idb0048d3a8e0dfe6855e1700ed26fb076be0c4f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580360
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Evgenii Stepanov <eugenis@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845826}

The presubmit check uses the most recent version, which was resulting in
different output for cq-builders.md. It also ow warns about
crbug.com/1054172 being an unknown experiement.

Change-Id: I323a9474df1824bfbc61a892aad75899a0055945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642188
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845825}