GitLab

We will use these types from both blink and //content and from code
inside //components.

This patch affects Clank downstream and will be submitted together with
a patch in that repo to avoid breakage. Clank CL:
https://crrev.com/i/2545991

See discussion in design doc:
https://docs.google.com/document/d/1ZA-1EMq4d40K5qfsZoeMIhJmZA6-AXaSibD3SsqZjfU/edit#

Bug: 1044252
Change-Id: Id658caa422bedbcb6d2275a8ccdd76f73bf955c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051363Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Sam Bowen <sgbowen@google.com>
Cr-Commit-Position: refs/heads/master@{#741227}

Bug: 710376, 778317
Change-Id: Ifc5cd2a0d961c3503a7732252398cdd24f30fcf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053929Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741226}

The tests are way less likely to fail as a result of noise

TBR=Crouleau@chromium.org

Bug: chromium:1052054
Change-Id: I55d29c2de1ef72db5315c1d792dd7fd9c67f5d3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055047Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741225}

Bug: 1049604
Change-Id: Ice20cf9ed6539d531d6e771013d1ef34e7d9635f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054295
Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741224}

* Moved directories:
ash/components/fast_ink -> ash/fast_ink
ash/components/cursor -> ash/fast_ink/cursor
ash/laser -> ash/fast_ink/laser

Rationale: fast_ink is a framework that can bypass native ui's cc
and /cursor and /laser are clients of this framework.

* Consolidated OWNERS to one

Bug: 1046624
Change-Id: I8c9475e4ccf4413b6626975f65479f87af51bed0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050843Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741223}

Screenshot:
https://screenshot.googleplex.com/7ZyeNAwxjxC.png

Bug: 1052026
Change-Id: Ie0e5f58b03e1fdc21d2c6dafc1c6990636b2ebc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054564
Commit-Queue: Ehsan Kia <ehsankia@google.com>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741222}

This reverts commit b3bd6f98.

Reason for revert: Speculative fix for crbug.com/1052142:
Landing this coincided with MSAN failures in 
BackgroundTracingManagerBrowserTest.PerfettoSystemBackgroundScenarioDefaultName
BackgroundTracingManagerBrowserTest.PerfettoSystemBackgroundScenarioRuleId

Original change's description:
> tracing: Update to latest TrackEventDescriptor message and roll Perfetto
> 
> git log f440b92c2422..02808dc0a181 --date=short --first-parent --format='%ad %ae %s'
> 2020-02-12 treehugger-gerrit@google.com Merge "TrackEvent: Add configuration for TrackEvent"
> 2020-02-12 fmayer@google.com Merge "Roll trace_to_text to pick up aosp/1232924"
> 2020-02-12 skyostil@google.com Merge "TrackEvent: Implement dynamic categories"
> 
> Created with:
>   gclient setdep -r src/third_party/perfetto@02808dc0a181
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/perfetto-chromium-autoroll
> Please CC perfetto-bugs@google.com on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> Bug: None
> Tbr: perfetto-bugs@google.com
> Change-Id: Ia7577abef7435e6ef8a37ac3a42b94363c44c986
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054248
> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Stephen Nusko <nuskos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#741071}

TBR=skyostil@chromium.org,nuskos@chromium.org

Change-Id: Ib11cfbd9a29aa21515b64d322128a9ddbac8360c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1052142
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055592Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741221}

Devtools was using this interface, and when IndexedDB moves to the
storage service, it will need to access it via mojo instead.
This creates a function for observing IndexedDB changes on the
IndexedDBControl interface and replaces users and tests.

The IndexedDBDispatcherHostTest tests are disabled and were both broken
(identically without this change).  They are updated to at least pass,
although enabling them will be done in a followup to avoid getting this
reverted.

Bug: 1015214
Change-Id: I455d06545e9bbc780173244846b7e801f6bae2cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052768
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741220}

This reverts commit 67a641bc.

Reason for revert: Need to revert this roll in order to revert
the roll which may have caused crbug.com/1052142.

Original change's description:
> Roll src/third_party/perfetto 02808dc0a181..465b5e722d31 (9 commits)
> 
> https://android.googlesource.com/platform/external/perfetto.git/+log/02808dc0a181..465b5e722d31
> 
> git log 02808dc0a181..465b5e722d31 --date=short --first-parent --format='%ad %ae %s'
> 2020-02-13 treehugger-gerrit@google.com Merge "perf sampling: minimal UI for stacks as slice columns"
> 2020-02-13 hjd@google.com Merge "Fix Mac compile of api_integrationtest.cc"
> 2020-02-13 fmayer@google.com Merge "Remove stale comment."
> 2020-02-13 lalitm@google.com Merge "tp: make diff testing script run all tests by default"
> 2020-02-13 lalitm@google.com Merge "tp: cleanup diff test script in preperation for unified execution"
> 2020-02-13 ddrone@google.com Add frame_tree_node_id to LatencyInfo.Flow event
> 2020-02-12 treehugger-gerrit@google.com Merge "processor: Override/extend args correctly when merging"
> 2020-02-12 treehugger-gerrit@google.com Merge "TrackEvent: Register available categories with service"
> 2020-02-12 treehugger-gerrit@google.com Merge "UI: update logo and sidebar animation"
> 
> Created with:
>   gclient setdep -r src/third_party/perfetto@465b5e722d31
> 
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/perfetto-chromium-autoroll
> Please CC perfetto-bugs@google.com on the revert to ensure that a human
> is aware of the problem.
> 
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
> 
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
> 
> Bug: chromium:148777631
> Tbr: perfetto-bugs@google.com
> Change-Id: I60adf3a7482a2df1c8419eb6916812a7bfa6035c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053302
> Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/master@{#741125}

TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,perfetto-bugs@google.com

Change-Id: Idf533af0c122b7c71e74280b0fd87c1638d35abd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:148777631,1052142
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055556Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741219}

Initially this DCHECK was placed to prevent an increase in case #3,
checking quads against the target space occluding region. This case is
not a particularly high cost computation and is still relatively
uncommon.

The occluder in conentspace region may be empty if the target space
occluding rect is reduced to 0 after mapping into content space.

Bug: 1051922
Bug: 1051566
Change-Id: Iffd3433a7bf38be9951479c0d8d4c0d5f2b93dde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053410Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741218}

Be explicit about whether or not browser sync consent is required
when looking up the IdentityManager primary account.

Updated:
* kiosk mode tests
* login / user session
* device local account tests
* plugin vm

See go/cros-primary-account and go/consent-aware-api-dd

Bug: 1042400, 1046746
Test: existing browser_tests
Change-Id: I0f272f7bbcc2a4b0378cdf0e3590491617fe62a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054275Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741217}

This indicates how important the request is.

Bug: b/149323794
Change-Id: I23bd7177a89fa1122c9365268e1cffc45a4c9b7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055025Reviewed-by: Ian Wells <iwells@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741216}

This test appears to be flaking frequently:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyaAsSBUZsYWtlIl1jaHJvbWl1bUBicm93c2VyX3Rlc3RzQFByZXJlbmRlckJyb3dzZXJUZXN0LlByZXJlbmRlckNhbmNlbE1haW5GcmFtZVJlZGlyZWN0VW5zdXBwb3J0ZWRTY2hlbWUM

TBR=tbansal@chromium.org,darin@chromium.org

Bug: 1050143
Change-Id: I6fec8b6c4f1262c6884ad05be9be28e69775f805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055670Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741215}

Bug: 1051106
Test: fast/animation/animation-constructor-after-detach-crash.html
Change-Id: I1024e2c28d4ceafa22b738d20bdcc59144b20773
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055396
Commit-Queue: Nate Chapin <japhet@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741214}

Added more instructions on skipping representative perf tests stories.

Bug: chromium:1044705
Change-Id: Ic17b8ccbf345f4be207e0aa25c9a4fdfb0b1350c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035855
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741213}

This flag was introduced by https://crrev.com/c/533895, but not set correctly.

Bug: 732874
Change-Id: Ide151862a74cfeff575517e07ce3652fee201021
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053743Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741212}

Test: Manual
Bug: None
Change-Id: I14fbb5586dd2cef623f37c76f392a1719a775968
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053668Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: David Munro <davidmunro@google.com>
Cr-Commit-Position: refs/heads/master@{#741211}

TBR=govind@chromium.org

Change-Id: I6c6ed4e09bd52e2d9ca2fbec3a17e2a18368cffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055386Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741210}

Also:
- fixes the handling of menuItemSelected to only be respected from a focused node (Chrome now fires it more noisely)
- add a full test suite for options page testing which drives the UI end to end and verifies local ChromeVox state
(this motivated the above fix)
- noticed a regression in the way <select> nodes work (TODO'ed and not handled fixing in this change)
- adds a unit test for verifying number style reading behavior

Test: see above
Change-Id: I4dce435c6de54399128c1a21f805671b54ac3904
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003895
Commit-Queue: David Tseng <dtseng@chromium.org>
Reviewed-by: Akihiro Ota <akihiroota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741209}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome

BUG=762641
TBR=chrome-os-gardeners@google.com

Change-Id: I3ff44841ffcccb679698f1572372b157454b03c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054566Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#741208}

This CL disables SurfaceView for ThinWebView since currently we have an
issue with surface control in Q which breaks this feature.

https://chromium-review.googlesource.com/c/chromium/src/+/2029240 will fix
this, but it will land in M82. Hence disabling SurfaceView for now so
as to unblock features like ephemeral tab.

Bug: 1024622
Change-Id: Id6825934bd2270e6b45d66c2f3e9aa6db9dadf76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048507Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741207}

Moves a couple non-splitview tests from SplitViewOverviewSessionTest
to TabletOverviewSessionTest. This has less setup and functions, it
works well enough for the moved tests.

Test: ash_unittests
Bug: none
Change-Id: I6874fa8906895f8dc3279a3918544ad582f756c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053085
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741206}

This CL adds logic into ChromeWebUIControllerFactory for handling
Kaleidoscope URLs instead of using the
KaleidoscopeWebUIControllerFactory.

Bug: 1044741
Change-Id: I798b39fd8040f43fcfc1d841fea0f82fcf7985f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050032
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741205}

SplitSettingsSync will allow the user to opt-out of browser sync.
However, IdentityAccessor::GetPrimaryAccountInfo() defaults to
ConsentLevel::kSync, so it returns an empty struct if the user has not
consented to the browser sync feature.

Feedback isn't tied to browser sync. It has its own consent text in
the feedback dialog.

Switch to using the "unconsented" primary account. On Chrome OS this
account always exists for the logged-in user account, whether or not
the user consented to browser sync.

go/cros-primary-account and go/consent-aware-api-dd

Bug: 1042400, 1046746
Test: Send feedback, report shows up in dashboard
Change-Id: I3f515046994dbb13e826b4c0d62e765ac7025857
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053128Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741204}

Consider the following example :
<div>some</div> <!-- ID:1 -->
<div>text</div> <!-- ID:2 -->
<div aria-hidden="true">Hidden</div> <!-- ID:3 -->

Forward word navigation starting at ID:1 results in a range :
start: {ID:2, text_offset=0}
end: {ID:3, text_offset=0}

Because ID:3 is ignored, AsUnignoredPosition forward will result in
a NULL_POSITION because no unignored content follows.
For StopAtLastAnchorBoundary we want to try to resolve
AsUnignoredPosition in the opposite direction so it can resolve to the
last unignored position in the desired direction before it would have
crossed into the ignored region of content at the start/end of the
document.

Bug: 1049852
Change-Id: Ic19fba25492c915e321c64d2a8d2cfe158c4b7d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048905
Commit-Queue: Adam Ettenberger <Adam.Ettenberger@microsoft.com>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#741203}

This CL adds instantiations for:
 - ResourceLoadingHintsBrowserTestWithExperimentEnabled
 - ResourceLoadingHintsBrowserTestWithExperimentDisabled
 - ResourceLoadingHintsBrowserTestWithCoinFlipAlwaysHoldback

This CL fixes the warnings thrown by browser_tests:
[test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<ResourceLoadingHintsBrowserTestWithExperimentEnabled>
[test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<ResourceLoadingHintsBrowserTestWithExperimentDisabled>
[test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<ResourceLoadingHintsBrowserTestWithCoinFlipAlwaysHoldback>

Change-Id: Idf98ff3a53a377b34b3dfb5340faa379b45e13e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053230
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741202}

This CL adds instantiations for
PreviewsLitePageRedirectServerBrowserTestWithAlwaysHoldback and removes
the empty instantiation for CoinFlipHoldbackExperimentBrowserTest.

This CL fixes the warnings thrown by browser_tests:
[test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<PreviewsLitePageRedirectServerBrowserTestWithAlwaysHoldback>
[test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<CoinFlipHoldbackExperimentBrowserTest>

Change-Id: I3ac29a9f8971b8445a8d65e37b2eadc15f3efcd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054126
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741201}

Rulesets no longer have priorities. CompositeMatcher now returns the
highest priority rule from all its rulesets, instead of stopping after
the first ruleset.

Bug: 1026733
Change-Id: Ie77c4d1171bce374af4999339da7e73c018730e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026747
Commit-Queue: Theodore Dubois <tbodt@google.com>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Auto-Submit: Theodore Dubois <tbodt@google.com>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741200}

Apart from being used for metrics, we also base our branching logic on
UnmaskAuthFlowType in CreditCardAccessManager. so it should be declared
in CreditCardAccessManager instead of CreditCardFormEventLogger.

We use forward declaring to avoid cyclic imports.

Bug: 949269
Change-Id: Idc2a12beaac80f7b9e9fc496d66245c842eebcb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052325
Commit-Queue: Sujie Zhu <sujiezhu@google.com>
Reviewed-by: Manas Verma <manasverma@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741199}

This gives us offsets in the binary which enables us to run
symbolizer to get the function name/source line.

After this change stack looks like
#0 0x00558c83b8ec (foo.bar+0x2428eb)
#1 0x00558c7e9ac8 (foo.bar+0x1f0ac7)
#2 0x00558c7ef9b8 (foo.bar+0x1f69b7)

Bug: internal b/148287348
Change-Id: I654be3afaecd56a06d0339cf0d6cfc4669812c01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053251
Commit-Queue: Mohit Hotwani <hmohit@chromium.org>
Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741198}

Right now, there is a name contains_non_srgb_images that is used a
handful of times. The negative "non" complicates things when we have
to !contains_non_srgb_images.

This CL changes the name to contains_only_srgb_images and inverts
the behavior that depends on it.

Bug: 955158
Change-Id: I60799094a3f1aea2ffe9cfa58f7f396eb61d1c4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055407Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741197}

Specifically make it match the declaration order section:
https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.md?cl=head#Declaration_Order

BUG=none
TEST=none

Change-Id: I9380461c30c01d6c6d605764ac3638993dffd991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055048Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741196}

Bug: 1051558
Change-Id: I2748972508acb489f1a455a7dbd8617f26909dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052089
Commit-Queue: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741195}

TBR=robertma

Change-Id: I6847834e501645a3e5ad88daabe10e2c64672579
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055400
Commit-Queue: Luke Z <lpz@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741194}

This CL will not land until
https://chromium-review.googlesource.com/c/chromium/src/+/2051038
and
https://chromium-review.googlesource.com/c/chromium/src/+/2051164
lands.

Bug: 1049830
Change-Id: I064397122611884eb4e3ed22650c06dda1955191
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050097
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741193}

This reverts commit 0db01e1d.

Reason for revert: Appears to cause a compile failure and closed the tree

Original change's description:
> [Android] Move NfcSystemLevelSetting and modularize NFC code
> 
> NfcSystemLevelSetting is not a shared class used by multiple Settings
> screens, so move it out of the  org.chromium.chrome.browser.settings
> package to org.chromium.chrome.browser.nfc instead.
> 
> Since the classes in org.chromium.chrome.browser.nfc are fairly trivial
> to modularize, organize and build to a separate target in
> //chrome/browser/nfc as part of go/chrome-hoa efforts.
> 
> Bug: 1052056
> Change-Id: Ia402340b05596ad880f16aef9521003658c1e2a5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032785
> Commit-Queue: Natalie Chouinard <chouinard@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Reviewed-by: Theresa  <twellington@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Reviewed-by: Patrick Noland <pnoland@chromium.org>
> Reviewed-by: Peter Wen <wnwen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#741173}

TBR=yfriedman@chromium.org,wnwen@chromium.org,engedy@chromium.org,blundell@chromium.org,twellington@chromium.org,pnoland@chromium.org,chouinard@chromium.org

Change-Id: I4b89ae8773c38139c28ea7e1557217fc7abb98a6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1052056
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055589Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741192}

Follow up to CL 1949847, adding the data deps for host app for
* ios/web eg2_tests
* ios/showcase eg2_tests

Bug: 1019533
Change-Id: Idd71f6fe715356e1dd0100bae3361bce98e8fd76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042193
Commit-Queue: Jeff Yoon <jeffyoon@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741191}

This change introduces the otp option for credential manager.
The shape is as shown below, and is behind the SmsReceiver flag. This
implementation piggy backs on top of previous implemented version of
SMS Receiver API, now renamed to WebOTP API.

navigator.credentials.get({otp: {transport: ["sms"]}}).then((credential) => {
  let type = credential.type; // "otp"
  let id = credential.id; // otp string ex. "ABC1234"
});

Tested: locally, browsertests, wpt

Relevant resources:
Explainer: https://github.com/samuelgoto/WebOTPs/blob/master/explainer.md
Early discussions: https://github.com/whatwg/html/issues/3745#issuecomment-395327173
Discussed alternatives: https://github.com/samuelgoto/WebOTPs/blob/master/explainer.md#api-alternatives-considered
Design Doc for Sms Receiver API(V1): https://docs.google.com/document/d/1dB5UM9x8Ap2-bs6Xn0KnbC_B1KNLIUv4W05MunuXYh0/edit?usp=sharing
OT of Sms Receiver API(V1): https://developers.chrome.com/origintrials/#/view_trial/607985949695016961

Bug: 1045233
Change-Id: I4b68f08f2b26047809f6dcf84cbd82245e741f4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018331
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741190}

https://pdfium.googlesource.com/pdfium.git/+log/1c5647025500..951c1df3ce7d

git log 1c5647025500..951c1df3ce7d --date=short --first-parent --format='%ad %ae %s'
2020-02-13 tsepez@chromium.org Use Optional<> return in CheckStyleFromCaption().
2020-02-13 thestig@chromium.org Tidy CPDF_FormControl.
2020-02-13 thestig@chromium.org Fix regression with CheckStyleFromCaption().
2020-02-13 hikakar@microsoft.com Fix the rendering of scientific symbols correctly
2020-02-13 tsepez@chromium.org Tidy CFX_CSSSyntaxParser, part 2.

Created with:
  gclient setdep -r src/third_party/pdfium@951c1df3ce7d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I0fe7da575c1bb11c1fa5ffa9b431d41715a9ddb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055054Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#741189}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0715f3d5b5f1..c0ffd42151c6


Created with:
  gclient setdep -r src-internal@c0ffd42151c6

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1025256,chromium:783819
Tbr: jbudorick@google.com
Change-Id: If8418dfb19336fc7e244e1f48f47a0202993c651
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055366Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#741188}