- 19 Jul, 2019 40 commits
-
-
Sunny Sachanandani authored
Before this change ui::Compositor would scale the output color space according to the SDR brightness slider in Windows. This has the side effect of also scaling HDR content which can cause it to be easily washed out. With this change the SDR scaling factor is propagated to viz where GLRenderer applies it selectively to SDR content only. This change also removes the plumbing for blending color space since it can always be derived from the output color space. It also adds tests for verifying that the color transform in GLRenderer's shaders match what we expect, and enables the shader compile tests on Windows which were disabled in 2015 due to timeouts. Bug: 926173 Change-Id: I0932fbc7b66b24b7ea4d28157d084f4e2ef2762e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1694150Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#678939}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3d4dfa671d07..6a02f06dfd4e git log 3d4dfa671d07..6a02f06dfd4e --date=short --no-merges --format='%ad %ae %s' 2019-07-18 geofflang@chromium.org Implement EGL_ANGLE_create_context_backwards_compatible Created with: gclient setdep -r src/third_party/angle@6a02f06dfd4e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: None Change-Id: I9b00f6a3e987507555c2bc9df193c0972999b2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709829Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678938}
-
Luciano Pacheco authored
Division line got lost when we enabled MyFilesVolume flag which made MyFiles to have the default section. The division line is displayed when a new section starts in the directory tree. Change the test that checks for section to run with the flag enabled, code used when flag is disabled will be removed soon after M77 branch. Bug: 985415 Change-Id: I50957703426579b4203c47b88ac57f6b6c16dacd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709313 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#678937}
-
Shakti Sahu authored
If chrome is killed right away after user pauses a download, the download DB doesn't commit. So next time the download is resolved to a failed state and hence it doesnot show up on download home. A possible solution is to treat paused as immediate commit to the DB. Bug: 985464 Change-Id: I21487266e0ff24c329c850a33549c105e639b87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709334Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#678936}
-
Rose Garcia authored
Merged the basic text selection functionality from the text_input_manager.js to text_navigation_manager.js. Also added variables to keep track of the start and end node for the selection and and added functionality to hide the set selection end button is the start of the selection is not set and show it as soon as the start is set. Bug: 982004 Change-Id: I94b1e1dd3bf3636034276d0ee7db8c95a5711df1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707036Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Rose Garcia <rosalindag@google.com> Cr-Commit-Position: refs/heads/master@{#678935}
-
Miyoung Shin authored
This CL renames interfaces to mojom in //components/services/pdf_compositor. components/services/pdf_compositor/public/interfaces => components/services/pdf_compositor/public/mojom Bug: 806965 Change-Id: I23eb351c36d6b90cb9cffdb1a8c360ca83a76215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706455Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#678934}
-
David Bokan authored
Since https://crrev.com/863d211743b2d3e510b786f9aafceb111c4661cb all tests have been running with fractional scroll offsets enabled so these suites are now redundant. Bug: 414283 Change-Id: Iaa820923a94daae080fd60ee7f22a65b735dd2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709548Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#678933}
-
Vlad Tsyrklevich authored
On Android, there are 3 ways that crashpad can be invoked: libcrashpad_handler.so, CrashpadHandlerMain, or by JNI invocation. This change introduces a custom CrashpadHandlerMain symbol instead of using crashpad's default and also routes JNI invocation to use our custom CrashpadHandlerMain. This allows Chrome to specify custom user stream data sources. A follow-up change will refactor libcrashpad_handler.so so that it also uses CrashpadHandlerMain. CQ-DEPEND=CL:1708759 Bug: 973167 Change-Id: I08a8bbf7bc668589810bbcb216d1c1033df10225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707405 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#678932}
-
Miyoung Shin authored
This CL renames interfaces to mojom in //components/services/patch. components/services/patch/public/interfaces => components/services/patch/public/mojom Bug: 806965 Change-Id: I68a85abdf754de184f2b0c189e3fde8e02ea0ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708090Reviewed-by:
-
Aleks Totic authored
My initial attempt to enforce kLayoutClean instead of kAfterPerformLayout triggered 9 test failures. They all pass with kAfterPerformLayout. external/wpt/content-security-policy/navigate-to/anchor-navigation-always-allowed.html fast/block/positioning/absolute-layout-after-image-load.html fast/block/positioning/positioned-float-layout-after-image-load.html fast/dom/anchor-without-content.html fast/dom/HTMLAnchorElement/anchor-in-noscroll-iframe.html fast/dynamic/anchor-lock.html fast/events/node-event-anchor-lock.html fast/events/scroll-to-anchor-in-overflow-hidden.html fast/events/sequential-focus-navigation-starting-point.html Bug: 957026 Change-Id: I08dd91ff1ede07fb8671cba1649563b27d1a4495 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593403 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#678930}
-
Lei Zhang authored
https://chromium.googlesource.com/external/github.com/googlefonts/sfntly.git/+log/e24c73130c66..48312c98332a Created with: roll-dep src/third_party/sfntly/src TBR=drott@chromium.org BUG=960354 Change-Id: I7c7d982ba9648d04b05c6fe1407bf31920b08329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709003 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
Pavel Yatsuk authored
Width of location bar depends on mTabSwitcherState (ToolbarPhone.updateUnfocusedLocationBarLayoutParams). After toolbar transitions from TAB_SWITCHER to STATIC_TAB state, location bar width should be updated. Because toolbar view doesn't request layout at the end of transition, location bar is displayed incorrectly. This CL introduces requestLayout() at the end of tab switcher state transition. BUG=974745 R=twellington@chromium.org Change-Id: I884cc1bd3d2a04b4d2ec4c667b38dc40acace559 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1698941 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#678928}
-
Julian Watson authored
BUG=chromium:985398 Change-Id: I8e0820451df8b782451a1ea3986dab16e760ee18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709569 Auto-Submit: Julian Watson <juwa@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#678927}
-
Nigel Tao authored
There's no behavior change, other than removing a DVLOG(2) message. But calling AppListModelBuilder's (the superclass') RemoveApp makes the ExtensionAppModelBuilder consistent with the other AppListModelBuilder sub-classes' methods (which all call AppListModelBuilder::RemoveApp): - AppServiceAppModelBuilder::OnAppUpdate - ArcAppModelBuilder::RemoveApp - CrostiniAppModelBuilder::OnRegistryUpdated Change-Id: Ic77e49f3e30125031796d40b629550326275da92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705480Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#678926}
-
chrome://testrbpotter authored
- Add a test data source that serves files from chrome://test - Autogenerate HTML responses containing a single <script type="module"> with src set to a requested JS file at runtime. Request these responses by preloading chrome://test?module=JS_TEST_FILE.js - Remaining dependencies, other than mocha and mocha adapter, can be imported via the JS test module, instead of using |extraLibraries|. - Map requests for chrome://test URLs to the appropriate Web UI controller using a new webuiHost parameter for tests. Bug: 968804 Change-Id: I5b409bb54da5611be68fe590176edec3c7b668e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700294 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#678925}
-
Sadrul Habib Chowdhury authored
This is only called in SingleThreadProxy, whose override of this function always returns true. So the function is removed, and instead |SchedulerSettings::commit_to_active_tree| is directly turned on. Change-Id: Iad171ac199e7f2e0f63526b3f6ffe45325b1bdff Bug: none Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708049 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#678924}
-
Collin Baker authored
InstallableInkDropPainter::State contains all (and only) data necessary to paint the ink drop for a frame. It includes the current state of animations and is updated by InstallableInkDropAnimator. This removes the setters and getters on InstallableInkDropPainter in favor of directly modifying the state. Bug: 933384 Change-Id: I344cfb73953c562ffdd8e3a2b33a8ca81b8fd251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1697437 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#678923}
-
Lei Zhang authored
These GitHub repos no longer exist. The git admins added new mirrors for the repos' updated locations, so point the DEPS entries for sfntly and emoji-segmenter to the new locations. TBR=drott@chromim.org BUG=985448 Change-Id: Ie0af7f9285a0d9593721b05bdf123de26f3b9f5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708999Reviewed-by:
-
Min Qin authored
This CL allows us to record the connection info for all the download. We will need this information to do some speed improvement later. BUG=971366 Change-Id: I66bc6cb9bca1d2f70cde3731b39f70959faf761e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709350 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#678921}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a41edbef7e5c..42a883d13292 git log a41edbef7e5c..42a883d13292 --date=short --no-merges --format='%ad %ae %s' 2019-07-18 oysteine@google.com Updated tracing/ to be Python3 compatible Created with: gclient setdep -r src/third_party/catapult@42a883d13292 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Change-Id: Ie542473ef841fe35bf1891fd10f36fe444de6a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709520Reviewed-by:
-
Hajime Hoshi authored
This change fixes issues in the test infrastructure especially for BackFowardCache eviction. * Add DOMMessageQueue::RenderFrameDeleted: Before this change, EvalJs never returned when the frame was gone. After this change, EvalJs suspends the message loop and returns by observing RenderFrameDeleted. * Guarantee EvalJs is available even when the frame is frozen: This change just added a comment. In the current implementation, JavaScriptExecuteRequestForTests uses a kInternalIPC task runner, and this is not suspended even when the frame is frozen. We have decided to guarantee this behavior. * Add |world_id| parameter to JavaScriptExecuteRequestForTests: Before this change, EvalJs can call JavaScriptExecuteRequestForTests or JavaScriptExecuteRequestInIsolatedWorld. The latter is not available when the frame is frozen. Semantically, it was strange to call the latter for tests. This change removes the call of the latter and unifies them to JavaScriptExecuteRequestForTests. Design Doc: https://docs.google.com/document/d/1xCpbKDJ_a0APU_zLiEdxmCMxJZT8lJjgOlUlcEPcix4/edit?usp=sharing Bug: 980111 Change-Id: I1268935ecec9573dd0f469d89f934f0d6c1a7c16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703052Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#678919}
-
John Emau authored
This change marks that audit status text with role="status" which is an ARIA live region so screen readers will announce status changes. This meets the following WCAG success criteria 1.3.1 https://www.w3.org/WAI/WCAG21/quickref/#info-and-relationships 4.1.2 https://www.w3.org/WAI/WCAG21/quickref/#name-role-value 4.1.3 https://www.w3.org/WAI/WCAG21/quickref/#status-messages Bug: 963183 Change-Id: Ib0cef967fc4c8b22029eba7fb664cb516ca299e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701637 Commit-Queue: John Emau <johnemau@microsoft.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#678918}
-
Dominick Ng authored
These metrics have been stable for a long time and are not actively looked at. Removing them significantly cleans up the code base. BUG=976033 Change-Id: I6d06097de558eae53ec82c0286bd00106ed4fd65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705183Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Tiansong Cui authored
This is to avoid the issue of Connect/Disconnect pending forever. Bug: internal b/137599592 Test: cast_bluetooth_unittests, manual Change-Id: Ib23ec06580fbeaa73aea15ce94c0f2b2b1b39563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707558Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Tiansong Cui <tiansong@google.com> Cr-Commit-Position: refs/heads/master@{#678916}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/91d2c3938fa5..d4bb7bbe7fa6 Created with: gclient setdep -r src-internal@d4bb7bbe7fa6 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=pdr@google.com,grt@google.com Change-Id: Icbc815353a1de0d3854172f45af0038907600451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709622Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#678915}
-
Alexandre Courbot authored
This is a reland of 89762a9e. Reason for reland: The CL was incorrectly considered faulty of a regression. Bug: 985387 Original change's description: > media/gpu/v4l2: move kernel-specific structures out of public sight > > As we add support for the request API and upstream H264 structures, two > sets of V4L2 H264 controls/structures will have to coexist: > > - The ones we used so far for our own kernels and the config store, > - The official upstream ones, relying on request API. > > Thus we will need two versions of the V4L2H264Accelerator, each of which > will use a different set of kernel controls/structures. However these > kernel members share the same name and cannot be both included in the > same compilation unit: thus, we cannot have them included in any .h file > that the decoder will include, or name collision will occurs. > > The CL takes care of this last point my moving all kernel-specific > definitions and includes into a private structure inside > v4l2_h264_accelerator.cc. That way, none of the kernel members are > visible to files that include v4l2_h264_accelerator.h, and we won't have > any name collision as we introduce the other accelerator class. > > Bug: 917279 > Test: vdatest passes on veyron_minnie. > Change-Id: I1601fccd37624244b3351e647c1c7e75f526f4a2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705928 > Commit-Queue: Alexandre Courbot <acourbot@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678501} Bug: 917279 Change-Id: Ia3d211af7a804b821565613dab02aeae252c5890 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709312Reviewed-by:
Maggie Chen <magchen@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#678914}
-
Wez authored
This reverts commit b4339047. Reason for revert: This broke compilation on the fuchsia-*-cast bots. Original change's description: > [Fuchsia][EME] FuchsiaCdmFactory and ClearKey > > Add FuchsiaCdmFactory which is used to create ContentDecryptionModule on > Fuchsia. Currently it only creates AesDecryptor for ClearKey. > > Bug: 966191 > Test: https://simpl.info/eme/clearkey/ > Change-Id: I2787c5f44c2794987149975f7e9bc6d43dbe5cac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643977 > Reviewed-by: John Rummell <jrummell@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Commit-Queue: Yuchen Liu <yucliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#678907} TBR=xhwang@chromium.org,jrummell@chromium.org,sergeyu@chromium.org,yucliu@chromium.org Change-Id: I19f3e2feb0f8e08a020f386c7e6246fa69a6b5b3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 966191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709879Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#678913}
-
Jeremy Chinsen authored
Currently the draw_utils::Get*FillRect() functions refer to the separator between two vertically adjacent pages as a vertical separator. However, in pdf/pdf_engine.h it is referred to as a bottom separator. This is a more specific name and cannot be confused with a horizontal separator. This CL renames |vertical_separator| to |bottom_separator| in the draw_utils::Get*FillRect() functions and related constants in draw_utils/coordinates_unittest.cc. Change-Id: Ic088e4657e7056d86b9110d097e21d66186ff39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709636Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d10b29d3e267..e371cbd597d8 git log d10b29d3e267..e371cbd597d8 --date=short --no-merges --format='%ad %ae %s' 2019-07-18 eashanbhatt@google.com cros_test_unittest: Add FileList Unittest. Created with: gclient setdep -r src/third_party/chromite@e371cbd597d8 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I0ced0b5a230926d3da47cd4c747f1761f0ee0a98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709101Reviewed-by:
-
Jazz Xu authored
This CL create a basic Picture-in-Picture window when requesting pip. Bug: 964377 Change-Id: I3d40c9c744f4cc2f8d32f7b6e8f5587717cb095a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1677152 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#678910}
-
danakj authored
Painting only happens on a local frame that is in the tree, not on a provisional frame, so the Page will never be null. R=schenney@chromium.org Bug: 912193 Change-Id: I6b2ed8f82363e3d478132dd1b3aeae3c6305ec63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1704687 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
-
Stanley Hon authored
This change updates chromedriver to call focus.js if the element is a non-text element. This is specifically to fix some cases where browser based text editors use <body contenteditable=true> to create a text area of sorts. Before this change, but after https://crrev.com/674640, we were not resetting focus to the body element as it was considered already focused. This results in sendkeys being lost. We now call focus on any non-text elements, which still abides by the W3C SendKeys spec change incoming https://github.com/w3c/webdriver/issues/1430 as carat preservation behavior is only specified for text-type inputs. Additionally, this change also updates focus.js javascript to not move carat after a focus. Which was erroneously not updated in https://crrev.com/674640 Bug: chromedriver:3006 Change-Id: Ie4d4bab3eb45aec64a586cbfa786968601a06189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700475 Commit-Queue: Stanley Hon <stahon@microsoft.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#678908}
-
Yuchen Liu authored
Add FuchsiaCdmFactory which is used to create ContentDecryptionModule on Fuchsia. Currently it only creates AesDecryptor for ClearKey. Bug: 966191 Test: https://simpl.info/eme/clearkey/ Change-Id: I2787c5f44c2794987149975f7e9bc6d43dbe5cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1643977Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#678907}
-
Eric Roman authored
This boolean is unused (left over from http://crbug.com/928551). Change-Id: I029610c63bb7be039f840cb148d71a472a2e8e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709631Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#678906}
-
chrome://flagsXiao Yang authored
Bug: b/132908766 Change-Id: Iaf83f8f145a66d230d40e87d3e60dedc03d3a2ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708311 Commit-Queue: Xiao Yang <yanxiao@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#678905}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/ef2b7a6d5aed..8f36a0dbeb56 git log ef2b7a6d5aed..8f36a0dbeb56 --date=short --no-merges --format='%ad %ae %s' 2019-07-18 dneto@google.com Fix typo (#762) Created with: gclient setdep -r src/third_party/shaderc/src@8f36a0dbeb56 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: I95793767c169104e40744cf3e99f642c4063b027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709100Reviewed-by:
-
May Lippert authored
Previously, ARC would open a Chrome setting by loading a chrome://settings/foo url. This change makes ARC++ call into SettingsWindowManager::ShowOSSettings instead so that if the SplitSettings flag is on, the new OS settings surface will be shown. BUG=980331 TEST=Ran browser_tests and component_unittests. Used adb to trigger the ChromePage actions and verified that the chrome:// URLs are handled correctly with the #split-settings flag enabled and disabled. Change-Id: I545779e1ad79e32fe51c6b910671279b0f620851 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1700379Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: May Lippert <maybelle@chromium.org> Cr-Commit-Position: refs/heads/master@{#678903}
-
Joe Mason authored
R=avi@chromium.org Bug: 984212 Change-Id: I89b90f7a40d864cf0e0962916a8cb712195a34f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703331 Auto-Submit: Joe Mason <joenotcharles@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#678902}
-
John Lee authored
Having a binding of `selectable` forces us to always make an exception to it when targeting the [selectable] attribute in CSS. The exception was first introduced when we were using paper-radio-group, but since they were replaced with cr-radio-group, we no longer are forced to use the `selectable` name. Change-Id: I0aba6d5af9125c1a85a624e4aa9fe8ee1d553fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705030Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#678901}
-
Xiaocheng Hu authored
The caller in property_regisration.cc is the only caller that's not for interpolation. And this caller doesn't actually require the length array, but is only checking existence of relative length units. Hence, this patch changes this caller to check existence of relative length units directly, instead of computing a length array. This is a preparation patch for implementing min/max, because when comparison functions are involved, it's not always possible to convert a math expression into a length array. So we want to eliminate its callers when possible. Bug: 825895 Change-Id: I5d6ce28b8c595fbb5f5f5a44deb4d410b2a31cdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707654Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#678900}
-
