- 20 Oct, 2020 40 commits
-
-
Dylan Cutler authored
By guarding the instrumentation on the condition causing the DCHECK, we should be able to avoid the flakes that are happening due to http://crrev.com/c/2472528. Bug: 1139738 Change-Id: If9076e9dc446ecb83816978abe40ba14ffc63a8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485517 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#819047}
-
Peter Kasting authored
Bug: 772945 Change-Id: I0ade53423cfb13df5ac78914ab2a42b022567587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466819 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#819046}
-
Andrew Grieve authored
Depending on a java target from a native target doesn't do anything. Change-Id: I01e2b75f93c95219a02f23f3da4d3d7878726f8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488381 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#819045}
-
Karthika Pai authored
This is part of a migration that replaces the old <histogram-suffixes> syntax that was used to denote groups of histogram to the new patterned histogram syntax. Bug: 758782 Change-Id: Ide054101bd01cb64d697106fb5ec85b88137c1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476609Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Karthika Pai <karthikapai@google.com> Cr-Commit-Position: refs/heads/master@{#819044}
-
Finnur Thorarinsson authored
Bug: 1135551 Change-Id: Ie82e10e722e5c9cd5d417ed247c1e09de80cc52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485169 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#819043}
-
Liquan (Max) Gu authored
Context: DimmingDialog#show() could throw BadTokenException which is an Android internal programming error. To work around this issue, DimmingDialog#show() catch this exception and uses its return to indicate the failure to PaymentUiService. When the failure happens, close the PaymentRequest and report the error to the user. Bug: 1139441 Change-Id: Ia2a23b61b249c25d068e201be0a41b1d57ebf249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484043Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#819042}
-
Andrey Kosyakov authored
This triggers Fetch.requestPaused if we get a network error through URLLoader::OnComplete() instead of network response. Bug: b/170901677 Change-Id: Ieb1a7beafa627dd17b130494c6daba47948d57c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478143Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#819041}
-
Anders Hartvoll Ruud authored
Change-Id: Ic049d5d75cc399b98223ff469ad2c2c55ce231dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2484797Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#819040}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Iaf3ba962a4cec440d9740798f0663aef3a8b8709 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488001Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#819039}
-
Geoff Lang authored
Use GL_ANGLE_get_tex_level_parameter to detect when the texture about to be allocated for YUV copies in YUVToRGBConverter will be a no-op, avoiding potential re-allocation costs. Bug: chromium:1132514 Change-Id: I1fabe4e44f92009250a82318cffa962be65b3560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2476413Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819038}
-
Alex Turner authored
base::Bind is deprecated and should be replaced with more explicit calls. ThemeService only has a single use, which can be converted to the preferred BindOnce. Bug: 1007635 Change-Id: I83d7af39bbf6be73262c024972df6b3652574e19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487840Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#819037}
-
Clark DuVall authored
WebLayer needs its base_module_java to be in the base module to load correctly. Bug: 1126301 Change-Id: I0dc89a897922c33695e8e0ede4be8b849ae7dffc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487821 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#819036}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/13fa34606b78..c49da0b5192d 2020-10-20 mtklein@google.com upstream cl/337571894 with tweaks 2020-10-20 robertphillips@google.com Pull the triangulating path renderer's shape-space triangulation into a helper method 2020-10-20 fmalita@chromium.org [svg] Parse text attributes 2020-10-20 johnstiles@google.com Clear the `builtin` status of SkSL nodes when they are cloned. 2020-10-20 adlai@google.com Almost remove GrContext 2020-10-20 kjlubick@google.com [canvaskit] Make build docs more clear 2020-10-20 jmbetancourt@google.com add new DemoActivity to showcase SkottieView xml loading and surface view backing 2020-10-20 johnstiles@google.com Fix frexp support in Metal. 2020-10-20 kjlubick@google.com [canvaskit] Add task driver for running GMs on WASM/WebGL. 2020-10-20 johnstiles@google.com Sort SkSL gencode enums by value, not name. 2020-10-20 michaelludwig@google.com Allow kNoCropRect to be referenced 2020-10-20 mtklein@google.com allow early returns 2020-10-20 robertphillips@google.com Better encapsulate creation & usage of triangulating path renderer's key data 2020-10-20 johnstiles@google.com Add a fBuiltin flag to FunctionDefinition. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408,chromium:1139725 Tbr: egdaniel@google.com Change-Id: I6db45e1c51d8fc599c94100d10b197d86c3cc92e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487172Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819035}
-
Dom Schulz authored
Delete the pwa.html and os-settings-manifest.json files, and install via a WebApplicationInfo. Bug: 1085274 Bug: 1126752 Change-Id: Ie269b46771daa7f302821491735e42b53e7bfc2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475310 Commit-Queue: Dominic Schulz <dominicschulz@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Auto-Submit: Dominic Schulz <dominicschulz@google.com> Cr-Commit-Position: refs/heads/master@{#819034}
-
Xinghui Lu authored
Move AsyncFeedbackSource.java, FeedbackSource.java and ScreenshotSource.java from chrome/android to chrome/browser/feedback/android. More classes will be moved in a future CL. Bug: 1117343 Change-Id: I618c2e0e46a265098e121a204f987bba97a674c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477595 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#819033}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib8228bad4bdd8b84d907bfab48f389311febbdcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487804Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819032}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 88-4280.20-1603104419-benchmark-88.0.4296.0-r1 to 88-4280.20-1603104419-benchmark-88.0.4296.6-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Id59b73781d3698ec984322455e60e8c44a88ad46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487806Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819031}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cdba9badd3b3..1227ffd79585 2020-10-20 alcastano@google.com Add isReportOnly field to CSP Issue messages in CDP 2020-10-20 almuthanna@google.com Add Profiling E2E test 2020-10-20 sigurds@chromium.org Add more logging to the inspector back-end 2020-10-20 tvanderlippe@chromium.org Revert "Use Markdown for Mixed Content related messages in the Issue tab" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1125465,chromium:1139223,chromium:1140504 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I34335623944fba9c0746912464978bff50ab20c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487174Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819030}
-
Peter Kasting authored
Bug: 772945 Change-Id: Ibfb794373df3f30e88c645ae7678cd3ccb3f9fdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485040Reviewed-by:
Mohsen Izadi <mohsen@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#819029}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e6f794f1dc5d..be6747613d78 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic887a7ce0c41fd73dd14aae9c5bf8a0cbacea3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487150Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819028}
-
Mike Dougherty authored
The Find in Page feature implementation has moved to ios/web/public/find_in_page. This code is unused and can be removed. Bug: 487804 , 949651, 996324 Change-Id: I55bfe528d428085f4f59de80d5bfb56130cabfa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480887 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#819027}
-
ssid authored
Also remove the legacy buffer limits added to the config. Change-Id: I375d3955e5d724c04b4b726f50eb227869680fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485604Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#819026}
-
Karandeep Bhatia authored
FlatBufferBuilder now supports returning the released data buffer. Modify FlatRulesetIndexer to use it. This is more safer and ergonomical as the lifetime of the buffer is not tied to FlatRulesetIndexer now. BUG=1043200 Change-Id: I983531ebd93820c9c28876c424302135e96651e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485841 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Auto-Submit: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#819025}
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 88-4280.20-1603100572-benchmark-88.0.4296.0-r1 to 88-4280.20-1603100572-benchmark-88.0.4296.6-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia9f4d7bbf4f1c50df94d467d0d51ddb43c80d5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487944Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819024}
-
yiyix authored
Add more wpt tests for textLetterSpacing and textWordSpacing. In this new test, I use width to show how setting letter spacing and word spacing can change the length of text in canvas. Bug: 1137055 Change-Id: I707c6f4fe8a79ff3ff6d19bb98dc3d9573a8b3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485480Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#819023}
-
George Steel authored
Begin development on compositing transform animations with relative keyframes (with translate operations using percents), eliminating the restriction that keyframes nust be absolute. This takes the approach of converting keyframes for the compositor by evaluating lengths on the current box size of the element under animation. Invalidation to deal with changes in box size will be added in future patches before the CompositeRelativeKeyframes flag is enabled. Add a virtual test suite to run transform animation tests with using this code path. Design doc: https://docs.google.com/document/d/1zgr5CHRMpvlqodn1e0eM9J3MjL2eEMfAHrHsZUK7gMM/ Bug: 389359 Change-Id: I9ad764e1206acf7a599e32b28f35626df186747d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477673 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#819022}
-
Philip Rogers authored
This patch adds a metric for when the "root" color-scheme contains dark. This can be true via either a meta color-scheme tag or CSS: 1. <meta name="color-scheme" content="dark"> 2. :root { color-scheme: dark; } Bug: 1131028 Change-Id: I8b0ba8374bef277ce36c1bef58b7b90d432ab65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468077 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#819021}
-
Kevin McNee authored
Input largely operates in terms of RenderWidgetHosts which is what these tests actually use. We remove some uses of RenderViewHost for clarity. Bug: None Change-Id: Ifd235d21379f0f69190125a93f1b23a2c2129fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485640Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#819020}
-
Henrique Nakashima authored
This is a reland of 7002dd78 Original change's description: > Log tab switch latency histograms through RecordHistogram > > Remove JNI calls that do only that and record through the Java API. > > Bug: 1139081 > Change-Id: I6f22bca96f8e3bd2de125d6e302d12eadb5e4301 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473042 > Reviewed-by: David Trainor <dtrainor@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#818043} Bug: 1139081 Change-Id: I61e6b53b2acca3bd70555fceed1c2da7de0ce0a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485541Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#819019}
-
Caitlin Fischer authored
Bug: 1126640, 953480 Change-Id: I2ec62130c4fbe6d2160d8d3ee57e530111b0bce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485515Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Cr-Commit-Position: refs/heads/master@{#819018}
-
Elly Fong-Jones authored
Currently clients of the SetCan{Maximize,Minimize,Resize} setters need to remember to call Widget::OnSizeConstraintsChanged afterwards, which is obviously dangerous. Just call it from inside the setters, and then we can stop calling it everywhere else. OnSizeConstraintsChanged is idempotent (though a bit expensive) so temporarily having two calls to it won't hurt anything. This change also fixes ViewEventTestBase::GetWidget() to tolerate being called early in the object's lifecycle. Bug: 1075649 Change-Id: I11dcf39e6b1ad86f8d5f5adfa973e5fd339dd36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485195 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#819017}
-
Patrick Noland authored
This lets us easily wire necessary dependencies to its constructor, which then lets us remove several LocationBar interface methods. ToolbarPhone/ToolbarTablet now have their coordinator set rather than instantiating it themselves. Change-Id: I8983b9c898c5676c1bdc7034de9cde2bb5de351a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472467 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
who/bttk <bttk@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#819016}
-
Anthony Cui authored
TranslateUtils.canTranslateCurrentTab performs URL checks that overlap with TranslateService::IsTranslatableURL. Consolidate the logic in these two places. Some of these checks are Android-specific. However, it is still preferable to move them to a single, shared location. This is also important for supporting logging of manual translate availability from menus, which is added in this change https://chromium-review.googlesource.com/c/chromium/src/+/2468796 Bug: 1127094 Change-Id: Ifd626f2f9c7d6c7c929e36d07c420f87314d8bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2444549 Commit-Queue: Anthony Cui <cuianthony@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#819015}
-
Tarun Bansal authored
Add flag for manual testing. Bug: 1115259 Change-Id: I1fad3de254c8504edcb80659caf72c97beb2d69b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485565Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#819014}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/de50d966..e874380d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I33b0ba8c02b51d551ff8440aecd0049817821d3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487360Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819013}
-
Liquan (Max) Gu authored
Bug: 1137006 Change-Id: Ib1401949fe60d0c3b6b459bdd8507bea983c40c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485641Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#819012}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1d0e7b6bbe17..7bc3356fbcb9 2020-10-20 saza@webrtc.org AEC3: Stop reporting obsolete metrics If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1140067,chromium:1140071,chromium:1140073 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie6289a90a246c1f9ab9aabd42a11d9fbf35d93af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487169Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#819011}
-
Benoit Lize authored
mallinfo() is used by MallocDumpProvider, and ProcessMemoryMetrics. The first one can also use the extended API of PartitionAlloc to report data, but the second one uses mallinfo(). To support both, implement mallinfo(). Bug: 998048 Change-Id: I9d71cd3a7bbf5c766cfc3771907c2f51ac17cace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426708Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#819010}
-
manukh authored
Adds configs for: - entity latency - dynamic max suggest - URL bubble max suggest Change-Id: Ideaf90a3ca9ffcdc05f7a89f2a2ddf9f755f72d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486398Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#819009}
-
Jose Dapena Paz authored
Fix GCC compilation issue: ../../components/media_message_center/media_notification_item.h:69:22: error: declaration of ‘virtual media_message_center::SourceType media_message_center::MediaNotificationItem::SourceType()’ changes meaning of ‘SourceType’ [-fpermissive] 69 | virtual SourceType SourceType() = 0; | ^~~~~~~~~~ ../../components/media_message_center/media_notification_item.h:19:12: note: ‘SourceType’ declared here as ‘enum class media_message_center::SourceType’ 19 | enum class SourceType { | ^~~~~~~~~~ To avoid the type clash, add explicit namespace in the declaration of the return type. Bug: 819294 Change-Id: I2d1e2f1feb5ddcb210c7df7a3762ae962d90167e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485175Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: José Dapena Paz <jdapena@igalia.com> Cr-Commit-Position: refs/heads/master@{#819008}
-