GitLab

Returning a failure in the Direct Composition functions will trigger a
context lost in GL Renderer and Direct Composition will be reinitialized.
If the same Direct Composition function keeps failing, it will cause an
infinity loop of restart and the result is a blank screen or a blank
video.

If a DXGI or D3D11 call fails due to out of memory or a bad graphics
driver, most likely the same call will fail next time. We should disable
Direct Composition or Overlay to prevent the same failure.

Bug: 1091958
Change-Id: I3ac7d9bac0fdf5938302583b072e7bda5839d2c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247390
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781408}

Check existing certs in UpdateOneCert to avoid creating a worker
for certificate profile that already has a provisioned certificate.
Also add a unit test for UpdateOneCert method.

Bug: 1045895
Test: CertProvisioning*
Change-Id: I284bec0c90766673b6ba3a2c1ac69f28303258ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245150
Commit-Queue: Michael Ershov <miersh@google.com>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781407}

The ServiceWorker API is changing, so adding a quick test to ensure
nothing regresses.

TBR=ryansturm@chromium.org

Change-Id: I4d4364ccde83e5b0c44a87965abb3bfd44004a0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261033Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781406}

Page based scrolling is used in three situations:

1. PageUp/PageDown keys
2. Main thread scrollbar scrolling using the track
3. Wheel when a scroll-by-page setting is enabled

The first two are explicitly main thread only. The last use is a niche
use case and was simply never implemented in the compositor. With recent
additions related to percent based scrolling this becomes trivial to
handle so this CL allows LayerTreeHostImpl to handle scrolls using a
page granularity.

Bug: 1082589
Change-Id: I35fc7c4fa3c57ba2c8c86c89fed314c516f8b4f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241131
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Rahul Arakeri <arakeri@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#781405}

Bug: 159382866
Test: covered by unittests.
Change-Id: I47295da3c1aacd00b649a5175d5f01eccd8c9e66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253363
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Jeroen Dhollander <jeroendh@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781404}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/dfc4c1d4..39d00b97

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Id6861b40cffcc7ed86bb948d10005b3c49568c73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260853Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781403}

... instead of WebMediaStreamTrack.

This is part of the effort to reduce the needless use of
public Blink APIs (wrappers) within renderer/modules.

BUG=704136
R=guidou@chromium.org

Change-Id: I0f59e454a8abd6f9674b6335a588594c2d2dd265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257422Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#781402}

Old UI:
https://screenshot.googleplex.com/1twKi3vamGm

New UI:
https://screenshot.googleplex.com/5o2mTDpZQyn

New UI works with long string:
https://screenshot.googleplex.com/M3yV8qPdsbL

Change-Id: Ic7fdb33f4e3d8f091ddef36a4ca6e5bea57e4fee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255500Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Andre Le <leandre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781401}

run_web_tests.py --iterations=100 [--exit-after-n-failures=1] is very
useful for running a slightly flaky test [until it fails]. Previously
results.html failed to display actual and expected results for a test
with multiple results like "PASS PASS PASS PASS PASS FAIL".

Now when collecting artifacts of a test, if the normal loop fails to
find any artifact, we'll use the last found artifacts.

Change-Id: I6de2be6eafcd0b0295b21df5b8d69866f55b9c0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259514Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781400}

The core use case being addressed is the case where a user connects
to a CrOS device in Kiosk mode which is used as signage (no user
interaction).  In this scenario, the mouse cursor becomes visible when
we inject mouse input and remains visible after we disconnect.

This change checks the cursor visibility prior to any input injection
and then hides the cursor when the input injector is torn down.


Bug: 1072886
Change-Id: I7e534ffbb3a078b0f90f5d79bdf2212fb2769f11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258780
Commit-Queue: Joe Downing <joedow@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Auto-Submit: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781399}

Currently, the browser controls height change animations are driven in
browser_controls_offset_manager.cc if we have web contents. For other
cases, we simply don't animate the browser controls.

This CL adds animations for the browser controls for cases where we
can't drive the animation in native, e.g. NTP, tab switcher. These
browser side animations are run in ChromeFullscreenManager, similar to
the existing browser-driven-show-animation.

We will animate the changing margins and layouts in a separate CL.

Bug: 1075640
Change-Id: I4a90479e6ff6a350b72bfb5a83fc9c10e6aaf133
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247244
Commit-Queue: Sinan Sahin <sinansahin@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781398}

InstallStageTracker::Observer::OnExtensionInstallationFailed may remove
the observers and thus change the object. Immediately after calling
this method, OnExtensionDataChangedForTesting method is called which
might result in a crash. The observers list is traversed again after
calling the method OnExtensionInstallationFailed so that only
the updated observers are used.

Bug: 1097700
Change-Id: I0c0721179d8b737e14748b2d5965926ad6a1bf88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257318
Commit-Queue: Swapnil Gupta <swapnilgupta@google.com>
Reviewed-by: Oleg Davydov <burunduk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781397}

bartekn@ is planning to remove custom hash support for LinkedHashSet.
To unblock him, use HashCountedSet for DocumentPolicyFeatureSet
for now.

Bug: 1069021
Change-Id: I94218dbd29eb59f26d67bdd52d990f21a7af26ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259484
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781396}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/87616f7ce2ea..fd20fafa8ec1

$ git log 87616f7ce..fd20fafa8 --date=short --no-merges --format='%ad %ae %s'
2020-06-22 brucedawson Use clang-cl to preprocess nacl assembly files
2020-06-03 fabiansommer Change ARM trybot up/download directory
2020-05-27 fabiansommer Rename CI ARM hw bots
2020-04-27 fabiansommer Enable debug build mode on debug builders.

Created with:
  roll-dep src/native_client

Bug: chromium:1097510
Change-Id: I56fac21b50062f726b8f8309999c678f0f097fd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260933
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781395}

- Change parseUrlParams_() implementation to use URLSearchParams,
  instead of manually extracting key/value pairs from the URL.
- Replace getUiUrlParams() with shouldShowToolbar(). The former was
  too generic for its current usage. It can be re-generalized if/when
  that is actually needed.
- Add some missing JS externs for OpenPDFParamsParser in pending.js
  externs, until the JS compiler externs are updated accordingly.

Bug: None
Change-Id: I3ce47d06332a61db5be93bd86f032d2db6e78c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254716
Commit-Queue: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781394}

Right now, a policy being "deprecated" can mean one of 2 things:

  (a) The policy still works, but it'll get removed soon.  (deprecated)
  (b) The policy doesn't work anymore.  (removed)

Right now, They both get placed in a "Deprecated Policies" group, in the
ADM/ADMX files.

This patch creates a new group: "Removed Policies". The old group is
for (a), and the new group is for (b).

Bug: 1086425
Change-Id: I728f78f52e114340cadb166b62d54f9bb43c3efd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255139
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781393}

https://github.com/WICG/native-file-system/pull/185 changed the
API surface exposed to websites for showing file/directory pickers.
This CL implements those changes.

Bug: 1096225
Change-Id: Idd17d7383c959f90cf5cecf729ad26e65af7ce34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248488
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781392}

Change-Id: I9ef48728586e7809ec38af243b21bc0393d30822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258774Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Hongbo Song <hbsong@google.com>
Cr-Commit-Position: refs/heads/master@{#781391}

Cleanup all usages of test fixture member access from tests. They should
go through member methods instead of being accessed directly.

Change-Id: I7b8730d470ae051a2ca4e4b9768fc16ac84179ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255079
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Anastasiia N <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781390}

This change also factors out functionality from CastActivityRecordTest
into ActivityRecordTestBase so it can be shared.

Bug: b/155649299
Change-Id: I84ff6c2527e7bcb0da53ffa86078f1c09278b6cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244125
Auto-Submit: John Williams <jrw@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: John Williams <jrw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781389}

This does the conversion of content/public tests. As part of this
transition, Criteria.equals is being replaced in tests to allow
its removal.

BUG=1071247

Change-Id: I27f336db7e66e01834945b7fa1df073093641b18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255658
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781388}

Neglected in the initial wiring up of infobars in WebLayer.

Bug: 1093846
Change-Id: I5fff123f3948c930ec78cfe80de3ed31785d287b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257218Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781387}

Currently, we have three places where we compute requests' referrers,
nominally according to [1, Algorithm 8.1].

This change makes a couple alterations to
SecurityPolicy::GenerateReferrer (one of the places) to bring it in line
with the behavior in content::Referrer::SanitizeForRequest (another
implementation of the algorithm). After this change,
SecurityPolicy::GenerateReferrer will:
- truncate requests with referrers longer than 4096 bytes to the
initiating origin, as specified in [1, Alg. 8.1, step 6];
- strip URLs for use as referrers as part of the referrer generation
process [step 4]; and
- explicitly return "no referrer" when given an invalid URL (motivation:
this will align the behavior with the other two implementations of the
algorithm once they also strip URLs for use as referrers as part of the
referrer generation process, because this is how GURL::GetAsReferrer
behaves).

In order to implement the second of these in a manner consistent with
the non-Blink code, this change alters KURL's referrer stripping logic
to move from "return a default value if the URL is not http(s)" to
"return a default value if the scheme is not suitable for use in a
referrer", bringing it in line with GURL::GetAsReferrer.

[1]:
https://w3c.github.io/webappsec-referrer-policy/#parse-referrer-policy-from-header

Bug: 1094526
Change-Id: I515fd9e832e99c1fdd2ca207560b865d06edc39c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246987Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: David Van Cleve <davidvc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781386}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/bf296fb827fe..fc5464c325c9

2020-06-23 ahassani@chromium.org cros_update: Remove quick provision code
2020-06-23 ahassani@chromium.org auto_updater_transfer: Fix issue with GetPayloadSize()
2020-06-23 ahassani@chromium.org auto_updater_transfer: Fix issues with ssh fallback
2020-06-22 pprabhu@chromium.org commands: Delete dead code
2020-06-22 pprabhu@chromium.org config: Introduce constants for quota accounts
2020-06-22 pprabhu@chromium.org config: Delete dead code
2020-06-22 pprabhu@chromium.org config: Delete unused constants
2020-06-22 pprabhu@chromium.org config: Update default HWTest pool and quota_account
2020-06-22 pprabhu@chromium.org config: Explicitly set Skylab quota account for tryjobs

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Tbr: chrome-os-gardeners@google.com
Change-Id: I41d50d42b062041b1ede751fba7f1b4745842fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260832Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781385}

Callers can create MeasurementRequest objects to perform per-frame
memory measurements at different frequencies. The decorator is
automatically created when the first request is issued.

Bug: 1080672
Change-Id: I20ac9d24ffceb6000ff595d4536a6d3daefa7d9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243444
Commit-Queue: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781384}

We have finished diagnosing crbug.com/1086968 about dirty layout
after layout for custom scrollbars and legacy flexboxes and fixed
several bugs. Now change the CHECKs to DCHECKs before M85 branch.

Bug: 1093281, 1086968
Change-Id: I6cd29c4d38f11f300b91088bb937df04d086e2f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261092
Auto-Submit: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781383}

Following moving rootId to a UserData object
(CriticalPersistedTabData) it is now necessary to check if
the Tab is destroyed before attempting to access root id
from the CriticalPersistedTabData object. Previously root
id was available right up until the object no longer
existed.

Bug: 1097009
Change-Id: I78ca61cdff2ccc3275a48425a76514790c59daac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257500Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781382}

Make sure |line| is a string and not a bytes object.

Bug: 941669
Change-Id: Ief610b426326f849b49353c5cbce68deb0cd4b3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260872
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781381}

According to PH w3 spec the "details" input of the changePaymentMethod
should be optional[1]. Even though payment_request_event.idl honors the
spec[2],the blink implementation and the mojom file treat "details"
as a mandatory field. This cl fixes the issue.


Test coverage:
I reproduced the bug by removing the "details" field from
changePaymentMethod call[3]; The following two tests pass only after
applying the fix in this cl and fail without it:
MerchantResponse/PaymentHandlerChangePaymentMethodTest.Test/0
MerchantResponse/PaymentHandlerChangePaymentMethodTest.Test/1

[1]https://w3c.github.io/payment-handler/#the-paymentrequestevent
[2]https://cs.chromium.org/chromium/src/third_party/blink/renderer/modules/payments/payment_request_event.idl?l=23
[3]https://chromium-review.googlesource.com/c/chromium/src/+/2254084/2/components/test/data/payments/change_payment_method_app.js#32

Bug: 1083193
Change-Id: Ia479401d021be2d110a7a7ad4fe652d2eae4d88c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254084
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781380}

MessagingUtilTest.TestMaximumMessageSize exercises our extension message
limits by trying to send large messages. Unfortunately, large messages
take a long time to construct, which, it appears, can result in the test
timing out.

The test currently runs two virtually-identical cases (a massive string
and a massive JSON-ified string). Remove the JSON-ified case to cut the
effective test duration in half.

Bug: 1093817
Change-Id: I597b8ad1c66fb894c8b1520230c779aa70107c6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259473Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781379}

This TODO isn't going to be completed, so deleting it from source.

Bug: 1015461
Change-Id: I5dbfbbf9751cd8fb089614138d5759a668f08523
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258682Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Jordan Bayles <jophba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781378}

https://skia.googlesource.com/skia.git/+log/2bf27f21f8d1..2eb3c17ba30a

2020-06-23 dmazzoni@chromium.org Add appendNodeIdArray to avoid code duplication.
2020-06-23 jmbetancourt@google.com Reland the new module for skia lib for g3
2020-06-23 kjlubick@google.com [canvaskit] Fix CPU build
2020-06-23 brianosman@google.com Remove GPU read-back logic in SkSpecialImage
2020-06-23 robertphillips@google.com Update image_from_yuv_textures GM for *ooprddl configs
2020-06-23 fmalita@google.com Revert "[skottie] skottie_tool updates"
2020-06-23 fmalita@chromium.org [skrive] Parse color paints

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC lovisolo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:607777
Tbr: lovisolo@google.com
Change-Id: I79fce18802108a47219aa0049b6c16f2ef3b6038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260525Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#781377}

This CL addresses the two potential reasons that
ChromeActivity#getCompositorViewHolder() == null when
SplashController#hideSplash() is called
Reason #1: ChromeActivity#onInitialLayoutInflationComplete() has not yet
been called
Reason #2: SplashController#hideSplash() is called after
ChromeActivity#onDestroy()

BUG=1096171

Change-Id: If46daf4bcf007fab26c6c9066d355b3c4506eb38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259483
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781376}

The modern codepaths within the sync engine have barely any special-
handling for bookmarks. The relevant bits already have unit-test
coverage, such as in ModelTypeWorkerTest, and most bookmark-related
logic lives in components/sync_bookmarks, where there is good test
coverage.

Besides that, most scenarios are also covered by sync integration
tests for bookmarks.

Change-Id: Ife306e8924fabaef518400ed0b210fcfdaaaea5a
Bug: 923287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259859Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781375}

Change-Id: I2d1d7835f1434c665f6382c0da33e0eacee9b7da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259698Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781374}

Based on go/respectful-code, modify blacklist to blocklist.

FYI: https://tools.ietf.org/id/draft-knodel-terminology-00.html

BUG=1097644

Change-Id: I271542cc8103e2488d7d27b7df805d020e70ede3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256113Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781373}

This patch adds a use counter for each value of content visibility
other than the default.

R=chrishtr@chromium.org

Fixed: 1096676
Change-Id: I71dcb549b04b249f701bcc0b5b68f966052f0c8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257540
Commit-Queue: vmpstr <vmpstr@chromium.org>
Auto-Submit: vmpstr <vmpstr@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781372}

The ClearSyncedData feature has been enabled by default.

Bug: 1005509
Change-Id: I799683d3cd1e9194d66751c1d4ac52f578949f04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260732Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781371}

Split InitializeAccountManager utility method into two methods -
InitializeAccountManager and InitializeAccountManagerAsync - to clearly
communicate the contract of these methods.

Change-Id: Ifbc16205cea0ba37ab3d7cc5d8be287510a07082
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255358
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Anastasiia N <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781370}

Also fix files that failed to do IWYU and stopped building as a result.

Bug: 1010217
Change-Id: I6ab8e88728d33853ea62426046ecc1f92430cb28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257994Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#781369}